Re: [VOTE] Release Apache Sling Scripting JavaScript 3.1.4
+1 Carsten Am 15.10.2020 um 20:42 schrieb Eric Norman: Hi, We solved 2 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12346587 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2356/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2356 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Resolved] (SLING-9773) Starter project does not build with the enforced minimum version of maven
[ https://issues.apache.org/jira/browse/SLING-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-9773. Resolution: Fixed > Starter project does not build with the enforced minimum version of maven > - > > Key: SLING-9773 > URL: https://issues.apache.org/jira/browse/SLING-9773 > Project: Sling > Issue Type: Bug >Reporter: Eric Norman >Assignee: Konrad Windszus >Priority: Major > Fix For: Starter 12 > > > The org-apache-sling-starter project does not build with maven 3.3.9 which > is the current enforcer minimum version. > The bnd-indexer-maven-plugin doesn't appear to work with maven 3.3.9 even > with the skip flag set to true. It reports lots of nasty exceptions and > fails the build. > I did some additional testing and it looks like maven version 3.5.0 is the > minimum version that seems to work. > Do we need to enforce/change the minimum maven version required to build > sling to something newer than 3.3.9? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9773) Starter project does not build with the enforced minimum version of maven
[ https://issues.apache.org/jira/browse/SLING-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-9773: --- Fix Version/s: (was: Starter 12) > Starter project does not build with the enforced minimum version of maven > - > > Key: SLING-9773 > URL: https://issues.apache.org/jira/browse/SLING-9773 > Project: Sling > Issue Type: Bug >Reporter: Eric Norman >Assignee: Konrad Windszus >Priority: Major > > The org-apache-sling-starter project does not build with maven 3.3.9 which > is the current enforcer minimum version. > The bnd-indexer-maven-plugin doesn't appear to work with maven 3.3.9 even > with the skip flag set to true. It reports lots of nasty exceptions and > fails the build. > I did some additional testing and it looks like maven version 3.5.0 is the > minimum version that seems to work. > Do we need to enforce/change the minimum maven version required to build > sling to something newer than 3.3.9? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9773) Starter project does not build with the enforced minimum version of maven
[ https://issues.apache.org/jira/browse/SLING-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-9773: --- Fix Version/s: Starter 12 > Starter project does not build with the enforced minimum version of maven > - > > Key: SLING-9773 > URL: https://issues.apache.org/jira/browse/SLING-9773 > Project: Sling > Issue Type: Bug >Reporter: Eric Norman >Assignee: Konrad Windszus >Priority: Major > Fix For: Starter 12 > > > The org-apache-sling-starter project does not build with maven 3.3.9 which > is the current enforcer minimum version. > The bnd-indexer-maven-plugin doesn't appear to work with maven 3.3.9 even > with the skip flag set to true. It reports lots of nasty exceptions and > fails the build. > I did some additional testing and it looks like maven version 3.5.0 is the > minimum version that seems to work. > Do we need to enforce/change the minimum maven version required to build > sling to something newer than 3.3.9? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9773) Starter project does not build with the enforced minimum version of maven
[ https://issues.apache.org/jira/browse/SLING-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215216#comment-17215216 ] Konrad Windszus commented on SLING-9773: Fixed with https://github.com/apache/sling-org-apache-sling-starter/commit/9c56282b7d4ce65656b7116d0fb28e9795761a8b. The new bnd version 5.2.0 restores compatibility with Maven 3.1.1 and above. > Starter project does not build with the enforced minimum version of maven > - > > Key: SLING-9773 > URL: https://issues.apache.org/jira/browse/SLING-9773 > Project: Sling > Issue Type: Bug >Reporter: Eric Norman >Assignee: Konrad Windszus >Priority: Major > Fix For: Starter 12 > > > The org-apache-sling-starter project does not build with maven 3.3.9 which > is the current enforcer minimum version. > The bnd-indexer-maven-plugin doesn't appear to work with maven 3.3.9 even > with the skip flag set to true. It reports lots of nasty exceptions and > fails the build. > I did some additional testing and it looks like maven version 3.5.0 is the > minimum version that seems to work. > Do we need to enforce/change the minimum maven version required to build > sling to something newer than 3.3.9? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9807) AuthorizablePrivilegesInfo is checking for too many privileges for some of the operations
[ https://issues.apache.org/jira/browse/SLING-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman updated SLING-9807: --- Description: canRemove - should require only these privileges: # jcr:read # rep:userManagement canUpdateGroupMembers - should require only these privileges: # jcr:read # rep:userManagement canUpdateProperties - should require only these privileges: * when adding a new (non-nested) property ## rep:addProperties * when adding a new nested property ## rep:addProperties ## jcr:addChildNodes * when altering an existing property ## rep:alterProperties * when removing a property ## rep:removeProperties For canRemove and canUpdateGroupMembers this can be solved by reducing the set of privileges it is checking for. For canUpdateProperties, a new variation of that method should be introduced where the user can pass in the types of property updates that are expected to be needed. was: canRemove - should require only these privileges: # jcr:read # rep:userManagement canUpdateGroupMembers - should require only these privileges: # jcr:read # rep:userManagement canUpdateProperties - should require only these privileges: * when adding a new (non-nested) property ## rep:addProperties * when adding a new nested property ## rep:addProperties ## jcr:addChildNodes * when altering an existing property ## rep:alterProperties * when removing a property ## rep:removeProperties For canRemove and canUpdateGroupMembers this can be solved by reducing the set of privileges it is checking for. For canUpdateProperties, a new variation of that method should be introduced where the user can pass in the types of property updates are expected to be needed. > AuthorizablePrivilegesInfo is checking for too many privileges for some of > the operations > - > > Key: SLING-9807 > URL: https://issues.apache.org/jira/browse/SLING-9807 > Project: Sling > Issue Type: Bug >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: JCR Jackrabbit User Manager 2.2.12 > > > canRemove - should require only these privileges: > # jcr:read > # rep:userManagement > canUpdateGroupMembers - should require only these privileges: > # jcr:read > # rep:userManagement > canUpdateProperties - should require only these privileges: > * when adding a new (non-nested) property > ## rep:addProperties > * when adding a new nested property > ## rep:addProperties > ## jcr:addChildNodes > * when altering an existing property > ## rep:alterProperties > * when removing a property > ## rep:removeProperties > > For canRemove and canUpdateGroupMembers this can be solved by reducing the > set of privileges it is checking for. For canUpdateProperties, a new > variation of that method should be introduced where the user can pass in the > types of property updates that are expected to be needed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9807) AuthorizablePrivilegesInfo is checking for too many privileges for some of the operations
[ https://issues.apache.org/jira/browse/SLING-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman updated SLING-9807: --- Summary: AuthorizablePrivilegesInfo is checking for too many privileges for some of the operations (was: AuthorizablePrivilegesInfo is checking for too may privileges for some of the operations) > AuthorizablePrivilegesInfo is checking for too many privileges for some of > the operations > - > > Key: SLING-9807 > URL: https://issues.apache.org/jira/browse/SLING-9807 > Project: Sling > Issue Type: Bug >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: JCR Jackrabbit User Manager 2.2.12 > > > canRemove - should require only these privileges: > # jcr:read > # rep:userManagement > canUpdateGroupMembers - should require only these privileges: > # jcr:read > # rep:userManagement > canUpdateProperties - should require only these privileges: > * when adding a new (non-nested) property > ## rep:addProperties > * when adding a new nested property > ## rep:addProperties > ## jcr:addChildNodes > * when altering an existing property > ## rep:alterProperties > * when removing a property > ## rep:removeProperties > > For canRemove and canUpdateGroupMembers this can be solved by reducing the > set of privileges it is checking for. For canUpdateProperties, a new > variation of that method should be introduced where the user can pass in the > types of property updates are expected to be needed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Release Apache Sling JCR Jackrabbit User Manager 2.2.12, Apache Sling JCR Jackrabbit Access Manager 3.0.8
+1 On Thu, Oct 15, 2020 at 3:41 PM Eric Norman wrote: > Hi, > > We solved 8 issues in the JCR Jackrabbit User Manager 2.2.12 release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12348632 > > There are still 1 outstanding deferred issue: > https://issues.apache.org/jira/projects/SLING/versions/12349279 > > We solved 2 issues in the JCR Jackrabbit Access Manager 3.0.8 release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12348654 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2357/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2357 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. >
[VOTE] Release Apache Sling JCR Jackrabbit User Manager 2.2.12, Apache Sling JCR Jackrabbit Access Manager 3.0.8
Hi, We solved 8 issues in the JCR Jackrabbit User Manager 2.2.12 release: https://issues.apache.org/jira/browse/SLING/fixforversion/12348632 There are still 1 outstanding deferred issue: https://issues.apache.org/jira/projects/SLING/versions/12349279 We solved 2 issues in the JCR Jackrabbit Access Manager 3.0.8 release: https://issues.apache.org/jira/browse/SLING/fixforversion/12348654 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2357/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2357 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] commented on pull request #4: SLING-9795 - JUnit 5 support for server-side tests
sonarcloud[bot] commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-709624321 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=SECURITY_HO TSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=CODE_SMELL) [22 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&metric=new_coverage&view=list) [80.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] removed a comment on pull request #4: SLING-9795 - JUnit 5 support for server-side tests
sonarcloud[bot] removed a comment on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-705825250 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=SECURITY_HO TSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=CODE_SMELL) [18 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&metric=new_coverage&view=list) [67.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-core&pullRequest=4&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-9833) Update to Sling Bundle Parent 40
[ https://issues.apache.org/jira/browse/SLING-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-9833. Resolution: Fixed Fixed at: https://github.com/apache/sling-org-apache-sling-jcr-jackrabbit-accessmanager/commit/ac82a4a0247b56c874c05d3b31e1c5d4b009f604 > Update to Sling Bundle Parent 40 > > > Key: SLING-9833 > URL: https://issues.apache.org/jira/browse/SLING-9833 > Project: Sling > Issue Type: Sub-task >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: JCR Jackrabbit Access Manager 3.0.8 > > > Update to Sling Bundle Parent 40 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9833) Update to Sling Bundle Parent 40
Eric Norman created SLING-9833: -- Summary: Update to Sling Bundle Parent 40 Key: SLING-9833 URL: https://issues.apache.org/jira/browse/SLING-9833 Project: Sling Issue Type: Sub-task Reporter: Eric Norman Assignee: Eric Norman Fix For: JCR Jackrabbit Access Manager 3.0.8 Update to Sling Bundle Parent 40 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9832) Update to Sling Bundle Parent 40
[ https://issues.apache.org/jira/browse/SLING-9832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-9832. Resolution: Fixed Fixed at: https://github.com/apache/sling-org-apache-sling-jcr-jackrabbit-usermanager/commit/eaad054ce77ba3f19da67f24f96ad6113da73a4c > Update to Sling Bundle Parent 40 > > > Key: SLING-9832 > URL: https://issues.apache.org/jira/browse/SLING-9832 > Project: Sling > Issue Type: Sub-task >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: JCR Jackrabbit User Manager 2.2.12 > > > Update to Sling Bundle Parent 40 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9832) Update to Sling Bundle Parent 40
Eric Norman created SLING-9832: -- Summary: Update to Sling Bundle Parent 40 Key: SLING-9832 URL: https://issues.apache.org/jira/browse/SLING-9832 Project: Sling Issue Type: Sub-task Reporter: Eric Norman Assignee: Eric Norman Fix For: JCR Jackrabbit User Manager 2.2.12 Update to Sling Bundle Parent 40 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-6767) Jackrabbit Usermanager: Allow to detect whether a POST request was treated by the default POST servlet or the jackrabbit.usermanager
[ https://issues.apache.org/jira/browse/SLING-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman updated SLING-6767: --- Fix Version/s: (was: JCR Jackrabbit User Manager 2.2.12) JCR Jackrabbit User Manager 2.2.14 > Jackrabbit Usermanager: Allow to detect whether a POST request was treated by > the default POST servlet or the jackrabbit.usermanager > > > Key: SLING-6767 > URL: https://issues.apache.org/jira/browse/SLING-6767 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus >Priority: Major > Fix For: JCR Jackrabbit User Manager 2.2.14 > > > Currently it is impossible to tell from the response whether a POST request > has been answered by either the Default Sling POST servlet or the Jackrabbit > Usermanager. Both the JSON and the HTML look exactly the same no matter, who > answered. It should be possible to see from the client-side whether a request > has been treated by one or the other. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9826) jcr:uuid index not updated on move
[
https://issues.apache.org/jira/browse/SLING-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman resolved SLING-9826.
Resolution: Fixed
Fixed at:
[https://github.com/apache/sling-org-apache-sling-jcr-oak-server/commit/ff4c2bc05f3900d9c32c3aeb3887ba03d96e0d9c]
Also added new test to verify and guard against future regressions.
> jcr:uuid index not updated on move
> --
>
> Key: SLING-9826
> URL: https://issues.apache.org/jira/browse/SLING-9826
> Project: Sling
> Issue Type: Bug
> Components: JCR, Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Oak Server 1.2.10
>
>
> When changing from Sling Starter 11 to the (almost) latest version of Sling
> Starter 12-SNAPSHOT I get the problem that it is not possible to find nodes
> that are mix:referenceable by their jcr:uuid after they have been moved in
> the JCR tree: Session.getNodeByIdentifier throws an ItemNotFoundException,
> and a query /jcr:root//*[@jcr:uuid='${uuid}'] does not find the node.
> I tested it with the following code (Node and Session being from javax.jcr.*):
> {code:java}
> Node parent = session.getNode(PATH);
> String name = "child" + System.currentTimeMillis();
> Node child = parent.addNode(name, "sling:Folder");
> child.addMixin("mix:referenceable");
> session.save();
> String id = child.getIdentifier();
> // session.getNodeByIdentifier(id); // OK, works as expected here.
> session.move(child.getPath(), PATH2 + "/" + name);
> session.save();
> session.getNodeByIdentifier(id); // often throws ItemNotFoundException!
> {code}
> PATH and PATH2 denote two preexisting writeable nodes. If I force a refresh
> of the /oak:index/uuid, the node is found again - until it is moved again.
> The query problem is also easy to replicate by creating a mix:referenceable
> node in the browser, moving it and trying to query it with
> /jcr:root//*[@jcr:uuid='${uuid}'] .
> I initially reported the bug to the Jackrabbit OAK project, but it is not
> possible to reproduce this with the oak-jcr tests. I could also not reproduce
> it with a unit test in org-apache-sling-jcr-resource, only when using the
> Sling Starter 12. [This comment on my Oak
> bugreport|https://issues.apache.org/jira/browse/OAK-9253?focusedCommentId=17213939&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17213939]
> suggests that there might be some misconfiguration in Sling.
> Thank you very much!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9825) Bundle Content Install Fails in Composite Store Seeding
[
https://issues.apache.org/jira/browse/SLING-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman resolved SLING-9825.
Resolution: Fixed
Fixed at:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/commit/ff4c2bc05f3900d9c32c3aeb3887ba03d96e0d9c
> Bundle Content Install Fails in Composite Store Seeding
> ---
>
> Key: SLING-9825
> URL: https://issues.apache.org/jira/browse/SLING-9825
> Project: Sling
> Issue Type: Bug
> Components: Oak
>Affects Versions: JCR Oak Server 1.2.8
>Reporter: Dan Klco
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Oak Server 1.2.10
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When running with JCR Oak Server 1.2.8, installing Bundle Content fails with
> exceptions complaining about UUID conflicts, for example:
> {{08.10.2020 23:02:19.406 *ERROR* [Apache Sling Repository Startup Thread #1]
> org.apache.sling.jcr.contentloader.internal.BundleContentLoader Cannot load
> initial content for bundle org.apache.sling.cms.ui : OakConstraint0030:
> Uniqueness constraint violated property [jcr:uuid] having value
> 5f5e23b5-e45b-4c8f-ac2f-fc725e3c14b6:
> /libs/sling-cms/components/cms/blank/blank.jsp/jcr:content
> javax.jcr.nodetype.ConstraintViolationException: OakConstraint0030:
> Uniqueness constraint violated property [jcr:uuid] having value
> 5f5e23b5-e45b-4c8f-ac2f-fc725e3c14b6:
> /libs/sling-cms/components/cms/blank/blank.jsp/jcr:content}}
> Reverting to 1.2.4 resolves the issue. I suspect the issue may be due to the
> following commit, but I need to do more analysis:
> https://github.com/apache/sling-org-apache-sling-jcr-oak-server/commit/77c571f03362f1d7b4ec33842c09ef23c85759ed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-9826) jcr:uuid index not updated on move
[
https://issues.apache.org/jira/browse/SLING-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman reassigned SLING-9826:
--
Assignee: Eric Norman
> jcr:uuid index not updated on move
> --
>
> Key: SLING-9826
> URL: https://issues.apache.org/jira/browse/SLING-9826
> Project: Sling
> Issue Type: Bug
> Components: JCR, Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Oak Server 1.2.10
>
>
> When changing from Sling Starter 11 to the (almost) latest version of Sling
> Starter 12-SNAPSHOT I get the problem that it is not possible to find nodes
> that are mix:referenceable by their jcr:uuid after they have been moved in
> the JCR tree: Session.getNodeByIdentifier throws an ItemNotFoundException,
> and a query /jcr:root//*[@jcr:uuid='${uuid}'] does not find the node.
> I tested it with the following code (Node and Session being from javax.jcr.*):
> {code:java}
> Node parent = session.getNode(PATH);
> String name = "child" + System.currentTimeMillis();
> Node child = parent.addNode(name, "sling:Folder");
> child.addMixin("mix:referenceable");
> session.save();
> String id = child.getIdentifier();
> // session.getNodeByIdentifier(id); // OK, works as expected here.
> session.move(child.getPath(), PATH2 + "/" + name);
> session.save();
> session.getNodeByIdentifier(id); // often throws ItemNotFoundException!
> {code}
> PATH and PATH2 denote two preexisting writeable nodes. If I force a refresh
> of the /oak:index/uuid, the node is found again - until it is moved again.
> The query problem is also easy to replicate by creating a mix:referenceable
> node in the browser, moving it and trying to query it with
> /jcr:root//*[@jcr:uuid='${uuid}'] .
> I initially reported the bug to the Jackrabbit OAK project, but it is not
> possible to reproduce this with the oak-jcr tests. I could also not reproduce
> it with a unit test in org-apache-sling-jcr-resource, only when using the
> Sling Starter 12. [This comment on my Oak
> bugreport|https://issues.apache.org/jira/browse/OAK-9253?focusedCommentId=17213939&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17213939]
> suggests that there might be some misconfiguration in Sling.
> Thank you very much!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-9825) Bundle Content Install Fails in Composite Store Seeding
[
https://issues.apache.org/jira/browse/SLING-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman reassigned SLING-9825:
--
Assignee: Eric Norman (was: Dan Klco)
> Bundle Content Install Fails in Composite Store Seeding
> ---
>
> Key: SLING-9825
> URL: https://issues.apache.org/jira/browse/SLING-9825
> Project: Sling
> Issue Type: Bug
> Components: Oak
>Affects Versions: JCR Oak Server 1.2.8
>Reporter: Dan Klco
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Oak Server 1.2.10
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When running with JCR Oak Server 1.2.8, installing Bundle Content fails with
> exceptions complaining about UUID conflicts, for example:
> {{08.10.2020 23:02:19.406 *ERROR* [Apache Sling Repository Startup Thread #1]
> org.apache.sling.jcr.contentloader.internal.BundleContentLoader Cannot load
> initial content for bundle org.apache.sling.cms.ui : OakConstraint0030:
> Uniqueness constraint violated property [jcr:uuid] having value
> 5f5e23b5-e45b-4c8f-ac2f-fc725e3c14b6:
> /libs/sling-cms/components/cms/blank/blank.jsp/jcr:content
> javax.jcr.nodetype.ConstraintViolationException: OakConstraint0030:
> Uniqueness constraint violated property [jcr:uuid] having value
> 5f5e23b5-e45b-4c8f-ac2f-fc725e3c14b6:
> /libs/sling-cms/components/cms/blank/blank.jsp/jcr:content}}
> Reverting to 1.2.4 resolves the issue. I suspect the issue may be due to the
> following commit, but I need to do more analysis:
> https://github.com/apache/sling-org-apache-sling-jcr-oak-server/commit/77c571f03362f1d7b4ec33842c09ef23c85759ed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-jcr-oak-server] enapps-enorman merged pull request #5: SLING-9825 SLING-9826 remove the duplicate components in the Jcr/Oak config
enapps-enorman merged pull request #5: URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-oak-server] sonarcloud[bot] commented on pull request #5: SLING-9825 SLING-9826 remove the duplicate components in the Jcr/Oak config
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/5#issuecomment-709576620 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&resolved=false&t ypes=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-oak-server&pullRequest=5&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-oak-server] enapps-enorman opened a new pull request #5: SLING-9825 SLING-9826 remove the duplicate components in the Jcr/Oak config
enapps-enorman opened a new pull request #5: URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/5 In the 1.2.8 Oak/Jcr config the editorProvider, indexEditorProvider and queryIndexProvider config lists had some of the components twice, once coming from the OakDefaultComponents set and the same again via the Whiteboard*Provider components. This fix removes the duplicate components. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Scripting JavaScript 3.1.4
+1 On Thu, Oct 15, 2020 at 11:42 AM Eric Norman wrote: > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12346587 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2356/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2356 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. >
[VOTE] Release Apache Sling Scripting JavaScript 3.1.4
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12346587 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2356/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2356 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Resolved] (SLING-9831) Update to Sling Bundle Parent 40
[ https://issues.apache.org/jira/browse/SLING-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-9831. Resolution: Fixed Fixed at: https://github.com/apache/sling-org-apache-sling-scripting-javascript/commit/592034bcde914a49586308083852c2e0c2b71c6a > Update to Sling Bundle Parent 40 > > > Key: SLING-9831 > URL: https://issues.apache.org/jira/browse/SLING-9831 > Project: Sling > Issue Type: Sub-task >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Scripting JavaScript 3.1.4 > > > Update to Sling Bundle Parent 39 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9826) jcr:uuid index not updated on move
[
https://issues.apache.org/jira/browse/SLING-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214886#comment-17214886
]
Hans-Peter Stoerr commented on SLING-9826:
--
[~rombert] : when I try setting that bundle (and only that) to 1.2.4 , then my
server doesn't work properly - the start page shows no login and the log shows
{code:java}
org.apache.felix.log.LogException: org.apache.sling.api.SlingException: Can't
create the JCR event listener.
...
Caused by: org.apache.felix.log.LogException: javax.jcr.LoginException: Can
neither derive user name nor principal names for bundle
org.apache.sling.jcr.resource [179] an d sub service observation
{code}
When I used 1.2.6 the test with the browser did work - I didn't try the JSP
above. So that might be enough of a downgrade.
By the way: since the commit 8ef520c87 (re-enable Smoke-IT) my build fails with
{code:java}
[ERROR] Failed to execute goal
org.apache.sling:feature-launcher-maven-plugin:0.1.0:start (default) on project
org.apache.sling.starter: Launch sling-12-oak-tar failed to start in 30
seconds. -> [Help 1]
{code}
Perhaps 30 seconds isn't enough - if I use the starter and the feature files,
it seems to work normally.
> jcr:uuid index not updated on move
> --
>
> Key: SLING-9826
> URL: https://issues.apache.org/jira/browse/SLING-9826
> Project: Sling
> Issue Type: Bug
> Components: JCR, Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Priority: Major
> Fix For: JCR Oak Server 1.2.10
>
>
> When changing from Sling Starter 11 to the (almost) latest version of Sling
> Starter 12-SNAPSHOT I get the problem that it is not possible to find nodes
> that are mix:referenceable by their jcr:uuid after they have been moved in
> the JCR tree: Session.getNodeByIdentifier throws an ItemNotFoundException,
> and a query /jcr:root//*[@jcr:uuid='${uuid}'] does not find the node.
> I tested it with the following code (Node and Session being from javax.jcr.*):
> {code:java}
> Node parent = session.getNode(PATH);
> String name = "child" + System.currentTimeMillis();
> Node child = parent.addNode(name, "sling:Folder");
> child.addMixin("mix:referenceable");
> session.save();
> String id = child.getIdentifier();
> // session.getNodeByIdentifier(id); // OK, works as expected here.
> session.move(child.getPath(), PATH2 + "/" + name);
> session.save();
> session.getNodeByIdentifier(id); // often throws ItemNotFoundException!
> {code}
> PATH and PATH2 denote two preexisting writeable nodes. If I force a refresh
> of the /oak:index/uuid, the node is found again - until it is moved again.
> The query problem is also easy to replicate by creating a mix:referenceable
> node in the browser, moving it and trying to query it with
> /jcr:root//*[@jcr:uuid='${uuid}'] .
> I initially reported the bug to the Jackrabbit OAK project, but it is not
> possible to reproduce this with the oak-jcr tests. I could also not reproduce
> it with a unit test in org-apache-sling-jcr-resource, only when using the
> Sling Starter 12. [This comment on my Oak
> bugreport|https://issues.apache.org/jira/browse/OAK-9253?focusedCommentId=17213939&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17213939]
> suggests that there might be some misconfiguration in Sling.
> Thank you very much!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-9831) Update to Sling Bundle Parent 40
Eric Norman created SLING-9831: -- Summary: Update to Sling Bundle Parent 40 Key: SLING-9831 URL: https://issues.apache.org/jira/browse/SLING-9831 Project: Sling Issue Type: Sub-task Reporter: Eric Norman Assignee: Eric Norman Fix For: Scripting JavaScript 3.1.4 Update to Sling Bundle Parent 39 -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [roundtable] Sling 12 + future release process
On Fri, 2020-10-02 at 07:36 +, Stefan Seifert wrote: > the discussion then did go further whether we should rethink the way > of doing sling releases in the future: > > - should we still perform releases this way? > > - JavaDoc generation should be decoupled from our annual releases, > should be done automatically and updated for each module release > > - probably we could just do with "snapshot releases" / "nightly > builds" - and vote from time to time to make an official release out > of it? > > - Should we replace the Sling Starter release with a "release > generator" web page that allows the user to download a project? For > instance: > > Scripting: [ ] jsp, [ ] htl, [ ] freemarker, [ ] thymeleaf > > Discovery: [ ] standalone, [ ] oak > > Persistence: [ ] Tar, [ ] MongoDB > > Launcher: [ ] feature model, [ ] karaf > > - We have two launcher alternatives - Feature Launcher, Kickstarter. > We should only keep one. To give a bit more background, we were discussing whether having a Sling Starter release actually brings value to our users except for "This is how a Sling application should look like". The Starter is obviously very useful for us as developers to integrate our changes and test them in a sane environment, manually and/or automatically. For the users, my assumption (which is of course disprovable) is that they are building their own application taking the starter as an initial point. And our releases happen so rarely I doubt anyone is waiting for the next Starter release to upgrade. I also suspect that the Starter has great documentation value, as it shows what bundle versions work together, what configurations are required, expected repository structure and service users, etc. So one of the ideas floated around was to have a generator webpage that builds a sample Sling project based on user input. This project will be based on the Sling Starter configuration from git and copy instead of reference the feature files. This has the potential of removing a lot of release engineering effort. There are two things which are not entirely clear to me right now: 1. What do we lose when switching to this model? For instance, users wouldn't be able to download Sling and start playing around with it. 2. Is this OK from a legal point of view? I don't think we are dancing around the ASF release policy, but if anyone has any concerns it'd be good to discuss them. Comments/questions welcome. Thanks, Robert
Re: [roundtable] Sling 12 + future release process
On Fri, 2020-10-02 at 07:36 +, Stefan Seifert wrote: > we should not wait until more feature that are currently in progress > are ready, would be nice to have out Sling 12 soon +1 >From my point of view we still have to finish the feature model conversion [0]: - docker support - kickstart - documentation - archetypes and make sure we don't ship with regressions: - SLING-9825, SLING-9826 - JCR support regression, requires a new oak.server release [1][2] - SLING-9842 - sun.mic.Unsafe not available OOTB [3] - SLING-9648 - error logged at startup, needs a settings bundle release [4] Are there any other items that are important to have in the next Starter release? Thanks, Robert [0]: https://cwiki.apache.org/confluence/display/SLING/Migrating+the+Sling+Starter+to+the+Feature+Model [1]: https://issues.apache.org/jira/browse/SLING-9826 [2]: https://issues.apache.org/jira/browse/SLING-9825 [3]: https://issues.apache.org/jira/browse/SLING-9824 [4]: https://issues.apache.org/jira/browse/SLING-9648
Re: [VOTE] Release Apache Sling slingfeature-maven-plugin 1.4.4
+1 On Thu, Oct 15, 2020 at 3:25 AM Karl Pauls wrote: > +1 > > regards, > > Karl > > On Thursday, October 15, 2020, wrote: > > > +1 > > > > David > > > > On Thu, 15 Oct 2020 at 07:01, Carsten Ziegeler > > wrote: > > > > > Hi, > > > > > > We solved 1 issue in this release: > > > https://issues.apache.org/jira/browse/SLING-9828 > > > > > > Staging repository: > > > > https://repository.apache.org/content/repositories/orgapachesling-2355/ > > > > > > You can use this UNIX script to download the release and verify the > > > signatures: > > > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling- > > release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > Usage: > > > sh check_staged_release.sh 2355 /tmp/sling-staging > > > > > > Please vote to approve this release: > > > > > >[ ] +1 Approve the release > > >[ ] 0 Don't care > > >[ ] -1 Don't release, because ... > > > > > > This majority vote is open for at least 72 hours. > > > > > > Regards > > > Carsten > > > -- > > > Carsten Ziegeler > > > Adobe Research Switzerland > > > cziege...@apache.org > > > > > > > > -- > Karl Pauls > karlpa...@gmail.com >
[jira] [Commented] (SLING-9829) data-sly-element should correctly handle void elements
[
https://issues.apache.org/jira/browse/SLING-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214717#comment-17214717
]
Paul Bjorkstrand commented on SLING-9829:
-
Though it would be bead form, I am curious how you will handle when the element
name is for a void element, but the actual element has child nodes (text
content or other elements). It might be worthwhile to at least debug log when
that situation occurs, something along the lines of "The name in
data-sly-element is a void element, all children of this element
will be ignored/removed"
Thoughts?
> data-sly-element should correctly handle void elements
> --
>
> Key: SLING-9829
> URL: https://issues.apache.org/jira/browse/SLING-9829
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Sightly Engine 1.0.0, Scripting HTL Compiler
> 1.0.0, Scripting HTL Compiler 1.1.0-1.4.0, Scripting HTL Compiler 1.2.0-1.4.0
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Compiler 1.2.12-1.4.0
>
>
> The current implementation of {{data-sly-element}} doesn't correctly handle
> void elements which will replace the original element on which the block
> element was placed:
> When {{$\{item.element.name}}} evaluates to {{link}} or {{meta}}, the element
> will have a closing tag in the following example, although both {{link}} and
> {{meta}} are void elements:
> {code:html}
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SLING-9829) data-sly-element should correctly handle void elements
[
https://issues.apache.org/jira/browse/SLING-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214717#comment-17214717
]
Paul Bjorkstrand edited comment on SLING-9829 at 10/15/20, 2:00 PM:
Though it would be bad form to add children to an eventual void element, I am
curious how you will handle when the element name is for a void element, but
the actual element has child nodes (text content or other elements). It might
be worthwhile to at least debug log when that situation occurs, something along
the lines of "The name in data-sly-element is a void element,
all children of this element will be ignored/removed"
Thoughts?
was (Author: paul.bjorkstrand):
Though it would be bead form, I am curious how you will handle when the element
name is for a void element, but the actual element has child nodes (text
content or other elements). It might be worthwhile to at least debug log when
that situation occurs, something along the lines of "The name in
data-sly-element is a void element, all children of this element
will be ignored/removed"
Thoughts?
> data-sly-element should correctly handle void elements
> --
>
> Key: SLING-9829
> URL: https://issues.apache.org/jira/browse/SLING-9829
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Sightly Engine 1.0.0, Scripting HTL Compiler
> 1.0.0, Scripting HTL Compiler 1.1.0-1.4.0, Scripting HTL Compiler 1.2.0-1.4.0
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Compiler 1.2.12-1.4.0
>
>
> The current implementation of {{data-sly-element}} doesn't correctly handle
> void elements which will replace the original element on which the block
> element was placed:
> When {{$\{item.element.name}}} evaluates to {{link}} or {{meta}}, the element
> will have a closing tag in the following example, although both {{link}} and
> {{meta}} are void elements:
> {code:html}
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #166 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/166/ for details. No further emails will be sent until the status of the build is changed.
[jira] [Resolved] (SLING-9830) Fix stale debugging instructions in launchpad-testing module
[ https://issues.apache.org/jira/browse/SLING-9830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-9830. Resolution: Fixed README reworked, pom.xml adapted to get the feature launcher jar used to start the instance for debugging. > Fix stale debugging instructions in launchpad-testing module > > > Key: SLING-9830 > URL: https://issues.apache.org/jira/browse/SLING-9830 > Project: Sling > Issue Type: Task > Components: Launchpad, Testing >Affects Versions: Launchpad Testing 11 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Launchpad Testing 12 > > > The README's tests debugging instructions need to be adapted now that the > tests are started with the feature launcher plugin. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9830) Fix stale debugging instructions in launchpad-testing module
Bertrand Delacretaz created SLING-9830: -- Summary: Fix stale debugging instructions in launchpad-testing module Key: SLING-9830 URL: https://issues.apache.org/jira/browse/SLING-9830 Project: Sling Issue Type: Task Components: Launchpad, Testing Affects Versions: Launchpad Testing 11 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Fix For: Launchpad Testing 12 The README's tests debugging instructions need to be adapted now that the tests are started with the feature launcher plugin. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: SLING-9639 - Deprecate launchpad-testing-bundles and launchpad-testing-war
On Fri, 2020-10-02 at 15:33 +0200, Robert Munteanu wrote: > Hi, > > After switching to the feature model there are two modules that > should > be deprecated. Both are related to testing the current Starter: > > - launchpad-testing-war runs tests against a WAR build of the > Starter, > but that no longer exists > - launchpad-testing-bundles builds a provisioning model of the test > artifacts ( services, fragment, junit bundles ) but this has been > moved > to the launchpad-testing project > > I'm polling for lazy consensus so if anyone has any objections please > raise them in the following 3 working days. Took a bitmore than three working days, but I've now deprecated these two modules. Thanks, Robert
[jira] [Resolved] (SLING-9639) Deprecate no longer used launchpad testing projects
[ https://issues.apache.org/jira/browse/SLING-9639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-9639. Resolution: Fixed Done with - [sling-org-apache-sling-launchpad-test-bundles commit 710c8e4|https://github.com/apache/sling-org-apache-sling-launchpad-test-bundles/commit/710c8e4] - [sling-org-apache-sling-launchpad-testing-war commit 2592e23|https://github.com/apache/sling-org-apache-sling-launchpad-testing-war/commit/2592e23] - [sling-org-apache-sling-launchpad-testing-war commit 68e9af6|https://github.com/apache/sling-org-apache-sling-launchpad-testing-war/commit/68e9af6] > Deprecate no longer used launchpad testing projects > --- > > Key: SLING-9639 > URL: https://issues.apache.org/jira/browse/SLING-9639 > Project: Sling > Issue Type: Sub-task > Components: Launchpad, Testing >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > > We can deprecated the following two projects: > - launchpad-testing-bundles - now the launchpad-testing project has its own > feature model > - launchpad-testing-war - wars are no longer supported -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-feature-cpconverter] bosschaert merged pull request #31: SLING-9827 Specify the API Region to export packages into
bosschaert merged pull request #31: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-9829) data-sly-element should correctly handle void elements
Radu Cotescu created SLING-9829:
---
Summary: data-sly-element should correctly handle void elements
Key: SLING-9829
URL: https://issues.apache.org/jira/browse/SLING-9829
Project: Sling
Issue Type: Bug
Components: Scripting
Affects Versions: Scripting HTL Compiler 1.2.0-1.4.0, Scripting HTL
Compiler 1.1.0-1.4.0, Scripting HTL Compiler 1.0.0, Scripting Sightly Engine
1.0.0
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: Scripting HTL Compiler 1.2.12-1.4.0
The current implementation of {{data-sly-element}} doesn't correctly handle
void elements which will replace the original element on which the block
element was placed:
When {{$\{item.element.name}}} evaluates to {{link}} or {{meta}}, the element
will have a closing tag in the following example, although both {{link}} and
{{meta}} are void elements:
{code:html}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #31: SLING-9827 Specify the API Region to export packages into
sonarcloud[bot] removed a comment on pull request #31: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/31#issuecomment-708995846 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullReq uest=31&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&metric=new_coverage&view=list) [92.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #31: SLING-9827 Specify the API Region to export packages into
sonarcloud[bot] commented on pull request #31: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/31#issuecomment-709057458 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullReq uest=31&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&metric=new_coverage&view=list) [92.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] bosschaert commented on a change in pull request #31: SLING-9827 Specify the API Region to export packages into
bosschaert commented on a change in pull request #31:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/31#discussion_r505411845
##
File path:
src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java
##
@@ -225,6 +224,45 @@ public void addConfiguration(String runMode, String pid,
Dictionary exportedPackages)
{
Review comment:
You are right - this is better. I've just made the change. Thanks for
reviewing @cziegeler !
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-9824) sun.misc.Unsafe accessible in Sling Starter 12
[
https://issues.apache.org/jira/browse/SLING-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214570#comment-17214570
]
Karl Pauls commented on SLING-9824:
---
[~kwin], not for the boot delegation. To be precise: Felix doesn't bootdelegate
by default - hence, if we don't add boot delegation to sun.* and com.sun.* it
will not be there. That might be fine, as users like [~hanspeterstoerr] in this
case (but others in general) could then add the required delegation via -D
properties. However, for sun.* and com.sun.* it might be a very common case...
> sun.misc.Unsafe accessible in Sling Starter 12
> --
>
> Key: SLING-9824
> URL: https://issues.apache.org/jira/browse/SLING-9824
> Project: Sling
> Issue Type: Bug
> Components: Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Priority: Minor
>
> We are having some trouble running our application on [the current Sling
> Starter 12
> snapshot|https://github.com/apache/sling-org-apache-sling-starter/tree/addb8f7ba16dfb2ab6cda1a70f98a461a7cacb7a]
> since we are using ehache 3, which uses sun.misc.Unsafe internally. This
> works with Sling Starter 11, but since Sling Starter changed to the feature
> launcher, this class seems to have disappeared from the classpath: the class
> loading of ehcache classes fails with a java.lang.NoClassDefFoundError:
> sun/misc/Unsafe
> I tried to add command line arguments
> --add-modules=jdk.unsupported
> and
> --add-opens=jdk.unsupported/sun.misc=ALL-UNNAMED
> to the launcher command line, as I've seen that suggested on the net for
> similar problems, but it didn't help.
> In fact, this doesn't seem to be the problem: even without those flags the
> jdk.unsupported module does export sun.misc:
> module
> { name: jdk.unsupported@11.0.6, [mandated java.base], exports:
> [com.sun.nio.file, sun.misc, sun.reflect], opens: [sun.misc, sun.reflect] }
> So it seems the module is loaded, but not used to load the class.
> The easiest way to reproduce the problem is to add this to some JSP:
> <%
> Class clazz = sun.misc.Unsafe.class;
> %>
> In case that matters: I tried JDK 11 and 13 on MacOS, as well as JDK 11 on
> an x86_64 Linux.
> This works on Sling Starter 11, but not the current 12 snapshot.
> The workaround to add
> {{-D org.osgi.framework.system.packages.extra=sun.misc}}
> to the command line, which was thankfully suggested [in the mailing
> list|https://www.mail-archive.com/users@sling.apache.org/msg05423.html], does
> work. But I feel it is not a particularily clean solution. It also does
> something else than what happens on Sling Starter 11 : now the sun.misc
> package is listed in the exports list of the felix framework bundle
> [http://localhost:9090/system/console/bundles/0] . Not sure whether this is
> good or bad.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-feature-cpconverter] cziegeler commented on a change in pull request #31: SLING-9827 Specify the API Region to export packages into
cziegeler commented on a change in pull request #31:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/31#discussion_r505393425
##
File path:
src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java
##
@@ -225,6 +224,45 @@ public void addConfiguration(String runMode, String pid,
Dictionary exportedPackages)
{
Review comment:
Thanks, yes, I know but I think if we touch the code we should improve :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (SLING-9624) Get rid of custom "org.osgi.framework.system.packages"
[ https://issues.apache.org/jira/browse/SLING-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-9624: --- Description: Instead of using a Sling specific "org.osgi.framework.system.packages" property (https://github.com/apache/sling-org-apache-sling-starter/blob/5f44b7f6c6b75e4cfd5574fb701c3e7eca8405ef/src/main/provisioning/launchpad.txt#L26) we should just rely on the Felix default (https://github.com/apache/felix-dev/blob/master/framework/src/main/resources/default.properties) to not miss to export all relevant packages for the different JREs compare with https://lists.apache.org/thread.html/r0aa3c02c38b5026e24684a00de3c6c8506e166334e77892ac2ee0ab3%40%3Cdev.sling.apache.org%3E. was: Instead of using a Sling specific "org.osgi.framework.system.packages" property (https://github.com/apache/sling-org-apache-sling-starter/blob/5f44b7f6c6b75e4cfd5574fb701c3e7eca8405ef/src/main/provisioning/launchpad.txt#L26) we should just rely on the Feix default (https://github.com/apache/felix-dev/blob/master/framework/src/main/resources/default.properties) to not miss to export all relevant packages for the different JREs compare with https://lists.apache.org/thread.html/r0aa3c02c38b5026e24684a00de3c6c8506e166334e77892ac2ee0ab3%40%3Cdev.sling.apache.org%3E. > Get rid of custom "org.osgi.framework.system.packages" > -- > > Key: SLING-9624 > URL: https://issues.apache.org/jira/browse/SLING-9624 > Project: Sling > Issue Type: Improvement > Components: Starter >Reporter: Konrad Windszus >Priority: Major > Fix For: Starter 12 > > > Instead of using a Sling specific "org.osgi.framework.system.packages" > property > (https://github.com/apache/sling-org-apache-sling-starter/blob/5f44b7f6c6b75e4cfd5574fb701c3e7eca8405ef/src/main/provisioning/launchpad.txt#L26) > we should just rely on the Felix default > (https://github.com/apache/felix-dev/blob/master/framework/src/main/resources/default.properties) > to not miss to export all relevant packages for the different JREs > compare with > https://lists.apache.org/thread.html/r0aa3c02c38b5026e24684a00de3c6c8506e166334e77892ac2ee0ab3%40%3Cdev.sling.apache.org%3E. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9824) sun.misc.Unsafe accessible in Sling Starter 12
[
https://issues.apache.org/jira/browse/SLING-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214565#comment-17214565
]
Konrad Windszus commented on SLING-9824:
Can't we just rely on Felix defaults instead of defining our own
(https://issues.apache.org/jira/browse/SLING-9624)?
> sun.misc.Unsafe accessible in Sling Starter 12
> --
>
> Key: SLING-9824
> URL: https://issues.apache.org/jira/browse/SLING-9824
> Project: Sling
> Issue Type: Bug
> Components: Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Priority: Minor
>
> We are having some trouble running our application on [the current Sling
> Starter 12
> snapshot|https://github.com/apache/sling-org-apache-sling-starter/tree/addb8f7ba16dfb2ab6cda1a70f98a461a7cacb7a]
> since we are using ehache 3, which uses sun.misc.Unsafe internally. This
> works with Sling Starter 11, but since Sling Starter changed to the feature
> launcher, this class seems to have disappeared from the classpath: the class
> loading of ehcache classes fails with a java.lang.NoClassDefFoundError:
> sun/misc/Unsafe
> I tried to add command line arguments
> --add-modules=jdk.unsupported
> and
> --add-opens=jdk.unsupported/sun.misc=ALL-UNNAMED
> to the launcher command line, as I've seen that suggested on the net for
> similar problems, but it didn't help.
> In fact, this doesn't seem to be the problem: even without those flags the
> jdk.unsupported module does export sun.misc:
> module
> { name: jdk.unsupported@11.0.6, [mandated java.base], exports:
> [com.sun.nio.file, sun.misc, sun.reflect], opens: [sun.misc, sun.reflect] }
> So it seems the module is loaded, but not used to load the class.
> The easiest way to reproduce the problem is to add this to some JSP:
> <%
> Class clazz = sun.misc.Unsafe.class;
> %>
> In case that matters: I tried JDK 11 and 13 on MacOS, as well as JDK 11 on
> an x86_64 Linux.
> This works on Sling Starter 11, but not the current 12 snapshot.
> The workaround to add
> {{-D org.osgi.framework.system.packages.extra=sun.misc}}
> to the command line, which was thankfully suggested [in the mailing
> list|https://www.mail-archive.com/users@sling.apache.org/msg05423.html], does
> work. But I feel it is not a particularily clean solution. It also does
> something else than what happens on Sling Starter 11 : now the sun.misc
> package is listed in the exports list of the felix framework bundle
> [http://localhost:9090/system/console/bundles/0] . Not sure whether this is
> good or bad.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9824) sun.misc.Unsafe accessible in Sling Starter 12
[
https://issues.apache.org/jira/browse/SLING-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214561#comment-17214561
]
Karl Pauls commented on SLING-9824:
---
[~rombert], yes indeed - the launchpad.base generated a sling.properties that
has bootdelegation for sun.* and com.sun.* in it by default. With the feature
launcher, we don't get this kind of implicit defaults anymore - hence, they
would need to be added to the framework properties via the feature model. I
think we should add boot delegation at least for sun.* and com.sun.*.
> sun.misc.Unsafe accessible in Sling Starter 12
> --
>
> Key: SLING-9824
> URL: https://issues.apache.org/jira/browse/SLING-9824
> Project: Sling
> Issue Type: Bug
> Components: Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Priority: Minor
>
> We are having some trouble running our application on [the current Sling
> Starter 12
> snapshot|https://github.com/apache/sling-org-apache-sling-starter/tree/addb8f7ba16dfb2ab6cda1a70f98a461a7cacb7a]
> since we are using ehache 3, which uses sun.misc.Unsafe internally. This
> works with Sling Starter 11, but since Sling Starter changed to the feature
> launcher, this class seems to have disappeared from the classpath: the class
> loading of ehcache classes fails with a java.lang.NoClassDefFoundError:
> sun/misc/Unsafe
> I tried to add command line arguments
> --add-modules=jdk.unsupported
> and
> --add-opens=jdk.unsupported/sun.misc=ALL-UNNAMED
> to the launcher command line, as I've seen that suggested on the net for
> similar problems, but it didn't help.
> In fact, this doesn't seem to be the problem: even without those flags the
> jdk.unsupported module does export sun.misc:
> module
> { name: jdk.unsupported@11.0.6, [mandated java.base], exports:
> [com.sun.nio.file, sun.misc, sun.reflect], opens: [sun.misc, sun.reflect] }
> So it seems the module is loaded, but not used to load the class.
> The easiest way to reproduce the problem is to add this to some JSP:
> <%
> Class clazz = sun.misc.Unsafe.class;
> %>
> In case that matters: I tried JDK 11 and 13 on MacOS, as well as JDK 11 on
> an x86_64 Linux.
> This works on Sling Starter 11, but not the current 12 snapshot.
> The workaround to add
> {{-D org.osgi.framework.system.packages.extra=sun.misc}}
> to the command line, which was thankfully suggested [in the mailing
> list|https://www.mail-archive.com/users@sling.apache.org/msg05423.html], does
> work. But I feel it is not a particularily clean solution. It also does
> something else than what happens on Sling Starter 11 : now the sun.misc
> package is listed in the exports list of the felix framework bundle
> [http://localhost:9090/system/console/bundles/0] . Not sure whether this is
> good or bad.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-feature-cpconverter] bosschaert commented on a change in pull request #31: SLING-9827 Specify the API Region to export packages into
bosschaert commented on a change in pull request #31:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/31#discussion_r505389906
##
File path:
src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java
##
@@ -225,6 +224,45 @@ public void addConfiguration(String runMode, String pid,
Dictionary exportedPackages)
{
Review comment:
:) this class was already doing it like that - but I'll be happy to
improve it to use the API.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] cziegeler commented on a change in pull request #31: SLING-9827 Specify the API Region to export packages into
cziegeler commented on a change in pull request #31:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/31#discussion_r505388455
##
File path:
src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java
##
@@ -225,6 +224,45 @@ public void addConfiguration(String runMode, String pid,
Dictionary exportedPackages)
{
Review comment:
The regions java api supports generating (and parsing) of the extension
JSON - we should not do this by hand anymore
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-9824) sun.misc.Unsafe accessible in Sling Starter 12
[
https://issues.apache.org/jira/browse/SLING-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214557#comment-17214557
]
Karl Pauls commented on SLING-9824:
---
It sounds to me like sun.misc should be boot delegated instead of being added
to the framework exports. Was that maybe the case in the old provisioning
models but isn't the case in current feature models?
> sun.misc.Unsafe accessible in Sling Starter 12
> --
>
> Key: SLING-9824
> URL: https://issues.apache.org/jira/browse/SLING-9824
> Project: Sling
> Issue Type: Bug
> Components: Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Priority: Minor
>
> We are having some trouble running our application on [the current Sling
> Starter 12
> snapshot|https://github.com/apache/sling-org-apache-sling-starter/tree/addb8f7ba16dfb2ab6cda1a70f98a461a7cacb7a]
> since we are using ehache 3, which uses sun.misc.Unsafe internally. This
> works with Sling Starter 11, but since Sling Starter changed to the feature
> launcher, this class seems to have disappeared from the classpath: the class
> loading of ehcache classes fails with a java.lang.NoClassDefFoundError:
> sun/misc/Unsafe
> I tried to add command line arguments
> --add-modules=jdk.unsupported
> and
> --add-opens=jdk.unsupported/sun.misc=ALL-UNNAMED
> to the launcher command line, as I've seen that suggested on the net for
> similar problems, but it didn't help.
> In fact, this doesn't seem to be the problem: even without those flags the
> jdk.unsupported module does export sun.misc:
> module
> { name: jdk.unsupported@11.0.6, [mandated java.base], exports:
> [com.sun.nio.file, sun.misc, sun.reflect], opens: [sun.misc, sun.reflect] }
> So it seems the module is loaded, but not used to load the class.
> The easiest way to reproduce the problem is to add this to some JSP:
> <%
> Class clazz = sun.misc.Unsafe.class;
> %>
> In case that matters: I tried JDK 11 and 13 on MacOS, as well as JDK 11 on
> an x86_64 Linux.
> This works on Sling Starter 11, but not the current 12 snapshot.
> The workaround to add
> {{-D org.osgi.framework.system.packages.extra=sun.misc}}
> to the command line, which was thankfully suggested [in the mailing
> list|https://www.mail-archive.com/users@sling.apache.org/msg05423.html], does
> work. But I feel it is not a particularily clean solution. It also does
> something else than what happens on Sling Starter 11 : now the sun.misc
> package is listed in the exports list of the felix framework bundle
> [http://localhost:9090/system/console/bundles/0] . Not sure whether this is
> good or bad.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-9722) AbstractSlingRepositoryManager.stop throws NullPointerExceptions if invoked multiple times
[
https://issues.apache.org/jira/browse/SLING-9722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-9722.
--
> AbstractSlingRepositoryManager.stop throws NullPointerExceptions if invoked
> multiple times
> --
>
> Key: SLING-9722
> URL: https://issues.apache.org/jira/browse/SLING-9722
> Project: Sling
> Issue Type: Bug
> Components: JCR
>Affects Versions: JCR Base 3.1.4
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: JCR Base 3.1.6
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The stop method has a check for the currentThread
> {code:java}
> if ( startupThread != Thread.currentThread() ) {
> waitForStartupThreadToComplete();
> startupThread = null;
> }
> {code}
> On the first invocation, the {{startupThread}} is not null, the if block is
> entered and the field is then set to null. On subsequent invocations, the
> condition will also be true, since {{startupThread == null}}, which will
> cause an NPE in the {{waitForStartupThreadToComplete}} method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[RESULT] [VOTE] Release Apache Sling JCR Base 3.1.6
Hi, The vote has passed with the following result: +1 (binding): Robert Munteanu, Carsten Ziegeler, Georg Henzler, A. J. David Bosschaert +1 (non-binding): Andreas Schaefer I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
[jira] [Updated] (SLING-9821) Error message points to non-existing method
[
https://issues.apache.org/jira/browse/SLING-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-9821:
---
Fix Version/s: JCR Base 3.1.8
> Error message points to non-existing method
> ---
>
> Key: SLING-9821
> URL: https://issues.apache.org/jira/browse/SLING-9821
> Project: Sling
> Issue Type: Bug
> Components: JCR
>Reporter: Angela Schreiber
>Priority: Trivial
> Fix For: JCR Base 3.1.8
>
>
> https://github.com/apache/sling-org-apache-sling-jcr-base/blame/master/src/main/java/org/apache/sling/jcr/base/AbstractSlingRepositoryManager.java#L573
> logs the following error:
> {code}
> log.error("start: Uncaught Throwable trying to access Repository, calling
> stopRepository()", e);
> {code}
> but there no method {{stopRepository()}}. the method that is called is
> {{stop()}}.
> so, the right log output should read instead:
> {code}
> log.error("start: Uncaught Throwable trying to access Repository, calling
> stop()", e);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9824) sun.misc.Unsafe accessible in Sling Starter 12
[
https://issues.apache.org/jira/browse/SLING-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214543#comment-17214543
]
Robert Munteanu commented on SLING-9824:
[~kpauls], [~davidb] - any thoughts on this?
> sun.misc.Unsafe accessible in Sling Starter 12
> --
>
> Key: SLING-9824
> URL: https://issues.apache.org/jira/browse/SLING-9824
> Project: Sling
> Issue Type: Bug
> Components: Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Priority: Minor
>
> We are having some trouble running our application on [the current Sling
> Starter 12
> snapshot|https://github.com/apache/sling-org-apache-sling-starter/tree/addb8f7ba16dfb2ab6cda1a70f98a461a7cacb7a]
> since we are using ehache 3, which uses sun.misc.Unsafe internally. This
> works with Sling Starter 11, but since Sling Starter changed to the feature
> launcher, this class seems to have disappeared from the classpath: the class
> loading of ehcache classes fails with a java.lang.NoClassDefFoundError:
> sun/misc/Unsafe
> I tried to add command line arguments
> --add-modules=jdk.unsupported
> and
> --add-opens=jdk.unsupported/sun.misc=ALL-UNNAMED
> to the launcher command line, as I've seen that suggested on the net for
> similar problems, but it didn't help.
> In fact, this doesn't seem to be the problem: even without those flags the
> jdk.unsupported module does export sun.misc:
> module
> { name: jdk.unsupported@11.0.6, [mandated java.base], exports:
> [com.sun.nio.file, sun.misc, sun.reflect], opens: [sun.misc, sun.reflect] }
> So it seems the module is loaded, but not used to load the class.
> The easiest way to reproduce the problem is to add this to some JSP:
> <%
> Class clazz = sun.misc.Unsafe.class;
> %>
> In case that matters: I tried JDK 11 and 13 on MacOS, as well as JDK 11 on
> an x86_64 Linux.
> This works on Sling Starter 11, but not the current 12 snapshot.
> The workaround to add
> {{-D org.osgi.framework.system.packages.extra=sun.misc}}
> to the command line, which was thankfully suggested [in the mailing
> list|https://www.mail-archive.com/users@sling.apache.org/msg05423.html], does
> work. But I feel it is not a particularily clean solution. It also does
> something else than what happens on Sling Starter 11 : now the sun.misc
> package is listed in the exports list of the felix framework bundle
> [http://localhost:9090/system/console/bundles/0] . Not sure whether this is
> good or bad.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9816) Lookup jsp includes from the class path if not found locally
[ https://issues.apache.org/jira/browse/SLING-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-9816. - Resolution: Fixed Implemented in [commit 3b994fe|https://github.com/apache/sling-jspc-maven-plugin/commit/3b994fe152b8df8e62164a43f73f105158f87588]. > Lookup jsp includes from the class path if not found locally > > > Key: SLING-9816 > URL: https://issues.apache.org/jira/browse/SLING-9816 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: JSPC Maven Plugin 2.2.2 >Reporter: Karl Pauls >Assignee: Radu Cotescu >Priority: Major > Fix For: JSPC Maven Plugin 2.2.4 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > When compiling a jsp that has an include it would be good if the jspc could > try to find the included jsp from the class path if it doesn't exist locally > (similar to what happens with taglibs). > This way, it would be possible to include jsps coming from a different > project just by adding a dependency. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-jspc-maven-plugin] raducotescu merged pull request #2: SLING-9816 - Lookup jsp includes from the class path if not found locally
raducotescu merged pull request #2: URL: https://github.com/apache/sling-jspc-maven-plugin/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-jspc-maven-plugin] raducotescu commented on pull request #2: SLING-9816 - Lookup jsp includes from the class path if not found locally
raducotescu commented on pull request #2:
URL:
https://github.com/apache/sling-jspc-maven-plugin/pull/2#issuecomment-709017498
`getDependencyArtifacts()` is a deprecated method. This is what its JavaDoc
states:
```java
/**
* Direct dependencies that this project has.
*
* @return {@link Set} < {@link Artifact} >
* @see #getArtifacts() to get all transitive dependencies
*/
@Deprecated
public Set getDependencyArtifacts()
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (SLING-9827) Specify the API Region to export packages into
[
https://issues.apache.org/jira/browse/SLING-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-9827:
--
Affects Version/s: Feature Model Converter Plugin 1.0.4
> Specify the API Region to export packages into
> --
>
> Key: SLING-9827
> URL: https://issues.apache.org/jira/browse/SLING-9827
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Affects Versions: Feature Model Converter Plugin 1.0.4, Content-Package to
> Feature Model Converter 1.0.14
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Converter Plugin 1.0.6, Content-Package to
> Feature Model Converter 1.0.16
>
>
> Make it possible to specify that all packages exported by bundles in a
> content package will be exported in a given region.
> By default the packages are not listed, which is ok if the generated feature
> doesn't opt in to the API Regions mechanism. In that case the packages are
> implicitly visible in the {{global}} region.
> However, if the generated feature does opt into the API Regions (for example
> by specifying the {{-r}} / {{--api-region}} option), then it will be
> necessary to also explicitly list the exported packages in the API Regions
> exports, as otherwise they will not be visible across the features if
> multiple features are generated from a single content package (e.g. to handle
> run modes).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9827) Specify the API Region to export packages into
[
https://issues.apache.org/jira/browse/SLING-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-9827:
--
Fix Version/s: Feature Model Converter Plugin 1.0.6
> Specify the API Region to export packages into
> --
>
> Key: SLING-9827
> URL: https://issues.apache.org/jira/browse/SLING-9827
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.14
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Converter Plugin 1.0.6, Content-Package to
> Feature Model Converter 1.0.16
>
>
> Make it possible to specify that all packages exported by bundles in a
> content package will be exported in a given region.
> By default the packages are not listed, which is ok if the generated feature
> doesn't opt in to the API Regions mechanism. In that case the packages are
> implicitly visible in the {{global}} region.
> However, if the generated feature does opt into the API Regions (for example
> by specifying the {{-r}} / {{--api-region}} option), then it will be
> necessary to also explicitly list the exported packages in the API Regions
> exports, as otherwise they will not be visible across the features if
> multiple features are generated from a single content package (e.g. to handle
> run modes).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #31: SLING-9827 Specify the API Region to export packages into
sonarcloud[bot] commented on pull request #31: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/31#issuecomment-708995846 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullReq uest=31&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&metric=new_coverage&view=list) [92.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=31&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] bosschaert opened a new pull request #31: SLING-9827 Specify the API Region to export packages into
bosschaert opened a new pull request #31: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/31 The region can be specified with the -e / --exports-to-region option. Normally when this option is used the region specified with this option would be the 'global' region or a region specific to the content package. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling slingfeature-maven-plugin 1.4.4
+1 regards, Karl On Thursday, October 15, 2020, wrote: > +1 > > David > > On Thu, 15 Oct 2020 at 07:01, Carsten Ziegeler > wrote: > > > Hi, > > > > We solved 1 issue in this release: > > https://issues.apache.org/jira/browse/SLING-9828 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2355/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling- > release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2355 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe Research Switzerland > > cziege...@apache.org > > > -- Karl Pauls karlpa...@gmail.com
