[jira] [Commented] (SLING-9581) Reduce implementation duplication between kickstart and feature-launcher maven plugin

[Andreas Schaefer (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217127#comment-17217127
 ] 

Andreas Schaefer commented on SLING-9581:
-

I started to look into the two Maven Plugin.

The Kickstart Maven Plugin is tied to the Kickstart module (Sling) and does 
start that Sling in the process together with the Feature Model from the Maven 
project. It can keep the launched system alive after the Maven build ends. 

The Feature Launcher Maven Plugin just start the given Feature Model from the 
Maven project but it allows to start multiple instances (not sure what this is 
intended to do).


To unify the two I could add a property that allows to run the Kickstart system 
would just run with the Feature Model of the Maven project.

> Reduce implementation duplication between kickstart and feature-launcher 
> maven plugin
> -
>
> Key: SLING-9581
> URL: https://issues.apache.org/jira/browse/SLING-9581
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.2, Feature Model Sling 
> Kickstart Project 0.0.10, Feature Model Sling Maven Kickstart Plugin 0.0.10
>
>
> There is an implementation overlap between the kickstart tooling and the 
> feature-launcher maven plugin. We should remove it to ensure our tooling 
> behaves consistently.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #176 is FIXED

[Apache Jenkins Server]

Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/176/
 for details.

No further emails will be sent until the status of the build is changed.

[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] removed a comment on pull request #3: SLING-9841: JCR ContentLoader Runmode Support

[GitBox]

sonarcloud[bot] removed a comment on pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/3#issuecomment-712375042


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&reso
 lved=false&types=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&metric=new_coverage&view=list)
 [78.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&metric=new_duplicated_lines_density&view=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] commented on pull request #3: SLING-9841: JCR ContentLoader Runmode Support

[GitBox]

sonarcloud[bot] commented on pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/3#issuecomment-712391845


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&reso
 lved=false&types=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&metric=new_coverage&view=list)
 [84.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&metric=new_duplicated_lines_density&view=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #175 is BROKEN

[Apache Jenkins Server]

sed: 0.088 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletAtDeleteTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.issues.SLING2617Test
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.112 s 
- in org.apache.sling.launchpad.webapp.integrationtest.issues.SLING2617Test
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.teleporter.MultipleRulesTeleporterTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.296 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.teleporter.MultipleRulesTeleporterTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.userManager.UpdateUserTest
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.628 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.userManager.UpdateUserTest
[INFO] Running org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.137 s 
- in org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.auth.AuthenticationResponseCodeTest
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.073 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.auth.AuthenticationResponseCodeTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.PrefixTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.238 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.PrefixTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.issues.SLING760Test
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.068 s 
- in org.apache.sling.launchpad.webapp.integrationtest.issues.SLING760Test
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.ScriptBuiltinObjectsTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.072 s 
- in org.apache.sling.launchpad.webapp.integrationtest.ScriptBuiltinObjectsTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.StreamServletTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.207 s 
- in org.apache.sling.launchpad.webapp.integrationtest.StreamServletTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletNopTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.03 s - 
in 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletNopTest
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   UserPrivilegesInfoTest.testCanRemoveUser:318 expected: but 
was:
[INFO] 
[ERROR] Tests run: 661, Failures: 1, Errors: 0, Skipped: 1
[INFO] 
[INFO] 
[INFO] --- feature-launcher-maven-plugin:0.1.0:stop (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] Stopping launch with id sling-12-oak-tar
[INFO] 
[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-12-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-12-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- apache-rat-plugin:0.11:check (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: src/main/appended-resources/META-INF/*
[INFO] Exclude: velocity.log
[INFO] Exclude: target/*
[INFO] Exclude: README.md
[INFO] Exclude: maven-eclipse.xml
[INFO] Exclude: .*
[INFO] Exclude: .*/**
[INFO] Exclude: **/*.json
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: **/*.rej
[INFO] Exclude: hs_err_*.log
[INFO] Exclude: **/repository/index/*/index-details.txt
[INFO] Exclude: bnd.bnd
[INFO] 6 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 5 licence.
[INFO] 
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  03:05 min
[INFO] Finished at: 2020-10-19T19:11:40Z
[INFO] 
[WARNING] The requested profile "ci" could not be activated because it does not 
exist.
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven33d3b1ff/maven-spy-20201019-190834-804688185562952003595.log
[E

[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] commented on pull request #3: SLING-9841: JCR ContentLoader Runmode Support

[GitBox]

sonarcloud[bot] commented on pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/3#issuecomment-712375042


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&reso
 lved=false&types=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&metric=new_coverage&view=list)
 [78.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=3&metric=new_duplicated_lines_density&view=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[Discuss] - JCR ContentLoader Skip Runmode

[Daniel Klco]

Hey Sling Team,

As Robert mentioned previously[1] using the JCR Content Loader with a
Composite NodeStore is challenging as it keeps track of the status of the
bundles underneath the /var directory.

One of the practical challenges I've also seen with a Composite Repository
is that you actually want the bundle content to re-install when the
Composite Repository loads. For example, if you want a single bundle to
populate the entire repository you may want it to load content under /apps
during seeding and /conf during runtime.

My proposal would be to add a new PathEntry directive, "skipRunmode" which
would skip the installing of a content entry when the Sling instance is
running with the specified runmode. If not specified the content would
still be loaded so this would be backward compatible.

I've created a ticket[2] and have opened a Pull Request with my recommended
changes[3].

Does anyone see any issues with this approach? Does anyone see value in
supporting this at the bundle level vs path level? Any other ideas?

Regards,
Dan

[1] - https://markmail.org/message/xhirmjeyi6mlv635
[2] - https://issues.apache.org/jira/browse/SLING-9841
[3] -
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/3

[GitHub] [sling-org-apache-sling-jcr-contentloader] klcodanr opened a new pull request #3: SLING-9841: JCR ContentLoader Runmode Support

[GitBox]

klcodanr opened a new pull request #3:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/3


   Adding support for skipping the loading of a path when a runmode matches



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-9841) JCR Content Loader Skip on Sling Runmode

[Dan Klco (Jira)]

Dan Klco created SLING-9841:
---

 Summary: JCR Content Loader Skip on Sling Runmode
 Key: SLING-9841
 URL: https://issues.apache.org/jira/browse/SLING-9841
 Project: Sling
  Issue Type: Improvement
Affects Versions: JCR ContentLoader 2.3.0
Reporter: Dan Klco
Assignee: Dan Klco
 Fix For: JCR ContentLoader 2.4.0


As a developer, I want to be able to set a directive in a path entry to skip 
the loading of the path entry when the value matches the current instance 
Runmode.

The new directive should be called "skipRunmode". If not specified (null or 
empty) the content will be loaded.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-site] cmrockwell opened a new pull request #52: Update/release management appendex a

[GitBox]

cmrockwell opened a new pull request #52:
URL: https://github.com/apache/sling-site/pull/52


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-site] cmrockwell opened a new pull request #51: Horizonal scrolling is very common throughout Sling Site docs, and it…

[GitBox]

cmrockwell opened a new pull request #51:
URL: https://github.com/apache/sling-site/pull/51


   … is annoying. This page /documentation/development/release-management.html 
div.column.main was 2333px wide. This is caused by absence of line-breaks 
inside  text and absence of max-width CSS applied to the parent .main css 
class. This commit sets max-width at 1000px for the .main element. If  
text extend beyond that, there will be local horizontal scroll. Therefore 
excessivly long  text won't ruin the experience throughout the page. Added 
line breaks in the example email announcemenbt  text also makes it more 
readable.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Reopened] (SLING-9800) Extract a service to be able to execute GraphQL queries directly

[Andreas Schaefer (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Schaefer reopened SLING-9800:
-

The QueryExecutor.execute() and .validate() is requiring a Resource 
(queryResource) which must be a resource that points to the Endpoint

DefaultQueryExecutor.execute() -> prepareSchemaDefinition() -> 
DefaultSchemaProvider.

getSchema()

I would suggest to the user provides the path to the GraphQL Endpoint as a 
string and the DefaultSchemaProvider is creating an internal resource. So the 
method would look like this:

Map execute(String query, Map variables, String 
queryEndpoint, String[] selectors);

 

> Extract a service to be able to execute GraphQL queries directly
> 
>
> Key: SLING-9800
> URL: https://issues.apache.org/jira/browse/SLING-9800
> Project: Sling
>  Issue Type: Improvement
>  Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: GraphQL Core 0.0.8
>
>
> In the current implementation of the GraphQL Core bundle queries can only be 
> executed via a GraphQL Servlet that needs to be configured or via server-side 
> scripts. It would be good if the queries could also be executed directly, 
> without the need for a request.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9840) Update to Sling Bundle Parent 40

[Eric Norman (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman resolved SLING-9840.

Resolution: Fixed

Fixed at: 
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/commit/041cae1f4caeafae981ff92122ef789221ec0ca8

> Update to Sling Bundle Parent 40
> 
>
> Key: SLING-9840
> URL: https://issues.apache.org/jira/browse/SLING-9840
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Oak Server 1.2.10
>
>
> Update to Sling Bundle Parent 40



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9840) Update to Sling Bundle Parent 40

[Eric Norman (Jira)]

Eric Norman created SLING-9840:
--

 Summary: Update to Sling Bundle Parent 40
 Key: SLING-9840
 URL: https://issues.apache.org/jira/browse/SLING-9840
 Project: Sling
  Issue Type: Sub-task
Reporter: Eric Norman
Assignee: Eric Norman
 Fix For: JCR Oak Server 1.2.10


Update to Sling Bundle Parent 40



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9833) Update to Sling Bundle Parent 40

[Eric Norman (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-9833.
--

Completed with the 3.0.8 release

> Update to Sling Bundle Parent 40
> 
>
> Key: SLING-9833
> URL: https://issues.apache.org/jira/browse/SLING-9833
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit Access Manager 3.0.8
>
>
> Update to Sling Bundle Parent 40



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9812) AccessManager Post servlets should not allow redirects to other hosts

[Eric Norman (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-9812.
--

Completed with the 3.0.8 release

> AccessManager Post servlets should not allow redirects to other hosts
> -
>
> Key: SLING-9812
> URL: https://issues.apache.org/jira/browse/SLING-9812
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit Access Manager 3.0.8
>
>
> Through the {{:redirect}} parameter of the AbstractAccessPostServlet 
> arbitrary redirects are possible. That should be limited so that redirects to 
> other servers are not possible.
>  
> Expected: Apply the same solution that was applied to SlingPostServlet for 
> SLING-4469 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9814) Add canDisable and canChangePassword methods to AuthorizablePrivilegesInfo

[Eric Norman (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-9814.
--

Completed with the 2.2.12 release

> Add canDisable and canChangePassword methods to AuthorizablePrivilegesInfo
> --
>
> Key: SLING-9814
> URL: https://issues.apache.org/jira/browse/SLING-9814
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Minor
> Fix For: JCR Jackrabbit User Manager 2.2.12
>
>
> canDisable - checks whether the current user has privileges to disable the 
> specified user.
> canChangePassword - checks whether the current user has privileges to change 
> the password of the specified user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9832) Update to Sling Bundle Parent 40

[Eric Norman (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-9832.
--

Completed with the 2.2.12 release

> Update to Sling Bundle Parent 40
> 
>
> Key: SLING-9832
> URL: https://issues.apache.org/jira/browse/SLING-9832
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit User Manager 2.2.12
>
>
> Update to Sling Bundle Parent 40



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9808) Add configuration option to always allow users to change their own password

[Eric Norman (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-9808.
--

Completed with the 2.2.12 release

> Add configuration option to always allow users to change their own password
> ---
>
> Key: SLING-9808
> URL: https://issues.apache.org/jira/browse/SLING-9808
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit User Manager 2.2.12
>
>
> Oak generally requires that the user be granted the rep:userManagement 
> privilege in order to be able to call the User.changePassword API.
> However, in an environment where security is more locked down, it may be 
> necessary for the user to have the ability to change their own password but 
> not get all the other access that being granted rep:userManagement would 
> allow (i.e. User.disable or Authorizable.remove)
> To make that possible, the ChangeUserPassword servlet should have a 
> configurable property to specify whether a user is allowed to change their 
> own password even if they haven't been granted the rep:userManagement 
> privilege.  If the user doesn't have the required  rep:userManagement 
> privilege, then the work should be done on their behalf by a service user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9811) UserManager Post servlets should not allow redirects to other hosts

[Eric Norman (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-9811.
--

Completed with the 2.2.12 release

> UserManager Post servlets should not allow redirects to other hosts
> ---
>
> Key: SLING-9811
> URL: https://issues.apache.org/jira/browse/SLING-9811
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit User Manager 2.2.12
>
>
> Through the {{:redirect}} parameter of the AbstractPostServlet arbitrary 
> redirects are possible. That should be limited so that redirects to other 
> servers are not possible.
>  
> Expected: Apply the same solution that was applied to SlingPostServlet for 
> SLING-4469



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9810) Make it possible to change the AuthorizableResourceProvider root path via configuration

[Eric Norman (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-9810.
--

Completed with the 2.2.12 release

> Make it possible to change the AuthorizableResourceProvider root path via 
> configuration
> ---
>
> Key: SLING-9810
> URL: https://issues.apache.org/jira/browse/SLING-9810
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit User Manager 2.2.12
>
>
> The AuthorizableResourceProvider has the provider.root mounted (and 
> semi-hardcoded) at "/system/userManager". 
>  
> Expected: It should be possible to define that "provider.root" value with 
> configuration to mount it at some other path (i.e. "/people").



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9723) switch dependency from oak-core to oak-security-spi

[Eric Norman (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-9723.
--

Completed with the 2.2.12 release

> switch dependency from oak-core to oak-security-spi
> ---
>
> Key: SLING-9723
> URL: https://issues.apache.org/jira/browse/SLING-9723
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit User Manager 2.2.12
>
>
> Refactoring of oak in version 1.8 moved some things around.  To compensate we 
> should switch the dependency from oak-core to oak-security-spi



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9809) Remove loginAdministrative() usage from org.apache.sling.jcr.jackrabbit.usermanager

[Eric Norman (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-9809.
--

Completed with the 2.2.12 release

> Remove loginAdministrative() usage from 
> org.apache.sling.jcr.jackrabbit.usermanager
> ---
>
> Key: SLING-9809
> URL: https://issues.apache.org/jira/browse/SLING-9809
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit User Manager 2.2.12
>
>
> Create a service user and replace usage of loginAdministrative()  to use that 
> service user.
>  
> Counted 2 occurrences in the current source code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9807) AuthorizablePrivilegesInfo is checking for too many privileges for some of the operations

[Eric Norman (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-9807.
--

Completed with the 2.2.12 release

> AuthorizablePrivilegesInfo is checking for too many privileges for some of 
> the operations
> -
>
> Key: SLING-9807
> URL: https://issues.apache.org/jira/browse/SLING-9807
> Project: Sling
>  Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit User Manager 2.2.12
>
>
> canRemove - should require only these privileges:
>  # jcr:read
>  # rep:userManagement
> canUpdateGroupMembers - should require only these privileges:
>  # jcr:read
>  # rep:userManagement 
> canUpdateProperties - should require only these privileges:
>  * when adding a new (non-nested) property
>  ## rep:addProperties
>  * when adding a new nested property
>  ## rep:addProperties
>  ## jcr:addChildNodes
>  * when altering an existing property
>  ## rep:alterProperties
>  * when removing a property
>  ## rep:removeProperties
>  
> For canRemove and canUpdateGroupMembers this can be solved by reducing the 
> set of privileges it is checking for.  For canUpdateProperties, a new 
> variation of that method should be introduced where the user can pass in the 
> types of property updates that are expected to be needed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[RESULT] [VOTE] Release Apache Sling JCR Jackrabbit User Manager 2.2.12, Apache Sling JCR Jackrabbit Access Manager 3.0.8

[Eric Norman]

Hi,

The vote has passed with the following result :

+1 (binding): Eric Norman, Daniel Klco, Robert Munteanu
+1 (non binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

[jira] [Closed] (SLING-9831) Update to Sling Bundle Parent 40

[Eric Norman (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-9831.
--

Completed with the 3.1.4 release

> Update to Sling Bundle Parent 40
> 
>
> Key: SLING-9831
> URL: https://issues.apache.org/jira/browse/SLING-9831
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Scripting JavaScript 3.1.4
>
>
> Update to Sling Bundle Parent 39



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9792) ScriptCache interaction with RhinoJavaScriptEngineFactory is not thread safe

[Eric Norman (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-9792.
--

Completed with the 3.1.4 release

> ScriptCache interaction with RhinoJavaScriptEngineFactory is not thread safe
> 
>
> Key: SLING-9792
> URL: https://issues.apache.org/jira/browse/SLING-9792
> Project: Sling
>  Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Scripting JavaScript 3.1.4
>
>
> During startup, the RhinoJavaScriptEngineFactory component may become 
> deactivated temporarily.  The ScriptCacheImpl#handleEvent (running in another 
> thread) may concurrently attempt to get the script engine from the factory.  
> At this point, the deactivated factory may still be in the engine list 
> because it hasn't been unbound from the ScriptEngineManager yet.  In that 
> case, the RhinoJavaScriptEngineFactory#getScriptEngine call from 
> ScriptCacheImpl#handleEvent throws a series of NullPointerExceptions related 
> to usage of field that was nulled during the 
> RhinoJavaScriptEngineFactory#deactivate logic.
> For example:
>  
> {noformat}
> 03.10.2020 13:20:29.237 *WARN* [EventAdminAsyncThread #6] 
> org.apache.sling.scripting.javascript.internal.RhinoJavaScriptEngineFactory 
> addHostObjects: Cannot prepare host object class 
> org.apache.sling.scripting.javascript.wrapper.ScriptableResource
> java.lang.NullPointerException: null
> at 
> org.apache.sling.scripting.javascript.internal.RhinoJavaScriptEngineFactory.addHostObjects(RhinoJavaScriptEngineFactory.java:342)
>  [org.apache.sling.scripting.javascript:3.1.3.20201003201741112]
> at 
> org.apache.sling.scripting.javascript.internal.RhinoJavaScriptEngineFactory.getRootScope(RhinoJavaScriptEngineFactory.java:195)
>  [org.apache.sling.scripting.javascript:3.1.3.20201003201741112]
> at 
> org.apache.sling.scripting.javascript.internal.RhinoJavaScriptEngineFactory.getScriptEngine(RhinoJavaScriptEngineFactory.java:142)
>  [org.apache.sling.scripting.javascript:3.1.3.20201003201741112]
> at 
> org.apache.sling.scripting.core.impl.jsr223.SortableScriptEngineFactory.getScriptEngine(SortableScriptEngineFactory.java:120)
>  [org.apache.sling.scripting.core:2.3.5.SNAPSHOT]
> at 
> org.apache.sling.scripting.core.impl.ScriptCacheImpl.handleEvent(ScriptCacheImpl.java:283)
>  [org.apache.sling.scripting.core:2.3.5.SNAPSHOT]
> at 
> org.apache.felix.eventadmin.impl.handler.EventHandlerProxy.sendEvent(EventHandlerProxy.java:415)
> at 
> org.apache.felix.eventadmin.impl.tasks.HandlerTask.runWithoutBlacklistTiming(HandlerTask.java:82)
>  [org.apache.felix.eventadmin:1.5.0]
> at 
> org.apache.felix.eventadmin.impl.tasks.SyncDeliverTasks.execute(SyncDeliverTasks.java:104)
>  [org.apache.felix.eventadmin:1.5.0]
> at 
> org.apache.felix.eventadmin.impl.tasks.AsyncDeliverTasks$TaskExecuter.run(AsyncDeliverTasks.java:166)
>  [org.apache.felix.eventadmin:1.5.0]
> at 
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:834)
> 03.10.2020 13:20:29.239 *WARN* [EventAdminAsyncThread #6] 
> org.apache.sling.scripting.javascript.internal.RhinoJavaScriptEngineFactory 
> addHostObjects: Cannot prepare host object class 
> org.apache.sling.scripting.javascript.wrapper.ScriptableNode
> java.lang.NullPointerException: null
> at 
> org.apache.sling.scripting.javascript.internal.RhinoJavaScriptEngineFactory.addHostObjects(RhinoJavaScriptEngineFactory.java:342)
>  [org.apache.sling.scripting.javascript:3.1.3.20201003201741112]
> at 
> org.apache.sling.scripting.javascript.internal.RhinoJavaScriptEngineFactory.getRootScope(RhinoJavaScriptEngineFactory.java:195)
>  [org.apache.sling.scripting.javascript:3.1.3.20201003201741112]
> at 
> org.apache.sling.scripting.javascript.internal.RhinoJavaScriptEngineFactory.getScriptEngine(RhinoJavaScriptEngineFactory.java:142)
>  [org.apache.sling.scripting.javascript:3.1.3.20201003201741112]
> at 
> org.apache.sling.scripting.core.impl.jsr223.SortableScriptEngineFactory.getScriptEngine(SortableScriptEngineFactory.java:120)
>  [org.apache.sling.scripting.core:2.3.5.SNAPSHOT]
> at 
> org.apache.sling.scripting.core.impl.ScriptCacheImpl.handleEvent(ScriptCacheImpl.java:283)
>  [org.apache.sling.scripting.core:2.3.5.SNAPSHOT]
> at 
> org.apache.felix.eventadmin.impl.handler.EventHandlerProxy.sendEvent(EventHandlerProxy.java:415)
> at 

[RESULT] [VOTE] Release Apache Sling Scripting JavaScript 3.1.4

[Eric Norman]

Hi,

The vote has passed with the following result :

+1 (binding): Eric Norman, Carsten Ziegeler, Radu Cotescu, Daniel Klco
+1 (non binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Re: How to 'spin a release'

[Konrad Windszus]

Indeed step 4 can only be done by a PMC. Also your other suggestions seem 
reasonable.
Can you come up with a PR to clarify the steps in 
https://github.com/apache/sling-site/blob/master/src/main/jbake/content/documentation/development/release-management.md
 
?

Thanks,
Konrad

> On 19. Oct 2020, at 16:30, Cris Rockwell  wrote:
> 
> Hi Konrad and Robert
> 
> Thanks for the info. I added my fingerprint to my Apache ID Friday morning. 
> Seems that it could take a few days to update, but my key is now in the list 
> https://people.apache.org/keys/group/sling.asc
> 
> But my key is not included here
> https://downloads.apache.org/sling/KEYS
> 
> 
> As far the docs go. I have a two suggestions
> 
> Swap step 2 with step 3. Step 2.3 says “you are DONE” but there are more 
> steps. I think it may be important to have the public key uploaded to a key 
> server before updating the Apache ID with the key fingerprint.
> 
> Regarding Step 4. I tried updating KEYS, but don’t have access to commit 
> changes. Is it likely that somebody has access to edit KEYS, and also needs 
> to add their own public key? From an on-boarding perspective, I think most 
> new committers won’t be able to edit KEYS. If it's a step that should be 
> performed by another committer, then the docs could reflect that by 
> indicating the role of the person in charge of step #4
> 
> Thanks
> Cris
> 
> 
>> On Oct 19, 2020, at 3:33 AM, Konrad Windszus  wrote:
>> 
>> Hi Cris and Robert,
>> 
>> after doing those steps you still need to manually add your key to the keys 
>> file as outlined in https://issues.apache.org/jira/browse/SLING-9173 
>> >  >.
>> It is not generated automatically!
>> 
>> We still need to update 
>> https://sling.apache.org/documentation/development/release-management.html 
>>  
>> > >
>>  to reflect that.
>> 
>> Thanks,
>> Konrad
>> 
>>> On 19. Oct 2020, at 09:30, Robert Munteanu >> > wrote:
>>> 
>>> Hi Cris,
>>> 
>>> On Fri, 2020-10-16 at 12:24 -0400, Cris Rockwell wrote:
 Regarding
 
 
 Konrad Windszus commented on SLING-9648:
 
 Someone would need to spin a release. [~cris_rockwell] Do you want to
 give it a try?
 
 
 Sure! Haven't released to Maven Central before, so I would like to
 try. I found a release management doc <
 https://sling.apache.org/documentation/development/release-management.html
> on the Sling website. But as of now, my keys is not included in
 the linked sling.asc file
>>> 
>>> Try logging in to https://id.apache.org  
>>> > . You should see a form 
>>> with a
>>> field named 'OpenPGP Public Key Primary Fingerprint: '. Fill it in with
>>> the corresponding information and submit. The sling.asc file should be
>>> regenerated, but I'm not sure if it's immediate or needs some time.
>>> 
>>> Thanks,
>>> Robert
> 

[GitHub] [sling-org-apache-sling-models-impl] cjelger edited a comment on pull request #21: SLING-9834 - [Sling Models] Caching bug with reused Servlet requests

[GitBox]

cjelger edited a comment on pull request #21:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/21#issuecomment-712216861


   @cziegeler @raducotescu I included your PR feedback: keep one single method 
to get or create the cache, and `synchronized` it on the adaptable to make sure 
we don't get any race condition. However SunarQube complains about the 
`synchronized` block because it's done on a method parameter, although here we 
exactly want to synchronize that block **_per_** adaptable and it's declared 
`final`. Not sure if this is a strict check and I should fix or not. WDYT?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-impl] cjelger commented on pull request #21: SLING-9834 - [Sling Models] Caching bug with reused Servlet requests

[GitBox]

cjelger commented on pull request #21:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/21#issuecomment-712216861


   @cziegeler @raducotescu I included your PR feedback: keep one single method 
to get or create the cache, and `synchronized` it on the adaptable to make sure 
we don't get any race condition. However SunarQube complains about the 
`synchronized` block because it's done on a method parameter, although here we 
exactly want to synchronize that block **_per_** adaptable. Not sure if this is 
a strict check ad I should fix or not. WDYT?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling Scripting JavaScript 3.1.4

[Daniel Klco]

+1

On Mon, Oct 19, 2020 at 7:23 AM Radu Cotescu  wrote:

> +1
>
> > On 15 Oct 2020, at 20:42, Eric Norman  wrote:
> >
> > Please vote to approve this release:
> >
> >  [ ] +1 Approve the release
> >  [ ]  0 Don't care
> >  [ ] -1 Don't release, because ...
>
>

[GitHub] [sling-org-apache-sling-models-impl] sonarcloud[bot] commented on pull request #21: SLING-9834 - [Sling Models] Caching bug with reused Servlet requests

[GitBox]

sonarcloud[bot] commented on pull request #21:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/21#issuecomment-712211298


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=BUG)
 [1 
Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=SEC
 URITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=CODE_SMELL)
 [4 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_coverage&view=list)
 [94.1% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_duplicated_lines_density&view=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-impl] sonarcloud[bot] removed a comment on pull request #21: SLING-9834 - [Sling Models] Caching bug with reused Servlet requests

[GitBox]

sonarcloud[bot] removed a comment on pull request #21:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/21#issuecomment-712196068


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=BUG)
 [3 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=SEC
 URITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=CODE_SMELL)
 [4 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_coverage&view=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_duplicated_lines_density&view=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: How to 'spin a release'

[Cris Rockwell]

Hi Konrad and Robert

Thanks for the info. I added my fingerprint to my Apache ID Friday morning. 
Seems that it could take a few days to update, but my key is now in the list 
https://people.apache.org/keys/group/sling.asc

But my key is not included here
https://downloads.apache.org/sling/KEYS


As far the docs go. I have a two suggestions

Swap step 2 with step 3. Step 2.3 says “you are DONE” but there are more steps. 
I think it may be important to have the public key uploaded to a key server 
before updating the Apache ID with the key fingerprint.

Regarding Step 4. I tried updating KEYS, but don’t have access to commit 
changes. Is it likely that somebody has access to edit KEYS, and also needs to 
add their own public key? From an on-boarding perspective, I think most new 
committers won’t be able to edit KEYS. If it's a step that should be performed 
by another committer, then the docs could reflect that by indicating the role 
of the person in charge of step #4

Thanks
Cris


> On Oct 19, 2020, at 3:33 AM, Konrad Windszus  wrote:
> 
> Hi Cris and Robert,
> 
> after doing those steps you still need to manually add your key to the keys 
> file as outlined in https://issues.apache.org/jira/browse/SLING-9173 
>   >.
> It is not generated automatically!
> 
> We still need to update 
> https://sling.apache.org/documentation/development/release-management.html 
>  
>  > 
> to reflect that.
> 
> Thanks,
> Konrad
> 
>> On 19. Oct 2020, at 09:30, Robert Munteanu > > wrote:
>> 
>> Hi Cris,
>> 
>> On Fri, 2020-10-16 at 12:24 -0400, Cris Rockwell wrote:
>>> Regarding
>>> 
>>> 
>>> Konrad Windszus commented on SLING-9648:
>>> 
>>> Someone would need to spin a release. [~cris_rockwell] Do you want to
>>> give it a try?
>>> 
>>> 
>>> Sure! Haven't released to Maven Central before, so I would like to
>>> try. I found a release management doc <
>>> https://sling.apache.org/documentation/development/release-management.html
 on the Sling website. But as of now, my keys is not included in
>>> the linked sling.asc file
>> 
>> Try logging in to https://id.apache.org  
>> > . You should see a form 
>> with a
>> field named 'OpenPGP Public Key Primary Fingerprint: '. Fill it in with
>> the corresponding information and submit. The sling.asc file should be
>> regenerated, but I'm not sure if it's immediate or needs some time.
>> 
>> Thanks,
>> Robert

[GitHub] [sling-org-apache-sling-models-impl] sonarcloud[bot] commented on pull request #21: SLING-9834 - [Sling Models] Caching bug with reused Servlet requests

[GitBox]

sonarcloud[bot] commented on pull request #21:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/21#issuecomment-712196068


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=BUG)
 [3 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=SEC
 URITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=CODE_SMELL)
 [4 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_coverage&view=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_duplicated_lines_density&view=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-impl] sonarcloud[bot] removed a comment on pull request #21: SLING-9834 - [Sling Models] Caching bug with reused Servlet requests

[GitBox]

sonarcloud[bot] removed a comment on pull request #21:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/21#issuecomment-709909993


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=SEC
 URITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_coverage&view=list)
 [80.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=21&metric=new_duplicated_lines_density&view=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-impl] raducotescu commented on a change in pull request #21: SLING-9834 - [Sling Models] Caching bug with reused Servlet requests

[GitBox]

raducotescu commented on a change in pull request #21:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/21#discussion_r507719558



##
File path: src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java
##
@@ -404,11 +430,7 @@ public boolean isModelClass(@NotNull Class type) {
 ModelType model = (ModelType) 
Proxy.newProxyInstance(modelClass.getType().getClassLoader(), new Class[] { 
modelClass.getType() }, handlerResult.getValue());
 
 if (modelAnnotation.cache()) {
-Map, SoftReference> 
adaptableCache = adapterCache.get(cacheKey);
-if (adaptableCache == null) {
-adaptableCache = 
Collections.synchronizedMap(new WeakHashMap, SoftReference>());
-adapterCache.put(cacheKey, adaptableCache);
-}
+Map, SoftReference> 
adaptableCache = getOrCreateCache(adaptable);

Review comment:
   I think my question was not clear enough. I'm saying that if the 
`modelAnnotation#cache` returns `true`, we can already create the cache for the 
`adaptable` at 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/21/files#diff-0c273224a9fa6e263f4381c5d4b8145aa2c6c89e75e0b62025eea5efa17edec9R401,
 using `getOrCreate`.
   
   Further down, you just need to populate the cache. I think the `getCache` 
and `getOrCreate` should be merged and make the code simpler to read.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-impl] cjelger commented on a change in pull request #21: SLING-9834 - [Sling Models] Caching bug with reused Servlet requests

[GitBox]

cjelger commented on a change in pull request #21:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/21#discussion_r507682094



##
File path: src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java
##
@@ -404,11 +430,7 @@ public boolean isModelClass(@NotNull Class type) {
 ModelType model = (ModelType) 
Proxy.newProxyInstance(modelClass.getType().getClassLoader(), new Class[] { 
modelClass.getType() }, handlerResult.getValue());
 
 if (modelAnnotation.cache()) {
-Map, SoftReference> 
adaptableCache = adapterCache.get(cacheKey);
-if (adaptableCache == null) {
-adaptableCache = 
Collections.synchronizedMap(new WeakHashMap, SoftReference>());
-adapterCache.put(cacheKey, adaptableCache);
-}
+Map, SoftReference> 
adaptableCache = getOrCreateCache(adaptable);

Review comment:
   No, the same adaptable can be adapted to multiple types. For example, 
the request could be adapted first to `MyFirstModel.class` and then to 
`MySecondModel.class`: so in the first case there is no cache and of course no 
cached model, but in the 2nd case, the cache exists but doesn't contain a 
cached model for the `MySecondModel.class` (but would contain a cached model 
for `MyFirstModel.class`).





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-impl] cjelger commented on a change in pull request #21: SLING-9834 - [Sling Models] Caching bug with reused Servlet requests

[GitBox]

cjelger commented on a change in pull request #21:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/21#discussion_r507677579



##
File path: src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java
##
@@ -404,11 +430,7 @@ public boolean isModelClass(@NotNull Class type) {
 ModelType model = (ModelType) 
Proxy.newProxyInstance(modelClass.getType().getClassLoader(), new Class[] { 
modelClass.getType() }, handlerResult.getValue());
 
 if (modelAnnotation.cache()) {
-Map, SoftReference> 
adaptableCache = adapterCache.get(cacheKey);
-if (adaptableCache == null) {
-adaptableCache = 
Collections.synchronizedMap(new WeakHashMap, SoftReference>());
-adapterCache.put(cacheKey, adaptableCache);
-}
+Map, SoftReference> 
adaptableCache = getOrCreateCache(adaptable);

Review comment:
   No there could be a cache with the same `adaptable` but a different 
"target" model class. For example, one could first `adapt` the request to 
`MyModel.class` and then to `MyOtherModel.class`. So in the first case, the 
cache doesn't exist and the model is of course not cached, but in the 2nd case, 
the cache exists but the model is also not cached.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling Scripting JavaScript 3.1.4

[Radu Cotescu]

+1

> On 15 Oct 2020, at 20:42, Eric Norman  wrote:
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...

Re: [VOTE] Release Apache Sling JUnit Core 1.1.0

[Radu Cotescu]

+1

> On 16 Oct 2020, at 11:27, Julian Sedding  wrote:
> 
> Please vote to approve this release:
> 
>[  ]  +1 Approve the release
>[  ]0 Don't care
>[  ]   -1 Don't release, because ...

[GitHub] [sling-org-apache-sling-models-impl] raducotescu commented on a change in pull request #21: SLING-9834 - [Sling Models] Caching bug with reused Servlet requests

[GitBox]

raducotescu commented on a change in pull request #21:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/21#discussion_r507661762



##
File path: src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java
##
@@ -404,11 +430,7 @@ public boolean isModelClass(@NotNull Class type) {
 ModelType model = (ModelType) 
Proxy.newProxyInstance(modelClass.getType().getClassLoader(), new Class[] { 
modelClass.getType() }, handlerResult.getValue());
 
 if (modelAnnotation.cache()) {
-Map, SoftReference> 
adaptableCache = adapterCache.get(cacheKey);
-if (adaptableCache == null) {
-adaptableCache = 
Collections.synchronizedMap(new WeakHashMap, SoftReference>());
-adapterCache.put(cacheKey, adaptableCache);
-}
+Map, SoftReference> 
adaptableCache = getOrCreateCache(adaptable);

Review comment:
   Don't we already know here that there was no cache created for this 
`adaptable`? If a cache was available, we would have returned the result 
already - see 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/21/files#diff-0c273224a9fa6e263f4381c5d4b8145aa2c6c89e75e0b62025eea5efa17edec9R401.

##
File path: src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java
##
@@ -421,11 +443,7 @@ public boolean isModelClass(@NotNull Class type) {
 result = createObject(adaptable, modelClass);
 
 if (result.wasSuccessful() && modelAnnotation.cache()) 
{
-Map, SoftReference> 
adaptableCache = adapterCache.get(cacheKey);
-if (adaptableCache == null) {
-adaptableCache = 
Collections.synchronizedMap(new WeakHashMap, SoftReference>());
-adapterCache.put(cacheKey, adaptableCache);
-}
+Map, SoftReference> 
adaptableCache = getOrCreateCache(adaptable);

Review comment:
   Don't we already know here that there was no cache created for this 
`adaptable`? If a cache was available, we would have returned the result 
already - see 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/21/files#diff-0c273224a9fa6e263f4381c5d4b8145aa2c6c89e75e0b62025eea5efa17edec9R401.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-9173) Add KEYS file to https://dist.apache.org/repos/dist/release/sling

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216620#comment-17216620
 ] 

Konrad Windszus commented on SLING-9173:


Does anyone know how to verify the signature with gpg against 
https://downloads.apache.org/sling/KEYS? Even 
https://www.apache.org/info/verification does not really outline how to verify 
without using the chain of trust!

> Add KEYS file to https://dist.apache.org/repos/dist/release/sling
> -
>
> Key: SLING-9173
> URL: https://issues.apache.org/jira/browse/SLING-9173
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Reporter: Konrad Windszus
>Priority: Major
>
> The link at https://sling.apache.org/downloads.cgi to 
> https://www.apache.org/dist/sling/KEYS is broken, because the KEYS file has 
> been removed in 2013 from the dist directory.
> The file needs to be reestablished and 
> https://sling.apache.org/documentation/development/release-management.html#appendix-a-create-and-add-your-key-to-peopleapacheorg
>  need to be updated.
> Compare with the discussion at  
> https://lists.apache.org/thread.html/ra6807cd9c8d7921f4441f621b43c92aa90cb0380b0190e0da1461939%40%3Cdev.sling.apache.org%3E
> It is not allowed to instead just reference the file from 
> https://people.apache.org/keys/group/sling.asc, for a reasoning look at 
> https://people.apache.org/keys/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9173) Add KEYS file to https://dist.apache.org/repos/dist/release/sling

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216617#comment-17216617
 ] 

Konrad Windszus commented on SLING-9173:


I extended the appendix A with 
https://github.com/apache/sling-site/commit/9458315d4671a02a0297f05123f2f4501375be09.

> Add KEYS file to https://dist.apache.org/repos/dist/release/sling
> -
>
> Key: SLING-9173
> URL: https://issues.apache.org/jira/browse/SLING-9173
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Reporter: Konrad Windszus
>Priority: Major
>
> The link at https://sling.apache.org/downloads.cgi to 
> https://www.apache.org/dist/sling/KEYS is broken, because the KEYS file has 
> been removed in 2013 from the dist directory.
> The file needs to be reestablished and 
> https://sling.apache.org/documentation/development/release-management.html#appendix-a-create-and-add-your-key-to-peopleapacheorg
>  need to be updated.
> Compare with the discussion at  
> https://lists.apache.org/thread.html/ra6807cd9c8d7921f4441f621b43c92aa90cb0380b0190e0da1461939%40%3Cdev.sling.apache.org%3E
> It is not allowed to instead just reference the file from 
> https://people.apache.org/keys/group/sling.asc, for a reasoning look at 
> https://people.apache.org/keys/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-9834) [Sling Models] Caching bug with reused Servlet requests

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-9834:
---

Assignee: Radu Cotescu

> [Sling Models] Caching bug with reused Servlet requests
> ---
>
> Key: SLING-9834
> URL: https://issues.apache.org/jira/browse/SLING-9834
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Sling Models Impl 1.4.14
>Reporter: Christophe Jelger
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Sling Models Impl 1.4.16
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The fix from https://issues.apache.org/jira/browse/SLING-9781 introduces 
> another unexpected issue because a container like Jetty may reuse 
> ServletRequest objects, so this means that Sling models might be cached 
> across different HTTP requests because of the unwrapping introduced by 
> SLING-9781.
> After a quick discussion with [~cziegeler] and [~justin], it is actually best 
> to use the ServletRequest attributes to store the cached models and avoid any 
> unwrapping.
> I'll provide a PR with a fix.
> cc: [~radu]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9755) Make annotation parsing in ModelPackageBundleListener.analyzeClass() more lenient

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu closed SLING-9755.
---

> Make annotation parsing in ModelPackageBundleListener.analyzeClass() more 
> lenient
> -
>
> Key: SLING-9755
> URL: https://issues.apache.org/jira/browse/SLING-9755
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Affects Versions: Sling Models Impl 1.4.12
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Models Impl 1.4.14
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> I have seen an exception like this
> {code}
> [ERROR] myPackage.MyTest.testMethod  Time elapsed: 0.052 s  <<< ERROR!
> java.lang.annotation.AnnotationFormatError: Invalid default: public abstract 
> java.lang.Class com.adobe.granite.haf.annotations.ApiModel.modelLookup()
> at java.lang.reflect.Method.getDefaultValue(Method.java:612)
> at 
> sun.reflect.annotation.AnnotationType.(AnnotationType.java:132)
> at 
> sun.reflect.annotation.AnnotationType.getInstance(AnnotationType.java:85)
> at 
> sun.reflect.annotation.AnnotationParser.parseAnnotation2(AnnotationParser.java:266)
> at 
> sun.reflect.annotation.AnnotationParser.parseAnnotations2(AnnotationParser.java:120)
> at 
> sun.reflect.annotation.AnnotationParser.parseAnnotations(AnnotationParser.java:72)
> at java.lang.Class.createAnnotationData(Class.java:3521)
> at java.lang.Class.annotationData(Class.java:3510)
> at java.lang.Class.getAnnotation(Class.java:3415)
> at 
> org.apache.sling.models.impl.ModelPackageBundleListener.analyzeClass(ModelPackageBundleListener.java:145)
> at 
> org.apache.sling.models.impl.ModelPackageBundleListener.addingBundle(ModelPackageBundleListener.java:125)
> at 
> org.apache.sling.models.impl.ModelPackageBundleListener.addingBundle(ModelPackageBundleListener.java:52)
> at 
> org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:475)
> at 
> org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:420)
> at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
> at 
> org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
> at 
> org.osgi.util.tracker.BundleTracker$Tracked.bundleChanged(BundleTracker.java:450)
> at 
> org.apache.sling.testing.mock.osgi.MockBundleContext.sendBundleEvent(MockBundleContext.java:383)
> at 
> org.apache.sling.testing.mock.osgi.MockOsgi.sendBundleEvent(MockOsgi.java:62)
> at 
> org.apache.sling.testing.mock.sling.context.ModelAdapterFactoryUtil.addModelsForPackages(ModelAdapterFactoryUtil.java:95)
> at 
> org.apache.sling.testing.mock.sling.context.ModelAdapterFactoryUtil.addModelsForManifestEntries(ModelAdapterFactoryUtil.java:128)
> at 
> org.apache.sling.testing.mock.sling.context.SlingContextImpl.registerDefaultServices(SlingContextImpl.java:187)
> at 
> io.wcm.testing.mock.aem.context.AemContextImpl.registerDefaultServices(AemContextImpl.java:67)
> at 
> org.apache.sling.testing.mock.sling.context.SlingContextImpl.setUp(SlingContextImpl.java:131)
> at 
> io.wcm.testing.mock.aem.context.AemContextImpl.setUp(AemContextImpl.java:94)
> at 
> io.wcm.testing.mock.aem.junit.AemContext.access$100(AemContext.java:49)
> at 
> io.wcm.testing.mock.aem.junit.AemContext$1.before(AemContext.java:183)
> at 
> org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:46)
> at 
> org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.evaluateStatement(PowerMockJUnit47RunnerDelegateImpl.java:107)
> at 
> org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTest(PowerMockJUnit47RunnerDelegateImpl.java:82)
> at 
> org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runBeforesThenTestThenAfters(PowerMockJUnit44RunnerDelegateImpl.java:298)
> at 
> org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:87)
> at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:50)
> at 
> org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.invokeTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:218)
> at 
> org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.runMethods(PowerMockJUnit44RunnerDelegateImpl.java:160)
> at 
> org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl

[jira] [Closed] (SLING-8858) Model Cache causes NPE in sling.models.impl 1.4.10+

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu closed SLING-8858.
---

> Model Cache causes NPE in sling.models.impl 1.4.10+
> ---
>
> Key: SLING-8858
> URL: https://issues.apache.org/jira/browse/SLING-8858
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Affects Versions: Sling Models Impl 1.4.10
> Environment: Java SE 1.8.0_231
>Reporter: Frank Pauleickhoff
>Assignee: Dan Klco
>Priority: Major
> Fix For: Sling Models Impl 1.4.14
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> In AEM 6.4 ServicePack 6 we face NullPointerExceptions when using the Sling 
> model cache that used to work before (in SP 3).
> *Exception Stacktrace is:*
> {code:java}
> 22.11.2019 15:29:22.525 *ERROR* [127.0.0.1 [1574432957337] GET 
> /content/mypage.html HTTP/1.1] 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught 
> SlingException
> org.apache.sling.scripting.sightly.SightlyException: 
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript: 
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript: 
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript: 
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript: 
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript: 
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript: 
> Identifier xx.xxx.MyModel cannot be correctly instantiated by the Use API
> [...]
> Caused by: java.lang.NullPointerException: null
>  at 
> org.apache.sling.models.impl.ModelAdapterFactory.internalCreateModel(ModelAdapterFactory.java:407)
>  at 
> org.apache.sling.models.impl.ModelAdapterFactory.createModel(ModelAdapterFactory.java:314)
> {code}
> Problem seems to be related to introduction of WeakReferences in SLING-7586. 
> Without knowing any details and being deeply into the Sling Model Caching 
> implementation, I think a null-check is missing for "SoftReference" in Line 
> 407:
> {code:java}
> SoftReference SoftReference = adaptableCache.get(requestedType);
> ModelType cachedObject = (ModelType) SoftReference.get();
> {code}
> That seems to cause caching to throw NPE for any not yet cached model.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9781) [Sling Models] Caching doesn't work with Wrapped requests

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu closed SLING-9781.
---

> [Sling Models] Caching doesn't work with Wrapped requests
> -
>
> Key: SLING-9781
> URL: https://issues.apache.org/jira/browse/SLING-9781
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Sling Models Impl 1.4.12
>Reporter: Christophe Jelger
>Assignee: Justin Edelson
>Priority: Major
> Fix For: Sling Models Impl 1.4.14
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> The caching of Sling models doesn't work when the original 
> {{SlingHttpServletRequest}} is wrapped in a request wrapper, like this is 
> typically done in HTL scripts with the {{OnDemandReaderRequest}} wrapper.
> The solution is to use the original request when caching models so that any 
> wrapping does not interfere with the caching. When someone enables caching 
> for a model adapted from request, I think the expectation is that caching 
> does happen whenever the original request is wrapped.
> I'll provide a PR with a fix.
> cc: [~justinedelson] [~radu] as discussed in Slack.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9782) Failure in loading vanity paths due to query limit being reached

[Carsten Ziegeler (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216606#comment-17216606
 ] 

Carsten Ziegeler commented on SLING-9782:
-

[~jsedding] - Thanks for the suggestion - I've updated the implementation to 
log every 5 minutes. Does this look ok to you?

[~rombert] Thanks for pointing out, I've renamed the variable

> Failure in loading vanity paths due to query limit being reached
> 
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.0
>Reporter: Robert Munteanu
>Assignee: Carsten Ziegeler
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(E

[jira] [Closed] (SLING-9828) Processor is not called for sources if source jar is disabled

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-9828.
---

> Processor is not called for sources if source jar is disabled
> -
>
> Key: SLING-9828
> URL: https://issues.apache.org/jira/browse/SLING-9828
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: OSGi Feature Maven Plugin 1.4.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.4.4
>
>
> When the source jar creation is disabled, but javadoc jar creation is 
> enabled, the processor needs to be called to process the sources - which is 
> currently not the case



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[VOTE RESULT] Release Apache Sling slingfeature-maven-plugin 1.4.4

[Carsten Ziegeler]

The vote passes with four binding +1 votes

Thanks
Carsten

--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling slingfeature-maven-plugin 1.4.4

[Carsten Ziegeler]

+1

Carsten

Am 15.10.2020 um 08:01 schrieb Carsten Ziegeler:

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING-9828

Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2355/


You can use this UNIX script to download the release and verify the 
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD 



Usage:
sh check_staged_release.sh 2355 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling JCR Jackrabbit User Manager 2.2.12, Apache Sling JCR Jackrabbit Access Manager 3.0.8

[Robert Munteanu]

On Thu, 2020-10-15 at 15:41 -0700, Eric Norman wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling JUnit Core 1.1.0

[Robert Munteanu]

On Fri, 2020-10-16 at 11:27 +0200, Julian Sedding wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling Scripting JavaScript 3.1.4

[Robert Munteanu]

On Thu, 2020-10-15 at 11:42 -0700, Eric Norman wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #172 is FIXED

[Apache Jenkins Server]

Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/172/
 for details.

No further emails will be sent until the status of the build is changed.

[jira] [Commented] (SLING-9839) Jenkins: Sonarcloud analysis with Java 11

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216518#comment-17216518
 ] 

Konrad Windszus commented on SLING-9839:


The SonarCloud analysis will fail for modules not buildable with Java 11 anyhow 
(as support for Java 8 is gonna be removed), so IMHO making it fail right now 
is an advantage. That allows to easily track which modules still need an update 
to the latest parent.

> Jenkins: Sonarcloud analysis with Java 11
> -
>
> Key: SLING-9839
> URL: https://issues.apache.org/jira/browse/SLING-9839
> Project: Sling
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Priority: Major
>
> As SonarSource is stopping support for Java 8 analysis 
> (https://sonarcloud.io/documentation/appendices/move-analysis-java-11/), we 
> should switch to matrix builds with Jenkins with Java 8 and 11 builds in 
> parallel 
> (https://www.jenkins.io/blog/2019/12/02/matrix-building-with-scripted-pipeline/
>  ).
> The Java 8 build should be deployed to Apache Snapshots (for backwards 
> compatibility reasons). The Java 11 build should be used for coverage 
> analysis and sonar execution..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9839) Jenkins: Sonarcloud analysis with Java 11

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216515#comment-17216515
 ] 

Robert Munteanu commented on SLING-9839:


Yes, we need to adapt somehow to these changes. One thing to keep in mind is 
that not all modules will build on Java 11 (but I don't have numbers ATM).

> Jenkins: Sonarcloud analysis with Java 11
> -
>
> Key: SLING-9839
> URL: https://issues.apache.org/jira/browse/SLING-9839
> Project: Sling
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Priority: Major
>
> As SonarSource is stopping support for Java 8 analysis 
> (https://sonarcloud.io/documentation/appendices/move-analysis-java-11/), we 
> should switch to matrix builds with Jenkins with Java 8 and 11 builds in 
> parallel 
> (https://www.jenkins.io/blog/2019/12/02/matrix-building-with-scripted-pipeline/
>  ).
> The Java 8 build should be deployed to Apache Snapshots (for backwards 
> compatibility reasons). The Java 11 build should be used for coverage 
> analysis and sonar execution..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9838) Jenkins builds fail: ERROR: Could not find the JDK installation: JDK 1.8 (latest)

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9838.

Resolution: Fixed

Fixed with [sling-tooling-jenkins commit 
85f35e1|https://github.com/apache/sling-tooling-jenkins/commit/85f35e1].

> Jenkins builds fail: ERROR: Could not find the JDK installation: JDK 1.8 
> (latest)
> -
>
> Key: SLING-9838
> URL: https://issues.apache.org/jira/browse/SLING-9838
> Project: Sling
>  Issue Type: Bug
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Critical
>
> With INFRA-20858 the names of the tools have changed and we need to update, 
> otherwise all builds will keep failing. A more detailed description and a 
> discussion is at 
> https://lists.apache.org/thread.html/rb4c2834b9874b9f4a74c528de9055958483d2bc6e62c3464bc5c053f%40%3Cbuilds.apache.org%3E
>  ..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9839) Jenkins: Sonarcloud analysis with Java 11

[Konrad Windszus (Jira)]

Konrad Windszus created SLING-9839:
--

 Summary: Jenkins: Sonarcloud analysis with Java 11
 Key: SLING-9839
 URL: https://issues.apache.org/jira/browse/SLING-9839
 Project: Sling
  Issue Type: Improvement
Reporter: Konrad Windszus


As SonarSource is stopping support for Java 8 analysis 
(https://sonarcloud.io/documentation/appendices/move-analysis-java-11/), we 
should switch to matrix builds with Jenkins with Java 8 and 11 builds in 
parallel 
(https://www.jenkins.io/blog/2019/12/02/matrix-building-with-scripted-pipeline/ 
).
The Java 8 build should be deployed to Apache Snapshots (for backwards 
compatibility reasons). The Java 11 build should be used for coverage analysis 
and sonar execution..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #170 is BROKEN

[Robert Munteanu]

Hi,

On Sat, 2020-10-17 at 15:52 +, Apache Jenkins Server wrote:
> Please see 
> https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/170/
>  for details.

This is caused by an infra changed and tracked with SLING-9838 [1].

Thanks,
Robert

[1]: https://issues.apache.org/jira/browse/SLING-9838

[jira] [Updated] (SLING-9838) Jenkins builds fail: ERROR: Could not find the JDK installation: JDK 1.8 (latest)

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9838:
---
Description: With INFRA-20858 the names of the tools have changed and we 
need to update, otherwise all builds will keep failing. A more detailed 
description and a discussion is at 
https://lists.apache.org/thread.html/rb4c2834b9874b9f4a74c528de9055958483d2bc6e62c3464bc5c053f%40%3Cbuilds.apache.org%3E
 ..  (was: With INFRA-20858 the names of the tools have changed and we need to 
update, otherwise all builds will keep failing.)

> Jenkins builds fail: ERROR: Could not find the JDK installation: JDK 1.8 
> (latest)
> -
>
> Key: SLING-9838
> URL: https://issues.apache.org/jira/browse/SLING-9838
> Project: Sling
>  Issue Type: Bug
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Critical
>
> With INFRA-20858 the names of the tools have changed and we need to update, 
> otherwise all builds will keep failing. A more detailed description and a 
> discussion is at 
> https://lists.apache.org/thread.html/rb4c2834b9874b9f4a74c528de9055958483d2bc6e62c3464bc5c053f%40%3Cbuilds.apache.org%3E
>  ..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9838) Jenkins builds fail: ERROR: Could not find the JDK installation: JDK 1.8 (latest)

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-9838:
--

 Summary: Jenkins builds fail: ERROR: Could not find the JDK 
installation: JDK 1.8 (latest)
 Key: SLING-9838
 URL: https://issues.apache.org/jira/browse/SLING-9838
 Project: Sling
  Issue Type: Bug
  Components: Build and Source Control
Reporter: Robert Munteanu
Assignee: Robert Munteanu


With INFRA-20858 the names of the tools have changed and we need to update, 
otherwise all builds will keep failing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9782) Failure in loading vanity paths due to query limit being reached

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216509#comment-17216509
 ] 

Robert Munteanu commented on SLING-9782:


[~cziegeler] - LGTM, with a minor naming nitpick.

> Failure in loading vanity paths due to query limit being reached
> 
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.0
>Reporter: Robert Munteanu
>Assignee: Carsten Ziegeler
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
>   at org.apache.felix.framework

Re: How to 'spin a release'

[Konrad Windszus]

Hi Cris and Robert,

after doing those steps you still need to manually add your key to the keys 
file as outlined in https://issues.apache.org/jira/browse/SLING-9173 
.
It is not generated automatically!

We still need to update 
https://sling.apache.org/documentation/development/release-management.html 
 to 
reflect that.

Thanks,
Konrad

> On 19. Oct 2020, at 09:30, Robert Munteanu  wrote:
> 
> Hi Cris,
> 
> On Fri, 2020-10-16 at 12:24 -0400, Cris Rockwell wrote:
>> Regarding
>> 
>> 
>> Konrad Windszus commented on SLING-9648:
>> 
>> Someone would need to spin a release. [~cris_rockwell] Do you want to
>> give it a try?
>> 
>> 
>> Sure! Haven't released to Maven Central before, so I would like to
>> try. I found a release management doc <
>> https://sling.apache.org/documentation/development/release-management.html
>>> on the Sling website. But as of now, my keys is not included in
>> the linked sling.asc file
> 
> Try logging in to https://id.apache.org  . You should 
> see a form with a
> field named 'OpenPGP Public Key Primary Fingerprint: '. Fill it in with
> the corresponding information and submit. The sling.asc file should be
> regenerated, but I'm not sure if it's immediate or needs some time.
> 
> Thanks,
> Robert

[jira] [Commented] (SLING-9782) Failure in loading vanity paths due to query limit being reached

[Julian Sedding (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216501#comment-17216501
 ] 

Julian Sedding commented on SLING-9782:
---

I believe this kind of logging is better implemented as a function of time, 
e.g. once every minute. Logging every 1000th access can amount to a lot of 
logging on a busy system, whereas on a development system it would barely ever 
log. Looking at the diff it seems that the implementation would not be 
significantly more complicated. Just my 2 cents.

> Failure in loading vanity paths due to query limit being reached
> 
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.0
>Reporter: Robert Munteanu
>Assignee: Carsten Ziegeler
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org

Re: How to 'spin a release'

[Robert Munteanu]

Hi Cris,

On Fri, 2020-10-16 at 12:24 -0400, Cris Rockwell wrote:
> Regarding
> 
> 
> Konrad Windszus commented on SLING-9648:
> 
> Someone would need to spin a release. [~cris_rockwell] Do you want to
> give it a try?
> 
> 
> Sure! Haven't released to Maven Central before, so I would like to
> try. I found a release management doc <
> https://sling.apache.org/documentation/development/release-management.html
> >  on the Sling website. But as of now, my keys is not included in
> the linked sling.asc file

Try logging in to https://id.apache.org . You should see a form with a
field named 'OpenPGP Public Key Primary Fingerprint: '. Fill it in with
the corresponding information and submit. The sling.asc file should be
regenerated, but I'm not sure if it's immediate or needs some time.

Thanks,
Robert