Re: [VOTE] Release Apache Sling JCR ContentLoader version 2.4.0

[Eric Norman]

+1

However, it looks like the pom is missing
the "project.build.outputTimestamp" property that would be required for
reproducible builds (per SLING-9611
).  But that can probably
be fixed in the next release?

Regards,
Eric

On Mon, Nov 2, 2020 at 7:28 AM Daniel Klco  wrote:

> Hi,
>
> We solved 14 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12344649
>
> There are still some outstanding issues:
> https://issues.apache.org/jira/projects/SLING/versions/12349341
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2366/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2366 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>

[jira] [Comment Edited] (SLING-9735) Remove loginAdministrative() usage from org.apache.sling.jcr.contentloader

[Eric Norman (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198588#comment-17198588
 ] 

Eric Norman edited comment on SLING-9735 at 11/3/20, 1:11 AM:
--

Fixed at: 
[https://github.com/apache/sling-org-apache-sling-jcr-contentloader/commit/2647cbf573790e756a7f31793bcb680d79606483]

 

NOTE: after upgrade to version 2.4.0 or later the following additional 
configurations must be added to your system and the contentloader bundle should 
be removed from the 
"org.apache.sling.jcr.base.internal.LoginAdminWhitelist.fragment-sling" 
configuration.
{code:java}
[:repoinit]

# jcr bundle contentloader
create service user sling-content-loader with path system/sling

set principal ACL for sling-content-loader 
allow   jcr:allon / 
end

[configurations]

  
org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended-jcr-contentloader
user.mapping=[
  "org.apache.sling.jcr.contentloader\=sling-content-loader"
]{code}
 

 


was (Author: enorman):
Fixed at: 
[https://github.com/apache/sling-org-apache-sling-jcr-contentloader/commit/2647cbf573790e756a7f31793bcb680d79606483]

 

NOTE: after upgrade to version 2.4.0 or later the following additional 
configurations must be added to your system and the contentloader bundle should 
be removed from the 
"org.apache.sling.jcr.base.internal.LoginAdminWhitelist.fragment-sling" 
configuration.
{code:java}
[:repoinit]

# jcr bundle contentloader
create service user sling-content-loader

set principal ACL for sling-content-loader 
allow   jcr:allon / 
end

[configurations]

  
org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended-jcr-contentloader
user.mapping=[
  "org.apache.sling.jcr.contentloader\=sling-content-loader"
]{code}
 

 

> Remove loginAdministrative() usage from org.apache.sling.jcr.contentloader
> --
>
> Key: SLING-9735
> URL: https://issues.apache.org/jira/browse/SLING-9735
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR ContentLoader 2.4.0
>
>
> Create a service user and replace usage of loginAdministrative()  to use that 
> service user.
>  
> Counted 4 occurrences in the current source code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9735) Remove loginAdministrative() usage from org.apache.sling.jcr.contentloader

[Eric Norman (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225032#comment-17225032
 ] 

Eric Norman commented on SLING-9735:


[~olli] I don't have a strong opinion about the name of the service user.  I 
guess I view it as configurable so people can use whatever name they like.

> Remove loginAdministrative() usage from org.apache.sling.jcr.contentloader
> --
>
> Key: SLING-9735
> URL: https://issues.apache.org/jira/browse/SLING-9735
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR ContentLoader 2.4.0
>
>
> Create a service user and replace usage of loginAdministrative()  to use that 
> service user.
>  
> Counted 4 occurrences in the current source code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-3535) reduce duplicated code in content loader

[Eric Norman (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225027#comment-17225027
 ] 

Eric Norman commented on SLING-3535:


[~olli] Ok, maybe my confusion is because there is no class named Loader in the 
jcr.contentloader bundle.  I assume you mean BundleContentLoader?

In comparing BundleContentLoader and DefaultContentImporter, I don't really see 
a lot of obvious code duplication so I guess I would be inclined to just close 
this one.

> reduce duplicated code in content loader
> 
>
> Key: SLING-3535
> URL: https://issues.apache.org/jira/browse/SLING-3535
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> e.g. {{DefaultContentImporter}} and {{Loader}} can share more code in 
> {{BaseImportLoader}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9735) Remove loginAdministrative() usage from org.apache.sling.jcr.contentloader

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225003#comment-17225003
 ] 

Oliver Lietz commented on SLING-9735:
-

[~enorman], I would prefer {{sling-contentloader}} instead of 
{{sling-content-loader}}.

> Remove loginAdministrative() usage from org.apache.sling.jcr.contentloader
> --
>
> Key: SLING-9735
> URL: https://issues.apache.org/jira/browse/SLING-9735
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR ContentLoader 2.4.0
>
>
> Create a service user and replace usage of loginAdministrative()  to use that 
> service user.
>  
> Counted 4 occurrences in the current source code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-3535) reduce duplicated code in content loader

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225001#comment-17225001
 ] 

Oliver Lietz commented on SLING-3535:
-

[~enorman], I can't remember and would have to look into the code. From the 
description: {{DefaultContentImporter}} and {{Loader}}.

> reduce duplicated code in content loader
> 
>
> Key: SLING-3535
> URL: https://issues.apache.org/jira/browse/SLING-3535
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> e.g. {{DefaultContentImporter}} and {{Loader}} can share more code in 
> {{BaseImportLoader}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9862) Support installing repoinit files listed in bundle header

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224998#comment-17224998
 ] 

Oliver Lietz commented on SLING-9862:
-

[~cziegeler], You have a very specific use case with _the code bundle_ in mind. 
Sorry, I didn't realize *code* before and wouldn't put repoinit statements into 
a code bundle neither.

We have around a dozen _features_ (eventing, discovery, scripting, ...) in 
Sling where we set some configurations incl. service users and ACLs via 
repoinit – sensitive defaults which is IMHO totally fine and it's very unlikely 
that someone using Sling (didn't compare with AEM, but out of my head the paths 
are all the same) will change them.

Both Starter and Karaf bake the repoinit statements into configs which requires 
a custom distribution to change the configs and repoinit statements.

Moving the repoinit statements out of configs (scripts) into *a* dedicated 
bundle which has to be installed separately and reference them instead would at 
least allow to change the repoinit statements. This approach works fine with 
Pax URL Classpath.

> Support installing repoinit files listed in bundle header
> -
>
> Key: SLING-9862
> URL: https://issues.apache.org/jira/browse/SLING-9862
> Project: Sling
>  Issue Type: New Feature
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.26
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Minor
>
> Implement support for a {{Sling-RepoInit}} bundle header that consists of a 
> comma separated list of relative paths pointing to resources within the 
> bundle. For each bundle with a non-empty {{Sling-RepoInit}} header, a 
> {{SlingRepositoryInitializer}} that applies all repoinit files referenced in 
> the header, should be dynamically registered.
> Such a mechanism would allow bundles to install their own service-user and 
> corresponding ACLs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (SLING-9735) Remove loginAdministrative() usage from org.apache.sling.jcr.contentloader

[Eric Norman (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198588#comment-17198588
 ] 

Eric Norman edited comment on SLING-9735 at 11/2/20, 10:14 PM:
---

Fixed at: 
[https://github.com/apache/sling-org-apache-sling-jcr-contentloader/commit/2647cbf573790e756a7f31793bcb680d79606483]

 

NOTE: after upgrade to version 2.4.0 or later the following additional 
configurations must be added to your system and the contentloader bundle should 
be removed from the 
"org.apache.sling.jcr.base.internal.LoginAdminWhitelist.fragment-sling" 
configuration.
{code:java}
[:repoinit]

# jcr bundle contentloader
create service user sling-content-loader

set principal ACL for sling-content-loader 
allow   jcr:allon / 
end

[configurations]

  
org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended-jcr-contentloader
user.mapping=[
  "org.apache.sling.jcr.contentloader\=sling-content-loader"
]{code}
 

 


was (Author: enorman):
Fixed at: 
[https://github.com/apache/sling-org-apache-sling-jcr-contentloader/commit/2647cbf573790e756a7f31793bcb680d79606483]

 

NOTE: after upgrade to version 2.4.0 or later the following additional 
configurations must be added to your system and the contentloader bundle should 
be removed from the 
"org.apache.sling.jcr.base.internal.LoginAdminWhitelist.fragment-sling" 
configuration.
{code:java}
[:repoinit]

# jcr bundle contentloader
create service user sling-content-loader

set ACL for sling-content-loader 
allow   jcr:allon / 
end

[configurations]

  
org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended-jcr-contentloader
user.mapping=[
  "org.apache.sling.jcr.contentloader\=sling-content-loader"
]{code}
 

 

> Remove loginAdministrative() usage from org.apache.sling.jcr.contentloader
> --
>
> Key: SLING-9735
> URL: https://issues.apache.org/jira/browse/SLING-9735
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR ContentLoader 2.4.0
>
>
> Create a service user and replace usage of loginAdministrative()  to use that 
> service user.
>  
> Counted 4 occurrences in the current source code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-3535) reduce duplicated code in content loader

[Eric Norman (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224938#comment-17224938
 ] 

Eric Norman commented on SLING-3535:


[~olli] was there some specific duplication that this was referring to?  It's 
hard to offer an opinion with such a generic description.

> reduce duplicated code in content loader
> 
>
> Key: SLING-3535
> URL: https://issues.apache.org/jira/browse/SLING-3535
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> e.g. {{DefaultContentImporter}} and {{Loader}} can share more code in 
> {{BaseImportLoader}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-3619) Content Loader should handle input errors gracefully

[Eric Norman (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224934#comment-17224934
 ] 

Eric Norman commented on SLING-3619:


I would also agree that failing fast and stopping on the first error is the 
safer approach.

> Content Loader should handle input errors gracefully
> 
>
> Key: SLING-3619
> URL: https://issues.apache.org/jira/browse/SLING-3619
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.8
>Reporter: Yogesh Upadhyay
>Assignee: Oliver Lietz
>Priority: Minor
>
> After upgrading to latest sling jar file, content loader stopped working to 
> load content using Sling-Initial-Content. Getting following message in log
> 29.05.2014 23:20:21.504 *INFO* [Background Install 
> /var/folders/mh/tkx6mmq53tb_bcph_cfp7wzmgn/T/install277506169886207.tmp]
>  org.apache.sling.jcr.contentloader.internal.DefaultContentCreator 
> createFile: Cannot find content type for body.jsp, using 
> application/octet-stream



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-3533) improve error handling and logging in content loader

[Eric Norman (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224932#comment-17224932
 ] 

Eric Norman commented on SLING-3533:


I also don't know what the original concern was about, but it wouldn't hurt to 
have some additional test automation that focused on invalid or malformed input 
to make sure it is handled in a reasonable manner.

> improve error handling and logging in content loader
> 
>
> Key: SLING-3533
> URL: https://issues.apache.org/jira/browse/SLING-3533
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> handle errors more appropriate and use proper log levels



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (SLING-9870) NullPointerException, in case Locations are null in an GraphQL error response

[Jabran Asghar (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224801#comment-17224801
 ] 

Jabran Asghar edited comment on SLING-9870 at 11/2/20, 7:20 PM:


Created a PR: 
[https://github.com/apache/sling-org-apache-sling-graphql-core/pull/13]


was (Author: jasghar):
Created  a PR: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/13

> NullPointerException, in case Locations are null in an GraphQL error response
> -
>
> Key: SLING-9870
> URL: https://issues.apache.org/jira/browse/SLING-9870
> Project: Sling
>  Issue Type: Bug
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.6
>Reporter: Jabran Asghar
>Priority: Minor
> Fix For: GraphQL Core 0.0.8
>
>
> *Problem*
> In case GraphQLError does not contain any Location information, rather when 
> the list of locations will be null [0], then a NullPointerException is 
> thrown. This causes a non-meaningful response to be sent back to client.
> For example, the following query will cause a NPE:
> {code:java}
> {   article(_path: "/non-existent/path/to/an-article") 
> { 
> _path   
> } 
> }{code}
>  
>  *Proposed solution:*
>  Should be a null check for {{error.getLocations().}}
>  [0] 
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/e3b09af9e5bd9550e2df87491fd924a886eba51e/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L144]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service

[Henry Kuijpers (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224886#comment-17224886
 ] 

Henry Kuijpers commented on SLING-2938:
---

[~kwin] with 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-adapter-annotations-it/job/PR-1/3/console
 the build was failing again due to the problem being described here: 
https://issues.apache.org/jira/browse/SLING-8080 This happens every now and 
then with my local build as well. I don't know how to fix this.

However, with 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-adapter-annotations-it/job/PR-1/4/console
 the tests are passing. It however triggered an error from SonarCloud due to a 
deprecated Java version (it says it should be updated to Java 11). Not sure how 
to fix that, any ideas?

PR here: 
https://github.com/apache/sling-org-apache-sling-adapter-annotations-it/pull/1

> AdapterMethods annotation and adapter proxy service
> ---
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
>  Issue Type: Bug
>  Components: Engine, Extensions
>Affects Versions: Adapter 2.1.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've 
> been working on an @AdapterMethod annotation that makes it easier to create 
> Sling adapters, as in
>   @Component
>   @Service
>   public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
>   }
> As this requires changes to the sling.api bundle, I'll commit to my 
> whiteboard first, for review



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9870) NullPointerException, in case Locations are null in an GraphQL error response

[Jabran Asghar (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224801#comment-17224801
 ] 

Jabran Asghar commented on SLING-9870:
--

Created  a PR: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/13

> NullPointerException, in case Locations are null in an GraphQL error response
> -
>
> Key: SLING-9870
> URL: https://issues.apache.org/jira/browse/SLING-9870
> Project: Sling
>  Issue Type: Bug
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.6
>Reporter: Jabran Asghar
>Priority: Minor
> Fix For: GraphQL Core 0.0.8
>
>
> *Problem*
> In case GraphQLError does not contain any Location information, rather when 
> the list of locations will be null [0], then a NullPointerException is 
> thrown. This causes a non-meaningful response to be sent back to client.
> For example, the following query will cause a NPE:
> {code:java}
> {   article(_path: "/non-existent/path/to/an-article") 
> { 
> _path   
> } 
> }{code}
>  
>  *Proposed solution:*
>  Should be a null check for {{error.getLocations().}}
>  [0] 
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/e3b09af9e5bd9550e2df87491fd924a886eba51e/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L144]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9870) NullPointerException, in case Locations are null in an GraphQL error response

[Jabran Asghar (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jabran Asghar updated SLING-9870:
-
Description: 
*Problem*

In case GraphQLError does not contain any Location information, rather when the 
list of locations will be null [0], then a NullPointerException is thrown. This 
causes a non-meaningful response to be sent back to client.

For example, the following query will cause a NPE:
{code:java}
{   article(_path: "/non-existent/path/to/an-article") 
{ 
_path   
} 
}{code}
 
 *Proposed solution:*
 Should be a null check for {{error.getLocations().}}


 [0] 
[https://github.com/apache/sling-org-apache-sling-graphql-core/blob/e3b09af9e5bd9550e2df87491fd924a886eba51e/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L144]

  was:
*Problem*

In case GraphQLError does not contain any Location information, rather when the 
list of locations will be null [0], then a NullPointerException is thrown. This 
causes a non-meaningful response to be sent back to client.

For example, the following query will cause a NPE:
{code:java}
{   article(_path: "/non-existent/path/to/an-article") 
{ 
_path   
} 
}{code}
 
 *Proposed solution:*
 Should be a null check for {{error.getLocations().}}
 [0] 
[https://github.com/apache/sling-org-apache-sling-graphql-core/blob/e3b09af9e5bd9550e2df87491fd924a886eba51e/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L144]


> NullPointerException, in case Locations are null in an GraphQL error response
> -
>
> Key: SLING-9870
> URL: https://issues.apache.org/jira/browse/SLING-9870
> Project: Sling
>  Issue Type: Bug
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.6
>Reporter: Jabran Asghar
>Priority: Minor
> Fix For: GraphQL Core 0.0.8
>
>
> *Problem*
> In case GraphQLError does not contain any Location information, rather when 
> the list of locations will be null [0], then a NullPointerException is 
> thrown. This causes a non-meaningful response to be sent back to client.
> For example, the following query will cause a NPE:
> {code:java}
> {   article(_path: "/non-existent/path/to/an-article") 
> { 
> _path   
> } 
> }{code}
>  
>  *Proposed solution:*
>  Should be a null check for {{error.getLocations().}}
>  [0] 
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/e3b09af9e5bd9550e2df87491fd924a886eba51e/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L144]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9870) NullPointerException, in case Locations are null in an GraphQL error response

[Jabran Asghar (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jabran Asghar updated SLING-9870:
-
Description: 
*Problem*

In case GraphQLError does not contain any Location information, rather when the 
list of locations will be null [0], then a NullPointerException is thrown. This 
causes a non-meaningful response to be sent back to client.

For example, the following query will cause a NPE:
{code:java}
{   article(_path: "/non-existent/path/to/an-article") 
{ 
_path   
} 
}{code}
 
 *Proposed solution:*
 Should be a null check for {{error.getLocations().}}
 [0] 
[https://github.com/apache/sling-org-apache-sling-graphql-core/blob/e3b09af9e5bd9550e2df87491fd924a886eba51e/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L144]

  was:
*Problem*

In case GraphQLError does not contain any Location information, rather when the 
list of locations will be null [0], then a NullPointerException is thrown. This 
causes a non-meaningful response to be sent back to client.

For example, the following query will cause a NPE:
{{}}
{code:java}
{   article(_path: "/non-existent/path/to/an-article") 
{ 
_path   
} 
}{code}
 
*Proposed solution:*
Should be a null check for {{error.getLocations().}}
[0] 
https://github.com/apache/sling-org-apache-sling-graphql-core/blob/e3b09af9e5bd9550e2df87491fd924a886eba51e/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L144


> NullPointerException, in case Locations are null in an GraphQL error response
> -
>
> Key: SLING-9870
> URL: https://issues.apache.org/jira/browse/SLING-9870
> Project: Sling
>  Issue Type: Bug
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.6
>Reporter: Jabran Asghar
>Priority: Minor
> Fix For: GraphQL Core 0.0.8
>
>
> *Problem*
> In case GraphQLError does not contain any Location information, rather when 
> the list of locations will be null [0], then a NullPointerException is 
> thrown. This causes a non-meaningful response to be sent back to client.
> For example, the following query will cause a NPE:
> {code:java}
> {   article(_path: "/non-existent/path/to/an-article") 
> { 
> _path   
> } 
> }{code}
>  
>  *Proposed solution:*
>  Should be a null check for {{error.getLocations().}}
>  [0] 
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/e3b09af9e5bd9550e2df87491fd924a886eba51e/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L144]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9870) NullPointerException, in case Locations are null in an GraphQL error response

[Jabran Asghar (Jira)]

Jabran Asghar created SLING-9870:


 Summary: NullPointerException, in case Locations are null in an 
GraphQL error response
 Key: SLING-9870
 URL: https://issues.apache.org/jira/browse/SLING-9870
 Project: Sling
  Issue Type: Bug
  Components: GraphQL
Affects Versions: GraphQL Core 0.0.6
Reporter: Jabran Asghar
 Fix For: GraphQL Core 0.0.8


*Problem*

In case GraphQLError does not contain any Location information, rather when the 
list of locations will be null [0], then a NullPointerException is thrown. This 
causes a non-meaningful response to be sent back to client.

For example, the following query will cause a NPE:
{{}}
{code:java}
{   article(_path: "/non-existent/path/to/an-article") 
{ 
_path   
} 
}{code}
 
*Proposed solution:*
Should be a null check for {{error.getLocations().}}
[0] 
https://github.com/apache/sling-org-apache-sling-graphql-core/blob/e3b09af9e5bd9550e2df87491fd924a886eba51e/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L144



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[VOTE] Release Apache Sling JCR ContentLoader version 2.4.0

[Daniel Klco]

Hi,

We solved 14 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12344649

There are still some outstanding issues:
https://issues.apache.org/jira/projects/SLING/versions/12349341

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2366/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2366 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Re: Improving support for deploying Repoinit DSL files

[Bertrand Delacretaz]

Hi,

On Sat, Oct 24, 2020 at 4:34 PM Julian Sedding  wrote:
> ...as Dan already noticed in "SLING-9524 -
> Add Support for Bundle URL References", it is not currently possible
> to reference bundle resources in a stable fashion. This renders the
> "references" Configuration virtually useless...

FWIW, this feature was added to support grabbing repoinit "scripts"
from the Sling provisioning model using model@repoinit:context:/...
references [1]. But as noted it is not useful for bundle resources.

-Bertrand

[1] 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/1ed447ae1daece383a619f564b3263d67f891b43/src/main/java/org/apache/sling/jcr/repoinit/impl/RepoinitTextProvider.java#L42

Re: [VOTE] Release Apache Sling Scripting HTL Engine 1.4.6-1.4.0, Apache Sling Scripting HTL Compiler 1.2.12-1.4.0, Apache Sling Scripting HTL Testing Content 1.0.26-1.4.0, Apache Sling Scripting HTL

[Nicolas Peltier]

+1

Le lun. 2 nov. 2020 à 14:13, Stefan Seifert  a
écrit :

> +1
>
>
>

[jira] [Resolved] (SLING-3533) improve error handling and logging in content loader

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-3533.
-
Resolution: Cannot Reproduce

> improve error handling and logging in content loader
> 
>
> Key: SLING-3533
> URL: https://issues.apache.org/jira/browse/SLING-3533
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> handle errors more appropriate and use proper log levels



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-3533) improve error handling and logging in content loader

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-3533:

Fix Version/s: (was: JCR ContentLoader 2.4.2)

> improve error handling and logging in content loader
> 
>
> Key: SLING-3533
> URL: https://issues.apache.org/jira/browse/SLING-3533
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> handle errors more appropriate and use proper log levels



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-3619) Content Loader should handle input errors gracefully

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-3619:

Fix Version/s: (was: JCR ContentLoader 2.4.2)

> Content Loader should handle input errors gracefully
> 
>
> Key: SLING-3619
> URL: https://issues.apache.org/jira/browse/SLING-3619
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.8
>Reporter: Yogesh Upadhyay
>Assignee: Oliver Lietz
>Priority: Minor
>
> After upgrading to latest sling jar file, content loader stopped working to 
> load content using Sling-Initial-Content. Getting following message in log
> 29.05.2014 23:20:21.504 *INFO* [Background Install 
> /var/folders/mh/tkx6mmq53tb_bcph_cfp7wzmgn/T/install277506169886207.tmp]
>  org.apache.sling.jcr.contentloader.internal.DefaultContentCreator 
> createFile: Cannot find content type for body.jsp, using 
> application/octet-stream



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-3619) Content Loader should handle input errors gracefully

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-3619.
-
Resolution: Not A Problem

> Content Loader should handle input errors gracefully
> 
>
> Key: SLING-3619
> URL: https://issues.apache.org/jira/browse/SLING-3619
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.8
>Reporter: Yogesh Upadhyay
>Assignee: Oliver Lietz
>Priority: Minor
>
> After upgrading to latest sling jar file, content loader stopped working to 
> load content using Sling-Initial-Content. Getting following message in log
> 29.05.2014 23:20:21.504 *INFO* [Background Install 
> /var/folders/mh/tkx6mmq53tb_bcph_cfp7wzmgn/T/install277506169886207.tmp]
>  org.apache.sling.jcr.contentloader.internal.DefaultContentCreator 
> createFile: Cannot find content type for body.jsp, using 
> application/octet-stream



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-3619) Content Loader should handle input errors gracefully

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224703#comment-17224703
 ] 

Oliver Lietz commented on SLING-3619:
-

And it doesn't stop if the content type is unknown.

> Content Loader should handle input errors gracefully
> 
>
> Key: SLING-3619
> URL: https://issues.apache.org/jira/browse/SLING-3619
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.8
>Reporter: Yogesh Upadhyay
>Assignee: Oliver Lietz
>Priority: Minor
> Fix For: JCR ContentLoader 2.4.2
>
>
> After upgrading to latest sling jar file, content loader stopped working to 
> load content using Sling-Initial-Content. Getting following message in log
> 29.05.2014 23:20:21.504 *INFO* [Background Install 
> /var/folders/mh/tkx6mmq53tb_bcph_cfp7wzmgn/T/install277506169886207.tmp]
>  org.apache.sling.jcr.contentloader.internal.DefaultContentCreator 
> createFile: Cannot find content type for body.jsp, using 
> application/octet-stream



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9800) Extract a service to be able to execute GraphQL queries directly

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224695#comment-17224695
 ] 

Bertrand Delacretaz commented on SLING-9800:


bq. ...the resource of the request is the Servlet ...

Not sure what this means but what happens under the hood in the 
[DefaultSchemaProvider|https://github.com/apache/sling-org-apache-sling-graphql-core/blob/master/src/main/java/org/apache/sling/graphql/core/schema/DefaultSchemaProvider.java]
 is an internal request to the path of that Resource with a `.GQLschema` 
extension. 

So that Resource should be setup with the appropriate `sling:resourceType` so 
that the correct script or servlet is called to generate the schema.

If that information doesn't help, it would be useful if you can provide a 
Sling-based example that reproduces your issue - and that would belong to a 
different ticket.

> Extract a service to be able to execute GraphQL queries directly
> 
>
> Key: SLING-9800
> URL: https://issues.apache.org/jira/browse/SLING-9800
> Project: Sling
>  Issue Type: Improvement
>  Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: GraphQL Core 0.0.8
>
>
> In the current implementation of the GraphQL Core bundle queries can only be 
> executed via a GraphQL Servlet that needs to be configured or via server-side 
> scripts. It would be good if the queries could also be executed directly, 
> without the need for a request.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-3619) Content Loader should handle input errors gracefully

[Dan Klco (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224682#comment-17224682
 ] 

Dan Klco commented on SLING-3619:
-

IMO -- the content loader should fail fast rather than attempting to recover. I 
vote to close.

> Content Loader should handle input errors gracefully
> 
>
> Key: SLING-3619
> URL: https://issues.apache.org/jira/browse/SLING-3619
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.8
>Reporter: Yogesh Upadhyay
>Assignee: Oliver Lietz
>Priority: Minor
> Fix For: JCR ContentLoader 2.4.2
>
>
> After upgrading to latest sling jar file, content loader stopped working to 
> load content using Sling-Initial-Content. Getting following message in log
> 29.05.2014 23:20:21.504 *INFO* [Background Install 
> /var/folders/mh/tkx6mmq53tb_bcph_cfp7wzmgn/T/install277506169886207.tmp]
>  org.apache.sling.jcr.contentloader.internal.DefaultContentCreator 
> createFile: Cannot find content type for body.jsp, using 
> application/octet-stream



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-3533) improve error handling and logging in content loader

[Dan Klco (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224680#comment-17224680
 ] 

Dan Klco commented on SLING-3533:
-

Honestly, I think the logging is acceptable, but I'm not entirely sure what was 
the concern. 

> improve error handling and logging in content loader
> 
>
> Key: SLING-3533
> URL: https://issues.apache.org/jira/browse/SLING-3533
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> handle errors more appropriate and use proper log levels



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-3533) improve error handling and logging in content loader

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224676#comment-17224676
 ] 

Oliver Lietz commented on SLING-3533:
-

[~enorman], [~jeb], [~dklco], You guys have worked mainly on Content Loader in 
the past – is this issue still relevant or should we close it?

> improve error handling and logging in content loader
> 
>
> Key: SLING-3533
> URL: https://issues.apache.org/jira/browse/SLING-3533
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> handle errors more appropriate and use proper log levels



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-3535) reduce duplicated code in content loader

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224677#comment-17224677
 ] 

Oliver Lietz commented on SLING-3535:
-

[~enorman], [~jeb], [~dklco], You guys have worked mainly on Content Loader in 
the past – is this issue still relevant or should we close it?

> reduce duplicated code in content loader
> 
>
> Key: SLING-3535
> URL: https://issues.apache.org/jira/browse/SLING-3535
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> e.g. {{DefaultContentImporter}} and {{Loader}} can share more code in 
> {{BaseImportLoader}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-3619) Content Loader should handle input errors gracefully

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224675#comment-17224675
 ] 

Oliver Lietz commented on SLING-3619:
-

[~enorman], [~jeb], [~dklco], You guys have worked mainly on Content Loader in 
the past – is this issue still relevant or should we close it?

> Content Loader should handle input errors gracefully
> 
>
> Key: SLING-3619
> URL: https://issues.apache.org/jira/browse/SLING-3619
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.8
>Reporter: Yogesh Upadhyay
>Assignee: Oliver Lietz
>Priority: Minor
> Fix For: JCR ContentLoader 2.4.2
>
>
> After upgrading to latest sling jar file, content loader stopped working to 
> load content using Sling-Initial-Content. Getting following message in log
> 29.05.2014 23:20:21.504 *INFO* [Background Install 
> /var/folders/mh/tkx6mmq53tb_bcph_cfp7wzmgn/T/install277506169886207.tmp]
>  org.apache.sling.jcr.contentloader.internal.DefaultContentCreator 
> createFile: Cannot find content type for body.jsp, using 
> application/octet-stream



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-7927) JSON Content Loading errors out import on malformed json

[Dan Klco (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-7927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-7927:

Fix Version/s: (was: JCR ContentLoader 2.4.0)
   JCR ContentLoader 2.4.2

> JSON Content Loading errors out import on malformed json
> 
>
> Key: SLING-7927
> URL: https://issues.apache.org/jira/browse/SLING-7927
> Project: Sling
>  Issue Type: Bug
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> Current Behaviour:
> During the importing of json content from a bundle. If one of the files 
> contains malformed json the load process is discontinued and exits. This 
> stops the loading of any other, correctly formatted, data.
>  
> Expected Behaviour:
> If a single file contains malformed content, that specific file should 
> discontinue, the error logged and then the process continues to import the 
> rest of the provided content.
> As it is right now, it's possible to load the bundle and have the application 
> in an unworkable state. preventing the ability to trouble shoot and 
> investigate the root cause.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-3619) Content Loader should handle input errors gracefully

[Dan Klco (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-3619:

Fix Version/s: (was: JCR ContentLoader 2.4.0)
   JCR ContentLoader 2.4.2

> Content Loader should handle input errors gracefully
> 
>
> Key: SLING-3619
> URL: https://issues.apache.org/jira/browse/SLING-3619
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.8
>Reporter: Yogesh Upadhyay
>Assignee: Oliver Lietz
>Priority: Minor
> Fix For: JCR ContentLoader 2.4.2
>
>
> After upgrading to latest sling jar file, content loader stopped working to 
> load content using Sling-Initial-Content. Getting following message in log
> 29.05.2014 23:20:21.504 *INFO* [Background Install 
> /var/folders/mh/tkx6mmq53tb_bcph_cfp7wzmgn/T/install277506169886207.tmp]
>  org.apache.sling.jcr.contentloader.internal.DefaultContentCreator 
> createFile: Cannot find content type for body.jsp, using 
> application/octet-stream



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-7926) JSON Content Parser should support namespace mangling

[Dan Klco (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-7926:

Fix Version/s: (was: JCR ContentLoader 2.4.0)
   JCR ContentLoader 2.4.2

> JSON Content Parser should support namespace mangling
> -
>
> Key: SLING-7926
> URL: https://issues.apache.org/jira/browse/SLING-7926
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> Currently it's possible to define a json file with a name that matches a 
> mangled namespace. Which then makes the file unable to be accessed from the 
> ResourceResolver
> i.e. importing a file `_jcr_content.json` will create the node `_jcr_content` 
> which cannot then be resolved as the resource resolver will attempt to 
> convert `_jcr_content` to `jcr:content` supporting namespace mangling will 
> additionally provide a cleaner `colon` support then the current 
> recommendation of a url mangled colon of `%3A`
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-3535) reduce duplicated code in content loader

[Dan Klco (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-3535:

Fix Version/s: (was: JCR ContentLoader 2.4.0)
   JCR ContentLoader 2.4.2

> reduce duplicated code in content loader
> 
>
> Key: SLING-3535
> URL: https://issues.apache.org/jira/browse/SLING-3535
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> e.g. {{DefaultContentImporter}} and {{Loader}} can share more code in 
> {{BaseImportLoader}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-3533) improve error handling and logging in content loader

[Dan Klco (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-3533:

Fix Version/s: (was: JCR ContentLoader 2.4.0)
   JCR ContentLoader 2.4.2

> improve error handling and logging in content loader
> 
>
> Key: SLING-3533
> URL: https://issues.apache.org/jira/browse/SLING-3533
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> handle errors more appropriate and use proper log levels



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

RE: [VOTE] Release Apache Sling Scripting HTL Engine 1.4.6-1.4.0, Apache Sling Scripting HTL Compiler 1.2.12-1.4.0, Apache Sling Scripting HTL Testing Content 1.0.26-1.4.0, Apache Sling Scripting HTL

[Stefan Seifert]

+1

[jira] [Commented] (SLING-9826) jcr:uuid index not updated on move

[Hans-Peter Stoerr (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224581#comment-17224581
 ] 

Hans-Peter Stoerr commented on SLING-9826:
--

Thanks for the prompt response! I can confirm that this problem is gone from 
the Sling Starter, too, now that o.a.s.jcr.oak.server is at version 1.2.10, and 
our application works again properly.


BTW: I still get that "sling-12-oak-tar failed to start in 30 seconds" build 
failure at sling-starter, but that's another issue.

> jcr:uuid index not updated on move
> --
>
> Key: SLING-9826
> URL: https://issues.apache.org/jira/browse/SLING-9826
> Project: Sling
>  Issue Type: Bug
>  Components: JCR, Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11 
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Oak Server 1.2.10
>
>
> When changing from Sling Starter 11 to the (almost) latest version of Sling 
> Starter 12-SNAPSHOT I get the problem that it is not possible to find nodes 
> that are mix:referenceable by their jcr:uuid after they have been moved in 
> the JCR tree: Session.getNodeByIdentifier throws an ItemNotFoundException, 
> and a query /jcr:root//*[@jcr:uuid='${uuid}'] does not find the node.
> I tested it with the following code (Node and Session being from javax.jcr.*):
> {code:java}
> Node parent = session.getNode(PATH);
> String name = "child" + System.currentTimeMillis();
> Node child = parent.addNode(name, "sling:Folder");
> child.addMixin("mix:referenceable");
> session.save();
> String id = child.getIdentifier();
> // session.getNodeByIdentifier(id); // OK, works as expected here.
> session.move(child.getPath(), PATH2 + "/" + name);
> session.save();
> session.getNodeByIdentifier(id); // often throws ItemNotFoundException!
> {code}
> PATH and PATH2 denote two preexisting writeable nodes. If I force a refresh 
> of the /oak:index/uuid, the node is found again - until it is moved again. 
> The query problem is also easy to replicate by creating a mix:referenceable 
> node in the browser, moving it and trying to query it with 
> /jcr:root//*[@jcr:uuid='${uuid}'] .
> I initially reported the bug to the Jackrabbit OAK project, but it is not 
> possible to reproduce this with the oak-jcr tests. I could also not reproduce 
> it with a unit test in org-apache-sling-jcr-resource, only when using the 
> Sling Starter 12. [This comment on my Oak 
> bugreport|https://issues.apache.org/jira/browse/OAK-9253?focusedCommentId=17213939=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17213939]
>  suggests that there might be some misconfiguration in Sling.
> Thank you very much!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9866) Remove Json validator

[Stefan Seifert (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224568#comment-17224568
 ] 

Stefan Seifert commented on SLING-9866:
---

bq. We can throw an exception in case it is still used so it won't be 
unnoticed. Do you know of any projects using this feature?
yes... all our projects which are using sling-initial-content in the bundles, 
it's currently activated by default in wcm.io 
[aem-global-parent|https://github.com/wcm-io/wcm-io-tooling/tree/develop/maven/aem-global-parent].
 in the old times where sling had its on commons json implementation with some 
special tweaks it was good to have a validator which uses exactly the same code 
base.

for wcm.io aem-global-parent it is easy to switch to a another maven plugin 
when it has the same feature set as it is defined centrally - but i cannot 
speak for other projects. the mojo is only active when it's called explicitly 
in the POM, so it should not be an efficiency problem with projects not using 
it.

> Remove Json validator
> -
>
> Key: SLING-9866
> URL: https://issues.apache.org/jira/browse/SLING-9866
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Maven Plugin 2.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 2.4.4
>
>
> In the context of SLING-653 a generic JSON file validator was added. This is 
> not Sling specific and there are specialized Maven plugins like 
> https://github.com/sylvainlaurent/yaml-json-validator-maven-plugin which do a 
> better job. I would recommend getting rid of 
> https://github.com/apache/sling-maven-plugin/blob/master/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/ValidationMojo.java
>  together with 
> https://github.com/apache/sling-maven-plugin/blob/master/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/JsonSupport.java
>  to reduce the footprint of the sling-maven-plugin.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9866) Remove Json validator

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224562#comment-17224562
 ] 

Konrad Windszus commented on SLING-9866:


bq. do we have an urgent need to remove this feature?

No, but looking at 
https://sling.apache.org/components/maven-sling-plugin-archives/maven-sling-plugin-2.3.0/validate-mojo.html
 it is not really clear what this mojo does (at least to me). Also it might 
have an impact on build times as the way it iterates through all artifact 
resources doesn't seem very effective with no way to skip certain folders 
in 
https://github.com/apache/sling-maven-plugin/blob/ee08451c880cc8cdc554b4cf8964c35792d75326/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/ValidationMojo.java#L96

bq. and not noticing that it's gone and shipping invalid JSON after that

We can throw an exception in case it is still used so it won't be unnoticed. Do 
you know of any projects using this feature?





> Remove Json validator
> -
>
> Key: SLING-9866
> URL: https://issues.apache.org/jira/browse/SLING-9866
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Maven Plugin 2.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 2.4.4
>
>
> In the context of SLING-653 a generic JSON file validator was added. This is 
> not Sling specific and there are specialized Maven plugins like 
> https://github.com/sylvainlaurent/yaml-json-validator-maven-plugin which do a 
> better job. I would recommend getting rid of 
> https://github.com/apache/sling-maven-plugin/blob/master/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/ValidationMojo.java
>  together with 
> https://github.com/apache/sling-maven-plugin/blob/master/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/JsonSupport.java
>  to reduce the footprint of the sling-maven-plugin.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9866) Remove Json validator

[Stefan Seifert (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224557#comment-17224557
 ] 

Stefan Seifert commented on SLING-9866:
---

do we have an urgent need to remove this feature? breaking it deliberately 
(with and empty stub) is not very polite, there may be thousands of projects 
out there currently relying on this validation (and not noticing that it's gone 
and shipping invalid JSON after that).

for sure that there may be better alternatives, but looking e.g. at 
[https://github.com/sylvainlaurent/yaml-json-validator-maven-plugin] it seems 
it has no incremental build support for eclipse.

> Remove Json validator
> -
>
> Key: SLING-9866
> URL: https://issues.apache.org/jira/browse/SLING-9866
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Maven Plugin 2.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 2.4.4
>
>
> In the context of SLING-653 a generic JSON file validator was added. This is 
> not Sling specific and there are specialized Maven plugins like 
> https://github.com/sylvainlaurent/yaml-json-validator-maven-plugin which do a 
> better job. I would recommend getting rid of 
> https://github.com/apache/sling-maven-plugin/blob/master/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/ValidationMojo.java
>  together with 
> https://github.com/apache/sling-maven-plugin/blob/master/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/JsonSupport.java
>  to reduce the footprint of the sling-maven-plugin.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[RESULT] [VOTE] Release Apache Sling Feature Model 1.2.12, Feature Model Analyser 1.3.10, Feature Model Launcher 1.1.10, Content-Package to Feature Model Converter 1.0.16, slingfeature-maven-plugin 1.

[davidb]

Hi all,

With binding +1 votes from Karl Pauls, Daniel Klco, Carsten Ziegeler
and non-binding +1 votes from Andreas Schaefer

this release is successful.

I have promoted the artifacts.

Best regards,

David

On Thu, 29 Oct 2020 at 17:12,  wrote:

> Hi all,
>
> I would like to call the release on the following Apache Sling Feature
> Model related components:
>
> Feature Model 1.2.12
> https://issues.apache.org/jira/projects/SLING/versions/12348830
>
> Feature Model Analyser 1.3.10
> https://issues.apache.org/jira/projects/SLING/versions/12348762
>
> Feature Model Launcher 1.1.10
> https://issues.apache.org/jira/projects/SLING/versions/12349327
>
> Content-Package to Feature Model Converter 1.0.16
> https://issues.apache.org/jira/projects/SLING/versions/12348790
>
> slingfeature-maven-plugin 1.4.6
> https://issues.apache.org/jira/projects/SLING/versions/12349275
>
> Feature Model Converter Plugin 1.0.6
> https://issues.apache.org/jira/projects/SLING/versions/12346782
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2365
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2365 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Best regards,
>
> David
>

Re: Improving support for deploying Repoinit DSL files

[Julian Sedding]

Hi

@Carsten: thanks for the pointers, I had missed
o.a.s.installer.factory.feature. After spending some trying, I managed
to get everything set up correctly. However, I encountered SLING-9869,
where a feature JSON file is treated as a feature archive leading to
an exception. I should be able to come up with a fix in the next few
days.

On a related note: I didn't manage to create a FAR with the JSON
included as JSON. I always ended up with the JSON file inside the FAR,
but with a JAR extension. Any pointers?

@Oliver: thank you for the pointers to the paxurl support for
classpath URLs. I may go down this route if all else fails, because it
will certainly work.

After thinking about the problem at hand, I am leaning towards
agreeing with Carsten that repoinit files are a deployment concern and
don't belong inside a bundle. Even though I would be open to allowing
a default/sample repoinit file inside, which could be used based on an
opt-in mechanism.

The feature model installer factory (once fixed) allows indirectly
deploying repoinit files via e.g. content-packages and thus meets my
requirement. For the purpose of "only" deploying repoinit files it
seems like overkill, as it requires the use of the
slingfeature-maven-plugin for inlining the repoinit file into a
feature JSON file. However, it might be interesting to move more
deployment artifacts (e.g. confings, bundles and content-packages)
into a FAR and move the application closer to being "feature-model
ready (TM)".

Regards
Julian


On Thu, Oct 29, 2020 at 4:57 PM Oliver Lietz  wrote:
>
> On Thursday, October 29, 2020 3:44:35 PM CET Julian Sedding wrote:
> > Hi
>
> Hi *,
>
> > Thank you Oliver for the suggestion. I have attempted using the
> > "classpath" scheme as, but I get "java.lang.IllegalStateException:
> > Unknown protocol: classpath". Maybe Karaf has an additional URLHandler
> > for "classpath"?
>
> Yes, Pax URL which can be used outside of Karaf of course:
> https://ops4j1.jira.com/wiki/spaces/paxurl/overview
>
> And see here for the bundles:
> https://github.com/apache/sling-org-apache-sling-testing-paxexam/blob/master/
> src/main/java/org/apache/sling/testing/paxexam/SlingOptions.java#L168
>
> Regards,
> O.
>
>
> > Carsten Ziegeler wrote on SLING-9862
> >
> > > I personally don't like the idea to have repoinit inside a bundle; so if
> > > we can come to a solution where no new header is introduced that's
> > > probably better. Today, you can install a feature, which references
> > > bundles, configurations and repoinit - which I think is a much more
> > > flexible way than having everything inside the code bundle. Users of your
> > > code might use different users, different content paths (if configurable)
> > > etc.
> >
> > Unfortunately I am in no position to use the feature model. I am
> > looking for solutions on how to better leverage repoinit on older
> > Sling deployments (namely AEM 6.5 on-prem), where the OSGi installer
> > is still the main means for deployment. Or am I missing something and
> > it is possible to use the feature model for this?
> >
> > My goal is finding a way to maintain repoinit files in a Git
> > Repository and have them applied to the instance upon deployment via
> > content-packages. The existing "RepositoryInitializerFactory"
> > configuration does not quite cut it, as I outlined previously in this
> > thread (mainly the "scripts" configs are not maintainable due to
> > required escaping within config files and "references" to bundle
> > resources are not predictable, see SLING-9524).
> >
> > I think a bundle developer knows best which permissions a service user
> > requires. Therefore I see some value in allowing the bundle to
> > transport such information. However, I acknowledge that embedding such
> > information in the bundle could take away flexibility for deployments
> > to customize the setup. And as you mention, it _is_ possible to use a
> > different name for a service-user.
> >
> > An alternative could be a repoinit installer factory for the OSGi
> > Installer. This would allow repoinit files to be deployed via
> > content-package, e.g. in an /apps/myapp/config folder.
> >
> > Also a combination of the two could be worthwhile: the bundle-header
> > approach could be opt-in and guarded by a configuration that allows
> > whitelisting bundle symbolic names for which embedded repoinit scripts
> > should be deployed. A warning could be printed for any bundle that
> > contains repoinit scripts but is not whitelisted. And finally, an
> > "ignore"-list of bundle symbolic names could allow suppressing the
> > warning. The logging would draw a deployer's attention to the fact
> > that a bundle embeds repoinit files and ideally prompt them to
> > whitelist it or to add it to the ignore list. Even in the case of the
> > ignore list, the deployer could extract the repoinit files and modify
> > them.
> >
> > Any custom repoinit configurations could be deployed via OSGi installer.
> >
> > I am not fixed on 

[jira] [Created] (SLING-9869) Installer Factory Feature Model cannot install feature JSON file

[Julian Sedding (Jira)]

Julian Sedding created SLING-9869:
-

 Summary: Installer Factory Feature Model cannot install feature 
JSON file
 Key: SLING-9869
 URL: https://issues.apache.org/jira/browse/SLING-9869
 Project: Sling
  Issue Type: Bug
  Components: Installer
Affects Versions: Installer Factory Feature Model 0.5.0
Reporter: Julian Sedding
Assignee: Julian Sedding


The installer factory for the feature model is supposed to support installation 
of both feature JSON files and feature archives (FAR).

When trying to install a feature JSON file I encountered the exception below. 
It seems that JSON files are partially treated as FAR files.

{noformat}
02.11.2020 09:13:52.154 *INFO* [JcrInstaller.1] 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller Registering resource 
with OSGi installer: [InstallableResource, priority=200, 
id=/apps/foo/config/config-package-1.0.0-SNAPSHOT-feature.json]
02.11.2020 09:13:52.154 *INFO* [JcrInstaller.1] 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller Removing resource 
from OSGi installer: [/apps/foo/config/config-package-1.0.0-SNAPSHOT-far.far]
02.11.2020 09:13:52.172 *INFO* [OsgiInstallerImpl] 
org.apache.sling.audit.osgi.installer Installing 
featuremodel:ch.stzh.cq:config-package:1.0.0-SNAPSHOT
02.11.2020 09:13:52.267 *WARN* [OsgiInstallerImpl] 
org.apache.sling.installer.factory.model.impl.InstallFeatureModelTask Unable to 
extract artifacts from feature model ch.stzh.cq:config-package:1.0.0-SNAPSHOT
java.io.IOException: Not a feature model archive - manifest is missing.
at 
org.apache.sling.feature.io.archive.ArchiveReader.checkHeaderAndExtractContents(ArchiveReader.java:155)
 [org.apache.sling.feature:1.2.6]
at 
org.apache.sling.feature.io.archive.ArchiveReader.read(ArchiveReader.java:79) 
[org.apache.sling.feature:1.2.6]
at 
org.apache.sling.installer.factory.model.impl.InstallFeatureModelTask.transform(InstallFeatureModelTask.java:141)
 [org.apache.sling.installer.factory.feature:0.5.0]
at 
org.apache.sling.installer.factory.model.impl.InstallFeatureModelTask.execute(InstallFeatureModelTask.java:83)
 [org.apache.sling.installer.factory.feature:0.5.0]
at 
org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:914)
 [org.apache.sling.installer.core:3.9.0.B002]
at 
org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:749)
 [org.apache.sling.installer.core:3.9.0.B002]
at 
org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:298)
 [org.apache.sling.installer.core:3.9.0.B002]
at java.lang.Thread.run(Thread.java:748)
02.11.2020 09:13:52.267 *INFO* [OsgiInstallerImpl] 
org.apache.sling.audit.osgi.installer Unable to install feature model resource 
TaskResource(url=jcrinstall:/apps/foo/config/config-package-1.0.0-SNAPSHOT-feature.json,
 entity=featuremodel:ch.stzh.cq:config-package:1.0.0-SNAPSHOT, state=INSTALL, 
attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:41:1603:12224:,
 feature={
  "id":"ch.stzh.cq:config-package:1.0.0-SNAPSHOT",
  "title":"Stadt Zuerich 01.00 Config: package",
  "description":"configuration data for shipped bundles and stzh",
  "license":"Stadt Zuerich, Organisation und Informatik",
  "repoinit:TEXT|true":[
"create path /tmp/config-package(sling:OrderedFolder)",
"create path /tmp/config-package(sling:OrderedFolder)/foo(nt:unstructured)",
"create path /tmp/config-package(sling:OrderedFolder)/bar(nt:unstructured)",
"",
"set ACL on /tmp/config-package",
"allow jcr:read everyone",
"allow jcr:all administrators",
"end"
  ]
}, Bundle-Version=8.99.1.SNAPSHOT, 
featureId=ch.stzh.cq:config-package:1.0.0-SNAPSHOT], digest=1604067231900) : 
unable to create resources
{noformat}




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9868) Add github labels to o.a.s.installer.factory.feature

[Julian Sedding (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Sedding resolved SLING-9868.
---
Fix Version/s: Installer Factory Feature Model 0.6.0
   Resolution: Fixed

Added labels in [commit 
b9efd45|https://github.com/apache/sling-org-apache-sling-installer-factory-feature/commit/b9efd45].

> Add github labels to o.a.s.installer.factory.feature
> 
>
> Key: SLING-9868
> URL: https://issues.apache.org/jira/browse/SLING-9868
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Factory Feature Model 0.5.0
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Major
> Fix For: Installer Factory Feature Model 0.6.0
>
>
> The git repository 
> [{{sling-org-apache-sling-installer-factory-feature}}|https://github.com/apache/sling-org-apache-sling-installer-factory-feature]
>  currently has no labels assigned. This makes it harder to find the repo with 
> [github 
> queries|https://github.com/search?q=topic%3Asling+topic%3Aosgi-feature-model+topic%3Aosgi+org%3Aapache=Repositories]
>  like the one used in the [Feature Model How-To 
> Guide|https://sling.apache.org/documentation/feature-model/feature-model-howto.html].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9868) Add github labels to o.a.s.installer.factory.feature

[Julian Sedding (Jira)]

Julian Sedding created SLING-9868:
-

 Summary: Add github labels to o.a.s.installer.factory.feature
 Key: SLING-9868
 URL: https://issues.apache.org/jira/browse/SLING-9868
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: Installer Factory Feature Model 0.5.0
Reporter: Julian Sedding
Assignee: Julian Sedding


The git repository 
[{{sling-org-apache-sling-installer-factory-feature}}|https://github.com/apache/sling-org-apache-sling-installer-factory-feature]
 currently has no labels assigned. This makes it harder to find the repo with 
[github 
queries|https://github.com/search?q=topic%3Asling+topic%3Aosgi-feature-model+topic%3Aosgi+org%3Aapache=Repositories]
 like the one used in the [Feature Model How-To 
Guide|https://sling.apache.org/documentation/feature-model/feature-model-howto.html].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9866) Remove Json validator

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224479#comment-17224479
 ] 

Konrad Windszus commented on SLING-9866:


I would leave an empty deprecated stub for the mojo in place pointing to 
alternatives but without the functionality. WDYT?

> Remove Json validator
> -
>
> Key: SLING-9866
> URL: https://issues.apache.org/jira/browse/SLING-9866
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Maven Plugin 2.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 2.4.4
>
>
> In the context of SLING-653 a generic JSON file validator was added. This is 
> not Sling specific and there are specialized Maven plugins like 
> https://github.com/sylvainlaurent/yaml-json-validator-maven-plugin which do a 
> better job. I would recommend getting rid of 
> https://github.com/apache/sling-maven-plugin/blob/master/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/ValidationMojo.java
>  together with 
> https://github.com/apache/sling-maven-plugin/blob/master/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/JsonSupport.java
>  to reduce the footprint of the sling-maven-plugin.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)