RE: [VOTE] Release Apache Sling Rewriter 1.3.0

2021-01-17 Thread Stefan Seifert
hallo daniel.

it's likely only a problem in the unit tests, but maybe also a problem in the 
production code itself? in the first case it would be fine for me to continue 
with the release, in the latter we should cancel it.

stefan


>-Original Message-
>From: Daniel Klco 
>Sent: Saturday, January 16, 2021 6:14 PM
>To: dev@sling.apache.org
>Subject: Re: [VOTE] Release Apache Sling Rewriter 1.3.0
>
>Thanks for the note and catch Stefan. Are you a -1 or okay with fixing the
>test post-release?
>
>On Sat, Jan 16, 2021 at 2:43 AM Stefan Seifert
> wrote:
>
>> i've a problem running the unit test on windows - seems to be a line
>> ending issue (see below).
>> another cosmetic remark: please put the SLING ticket number in the git
>> commit messages, otherwise it's difficult to associate it.
>>
>> stefan
>>
>>
>> -
>--
>> Test set: org.apache.sling.rewriter.impl.components.Html5SerializerTest
>>
>> -
>--
>> Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.177 s
>> <<< FAILURE! - in
>> org.apache.sling.rewriter.impl.components.Html5SerializerTest
>>
>org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocu
>ment
>> Time elapsed: 0.147 s  <<< FAILURE!
>> org.junit.ComparisonFailure:
>> expected:<[]
>> > but was:<[
>> ]
>> >
>> at
>>
>org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocu
>ment(Html5SerializerTest.java:113)
>>
>>
>>
>>
>> >-Original Message-
>> >From: Daniel Klco 
>> >Sent: Friday, January 15, 2021 6:40 PM
>> >To: dev@sling.apache.org
>> >Subject: [VOTE] Release Apache Sling Rewriter 1.3.0
>> >
>> >Hi,
>> >
>> >We solved 9 issues in this release:
>> >https://issues.apache.org/jira/projects/SLING/versions/12342644
>> >
>> >I bumped to 1.3 due to the HTM5 serializer support which is backwards
>> >compatible.
>> >
>> >Staging repository:
>> >https://repository.apache.org/content/repositories/orgapachesling-2399/
>> >
>> >You can use this UNIX script to download the release and verify the
>> >signatures:
>> >https://gitbox.apache.org/repos/asf?p=sling-tooling-
>> >release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>> >
>> >Usage:
>> >sh check_staged_release.sh 2399 /tmp/sling-staging
>> >
>> >Please vote to approve this release:
>> >
>> >  [ ] +1 Approve the release
>> >  [ ]  0 Don't care
>> >  [ ] -1 Don't release, because ...
>> >
>> >This majority vote is open for at least 72 hours.
>>


[jira] [Commented] (SLING-10068) CAConfig Mock Plugin: NPE when using `@Nested` tests

2021-01-17 Thread Stefan Seifert (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267049#comment-17267049
 ] 

Stefan Seifert commented on SLING-10068:


[~kylegio] can you provide a unit test to reproduce the problem?

> CAConfig Mock Plugin: NPE when using `@Nested` tests
> 
>
> Key: SLING-10068
> URL: https://issues.apache.org/jira/browse/SLING-10068
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: Context-Aware Configuration Mock Plugin 1.3.2
>Reporter: Kyle Giovannetti
>Priority: Minor
>
> When using the caconfig mocking plugin as per the example here: 
>  
> [https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/blob/master/src/test/java/org/apache/sling/testing/mock/caconfig/ContextPluginsTest.java]
>  
> If the tests are located inside an inner class annotated with the `@Nested` 
> annotation, then a NPE occurs:
>  
> {code:java}
> java.lang.NullPointerExceptionjava.lang.NullPointerException 
> at 
> org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:101)
>  
> at 
> org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:125)
>  
> at 
> org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:113)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-10068) CAConfig Mock Plugin: NPE when using `@Nested` tests

2021-01-17 Thread Kyle Giovannetti (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kyle Giovannetti updated SLING-10068:
-
Description: 
When using the caconfig mocking plugin as per the example here: 
 
[https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/blob/master/src/test/java/org/apache/sling/testing/mock/caconfig/ContextPluginsTest.java]

 

If the tests are located inside an inner class annotated with the `@Nested` 
annotation, then a NPE occurs:

 
{code:java}
java.lang.NullPointerExceptionjava.lang.NullPointerException 
at 
org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:101)
 
at 
org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:125)
 
at 
org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:113)

{code}

  was:
When using the caconfig mocking plugin as per the example here: 
 
[https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/blob/master/src/test/java/org/apache/sling/testing/mock/caconfig/ContextPluginsTest.java]

 

If the tests are located inside an inner class annotated with the `@Nested` 
annotation, then a NPE occurs:

 
{code:java}
java.lang.NullPointerExceptionjava.lang.NullPointerException at   
org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:101)
 at 
org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:125)
 at 
org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:113)
{code}


> CAConfig Mock Plugin: NPE when using `@Nested` tests
> 
>
> Key: SLING-10068
> URL: https://issues.apache.org/jira/browse/SLING-10068
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: Context-Aware Configuration Mock Plugin 1.3.2
>Reporter: Kyle Giovannetti
>Priority: Minor
>
> When using the caconfig mocking plugin as per the example here: 
>  
> [https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/blob/master/src/test/java/org/apache/sling/testing/mock/caconfig/ContextPluginsTest.java]
>  
> If the tests are located inside an inner class annotated with the `@Nested` 
> annotation, then a NPE occurs:
>  
> {code:java}
> java.lang.NullPointerExceptionjava.lang.NullPointerException 
> at 
> org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:101)
>  
> at 
> org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:125)
>  
> at 
> org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:113)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-10068) CAConfig Mock Plugin: NPE when using `@Nested` tests

2021-01-17 Thread Kyle Giovannetti (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kyle Giovannetti updated SLING-10068:
-
Affects Version/s: Context-Aware Configuration Mock Plugin 1.3.2

> CAConfig Mock Plugin: NPE when using `@Nested` tests
> 
>
> Key: SLING-10068
> URL: https://issues.apache.org/jira/browse/SLING-10068
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: Context-Aware Configuration Mock Plugin 1.3.2
>Reporter: Kyle Giovannetti
>Priority: Minor
>
> When using the caconfig mocking plugin as per the example here: 
>  
> [https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/blob/master/src/test/java/org/apache/sling/testing/mock/caconfig/ContextPluginsTest.java]
>  
> If the tests are located inside an inner class annotated with the `@Nested` 
> annotation, then a NPE occurs:
>  
> {code:java}
> java.lang.NullPointerExceptionjava.lang.NullPointerException at   
> org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:101)
>  at 
> org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:125)
>  at 
> org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:113)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-10068) CAConfig Mock Plugin: NPE when using `@Nested` tests

2021-01-17 Thread Kyle Giovannetti (Jira)
Kyle Giovannetti created SLING-10068:


 Summary: CAConfig Mock Plugin: NPE when using `@Nested` tests
 Key: SLING-10068
 URL: https://issues.apache.org/jira/browse/SLING-10068
 Project: Sling
  Issue Type: Bug
  Components: Testing
Reporter: Kyle Giovannetti


When using the caconfig mocking plugin as per the example here: 
 
[https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/blob/master/src/test/java/org/apache/sling/testing/mock/caconfig/ContextPluginsTest.java]

 

If the tests are located inside an inner class annotated with the `@Nested` 
annotation, then a NPE occurs:

 
{code:java}
java.lang.NullPointerExceptionjava.lang.NullPointerException at   
org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:101)
 at 
org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:125)
 at 
org.apache.sling.testing.mock.caconfig.MockContextAwareConfig.writeConfiguration(MockContextAwareConfig.java:113)
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #44: SLING-8525 - adding Launcher extension to be able to launch analyser …

2021-01-17 Thread GitBox


sonarcloud[bot] commented on pull request #44:
URL: https://github.com/apache/sling-whiteboard/pull/44#issuecomment-761888133


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=44=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=44=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=44=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=44=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=44=duplicated_lines_density=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #50: Bump eslint-utils from 1.3.1 to 1.4.3 in /serverless-microsling

2021-01-17 Thread GitBox


sonarcloud[bot] commented on pull request #50:
URL: https://github.com/apache/sling-whiteboard/pull/50#issuecomment-761888043


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=50=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=50=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=50=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=50=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=50=duplicated_lines_density=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-servlets-post] tomasalmeida commented on a change in pull request #10: SLING-10030 - Addin PostOperation ranking

2021-01-17 Thread GitBox


tomasalmeida commented on a change in pull request #10:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r559230689



##
File path: 
src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##
@@ -0,0 +1,106 @@
+/*

Review comment:
   Hi Paul, great point, I kept the same insertion code used before just 
moving it to the new Class, so it could reused.
   
   I can reimplement it using a SortedMap as proposed. Although I am not sure 
we can guarantee if no ranking is provided, the last inserted element will be 
the chosen one.
   
   Let me know if I should provide the implementation using a SortedMap and I 
can provide it.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-servlets-post] tomasalmeida commented on a change in pull request #10: SLING-10030 - Addin PostOperation ranking

2021-01-17 Thread GitBox


tomasalmeida commented on a change in pull request #10:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r559230689



##
File path: 
src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##
@@ -0,0 +1,106 @@
+/*

Review comment:
   Hi Paul, great point, I kept the same insertion code used before just 
moving it to the new Class, so it could reused.
   
   I can reimplement it using a SortedMap as proposed. Although I am not sure 
we can guarantee if no ranking is provided, the last inserted element will be 
the chosen one.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #10: SLING-10030 - Addin PostOperation ranking

2021-01-17 Thread GitBox


sonarcloud[bot] commented on pull request #10:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-761870261


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_coverage=list)
 [82.4% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] removed a comment on pull request #10: SLING-10030 - Addin PostOperation ranking

2021-01-17 Thread GitBox


sonarcloud[bot] removed a comment on pull request #10:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-761864165


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_coverage=list)
 [74.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-servlets-post] paul-bjorkstrand commented on a change in pull request #10: SLING-10030 - Addin PostOperation ranking

2021-01-17 Thread GitBox


paul-bjorkstrand commented on a change in pull request #10:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r559228997



##
File path: 
src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##
@@ -0,0 +1,106 @@
+/*

Review comment:
   This looks like it could be replaced with an implementation of 
[SortedMap] rather than a new, custom class. A benefit of using a SortedMap is 
that you can use either a concurrency safe version or not, depending on the use 
case.
   
   [SortedMap]: 
https://docs.oracle.com/javase/8/docs/api/java/util/SortedMap.html





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #10: SLING-10030 - Addin PostOperation ranking

2021-01-17 Thread GitBox


sonarcloud[bot] commented on pull request #10:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-761864165


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_coverage=list)
 [74.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] removed a comment on pull request #10: SLING-10030 - Addin PostOperation ranking

2021-01-17 Thread GitBox


sonarcloud[bot] removed a comment on pull request #10:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-761862849


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_coverage=list)
 [74.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-01-17 Thread GitBox


sonarcloud[bot] commented on pull request #7:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-761863545


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list)
 [70.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #10: SLING-10030 - Addin PostOperation ranking

2021-01-17 Thread GitBox


sonarcloud[bot] commented on pull request #10:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-761862849


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=10=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=10=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_coverage=list)
 [74.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=10=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (SLING-10030) Add an optional ranking as a property for PostOperation implementation

2021-01-17 Thread Jira


[ 
https://issues.apache.org/jira/browse/SLING-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266884#comment-17266884
 ] 

Tomás Dias Almeida commented on SLING-10030:


Proposed PR: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10

> Add an optional ranking as a property for PostOperation implementation 
> ---
>
> Key: SLING-10030
> URL: https://issues.apache.org/jira/browse/SLING-10030
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Servlets Post 2.3.36
>Reporter: Tomás Dias Almeida
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Given the case, a PostOperation PO1 implementation is provided for a given 
> operation, but it does not solve a particular need. I would like to be able 
> to create another PostOperation implementation PO2 with a higher ranking and 
> replace the PO1.
> h2. *Current status*
> h3. *Last wins condition*
> [org.apache.sling.servlets.post.impl.SlingPostServlet|https://github.com/apache/sling-org-apache-sling-servlets-post/blob/master/src/main/java/org/apache/sling/servlets/post/impl/SlingPostServlet.java]
>  can only store one PostOperation per operation as it is stored like
>  
> {code:java}
> private final Map postOperations = new 
> HashMap<>();{code}
>  
> This map is filled by the binding function per order of activation
>  
> {code:java}
> protected void bindPostOperation(final PostOperation operation, final 
> Map properties) {
> final String operationName = (String) 
> properties.get(PostOperation.PROP_OPERATION_NAME);
> if ( operationName != null && operation != null ) {
> synchronized (this.postOperations) {
> this.postOperations.put(operationName, operation);
> }
> }
> }{code}
>  
> If two classes provide an implementation for the given operation, we run into 
> a concurrency problem and the last activated component "wins" the race and 
> will be used.
> h3. Incorrect map if a component is stopped
> The map is updated using an unbinding method, that relies on the axiom that 
> there is only one PostOperation per operation.
>  
> {code:java}
> protected void unbindPostOperation(final PostOperation operation, final 
> Map properties) {
> final String operationName = (String) 
> properties.get(PostOperation.PROP_OPERATION_NAME);
> if ( operationName != null ) {
> synchronized (this.postOperations) {
> this.postOperations.remove(operationName);
> }
> }
> }
> {code}
> And so, if we have the following scenario: 
>  
>  # PostOperation P1 is activated for operation P
>  # PostOperation P2 is activated for operation P
>  # 
> [SlingPostServlet|https://github.com/apache/sling-org-apache-sling-servlets-post/blob/master/src/main/java/org/apache/sling/servlets/post/impl/SlingPostServlet.java]
>  stores P2 as PostOperation for P (as described above)
>  # P2 is stopped for any reason
>  # 
> [SlingPostServlet|https://github.com/apache/sling-org-apache-sling-servlets-post/blob/master/src/main/java/org/apache/sling/servlets/post/impl/SlingPostServlet.java]
>  has no PostOperation set for P, but P1 could be the right one.
> h2. Proposal
> Each PostOperation can provide an optional "operation.ranking" integer 
> property.
> bindPostOperation method will store all PostOperations by order of ranking 
> (higher first), PostOperations with no ranking will be added to the end by 
> order of calling.
> unbindPostOperation removes the given PostOperation of the sorted list.
>  
>  
> If you believe that is a good idea, I can provide an implementation to 
> discuss the solution.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-servlets-post] tomasalmeida opened a new pull request #10: SLING-10030 - Addin PostOperation ranking

2021-01-17 Thread GitBox


tomasalmeida opened a new pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10


   - Migrating SlingPostServletTest to Junit4
   - Creating an auxiliary SortedByRankingList class which stores elements by a 
given ranking
   - Storing all bound PostOperations by ranking and using the one with higher 
ranking
  - if no ranking is provided, order follows the behavior already 
established behavior: last Operation bound is used as default one.
   
   Full proposal is described in 
https://issues.apache.org/jira/browse/SLING-10030



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (SLING-10067) Prototype for chunked deep distribution

2021-01-17 Thread Timothee Maret (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266880#comment-17266880
 ] 

Timothee Maret commented on SLING-10067:


Thanks [~cschneider] for starting this prototype. The idea of using Sling Jobs 
looks appropriate for this use case. There will be only one Sling Job created 
per deep distribution action which won't stress the repository. It also makes 
sense to use the built in support to report progress and cancel jobs.

The feature would leverage APIs widely available in the Sling / AEM world: 
Sling Jobs, Sling Content Distribution and Jackrabbit FileVault. It could serve 
as a better implementation for AEM "tree activation" feature for on premise and 
cloud deployments. Toward this goal, the recursive descent should only add the 
path of hierarchical nodes (node of type nt:hierarchyNode such as sling:Folder 
or AEM's cq:Page, dam:Asset types) in the multi-path distribution requests.
{quote}I plan to create the prototype in the sling whiteboard.
{quote}
Nice! I would be glad to have a look.

> Prototype for chunked deep distribution
> ---
>
> Key: SLING-10067
> URL: https://issues.apache.org/jira/browse/SLING-10067
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
>
> We have a case where a tree distribution could not be applied on oak level as 
> it was too large. As we can not control how large a tree can grow we should 
> have a solution that does not depend on the size of the tree.
> I would like to create a prototype of a chunked deep distribution. It is 
> given a path to distribute and walks through the full tree of resources to 
> collect paths (breadth first).
> Then the list of paths is split into chunks of configurable size. For each 
> chunk we create a distribution with all paths of the chunk. This makes sure 
> the package size will not grow too big.
> The call should be asyncronous and it should be possible to monitor and 
> cancel the progress of package creation. So the idea is to use a sling job 
> with JobExecutor interface. This way the job can report progress and react to 
> cancel requests.
> I plan to create the prototype in the sling whiteboard. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-superimposing] sonarcloud[bot] commented on pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations

2021-01-17 Thread GitBox


sonarcloud[bot] commented on pull request #2:
URL: 
https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#issuecomment-761861203


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-superimposing=2=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-superimposing=2=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-superimposing=2=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=CODE_SMELL)
 [6 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=2=new_coverage=list)
 [89.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=2=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=2=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-models-api] sonarcloud[bot] commented on pull request #2: SLING-8655 - Added the Externalized Path Annotation and Provider inte…

2021-01-17 Thread GitBox


sonarcloud[bot] commented on pull request #2:
URL: 
https://github.com/apache/sling-org-apache-sling-models-api/pull/2#issuecomment-761825601


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-api=2=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-api=2=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-api=2=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-api=2=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-api=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-api=2=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-models-jacksonexporter] sonarcloud[bot] commented on pull request #1: SLING-8452 migrate to OSGi R6 annotations

2021-01-17 Thread GitBox


sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/1#issuecomment-761805624


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=BUG)
 [1 
Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=1=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=1=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=1=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-distribution-api] sonarcloud[bot] commented on pull request #7: SLING-9389: Distribution Event Properties enhanced for holding queue item creation time stamp

2021-01-17 Thread GitBox


sonarcloud[bot] commented on pull request #7:
URL: 
https://github.com/apache/sling-org-apache-sling-distribution-api/pull/7#issuecomment-761803595


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-api=7=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-api=7=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-api=7=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-api=7=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-api=7=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-api=7=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (SLING-10067) Prototype for chunked deep distribution

2021-01-17 Thread Christian Schneider (Jira)
Christian Schneider created SLING-10067:
---

 Summary: Prototype for chunked deep distribution
 Key: SLING-10067
 URL: https://issues.apache.org/jira/browse/SLING-10067
 Project: Sling
  Issue Type: Bug
  Components: Content Distribution
Reporter: Christian Schneider
Assignee: Christian Schneider


We have a case where a tree distribution could not be applied on oak level as 
it was too large. As we can not control how large a tree can grow we should 
have a solution that does not depend on the size of the tree.

I would like to create a prototype of a chunked deep distribution. It is given 
a path to distribute and walks through the full tree of resources to collect 
paths (breadth first).

Then the list of paths is split into chunks of configurable size. For each 
chunk we create a distribution with all paths of the chunk. This makes sure the 
package size will not grow too big.

The call should be asyncronous and it should be possible to monitor and cancel 
the progress of package creation. So the idea is to use a sling job with 
JobExecutor interface. This way the job can report progress and react to cancel 
requests.

I plan to create the prototype in the sling whiteboard. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)