[GitHub] [sling-org-apache-sling-app-cms] sonarcloud[bot] commented on pull request #11: Forms enhancements
sonarcloud[bot] commented on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/11#issuecomment-766878108 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&metric=new_duplicated_lines_density&view=list) [3.6% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-app-cms] klcodanr merged pull request #11: Forms enhancements
klcodanr merged pull request #11: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-packageinit] kwin commented on a change in pull request #3: SLING-10089 - adding logic & test to consider failing on error in exe…
kwin commented on a change in pull request #3:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/3#discussion_r563933930
##
File path:
src/main/java/org/apache/sling/jcr/packageinit/impl/ExecutionPlanRepoInitializer.java
##
@@ -163,6 +163,9 @@ public void processRepository(SlingRepository
slingRepository) throws Exception
builder.with(session);
ExecutionPlan xplan = builder.execute();
if (xplan.getTasks().size() > 0) {
+if (xplan.hasErrors()) {
+throw new
IllegalStateException("Excecutionplan execution contained errors - cannot
complete repository initialization.");
Review comment:
It would be good to include the errors from the tasks in the exception.
That way debugging is way easier.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-core] cschneider commented on pull request #45: Fixed vault filter generation so that paths are properly escaped
cschneider commented on pull request #45: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/45#issuecomment-766809545 I think this does not fix the problem we had. I created a different fix here: https://issues.apache.org/jira/browse/SLING-10088 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (SLING-10080) Onboard org.apache.sling.jcr.maintenance to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reopened SLING-10080: -- > Onboard org.apache.sling.jcr.maintenance to SonarCloud > -- > > Key: SLING-10080 > URL: https://issues.apache.org/jira/browse/SLING-10080 > Project: Sling > Issue Type: Task >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Attachments: screenshot-1.png > > > [~bellingard] - can you please onboard > https://github.com/apache/sling-org-apache-sling-jcr-maintenance to > SonarCloud? > Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (SLING-10080) Onboard org.apache.sling.jcr.maintenance to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271671#comment-17271671 ] Dan Klco edited comment on SLING-10080 at 1/25/21, 8:47 PM: Oh shoot, [~bellingard] it looks like the quality gates aren't configured correctly in SonarCloud !screenshot-1.png! was (Author: dklco): Oh shoot, it looks like the quality gates aren't configured correctly in SonarCloud !screenshot-1.png! > Onboard org.apache.sling.jcr.maintenance to SonarCloud > -- > > Key: SLING-10080 > URL: https://issues.apache.org/jira/browse/SLING-10080 > Project: Sling > Issue Type: Task >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Attachments: screenshot-1.png > > > [~bellingard] - can you please onboard > https://github.com/apache/sling-org-apache-sling-jcr-maintenance to > SonarCloud? > Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10080) Onboard org.apache.sling.jcr.maintenance to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271671#comment-17271671 ] Dan Klco commented on SLING-10080: -- Oh shoot, it looks like the quality gates aren't configured correctly in SonarCloud !screenshot-1.png! > Onboard org.apache.sling.jcr.maintenance to SonarCloud > -- > > Key: SLING-10080 > URL: https://issues.apache.org/jira/browse/SLING-10080 > Project: Sling > Issue Type: Task >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Attachments: screenshot-1.png > > > [~bellingard] - can you please onboard > https://github.com/apache/sling-org-apache-sling-jcr-maintenance to > SonarCloud? > Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10080) Onboard org.apache.sling.jcr.maintenance to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-10080: - Attachment: screenshot-1.png > Onboard org.apache.sling.jcr.maintenance to SonarCloud > -- > > Key: SLING-10080 > URL: https://issues.apache.org/jira/browse/SLING-10080 > Project: Sling > Issue Type: Task >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Attachments: screenshot-1.png > > > [~bellingard] - can you please onboard > https://github.com/apache/sling-org-apache-sling-jcr-maintenance to > SonarCloud? > Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10080) Onboard org.apache.sling.jcr.maintenance to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-10080. -- Resolution: Fixed Thanks [~bellingard]! > Onboard org.apache.sling.jcr.maintenance to SonarCloud > -- > > Key: SLING-10080 > URL: https://issues.apache.org/jira/browse/SLING-10080 > Project: Sling > Issue Type: Task >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > > [~bellingard] - can you please onboard > https://github.com/apache/sling-org-apache-sling-jcr-maintenance to > SonarCloud? > Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10080) Onboard org.apache.sling.jcr.maintenance to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271650#comment-17271650 ] Fabrice Bellingard commented on SLING-10080: [~dklco] Here it is! => https://sonarcloud.io/project/configuration?id=apache_sling-org-apache-sling-jcr-maintenance > Onboard org.apache.sling.jcr.maintenance to SonarCloud > -- > > Key: SLING-10080 > URL: https://issues.apache.org/jira/browse/SLING-10080 > Project: Sling > Issue Type: Task >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > > [~bellingard] - can you please onboard > https://github.com/apache/sling-org-apache-sling-jcr-maintenance to > SonarCloud? > Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-jcr-packageinit] kwin commented on a change in pull request #3: SLING-10089 - adding logic & test to consider failing on error in exe…
kwin commented on a change in pull request #3:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/3#discussion_r563933930
##
File path:
src/main/java/org/apache/sling/jcr/packageinit/impl/ExecutionPlanRepoInitializer.java
##
@@ -163,6 +163,9 @@ public void processRepository(SlingRepository
slingRepository) throws Exception
builder.with(session);
ExecutionPlan xplan = builder.execute();
if (xplan.getTasks().size() > 0) {
+if (xplan.hasErrors()) {
+throw new
IllegalStateException("Excecutionplan execution contained errors - cannot
complete repository initialization.");
Review comment:
It would be good to include the errors from the tasks in the exception.
That way debugging is way easier.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-10089) PackageInit Extension should fail when errors occur in ExecutionPlan
[ https://issues.apache.org/jira/browse/SLING-10089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271584#comment-17271584 ] Dominik Süß commented on SLING-10089: - Fix proposal at https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/3 > PackageInit Extension should fail when errors occur in ExecutionPlan > - > > Key: SLING-10089 > URL: https://issues.apache.org/jira/browse/SLING-10089 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Dominik Süß >Priority: Major > > ExtensionPlanBuilder on execute doesn't automatically throw an exceptions > when one or more of the Tasks Fail to install - therefore it is necessary to > crosscheck the hasErrors() method of the resulting ExecutionPlan object. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-jcr-packageinit] DominikSuess opened a new pull request #3: SLING-10089 - adding logic & test to consider failing on error in exe…
DominikSuess opened a new pull request #3: URL: https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/3 …cutionplan execution This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-10089) PackageInit Extension should fail when errors occur in ExecutionPlan
Dominik Süß created SLING-10089: --- Summary: PackageInit Extension should fail when errors occur in ExecutionPlan Key: SLING-10089 URL: https://issues.apache.org/jira/browse/SLING-10089 Project: Sling Issue Type: Bug Components: Extensions Reporter: Dominik Süß ExtensionPlanBuilder on execute doesn't automatically throw an exceptions when one or more of the Tasks Fail to install - therefore it is necessary to crosscheck the hasErrors() method of the resulting ExecutionPlan object. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-app-cms] sonarcloud[bot] commented on pull request #11: Forms enhancements
sonarcloud[bot] commented on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/11#issuecomment-766878108 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&metric=new_duplicated_lines_density&view=list) [3.6% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms&pullRequest=11&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-10082) CMS Reference - Support Site Authentication
[ https://issues.apache.org/jira/browse/SLING-10082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-10082. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/b20cd7745e13c68cd3357fae7a10e3e2719979b9 > CMS Reference - Support Site Authentication > --- > > Key: SLING-10082 > URL: https://issues.apache.org/jira/browse/SLING-10082 > Project: Sling > Issue Type: New Feature > Components: App CMS Reference >Affects Versions: App CMS 0.16.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.0.2 > > > Add a reference implementation showing: > - A login form > - Forgot password / reset action > - Registration action -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10083) CMS Reference - UGC CRUD Support
[ https://issues.apache.org/jira/browse/SLING-10083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-10083. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/b20cd7745e13c68cd3357fae7a10e3e2719979b9 > CMS Reference - UGC CRUD Support > > > Key: SLING-10083 > URL: https://issues.apache.org/jira/browse/SLING-10083 > Project: Sling > Issue Type: New Feature > Components: App CMS Reference >Affects Versions: App CMS 0.16.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.0.2 > > > Add actions to support: > - Reading > - Updating > - Deleting > of user generated content. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-app-cms] klcodanr merged pull request #11: Forms enhancements
klcodanr merged pull request #11: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-app-cms] klcodanr opened a new pull request #11: Forms enhancements
klcodanr opened a new pull request #11: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/11 Work on SLING-10083 and SLING-10082 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SLING-9857) Intermediate path is ignored if user/group already exists
[
https://issues.apache.org/jira/browse/SLING-9857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271332#comment-17271332
]
Bertrand Delacretaz edited comment on SLING-9857 at 1/25/21, 2:32 PM:
--
I have implemented the {{with forced path}} language option in [this
commit|https://github.com/apache/sling-org-apache-sling-repoinit-parser/commit/927bd185131382f83d0fb307bd4d97f12b053f79].
And also adapted the {{org.apache.sling.jcr.repoinit}} module to use this
updated parser in [this
commit|https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/d3a8098d9a75bdded80bfa7d248c33f77d8b1733].
The syntax is defined in the
[test-68.txt|https://github.com/apache/sling-org-apache-sling-repoinit-parser/blob/master/src/test/resources/testcases/test-68.txt]
test which is:
{code:java}
create user A with path /path/user/A
create user AF with forced path /path/user/AF
create service user B with path /path/service/B
create service user BF with forced path /path/service/BF
create group G with path /path/group/G
create group GF with forced path /path/group/GF
{code}
As mentioned, I won't have time to do more right now, what's left is to
implement the {{org.apache.sling.jcr.repoinit}} changes.
Note also that once this is implemented we need to update
https://sling.apache.org/documentation/bundles/repository-initialization.html
with the corresponding examples from
[test-99.txt|https://github.com/apache/sling-org-apache-sling-repoinit-parser/blob/master/src/test/resources/testcases/test-99.txt]
that I just added.
was (Author: bdelacretaz):
I have implemented the {{with forced path}} language option in [this
commit|https://github.com/apache/sling-org-apache-sling-repoinit-parser/commit/927bd185131382f83d0fb307bd4d97f12b053f79].
And also adapted the {{org.apache.sling.jcr.repoinit}} module to use this
updated parser in [this
commit|https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/d3a8098d9a75bdded80bfa7d248c33f77d8b1733].
The syntax is defined in the
[test-68.txt|https://github.com/apache/sling-org-apache-sling-repoinit-parser/blob/master/src/test/resources/testcases/test-68.txt]
test which is:
{code:java}
create user A with path /path/user/A
create user AF with forced path /path/user/AF
create service user B with path /path/service/B
create service user BF with forced path /path/service/BF
create group G with path /path/group/G
create group GF with forced path /path/group/GF
{code}
As mentioned, I won't have time to do more right now, what's left is to
implement the {{org.apache.sling.jcr.repoinit}} changes.
> Intermediate path is ignored if user/group already exists
> -
>
> Key: SLING-9857
> URL: https://issues.apache.org/jira/browse/SLING-9857
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit Parser 1.6.2, Repoinit JCR 1.1.26
>Reporter: Angela Schreiber
>Priority: Major
> Fix For: Repoinit Parser 1.6.4, Repoinit JCR 1.1.28
>
>
> Sling repoinit allows to create users/groups/service users with an optional
> intermediate path (absolute or relative):
> {code}
> create service user my-feature-service with path system/my-feature
> create user my-feature-user with path /home/users/my-feature
> create group my-feature-group with path my-feature
> {code}
> however, in case the user/group/service user already exists the intermediate
> path will be ignored.
> imo, there should be a way to make sure the intermediate path is respected
> upon execution of {{CreateUser}}, {{CreateGroup}} and {{CreateServiceUser}}
> operations.
> for example:
> h4. always verify and adjust path if needed
> in {{UserVisitor}}: if a group/user/service user already exists and the
> create-operation includes a path (i.e. {{getPath()}} doesn't return
> {{null}}), verify that {{Authorizable.getPath()}} is a descendant of that
> path. If that's not the case move the corresponding node by either deleting
> and recreating the user/group/service user or by actually moving.
> h4. global configuration option
> expand the repoinit such that handling of intermediate path can be configured
> for all statements. for example add a configuration option to
> {{JcrRepoInitOpsProcessorImpl}}. {{UserVisitor}} would only perform the
> verification and potentially move, if the configuration option mandates it.
> the configuration could either be a simple boolean flag for this particular
> case or be more sophisticated like e.g.
> {{http://jackrabbit.apache.org/filevault/importmode.html}}.
> h4. expand repo-init statements
> if enforcing intermediate paths should not be dealt on a global level but on
> a case by case basis, the create user/group/service user statements needed to
> be expand
[jira] [Comment Edited] (SLING-9857) Intermediate path is ignored if user/group already exists
[
https://issues.apache.org/jira/browse/SLING-9857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271332#comment-17271332
]
Bertrand Delacretaz edited comment on SLING-9857 at 1/25/21, 2:17 PM:
--
I have implemented the {{with forced path}} language option in [this
commit|https://github.com/apache/sling-org-apache-sling-repoinit-parser/commit/927bd185131382f83d0fb307bd4d97f12b053f79].
And also adapted the {{org.apache.sling.jcr.repoinit}} module to use this
updated parser in [this
commit|https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/d3a8098d9a75bdded80bfa7d248c33f77d8b1733].
The syntax is defined in the
[test-68.txt|https://github.com/apache/sling-org-apache-sling-repoinit-parser/blob/master/src/test/resources/testcases/test-68.txt]
test which is:
{code:java}
create user A with path /path/user/A
create user AF with forced path /path/user/AF
create service user B with path /path/service/B
create service user BF with forced path /path/service/BF
create group G with path /path/group/G
create group GF with forced path /path/group/GF
{code}
As mentioned, I won't have time to do more right now, what's left is to
implement the {{org.apache.sling.jcr.repoinit}} changes.
was (Author: bdelacretaz):
I have implemented the {{with forced path}} language option in [this
commit|https://github.com/apache/sling-org-apache-sling-repoinit-parser/commit/927bd185131382f83d0fb307bd4d97f12b053f79].
And also adapted the {{org.apache.sling.jcr.repoinit}} module to use this
updated parser in [this
commit|https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/d3a8098d9a75bdded80bfa7d248c33f77d8b1733].
As mentioned, I won't have time to do more right now, what's left is to
implement the {{org.apache.sling.jcr.repoinit}} changes.
> Intermediate path is ignored if user/group already exists
> -
>
> Key: SLING-9857
> URL: https://issues.apache.org/jira/browse/SLING-9857
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit Parser 1.6.2, Repoinit JCR 1.1.26
>Reporter: Angela Schreiber
>Priority: Major
> Fix For: Repoinit Parser 1.6.4, Repoinit JCR 1.1.28
>
>
> Sling repoinit allows to create users/groups/service users with an optional
> intermediate path (absolute or relative):
> {code}
> create service user my-feature-service with path system/my-feature
> create user my-feature-user with path /home/users/my-feature
> create group my-feature-group with path my-feature
> {code}
> however, in case the user/group/service user already exists the intermediate
> path will be ignored.
> imo, there should be a way to make sure the intermediate path is respected
> upon execution of {{CreateUser}}, {{CreateGroup}} and {{CreateServiceUser}}
> operations.
> for example:
> h4. always verify and adjust path if needed
> in {{UserVisitor}}: if a group/user/service user already exists and the
> create-operation includes a path (i.e. {{getPath()}} doesn't return
> {{null}}), verify that {{Authorizable.getPath()}} is a descendant of that
> path. If that's not the case move the corresponding node by either deleting
> and recreating the user/group/service user or by actually moving.
> h4. global configuration option
> expand the repoinit such that handling of intermediate path can be configured
> for all statements. for example add a configuration option to
> {{JcrRepoInitOpsProcessorImpl}}. {{UserVisitor}} would only perform the
> verification and potentially move, if the configuration option mandates it.
> the configuration could either be a simple boolean flag for this particular
> case or be more sophisticated like e.g.
> {{http://jackrabbit.apache.org/filevault/importmode.html}}.
> h4. expand repo-init statements
> if enforcing intermediate paths should not be dealt on a global level but on
> a case by case basis, the create user/group/service user statements needed to
> be expanded to allow for more fine-grained setup. as with the previous
> option it could be a simple flag or follow the example of
> {{Jackrabbit-fvault}}, which defines a variety of import modes (see
> http://jackrabbit.apache.org/filevault/importmode.html).
> h4. on a general note:
> i see the benefit of the fine-grain import-modes (and ac-handling flags on
> top of that,
> http://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/io/AccessControlHandling))
> in jackrabbit-fvault. however, in a repository setup with many features, it
> becomes increasingly difficult to manage and my personal preference would
> rather be to keep it simple.
> note though SLING-6423: the fvault ac-handling flags already found their way
> into the parser (implementation still missing though)
[jira] [Assigned] (SLING-9857) Intermediate path is ignored if user/group already exists
[
https://issues.apache.org/jira/browse/SLING-9857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz reassigned SLING-9857:
--
Assignee: (was: Bertrand Delacretaz)
I have implemented the {{with forced path}} language option in [this
commit|https://github.com/apache/sling-org-apache-sling-repoinit-parser/commit/927bd185131382f83d0fb307bd4d97f12b053f79].
And also adapted the {{org.apache.sling.jcr.repoinit}} module to use this
updated parser in [this
commit|https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/d3a8098d9a75bdded80bfa7d248c33f77d8b1733].
As mentioned, I won't have time to do more right now, what's left is to
implement the {{org.apache.sling.jcr.repoinit}} changes.
> Intermediate path is ignored if user/group already exists
> -
>
> Key: SLING-9857
> URL: https://issues.apache.org/jira/browse/SLING-9857
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit Parser 1.6.2, Repoinit JCR 1.1.26
>Reporter: Angela Schreiber
>Priority: Major
> Fix For: Repoinit Parser 1.6.4, Repoinit JCR 1.1.28
>
>
> Sling repoinit allows to create users/groups/service users with an optional
> intermediate path (absolute or relative):
> {code}
> create service user my-feature-service with path system/my-feature
> create user my-feature-user with path /home/users/my-feature
> create group my-feature-group with path my-feature
> {code}
> however, in case the user/group/service user already exists the intermediate
> path will be ignored.
> imo, there should be a way to make sure the intermediate path is respected
> upon execution of {{CreateUser}}, {{CreateGroup}} and {{CreateServiceUser}}
> operations.
> for example:
> h4. always verify and adjust path if needed
> in {{UserVisitor}}: if a group/user/service user already exists and the
> create-operation includes a path (i.e. {{getPath()}} doesn't return
> {{null}}), verify that {{Authorizable.getPath()}} is a descendant of that
> path. If that's not the case move the corresponding node by either deleting
> and recreating the user/group/service user or by actually moving.
> h4. global configuration option
> expand the repoinit such that handling of intermediate path can be configured
> for all statements. for example add a configuration option to
> {{JcrRepoInitOpsProcessorImpl}}. {{UserVisitor}} would only perform the
> verification and potentially move, if the configuration option mandates it.
> the configuration could either be a simple boolean flag for this particular
> case or be more sophisticated like e.g.
> {{http://jackrabbit.apache.org/filevault/importmode.html}}.
> h4. expand repo-init statements
> if enforcing intermediate paths should not be dealt on a global level but on
> a case by case basis, the create user/group/service user statements needed to
> be expanded to allow for more fine-grained setup. as with the previous
> option it could be a simple flag or follow the example of
> {{Jackrabbit-fvault}}, which defines a variety of import modes (see
> http://jackrabbit.apache.org/filevault/importmode.html).
> h4. on a general note:
> i see the benefit of the fine-grain import-modes (and ac-handling flags on
> top of that,
> http://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/io/AccessControlHandling))
> in jackrabbit-fvault. however, in a repository setup with many features, it
> becomes increasingly difficult to manage and my personal preference would
> rather be to keep it simple.
> note though SLING-6423: the fvault ac-handling flags already found their way
> into the parser (implementation still missing though). so, maybe this issue
> here in combination with SLING-6423 could be used to make a conscious
> decision about the future development of repo-init beyond this improvement
> and whether or not additional flexibility is desirable/needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10080) Onboard org.apache.sling.jcr.maintenance to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271315#comment-17271315 ] Dan Klco commented on SLING-10080: -- [~bellingard] - Please onboard sling-org-apache-sling-jcr-maintenance to SonarCloud. > Onboard org.apache.sling.jcr.maintenance to SonarCloud > -- > > Key: SLING-10080 > URL: https://issues.apache.org/jira/browse/SLING-10080 > Project: Sling > Issue Type: Task >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > > [~bellingard] - can you please onboard > https://github.com/apache/sling-org-apache-sling-jcr-maintenance to > SonarCloud? > Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-distribution-core] cschneider commented on pull request #45: Fixed vault filter generation so that paths are properly escaped
cschneider commented on pull request #45: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/45#issuecomment-766809545 I think this does not fix the problem we had. I created a different fix here: https://issues.apache.org/jira/browse/SLING-10088 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-core] cschneider opened a new pull request #46: SLING-10088 - Correctly escape paths
cschneider opened a new pull request #46: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #321 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/321/ for details. No further emails will be sent until the status of the build is changed.
[jira] [Assigned] (SLING-9906) Avoid retrying to load jobs if classes are missing
[ https://issues.apache.org/jira/browse/SLING-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli reassigned SLING-9906: -- Assignee: Stefan Egli > Avoid retrying to load jobs if classes are missing > -- > > Key: SLING-9906 > URL: https://issues.apache.org/jira/browse/SLING-9906 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Carsten Ziegeler >Assignee: Stefan Egli >Priority: Major > Fix For: Event 4.2.14 > > > When a Sling job is tried to be loaded, it might reference public api classes > provided by bundles - although that is a bad pattern that should be avoid, > sometimes this is used. > While the job engine does not try to reload those jobs for execution - unless > such a new job is created (which is unlikely as the class is missing), the > re-assigning of jobs from a removed instance to a new one suffers from the > same problem. And that is retried over and over again. > So there are probably several possible improvements: > - make sure that jobs are not reloaded when public classes are missing during > job execution (unless bundles have changed) > - reduce log output to a log statement (except of stack trace) if > classloading for jobs fails > - change re-assigning of jobs to not require classes to be available. This > can probably be solved by using ResourceResolver.move -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10088) PatternSyntaxException: Unclosed group near index x
Christian Schneider created SLING-10088:
---
Summary: PatternSyntaxException: Unclosed group near index x
Key: SLING-10088
URL: https://issues.apache.org/jira/browse/SLING-10088
Project: Sling
Issue Type: Bug
Components: Content Distribution
Affects Versions: Content Distribution Core 0.4.2
Reporter: Christian Schneider
Assignee: Christian Schneider
Fix For: Content Distribution Core 0.4.4
if a path contains a "(" the following exception will occur when we try to
distribute it.
As far as I can tell the problem is a missing escaping of the path in
org.apache.sling.distribution.serialization.impl.vlt.VltUtils.createFilter.
{code:java}
[org.apache.sling.distribution.core:0.4.3.T20200720-c96d3fb] at
org.apache.sling.distribution.journal.impl.publisher.PackageMessageFactory.createAdd(PackageMessageFactory.java:95)
[org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693] at
org.apache.sling.distribution.journal.impl.publisher.PackageMessageFactory.create(PackageMessageFactory.java:86)
[org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693] at
org.apache.sling.distribution.journal.impl.publisher.DistributionPublisher.lambda$execute$1(DistributionPublisher.java:271)
[org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693] at
org.apache.sling.distribution.journal.shared.DistributionMetricsService.timed(DistributionMetricsService.java:147)
[org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693] at
org.apache.sling.distribution.journal.impl.publisher.DistributionPublisher.execute(DistributionPublisher.java:270)
[org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693] at
org.apache.sling.distribution.journal.impl.publisher.DistributionPublisher.execute(DistributionPublisher.java:259)
[org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693] at
org.apache.sling.distribution.impl.DefaultDistributor.distribute(DefaultDistributor.java:60)
[org.apache.sling.distribution.core:0.4.3.T20200720-c96d3fb] at
org.apache.sling.distribution.chunked.ChunkedDistribution.distributeChunk(ChunkedDistribution.java:124)
[org.apache.sling.distribution.chunked:0.1.0.20210121164255060] at
org.apache.sling.distribution.chunked.ChunkedDistribution.distribute(ChunkedDistribution.java:102)
[org.apache.sling.distribution.chunked:0.1.0.20210121164255060] at
org.apache.sling.distribution.chunked.ChunkedDistribution.process(ChunkedDistribution.java:72)
[org.apache.sling.distribution.chunked:0.1.0.20210121164255060] at
org.apache.sling.event.impl.jobs.queues.JobQueueImpl.startJob(JobQueueImpl.java:293)
[org.apache.sling.event:4.2.12] at
org.apache.sling.event.impl.jobs.queues.JobQueueImpl.access$100(JobQueueImpl.java:60)
[org.apache.sling.event:4.2.12] at
org.apache.sling.event.impl.jobs.queues.JobQueueImpl$1.run(JobQueueImpl.java:229)
[org.apache.sling.event:4.2.12] at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)Caused by:
java.util.regex.PatternSyntaxException: Unclosed group near index
20/nodewith(shouldwork at
java.base/java.util.regex.Pattern.error(Pattern.java:2027) at
java.base/java.util.regex.Pattern.accept(Pattern.java:1877) at
java.base/java.util.regex.Pattern.group0(Pattern.java:3060) at
java.base/java.util.regex.Pattern.sequence(Pattern.java:2123) at
java.base/java.util.regex.Pattern.expr(Pattern.java:2068) at
java.base/java.util.regex.Pattern.compile(Pattern.java:1782) at
java.base/java.util.regex.Pattern.(Pattern.java:1428) at
java.base/java.util.regex.Pattern.compile(Pattern.java:1068) at
org.apache.jackrabbit.vault.fs.filter.DefaultPathFilter.setPattern(DefaultPathFilter.java:68)
[org.apache.jackrabbit.vault:3.4.0] at
org.apache.jackrabbit.vault.fs.filter.DefaultPathFilter.(DefaultPathFilter.java:48)
[org.apache.jackrabbit.vault:3.4.0] at
org.apache.sling.distribution.serialization.impl.vlt.VltUtils.createFilter(VltUtils.java:92)
[org.apache.sling.distribution.core:0.4.3.T20200720-c96d3fb] at
org.apache.sling.distribution.serialization.impl.vlt.FileVaultContentSerializer.exportToStream(FileVaultContentSerializer.java:115)
[org.apache.sling.distribution.core:0.4.3.T20200720-c96d3fb] ... 21
common frames omitted
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
