[VOTE] Release Apache Sling Servlets Resolver version 2.8.0
Hi, We solved 5 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12350294 Changes: https://github.com/apache/sling-org-apache-sling-servlets-resolver/compare/org.apache.sling.servlets.resolver-2.7.14...org.apache.sling.servlets.resolver-2.8.0 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2502/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2502 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Resolved] (SLING-10615) DefaultErrorHandlerServlet json error response may throw a ClassCastException
[
https://issues.apache.org/jira/browse/SLING-10615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman resolved SLING-10615.
-
Resolution: Fixed
No concerns were raised, so I merged the PR at:
[{{fc1d22f}}|https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/fc1d22f79c31aa2e6eb91ef12b21c4af386242de]
> DefaultErrorHandlerServlet json error response may throw a ClassCastException
> -
>
> Key: SLING-10615
> URL: https://issues.apache.org/jira/browse/SLING-10615
> Project: Sling
> Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Servlets Resolver 2.8.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The DefaultErrorHandlerServlet json error response will fail with a
> ClassCastException if the "javax.servlet.error.exception_type" request
> attribute is not a String object.
> There is some inconsistency in what type of object the
> "javax.servlet.error.exception_type" should be in the error handler.
> * The servlet 3.1 specifications states that this attribute should be a
> "java.lang.Class" object.
> * The SlingConstants#ERROR_EXCEPTION_TYPE javadoc states that this attribute
> should be a "java.lang.String" object.
> In the interest of backward compatibility, the DefaultErrorHandlerServlet
> should try to handle it if the attribute value is either a String or a Class
> object.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-servlets-resolver] enapps-enorman merged pull request #18: SLING-10615 DefaultErrorHandlerServlet may throw a ClassCastException
enapps-enorman merged pull request #18: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-10638) Enable code checks with SpotBugs
Oliver Lietz created SLING-10638: Summary: Enable code checks with SpotBugs Key: SLING-10638 URL: https://issues.apache.org/jira/browse/SLING-10638 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Messaging 1.0.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10637) Enable code checks with PMD
Oliver Lietz created SLING-10637: Summary: Enable code checks with PMD Key: SLING-10637 URL: https://issues.apache.org/jira/browse/SLING-10637 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Messaging 1.0.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10635) Update to Sling Bundle Parent 43
Oliver Lietz created SLING-10635: Summary: Update to Sling Bundle Parent 43 Key: SLING-10635 URL: https://issues.apache.org/jira/browse/SLING-10635 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Messaging 1.0.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10636) Enable code checks with Checkstyle
Oliver Lietz created SLING-10636: Summary: Enable code checks with Checkstyle Key: SLING-10636 URL: https://issues.apache.org/jira/browse/SLING-10636 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Messaging 1.0.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10634) Enable code checks with SpotBugs
[ https://issues.apache.org/jira/browse/SLING-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-10634. -- Resolution: Done > Enable code checks with SpotBugs > > > Key: SLING-10634 > URL: https://issues.apache.org/jira/browse/SLING-10634 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Content Processing 1.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10633) Enable code checks with PMD
[ https://issues.apache.org/jira/browse/SLING-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-10633. -- Resolution: Done > Enable code checks with PMD > --- > > Key: SLING-10633 > URL: https://issues.apache.org/jira/browse/SLING-10633 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Content Processing 1.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10632) Enable code checks with Checkstyle
[ https://issues.apache.org/jira/browse/SLING-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-10632. -- Resolution: Done > Enable code checks with Checkstyle > -- > > Key: SLING-10632 > URL: https://issues.apache.org/jira/browse/SLING-10632 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Content Processing 1.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10631) Update to Sling Bundle Parent 43
[ https://issues.apache.org/jira/browse/SLING-10631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-10631. -- Resolution: Done > Update to Sling Bundle Parent 43 > > > Key: SLING-10631 > URL: https://issues.apache.org/jira/browse/SLING-10631 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Content Processing 1.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10630) Enable code checks with SpotBugs
[ https://issues.apache.org/jira/browse/SLING-10630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-10630. -- Resolution: Done > Enable code checks with SpotBugs > > > Key: SLING-10630 > URL: https://issues.apache.org/jira/browse/SLING-10630 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Content Analyzing 1.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh commented on pull request #12: SLING-10010 update to sling-bundle-parent 40
joerghoh commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/12#issuecomment-881949498 ok, then I will just update it to parent 43 and leave everything else for a different ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-10629) Enable code checks with PMD
[ https://issues.apache.org/jira/browse/SLING-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-10629. -- Resolution: Done > Enable code checks with PMD > --- > > Key: SLING-10629 > URL: https://issues.apache.org/jira/browse/SLING-10629 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Content Analyzing 1.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10628) Enable code checks with Checkstyle
[ https://issues.apache.org/jira/browse/SLING-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-10628. -- Resolution: Done > Enable code checks with Checkstyle > -- > > Key: SLING-10628 > URL: https://issues.apache.org/jira/browse/SLING-10628 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Content Analyzing 1.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10627) Update to Sling Bundle Parent 43
[ https://issues.apache.org/jira/browse/SLING-10627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-10627. -- Resolution: Done > Update to Sling Bundle Parent 43 > > > Key: SLING-10627 > URL: https://issues.apache.org/jira/browse/SLING-10627 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Content Analyzing 1.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10634) Enable code checks with SpotBugs
Oliver Lietz created SLING-10634: Summary: Enable code checks with SpotBugs Key: SLING-10634 URL: https://issues.apache.org/jira/browse/SLING-10634 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Content Processing 1.0.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10633) Enable code checks with PMD
Oliver Lietz created SLING-10633: Summary: Enable code checks with PMD Key: SLING-10633 URL: https://issues.apache.org/jira/browse/SLING-10633 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Content Processing 1.0.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10630) Enable code checks with SpotBugs
Oliver Lietz created SLING-10630: Summary: Enable code checks with SpotBugs Key: SLING-10630 URL: https://issues.apache.org/jira/browse/SLING-10630 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Content Analyzing 1.0.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10632) Enable code checks with Checkstyle
Oliver Lietz created SLING-10632: Summary: Enable code checks with Checkstyle Key: SLING-10632 URL: https://issues.apache.org/jira/browse/SLING-10632 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Content Processing 1.0.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10631) Update to Sling Bundle Parent 43
Oliver Lietz created SLING-10631: Summary: Update to Sling Bundle Parent 43 Key: SLING-10631 URL: https://issues.apache.org/jira/browse/SLING-10631 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Content Processing 1.0.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10627) Update to Sling Bundle Parent 43
Oliver Lietz created SLING-10627: Summary: Update to Sling Bundle Parent 43 Key: SLING-10627 URL: https://issues.apache.org/jira/browse/SLING-10627 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Content Analyzing 1.0.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10629) Enable code checks with PMD
Oliver Lietz created SLING-10629: Summary: Enable code checks with PMD Key: SLING-10629 URL: https://issues.apache.org/jira/browse/SLING-10629 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Content Analyzing 1.0.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10628) Enable code checks with Checkstyle
Oliver Lietz created SLING-10628: Summary: Enable code checks with Checkstyle Key: SLING-10628 URL: https://issues.apache.org/jira/browse/SLING-10628 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Content Analyzing 1.0.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on pull request #12: SLING-10010 update to sling-bundle-parent 40
kwin commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/12#issuecomment-881943994 I would like to separate these things. The update to a newer parent is not directly related to migrating to other testing classes. This PR is now 7 month old (at that time parent 40 was the latest) and there was never any review. Feel free to pick it up from where it is and update to parent 43. I can do a review afterwards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh edited a comment on pull request #12: SLING-10010 update to sling-bundle-parent 40
joerghoh edited a comment on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/12#issuecomment-881912890 @kwin I think we should drop the dependency to sling-commons-testing, we should start to use the sling mocks instead (they are maintained and much more easier to use). For that reason I added the 2 relevant classes in here, which serve as a replacement for the ones of sling-commons-testing, but Oak-based. I also think that we should invest in some time and update some Junit3 tests to Junit4, which I haven't done yet to keep the scope of the patch as narrow as possible. Also we should update to the most recent of the parent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh commented on pull request #12: SLING-10010 update to sling-bundle-parent 40
joerghoh commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/12#issuecomment-881912890 @kwin I think we should drop the dependency to sling-commons-testing, we should start to use the sling mocks instead (they are maintained and much more easier to use). For that reason I added the 2 relevant classes in here, which serve as a replacement for the ones of sling-commons-testing, but Oak-based. I also think that we should invest in some time and update some Junit3 tests to Junit4, which I haven't done yet to keep the scope of the patch as narrow as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #12: SLING-10010 update to sling-bundle-parent 40
sonarcloud[bot] commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/12#issuecomment-881912530 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=12=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=12=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=12=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=12=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=12=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=12=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=12=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=12=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=12=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=12=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=12=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=12=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=12=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=12=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=12=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10618) Onboard the Apache Sling GraphQL Schema Aggregator module to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-10618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382519#comment-17382519 ] Fabrice Bellingard commented on SLING-10618: Done [~bdelacretaz]! => https://sonarcloud.io/project/configuration?id=apache_sling-org-apache-sling-graphql-schema-aggregator > Onboard the Apache Sling GraphQL Schema Aggregator module to SonarCloud > --- > > Key: SLING-10618 > URL: https://issues.apache.org/jira/browse/SLING-10618 > Project: Sling > Issue Type: Task > Components: GraphQL >Reporter: Bertrand Delacretaz >Assignee: Fabrice Bellingard >Priority: Minor > > [~bellingard], could you onboard this new module to SonarCloud? > https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator > Thank you very much! -- This message was sent by Atlassian Jira (v8.3.4#803005)
