Re: [DISCUSS] Sling RepoInit Webconsole

[Bertrand Delacretaz]

On Fri, Aug 6, 2021 at 2:40 PM Bertrand Delacretaz
 wrote:
> ...Jbang scripts [1] for example might be a nice way to do that...

I tried that [1] and that works well, at least if your goal is only to
check the syntax of repoinit scripts.

To run that script, use:

$ jbang trust add https://github.com/apache/sling-whiteboard/

$ cat > /tmp/xx 

[GitHub] [sling-scriptingbundle-maven-plugin] sonarcloud[bot] commented on pull request #5: SLING-10707 correctly escape values in capability headers

[GitBox]

sonarcloud[bot] commented on pull request #5:
URL: 
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/5#issuecomment-894510340


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=CODE_SMELL)
   
   
[![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png
 
'100.0%')](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&metric=new_coverage&view=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-scriptingbundle-maven-plugin] sonarcloud[bot] removed a comment on pull request #5: SLING-10707 correctly escape values in capability headers

[GitBox]

sonarcloud[bot] removed a comment on pull request #5:
URL: 
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/5#issuecomment-894410662


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=CODE_SMELL)
   
   
[![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png
 
'100.0%')](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&metric=new_coverage&view=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [DISCUSS] Sling RepoInit Webconsole

[Eric Norman]

Perhaps your original goal of easily testing RepoInit script could be
accomplished by creating some sort of (parameterized) generic integration
test?

Imagine a test that starts up an instance of sling by using paxexam (or
feature launcher?) with the existing bundle (or a tinybundle created on the
fly) configured to be deployed and then let the test do some assertions to
make sure it worked.  The test automation may be more efficient (and
reusable?) than the manual steps you outlined for a webconsole plugin.

Regards,
Eric

On Fri, Aug 6, 2021 at 7:52 AM Bertrand Delacretaz 
wrote:

> Hi Dan,
>
> On Fri, Aug 6, 2021 at 3:55 PM Daniel Klco  wrote:
> > On Fri, Aug 6, 2021 at 8:40 AM Bertrand Delacretaz <
> bdelacre...@apache.org>
> > wrote:
> > >...I think nowadays we'd rather create command-line
> > > utilities for such things,...
>
> > ...The question I have though is how would I get access to the running
> OSGi
> > context? I've done JCR over RMI, but I'm not seeing a good way to invoke
> > services remotely...
>
> I think you either need a specific servlet on the Sling side, which
> kind of defeats the whole purpose of a command-line tool, or you can
> inject code from the client side given the appropriate permissions.
> Uploading a Sling script comes to mind, but that won't work if the
> target instance uses read-only scripts.
>
> -Bertrand
>

Re: Release Management: Always update to latest parent prior release?

[Eric Norman]

I would not be opposed to requiring (or at least recommending) to update to
the latest parent before each release.  Especially if doing so doesn't
require any substantial additional work.

It's not a good experience to keep running into modules that won't build
with Java 11, so anything that encourages moving to a compatible parent
would be good.

On Fri, Aug 6, 2021 at 5:29 AM Robert Munteanu  wrote:

> Hi Konrad,
>
> On Fri, 2021-08-06 at 13:36 +0200, Konrad Windszus wrote:
> >
> > What do you think about adding a check to the release management page
> > in
> >
> https://sling.apache.org/documentation/development/release-management.html#prerequisites
> >  <
> >
> https://sling.apache.org/documentation/development/release-management.html#prerequisites
> > > that the module must reference the latest Sling Parent?
>
> Updating to the latest parent module version is not always easy,
> especially with the maven-bundle-plugin → bnd-maven-plugin migration
> and switching from the Felix annotations to the official OSGi ones.
>
> I would be very happy to see all modules updated to the latest parent
> pom, but I think it's not going to be always feasible.
>
> Thanks,
> Robert
>
>

Re: [VOTE] Release Apache Sling Scripting HTL Compiler version 1.2.14-1.4.0, Scripting HTL Runtime version 1.2.6-1.4.0

[Eric Norman]

Hi Konrad,

Would have been good to update to a more recent parent though, because this
> release
>

Yes, I missed that those modules were not using the most recent parent.  I
usually try to update the parent before a new release.

I think I'll continue with this release in order to unblock the fix of
SLING-10677  for Scripting
HTL Engine 1.4.10-1.4.0


I can update the parent for these modules for the next pass.

Regards,
Eric

On Fri, Aug 6, 2021 at 4:21 AM Konrad Windszus  wrote:

> +1
>
> Would have been good to update to a more recent parent though, because
> this release
> - is lacking SHA512 for the source-release artifacts
> - is not reproducible
>
> as both modules still reference sling-bundle-parent 38
>
> Konrad
>
> > On 3. Aug 2021, at 21:22, Eric Norman  wrote:
> >
> > Hi,
> >
> > We solved 1 issues in the Scripting HTL Compiler 1.2.14-1.4.0 release:
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12350467
> >
> > Changes:
> >
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/compare/org.apache.sling.scripting.sightly.compiler-1.2.12-1.4.0...org.apache.sling.scripting.sightly.compiler-1.2.14-1.4.0
> >
> > We solved 4 issues in the Scripting HTL Runtime 1.2.6-1.4.0 release:
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12350438
> >
> > Changes:
> >
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-runtime/compare/org.apache.sling.scripting.sightly.runtime-1.2.4-1.4.0...org.apache.sling.scripting.sightly.runtime-1.2.6-1.4.0
> >
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2510/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2510 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >  [ ] +1 Approve the release
> >  [ ]  0 Don't care
> >  [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
>
>

[GitHub] [sling-scriptingbundle-maven-plugin] sonarcloud[bot] commented on pull request #5: SLING-10707 correctly escape values in capability headers

[GitBox]

sonarcloud[bot] commented on pull request #5:
URL: 
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/5#issuecomment-894410662


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&resolved=false&types=CODE_SMELL)
   
   
[![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png
 
'100.0%')](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&metric=new_coverage&view=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=5&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-scriptingbundle-maven-plugin] kwin opened a new pull request #5: SLING-10707 correctly escape values in capability headers

[GitBox]

kwin opened a new pull request #5:
URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/5


   add tests
   leverage bnd Parameters class for escaping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10706) Order of selectors not kept

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394903#comment-17394903
 ] 

Konrad Windszus commented on SLING-10706:
-

Does that mean, that this plugin will never register more than 1 selector for a 
single script? That would be an even bigger flaw then...

> Order of selectors not kept
> ---
>
> Key: SLING-10706
> URL: https://issues.apache.org/jira/browse/SLING-10706
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The selectors used for registration of script/servlets have an order: Only if 
> they appear in the given order the script/servlet matches 
> (https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
> The order is potentially lost, though during the generation of the 
> capabilities headers as the code is using Sets internally.
> Also it is totally valid to register a script to "myselector.myselector" 
> which cannot be expressed with Sets either.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (SLING-10706) Order of selectors not kept

[Radu Cotescu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394869#comment-17394869
 ] 

Radu Cotescu edited comment on SLING-10706 at 8/6/21, 4:19 PM:
---

I see your point, but then I think we need to rephrase this issue and state the 
actual problems:
# nested identical selectors are not correctly generating a capability
# nested resource types should contribute selector scripts to resource types 
higher in the file hierarchy (I think we're filtering this in the plugin right 
now)


was (Author: radu.cotescu):
I see your point, but then I think we need to rephrase this issue and state the 
actual problems:
1. nested identical selectors are not correctly generating a capability
2. nested resource types should contribute selector scripts to resource types 
higher in the file hierarchy (I think we're filtering this in the plugin right 
now)

> Order of selectors not kept
> ---
>
> Key: SLING-10706
> URL: https://issues.apache.org/jira/browse/SLING-10706
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The selectors used for registration of script/servlets have an order: Only if 
> they appear in the given order the script/servlet matches 
> (https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
> The order is potentially lost, though during the generation of the 
> capabilities headers as the code is using Sets internally.
> Also it is totally valid to register a script to "myselector.myselector" 
> which cannot be expressed with Sets either.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10706) Order of selectors not kept

[Radu Cotescu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394869#comment-17394869
 ] 

Radu Cotescu commented on SLING-10706:
--

I see your point, but then I think we need to rephrase this issue and state the 
actual problems:
1. nested identical selectors are not correctly generating a capability
2. nested resource types should contribute selector scripts to resource types 
higher in the file hierarchy (I think we're filtering this in the plugin right 
now)

> Order of selectors not kept
> ---
>
> Key: SLING-10706
> URL: https://issues.apache.org/jira/browse/SLING-10706
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The selectors used for registration of script/servlets have an order: Only if 
> they appear in the given order the script/servlet matches 
> (https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
> The order is potentially lost, though during the generation of the 
> capabilities headers as the code is using Sets internally.
> Also it is totally valid to register a script to "myselector.myselector" 
> which cannot be expressed with Sets either.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10706) Order of selectors not kept

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394855#comment-17394855
 ] 

Konrad Windszus commented on SLING-10706:
-

According to 
https://sling.apache.org/documentation/the-sling-engine/url-to-script-resolution.html#script-naming-conventions
 it would be indeed
{code}
/apps/scripts/myscript/sel1/sel1.html
{code}

That should resolve for request to {{/content/my.sel1.sel1.html}} given that 
{{/content/my}} has the resource type {{/apps/scripts/myscript}}.

Whether that script additionally resolves for {{/content/mysel1.sel1.html}} 
given that {{/content/mysel1}} has the resource type 
{{/apps/scripts/myscript/sel1}} does not really matter in this context.

> Order of selectors not kept
> ---
>
> Key: SLING-10706
> URL: https://issues.apache.org/jira/browse/SLING-10706
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The selectors used for registration of script/servlets have an order: Only if 
> they appear in the given order the script/servlet matches 
> (https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
> The order is potentially lost, though during the generation of the 
> capabilities headers as the code is using Sets internally.
> Also it is totally valid to register a script to "myselector.myselector" 
> which cannot be expressed with Sets either.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10706) Order of selectors not kept

[Radu Cotescu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394848#comment-17394848
 ] 

Radu Cotescu commented on SLING-10706:
--

In the classical setup (scripts in the repository) how would you define a 
script mapped to a list of identical selectors without doing weird things? To 
my knowledge, as soon as you have more than one selector to which you want to 
map a script you will end up with folder structures, e.g.:
{noformat}
/apps/scripts/myscript
myscript.html
sel1/sel2.html
{noformat}

If you had something like:
{noformat}
/apps/scripts/myscript
myscript.html
sel1/sel1.html
{noformat}

then I think that we'd talk about two resource types: {{scripts/myscript}} and 
{{scripts/myscript/sel1}}.

> Order of selectors not kept
> ---
>
> Key: SLING-10706
> URL: https://issues.apache.org/jira/browse/SLING-10706
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The selectors used for registration of script/servlets have an order: Only if 
> they appear in the given order the script/servlet matches 
> (https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
> The order is potentially lost, though during the generation of the 
> capabilities headers as the code is using Sets internally.
> Also it is totally valid to register a script to "myselector.myselector" 
> which cannot be expressed with Sets either.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10706) Order of selectors not kept

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394845#comment-17394845
 ] 

Konrad Windszus commented on SLING-10706:
-

Even if you use a sorted set impl this won't work for "myselector.myselector". 
Selectors are not necessarily unique!

> Order of selectors not kept
> ---
>
> Key: SLING-10706
> URL: https://issues.apache.org/jira/browse/SLING-10706
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The selectors used for registration of script/servlets have an order: Only if 
> they appear in the given order the script/servlet matches 
> (https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
> The order is potentially lost, though during the generation of the 
> capabilities headers as the code is using Sets internally.
> Also it is totally valid to register a script to "myselector.myselector" 
> which cannot be expressed with Sets either.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10706) Order of selectors not kept

[Radu Cotescu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394843#comment-17394843
 ] 

Radu Cotescu commented on SLING-10706:
--

I don't think that this issue is valid - whenever dealing with selectors, the 
plugins use a {{LinkedHashSet}}. Do you have a test that fails?

> Order of selectors not kept
> ---
>
> Key: SLING-10706
> URL: https://issues.apache.org/jira/browse/SLING-10706
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The selectors used for registration of script/servlets have an order: Only if 
> they appear in the given order the script/servlet matches 
> (https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
> The order is potentially lost, though during the generation of the 
> capabilities headers as the code is using Sets internally.
> Also it is totally valid to register a script to "myselector.myselector" 
> which cannot be expressed with Sets either.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10706) Order of selectors not kept

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10706:

Description: 
The selectors used for registration of script/servlets have an order: Only if 
they appear in the given order the script/servlet matches 
(https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
The order is potentially lost, though during the generation of the capabilities 
headers as the code is using Sets internally.
Also it is totally valid to register a script to "myselector.myselector" which 
cannot be expressed with Sets either.

  was:
The selectors used for registration of script/servlets have an order: Only if 
they appear in the given order the script/servlet matches 
(https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
The order is potentially lost, though during the generation of the capabilities 
headers as the code is using Sets internally.


> Order of selectors not kept
> ---
>
> Key: SLING-10706
> URL: https://issues.apache.org/jira/browse/SLING-10706
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The selectors used for registration of script/servlets have an order: Only if 
> they appear in the given order the script/servlet matches 
> (https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
> The order is potentially lost, though during the generation of the 
> capabilities headers as the code is using Sets internally.
> Also it is totally valid to register a script to "myselector.myselector" 
> which cannot be expressed with Sets either.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-10707) Comma in selector not correctly escaped in capability header

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-10707:
---

Assignee: Konrad Windszus

> Comma in selector not correctly escaped in capability header
> 
>
> Key: SLING-10707
> URL: https://issues.apache.org/jira/browse/SLING-10707
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The manual escaping in 
> https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/master/src/main/java/org/apache/sling/scriptingbundle/plugin/capability/Capabilities.java
>   is not enough for list items containing a comma.
> According to 
> http://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html#i3306043
> bq. Commas or reverse solidi ('\' \u005C) that are part of an element value 
> must be escaped by prefixing them with a reverse solidus. In practice, this 
> requires escaping with two reverse solidi because a reverse solidus must 
> already be escaped in strings.
> Instead of doing the escaping manually (and always use quoted strings) I 
> would rather leverage {{aQute.bnd.header.OSGiHeader}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10707) Comma in selector not correctly escaped in capability header

[Konrad Windszus (Jira)]

Konrad Windszus created SLING-10707:
---

 Summary: Comma in selector not correctly escaped in capability 
header
 Key: SLING-10707
 URL: https://issues.apache.org/jira/browse/SLING-10707
 Project: Sling
  Issue Type: Bug
  Components: Maven Plugins and Archetypes
Affects Versions: Scripting Bundle Maven Plugin 0.3.0
Reporter: Konrad Windszus
 Fix For: Scripting Bundle Maven Plugin 0.4.0


The manual escaping in 
https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/master/src/main/java/org/apache/sling/scriptingbundle/plugin/capability/Capabilities.java
  is not enough for list items containing a comma.

According to 
http://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html#i3306043

bq. Commas or reverse solidi ('\' \u005C) that are part of an element value 
must be escaped by prefixing them with a reverse solidus. In practice, this 
requires escaping with two reverse solidi because a reverse solidus must 
already be escaped in strings.

Instead of doing the escaping manually (and always use quoted strings) I would 
rather leverage {{aQute.bnd.header.OSGiHeader}}





--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-scriptingbundle-maven-plugin] sonarcloud[bot] commented on pull request #4: SLING-10693 fail build in case of invalid extends/requires file

[GitBox]

sonarcloud[bot] commented on pull request #4:
URL: 
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/4#issuecomment-894316454


   SonarCloud Quality Gate failed.    ![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate failed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
   
   
[![76.9%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'76.9%')](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&metric=new_coverage&view=list)
 [76.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-scriptingbundle-maven-plugin] sonarcloud[bot] removed a comment on pull request #4: SLING-10693 fail build in case of invalid extends/requires file

[GitBox]

sonarcloud[bot] removed a comment on pull request #4:
URL: 
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/4#issuecomment-894311180


   SonarCloud Quality Gate failed.    ![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate failed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
   
   
[![76.9%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'76.9%')](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&metric=new_coverage&view=list)
 [76.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [DISCUSS] Sling RepoInit Webconsole

[Bertrand Delacretaz]

Hi Dan,

On Fri, Aug 6, 2021 at 3:55 PM Daniel Klco  wrote:
> On Fri, Aug 6, 2021 at 8:40 AM Bertrand Delacretaz 
> wrote:
> >...I think nowadays we'd rather create command-line
> > utilities for such things,...

> ...The question I have though is how would I get access to the running OSGi
> context? I've done JCR over RMI, but I'm not seeing a good way to invoke
> services remotely...

I think you either need a specific servlet on the Sling side, which
kind of defeats the whole purpose of a command-line tool, or you can
inject code from the client side given the appropriate permissions.
Uploading a Sling script comes to mind, but that won't work if the
target instance uses read-only scripts.

-Bertrand

[GitHub] [sling-scriptingbundle-maven-plugin] sonarcloud[bot] commented on pull request #4: SLING-10693 fail build in case of invalid extends/requires file

[GitBox]

sonarcloud[bot] commented on pull request #4:
URL: 
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/4#issuecomment-894311180


   SonarCloud Quality Gate failed.    ![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate failed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
   
   
[![76.9%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'76.9%')](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&metric=new_coverage&view=list)
 [76.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-scriptingbundle-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-10706) Order of selectors not kept

[Konrad Windszus (Jira)]

Konrad Windszus created SLING-10706:
---

 Summary: Order of selectors not kept
 Key: SLING-10706
 URL: https://issues.apache.org/jira/browse/SLING-10706
 Project: Sling
  Issue Type: Bug
  Components: Maven Plugins and Archetypes
Affects Versions: Scripting Bundle Maven Plugin 0.3.0
Reporter: Konrad Windszus
 Fix For: Scripting Bundle Maven Plugin 0.4.0


The selectors used for registration of script/servlets have an order: Only if 
they appear in the given order the script/servlet matches 
(https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
The order is potentially lost, though during the generation of the capabilities 
headers as the code is using Sets internally.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Scripting Core 2.4.0

[Jörg Hoh]

+1 (non-binding)

Am Do., 5. Aug. 2021 um 15:22 Uhr schrieb Radu Cotescu :

> Hi,
>
> We solved 5 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12350330
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2511/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2511 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> Radu Cotescu
>


-- 
Cheers,
Jörg Hoh,

https://cqdump.joerghoh.de
Twitter: @joerghoh

Re: [VOTE] Release Apache Sling Scripting HTL Compiler version 1.2.14-1.4.0, Scripting HTL Runtime version 1.2.6-1.4.0

[Daniel Klco]

+1

On Fri, Aug 6, 2021 at 7:21 AM Konrad Windszus  wrote:

> +1
>
> Would have been good to update to a more recent parent though, because
> this release
> - is lacking SHA512 for the source-release artifacts
> - is not reproducible
>
> as both modules still reference sling-bundle-parent 38
>
> Konrad
>
> > On 3. Aug 2021, at 21:22, Eric Norman  wrote:
> >
> > Hi,
> >
> > We solved 1 issues in the Scripting HTL Compiler 1.2.14-1.4.0 release:
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12350467
> >
> > Changes:
> >
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/compare/org.apache.sling.scripting.sightly.compiler-1.2.12-1.4.0...org.apache.sling.scripting.sightly.compiler-1.2.14-1.4.0
> >
> > We solved 4 issues in the Scripting HTL Runtime 1.2.6-1.4.0 release:
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12350438
> >
> > Changes:
> >
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-runtime/compare/org.apache.sling.scripting.sightly.runtime-1.2.4-1.4.0...org.apache.sling.scripting.sightly.runtime-1.2.6-1.4.0
> >
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2510/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2510 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >  [ ] +1 Approve the release
> >  [ ]  0 Don't care
> >  [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
>
>

Re: [VOTE] Release Apache Sling Installer Core 3.12.0, Installer Factory Configuration 1.4.0 and Installer Factory Feature 0.6.0

[Daniel Klco]

+1

On Fri, Aug 6, 2021 at 8:34 AM Carsten Ziegeler 
wrote:

> +1
>
> Carsten
>
> Am 06.08.2021 um 11:14 schrieb Carsten Ziegeler:
> > Hi,
> >
> > We solved 2 issues for Installer Core 3.12.0:
> > https://issues.apache.org/jira/projects/SLING/versions/12348646
> >
> > We solved 1 issues for Installer Factory Configuration 1.4.0:
> > https://issues.apache.org/jira/projects/SLING/versions/12349582
> >
> > We solved 3 issues for Installer Factory Feature Model 0.6.0:
> > https://issues.apache.org/jira/projects/SLING/versions/12348804
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2512/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> >
> > Usage:
> > sh check_staged_release.sh 2512 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >[ ] +1 Approve the release
> >[ ]  0 Don't care
> >[ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > Regards
> > Carsten
>
> --
> Carsten Ziegeler
> Adobe
> cziege...@apache.org
>

Re: [DISCUSS] Sling RepoInit Webconsole

[Daniel Klco]

On Fri, Aug 6, 2021 at 8:40 AM Bertrand Delacretaz 
wrote:

> Hi,
>
> On Thu, Aug 5, 2021 at 8:00 PM Daniel Klco  wrote:
> > ...I've been working on a web console plugin for users to test and
> validate
> > their RepoInit scripts on an instance of Sling. It would not be expected
> to
> > be installed in production, but something for developers to install in a
> > local instance
>
> Any code that gets written is bound to end up in production some day ;-)
>
> More seriously, I think nowadays we'd rather create command-line
> utilities for such things, but I don't think we have a good framework
> for doing that at this point.
>
> Jbang scripts [1] for example might be a nice way to do that if
> someone has good ideas.
>

That makes a lot of sense to me, a CLI tool seems more useful since it
would require less setup than having to install then whitelist a bundle.
The question I have though is how would I get access to the running OSGi
context? I've done JCR over RMI, but I'm not seeing a good way to invoke
services remotely.


>
> This is just a general comment, I'm not opposed to a webconsole plugin
> in this case.
>
> > ...Please review the project in the Sling Whiteboard:
> >
> https://github.com/apache/sling-whiteboard/tree/master/org.apache.sling.repoinit.webconsole
> ...
>
> I was going to say that you should use the incoming request's identity
> instead of calling loginAdministrative [2] but I forgot if that's
> possible in a web console plugin.


> The current code causes a privilege escalation, which might be ok for
> a console plugin but that IMHO we should avoid if possible.
>

Thus the non-production callout :-D


>
> -Bertrand
>
> [1] https://www.jbang.dev/
> [2]
> https://github.com/apache/sling-whiteboard/blob/c369b1bbba2c990cfe05d706efdb1ba5050f5fa6/org.apache.sling.repoinit.webconsole/src/main/java/org/apache/sling/repoinit/webconsole/RepoInitWebConsole.java#L152
>

[GitHub] [sling-org-apache-sling-repoinit-parser] bdelacretaz commented on pull request #13: SLING-10136 Add operation for deleting a path

[GitBox]

bdelacretaz commented on pull request #13:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/13#issuecomment-894245812


   > How can we address this issue though?
   
   I think best is to discuss it in SLING-10136, I added some comments there. I 
might not be available in the next few days to discuss more, don't wait for me 
if you reach consensus there!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [DISCUSS] Sling RepoInit Webconsole

[Bertrand Delacretaz]

Hi,

On Thu, Aug 5, 2021 at 8:00 PM Daniel Klco  wrote:
> ...I've been working on a web console plugin for users to test and validate
> their RepoInit scripts on an instance of Sling. It would not be expected to
> be installed in production, but something for developers to install in a
> local instance

Any code that gets written is bound to end up in production some day ;-)

More seriously, I think nowadays we'd rather create command-line
utilities for such things, but I don't think we have a good framework
for doing that at this point.

Jbang scripts [1] for example might be a nice way to do that if
someone has good ideas.

This is just a general comment, I'm not opposed to a webconsole plugin
in this case.

> ...Please review the project in the Sling Whiteboard:
> https://github.com/apache/sling-whiteboard/tree/master/org.apache.sling.repoinit.webconsole
>  ...

I was going to say that you should use the incoming request's identity
instead of calling loginAdministrative [2] but I forgot if that's
possible in a web console plugin.

The current code causes a privilege escalation, which might be ok for
a console plugin but that IMHO we should avoid if possible.

-Bertrand

[1] https://www.jbang.dev/
[2] 
https://github.com/apache/sling-whiteboard/blob/c369b1bbba2c990cfe05d706efdb1ba5050f5fa6/org.apache.sling.repoinit.webconsole/src/main/java/org/apache/sling/repoinit/webconsole/RepoInitWebConsole.java#L152

[jira] [Commented] (SLING-10136) Sling Repo Init: Add option to delete paths

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394739#comment-17394739
 ] 

Bertrand Delacretaz commented on SLING-10136:
-

Considering that there is a "create path" operation, I think there should also 
be a "delete path".

However that's quite a dangerous operation, and might take a long time if 
there's lots of content and/or listeners triggered during deletion.

Do people have an idea on how to avoid the risk, or make sure whoever writes 
that statement is aware of the risk?

One approach might be to count the child nodes of the deletion candidate 
recursively and failing the command once that count reaches a set limit. And 
maybe allow raising the limit value with {{DELETE PATH /somepath LIMIT }} 
where N sets a new limit.

That's a crude mechanism but would at least make people aware that in general 
this is meant to delete small quantities of content only.

Alternatively, we might create a version of the path before deleting it, to 
provide a way to restore it if needed, but I'm not sure if that's practical or 
if that might cause other problems.

> Sling Repo Init: Add option to delete paths
> ---
>
> Key: SLING-10136
> URL: https://issues.apache.org/jira/browse/SLING-10136
> Project: Sling
>  Issue Type: New Feature
>  Components: Repoinit
>Affects Versions: Repoinit Parser 1.6.4, Repoinit JCR 1.1.30
>Reporter: Henry Kuijpers
>Priority: Major
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Given that we are able to create paths, it would also be beneficial to be 
> able to delete paths as well. 
> In our case, we're migrating a legacy setup to Sling Repo Init, where there 
> are some "leftover" nodes in the instances. Given that Sling Repo Init is an 
> "admin" way to initialize a repo, it would be very nice if delete statements 
> could be supported.
> In our case, we would want to delete /apps/foundation, for example, because 
> historically there seem to have been modifications made there.
> This mandates for a simple syntax like "delete path /apps/foundation" being 
> supported.
> Another case is that we would like to cleanup /apps/cq, however, there are 
> some nodes that are maintained by the product (in our case AEM), such as 
> /apps/cq/xssprotection and also /apps/cq/core/content/nav/tools. 
> This mandates for a slightly more complicated syntax such as "delete path 
> /apps/cq (!/xssprotection,!/core/content/nav/tools,*)", however, I would be 
> fine with multiple delete path statements as well, for that usecase.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Installer Core 3.12.0, Installer Factory Configuration 1.4.0 and Installer Factory Feature 0.6.0

[Carsten Ziegeler]

+1

Carsten

Am 06.08.2021 um 11:14 schrieb Carsten Ziegeler:

Hi,

We solved 2 issues for Installer Core 3.12.0:
https://issues.apache.org/jira/projects/SLING/versions/12348646

We solved 1 issues for Installer Factory Configuration 1.4.0:
https://issues.apache.org/jira/projects/SLING/versions/12349582

We solved 3 issues for Installer Factory Feature Model 0.6.0:
https://issues.apache.org/jira/projects/SLING/versions/12348804

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2512/

You can use this UNIX script to download the release and verify the 
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD 



Usage:
sh check_staged_release.sh 2512 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten


--
Carsten Ziegeler
Adobe
cziege...@apache.org

[GitHub] [sling-org-apache-sling-repoinit-parser] henrykuijpers commented on pull request #13: SLING-10136 Add operation for deleting a path

[GitBox]

henrykuijpers commented on pull request #13:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/13#issuecomment-894226999


   > Sorry that I took so long to take a look at this.
   > 
   > The code looks good to me.
   > 
   > In SLING-10136, Konrad expresses concerns about implementing this 
operation, I think those should be addressed before merging this.
   
   I agree! How can we address this issue though? I'm fine with any concensus 
we can reach. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-repoinit] bdelacretaz commented on pull request #20: SLING-10136 Add delete path operation

[GitBox]

bdelacretaz commented on pull request #20:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/20#issuecomment-894226396


   Sorry that I took so long to take a look at this.
   
   The code looks good to me.
   
   Same comment as in apache/sling-org-apache-sling-repoinit-parser#13 : in 
SLING-10136, Konrad expresses concerns about implementing this operation, I 
think those should be addressed before merging this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Release Management: Always update to latest parent prior release?

[Robert Munteanu]

Hi Konrad,

On Fri, 2021-08-06 at 13:36 +0200, Konrad Windszus wrote:
> 
> What do you think about adding a check to the release management page
> in
> https://sling.apache.org/documentation/development/release-management.html#prerequisites
>  <
> https://sling.apache.org/documentation/development/release-management.html#prerequisites
> > that the module must reference the latest Sling Parent?

Updating to the latest parent module version is not always easy,
especially with the maven-bundle-plugin → bnd-maven-plugin migration
and switching from the Felix annotations to the official OSGi ones.

I would be very happy to see all modules updated to the latest parent
pom, but I think it's not going to be always feasible.

Thanks,
Robert

[GitHub] [sling-org-apache-sling-repoinit-parser] bdelacretaz commented on pull request #13: SLING-10136 Add operation for deleting a path

[GitBox]

bdelacretaz commented on pull request #13:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/13#issuecomment-894225566


   Sorry that I took so long to take a look at this.
   
   The code looks good to me.
   
   In SLING-10136, Konrad expresses concerns about implementing this operation, 
I think those should be addressed before merging this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Release Management: Always update to latest parent prior release?

[Konrad Windszus]

Hi,
according to ASF policy we should provide a SHA512 for the source-release 
artifact (https://infra.apache.org/release-distribution#sigs-and-sums 
). In addition it 
would be nice to allow reproducible builds 
(https://maven.apache.org/guides/mini/guide-reproducible-builds.html 
).

Basic support for former has been added in Sling Parent 35 
(https://github.com/apache/sling-parent/commit/8d1903a1189424c8ba8a8a110b2dd9d75a8744fe0
 
)
 and also added to the staging repo in Parent 43 
(https://issues.apache.org/jira/browse/SLING-7534 
)
The latter is supported since https://issues.apache.org/jira/browse/SLING-9307 
.
Also building with Java 11 is only supported in newer Sling Parents.

What do you think about adding a check to the release management page in 
https://sling.apache.org/documentation/development/release-management.html#prerequisites
 

 that the module must reference the latest Sling Parent?

WDYT?
Konrad

Re: [VOTE] Release Apache Sling Installer Core 3.12.0, Installer Factory Configuration 1.4.0 and Installer Factory Feature 0.6.0

[Konrad Windszus]

+1

Due to usage of old Sling Parent this neither has a SH512 checksum for 
source-release nor is a reproducible build, though...

Konrad



> On 6. Aug 2021, at 11:14, Carsten Ziegeler  wrote:
> 
> Hi,
> 
> We solved 2 issues for Installer Core 3.12.0:
> https://issues.apache.org/jira/projects/SLING/versions/12348646
> 
> We solved 1 issues for Installer Factory Configuration 1.4.0:
> https://issues.apache.org/jira/projects/SLING/versions/12349582
> 
> We solved 3 issues for Installer Factory Feature Model 0.6.0:
> https://issues.apache.org/jira/projects/SLING/versions/12348804
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2512/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2512 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards
> Carsten
> -- 
> Carsten Ziegeler
> Adobe
> cziege...@apache.org

Re: [VOTE] Release Apache Sling Scripting HTL Compiler version 1.2.14-1.4.0, Scripting HTL Runtime version 1.2.6-1.4.0

[Konrad Windszus]

+1

Would have been good to update to a more recent parent though, because this 
release 
- is lacking SHA512 for the source-release artifacts 
- is not reproducible

as both modules still reference sling-bundle-parent 38

Konrad

> On 3. Aug 2021, at 21:22, Eric Norman  wrote:
> 
> Hi,
> 
> We solved 1 issues in the Scripting HTL Compiler 1.2.14-1.4.0 release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12350467
> 
> Changes:
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/compare/org.apache.sling.scripting.sightly.compiler-1.2.12-1.4.0...org.apache.sling.scripting.sightly.compiler-1.2.14-1.4.0
> 
> We solved 4 issues in the Scripting HTL Runtime 1.2.6-1.4.0 release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12350438
> 
> Changes:
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-runtime/compare/org.apache.sling.scripting.sightly.runtime-1.2.4-1.4.0...org.apache.sling.scripting.sightly.runtime-1.2.6-1.4.0
> 
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2510/
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2510 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.

Re: [Proposal] Lift OSGi Feature Service impl from Sling Whiteboard into own repo

[Robert Munteanu]

Hi David,

On Fri, 2021-08-06 at 07:31 +0100, dav...@apache.org wrote:
> To prepare this implementation so that it can be released and be a
> proper
> component, I would propose that it moves out of the Sling Whiteboard
> into
> its own repository at Apache Sling.

Sounds good to me. What is the proposed repository name?

Thanks,
Robert

Re: [VOTE] Release Apache Sling Installer Core 3.12.0, Installer Factory Configuration 1.4.0 and Installer Factory Feature 0.6.0

[Robert Munteanu]

On Fri, 2021-08-06 at 11:14 +0200, Carsten Ziegeler wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[VOTE] Release Apache Sling Installer Core 3.12.0, Installer Factory Configuration 1.4.0 and Installer Factory Feature 0.6.0

[Carsten Ziegeler]

Hi,

We solved 2 issues for Installer Core 3.12.0:
https://issues.apache.org/jira/projects/SLING/versions/12348646

We solved 1 issues for Installer Factory Configuration 1.4.0:
https://issues.apache.org/jira/projects/SLING/versions/12349582

We solved 3 issues for Installer Factory Feature Model 0.6.0:
https://issues.apache.org/jira/projects/SLING/versions/12348804

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2512/

You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2512 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe
cziege...@apache.org

[jira] [Commented] (SLING-10538) Support merging of configurations

[Carsten Ziegeler (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394640#comment-17394640
 ] 

Carsten Ziegeler commented on SLING-10538:
--

Updated the docs

> Support merging of configurations
> -
>
> Key: SLING-10538
> URL: https://issues.apache.org/jira/browse/SLING-10538
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.11.6, Installer Configuration Factory 
> 1.3.6
>
>
> Today, the installer support for configurations applies a configuration as a 
> unit. While this is useful for many use cases, there are use cases where for 
> example an application provides an ootb OSGi configuration and the 
> customization of that configuration should only contain the changed 
> properties but not repeat all properties from the application.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10705) Improve exception handling and error reporting

[Carsten Ziegeler (Jira)]

Carsten Ziegeler created SLING-10705:


 Summary: Improve exception handling and error reporting
 Key: SLING-10705
 URL: https://issues.apache.org/jira/browse/SLING-10705
 Project: Sling
  Issue Type: Improvement
  Components: Content-Package to Feature Model Converter
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Content-Package to Feature Model Converter 1.1.8


The code is currently not distinguishing between user errors and tooling 
errors. For example an IllegalStateException might be thrown if an OSGi 
configuration is in the wrong place inside the content package as well as if 
there is an internal error inside the tool.
While the first category of errors can be fixed by users fixing/adjusting their 
code/content packlages - the second category hints at bugs in the code.
However both are reported exactly the same way.
I suggest we report the first one as errors via logging while the second one 
throws an exception to the "outside".

We can probably achieve this without much effort by using a special exception 
type for the first category.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)