[VOTE] Release Apache Sling ,Scripting HTL Engine version 1.4.12-1.4.0, Scripting HTL Testing Content version 1.0.30-1.4.0
Hi, We solved 3 issues in the "Scripting HTL Engine" release: https://issues.apache.org/jira/browse/SLING/fixforversion/12350437 Changes: https://github.com/apache/sling-org-apache-sling-scripting-sightly/compare/org.apache.sling.scripting.sightly-1.4.8-1.4.0...org.apache.sling.scripting.sightly-1.4.12-1.4.0 We solved 2 issues in the "Scripting HTL Testing Content" release: https://issues.apache.org/jira/browse/SLING/fixforversion/12350469 Changes: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/compare/org.apache.sling.scripting.sightly.testing-content-1.0.28-1.4.0...org.apache.sling.scripting.sightly.testing-content-1.0.30-1.4.0 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2513/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2513 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Resolved] (SLING-10683) add integration content for testing
[
https://issues.apache.org/jira/browse/SLING-10683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman resolved SLING-10683.
-
Resolution: Fixed
Merged PR at:
[{{7f8f5f3}}|https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/commit/7f8f5f3b089f9d021c39f8faf7119e2f7da49404]
> add integration content for testing
> ---
>
> Key: SLING-10683
> URL: https://issues.apache.org/jira/browse/SLING-10683
> Project: Sling
> Issue Type: Sub-task
> Components: Testing
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Scripting HTL Testing Content 1.0.30-1.4.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> For testing 10677, provide the test content needed for integration testing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10684) add integration tests to verify
[
https://issues.apache.org/jira/browse/SLING-10684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman resolved SLING-10684.
-
Resolution: Fixed
Merged PR at:
[{{7f8f5f3}}|https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/commit/7f8f5f3b089f9d021c39f8faf7119e2f7da49404]
> add integration tests to verify
> ---
>
> Key: SLING-10684
> URL: https://issues.apache.org/jira/browse/SLING-10684
> Project: Sling
> Issue Type: Sub-task
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Scripting HTL Testing 1.0.32-1.4.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> For testing 10677, provide the integration tests to verify the fix
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-scripting-sightly-testing-content] enapps-enorman merged pull request #5: SLING-10683 add integration content for testing
enapps-enorman merged pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-10714) Update to Sling Bundle Parent 44
[ https://issues.apache.org/jira/browse/SLING-10714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-10714. - Resolution: Fixed Fixed at: [9e641b8|https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/commit/9e641b8e9cbbdb9a00b3d76f5d40f13c8f3a544b] > Update to Sling Bundle Parent 44 > > > Key: SLING-10714 > URL: https://issues.apache.org/jira/browse/SLING-10714 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Scripting HTL Testing 1.0.32-1.4.0 > > > Update to a latest parent for: > * SHA512 for the source-release artifacts > * reproducible build -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10714) Update to Sling Bundle Parent 44
Eric Norman created SLING-10714: --- Summary: Update to Sling Bundle Parent 44 Key: SLING-10714 URL: https://issues.apache.org/jira/browse/SLING-10714 Project: Sling Issue Type: Improvement Reporter: Eric Norman Assignee: Eric Norman Fix For: Scripting HTL Testing 1.0.32-1.4.0 Update to a latest parent for: * SHA512 for the source-release artifacts * reproducible build -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10713) Update to Sling Bundle Parent 44
[ https://issues.apache.org/jira/browse/SLING-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-10713. - Resolution: Fixed Fixed at: [678718e|https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/commit/678718e9ebdc7be629916eaa0f71fba403c380f1] > Update to Sling Bundle Parent 44 > > > Key: SLING-10713 > URL: https://issues.apache.org/jira/browse/SLING-10713 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Scripting HTL Testing Content 1.0.30-1.4.0 > > > Update to a latest parent for: > * SHA512 for the source-release artifacts > * reproducible build -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-scripting-sightly-testing-content] sonarcloud[bot] removed a comment on pull request #5: SLING-10683 add integration content for testing
sonarcloud[bot] removed a comment on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/pull/5#issuecomment-890122541 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly-testing-content] sonarcloud[bot] commented on pull request #5: SLING-10683 add integration content for testing
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/pull/5#issuecomment-894709997 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing-content=5=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-10713) Update to Sling Bundle Parent 44
Eric Norman created SLING-10713: --- Summary: Update to Sling Bundle Parent 44 Key: SLING-10713 URL: https://issues.apache.org/jira/browse/SLING-10713 Project: Sling Issue Type: Improvement Reporter: Eric Norman Assignee: Eric Norman Fix For: Scripting HTL Testing Content 1.0.30-1.4.0 Update to a latest parent for: * SHA512 for the source-release artifacts * reproducible build -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10698) several io.sightly.tck dateformat tests are sensitive to the timezone of the server
[
https://issues.apache.org/jira/browse/SLING-10698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman resolved SLING-10698.
-
Resolution: Fixed
Merged PR at:
[{{81dd5fb}}|https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/commit/81dd5fbec7fe6ec13519edd6f4628d8a924ef5ba]
> several io.sightly.tck dateformat tests are sensitive to the timezone of the
> server
> ---
>
> Key: SLING-10698
> URL: https://issues.apache.org/jira/browse/SLING-10698
> Project: Sling
> Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Minor
> Fix For: Scripting HTL Testing 1.0.32-1.4.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Need to use GMT timezone so dateformat related tests from io.sightly.tck are
> not off by hours
> If the sling runtime is not using the GMT timezone, these 4 tests may fail:
> {noformat}
> junit.framework.AssertionFailedError: Expected value '01-12-1918' for
> selector '#format-date-1'. Instead we got '30-11-1918'. Please check the
> expected markup from /testfiles/output/exprlang/filters.html.
> at
> io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146)Expression
> Filters: @format - #format-date-3(io.sightly.tck.tests.TestBuilder$1) Time
> elapsed: 0 sec <<< FAILURE!
> junit.framework.AssertionFailedError: Expected value 'December' for selector
> '#format-date-3'. Instead we got 'November'. Please check the expected markup
> from /testfiles/output/exprlang/filters.html.
> at
> io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146)Expression
> Filters: @format - #format-date-4(io.sightly.tck.tests.TestBuilder$1) Time
> elapsed: 0 sec <<< FAILURE!
> junit.framework.AssertionFailedError: Expected value 'Dezember' for selector
> '#format-date-4'. Instead we got 'November'. Please check the expected markup
> from /testfiles/output/exprlang/filters.html.
> at
> io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146)Expression
> Filters: @format - #format-date-5(io.sightly.tck.tests.TestBuilder$1) Time
> elapsed: 0 sec <<< FAILURE!
> junit.framework.AssertionFailedError: Expected value 'Wochentag: Sonntag' for
> selector '#format-date-5'. Instead we got 'Wochentag: Samstag'. Please check
> the expected markup from /testfiles/output/exprlang/filters.html.
> at
> io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10677) add support for using an enum class via the Java Use-API
[
https://issues.apache.org/jira/browse/SLING-10677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman resolved SLING-10677.
-
Resolution: Fixed
Merged PR at:
[{{8e1965c}}|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/8e1965cc1285eb16b79ee018b061200f43aeb596]
> add support for using an enum class via the Java Use-API
>
>
> Key: SLING-10677
> URL: https://issues.apache.org/jira/browse/SLING-10677
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Scripting HTL Engine 1.4.10-1.4.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> For a use case where you need access to an enum value in your ui script for
> some reason, it would be nice to be able to "data-sly-use" your enum class
> with something like this:
>
> {code:java}
>
> {code}
> ... and then later on you can reference the enum values with an expression
> that looks something like this:
> {code:java}
>
> Enum value by name: ${myEnum.SOMEVALUE}
>
>
> Enum value by ordinal: ${myEnum[1]}
>
>
> Constant static field within the enum:
> ${myEnum.SOME_NON_VALUE_CONSTANT_FIELD}
>
>
> Enum value[${value.ordinal}] from static method call: ${value}
>
> {code}
> Since the enum can not have a default constructor, special handling in
> JavaUseProvider would be required to return the enum class itself instead of
> trying to instantiate a new instance of the class.
>
> NOTE: A companion fix will also be required in
> org.apache.sling.scripting.sightly.render.ObjectModel#resolveProperty to deal
> with the target object being an Enum class instead of a POJO object in order
> for the expressions to resolve as expected.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-scripting-sightly-testing] enapps-enorman merged pull request #7: SLING-10698 use GMT timezone for tests
enapps-enorman merged pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] enapps-enorman merged pull request #13: SLING-10677 add support for using an enum class via the Java Use-API
enapps-enorman merged pull request #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-10712) Update to Sling Bundle Parent 44
[ https://issues.apache.org/jira/browse/SLING-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-10712. - Resolution: Fixed Fixed at: [f23eaba|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/f23eabaeb667469fd5c4b1422c1262427e89a2c4] > Update to Sling Bundle Parent 44 > > > Key: SLING-10712 > URL: https://issues.apache.org/jira/browse/SLING-10712 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Scripting HTL Engine 1.4.10-1.4.0 > > > Update to a latest parent for: > * SHA512 for the source-release artifacts > * reproducible build -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10712) Update to Sling Bundle Parent 44
Eric Norman created SLING-10712: --- Summary: Update to Sling Bundle Parent 44 Key: SLING-10712 URL: https://issues.apache.org/jira/browse/SLING-10712 Project: Sling Issue Type: Improvement Reporter: Eric Norman Assignee: Eric Norman Fix For: Scripting HTL Engine 1.4.10-1.4.0 Update to a latest parent for: * SHA512 for the source-release artifacts * reproducible build -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10710) Update to Sling Bundle Parent 44
[ https://issues.apache.org/jira/browse/SLING-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman updated SLING-10710: Description: Update to a latest parent for: * SHA512 for the source-release artifacts * reproducible build was: Update to a latest parent for: - SHA512 for the source-release artifacts - reproducible build > Update to Sling Bundle Parent 44 > > > Key: SLING-10710 > URL: https://issues.apache.org/jira/browse/SLING-10710 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Minor > Fix For: Scripting HTL Compiler 1.2.16-1.4.0 > > > Update to a latest parent for: > * SHA512 for the source-release artifacts > * reproducible build -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10711) Update to Sling Bundle Parent 44
[ https://issues.apache.org/jira/browse/SLING-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman updated SLING-10711: Description: Update to a latest parent for: * SHA512 for the source-release artifacts * reproducible build was: Update to a latest parent for: - SHA512 for the source-release artifacts - reproducible build > Update to Sling Bundle Parent 44 > > > Key: SLING-10711 > URL: https://issues.apache.org/jira/browse/SLING-10711 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Minor > Fix For: Scripting HTL Runtime 1.2.8-1.4.0 > > > Update to a latest parent for: > * SHA512 for the source-release artifacts > * reproducible build -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10711) Update to Sling Bundle Parent 44
[ https://issues.apache.org/jira/browse/SLING-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-10711. - Resolution: Fixed Fixed at: [6252820|https://github.com/apache/sling-org-apache-sling-scripting-sightly-runtime/commit/6252820b4a626945c7e1db38fc455b2b3c77f313] > Update to Sling Bundle Parent 44 > > > Key: SLING-10711 > URL: https://issues.apache.org/jira/browse/SLING-10711 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Minor > Fix For: Scripting HTL Runtime 1.2.8-1.4.0 > > > Update to a latest parent for: > - SHA512 for the source-release artifacts > - reproducible build -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10710) Update to Sling Bundle Parent 44
[ https://issues.apache.org/jira/browse/SLING-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-10710. - Resolution: Fixed Fixed at: [7244040|https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/commit/7244040a67824ffb945219f8273e4505cd03b750] > Update to Sling Bundle Parent 44 > > > Key: SLING-10710 > URL: https://issues.apache.org/jira/browse/SLING-10710 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Minor > Fix For: Scripting HTL Compiler 1.2.16-1.4.0 > > > Update to a latest parent for: > - SHA512 for the source-release artifacts > - reproducible build -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10711) Update to Sling Bundle Parent 44
[ https://issues.apache.org/jira/browse/SLING-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman updated SLING-10711: Fix Version/s: (was: Scripting HTL Compiler 1.2.16-1.4.0) Scripting HTL Runtime 1.2.8-1.4.0 > Update to Sling Bundle Parent 44 > > > Key: SLING-10711 > URL: https://issues.apache.org/jira/browse/SLING-10711 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Minor > Fix For: Scripting HTL Runtime 1.2.8-1.4.0 > > > Update to a latest parent for: > - SHA512 for the source-release artifacts > - reproducible build -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10711) Update to Sling Bundle Parent 44
Eric Norman created SLING-10711: --- Summary: Update to Sling Bundle Parent 44 Key: SLING-10711 URL: https://issues.apache.org/jira/browse/SLING-10711 Project: Sling Issue Type: Improvement Reporter: Eric Norman Assignee: Eric Norman Fix For: Scripting HTL Compiler 1.2.16-1.4.0 Update to a latest parent for: - SHA512 for the source-release artifacts - reproducible build -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10678) enhance ObjectModel#resolveProperty to handle target that is an enum class
[ https://issues.apache.org/jira/browse/SLING-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman closed SLING-10678. --- Closing with the 1.2.6-1.4.0 release > enhance ObjectModel#resolveProperty to handle target that is an enum class > -- > > Key: SLING-10678 > URL: https://issues.apache.org/jira/browse/SLING-10678 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Scripting HTL Runtime 1.2.6-1.4.0 > > > Companion ticket for: SLING-10677 > When an expression target object is an enum class, the > ObjectModel#resolveProperty should handle resolving these scenarios: > # enum value by name > # enum value by ordinal > # access static field within the enum > # access static method within the enum > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10679) ObjectModel.toCollection() should fall back to single item list for every object type
[ https://issues.apache.org/jira/browse/SLING-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman closed SLING-10679. --- Closing with the 1.2.6-1.4.0 release > ObjectModel.toCollection() should fall back to single item list for every > object type > - > > Key: SLING-10679 > URL: https://issues.apache.org/jira/browse/SLING-10679 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting HTL Runtime 1.2.4-1.4.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Scripting HTL Runtime 1.2.6-1.4.0 > > > Currently in > https://github.com/apache/sling-org-apache-sling-scripting-sightly-runtime/blob/org.apache.sling.scripting.sightly.runtime-1.2.4-1.4.0/src/main/java/org/apache/sling/scripting/sightly/render/ObjectModel.java#L277 > only String and Number is converted to a single item list. This fallback > should be extended to support every type. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9968) ObjectModel.toString() should support more classes
[
https://issues.apache.org/jira/browse/SLING-9968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman closed SLING-9968.
--
Closing with the 1.2.6-1.4.0 release
> ObjectModel.toString() should support more classes
> --
>
> Key: SLING-9968
> URL: https://issues.apache.org/jira/browse/SLING-9968
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
>Affects Versions: Scripting HTL Runtime 1.2.4-1.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Scripting HTL Runtime 1.2.6-1.4.0
>
>
> For getter methods returning e.g. a {{java.net.URI}} there is no implicit
> {{toString()}} being applied. When looking at the HTL specs it seems not
> defined how to deal with complex objects
> (https://github.com/adobe/htl-spec/blob/master/SPECIFICATION.md#1152-string),
> but given that enums and primitives are automatically converted
> (https://github.com/apache/sling-org-apache-sling-scripting-sightly-runtime/blob/6cbd676a8875af756e6e43b38c39ba9e4784dc4e/src/main/java/org/apache/sling/scripting/sightly/render/ObjectModel.java#L238)
> already, I am wondering why other types like {{URI}} or {{URL}} are not
> supported.
> Is there any harm when doing object.toString() as fallback?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10651) HTL support java.time.Instant as date object
[ https://issues.apache.org/jira/browse/SLING-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman closed SLING-10651. --- Closing with the 1.2.6-1.4.0 release > HTL support java.time.Instant as date object > > > Key: SLING-10651 > URL: https://issues.apache.org/jira/browse/SLING-10651 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting HTL Runtime 1.2.4-1.4.0 >Reporter: Dirk Rudolph >Assignee: Dirk Rudolph >Priority: Minor > Fix For: Scripting HTL Runtime 1.2.6-1.4.0 > > > It would be good to add support for Java 8's time API to the > RenderObjectModel. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10710) Update to Sling Bundle Parent 44
Eric Norman created SLING-10710: --- Summary: Update to Sling Bundle Parent 44 Key: SLING-10710 URL: https://issues.apache.org/jira/browse/SLING-10710 Project: Sling Issue Type: Improvement Reporter: Eric Norman Assignee: Eric Norman Fix For: Scripting HTL Compiler 1.2.16-1.4.0 Update to a latest parent for: - SHA512 for the source-release artifacts - reproducible build -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10682) Comparison operators don't work to compare enum to another enum
[
https://issues.apache.org/jira/browse/SLING-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman closed SLING-10682.
---
Closing with the 1.2.14-1.4.0 release
> Comparison operators don't work to compare enum to another enum
> ---
>
> Key: SLING-10682
> URL: https://issues.apache.org/jira/browse/SLING-10682
> Project: Sling
> Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Minor
> Fix For: Scripting HTL Compiler 1.2.14-1.4.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> An expression that attempts to compare an enum to another enum throws a
> SightlyCompilerException exception with a message stating that the operands
> are not of same type.
> {noformat}
> Caused by:
> org.apache.sling.scripting.sightly.compiler.SightlyCompilerException:
> Operands are not of the same type: the equality operator can only be applied
> to String, Number and Boolean types.
> at
> org.apache.sling.scripting.sightly.compiler.expression.nodes.BinaryOperator.strictEq(BinaryOperator.java:247)
> [org.apache.sling.scripting.sightly.compiler:1.2.12.140]
> at
> org.apache.sling.scripting.sightly.libs.sling.servlet.__0064__efault.acl_body__002e__html.render(acl_body__002e__html.java:57)
> at
> org.apache.sling.scripting.sightly.render.RenderUnit.render(RenderUnit.java:53)
> [org.apache.sling.scripting.sightly.runtime:1.2.5.140-SNAPSHOT]
> at
> org.apache.sling.scripting.sightly.impl.engine.SightlyCompiledScript.eval(SightlyCompiledScript.java:61)
> [org.apache.sling.scripting.sightly:1.4.9.140-SNAPSHOT]
> at
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:386)
> [org.apache.sling.scripting.core:2.3.6]
> at
> org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:184)
> [org.apache.sling.scripting.core:2.3.6]
> at
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:491)
> [org.apache.sling.scripting.core:2.3.6]
> ... 92 common frames omitted
> {noformat}
> Expected:
> Comparing two enum objects should work without throwing any exception.
> For example:
> {code:html}
> enum equals enum = ${myEnum.ONE == myEnum.ONE}
> enum notEquals enum = ${myEnum.ONE != myEnum.TWO}
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[RESULT] [VOTE] Release Apache Sling Scripting HTL Compiler version 1.2.14-1.4.0, Scripting HTL Runtime version 1.2.6-1.4.0
Hi, The vote has passed with the following result : +1 (binding): Radu Cotescu, Stefan Seifert,Konrad Windszus, Daniel Klco, Eric Norman +1 (non binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository.
Re: [VOTE] Release Apache Sling Scripting HTL Compiler version 1.2.14-1.4.0, Scripting HTL Runtime version 1.2.6-1.4.0
+1 On Tue, Aug 3, 2021 at 12:22 PM Eric Norman wrote: > Hi, > > We solved 1 issues in the Scripting HTL Compiler 1.2.14-1.4.0 release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12350467 > > Changes: > > https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/compare/org.apache.sling.scripting.sightly.compiler-1.2.12-1.4.0...org.apache.sling.scripting.sightly.compiler-1.2.14-1.4.0 > > We solved 4 issues in the Scripting HTL Runtime 1.2.6-1.4.0 release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12350438 > > Changes: > > https://github.com/apache/sling-org-apache-sling-scripting-sightly-runtime/compare/org.apache.sling.scripting.sightly.runtime-1.2.4-1.4.0...org.apache.sling.scripting.sightly.runtime-1.2.6-1.4.0 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2510/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2510 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. >
[jira] [Comment Edited] (SLING-10706) Order of selectors not kept
[
https://issues.apache.org/jira/browse/SLING-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395256#comment-17395256
]
Konrad Windszus edited comment on SLING-10706 at 8/7/21, 3:57 PM:
--
I think we have a broader issue to solve here than just same name selectors:
resourceTypes don't necessarily need a script which is registered to the
resourceLabel, default extension (html) or default method (GET) as defined in
https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/76bf25f23fd3ce3d5381db7423a6c01909dcd075/src/main/java/org/apache/sling/scriptingbundle/plugin/processor/ResourceTypeFolderPredicate.java#L70.
In general every script in arbitrary folders may define its own resource types
(potentially only for a specific selector) as well as selectors for parent
folders till root, e.g. {{/apps/foo/bar/test.html}} (without declaring any
sling:resourceSuperType) defines
1. a script for resource type {{/apps/foo/bar}} and selector {{test}}
2. a script for resource type {{/apps/foo}} and selectors {{bar.test}} and even
3. a script for resource type {{/apps}} and selectors {{foo.bar.test}}
I am not sure whether the amount of resource types we would need to register
leads to issues with the capability registry in OSGi, but that is the current
logic for resource scripts.
was (Author: kwin):
I think we have a broader issue to solve here than just same name selectors:
resourceTypes don't necessarily need a script which is registered to the
resourceLabel, default extension (html) or default method (GET) as defined in
https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/76bf25f23fd3ce3d5381db7423a6c01909dcd075/src/main/java/org/apache/sling/scriptingbundle/plugin/processor/ResourceTypeFolderPredicate.java#L70.
In general every script in arbitrary folders may define its own resource types
(potentially only for a specific selector) as well as selectors for parent
folders till root, e.g. {{/apps/foo/bar/test.html}} defines
1. a script for resource type {{/apps/foo/bar}} and selector {{test}}
2. a script for resource type {{/apps/foo}} and selectors {{bar.test}} and even
3. a script for resource type {{/apps}} and selectors {{foo.bar.test}}
I am not sure whether the amount of resource types we would need to register
leads to issues with the capability registry in OSGi, but that is the current
logic for resource scripts.
> Order of selectors not kept
> ---
>
> Key: SLING-10706
> URL: https://issues.apache.org/jira/browse/SLING-10706
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The selectors used for registration of script/servlets have an order: Only if
> they appear in the given order the script/servlet matches
> (https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
> The order is potentially lost, though during the generation of the
> capabilities headers as the code is using Sets internally.
> Also it is totally valid to register a script to "myselector.myselector"
> which cannot be expressed with Sets either.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SLING-10706) Order of selectors not kept
[
https://issues.apache.org/jira/browse/SLING-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395256#comment-17395256
]
Konrad Windszus edited comment on SLING-10706 at 8/7/21, 3:56 PM:
--
I think we have a broader issue to solve here than just same name selectors:
resourceTypes don't necessarily need a script which is registered to the
resourceLabel, default extension (html) or default method (GET) as defined in
https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/76bf25f23fd3ce3d5381db7423a6c01909dcd075/src/main/java/org/apache/sling/scriptingbundle/plugin/processor/ResourceTypeFolderPredicate.java#L70.
In general every script in arbitrary folders may define its own resource types
(potentially only for a specific selector) as well as selectors for parent
folders till root, e.g. {{/apps/foo/bar/test.html}} defines
1. a script for resource type {{/apps/foo/bar}} and selector {{test}}
2. a script for resource type {{/apps/foo}} and selectors {{bar.test}} and even
3. a script for resource type {{/apps}} and selectors {{foo.bar.test}}
I am not sure whether the amount of resource types we would need to register
leads to issues with the capability registry in OSGi, but that is the current
logic for resource scripts.
was (Author: kwin):
I think we have a broader issue to solve here than just same name selectors:
resourceTypes don't necessarily need a script which is registered to the
resourceLabel, default extension (html) or default method (GET) as defined in
https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/76bf25f23fd3ce3d5381db7423a6c01909dcd075/src/main/java/org/apache/sling/scriptingbundle/plugin/processor/ResourceTypeFolderPredicate.java#L70.
In general every script in arbitrary folders may define its own resource types
(potentially only for a specific selector) as well as selectors for parent
folders till root, e.g. {{/apps/foo/bar/test.html}} defines
1. a script for resource type {{/apps/foo/bar}} and selector {{test}}
2. a script for resource type {{/apps/foo}} and selectors {{bar.test}} and even
3. a script for resource type {{/apps}} and selectors {{foo.bar.test}}
I am not sure whether the amount of resource types we would need to register
lead to issues with the capability registry in OSGi, but that is the current
logic for resource scripts.
> Order of selectors not kept
> ---
>
> Key: SLING-10706
> URL: https://issues.apache.org/jira/browse/SLING-10706
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The selectors used for registration of script/servlets have an order: Only if
> they appear in the given order the script/servlet matches
> (https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
> The order is potentially lost, though during the generation of the
> capabilities headers as the code is using Sets internally.
> Also it is totally valid to register a script to "myselector.myselector"
> which cannot be expressed with Sets either.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10706) Order of selectors not kept
[
https://issues.apache.org/jira/browse/SLING-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395256#comment-17395256
]
Konrad Windszus commented on SLING-10706:
-
I think we have a broader issue to solve here than just same name selectors:
resourceTypes don't necessarily need a script which is registered to the
resourceLabel, default extension (html) or default method (GET) as defined in
https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/76bf25f23fd3ce3d5381db7423a6c01909dcd075/src/main/java/org/apache/sling/scriptingbundle/plugin/processor/ResourceTypeFolderPredicate.java#L70.
In general every script in arbitrary folders may define its own resource types
(potentially only for a specific selector) as well as selectors for parent
folders till root, e.g. {{/apps/foo/bar/test.html}} defines
1. a script for resource type {{/apps/foo/bar}} and selector {{test}}
2. a script for resource type {{/apps/foo}} and selectors {{bar.test}} and even
3. a script for resource type {{/apps}} and selectors {{foo.bar.test}}
I am not sure whether the amount of resource types we would need to register
lead to issues with the capability registry in OSGi, but that is the current
logic for resource scripts.
> Order of selectors not kept
> ---
>
> Key: SLING-10706
> URL: https://issues.apache.org/jira/browse/SLING-10706
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The selectors used for registration of script/servlets have an order: Only if
> they appear in the given order the script/servlet matches
> (https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
> The order is potentially lost, though during the generation of the
> capabilities headers as the code is using Sets internally.
> Also it is totally valid to register a script to "myselector.myselector"
> which cannot be expressed with Sets either.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: [Proposal] Lift OSGi Feature Service impl from Sling Whiteboard into own repo
Hi Robert, On Fri, 6 Aug 2021 at 12:16, Robert Munteanu wrote: > Hi David, > > On Fri, 2021-08-06 at 07:31 +0100, dav...@apache.org wrote: > > To prepare this implementation so that it can be released and be a > > proper > > component, I would propose that it moves out of the Sling Whiteboard > > into > > its own repository at Apache Sling. > > Sounds good to me. What is the proposed repository name? > How about org.apache.sling.osgifeature Or alternatively org.apache.sling.feature.osgi ? Best regards, David
[jira] [Commented] (SLING-10709) Migrate SubscriberIdleCheck from Systemready to HC
[ https://issues.apache.org/jira/browse/SLING-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395229#comment-17395229 ] Carsten Ziegeler commented on SLING-10709: -- Created PR at https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/88 Previous status GREEN is mapped to OK Previous status RED is mapped to CRITICIAL (not sure if this is the right thing) > Migrate SubscriberIdleCheck from Systemready to HC > --- > > Key: SLING-10709 > URL: https://issues.apache.org/jira/browse/SLING-10709 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Affects Versions: Content Distribution Journal Core 0.1.18 >Reporter: Carsten Ziegeler >Priority: Major > Fix For: Content Distribution Journal Core 0.1.20 > > > Apache Felix systemready is deprecated in favour of Apache Felix HealthCheck. > This component should be migrated -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10709) Migrate SubscriberIdleCheck from Systemready to HC
Carsten Ziegeler created SLING-10709: Summary: Migrate SubscriberIdleCheck from Systemready to HC Key: SLING-10709 URL: https://issues.apache.org/jira/browse/SLING-10709 Project: Sling Issue Type: Improvement Components: Content Distribution Affects Versions: Content Distribution Journal Core 0.1.18 Reporter: Carsten Ziegeler Fix For: Content Distribution Journal Core 0.1.20 Apache Felix systemready is deprecated in favour of Apache Felix HealthCheck. This component should be migrated -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10706) Order of selectors not kept
[ https://issues.apache.org/jira/browse/SLING-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395198#comment-17395198 ] Radu Cotescu commented on SLING-10706: -- bq. Does that mean, that this plugin will never register more than 1 selector for a single script? That would be an even bigger flaw then... I didn't say that. I said that nested identical selectors via folder + script file with the same name won't generate the capability you expect. In addition to that, the scripts of a nested resource type won't generate selectors for a resource type folder containing it. For this second observation see [0]. [0] - https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/76bf25f23fd3ce3d5381db7423a6c01909dcd075/src/main/java/org/apache/sling/scriptingbundle/plugin/processor/ResourceTypeFolderAnalyser.java#L72 > Order of selectors not kept > --- > > Key: SLING-10706 > URL: https://issues.apache.org/jira/browse/SLING-10706 > Project: Sling > Issue Type: Bug > Components: Maven Plugins and Archetypes >Affects Versions: Scripting Bundle Maven Plugin 0.3.0 >Reporter: Konrad Windszus >Priority: Major > Fix For: Scripting Bundle Maven Plugin 0.4.0 > > > The selectors used for registration of script/servlets have an order: Only if > they appear in the given order the script/servlet matches > (https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration). > The order is potentially lost, though during the generation of the > capabilities headers as the code is using Sets internally. > Also it is totally valid to register a script to "myselector.myselector" > which cannot be expressed with Sets either. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10708) Record analyser task id for every report message
[ https://issues.apache.org/jira/browse/SLING-10708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-10708. -- Resolution: Fixed Added the task id in https://github.com/apache/sling-org-apache-sling-feature-analyser/commit/9e1dfec318884ca520248a51c0e9c3fb756ace85 This will also be logged by default now > Record analyser task id for every report message > > > Key: SLING-10708 > URL: https://issues.apache.org/jira/browse/SLING-10708 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 1.3.32 > > > For better logging, the id of the analyser task should be recorded with every > report (error / warning) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10708) Record analyser task id for every report message
Carsten Ziegeler created SLING-10708: Summary: Record analyser task id for every report message Key: SLING-10708 URL: https://issues.apache.org/jira/browse/SLING-10708 Project: Sling Issue Type: Improvement Components: Feature Model Analyser Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Feature Model Analyser 1.3.32 For better logging, the id of the analyser task should be recorded with every report (error / warning) -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [DISCUSS] Sling RepoInit Webconsole
Am 06.08.2021 um 14:40 schrieb Bertrand Delacretaz: I was going to say that you should use the incoming request's identity instead of calling loginAdministrative [2] but I forgot if that's possible in a web console plugin. The current code causes a privilege escalation, which might be ok for a console plugin but that IMHO we should avoid if possible. Privilege escalation should really be avoided. Just for the record, a webconsole plugin can use the current user / resource resolver - if Sling's webconsole security provider is enabled. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: Release Management: Always update to latest parent prior release?
As others said, depending on how old the current parent pom is, the update is non trivial and requires a lot of careful reworking. It can happen to easy that the module builds and tests pass, but the result is missing OSGi metadata. So recommendation: absolutely yes, requiring: no. And the good thing is everyone can help with these parent pom updates. You don't need deep knowledge about the details of the module. Make it build and pass the tests and compare the resulting jar with the previous one and check contents and metadata. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
