[jira] [Comment Edited] (SLING-10602) DistributionQueueItem's path should be correctly logged in case of success and failure
[
https://issues.apache.org/jira/browse/SLING-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17414738#comment-17414738
]
Mohit Arora edited comment on SLING-10602 at 9/14/21, 5:53 AM:
---
PR - https://github.com/apache/sling-org-apache-sling-distribution-core/pull/55
[~marett], [~cschneider], [~ashishc] can you please review?
This improved logging would help us diagnose the failing distribution in case
of brandportal.
was (Author: mohiaror):
PR - https://github.com/apache/sling-org-apache-sling-distribution-core/pull/55
[~marett], [~cschneider], [~ashishc] can you please review?
> DistributionQueueItem's path should be correctly logged in case of success
> and failure
> --
>
> Key: SLING-10602
> URL: https://issues.apache.org/jira/browse/SLING-10602
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.4.6
>Reporter: Mohit Arora
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The [process method of
> SimpleDistributionAgentQueueProcessor|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L83-L103]
> logs debug and error logs to indicate the processing and failure of
> individual queue items. It basically just prints the queueItem, the [toString
> method of
> whose|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/DistributionQueueItem.java#L67]
> prints the info map of the item as String. But the valuemap also contains
> some multivalue properties like paths and deepPaths, resulting in logged
> string to look like below -
> {noformat}[sling-default-4-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgent
> [agent][bpdistributionagent0] [queue-bpdistributionagent*0] ITEM-FAIL
> item=DistributionQueueItem{id='dstrpck-1610659801578-afcff2aa-79b4-437c-a248-8021b743ebb9',*
> info=org.apache.sling.distribution.queue.DistributionQueueItem@891d3504 :
> {item.id=dstrpck-1610659801578-afcff2aa-79b4-437c-a248-8021b743ebb9,
> internal.request.startTime=1610659801558, package.size=705, request.type=ADD,
> request.deepPaths=[Ljava.lang.String;@116219, internal.request.id=DSTRQ10,
> request.paths=[Ljava.lang.String;@7eef9f32,
> internal.request.user=dam-replication-service,
> package.type=signed-url}}{noformat}
> For debug purposes it would be helpful if we can map a queueItem to an actual
> resource through the path.
> cc - [~ashishc]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10602) DistributionQueueItem's path should be correctly logged in case of success and failure
[
https://issues.apache.org/jira/browse/SLING-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17414738#comment-17414738
]
Mohit Arora commented on SLING-10602:
-
PR - https://github.com/apache/sling-org-apache-sling-distribution-core/pull/55
[~marett], [~cschneider], [~ashishc] can you please review?
> DistributionQueueItem's path should be correctly logged in case of success
> and failure
> --
>
> Key: SLING-10602
> URL: https://issues.apache.org/jira/browse/SLING-10602
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.4.6
>Reporter: Mohit Arora
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The [process method of
> SimpleDistributionAgentQueueProcessor|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L83-L103]
> logs debug and error logs to indicate the processing and failure of
> individual queue items. It basically just prints the queueItem, the [toString
> method of
> whose|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/DistributionQueueItem.java#L67]
> prints the info map of the item as String. But the valuemap also contains
> some multivalue properties like paths and deepPaths, resulting in logged
> string to look like below -
> {noformat}[sling-default-4-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgent
> [agent][bpdistributionagent0] [queue-bpdistributionagent*0] ITEM-FAIL
> item=DistributionQueueItem{id='dstrpck-1610659801578-afcff2aa-79b4-437c-a248-8021b743ebb9',*
> info=org.apache.sling.distribution.queue.DistributionQueueItem@891d3504 :
> {item.id=dstrpck-1610659801578-afcff2aa-79b4-437c-a248-8021b743ebb9,
> internal.request.startTime=1610659801558, package.size=705, request.type=ADD,
> request.deepPaths=[Ljava.lang.String;@116219, internal.request.id=DSTRQ10,
> request.paths=[Ljava.lang.String;@7eef9f32,
> internal.request.user=dam-replication-service,
> package.type=signed-url}}{noformat}
> For debug purposes it would be helpful if we can map a queueItem to an actual
> resource through the path.
> cc - [~ashishc]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
RE: [VOTE] Release Apache Sling Testing Sling Mock 3.1.2
+1
RE: [VOTE] Release Apache Sling Feature Model Analyser 1.4.0 and slingfeature maven plugin 1.5.16
+1
[VOTE] Release Apache Sling Testing Sling Mock 3.1.2
Hi, We solved 1 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12350549 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2527/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2527 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan
Re: [VOTE] Release Apache Sling Feature Model Analyser 1.4.0 and slingfeature maven plugin 1.5.16
+1 Carsten Am 13.09.2021 um 14:12 schrieb Carsten Ziegeler: Hi, we solved five issues for the feature model analyser 1.4.0: https://issues.apache.org/jira/projects/SLING/versions/12350580 we solved one issue for slingfeature-maven-plugin 1.5.16: https://issues.apache.org/jira/projects/SLING/versions/12350533 Staging repositories https://repository.apache.org/content/repositories/orgapachesling-2525/ https://repository.apache.org/content/repositories/orgapachesling-2526/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2525 /tmp/sling-staging sh check_staged_release.sh 2526 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[GitHub] [sling-org-apache-sling-discovery-commons] mreutegg commented on pull request #4: SLING-10489 : ignore partially started instances :
mreutegg commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-discovery-commons/pull/4#issuecomment-918320275 Unit test for LocalClusterView as PR: https://github.com/stefan-egli/sling-org-apache-sling-discovery-commons/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-commons] mreutegg commented on a change in pull request #4: SLING-10489 : ignore partially started instances :
mreutegg commented on a change in pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-commons/pull/4#discussion_r707353308
##
File path:
src/main/java/org/apache/sling/discovery/commons/providers/util/LogSilencer.java
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.discovery.commons.providers.util;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+
+import org.slf4j.Logger;
+
+/**
+ * Helper class to help reduce log.info output. It will avoid repetitive
+ * log.info calls and instead log future occurrences to log.debug
+ */
+public class LogSilencer {
+
+private static final long DEFAULT_AUTO_RESET_DELAY_MINUTES = 10;
+
+private final Logger logger;
+
+private final Object syncObj = new Object();
+
+private final long autoResetDelayMillis;
+
+private Map lastMsgPerCategory;
+
+private long autoResetTime = 0;
+
+public LogSilencer(Logger logger, long autoResetDelaySeconds) {
+this.logger = logger;
+if (autoResetDelaySeconds > 0) {
+autoResetDelayMillis =
TimeUnit.MINUTES.toMillis(autoResetDelaySeconds);
Review comment:
The second parameter should be renamed to `autoResetDelayMinutes`
```suggestion
public LogSilencer(Logger logger, long autoResetDelayMinutes) {
this.logger = logger;
if (autoResetDelayMinutes > 0) {
autoResetDelayMillis =
TimeUnit.MINUTES.toMillis(autoResetDelayMinutes);
```
##
File path:
src/main/java/org/apache/sling/discovery/commons/providers/base/ViewStateManagerImpl.java
##
@@ -590,6 +595,46 @@ public void run() {
}
}
+protected boolean equalsIgnoreSyncToken(BaseTopologyView newView) {
+if (previousView==null) {
Review comment:
General question on concurrency. Public methods use `lock` to
synchronize access to internals. Why is this not necessary here?
##
File path:
src/main/java/org/apache/sling/discovery/commons/providers/base/ViewStateManagerImpl.java
##
@@ -590,6 +595,46 @@ public void run() {
}
}
+protected boolean equalsIgnoreSyncToken(BaseTopologyView newView) {
+if (previousView==null) {
+return false;
+}
+if (newView==null) {
+throw new IllegalArgumentException("newView must not be null");
+}
+final ClusterView cluster =
newView.getLocalInstance().getClusterView();
+if (cluster instanceof LocalClusterView) {
+final LocalClusterView local = (LocalClusterView)cluster;
+if (!local.hasPartiallyStartedInstances()) {
+// then we should not ignore the syncToken I'm afraid
+return previousView.equals(newView);
+}
+}
+final Set previousInstances =
previousView.getInstances();
+final Set newInstances = newView.getInstances();
+if (previousInstances.size() != newInstances.size()) {
+return false;
+}
+for (Iterator it = previousInstances.iterator();
it.hasNext();) {
+InstanceDescription instanceDescription = (InstanceDescription) it
+.next();
+boolean found = false;
+for (Iterator it2 = newInstances.iterator(); it2
+.hasNext();) {
+InstanceDescription otherId = (InstanceDescription) it2
+.next();
+if (instanceDescription.equals(otherId)) {
+found = true;
+break;
+}
+}
+if (!found) {
+return false;
+}
+}
+return true;
Review comment:
Can this be replaced with `previousInstances.equals(newInstances)`?
##
File path:
src/main/java/org/apache/sling/discovery/commons/providers/spi/LocalClusterView.java
##
@@ -33,4 +38,21 @@ public String getLocalClusterSyncTokenId() {
return localClusterSyncTokenId;
}
+public void setPartiallyStartedClusterNodeIds(Collection
clusterNodeIds) {
Review comment:
[jira] [Updated] (SLING-10809) command executor should write down what pipe command has just been executed
[ https://issues.apache.org/jira/browse/SLING-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10809: Fix Version/s: Pipes 4.2.0 > command executor should write down what pipe command has just been executed > > > Key: SLING-10809 > URL: https://issues.apache.org/jira/browse/SLING-10809 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.2.0 > > > in the persistence of the status of the pipe, we should have the command > executed, as a summary to find it back again, may be also the result (or the > first thousand chars) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10809) command executor should write down what pipe command has just been executed
Nicolas Peltier created SLING-10809: --- Summary: command executor should write down what pipe command has just been executed Key: SLING-10809 URL: https://issues.apache.org/jira/browse/SLING-10809 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Pipes 4.1.2 Reporter: Nicolas Peltier in the persistence of the status of the pipe, we should have the command executed, as a summary to find it back again, may be also the result (or the first thousand chars) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-distribution-core] actinium15 commented on a change in pull request #55: SLING-10602 DistributionQueueItem's path should be correctly logged in case of success and fai
actinium15 commented on a change in pull request #55:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/55#discussion_r707371685
##
File path:
src/main/java/org/apache/sling/distribution/queue/DistributionQueueItem.java
##
@@ -64,7 +67,25 @@ public long getSize() {
public String toString() {
return "DistributionQueueItem{" +
"id='" + packageId + '\'' +
-", info=" + super.toString() +
+", info={" + queueInfo(base) + '}' +
'}';
}
+
+/*
+ * convert the map of object values into string form
+ */
+private String queueInfo(Map base) {
+String queueItem = "";
+for(String key : base.keySet()) {
+Object value = base.get(key);
+String valueString = "";
+if (value instanceof String[]) {
+valueString = key + "=" + Arrays.toString((String[])value);
Review comment:
```suggestion
if (value.getClass().isArray()) {
valueString = key + "=" + Arrays.toString((Object[])value);
```
##
File path:
src/main/java/org/apache/sling/distribution/queue/DistributionQueueItem.java
##
@@ -44,7 +47,7 @@ public DistributionQueueItem(String packageId, long size,
Map ba
super(base);
this.packageId = packageId;
this.size = size;
-
+this.base = base;
Review comment:
I think we shouldn't keep this field because
1. it is unnecessary
2. it is possible to invoke `.put` directly on `this` because it extends
`ValueMapDecorator`, which can make `base` out of sync with what's there in
`DistributionQueueItem` object
##
File path:
src/main/java/org/apache/sling/distribution/queue/DistributionQueueItem.java
##
@@ -64,7 +67,25 @@ public long getSize() {
public String toString() {
return "DistributionQueueItem{" +
"id='" + packageId + '\'' +
-", info=" + super.toString() +
+", info={" + queueInfo(base) + '}' +
'}';
}
+
+/*
+ * convert the map of object values into string form
+ */
+private String queueInfo(Map base) {
+String queueItem = "";
Review comment:
```suggestion
String queueItemStr = "";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-core] mohiaror commented on pull request #55: SLING-10602 DistributionQueueItem's path should be correctly logged in case of success and failure
mohiaror commented on pull request #55: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/55#issuecomment-918223007 The sprouts is failing to build the project and failing with following exception. It seems the machine where sprouts is running has java 11 and the bundle does not build with that. ``` [INFO] [INFO] [INFO] Skipping Apache Sling Distribution Core [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 5.609 s [INFO] Finished at: 2021-09-13T10:49:17Z [INFO] [WARNING] The requested profile "ci" could not be activated because it does not exist. [INFO] [jenkins-event-spy] Generated /home/jenkins/workspace/he-sling-distribution-core_PR-55@tmp/withMaven442fa326/maven-spy-20210913-104911-2979981949278491312987.log [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (set-bundle-required-execution-environment) on project org.apache.sling.distribution.core: An Ant BuildException has occured: Unable to create javax script engine for javascript [ERROR] around Ant part ...
Re: [VOTE] Release Apache Sling Feature Model Analyser 1.4.0 and slingfeature maven plugin 1.5.16
+1 David On Mon, 13 Sept 2021 at 14:00, Karl Pauls wrote: > +1 > > regards, > > Karl > > On Mon, Sep 13, 2021 at 2:12 PM Carsten Ziegeler > wrote: > > > > Hi, > > > > we solved five issues for the feature model analyser 1.4.0: > > https://issues.apache.org/jira/projects/SLING/versions/12350580 > > > > > > we solved one issue for slingfeature-maven-plugin 1.5.16: > > https://issues.apache.org/jira/projects/SLING/versions/12350533 > > > > Staging repositories > > https://repository.apache.org/content/repositories/orgapachesling-2525/ > > https://repository.apache.org/content/repositories/orgapachesling-2526/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2525 /tmp/sling-staging > > sh check_staged_release.sh 2526 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > > -- > Karl Pauls > karlpa...@gmail.com >
Re: [VOTE] Release Apache Sling Feature Model Analyser 1.4.0 and slingfeature maven plugin 1.5.16
+1 regards, Karl On Mon, Sep 13, 2021 at 2:12 PM Carsten Ziegeler wrote: > > Hi, > > we solved five issues for the feature model analyser 1.4.0: > https://issues.apache.org/jira/projects/SLING/versions/12350580 > > > we solved one issue for slingfeature-maven-plugin 1.5.16: > https://issues.apache.org/jira/projects/SLING/versions/12350533 > > Staging repositories > https://repository.apache.org/content/repositories/orgapachesling-2525/ > https://repository.apache.org/content/repositories/orgapachesling-2526/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2525 /tmp/sling-staging > sh check_staged_release.sh 2526 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org -- Karl Pauls karlpa...@gmail.com
[VOTE] Release Apache Sling Feature Model Analyser 1.4.0 and slingfeature maven plugin 1.5.16
Hi, we solved five issues for the feature model analyser 1.4.0: https://issues.apache.org/jira/projects/SLING/versions/12350580 we solved one issue for slingfeature-maven-plugin 1.5.16: https://issues.apache.org/jira/projects/SLING/versions/12350533 Staging repositories https://repository.apache.org/content/repositories/orgapachesling-2525/ https://repository.apache.org/content/repositories/orgapachesling-2526/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2525 /tmp/sling-staging sh check_staged_release.sh 2526 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #662 is BROKEN
t;/home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMaven62edcafc/pipeline-maven-spy.jar" -Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMaven62edcafc" Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) Maven home: /home/jenkins/tools/maven/latest3 Java version: 1.8.0_291, vendor: Oracle Corporation, runtime: /usr/local/asfpackages/java/oraclejdk-1.8.0-291/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: "linux", version: "4.15.0-140-generic", arch: "amd64", family: "unix" [INFO] [jenkins-event-spy] Generate /home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMaven62edcafc/maven-spy-20210913-111730-210963555979380554830.log.tmp ... [INFO] Scanning for projects... [INFO] [INFO] < org.apache.sling:org.apache.sling.launchpad.testing >- [INFO] Building Apache Sling Launchpad Testing 12-SNAPSHOT [INFO] [ jar ]- [INFO] Downloading from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/maven-metadata.xml [INFO] Downloaded from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/maven-metadata.xml (1.0 kB at 1.4 kB/s) [INFO] Downloading from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/org.apache.sling.launchpad.integration-tests-12-20210908.061343-289.pom [INFO] Downloaded from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/org.apache.sling.launchpad.integration-tests-12-20210908.061343-289.pom (14 kB at 35 kB/s) [INFO] Downloading from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-services/12-SNAPSHOT/maven-metadata.xml [INFO] Downloaded from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-services/12-SNAPSHOT/maven-metadata.xml (1.0 kB at 482 B/s) [INFO] Downloading from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-services/12-SNAPSHOT/org.apache.sling.launchpad.test-services-12-20210911.192433-161.pom [INFO] Downloaded from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-services/12-SNAPSHOT/org.apache.sling.launchpad.test-services-12-20210911.192433-161.pom (9.8 kB at 28 kB/s) [INFO] Downloading from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-fragment/12-SNAPSHOT/maven-metadata.xml [INFO] Downloaded from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-fragment/12-SNAPSHOT/maven-metadata.xml (1.0 kB at 1.9 kB/s) [INFO] Downloading from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-fragment/12-SNAPSHOT/org.apache.sling.launchpad.test-fragment-12-20210910.031828-153.pom [INFO] Downloaded from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-fragment/12-SNAPSHOT/org.apache.sling.launchpad.test-fragment-12-20210910.031828-153.pom (2.9 kB at 6.8 kB/s) [INFO] Downloading from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/org.apache.sling.launchpad.integration-tests-12-20210908.061343-289.jar [INFO] Downloading from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-services/12-SNAPSHOT/org.apache.sling.launchpad.test-services-12-20210911.192433-161.jar [INFO] Downloading from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-fragment/12-SNAPSHOT/org.apache.sling.launchpad.test-fragment-12-20210910.031828-153.jar [INFO] Downloaded from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-fragment/12-SNAPSHOT/org.apache.sling.launchpad.test-fragment-12-20210910.031828-153.jar (9.2 kB at 17 kB/s) [INFO] Downloaded from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-services/12-SNAPSHOT/org.apache.sling.launchpad.test-services-12-20210911.192433-161.jar (182 kB at 189 kB/s) [INFO] Downloaded from Nexus: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/org.apache.sling.launchpad.integration-tests-12-20210908.061343-289.jar (486 kB at 425 kB/s) [INFO] [INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @ org.apache.sling.launchpad.testing --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-property-values) @ org.apache.sling.launchpad.testing --- [INFO] [INFO
[jira] [Created] (SLING-10808) Generate scripting capabilities from Jackrabbit FileVault content packages
Radu Cotescu created SLING-10808: Summary: Generate scripting capabilities from Jackrabbit FileVault content packages Key: SLING-10808 URL: https://issues.apache.org/jira/browse/SLING-10808 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Radu Cotescu Assignee: Radu Cotescu Fix For: Scripting Bundle Maven Plugin 0.5.0 The Scripting Bundle Maven Plugin should be extended to allow extracting scripting capabilities from Jackrabbit FileVault content packages. This would allow extracting the server-side scripts into an additional bundle that could be attached to the content package build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-distribution-core] mohiaror opened a new pull request #55: SLING-10602 DistributionQueueItem's path should be correctly logged in case of success and failure
mohiaror opened a new pull request #55: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/55 Adding the path(s) for which distribution package was created in the logging for distribution queue item. Also changing the debug level log to info level to give admin more info about which resources were distributed and how much time it took for distribution to complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SLING-10785) AclManager.addAcl adds an entry not an access control list
[
https://issues.apache.org/jira/browse/SLING-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10785.
--
> AclManager.addAcl adds an entry not an access control list
> --
>
> Key: SLING-10785
> URL: https://issues.apache.org/jira/browse/SLING-10785
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> the method {{AclManager.addAcl(@NotNull String systemUser, @NotNull
> AccessControlEntry acl)}} is somewhat confusing because it adds an access
> control entry and not a list.
> what was probably meant originally was 'adding some sort of access control
> related information'. anyway i would suggest to rename the method to
> "addAccessControlEntry" or "addAccessControl" or "addEntry".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10789) JsonConfigurationEntryHandler - sonar finding
[ https://issues.apache.org/jira/browse/SLING-10789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10789. -- > JsonConfigurationEntryHandler - sonar finding > - > > Key: SLING-10789 > URL: https://issues.apache.org/jira/browse/SLING-10789 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Minor > Fix For: Content-Package to Feature Model Converter 1.1.10 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10481) Review filter.xml creation for content package output of converter
[ https://issues.apache.org/jira/browse/SLING-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10481. -- > Review filter.xml creation for content package output of converter > -- > > Key: SLING-10481 > URL: https://issues.apache.org/jira/browse/SLING-10481 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.4 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.10 > > > The converter used to recalculate the filters for content-packages. Starting > with SLING-10243 that was made optional (maybe to not do it for sling initial > content packages) - however, it looks like it is now not done at all anymore. > We have to see if that is what we want and if the filters are still correct > for the converted packages (especially in the context of the principal and > acl work). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10755) DefaultAclManager.CONTENT_XML_FILE_NAME should be replace by filevault constant
[
https://issues.apache.org/jira/browse/SLING-10755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10755.
--
> DefaultAclManager.CONTENT_XML_FILE_NAME should be replace by filevault
> constant
> ---
>
> Key: SLING-10755
> URL: https://issues.apache.org/jira/browse/SLING-10755
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.8
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Trivial
> Labels: technical_debt
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> in order to limit hardcoding strings the private constant
> _CONTENT_XML_FILE_NAME_ in {{DefaultAclManager}} should be replace by
> {{org.apache.jackrabbit.vault.util.DOT_CONTENT_XML}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10778) *PolicyEntryHandler, *PolicyParser - sonar findings
[ https://issues.apache.org/jira/browse/SLING-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10778. -- > *PolicyEntryHandler, *PolicyParser - sonar findings > --- > > Key: SLING-10778 > URL: https://issues.apache.org/jira/browse/SLING-10778 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Minor > Fix For: Content-Package to Feature Model Converter 1.1.10 > > > there are a few sonar findings in > - AbstractPolicyEntryHandler > - AbstractPolicyParser > - RepPolicyEntryHandler > - RepPrincipalPolicyEntryHandler > in addition, i would suggest to improve a few of names that refer to the list > when actually entries (or an entry) is meant. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10754) Missing entries in filter.xml
[
https://issues.apache.org/jira/browse/SLING-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10754.
--
> Missing entries in filter.xml
> -
>
> Key: SLING-10754
> URL: https://issues.apache.org/jira/browse/SLING-10754
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.8
>Reporter: Karl Pauls
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> The calculation for the filter.xml of converted content packages can miss
> filters if the target is defined inside a content.xml. As an example, a
> content package with an entry like:
> {noformat}
> jcr_root/_oak_index/.content.xml
>
> ...
>
> .
> {noformat}
> and a filter.xml containing:
> {noformat}
>
[jira] [Closed] (SLING-10783) XmlConfigurationEntryHandler - sonar findings
[
https://issues.apache.org/jira/browse/SLING-10783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10783.
--
> XmlConfigurationEntryHandler - sonar findings
> --
>
> Key: SLING-10783
> URL: https://issues.apache.org/jira/browse/SLING-10783
> Project: Sling
> Issue Type: Sub-task
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> see
> https://sonarcloud.io/code?id=apache_sling-org-apache-sling-feature-cpconverter=apache_sling-org-apache-sling-feature-cpconverter%3Asrc%2Fmain%2Fjava%2Forg%2Fapache%2Fsling%2Ffeature%2Fcpconverter%2Fhandlers%2FXmlConfigurationEntryHandler.java
> in addition:
> the name of the inner class {{JcrConfigurationHandler extends
> AbstractJcrNodeParser}} is confusing. for the sake of consistency it should
> be named 'JcrConfigurationParser' instead of handler.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10758) Removed unused class SyntheticPathFilter
[
https://issues.apache.org/jira/browse/SLING-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10758.
--
> Removed unused class SyntheticPathFilter
>
>
> Key: SLING-10758
> URL: https://issues.apache.org/jira/browse/SLING-10758
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Labels: technical_debt
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> [~kpauls], the package private class
> {{org.apache.sling.feature.cpconverter.vltpkg.SyntheticPathFilter}} is not
> used anywhere. i would suggest that we get rid of it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10786) DefaultAclManager - sonar finding
[ https://issues.apache.org/jira/browse/SLING-10786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10786. -- > DefaultAclManager - sonar finding > - > > Key: SLING-10786 > URL: https://issues.apache.org/jira/browse/SLING-10786 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.10 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10780) AbstractConfigurationEntryHandler - sonar findings
[
https://issues.apache.org/jira/browse/SLING-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10780.
--
> AbstractConfigurationEntryHandler - sonar findings
> --
>
> Key: SLING-10780
> URL: https://issues.apache.org/jira/browse/SLING-10780
> Project: Sling
> Issue Type: Sub-task
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> fix sonar findings wrt public constructor and complexity.
> in addition: there are typos in comments and method names
> ({{setEnforceConfgurationBelowConfigFolder}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10769) VaultPackageAssembler should not implement EntryHandler
[
https://issues.apache.org/jira/browse/SLING-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10769.
--
> VaultPackageAssembler should not implement EntryHandler
> ---
>
> Key: SLING-10769
> URL: https://issues.apache.org/jira/browse/SLING-10769
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> [~kpauls], as stated with the PR for SLING-10754 i find it quite confusing
> the {{VaultPackageAssembler}} implements {{EntryHandler}} and is used as
> default in {{ContentPackage2FeatureModelConverter}}. even more so as the
> assembler is accessed by other {{EntryHandler}} implementations to add
> package entries that don't end up in repo-init.
> while the effect is likely the same if the {{EntryHandler}} methods get moved
> to a separate {{DefaultHandler}}, it would IMHO make the code easier to read.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10705) Improve exception handling and error reporting
[ https://issues.apache.org/jira/browse/SLING-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10705. -- > Improve exception handling and error reporting > -- > > Key: SLING-10705 > URL: https://issues.apache.org/jira/browse/SLING-10705 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.10 > > > The code is currently not distinguishing between user errors and tooling > errors. For example an IllegalStateException might be thrown if an OSGi > configuration is in the wrong place inside the content package as well as if > there is an internal error inside the tool. > While the first category of errors can be fixed by users fixing/adjusting > their code/content packlages - the second category hints at bugs in the code. > However both are reported exactly the same way. > I suggest we report the first one as errors via logging while the second one > throws an exception to the "outside". > We can probably achieve this without much effort by using a special exception > type for the first category. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10748) Feature Analyser should not embed dependencies
[ https://issues.apache.org/jira/browse/SLING-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10748. -- > Feature Analyser should not embed dependencies > -- > > Key: SLING-10748 > URL: https://issues.apache.org/jira/browse/SLING-10748 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Affects Versions: Feature Model Analyser 1.3.34 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 1.3.38, slingfeature-maven-plugin > 1.5.16 > > > Although the feature model analyser is a bundle with proper import statements > it is embedding some of the dependencies, like jackrabbit or the repoinit > parser. > This way, each time a new jackrabbit version or repoinit parser is released a > new release of the analyser is required - which we should avoid and decouple -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10776) DefaultFeaturesManager - sonar findings
[ https://issues.apache.org/jira/browse/SLING-10776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10776. -- > DefaultFeaturesManager - sonar findings > --- > > Key: SLING-10776 > URL: https://issues.apache.org/jira/browse/SLING-10776 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.10 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10788) ClassCastException is thrown when calling Json.createReader from a launcher extension
[
https://issues.apache.org/jira/browse/SLING-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10788.
--
> ClassCastException is thrown when calling Json.createReader from a launcher
> extension
> -
>
> Key: SLING-10788
> URL: https://issues.apache.org/jira/browse/SLING-10788
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model Launcher 1.1.22
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Launcher 1.1.26
>
>
> A ClassCastException is thrown when calling Json.createReader (JSON-P) from a
> launcher extension. The following stack trace shows the exception.
> {code}
> [ERROR] Error while running launcher:
> org.apache.johnzon.core.JsonProviderImpl not found
> javax.json.JsonException: org.apache.johnzon.core.JsonProviderImpl not found
> at javax.json.spi.JsonProvider.doLoadProvider(JsonProvider.java:118)
> at javax.json.spi.JsonProvider.provider(JsonProvider.java:89)
> at javax.json.Json.createReader(Json.java:88)
> ...
> at
> org.apache.sling.feature.launcher.impl.Bootstrap.run(Bootstrap.java:268)
> at
> org.apache.sling.feature.launcher.impl.Bootstrap.run(Bootstrap.java:170)
> at org.apache.sling.feature.launcher.impl.Main.main(Main.java:402)
> Caused by: java.lang.ClassCastException: Cannot cast
> org.apache.johnzon.core.JsonProviderImpl to javax.json.spi.JsonProvider
> at java.base/java.lang.Class.cast(Class.java:3605)
> at javax.json.spi.JsonProvider.doLoadProvider(JsonProvider.java:116)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10782) AbstractRegexEntryHandler - sonar findings
[ https://issues.apache.org/jira/browse/SLING-10782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10782. -- > AbstractRegexEntryHandler - sonar findings > -- > > Key: SLING-10782 > URL: https://issues.apache.org/jira/browse/SLING-10782 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Minor > Fix For: Content-Package to Feature Model Converter 1.1.10 > > > accessibility of constructors -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10777) VersionResolverContentPackageEntryHandler - sonar finding
[ https://issues.apache.org/jira/browse/SLING-10777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10777. -- > VersionResolverContentPackageEntryHandler - sonar finding > - > > Key: SLING-10777 > URL: https://issues.apache.org/jira/browse/SLING-10777 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.10 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10772) Reformat code in DefaultFeaturesManager, FeaturesManager
[
https://issues.apache.org/jira/browse/SLING-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10772.
--
> Reformat code in DefaultFeaturesManager, FeaturesManager
>
>
> Key: SLING-10772
> URL: https://issues.apache.org/jira/browse/SLING-10772
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Trivial
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> the indention is inconsistent and somewhat garbled in
> {{DefaultFeaturesManager}}, and {{FeaturesManager}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10807) Need to override osgi.http.whiteboard.context.name property of RequestLoggerFilter
[ https://issues.apache.org/jira/browse/SLING-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17414002#comment-17414002 ] Sagar Miglani commented on SLING-10807: --- Thanks [~cziegeler]! > Need to override osgi.http.whiteboard.context.name property of > RequestLoggerFilter > -- > > Key: SLING-10807 > URL: https://issues.apache.org/jira/browse/SLING-10807 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.7.8 >Reporter: Sagar Miglani >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.7.10 > > Time Spent: 20m > Remaining Estimate: 0h > > RequestLoggerFilter is unable to log access/request logs for the endpoints > directly configured over the jetty server (like felix web console). > I believe, RequestLoggerFilter filter should select all Servlet Context > Helpers (similar to > [ReferrerFiler:62|https://github.com/apache/sling-org-apache-sling-security/blob/1b4caa787d334d90375ab8aeb8e29dc75fcf3519/src/main/java/org/apache/sling/security/impl/ReferrerFilter.java#L62]), > and to achieve that in our instance we need to override > "osgi.http.whiteboard.context.name" property of RequestLoggerFilter with a > corresponding object in the OSGi configuration admin service, but we can not > override it as the configuration policy is set to IGNORE > ([RequestLoggerFilter:46|https://github.com/apache/sling-org-apache-sling-engine/blob/master/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerFilter.java#L46]) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10807) Need to override osgi.http.whiteboard.context.name property of RequestLoggerFilter
[ https://issues.apache.org/jira/browse/SLING-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-10807. -- Resolution: Fixed Thanks [~sagarmiglani] - I've applied your PR > Need to override osgi.http.whiteboard.context.name property of > RequestLoggerFilter > -- > > Key: SLING-10807 > URL: https://issues.apache.org/jira/browse/SLING-10807 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.7.8 >Reporter: Sagar Miglani >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.7.10 > > Time Spent: 20m > Remaining Estimate: 0h > > RequestLoggerFilter is unable to log access/request logs for the endpoints > directly configured over the jetty server (like felix web console). > I believe, RequestLoggerFilter filter should select all Servlet Context > Helpers (similar to > [ReferrerFiler:62|https://github.com/apache/sling-org-apache-sling-security/blob/1b4caa787d334d90375ab8aeb8e29dc75fcf3519/src/main/java/org/apache/sling/security/impl/ReferrerFilter.java#L62]), > and to achieve that in our instance we need to override > "osgi.http.whiteboard.context.name" property of RequestLoggerFilter with a > corresponding object in the OSGi configuration admin service, but we can not > override it as the configuration policy is set to IGNORE > ([RequestLoggerFilter:46|https://github.com/apache/sling-org-apache-sling-engine/blob/master/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerFilter.java#L46]) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-engine] cziegeler merged pull request #19: SLING-10807: Removed configuration policy from RequestLoggerFilter
cziegeler merged pull request #19: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-10807) Need to override osgi.http.whiteboard.context.name property of RequestLoggerFilter
[ https://issues.apache.org/jira/browse/SLING-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-10807: Assignee: Carsten Ziegeler > Need to override osgi.http.whiteboard.context.name property of > RequestLoggerFilter > -- > > Key: SLING-10807 > URL: https://issues.apache.org/jira/browse/SLING-10807 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.7.8 >Reporter: Sagar Miglani >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.7.10 > > Time Spent: 10m > Remaining Estimate: 0h > > RequestLoggerFilter is unable to log access/request logs for the endpoints > directly configured over the jetty server (like felix web console). > I believe, RequestLoggerFilter filter should select all Servlet Context > Helpers (similar to > [ReferrerFiler:62|https://github.com/apache/sling-org-apache-sling-security/blob/1b4caa787d334d90375ab8aeb8e29dc75fcf3519/src/main/java/org/apache/sling/security/impl/ReferrerFilter.java#L62]), > and to achieve that in our instance we need to override > "osgi.http.whiteboard.context.name" property of RequestLoggerFilter with a > corresponding object in the OSGi configuration admin service, but we can not > override it as the configuration policy is set to IGNORE > ([RequestLoggerFilter:46|https://github.com/apache/sling-org-apache-sling-engine/blob/master/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerFilter.java#L46]) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10807) Need to override osgi.http.whiteboard.context.name property of RequestLoggerFilter
[ https://issues.apache.org/jira/browse/SLING-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-10807: - Fix Version/s: Engine 2.7.10 > Need to override osgi.http.whiteboard.context.name property of > RequestLoggerFilter > -- > > Key: SLING-10807 > URL: https://issues.apache.org/jira/browse/SLING-10807 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.7.8 >Reporter: Sagar Miglani >Priority: Major > Fix For: Engine 2.7.10 > > Time Spent: 10m > Remaining Estimate: 0h > > RequestLoggerFilter is unable to log access/request logs for the endpoints > directly configured over the jetty server (like felix web console). > I believe, RequestLoggerFilter filter should select all Servlet Context > Helpers (similar to > [ReferrerFiler:62|https://github.com/apache/sling-org-apache-sling-security/blob/1b4caa787d334d90375ab8aeb8e29dc75fcf3519/src/main/java/org/apache/sling/security/impl/ReferrerFilter.java#L62]), > and to achieve that in our instance we need to override > "osgi.http.whiteboard.context.name" property of RequestLoggerFilter with a > corresponding object in the OSGi configuration admin service, but we can not > override it as the configuration policy is set to IGNORE > ([RequestLoggerFilter:46|https://github.com/apache/sling-org-apache-sling-engine/blob/master/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerFilter.java#L46]) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10807) Need to override osgi.http.whiteboard.context.name property of RequestLoggerFilter
[ https://issues.apache.org/jira/browse/SLING-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Miglani updated SLING-10807: -- Summary: Need to override osgi.http.whiteboard.context.name property of RequestLoggerFilter (was: Need to override osgi.http.whiteboard.context.name propery of RequestLoggerFilter) > Need to override osgi.http.whiteboard.context.name property of > RequestLoggerFilter > -- > > Key: SLING-10807 > URL: https://issues.apache.org/jira/browse/SLING-10807 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.7.8 >Reporter: Sagar Miglani >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > RequestLoggerFilter is unable to log access/request logs for the endpoints > directly configured over the jetty server (like felix web console). > I believe, RequestLoggerFilter filter should select all Servlet Context > Helpers (similar to > [ReferrerFiler:62|https://github.com/apache/sling-org-apache-sling-security/blob/1b4caa787d334d90375ab8aeb8e29dc75fcf3519/src/main/java/org/apache/sling/security/impl/ReferrerFilter.java#L62]), > and to achieve that in our instance we need to override > "osgi.http.whiteboard.context.name" property of RequestLoggerFilter with a > corresponding object in the OSGi configuration admin service, but we can not > override it as the configuration policy is set to IGNORE > ([RequestLoggerFilter:46|https://github.com/apache/sling-org-apache-sling-engine/blob/master/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerFilter.java#L46]) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10807) Need to override osgi.http.whiteboard.context.name propery of RequestLoggerFilter
[ https://issues.apache.org/jira/browse/SLING-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413992#comment-17413992 ] Sagar Miglani commented on SLING-10807: --- PR Link: https://github.com/apache/sling-org-apache-sling-engine/pull/19 > Need to override osgi.http.whiteboard.context.name propery of > RequestLoggerFilter > - > > Key: SLING-10807 > URL: https://issues.apache.org/jira/browse/SLING-10807 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.7.8 >Reporter: Sagar Miglani >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > RequestLoggerFilter is unable to log access/request logs for the endpoints > directly configured over the jetty server (like felix web console). > I believe, RequestLoggerFilter filter should select all Servlet Context > Helpers (similar to > [ReferrerFiler:62|https://github.com/apache/sling-org-apache-sling-security/blob/1b4caa787d334d90375ab8aeb8e29dc75fcf3519/src/main/java/org/apache/sling/security/impl/ReferrerFilter.java#L62]), > and to achieve that in our instance we need to override > "osgi.http.whiteboard.context.name" property of RequestLoggerFilter with a > corresponding object in the OSGi configuration admin service, but we can not > override it as the configuration policy is set to IGNORE > ([RequestLoggerFilter:46|https://github.com/apache/sling-org-apache-sling-engine/blob/master/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerFilter.java#L46]) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #19: SLING-10807: Removed configuration policy from RequestLoggerFilter
sonarcloud[bot] commented on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/19#issuecomment-917934443 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=19=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=19=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=19=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=19=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=19=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=19=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=19=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=19=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=19=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=19=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=19=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=19=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=19=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=19=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=19=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-10807) Need to override osgi.http.whiteboard.context.name propery of RequestLoggerFilter
[ https://issues.apache.org/jira/browse/SLING-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Miglani updated SLING-10807: -- Issue Type: Improvement (was: Bug) > Need to override osgi.http.whiteboard.context.name propery of > RequestLoggerFilter > - > > Key: SLING-10807 > URL: https://issues.apache.org/jira/browse/SLING-10807 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.7.8 >Reporter: Sagar Miglani >Priority: Major > > RequestLoggerFilter is unable to log access/request logs for the endpoints > directly configured over the jetty server (like felix web console). > I believe, RequestLoggerFilter filter should select all Servlet Context > Helpers (similar to > [ReferrerFiler:62|https://github.com/apache/sling-org-apache-sling-security/blob/1b4caa787d334d90375ab8aeb8e29dc75fcf3519/src/main/java/org/apache/sling/security/impl/ReferrerFilter.java#L62]), > and to achieve that in our instance we need to override > "osgi.http.whiteboard.context.name" property of RequestLoggerFilter with a > corresponding object in the OSGi configuration admin service, but we can not > override it as the configuration policy is set to IGNORE > ([RequestLoggerFilter:46|https://github.com/apache/sling-org-apache-sling-engine/blob/master/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerFilter.java#L46]) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10807) Need to override osgi.http.whiteboard.context.name propery of RequestLoggerFilter
Sagar Miglani created SLING-10807: - Summary: Need to override osgi.http.whiteboard.context.name propery of RequestLoggerFilter Key: SLING-10807 URL: https://issues.apache.org/jira/browse/SLING-10807 Project: Sling Issue Type: Bug Components: Engine Affects Versions: Engine 2.7.8 Reporter: Sagar Miglani RequestLoggerFilter is unable to log access/request logs for the endpoints directly configured over the jetty server (like felix web console). I believe, RequestLoggerFilter filter should select all Servlet Context Helpers (similar to [ReferrerFiler:62|https://github.com/apache/sling-org-apache-sling-security/blob/1b4caa787d334d90375ab8aeb8e29dc75fcf3519/src/main/java/org/apache/sling/security/impl/ReferrerFilter.java#L62]), and to achieve that in our instance we need to override "osgi.http.whiteboard.context.name" property of RequestLoggerFilter with a corresponding object in the OSGi configuration admin service, but we can not override it as the configuration policy is set to IGNORE ([RequestLoggerFilter:46|https://github.com/apache/sling-org-apache-sling-engine/blob/master/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerFilter.java#L46]) -- This message was sent by Atlassian Jira (v8.3.4#803005)
