[GitHub] [sling-org-apache-sling-models-jacksonexporter] kwin commented on a change in pull request #4: SLING-10959 Sling Models Exporter: Migrate from Felix SCR annotations to OSGi R7 annotations, Up

[GitBox]

kwin commented on a change in pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/4#discussion_r760826356



##
File path: pom.xml
##
@@ -29,50 +36,50 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-models-jacksonexporter.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-models-jacksonexporter.git
 
-
-
-
-org.apache.felix
-maven-scr-plugin
-
-
-org.apache.felix
-maven-bundle-plugin
-true
-
-
-*;scope=compile
-
org.apache.sling.commons.osgi
-
-
-
-
-
+
+
+8
+
2021-12-01T00:00:00Z
+
+
 
 
-org.apache.sling
-org.apache.sling.models.api
-1.3.0
+org.osgi
+osgi.core
 provided
 
 
 org.osgi
-org.osgi.compendium
+osgi.cmpn

Review comment:
   Let us rather use individual OSGi dependencies instead of aggregates.

##
File path: pom.xml
##
@@ -29,50 +36,50 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-models-jacksonexporter.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-models-jacksonexporter.git
 
-
-
-
-org.apache.felix
-maven-scr-plugin
-
-
-org.apache.felix
-maven-bundle-plugin
-true
-
-
-*;scope=compile
-
org.apache.sling.commons.osgi
-
-
-
-
-
+
+
+8
+
2021-12-01T00:00:00Z
+
+
 
 
-org.apache.sling
-org.apache.sling.models.api
-1.3.0
+org.osgi
+osgi.core

Review comment:
   Use individual OSGi dependencies

##
File path: 
src/main/java/org/apache/sling/models/jacksonexporter/impl/JacksonExporter.java
##
@@ -58,9 +56,7 @@
 
 private static final int MAPPER_FEATURE_PREFIX_LENGTH = 
MAPPER_FEATURE_PREFIX.length();
 
-@Reference(name = "moduleProvider", referenceInterface = 
ModuleProvider.class,
-cardinality = ReferenceCardinality.OPTIONAL_MULTIPLE, policy = 
ReferencePolicy.DYNAMIC)
-private final RankedServices moduleProviders = new 
RankedServices(Order.ASCENDING);
+private final RankedServices moduleProviders = new 
RankedServices<>(Order.ASCENDING);

Review comment:
   RankedServices are no longer necessary. Field injections are ordered by 
DS automatically: 
http://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#d0e37828
   
   > SCR must set the field value with a new mutable collection that must 
contain the initial set of bound services sorted using the same ordering as 
ServiceReference.compareTo based upon service ranking and service id. 

##
File path: 
src/main/java/org/apache/sling/models/jacksonexporter/impl/JacksonExporter.java
##
@@ -124,6 +120,9 @@ public boolean isSupported(@NotNull Class clazz) {
 }
 }
 
+@Reference(name = "moduleProvider", service = ModuleProvider.class,
+cardinality = ReferenceCardinality.MULTIPLE, policy = 
ReferencePolicy.DYNAMIC,
+bind = "bindModuleProvider", unbind = "unbindModuleProvider")
 protected void bindModuleProvider(final ModuleProvider moduleProvider, 
final Map props) {

Review comment:
   Let us rely on field injection here.

##
File path: 
src/main/java/org/apache/sling/models/jacksonexporter/impl/RequestModuleProvider.java
##
@@ -21,19 +21,16 @@
 import javax.servlet.ServletRequest;
 import javax.servlet.http.HttpServletRequest;
 
-import org.apache.felix.scr.annotations.Component;
-import org.apache.felix.scr.annotations.Property;
-import org.apache.felix.scr.annotations.Service;
 import org.apache.sling.api.SlingHttpServletRequest;
 import org.apache.sling.models.jacksonexporter.ModuleProvider;
-import org.osgi.framework.Constants;
+import org.osgi.service.component.annotations.Component;
+import org.osgi.service.component.propertytypes.ServiceRanking;
 
 import com.fasterxml.jackson.databind.Module;
 import com.fasterxml.jackson.databind.module.SimpleModule;
 
-@Component
-@Service
-@Property(name = Constants.SERVICE_RANKING, intValue = 0)
+@Component(service = ModuleProvider.class)
+@ServiceRanking(0)

Review comment:
   As 0 is the default I am not sure we should explicitly set it here.

##
File path: 
src/main/java/org/apache/sling/models/jacksonexporter/impl/JacksonExporter.java
##
@@ 

[GitHub] [sling-org-apache-sling-models-integration-tests] sonarcloud[bot] removed a comment on pull request #1: SLING-10954 Update Models Integration Tests to Sling 11 and Parent 46

[GitBox]

sonarcloud[bot] removed a comment on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-models-integration-tests/pull/1#issuecomment-984335446


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-integration-tests=1=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-integration-tests=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-integration-tests=1=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-integration-tests=1=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-integration-tests=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-integration-tests=1=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-10954 Update Models Integration Tests to Sling 11 and Parent 46

[GitBox]

sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-models-integration-tests/pull/1#issuecomment-984336422


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-integration-tests=1=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-integration-tests=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-integration-tests=1=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-integration-tests=1=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-integration-tests=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-integration-tests=1=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-10954 Update Models Integration Tests to Sling 11 and Parent 46

[GitBox]

sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-models-integration-tests/pull/1#issuecomment-984335446


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-integration-tests=1=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-integration-tests=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-integration-tests=1=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-integration-tests=1=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-integration-tests=1=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-integration-tests=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-integration-tests=1=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-impl] sonarcloud[bot] commented on pull request #26: SLING-10948 Update to Parent 46 and latest versions of OSGi annotation dependencies

[GitBox]

sonarcloud[bot] commented on pull request #26:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/26#issuecomment-984099685


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=26=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=26=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=26=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=26=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=26=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=26=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=26=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=26=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=26=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=26=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=26=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=26=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=26=coverage=list)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=26=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-jacksonexporter] sonarcloud[bot] commented on pull request #4: SLING-10959 Sling Models Exporter: Migrate from Felix SCR annotations to OSGi R7 annotations, Upd

[GitBox]

sonarcloud[bot] commented on pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/4#issuecomment-984098864


   SonarCloud Quality Gate failed.  ![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate failed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=4=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=4=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=4=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=4=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=4=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=4=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-jacksonexporter=4=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-jacksonexporter=4=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-jacksonexporter=4=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=4=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=4=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=4=false=CODE_SMELL)
   
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=4=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=4=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=4=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=4=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-validation-api] sonarcloud[bot] commented on pull request #1: SLING-10957 update to Parent 46

[GitBox]

sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-validation-api/pull/1#issuecomment-984089623


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-validation-api=1=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-validation-api=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-validation-api=1=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-validation-api=1=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-validation-api=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-validation-api=1=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-validation-api=1=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-validation-api=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-validation-api=1=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-validation-api=1=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-validation-api=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-validation-api=1=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-validation-api=1=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-validation-api=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-validation-api=1=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #33: SLING-10956: provide an assembly for the launcher and make the dependencies explicit

[GitBox]

sonarcloud[bot] commented on pull request #33:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/33#issuecomment-984057301


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=33=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=33=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=33=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=33=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=33=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=33=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=33=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=33=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=33=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=33=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=33=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=33=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=33=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=33=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=33=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-jacksonexporter] stefanseifert closed pull request #1: SLING-8452 migrate to OSGi R6 annotations

[GitBox]

stefanseifert closed pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/1


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-jacksonexporter] stefanseifert commented on pull request #1: SLING-8452 migrate to OSGi R6 annotations

[GitBox]

stefanseifert commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/1#issuecomment-984036326


   superseded by #4 
   
   and this one was waiting for a review from me for two years, i did overlook 
it...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10960) Sling Models Validation Impl: Update to OSGi R7 annotations, Update to Parent 46

[Stefan Seifert (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452016#comment-17452016
 ] 

Stefan Seifert commented on SLING-10960:


PR: 
https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1
(ITs do not yet pass)

> Sling Models Validation Impl: Update to OSGi R7 annotations, Update to Parent 
> 46
> 
>
> Key: SLING-10960
> URL: https://issues.apache.org/jira/browse/SLING-10960
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Sling Models Validation Impl 1.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-models-validation-impl] stefanseifert opened a new pull request #1: SLING-10960 switch to OSGI R7 annotations and update to sling-bundle-parent 46

[GitBox]

stefanseifert opened a new pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1


   also update integration tests to Sling 11 to ensure they can be run with 
Java 8 and Java 11
   
   @kwin the integration tests do not run successfully - i do not fully 
understand the reason. the testing bundle is deployed and the initial content 
contained in it is installed, but then the validation impl throws warnings like
   ```
   01.12.2021 21:26:09.574 *WARN* [EventAdminThread #2] 
org.apache.sling.validation.impl.resourcemodel.ResourceValidationModelProviderImpl
 Could not get covered resource type of newly added validation model at 
/apps/sling/validation/models/model1
   java.lang.IllegalStateException: Can no longer access resource at 
/apps/sling/validation/models/model1
at 
org.apache.sling.validation.impl.resourcemodel.ResourceValidationModelProviderImpl.getResourceTypeOfValidationModel(ResourceValidationModelProviderImpl.java:199)
 [org.apache.sling.validation.core:1.0.4]
at 
org.apache.sling.validation.impl.resourcemodel.ResourceValidationModelProviderImpl.handleEvent(ResourceValidationModelProviderImpl.java:163)
 [org.apache.sling.validation.core:1.0.4]
at 
org.apache.felix.eventadmin.impl.handler.EventHandlerProxy.sendEvent(EventHandlerProxy.java:415)
at 
org.apache.felix.eventadmin.impl.tasks.HandlerTask.run(HandlerTask.java:70) 
[org.apache.felix.eventadmin:1.5.0]
at 
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10960) Sling Models Validation Impl: Update to OSGi R7 annotations, Update to Parent 46

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-10960:
---
Summary: Sling Models Validation Impl: Update to OSGi R7 annotations, 
Update to Parent 46  (was: Sling Models Validation Impl: Migrate from Felix SCR 
annotations to OSGi R7 annotations, Update to Parent 46)

> Sling Models Validation Impl: Update to OSGi R7 annotations, Update to Parent 
> 46
> 
>
> Key: SLING-10960
> URL: https://issues.apache.org/jira/browse/SLING-10960
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Sling Models Validation Impl 1.1.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Assigned] (SLING-10960) Sling Models Validation Impl: Migrate from Felix SCR annotations to OSGi R7 annotations, Update to Parent 46

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert reassigned SLING-10960:
--

Assignee: Stefan Seifert

> Sling Models Validation Impl: Migrate from Felix SCR annotations to OSGi R7 
> annotations, Update to Parent 46
> 
>
> Key: SLING-10960
> URL: https://issues.apache.org/jira/browse/SLING-10960
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Sling Models Validation Impl 1.1.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10959) Sling Models Exporter: Migrate from Felix SCR annotations to OSGi R7 annotations, Update to Parent 46

[Stefan Seifert (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451997#comment-17451997
 ] 

Stefan Seifert commented on SLING-10959:


PR: 
https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/4

> Sling Models Exporter: Migrate from Felix SCR annotations to OSGi R7 
> annotations, Update to Parent 46
> -
>
> Key: SLING-10959
> URL: https://issues.apache.org/jira/browse/SLING-10959
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Sling Models Jackson Exporter 1.1.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Assigned] (SLING-10959) Sling Models Exporter: Migrate from Felix SCR annotations to OSGi R7 annotations, Update to Parent 46

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert reassigned SLING-10959:
--

Assignee: Stefan Seifert

> Sling Models Exporter: Migrate from Felix SCR annotations to OSGi R7 
> annotations, Update to Parent 46
> -
>
> Key: SLING-10959
> URL: https://issues.apache.org/jira/browse/SLING-10959
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Sling Models Jackson Exporter 1.1.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (SLING-10961) Sling Models API: Switch to OSGi R7 annotations, Update to Parent 46

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-10961.

  Assignee: Stefan Seifert
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-models-api/commit/7695f99db3f5d1cc4a200c6a1296a9056152a9b9

> Sling Models API: Switch to OSGi R7 annotations, Update to Parent 46
> 
>
> Key: SLING-10961
> URL: https://issues.apache.org/jira/browse/SLING-10961
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Sling Models API 1.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (SLING-10962) Sling Models Exporter: Switch to Commons Collections 4

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-10962.

  Assignee: Stefan Seifert
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/commit/3c6d311b5b0cd01121e5a3d7e8bffee70ed7fdf1

> Sling Models Exporter: Switch to Commons Collections 4
> --
>
> Key: SLING-10962
> URL: https://issues.apache.org/jira/browse/SLING-10962
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Sling Models Jackson Exporter 1.1.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10962) Sling Models Exporter: Switch to Commons Collections 4

[Stefan Seifert (Jira)]

Stefan Seifert created SLING-10962:
--

 Summary: Sling Models Exporter: Switch to Commons Collections 4
 Key: SLING-10962
 URL: https://issues.apache.org/jira/browse/SLING-10962
 Project: Sling
  Issue Type: Improvement
  Components: Sling Models
Reporter: Stefan Seifert
 Fix For: Sling Models Jackson Exporter 1.1.0






--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-7954) Switch from legacy commons collections 3 to commons collections 4

[Stefan Seifert (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-7954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451968#comment-17451968
 ] 

Stefan Seifert commented on SLING-7954:
---

created separate ticket for sling models exporter: SLING-10962

> Switch from legacy commons collections 3 to commons collections 4
> -
>
> Key: SLING-7954
> URL: https://issues.apache.org/jira/browse/SLING-7954
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Priority: Major
> Fix For: Sling Models Jackson Exporter 1.1.0
>
>
> The following bundles still use the legacy commons collections 3 version
>  They should be updated to use commons collections 4
>  com.composum.core.commons 
>  org.apache.jackrabbit.jackrabbit-spi-commons 
>  org.apache.jackrabbit.vault 
>  org.apache.sling.models.jacksonexporter



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (SLING-7954) Switch from legacy commons collections 3 to commons collections 4

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-7954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-7954:
--
Fix Version/s: (was: Sling Models Jackson Exporter 1.1.0)

> Switch from legacy commons collections 3 to commons collections 4
> -
>
> Key: SLING-7954
> URL: https://issues.apache.org/jira/browse/SLING-7954
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Priority: Major
>
> The following bundles still use the legacy commons collections 3 version
>  They should be updated to use commons collections 4
>  com.composum.core.commons 
>  org.apache.jackrabbit.jackrabbit-spi-commons 
>  org.apache.jackrabbit.vault 
>  org.apache.sling.models.jacksonexporter



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (SLING-10948) Sling Models Impl: Update to Parent 46 and latest versions of OSGi annotation dependencies

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-10948:
---
Summary: Sling Models Impl: Update to Parent 46 and latest versions of OSGi 
annotation dependencies  (was: Update to Parent 46 and latest versions of OSGi 
annotation dependencies)

> Sling Models Impl: Update to Parent 46 and latest versions of OSGi annotation 
> dependencies
> --
>
> Key: SLING-10948
> URL: https://issues.apache.org/jira/browse/SLING-10948
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Models Implementation 1.5.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> we should update to latest Sling Models Parent 46, and with this also remove 
> our explicit downgrades to OSGi R6 dependencies (and make sure next sling 
> models impl release is increasing it's minor version).
> i think we do no longer have to keep compatibility with OSGi R6 / DS/Metatype 
> 1.3.
> we should also check if we can remove the shaded dependencies form 
> org.apache.sling.commons.osgi and org.apache.sling.scripting.core and depend 
> directly on the versions we need.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10961) Sling Models API: Switch to OSGi R7 annotations, Update to Parent 46

[Stefan Seifert (Jira)]

Stefan Seifert created SLING-10961:
--

 Summary: Sling Models API: Switch to OSGi R7 annotations, Update 
to Parent 46
 Key: SLING-10961
 URL: https://issues.apache.org/jira/browse/SLING-10961
 Project: Sling
  Issue Type: Improvement
  Components: Sling Models
Reporter: Stefan Seifert
 Fix For: Sling Models API 1.4.0






--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Closed] (SLING-8452) Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-8452.
-

> Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations
> ---
>
> Key: SLING-8452
> URL: https://issues.apache.org/jira/browse/SLING-8452
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Affects Versions: Sling Models API 1.3.8, Sling Models Jackson Exporter 
> 1.0.8, Sling Models Impl 1.4.10
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Models Impl 1.4.12, Sling Models API 1.3.10
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Even the R6 metatype annotations should work in this case as currently we 
> don't have any attributes with hyphens in the name (which are only supported 
> since R7).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (SLING-8452) Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-8452.
---
Resolution: Fixed

> Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations
> ---
>
> Key: SLING-8452
> URL: https://issues.apache.org/jira/browse/SLING-8452
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Affects Versions: Sling Models API 1.3.8, Sling Models Jackson Exporter 
> 1.0.8, Sling Models Impl 1.4.10
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Models API 1.3.10, Sling Models Impl 1.4.12
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Even the R6 metatype annotations should work in this case as currently we 
> don't have any attributes with hyphens in the name (which are only supported 
> since R7).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-8452) Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations

[Stefan Seifert (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451964#comment-17451964
 ] 

Stefan Seifert commented on SLING-8452:
---

opened SLING-10959 and SLING-10960 for the remaining parts (exporter and 
validation impl), as the goal now is to migrated to R7 annotations, we can skip 
R6.

> Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations
> ---
>
> Key: SLING-8452
> URL: https://issues.apache.org/jira/browse/SLING-8452
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Affects Versions: Sling Models API 1.3.8, Sling Models Jackson Exporter 
> 1.0.8, Sling Models Impl 1.4.10
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Models Jackson Exporter 1.1.0, Sling Models Impl 
> 1.4.12, Sling Models API 1.3.10
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Even the R6 metatype annotations should work in this case as currently we 
> don't have any attributes with hyphens in the name (which are only supported 
> since R7).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (SLING-8452) Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-8452:
--
Fix Version/s: (was: Sling Models Jackson Exporter 1.1.0)

> Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations
> ---
>
> Key: SLING-8452
> URL: https://issues.apache.org/jira/browse/SLING-8452
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Affects Versions: Sling Models API 1.3.8, Sling Models Jackson Exporter 
> 1.0.8, Sling Models Impl 1.4.10
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Models Impl 1.4.12, Sling Models API 1.3.10
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Even the R6 metatype annotations should work in this case as currently we 
> don't have any attributes with hyphens in the name (which are only supported 
> since R7).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10959) Sling Models Exporter: Migrate from Felix SCR annotations to OSGi R7 annotations, Update to Parent 46

[Stefan Seifert (Jira)]

Stefan Seifert created SLING-10959:
--

 Summary: Sling Models Exporter: Migrate from Felix SCR annotations 
to OSGi R7 annotations, Update to Parent 46
 Key: SLING-10959
 URL: https://issues.apache.org/jira/browse/SLING-10959
 Project: Sling
  Issue Type: Improvement
  Components: Sling Models
Reporter: Stefan Seifert
 Fix For: Sling Models Jackson Exporter 1.1.0






--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10960) Sling Models Validation Impl: Migrate from Felix SCR annotations to OSGi R7 annotations, Update to Parent 46

[Stefan Seifert (Jira)]

Stefan Seifert created SLING-10960:
--

 Summary: Sling Models Validation Impl: Migrate from Felix SCR 
annotations to OSGi R7 annotations, Update to Parent 46
 Key: SLING-10960
 URL: https://issues.apache.org/jira/browse/SLING-10960
 Project: Sling
  Issue Type: Improvement
  Components: Sling Models
Reporter: Stefan Seifert
 Fix For: Sling Models Validation Impl 1.1.0






--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10948) Update to Parent 46 and latest versions of OSGi annotation dependencies

[Stefan Seifert (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451958#comment-17451958
 ] 

Stefan Seifert commented on SLING-10948:


PR: https://github.com/apache/sling-org-apache-sling-models-impl/pull/26

> Update to Parent 46 and latest versions of OSGi annotation dependencies
> ---
>
> Key: SLING-10948
> URL: https://issues.apache.org/jira/browse/SLING-10948
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Models Implementation 1.5.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> we should update to latest Sling Models Parent 46, and with this also remove 
> our explicit downgrades to OSGi R6 dependencies (and make sure next sling 
> models impl release is increasing it's minor version).
> i think we do no longer have to keep compatibility with OSGi R6 / DS/Metatype 
> 1.3.
> we should also check if we can remove the shaded dependencies form 
> org.apache.sling.commons.osgi and org.apache.sling.scripting.core and depend 
> directly on the versions we need.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-models-impl] stefanseifert opened a new pull request #26: SLING-10948 Update to Parent 46 and latest versions of OSGi annotation dependencies

[GitBox]

stefanseifert opened a new pull request #26:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/26


   this actively drops the support for OSGi < R7 and the older DS/metatype 
implementations.
   
   we also get rid of embedding org.apachesling.commons.osgi, as the required 
version is available for long time in recent sling releases
   
   runs fine in Sling 11 (released 3 years ago) and up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (SLING-10948) Update to Parent 46 and latest versions of OSGi annotation dependencies

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert reassigned SLING-10948:
--

Assignee: Stefan Seifert

> Update to Parent 46 and latest versions of OSGi annotation dependencies
> ---
>
> Key: SLING-10948
> URL: https://issues.apache.org/jira/browse/SLING-10948
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Models Implementation 1.5.0
>
>
> we should update to latest Sling Models Parent 46, and with this also remove 
> our explicit downgrades to OSGi R6 dependencies (and make sure next sling 
> models impl release is increasing it's minor version).
> i think we do no longer have to keep compatibility with OSGi R6 / DS/Metatype 
> 1.3.
> we should also check if we can remove the shaded dependencies form 
> org.apache.sling.commons.osgi and org.apache.sling.scripting.core and depend 
> directly on the versions we need.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10954) Update Models Integration Tests to Sling 11 and Parent 46

[Stefan Seifert (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451953#comment-17451953
 ] 

Stefan Seifert commented on SLING-10954:


PR: 
https://github.com/apache/sling-org-apache-sling-models-integration-tests/pull/1

> Update Models Integration Tests to Sling 11 and Parent 46
> -
>
> Key: SLING-10954
> URL: https://issues.apache.org/jira/browse/SLING-10954
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> the sling model integration tests where not touched since a long time (2018):
> https://github.com/apache/sling-org-apache-sling-models-integration-tests
> they should be made up to date with:
> * switching to Sling 11
> * making sure it compiles and runs with Java 11
> * using latest Bundle Parent 46
> * references latest snapshots of all sling model bundles



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-models-integration-tests] stefanseifert opened a new pull request #1: SLING-10954 Update Models Integration Tests to Sling 11 and Parent 46

[GitBox]

stefanseifert opened a new pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-models-integration-tests/pull/1


   https://issues.apache.org/jira/browse/SLING-10954
   
   with this we can use either java 8 or java 11, and the integration tests are 
running against Sling 11
   
   it's still using slingstart-maven-plugin, but this works quite elegant. i 
hat do combine the different approaches we used in the past to make sure the 
integration tests are waiting until sling is fully started up. luckily enough, 
the old ways used in sling 8 still work in sling 11 with the 
slingstart-maven-plugin, with a little tweaks.
   
   in a separate ticket/task we could evaluate switching to feature model - but 
i want to test against sling 11 anyway and not necessary against current Sling 
12-SNAPSHOT to ensure a good deal of backward compatibility (but dropping 
compatibility with Sling 8).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10958) validation.core: Upgrade to Parent 46

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10958:

Fix Version/s: Validation Core 1.0.6
   (was: Validation API 1.0.2)

> validation.core: Upgrade to Parent 46
> -
>
> Key: SLING-10958
> URL: https://issues.apache.org/jira/browse/SLING-10958
> Project: Sling
>  Issue Type: Sub-task
>  Components: Validation
>Affects Versions: Validation 1.0.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Validation Core 1.0.6
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10958) validation.core: Upgrade to Parent 46

[Konrad Windszus (Jira)]

Konrad Windszus created SLING-10958:
---

 Summary: validation.core: Upgrade to Parent 46
 Key: SLING-10958
 URL: https://issues.apache.org/jira/browse/SLING-10958
 Project: Sling
  Issue Type: Sub-task
  Components: Validation
Affects Versions: Validation 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
 Fix For: Validation API 1.0.2






--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10957) validation.api: Upgrade to Parent 46

[Konrad Windszus (Jira)]

Konrad Windszus created SLING-10957:
---

 Summary: validation.api: Upgrade to Parent 46
 Key: SLING-10957
 URL: https://issues.apache.org/jira/browse/SLING-10957
 Project: Sling
  Issue Type: Sub-task
  Components: Validation
Affects Versions: Validation 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
 Fix For: Validation API 1.0.2






--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10956) Create assembly for feature launcher

[Karl Pauls (Jira)]

Karl Pauls created SLING-10956:
--

 Summary: Create assembly for feature launcher
 Key: SLING-10956
 URL: https://issues.apache.org/jira/browse/SLING-10956
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model
Affects Versions: Feature Model Launcher 1.1.26
Reporter: Karl Pauls
Assignee: Karl Pauls
 Fix For: Feature Model Launcher 1.1.28


The launcher can be extended with service loader based class path extenders. 
That makes it tricky to have it inline its dependencies (especially 
conditionally) as the extenders might have dependencies as well. 

I think we should provide the launcher as an assembly so that we can have the 
launcher jar only contain the launcher classes and provide a zip file with 
everything included. 

That way, one can drop in extensions (and their dependencies) into the libs dir 
and manage the dependencies if required.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-9948) Jenkins: Parallelize steps of pipeline

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451901#comment-17451901
 ] 

Konrad Windszus commented on SLING-9948:


This library implements parallel builds, dedicated SonarQube execution without 
full rebuild and deployment to the Maven repository at the very end: 
https://github.com/apache/jackrabbit-filevault-jenkins-lib/blob/master/vars/fileVaultMavenStdBuild.groovy

> Jenkins: Parallelize steps of pipeline
> --
>
> Key: SLING-9948
> URL: https://issues.apache.org/jira/browse/SLING-9948
> Project: Sling
>  Issue Type: Improvement
>  Components: Build and Source Control
>Reporter: Konrad Windszus
>Priority: Major
>
> We should improve the speed of Jenkins pipelines by executing multiple Maven 
> builds in parallel.
> Also the Sonarqube step executes the Maven build again, instead it should 
> reuse the workspace of a previous build instead.
> Parallelizing Maven probably requires MRESOLVER-123 or we have to use 
> completely separate Maven repositories



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-models-impl] paul-bjorkstrand commented on pull request #25: Remove usage of Unsafe from tests

[GitBox]

paul-bjorkstrand commented on pull request #25:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/25#issuecomment-983753211


   Final note @kwin , feel free to tweak 
`CachedModelWithSelfReference.numberOfLongs`. Right now, it has about 31k worth 
of longs. The bigger this number is, the fewer allocations are necessary, and 
the faster the test will run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter and directory not auto-created

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451890#comment-17451890
 ] 

Konrad Windszus commented on SLING-7504:


Adjusted documentation in 
https://github.com/apache/sling-site/commit/427a4cb122d0a6838ff0a29ae716db787a9318f4.

> Sling File Installer Provider inactive in Sling Starter and directory not 
> auto-created
> --
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Starter 12, File Installer 1.3.4
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Even in the newest Starter 11 the framework property for the Sling File 
> Installer is not set by default. This should be fixed. The relevant framework 
> property is {{sling.fileinstall.dir}}. I propose to set this to 
> {{${sling.home}/install}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-models-impl] paul-bjorkstrand commented on a change in pull request #25: Remove usage of Unsafe from tests

[GitBox]

paul-bjorkstrand commented on a change in pull request #25:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/25#discussion_r760288510



##
File path: pom.xml
##
@@ -22,7 +22,7 @@
 
 org.apache.sling
 sling-bundle-parent
-41
+40

Review comment:
   Ah, I missed that (mostly wanted to keep #23 as much unchanged as 
possible. Thanks for the assist on this one @kwin . 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #122: Sling 10931

[GitBox]

sonarcloud[bot] commented on pull request #122:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/122#issuecomment-983708383


   SonarCloud Quality Gate failed.  ![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate failed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=VULNERABILITY)
 
[![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png
 
'E')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=VULNERABILITY)
 [1 
Vulnerability](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=SECURITY_HOTSPOT)
 
[![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png
 
'E')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=SECURITY_HOTSPOT)
 [1 Security 
Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=CODE_SMELL)
 [17 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=CODE_SMELL)
   
   
[![80.8%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'80.8%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_coverage=list)
 [80.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #122: Sling 10931

[GitBox]

sonarcloud[bot] removed a comment on pull request #122:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/122#issuecomment-983691732


   SonarCloud Quality Gate failed.  ![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate failed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=VULNERABILITY)
 
[![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png
 
'E')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=VULNERABILITY)
 [1 
Vulnerability](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=SECURITY_HOTSPOT)
 
[![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png
 
'E')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=SECURITY_HOTSPOT)
 [1 Security 
Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=CODE_SMELL)
 [18 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=CODE_SMELL)
   
   
[![80.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'80.7%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_coverage=list)
 [80.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage

[Nitin Gupta (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451871#comment-17451871
 ] 

Nitin Gupta commented on SLING-10447:
-

 
{quote}It works because the ntBaseLucene index has evaluatePathRestrictions=true
{quote}
evaluatePathRestrictions does work for isDescendantNode, but I don't think it 
works for the NOT isDescendantNode. 
{quote}the amount of nodes that is fetched from the index is drastically less 
than without that restriction.
{quote}
HI [~Henry Kuijpers] 

If the test was done on the final result set, then yes, this could have worked, 
but not because the index supported it, but most probably because the NOT 
condition was applied in the query engine. 

So something like 
{code:java}
(ISDESCENDANTNODE('/content') OR ISDESCENDANTNODE('/libs') OR 
ISDESCENDANTNODE('/apps')) {code}
would work effectively with index.

but 
{code:java}
(NOT isdescendantNode(\"/jcr:system\") AND not 
isdescendantnode('/content/usergenerated')) {code}
this might not. 

A good test case to verify this would be - 

Assuming query limit is set to 10

Create >10 nodes where sling:vanityPath is not null. Out of these, keep 80% 
of nodes under /jcr:system.

Then verify this query - 
{code:java}
SELECT sling:vanityPath from nt:base WHERE sling:vanityPath IS NOT NULL {code}
This should hit the Index-Traversal limit.

 

Then try with 
{code:java}
SELECT sling:vanityPath from nt:base WHERE sling:vanityPath IS NOT NULL AND NOT 
isdescendantNode(\"/jcr:system\"){code}
you should notice that the query would still hit the index traversal read limit 
- because the NOT operation is not directly served from the index.

 

I can do some additional testing on this in a couple of days, but I am almost 
certain that the NOT condition is not directly served from the index.

> sling:vanityPath are being searched during startup in the entire repository, 
> including version storage
> --
>
> Key: SLING-10447
> URL: https://issues.apache.org/jira/browse/SLING-10447
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.6
>Reporter: Henry Kuijpers
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Resource Resolver 1.8.0
>
> Attachments: with-path-restrictions.json, 
> without-path-restrictions.json
>
>  Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> We have a lot of pages on our production author instance. We also have a lot 
> of pages that use sling:vanityPath. Everytime a page is replicated, a new 
> version is created. 
> We have roughly 168.000 pages in our instance. In the /content node, there 
> are approx. 4500 pages with vanity URLs. In the version storage, however, 
> there are 120.000+ entries that have a sling:vanityPath defined.
> When starting up Apache Sling, the Resource Resolver fetches all the existing 
> sling:vanityPath entries, which it fails to do, because of the large amount 
> of sling:vanityPath in the version storage.
> In the code, I specifically see checks (when processing the query results) 
> about the version storage. However, this should have been put inside the 
> query as a filter, in order to avoid fetching such a large amount of query 
> result nodes:
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158
> I propose to update the query with a "not isdescendantnode"-check, to make 
> sure we do not return any content from the version storage and thus make the 
> default query limits of 100.000 nodes work again.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10955) RepoInit documentation contains confusing example for single-valued rep:glob restriction

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451866#comment-17451866
 ] 

Angela Schreiber commented on SLING-10955:
--

[~bdelacretaz], it depends on what the aim of the example is. looking at the 
other usages of the 'restriction' clause they all refer to known multi-valued 
restrictions. so, i might make sense to keep the rep:glob examples but change 
them to singe-valued.



> RepoInit documentation contains confusing example for single-valued rep:glob 
> restriction
> 
>
> Key: SLING-10955
> URL: https://issues.apache.org/jira/browse/SLING-10955
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Reporter: Angela Schreiber
>Priority: Major
>
> [~bdelacretaz], just came across the following examples on the documentation 
> page for the Sling RepoInit feature at 
> https://sling.apache.org/documentation/bundles/repository-initialization.html
> {code}
> # restrictions with glob patterns
> allow jcr:addChildNodes on /apps,/content 
> restriction(rep:glob,/cat,/cat/,cat)
> allow jcr:addChildNodes on /apps,/content 
> restriction(rep:glob,cat/,*,*cat)
> allow jcr:addChildNodes on /apps,/content 
> restriction(rep:glob,/cat/*,*/cat,*cat/*)
> {code}
> the {{rep:glob}} restriction defined with Jackrabbit Oak is single-valued :)
> while i admit that this could just be viewed as a random, the fact that there 
> is an restriction with the given name, might create a false impression and 
> consumers of the documentation might actually believe this is valid. 
> i would suggest to either use an arbitrary restriction name or if using 
> rep:glob change the examples such that they would actually work in a setup 
> based on Jackrabbit



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10955) RepoInit documentation contains confusing example for single-valued rep:glob restriction

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451862#comment-17451862
 ] 

Bertrand Delacretaz commented on SLING-10955:
-

Thanks for mentioning that, I wasn't aware of this {{rep:glob}} constraint.

IIUC, replacing {{rep:glob}} by {{example:restriction}} in these tests would 
fix this?

The examples on the docs page are now generated from [the test 
scenarios|https://github.com/apache/sling-org-apache-sling-repoinit-parser/tree/master/src/test/resources/testcases]
 - but changing those is not a problem.

> RepoInit documentation contains confusing example for single-valued rep:glob 
> restriction
> 
>
> Key: SLING-10955
> URL: https://issues.apache.org/jira/browse/SLING-10955
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Reporter: Angela Schreiber
>Priority: Major
>
> [~bdelacretaz], just came across the following examples on the documentation 
> page for the Sling RepoInit feature at 
> https://sling.apache.org/documentation/bundles/repository-initialization.html
> {code}
> # restrictions with glob patterns
> allow jcr:addChildNodes on /apps,/content 
> restriction(rep:glob,/cat,/cat/,cat)
> allow jcr:addChildNodes on /apps,/content 
> restriction(rep:glob,cat/,*,*cat)
> allow jcr:addChildNodes on /apps,/content 
> restriction(rep:glob,/cat/*,*/cat,*cat/*)
> {code}
> the {{rep:glob}} restriction defined with Jackrabbit Oak is single-valued :)
> while i admit that this could just be viewed as a random, the fact that there 
> is an restriction with the given name, might create a false impression and 
> consumers of the documentation might actually believe this is valid. 
> i would suggest to either use an arbitrary restriction name or if using 
> rep:glob change the examples such that they would actually work in a setup 
> based on Jackrabbit



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #122: Sling 10931

[GitBox]

sonarcloud[bot] removed a comment on pull request #122:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/122#issuecomment-975366392


   SonarCloud Quality Gate failed.  ![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate failed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=CODE_SMELL)
   
   
[![65.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'65.2%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_coverage=list)
 [65.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #122: Sling 10931

[GitBox]

sonarcloud[bot] commented on pull request #122:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/122#issuecomment-983691732


   SonarCloud Quality Gate failed.  ![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate failed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=VULNERABILITY)
 
[![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png
 
'E')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=VULNERABILITY)
 [1 
Vulnerability](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=SECURITY_HOTSPOT)
 
[![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png
 
'E')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=SECURITY_HOTSPOT)
 [1 Security 
Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=CODE_SMELL)
 [18 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=122=false=CODE_SMELL)
   
   
[![80.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'80.7%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_coverage=list)
 [80.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=122=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (SLING-10954) Update Models Integration Tests to Sling 11 and Parent 46

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert reassigned SLING-10954:
--

Assignee: Stefan Seifert

> Update Models Integration Tests to Sling 11 and Parent 46
> -
>
> Key: SLING-10954
> URL: https://issues.apache.org/jira/browse/SLING-10954
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
>
> the sling model integration tests where not touched since a long time (2018):
> https://github.com/apache/sling-org-apache-sling-models-integration-tests
> they should be made up to date with:
> * switching to Sling 11
> * making sure it compiles and runs with Java 11
> * using latest Bundle Parent 46
> * references latest snapshots of all sling model bundles



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #6: SLING-10126 - Added [] as a postfix to Type to force a multi-value

[GitBox]

sonarcloud[bot] commented on pull request #6:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/6#issuecomment-983686388


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=6=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=6=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=6=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=6=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=6=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=6=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=6=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=6=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=6=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=6=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=6=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=6=false=CODE_SMELL)
   
   
[![66.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'66.7%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=6=new_coverage=list)
 [66.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=6=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=6=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=6=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage

[Henry Kuijpers (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451855#comment-17451855
 ] 

Henry Kuijpers commented on SLING-10447:


Hi Gupta,

This actually does fix the issue: the amount of nodes that is fetched from the 
index is drastically less than without that restriction.

It works because the ntBaseLucene index has evaluatePathRestrictions=true and 
it defines an index for sling:vanityPath.

> sling:vanityPath are being searched during startup in the entire repository, 
> including version storage
> --
>
> Key: SLING-10447
> URL: https://issues.apache.org/jira/browse/SLING-10447
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.6
>Reporter: Henry Kuijpers
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Resource Resolver 1.8.0
>
> Attachments: with-path-restrictions.json, 
> without-path-restrictions.json
>
>  Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> We have a lot of pages on our production author instance. We also have a lot 
> of pages that use sling:vanityPath. Everytime a page is replicated, a new 
> version is created. 
> We have roughly 168.000 pages in our instance. In the /content node, there 
> are approx. 4500 pages with vanity URLs. In the version storage, however, 
> there are 120.000+ entries that have a sling:vanityPath defined.
> When starting up Apache Sling, the Resource Resolver fetches all the existing 
> sling:vanityPath entries, which it fails to do, because of the large amount 
> of sling:vanityPath in the version storage.
> In the code, I specifically see checks (when processing the query results) 
> about the version storage. However, this should have been put inside the 
> query as a filter, in order to avoid fetching such a large amount of query 
> result nodes:
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158
> I propose to update the query with a "not isdescendantnode"-check, to make 
> sure we do not return any content from the version storage and thus make the 
> default query limits of 100.000 nodes work again.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10954) Update Models Integration Tests to Sling 11 and Parent 46

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451852#comment-17451852
 ] 

Konrad Windszus commented on SLING-10954:
-

Sounds reasonable, lets first update and move them later.

> Update Models Integration Tests to Sling 11 and Parent 46
> -
>
> Key: SLING-10954
> URL: https://issues.apache.org/jira/browse/SLING-10954
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Priority: Major
>
> the sling model integration tests where not touched since a long time (2018):
> https://github.com/apache/sling-org-apache-sling-models-integration-tests
> they should be made up to date with:
> * switching to Sling 11
> * making sure it compiles and runs with Java 11
> * using latest Bundle Parent 46
> * references latest snapshots of all sling model bundles



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage

[Nitin Gupta (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451844#comment-17451844
 ] 

Nitin Gupta commented on SLING-10447:
-

[~rombert]  [~Henry Kuijpers]  - I came across this Jira while investigating an 
issue with vanity paths query at startup. I see that the fix here is to add a 
NOT isDescendent clause in the query.

I think this would not help with avoiding the query hit limit. Because NOT 
isDescendent would not be fetched directly from index - so if it the NOT 
condition here even works - it would be done in memory by QueryEngine - which 
would mean the same amount of nodes would be read from the index as before.

 

[~thomasm]  - Please correct me if I am wrong here. 

> sling:vanityPath are being searched during startup in the entire repository, 
> including version storage
> --
>
> Key: SLING-10447
> URL: https://issues.apache.org/jira/browse/SLING-10447
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.6
>Reporter: Henry Kuijpers
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Resource Resolver 1.8.0
>
> Attachments: with-path-restrictions.json, 
> without-path-restrictions.json
>
>  Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> We have a lot of pages on our production author instance. We also have a lot 
> of pages that use sling:vanityPath. Everytime a page is replicated, a new 
> version is created. 
> We have roughly 168.000 pages in our instance. In the /content node, there 
> are approx. 4500 pages with vanity URLs. In the version storage, however, 
> there are 120.000+ entries that have a sling:vanityPath defined.
> When starting up Apache Sling, the Resource Resolver fetches all the existing 
> sling:vanityPath entries, which it fails to do, because of the large amount 
> of sling:vanityPath in the version storage.
> In the code, I specifically see checks (when processing the query results) 
> about the version storage. However, this should have been put inside the 
> query as a filter, in order to avoid fetching such a large amount of query 
> result nodes:
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158
> I propose to update the query with a "not isdescendantnode"-check, to make 
> sure we do not return any content from the version storage and thus make the 
> default query limits of 100.000 nodes work again.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10954) Update Models Integration Tests to Sling 11 and Parent 46

[Stefan Seifert (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451840#comment-17451840
 ] 

Stefan Seifert commented on SLING-10954:


probably it's easier then to complete this task first, making sure everything 
runs with the latest versions, migration to OSGi annotation etc. and then in a 
second step try to move it to the actual bundles? otherwise we are changing a 
lot at the same time. i assume pax exam is not enough as we need the full sling 
stack (never used pax exam myself).

the goal of this ticket would be to change as little as possible on the actual 
running of the integration tests, but update the test code itself to latest 
standards and make sure everything runs with latest versions.

> Update Models Integration Tests to Sling 11 and Parent 46
> -
>
> Key: SLING-10954
> URL: https://issues.apache.org/jira/browse/SLING-10954
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Priority: Major
>
> the sling model integration tests where not touched since a long time (2018):
> https://github.com/apache/sling-org-apache-sling-models-integration-tests
> they should be made up to date with:
> * switching to Sling 11
> * making sure it compiles and runs with Java 11
> * using latest Bundle Parent 46
> * references latest snapshots of all sling model bundles



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Comment Edited] (SLING-10954) Update Models Integration Tests to Sling 11 and Parent 46

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451834#comment-17451834
 ] 

Konrad Windszus edited comment on SLING-10954 at 12/1/21, 1:46 PM:
---

I am aware of 
[https://github.com/apache/sling-org-apache-sling-validation-core/] (still 
based on [https://sling.apache.org/documentation/development/slingstart.html]) 
and [https://github.com/apache/sling-org-apache-sling-jcr-repoinit] (based on 
pax exam). Not sure if we have a good example which leverages 
[http://sling.apache.org/components/slingfeature-maven-plugin/,] though.


was (Author: kwin):
I am aware of 
[https://github.com/apache/sling-org-apache-sling-validation-core/] (still 
leveraging based on 
https://sling.apache.org/documentation/development/slingstart.html) and 
[https://github.com/apache/sling-org-apache-sling-jcr-repoinit] (based on pax 
exam). Not sure we have a good example which leverages 
[http://sling.apache.org/components/slingfeature-maven-plugin/,] though.

> Update Models Integration Tests to Sling 11 and Parent 46
> -
>
> Key: SLING-10954
> URL: https://issues.apache.org/jira/browse/SLING-10954
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Priority: Major
>
> the sling model integration tests where not touched since a long time (2018):
> https://github.com/apache/sling-org-apache-sling-models-integration-tests
> they should be made up to date with:
> * switching to Sling 11
> * making sure it compiles and runs with Java 11
> * using latest Bundle Parent 46
> * references latest snapshots of all sling model bundles



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10954) Update Models Integration Tests to Sling 11 and Parent 46

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451834#comment-17451834
 ] 

Konrad Windszus commented on SLING-10954:
-

I am aware of 
[https://github.com/apache/sling-org-apache-sling-validation-core/] (still 
leveraging based on 
https://sling.apache.org/documentation/development/slingstart.html) and 
[https://github.com/apache/sling-org-apache-sling-jcr-repoinit] (based on pax 
exam). Not sure we have a good example which leverages 
[http://sling.apache.org/components/slingfeature-maven-plugin/,] though.

> Update Models Integration Tests to Sling 11 and Parent 46
> -
>
> Key: SLING-10954
> URL: https://issues.apache.org/jira/browse/SLING-10954
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Priority: Major
>
> the sling model integration tests where not touched since a long time (2018):
> https://github.com/apache/sling-org-apache-sling-models-integration-tests
> they should be made up to date with:
> * switching to Sling 11
> * making sure it compiles and runs with Java 11
> * using latest Bundle Parent 46
> * references latest snapshots of all sling model bundles



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10955) RepoInit documentation contains confusing example for single-valued rep:glob restriction

[Angela Schreiber (Jira)]

Angela Schreiber created SLING-10955:


 Summary: RepoInit documentation contains confusing example for 
single-valued rep:glob restriction
 Key: SLING-10955
 URL: https://issues.apache.org/jira/browse/SLING-10955
 Project: Sling
  Issue Type: Bug
  Components: Repoinit
Reporter: Angela Schreiber


[~bdelacretaz], just came across the following examples on the documentation 
page for the Sling RepoInit feature at 
https://sling.apache.org/documentation/bundles/repository-initialization.html

{code}
# restrictions with glob patterns
allow jcr:addChildNodes on /apps,/content 
restriction(rep:glob,/cat,/cat/,cat)
allow jcr:addChildNodes on /apps,/content restriction(rep:glob,cat/,*,*cat)
allow jcr:addChildNodes on /apps,/content 
restriction(rep:glob,/cat/*,*/cat,*cat/*)
{code}

the {{rep:glob}} restriction defined with Jackrabbit Oak is single-valued :)
while i admit that this could just be viewed as a random, the fact that there 
is an restriction with the given name, might create a false impression and 
consumers of the documentation might actually believe this is valid. 

i would suggest to either use an arbitrary restriction name or if using 
rep:glob change the examples such that they would actually work in a setup 
based on Jackrabbit




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10954) Update Models Integration Tests to Sling 11 and Parent 46

[Stefan Seifert (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451829#comment-17451829
 ] 

Stefan Seifert commented on SLING-10954:


that basically would make sense as well, if easy to achieve.

do we have an example from other sling modules where we have such integration 
tests in place? running against a real sling instance started from maven with 
the current models snapshot bundles? i've a bit lost track of the latest best 
practices here.

> Update Models Integration Tests to Sling 11 and Parent 46
> -
>
> Key: SLING-10954
> URL: https://issues.apache.org/jira/browse/SLING-10954
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Priority: Major
>
> the sling model integration tests where not touched since a long time (2018):
> https://github.com/apache/sling-org-apache-sling-models-integration-tests
> they should be made up to date with:
> * switching to Sling 11
> * making sure it compiles and runs with Java 11
> * using latest Bundle Parent 46
> * references latest snapshots of all sling model bundles



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10954) Update Models Integration Tests to Sling 11 and Parent 46

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451822#comment-17451822
 ] 

Konrad Windszus commented on SLING-10954:
-

Should we rather try to dissolve that project and move the according ITs to 
[https://github.com/apache/sling-org-apache-sling-models-impl] and 
[https://github.com/apache/sling-org-apache-sling-models-jacksonexporter], 
respectively?

> Update Models Integration Tests to Sling 11 and Parent 46
> -
>
> Key: SLING-10954
> URL: https://issues.apache.org/jira/browse/SLING-10954
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Reporter: Stefan Seifert
>Priority: Major
>
> the sling model integration tests where not touched since a long time (2018):
> https://github.com/apache/sling-org-apache-sling-models-integration-tests
> they should be made up to date with:
> * switching to Sling 11
> * making sure it compiles and runs with Java 11
> * using latest Bundle Parent 46
> * references latest snapshots of all sling model bundles



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10954) Update Models Integration Tests to Sling 11 and Parent 46

[Stefan Seifert (Jira)]

Stefan Seifert created SLING-10954:
--

 Summary: Update Models Integration Tests to Sling 11 and Parent 46
 Key: SLING-10954
 URL: https://issues.apache.org/jira/browse/SLING-10954
 Project: Sling
  Issue Type: Improvement
  Components: Sling Models
Reporter: Stefan Seifert


the sling model integration tests where not touched since a long time (2018):
https://github.com/apache/sling-org-apache-sling-models-integration-tests

they should be made up to date with:
* switching to Sling 11
* making sure it compiles and runs with Java 11
* using latest Bundle Parent 46
* references latest snapshots of all sling model bundles



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #777 is FIXED

[Apache Jenkins Server]

Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/777/
 for details.

No further emails will be sent until the status of the build is changed.

[jira] [Updated] (SLING-8069) Sling Models: Enable constructor injection to use non-public constructors

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-8069:
---
Fix Version/s: Models Implementation 1.5.0

> Sling Models: Enable constructor injection to use non-public constructors
> -
>
> Key: SLING-8069
> URL: https://issues.apache.org/jira/browse/SLING-8069
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Affects Versions: Sling Models Impl 1.4.10
>Reporter: Paul Bjorkstrand
>Priority: Minor
> Fix For: Models Implementation 1.5.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In Sling Models, you cannot use a non-public constructor to inject. Looking 
> through the code, there doesn't seem to be any clear reason for this 
> restriction. In my opinion, constructor injection should allow any 
> constructor visibility.
> Here are some discussion points:
>  * Private fields are allowed for use, so disallowing private constructors 
> seems unnecessary.
>  * Private constructors may be bad practice (difficult to test), but Sling 
> should not be telling users how to write their Java code. This is especially 
> true for models, since it should work with POJOs, as stated in the 
> documentation. It would be trivial to add checks to just allow default, 
> protected, or public, but I feel that logic is unnecessary.
>  * Non-public methods could also be allowed, but that can be a separate 
> ticket.
>  ** A prerequisite of this would be to allow setter injection on models in 
> the first place. Again, not the subject of this ticket.
>  * Threading concerns are minimal, but there could be possible deadlocks, as 
> with any multi-threaded application that uses locks. In general, I think 
> locking similar to how it is done in {{InjectableField}} would be sufficient. 
> The risk of deadlock would be similar to the risk of the locking in 
> {{injectableField.set(Object, Result)}}.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (SLING-10037) Jenkins build issue: package sun.misc does not exist

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-10037.
-
Resolution: Fixed

> Jenkins build issue: package sun.misc does not exist
> 
>
> Key: SLING-10037
> URL: https://issues.apache.org/jira/browse/SLING-10037
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Reporter: Ashok Pelluru
>Priority: Major
>  Labels: compile-error
> Fix For: Models Implementation 1.5.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Jenkins/local build issue: package sun.misc does not exist
>  
> {code:java}
> [INFO] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/InjectorSpecificAnnotationTest.java:
>  Recompile with -Xlint:unchecked for details.
> [INFO] -
> [ERROR] COMPILATION ERROR : 
> [INFO] -
> [ERROR] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/AdapterFactoryTest.java:[314,23]
>  package sun.misc does not exist
> [ERROR] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/AdapterFactoryTest.java:[314,54]
>  package sun.misc does not exist
> [ERROR] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/AdapterFactoryTest.java:[317,17]
>  package sun.misc does not exist
> [ERROR] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/AdapterFactoryTest.java:[317,46]
>  package sun.misc does not exist
> [INFO] 4 errors 
> {code}
> Affected version: 1.4.17-SNAPSHOT
> For more build details: 
> [https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-models-impl/job/master/32/console]
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-models-impl] kwin closed pull request #23: Sling 10037 jdk11 build issues

[GitBox]

kwin closed pull request #23:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/23


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-impl] kwin commented on pull request #23: Sling 10037 jdk11 build issues

[GitBox]

kwin commented on pull request #23:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-983508994


   Superseded by #25 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10037) Jenkins build issue: package sun.misc does not exist

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451707#comment-17451707
 ] 

Konrad Windszus commented on SLING-10037:
-

Now fixed in 
[https://github.com/apache/sling-org-apache-sling-models-impl/commit/251610f58c8c847896ba37eef89ed8c23c3eb104]
 by merging 
[https://github.com/apache/sling-org-apache-sling-models-impl/pull/25|https://github.com/apache/sling-org-apache-sling-models-impl/pull/25.]

Thanks [~ashokmc...@gmail.com] and [~paul.bjorkstrand] for the efforts.

> Jenkins build issue: package sun.misc does not exist
> 
>
> Key: SLING-10037
> URL: https://issues.apache.org/jira/browse/SLING-10037
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Reporter: Ashok Pelluru
>Priority: Major
>  Labels: compile-error
> Fix For: Models Implementation 1.5.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Jenkins/local build issue: package sun.misc does not exist
>  
> {code:java}
> [INFO] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/InjectorSpecificAnnotationTest.java:
>  Recompile with -Xlint:unchecked for details.
> [INFO] -
> [ERROR] COMPILATION ERROR : 
> [INFO] -
> [ERROR] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/AdapterFactoryTest.java:[314,23]
>  package sun.misc does not exist
> [ERROR] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/AdapterFactoryTest.java:[314,54]
>  package sun.misc does not exist
> [ERROR] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/AdapterFactoryTest.java:[317,17]
>  package sun.misc does not exist
> [ERROR] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/AdapterFactoryTest.java:[317,46]
>  package sun.misc does not exist
> [INFO] 4 errors 
> {code}
> Affected version: 1.4.17-SNAPSHOT
> For more build details: 
> [https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-models-impl/job/master/32/console]
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-models-impl] kwin merged pull request #25: Remove usage of Unsafe from tests

[GitBox]

kwin merged pull request #25:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/25


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10447:

Fix Version/s: Resource Resolver 1.8.0
   (was: Resource Resolver 1.7.8)

> sling:vanityPath are being searched during startup in the entire repository, 
> including version storage
> --
>
> Key: SLING-10447
> URL: https://issues.apache.org/jira/browse/SLING-10447
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.6
>Reporter: Henry Kuijpers
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Resource Resolver 1.8.0
>
> Attachments: with-path-restrictions.json, 
> without-path-restrictions.json
>
>  Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> We have a lot of pages on our production author instance. We also have a lot 
> of pages that use sling:vanityPath. Everytime a page is replicated, a new 
> version is created. 
> We have roughly 168.000 pages in our instance. In the /content node, there 
> are approx. 4500 pages with vanity URLs. In the version storage, however, 
> there are 120.000+ entries that have a sling:vanityPath defined.
> When starting up Apache Sling, the Resource Resolver fetches all the existing 
> sling:vanityPath entries, which it fails to do, because of the large amount 
> of sling:vanityPath in the version storage.
> In the code, I specifically see checks (when processing the query results) 
> about the version storage. However, this should have been put inside the 
> query as a filter, in order to avoid fetching such a large amount of query 
> result nodes:
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158
> I propose to update the query with a "not isdescendantnode"-check, to make 
> sure we do not return any content from the version storage and thus make the 
> default query limits of 100.000 nodes work again.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10953) Update dependency Antisamy version from 1.5.10 to 1.6.4

[Tatyana Vogel (Jira)]

Tatyana Vogel created SLING-10953:
-

 Summary: Update dependency Antisamy version from 1.5.10 to 1.6.4
 Key: SLING-10953
 URL: https://issues.apache.org/jira/browse/SLING-10953
 Project: Sling
  Issue Type: Improvement
Reporter: Tatyana Vogel






--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-models-impl] kwin commented on a change in pull request #25: Remove usage of Unsafe from tests

[GitBox]

kwin commented on a change in pull request #25:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/25#discussion_r760026835



##
File path: pom.xml
##
@@ -22,7 +22,7 @@
 
 org.apache.sling
 sling-bundle-parent
-41
+40

Review comment:
   I am gonna upgrade to the newest parent post merge so we can ignore this 
downgrade




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10037) Jenkins build issue: package sun.misc does not exist

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10037:

Fix Version/s: Models Implementation 1.5.0

> Jenkins build issue: package sun.misc does not exist
> 
>
> Key: SLING-10037
> URL: https://issues.apache.org/jira/browse/SLING-10037
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Reporter: Ashok Pelluru
>Priority: Major
>  Labels: compile-error
> Fix For: Models Implementation 1.5.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Jenkins/local build issue: package sun.misc does not exist
>  
> {code:java}
> [INFO] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/InjectorSpecificAnnotationTest.java:
>  Recompile with -Xlint:unchecked for details.
> [INFO] -
> [ERROR] COMPILATION ERROR : 
> [INFO] -
> [ERROR] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/AdapterFactoryTest.java:[314,23]
>  package sun.misc does not exist
> [ERROR] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/AdapterFactoryTest.java:[314,54]
>  package sun.misc does not exist
> [ERROR] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/AdapterFactoryTest.java:[317,17]
>  package sun.misc does not exist
> [ERROR] 
> /home/jenkins/h49-shared/712657a4/workspace/_apache-sling-models-impl_master/src/test/java/org/apache/sling/models/impl/AdapterFactoryTest.java:[317,46]
>  package sun.misc does not exist
> [INFO] 4 errors 
> {code}
> Affected version: 1.4.17-SNAPSHOT
> For more build details: 
> [https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-models-impl/job/master/32/console]
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (SLING-10947) Sling Models Unit Tests do not compile with Java 11

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-10947.
-
Resolution: Duplicate

> Sling Models Unit Tests do not compile with Java 11
> ---
>
> Key: SLING-10947
> URL: https://issues.apache.org/jira/browse/SLING-10947
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Affects Versions: Models Implementation 1.4.16
>Reporter: Stefan Seifert
>Priority: Minor
> Fix For: Models Implementation 1.5.0
>
>
> due to a reference to sun.misc in 
> https://github.com/apache/sling-org-apache-sling-models-impl/blob/a016b05184a17f3760f8594139fabc573d5bfdae/src/test/java/org/apache/sling/models/impl/AdapterFactoryTest.java#L313-L335



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

RE: archive help

[Stefan Seifert]

https://lists.apache.org/thread/bpxnhycdp40y1n4zbf2q2wx5kmfxjdy0

stefan

>-Original Message-
>From: Nicolas Peltier 
>Sent: Wednesday, December 1, 2021 10:31 AM
>To: Sling Developers List 
>Subject: archive help
>
>Hey,
>
>i can't find the hackathon discussion around maven-bnd-plugin vs
>bnd-maven-plugin.
>That link
>http://apache-sling.73963.n3.nabble.com/hackathon-bnd-maven-plugin-vs-
>maven-bundle-plugin-td4086273.html
>does not work anymore...
>any clue where i could find it?
>Thanks,
>Nicolas

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #53: SLING-10945 add metrics

[GitBox]

sonarcloud[bot] commented on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#issuecomment-983456869


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
   
   
[![87.8%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'87.8%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_coverage=list)
 [87.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #53: SLING-10945 add metrics

[GitBox]

sonarcloud[bot] removed a comment on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#issuecomment-983449420


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
 [4 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
   
   
[![87.8%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'87.8%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_coverage=list)
 [87.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

archive help

[Nicolas Peltier]

Hey,

i can't find the hackathon discussion around maven-bnd-plugin vs
bnd-maven-plugin.
That link
http://apache-sling.73963.n3.nabble.com/hackathon-bnd-maven-plugin-vs-maven-bundle-plugin-td4086273.html
does not work anymore...
any clue where i could find it?
Thanks,
Nicolas

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #53: SLING-10945 add metrics

[GitBox]

sonarcloud[bot] commented on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#issuecomment-983449420


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
 [4 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
   
   
[![87.8%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'87.8%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_coverage=list)
 [87.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #53: SLING-10945 add metrics

[GitBox]

sonarcloud[bot] removed a comment on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#issuecomment-983424078


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
   
   
[![87.8%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'87.8%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_coverage=list)
 [87.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #53: SLING-10945 add metrics

[GitBox]

sonarcloud[bot] removed a comment on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#issuecomment-982851368


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
   
   
[![87.8%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'87.8%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_coverage=list)
 [87.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #53: SLING-10945 add metrics

[GitBox]

sonarcloud[bot] commented on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#issuecomment-983424078


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=53=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=53=false=CODE_SMELL)
   
   
[![87.8%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'87.8%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_coverage=list)
 [87.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=53=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh edited a comment on pull request #53: SLING-10945 add metrics

[GitBox]

joerghoh edited a comment on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#issuecomment-983419537


   (prefixed the metric names with 'org.apache.sling.resourceresolver' with 
previous commit, description has been adjusted)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh commented on pull request #53: SLING-10945 add metrics

[GitBox]

joerghoh commented on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#issuecomment-983419537


   (prefixed the metric names with 'org.apache.sling.resourceresolver' with a 
new PR, description has been adjusted)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org