[GitHub] [sling-org-apache-sling-testing-clients] andrewmkhoury commented on pull request #23: SLING-10860 ignore server retries if response status code is in the expected status

2021-12-21 Thread GitBox


andrewmkhoury commented on pull request #23:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/23#issuecomment-999203842


   @klcodanr can you review, approve and merge here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #817 is BROKEN

2021-12-21 Thread Apache Jenkins Server
Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/817/
 for details.

No further emails will be sent until the status of the build is changed.
Build log follows below:

[...truncated 3009 lines...]
at 
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338)
at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315)
at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173)
at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131)
at 
org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:386)
at 
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
at 
org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
at java.lang.Thread.run(Thread.java:748)

[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.servlets.resolver.errorhandler.ErrorHandlingTest
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.045 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.servlets.resolver.errorhandler.ErrorHandlingTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletNopTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.061 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletNopTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.RangeStreamingTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.453 s 
- in org.apache.sling.launchpad.webapp.integrationtest.RangeStreamingTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.WebdavDeleteTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.199 s 
- in org.apache.sling.launchpad.webapp.integrationtest.WebdavDeleteTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.scripting.StandaloneScriptExecutionTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.08 s - 
in 
org.apache.sling.launchpad.webapp.integrationtest.scripting.StandaloneScriptExecutionTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.LaunchpadConfigInstallerTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.174 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.LaunchpadConfigInstallerTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletCreateTest
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.435 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletCreateTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletAtDeleteTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.167 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletAtDeleteTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.installer.ServerSideInstallerTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.515 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.installer.ServerSideInstallerTest
[INFO] Running org.apache.sling.launchpad.webapp.integrationtest.EspLoadTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.3 s - 
in org.apache.sling.launchpad.webapp.integrationtest.EspLoadTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverApiTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.392 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverApiTest
[INFO] Running org.apache.sling.launchpad.webapp.integrationtest.crud.CrudTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.195 s 
- in org.apache.sling.launchpad.webapp.integrationtest.crud.CrudTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.InitialContentTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.055 s 
- in org.apache.sling.launchpad.webapp.integrationtest.InitialContentTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletMoveTest
[INFO] Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.603 s 
- in 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletMoveTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest

Re: [VOTE] Release Apache Sling Content Distribution Journal Core 0.1.22 and Content Distribution Core 0.4.8

2021-12-21 Thread Nicolas Peltier
Ha ok sorry to be that late in the game

Kind regards,
Nicolas

De : Timothee Maret 
Envoyé : Tuesday, December 21, 2021 2:04:03 PM
À : dev@sling.apache.org 
Objet : Re: [VOTE] Release Apache Sling Content Distribution Journal Core 
0.1.22 and Content Distribution Core 0.4.8

Hi Nicolas,

I have promoted the release about 2 hours ago which removed the staging
repository.

Regards,

Timothee

Le mar. 21 déc. 2021 à 12:43, Nicolas Peltier  a
écrit :

> i don't find the 2573 repo anymore
>
> Le mar. 21 déc. 2021 à 10:20,  a écrit :
>
> > +1
> >
> > David
> >
> > On Tue, 21 Dec 2021 at 09:19, Timothee Maret  wrote:
> >
> > > Anybody else keen to cast a binding vote ?
> > >
> > > Regards,
> > >
> > > Timothee
> > >
> > > Le ven. 17 déc. 2021 à 17:12, Timothee Maret  a
> > écrit :
> > >
> > > > Hi,
> > > >
> > > > This vote includes 2 bundles
> > > >
> > > > 1. Content Distribution Journal Core 0.1.22
> > > >
> > > > We solved 3 issues in this release:
> > > >
> > > >
> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fprojects%2FSLING%2Fversions%2F12350413&data=04%7C01%7Cnpeltier%40adobe.com%7C36d226a37cc14295a97108d9c482652a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637756886588127718%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=MCmB28g58rdr3jQI6nrkfDyG84Ej07DPnffrFhG6Z7Y%3D&reserved=0
> > > >
> > > > There are still some outstanding issues:
> > > >
> > > >
> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fprojects%2FSLING%2Fversions%2F12351109&data=04%7C01%7Cnpeltier%40adobe.com%7C36d226a37cc14295a97108d9c482652a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637756886588137711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=cZcJbwsLqjTp6%2Bpmeq2clSUNT0%2B9bT53qBqc1xMSCw0%3D&reserved=0
> > > >
> > > > 2. Content Distribution Core 0.4.8
> > > >
> > > > We solved 3 issues in this release:
> > > >
> > > >
> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fprojects%2FSLING%2Fversions%2F12349660&data=04%7C01%7Cnpeltier%40adobe.com%7C36d226a37cc14295a97108d9c482652a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637756886588137711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=yplLWZPbZf3z3iwjAA4opTsPilirJKvqQRHMZPbIN4Q%3D&reserved=0
> > > >
> > > > There are still some outstanding issues:
> > > >
> > > >
> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fprojects%2FSLING%2Fversions%2F12351110&data=04%7C01%7Cnpeltier%40adobe.com%7C36d226a37cc14295a97108d9c482652a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637756886588137711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=sAMTyZY%2FuujvOjr7RtICY4eq4Eh4OlsRPzLoCbBZN0M%3D&reserved=0
> > > >
> > > > Staging repository:
> > > >
> > > >
> > >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachesling-2573%2F&data=04%7C01%7Cnpeltier%40adobe.com%7C36d226a37cc14295a97108d9c482652a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637756886588137711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=d%2BRtMp7W%2FqSEdRj1av49MZIebIH3tPsQwyw%2BPVZgKtA%3D&reserved=0
> > > >
> > > > You can use this UNIX script to download the release and verify the
> > > > signatures:
> > > >
> > > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%3Fp%3Dsling-tooling-release.git%3Ba%3Dblob%3Bf%3Dcheck_staged_release.sh%3Bhb%3DHEAD&data=04%7C01%7Cnpeltier%40adobe.com%7C36d226a37cc14295a97108d9c482652a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637756886588137711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=kUMVz9Qe0mXdpuuPMM7ARjgidfAUG%2BdcCkp3IVYKP4Y%3D&reserved=0
> > > >
> > > > Usage:
> > > > sh check_staged_release.sh 2573 /tmp/sling-staging
> > > >
> > > > Please vote to approve this release:
> > > >
> > > >   [ ] +1 Approve the release
> > > >   [ ]  0 Don't care
> > > >   [ ] -1 Don't release, because ...
> > > >
> > > > This majority vote is open for at least 72 hours.
> > > >
> > >
> >
>


[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #42: Update to o.a.s.scripting.sightly.repl 1.0.10

2021-12-21 Thread GitBox


rombert merged pull request #42:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/42


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #42: Update to o.a.s.scripting.sightly.repl 1.0.10

2021-12-21 Thread GitBox


sonarcloud[bot] commented on pull request #42:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/42#issuecomment-999026547


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=42&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=42&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=42&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=42&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=42&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=42&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=42&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=42&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=42&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=42&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=42&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=42&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=42)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=42&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-launchpad-testing] rombert merged pull request #6: Update to version 0.1.2 of the feature-launcher-maven-plugin

2021-12-21 Thread GitBox


rombert merged pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-testing/pull/6


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #41: Update to feature-launcher-maven-plugin 0.1.2

2021-12-21 Thread GitBox


rombert merged pull request #41:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/41


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #41: Update to feature-launcher-maven-plugin 0.1.2

2021-12-21 Thread GitBox


sonarcloud[bot] commented on pull request #41:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/41#issuecomment-998990803


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=41&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=41&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=41&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=41&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=41&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=41&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=41&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=41&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=41&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=41)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=41&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=41&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (SLING-9079) [HTL] HTL/Sightly REPL not building with Java > 8

2021-12-21 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-9079.
--

> [HTL] HTL/Sightly REPL not building with Java > 8
> -
>
> Key: SLING-9079
> URL: https://issues.apache.org/jira/browse/SLING-9079
> Project: Sling
>  Issue Type: Sub-task
>  Components: Scripting
>Affects Versions: Scripting HTL REPL 1.0.6
>Reporter: Vlad Bailescu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Scripting HTL REPL 1.0.10
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> The REPL is not building with Java 11:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run 
> (set-bundle-required-execution-environment) on project 
> org.apache.sling.scripting.sightly.repl: An Ant BuildException has occured: 
> Unable to create javax script engine for javascript
> [ERROR] around Ant part ...

[jira] [Closed] (SLING-10987) Don't overwrite/remove nodes outside the nodes really owned by HTL REPL

2021-12-21 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-10987.
---

> Don't overwrite/remove nodes outside the nodes really owned by HTL REPL
> ---
>
> Key: SLING-10987
> URL: https://issues.apache.org/jira/browse/SLING-10987
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Scripting HTL REPL 1.0.10
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Due to the missing path directive in 
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/blob/11a40bbeb0ca1ce01ed37441ece94cd29e29e9b0/bnd.bnd#L1,
>  this bundle will remove a lot of already existing nodes in the repository 
> once installed (compare with SLING-10983).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10978) HTL REPL should be installed under /content

2021-12-21 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-10978.
---

> HTL REPL should be installed under /content
> ---
>
> Key: SLING-10978
> URL: https://issues.apache.org/jira/browse/SLING-10978
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Scripting HTL REPL 1.0.10
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The entry HTL repl resource is installed at {{htl/repl}} ( see 
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/blob/ad3ee50c81fb77302fa2d0b7c505c720b93ec494/src/main/resources/SLING-INF/htl/repl.json
>  ).
> It should instead be installed at /content/htl/repl. This will incidentally 
> make it accesible at the same location anyway.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10981) Update HTL REPL to parent pom 46

2021-12-21 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-10981.
---

> Update HTL REPL to parent pom 46
> 
>
> Key: SLING-10981
> URL: https://issues.apache.org/jira/browse/SLING-10981
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Scripting HTL REPL 1.0.10
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[RESULT] [VOTE] Release Apache Sling Scripting HTL REPL 1.0.10

2021-12-21 Thread Robert Munteanu
Hi,

The vote has passed with the following result:

+1 (binding): Stefan Seifert, Robert Munteanu, Radu Cotescu, Dan Klco, Karl 
Pauls
+1 (non-binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Robert Munteanu


[jira] [Closed] (SLING-9843) fallback to java.home system property if JAVA_HOME env variable is not set

2021-12-21 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-9843.
--

> fallback to java.home system property if JAVA_HOME env variable is not set
> --
>
> Key: SLING-9843
> URL: https://issues.apache.org/jira/browse/SLING-9843
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.2
>
>
> If JAVA_HOME env variable is not set, then the launcher fails as it tries to 
> run with this error:
> {code:java}
> Cannot run program "null/bin/java" error.{code}
> Falling back to the java.home system property would also get us the path to 
> the java jre that should work for launching the java process.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-9994) Allow configuring extra jvm options

2021-12-21 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-9994.
--

> Allow configuring extra jvm options
> ---
>
> Key: SLING-9994
> URL: https://issues.apache.org/jira/browse/SLING-9994
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: Feature Launcher Maven Plugin 0.1.0
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Minor
> Fix For: Feature Launcher Maven Plugin 0.1.2
>
>
> It may be necessary to pass additional jvm options to the launcher command 
> line in order to do things like adjust the max memory or enable remote 
> debugging for the process.
> To facilitate that, add support for supplying an array of vmOptions to the 
> launcherArguments configuration and use those settings when launching the 
> process.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10364) sling-feature-launcher-maven-plugin: Optionally wait with shutdown until key is pressed

2021-12-21 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-10364.
---

> sling-feature-launcher-maven-plugin: Optionally wait with shutdown until key 
> is pressed
> ---
>
> Key: SLING-10364
> URL: https://issues.apache.org/jira/browse/SLING-10364
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: Feature Launcher Maven Plugin 0.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.2
>
>
> Similar to 
> [https://github.com/apache/sling-slingstart-maven-plugin/blob/b3abd6d811f895a126870ac241ba5d51d4be135c/src/main/java/org/apache/sling/maven/slingstart/run/AbstractStartStopMojo.java#L71]
>  it is sometimes handy to defer the shutdown of the Sling instance to perform 
> additional manual tests.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10423) Add support to skip a launch

2021-12-21 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-10423.
---

> Add support to skip a launch
> 
>
> Key: SLING-10423
> URL: https://issues.apache.org/jira/browse/SLING-10423
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.2
>
>
> For situation where you want skip a launch if certain pre-conditions are not 
> met. 
> For example:
>  
> {noformat}
> ...
> 
> sling-12-oak-mongo
> ${docker.skip}
> ...{noformat}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10941) Allow setting environment variables for launches

2021-12-21 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-10941.
---

> Allow setting environment variables for launches
> 
>
> Key: SLING-10941
> URL: https://issues.apache.org/jira/browse/SLING-10941
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.2
>
>
> When a feature model based application makes use of environment variables for 
> configuration, for instance using the [Felix ConfigAdmin interpolation 
> plugin|https://github.com/apache/felix-dev/tree/master/configadmin-plugins/interpolation],
>  it is useful to be able to configure environment variables per launch.
> Without this feature all env vars would be inherited from the launching 
> process.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10420) Add support for feature launcher variables

2021-12-21 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-10420.
---

> Add support for feature launcher variables
> --
>
> Key: SLING-10420
> URL: https://issues.apache.org/jira/browse/SLING-10420
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Feature Launcher Maven Plugin 0.1.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Feature Launcher Maven Plugin 0.1.2
>
>
> The feature launcher maven plugin doesn't support feature model variables 
> yet, I'll add them with a syntax like
> {code}
> 
>   
> TEST_VALUE
>   
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[RESULT] [VOTE] Release Apache Sling Feature Launcher Maven Plugin 0.1.2

2021-12-21 Thread Robert Munteanu
Hi,

The vote has passed with the following result:

+1 (binding): Robert Munteanu, Carsten Ziegeler, Stefan Seifert, Dan Klco, Karl 
Pauls, A. J. David Bosschaert
+1 (non-binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Robert Munteanu


[jira] [Resolved] (SLING-11030) OSGiServiceInjector.getService() calls ungetService even if service is not get

2021-12-21 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-11030.
--
Resolution: Fixed

Fixed in 
https://github.com/apache/sling-org-apache-sling-models-impl/commit/0a83d4129ccb78b25dea7926a11c60014c0344e4

> OSGiServiceInjector.getService() calls ungetService even if service is not get
> --
>
> Key: SLING-11030
> URL: https://issues.apache.org/jira/browse/SLING-11030
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Affects Versions: Models Implementation 1.5.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Models Implementation 1.5.2
>
>
> The getService method gets all service references, but only from one of them 
> it gets the service. However all service references are passed in to the 
> callback for disposal. So for all references an unget is called, although it 
> happened only for one
> In addition, the code is assuming that the service with the highest ranking 
> is always gettable. A null check is missing at : 
> https://github.com/apache/sling-org-apache-sling-models-impl/blob/89fcb8702e29ad3322ee2a023ae6b24e5d2f83ab/src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java#L114
>  
> It would be better to loop over the services references until one returns non 
> null and then only dispose that reference later



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Assigned] (SLING-11030) OSGiServiceInjector.getService() calls ungetService even if service is not get

2021-12-21 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-11030:


Assignee: Carsten Ziegeler

> OSGiServiceInjector.getService() calls ungetService even if service is not get
> --
>
> Key: SLING-11030
> URL: https://issues.apache.org/jira/browse/SLING-11030
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Affects Versions: Models Implementation 1.5.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Models Implementation 1.5.2
>
>
> The getService method gets all service references, but only from one of them 
> it gets the service. However all service references are passed in to the 
> callback for disposal. So for all references an unget is called, although it 
> happened only for one
> In addition, the code is assuming that the service with the highest ranking 
> is always gettable. A null check is missing at : 
> https://github.com/apache/sling-org-apache-sling-models-impl/blob/89fcb8702e29ad3322ee2a023ae6b24e5d2f83ab/src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java#L114
>  
> It would be better to loop over the services references until one returns non 
> null and then only dispose that reference later



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (SLING-11030) OSGiServiceInjector.getService() calls ungetService even if service is not get

2021-12-21 Thread Karl Pauls (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463282#comment-17463282
 ] 

Karl Pauls commented on SLING-11030:


Additionally, I think it would be good to improve the getService call to keep 
looping over the references until one did actually return a service. Like it is 
right now, it might return null even so there would have been a different 
service available. Obviously, the callback should then be seeded with the ref 
that was used (i.e., the first that didn't return null) - if any.

Futhermore, the getService_s_ has a similar issue where it a) might end up 
returning an empty array (if there was no ref returning a service) - instead, 
it should return null if the array is empty in the end and regardless, it 
should filter out the refs that returned null from the refs given to the 
callback.

> OSGiServiceInjector.getService() calls ungetService even if service is not get
> --
>
> Key: SLING-11030
> URL: https://issues.apache.org/jira/browse/SLING-11030
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Affects Versions: Models Implementation 1.5.0
>Reporter: Carsten Ziegeler
>Priority: Major
> Fix For: Models Implementation 1.5.2
>
>
> The getService method gets all service references, but only from one of them 
> it gets the service. However all service references are passed in to the 
> callback for disposal. So for all references an unget is called, although it 
> happened only for one
> In addition, the code is assuming that the service with the highest ranking 
> is always gettable. A null check is missing at : 
> https://github.com/apache/sling-org-apache-sling-models-impl/blob/89fcb8702e29ad3322ee2a023ae6b24e5d2f83ab/src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java#L114
>  
> It would be better to loop over the services references until one returns non 
> null and then only dispose that reference later



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-11030) OSGiServiceInjector.getService() calls ungetService even if service is not get

2021-12-21 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-11030:
-
Description: 
The getService method gets all service references, but only from one of them it 
gets the service. However all service references are passed in to the callback 
for disposal. So for all references an unget is called, although it happened 
only for one

In addition, the code is assuming that the service with the highest ranking is 
always gettable. A null check is missing at : 
https://github.com/apache/sling-org-apache-sling-models-impl/blob/89fcb8702e29ad3322ee2a023ae6b24e5d2f83ab/src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java#L114
 
It would be better to loop over the services references until one returns non 
null and then only dispose that reference later

  was:The getService method gets all service references, but only from one of 
them it gets the service. However all service references are passed in to the 
callback for disposal. So for all references an unget is called, although it 
happened only for one


> OSGiServiceInjector.getService() calls ungetService even if service is not get
> --
>
> Key: SLING-11030
> URL: https://issues.apache.org/jira/browse/SLING-11030
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Affects Versions: Models Implementation 1.5.0
>Reporter: Carsten Ziegeler
>Priority: Major
> Fix For: Models Implementation 1.5.2
>
>
> The getService method gets all service references, but only from one of them 
> it gets the service. However all service references are passed in to the 
> callback for disposal. So for all references an unget is called, although it 
> happened only for one
> In addition, the code is assuming that the service with the highest ranking 
> is always gettable. A null check is missing at : 
> https://github.com/apache/sling-org-apache-sling-models-impl/blob/89fcb8702e29ad3322ee2a023ae6b24e5d2f83ab/src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java#L114
>  
> It would be better to loop over the services references until one returns non 
> null and then only dispose that reference later



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (SLING-11030) OSGiServiceInjector.getService() calls ungetService even if service is not get

2021-12-21 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-11030:


 Summary: OSGiServiceInjector.getService() calls ungetService even 
if service is not get
 Key: SLING-11030
 URL: https://issues.apache.org/jira/browse/SLING-11030
 Project: Sling
  Issue Type: Bug
  Components: Sling Models
Affects Versions: Models Implementation 1.5.0
Reporter: Carsten Ziegeler
 Fix For: Models Implementation 1.5.2


The getService method gets all service references, but only from one of them it 
gets the service. However all service references are passed in to the callback 
for disposal. So for all references an unget is called, although it happened 
only for one



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (SLING-11029) OSGiServiceInjector.getService() should rely on framework

2021-12-21 Thread Carsten Ziegeler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463268#comment-17463268
 ] 

Carsten Ziegeler commented on SLING-11029:
--

Of course, that simplification does only work if the filter is null

> OSGiServiceInjector.getService() should rely on framework
> -
>
> Key: SLING-11029
> URL: https://issues.apache.org/jira/browse/SLING-11029
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Affects Versions: Models Implementation 1.5.0
>Reporter: Carsten Ziegeler
>Priority: Major
> Fix For: Models Implementation 1.5.2
>
>
> Looking at 
> https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java#L102
>  it seems to get all service references, sort them and then uses the one with 
> the highest ranking.
> However BundleContext#getServiceReference() does exactly that, so it can be 
> directly used



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (SLING-11029) OSGiServiceInjector.getService() should rely on framework

2021-12-21 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-11029:


 Summary: OSGiServiceInjector.getService() should rely on framework
 Key: SLING-11029
 URL: https://issues.apache.org/jira/browse/SLING-11029
 Project: Sling
  Issue Type: Improvement
  Components: Sling Models
Affects Versions: Models Implementation 1.5.0
Reporter: Carsten Ziegeler
 Fix For: Models Implementation 1.5.2


Looking at 
https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java#L102
 it seems to get all service references, sort them and then uses the one with 
the highest ranking.
However BundleContext#getServiceReference() does exactly that, so it can be 
directly used



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: [VOTE] Release Apache Sling Content Distribution Journal Core 0.1.22 and Content Distribution Core 0.4.8

2021-12-21 Thread Timothee Maret
Hi Nicolas,

I have promoted the release about 2 hours ago which removed the staging
repository.

Regards,

Timothee

Le mar. 21 déc. 2021 à 12:43, Nicolas Peltier  a
écrit :

> i don't find the 2573 repo anymore
>
> Le mar. 21 déc. 2021 à 10:20,  a écrit :
>
> > +1
> >
> > David
> >
> > On Tue, 21 Dec 2021 at 09:19, Timothee Maret  wrote:
> >
> > > Anybody else keen to cast a binding vote ?
> > >
> > > Regards,
> > >
> > > Timothee
> > >
> > > Le ven. 17 déc. 2021 à 17:12, Timothee Maret  a
> > écrit :
> > >
> > > > Hi,
> > > >
> > > > This vote includes 2 bundles
> > > >
> > > > 1. Content Distribution Journal Core 0.1.22
> > > >
> > > > We solved 3 issues in this release:
> > > >
> > > >https://issues.apache.org/jira/projects/SLING/versions/12350413
> > > >
> > > > There are still some outstanding issues:
> > > >
> > > >https://issues.apache.org/jira/projects/SLING/versions/12351109
> > > >
> > > > 2. Content Distribution Core 0.4.8
> > > >
> > > > We solved 3 issues in this release:
> > > >
> > > >https://issues.apache.org/jira/projects/SLING/versions/12349660
> > > >
> > > > There are still some outstanding issues:
> > > >
> > > >https://issues.apache.org/jira/projects/SLING/versions/12351110
> > > >
> > > > Staging repository:
> > > >
> > > >
> > >
> https://repository.apache.org/content/repositories/orgapachesling-2573/
> > > >
> > > > You can use this UNIX script to download the release and verify the
> > > > signatures:
> > > >
> > > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> > > >
> > > > Usage:
> > > > sh check_staged_release.sh 2573 /tmp/sling-staging
> > > >
> > > > Please vote to approve this release:
> > > >
> > > >   [ ] +1 Approve the release
> > > >   [ ]  0 Don't care
> > > >   [ ] -1 Don't release, because ...
> > > >
> > > > This majority vote is open for at least 72 hours.
> > > >
> > >
> >
>


[RESULT] [VOTE] Release Apache Sling Content Distribution Journal Core 0.1.22 and Content Distribution Core 0.4.8

2021-12-21 Thread Timothee Maret
Hi,

The vote has passed with the following result :

+1 (binding): Carsten Ziegeler, David Bosschaert, Timothee Maret
+1 (non binding): Christian Schneider

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Thanks for voting!

Timothee


[jira] [Closed] (SLING-10095) Surface latest content package extractor error as an exception

2021-12-21 Thread Jira


 [ 
https://issues.apache.org/jira/browse/SLING-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothée Maret closed SLING-10095.
--

> Surface latest content package extractor error as an exception 
> ---
>
> Key: SLING-10095
> URL: https://issues.apache.org/jira/browse/SLING-10095
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.6
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.22
>
>
> The 
> [ContentPackageExtractor|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/02846937fa0e07d183f50484bc68e028337c3fe5/src/main/java/org/apache/sling/distribution/journal/bookkeeper/ContentPackageExtractor.java]
>  should report its progress in the logs. This will allow to pin point exactly 
> which path is the root cause of import problems.
> FileVault allows to plug a ProgressTrackerListener for that purpose.
> We'd need to add set a progress tracker listener instance on the ImportOption 
> [here|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/02846937fa0e07d183f50484bc68e028337c3fe5/src/main/java/org/apache/sling/distribution/journal/bookkeeper/ContentPackageExtractor.java#L99]
>  and have that tracker log progress.
> To avoid flooding the logs, we may keep standard messages at debug level but 
> keep error messages at ERROR levels.
> {code}
> ImportOptions opts = new ImportOptions();
> opts.setListener(new ProgressTrackerListener() {
> @Override
> public void onMessage(Mode mode, String s, String s1) {
> log.debug(...);
> }
> @Override
> public void onError(Mode mode, String s, Exception e) {
> log.error(...);
> }
> });
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10743) Multiple instances cleaning up distribution queue at the same time and causing commit failures

2021-12-21 Thread Jira


 [ 
https://issues.apache.org/jira/browse/SLING-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothée Maret closed SLING-10743.
--

> Multiple instances cleaning up distribution queue at the same time and 
> causing commit failures
> --
>
> Key: SLING-10743
> URL: https://issues.apache.org/jira/browse/SLING-10743
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Alexei Krainiouk
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.4.8
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> There doesn't seem to be an arbitration between different server instances 
> when distribution queue cleanup is concerned. This occasionally causes commit 
> failures inside 
> org.apache.sling.distribution.packaging.impl.ResourceDistributionPackageCleanup
>  class with the folllowing exception thrown:
> {noformat}
> org.apache.sling.distribution.packaging.impl.ResourceDistributionPackageCleanup
>  Failed to delete disposable packages
> org.apache.sling.api.resource.PersistenceException: Unable to commit changes 
> to session.
> at 
> org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.commit(JcrResourceProvider.java:516)
>  [org.apache.sling.jcr.resource:3.0.22]
> at 
> org.apache.sling.resourceresolver.impl.providers.stateful.AuthenticatedResourceProvider.commit(AuthenticatedResourceProvider.java:215)
>  [org.apache.sling.resourceresolver:1.7.4]
> at 
> org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl.commit(ResourceResolverControl.java:425)
>  [org.apache.sling.resourceresolver:1.7.4]
> at 
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.commit(ResourceResolverImpl.java:1005)
>  [org.apache.sling.resourceresolver:1.7.4]
> at 
> org.apache.sling.distribution.packaging.impl.ResourceDistributionPackageCleanup.run(ResourceDistributionPackageCleanup.java:71)
>  [org.apache.sling.distribution.core:0.4.5.T202105062218-732
> 6f21]
> at 
> org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:349)
>  [org.apache.sling.commons.scheduler:2.7.12]
> at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
> [org.apache.sling.commons.scheduler:2.7.12]
> at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
> at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
> at java.base/java.lang.Thread.run(Unknown Source)
> Caused by: javax.jcr.InvalidItemStateException: OakState0001: Unresolved 
> conflicts in /var/sling/distribution/packages/signed-url/data
> at 
> org.apache.jackrabbit.oak.api.CommitFailedException.asRepositoryException(CommitFailedException.java:238)
>  [org.apache.jackrabbit.oak-api:1.39.0.R1889746]
> at 
> org.apache.jackrabbit.oak.api.CommitFailedException.asRepositoryException(CommitFailedException.java:213)
>  [org.apache.jackrabbit.oak-api:1.39.0.R1889746]
> at 
> org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.newRepositoryException(SessionDelegate.java:684)
>  [org.apache.jackrabbit.oak-jcr:1.39.0.R1889746]
> at 
> org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.save(SessionDelegate.java:505)
>  [org.apache.jackrabbit.oak-jcr:1.39.0.R1889746]
> at 
> org.apache.jackrabbit.oak.jcr.session.SessionImpl$8.performVoid(SessionImpl.java:429)
>  [org.apache.jackrabbit.oak-jcr:1.39.0.R1889746]
> at 
> org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.performVoid(SessionDelegate.java:275)
>  [org.apache.jackrabbit.oak-jcr:1.39.0.R1889746]
> at 
> org.apache.jackrabbit.oak.jcr.session.SessionImpl.save(SessionImpl.java:426) 
> [org.apache.jackrabbit.oak-jcr:1.39.0.R1889746]
> at 
> com.adobe.granite.repository.impl.CRX3SessionImpl.save(CRX3SessionImpl.java:207)
>  [com.adobe.granite.repository:1.6.128]
> at 
> org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.commit(JcrResourceProvider.java:514)
>  [org.apache.sling.jcr.resource:3.0.22]
> ... 9 common frames omitted
> Caused by: org.apache.jackrabbit.oak.api.CommitFailedException: OakState0001: 
> Unresolved conflicts in /var/sling/distribution/packages/signed-url/data
> at 
> org.apache.jackrabbit.oak.plugins.commit.ConflictValidator.failOnMergeConflict(ConflictValidator.java:115)
>  [org.apache.jackrabbit.oak-core:1.39.0.R1889746]
> at 
> org.apache.jackrabbit.oak.plugins.commit.ConflictValidator.propertyAdded(ConflictValidator.java:84)
>  [org.apache.jackrabbit.oak-core:1.39.0.R1889746]
> at 
> org.apache.jackrabbit.oak.spi.commit.CompositeEditor.propertyAdded(CompositeEdit

[jira] [Closed] (SLING-10097) Surface latest importer error as an exception

2021-12-21 Thread Jira


 [ 
https://issues.apache.org/jira/browse/SLING-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothée Maret closed SLING-10097.
--

> Surface latest importer error as an exception
> -
>
> Key: SLING-10097
> URL: https://issues.apache.org/jira/browse/SLING-10097
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.4.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The 
> [FileVaultContentSerializer|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/b80cd8f3bae6b7875387ee7caaea271b7e9baec6/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java]
>  should report its progress in the logs. This will allow to pin point exactly 
> which path is the root cause of import problems.
> FileVault allows to plug a ProgressTrackerListener for that purpose.
> We'd need to add set a progress tracker listener instance on the ImportOption 
> [here|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/b80cd8f3bae6b7875387ee7caaea271b7e9baec6/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java#L135]
>  and have that tracker log progress.
> To avoid flooding the logs, we may keep standard messages at debug level but 
> keep error messages at ERROR levels.
> {code}
> ImportOptions opts = new ImportOptions();
> opts.setListener(new ProgressTrackerListener() {
> @Override
> public void onMessage(Mode mode, String s, String s1) {
> log.debug(...);
> }
> @Override
> public void onError(Mode mode, String s, Exception e) {
> log.error(...);
> }
> });
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-9051) Package handling should not auto save the session

2021-12-21 Thread Jira


 [ 
https://issues.apache.org/jira/browse/SLING-9051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothée Maret closed SLING-9051.
-

> Package handling should not auto save the session
> -
>
> Key: SLING-9051
> URL: https://issues.apache.org/jira/browse/SLING-9051
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Dominik Süß
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.22
>
>
> For clean transactional behavior of replication the session should not be 
> autoSaved - the ootb behavior of filevault is to autoSave the nodes all 1024 
> nodes. This behavior should be changed somehow to keep transactional integrity
> https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/0b977dbd4782291c14f4173e76ef1451568100a2/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/ContentPackageExtractor.java#L95-L97



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-9052) DistributionSubscriber is not failing correctly on OakConstraint0025

2021-12-21 Thread Jira


 [ 
https://issues.apache.org/jira/browse/SLING-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothée Maret closed SLING-9052.
-

> DistributionSubscriber is not failing correctly on  OakConstraint0025
> -
>
> Key: SLING-9052
> URL: https://issues.apache.org/jira/browse/SLING-9052
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Dominik Süß
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.22
>
>
> During the reproduction attempt of another issue a node was mistakenly 
> replicated incomplete (not satisfying the OakConstraints) leading to 
> OakConstraint0025 - this should have caused the replication to be considered 
> failed as the replicated node couldn't be written into the repository at 
> first hand - instead this caused >4000 retries within an hour until being 
> noticed.
> {code}
> *ERROR* [Queue Processor for Subscriber agent forwardSubscriber] 
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber 
> Error processing queue item
> org.apache.sling.distribution.common.DistributionException: 
> javax.jcr.nodetype.ConstraintViolationException: OakConstraint0025: 
> /etc/packages/my_packages/temptest.zip[[nt:file]]: Mandatory child node 
> jcr:content not found in a new node
>   at 
> org.apache.sling.distribution.serialization.impl.vlt.FileVaultContentSerializer.importFromStream(FileVaultContentSerializer.java:170)
>  [org.apache.sling.distribution.core:0.4.1.T201912202217-537bb57]
>   at 
> org.apache.sling.distribution.packaging.impl.InMemoryDistributionPackageBuilder.installPackageInternal(InMemoryDistributionPackageBuilder.java:119)
>  [org.apache.sling.distribution.core:0.4.1.T201912202217-537bb57]
>   at 
> org.apache.sling.distribution.packaging.impl.AbstractDistributionPackageBuilder.installPackage(AbstractDistributionPackageBuilder.java:156)
>  [org.apache.sling.distribution.core:0.4.1.T201912202217-537bb57]
>   at 
> org.apache.sling.distribution.monitor.impl.MonitoringDistributionPackageBuilder.installPackage(MonitoringDistributionPackageBuilder.java:92)
>  [org.apache.sling.distribution.core:0.4.1.T201912202217-537bb57]
>   at 
> org.apache.sling.distribution.serialization.impl.vlt.VaultDistributionPackageBuilderFactory.installPackage(VaultDistributionPackageBuilderFactory.java:340)
>  [org.apache.sling.distribution.core:0.4.1.T201912202217-537bb57]
>   at 
> org.apache.sling.distribution.journal.impl.subscriber.PackageHandler.installAddPackage(PackageHandler.java:70)
>  [org.apache.sling.distribution.journal:0.1.7.T202023011551-c372493]
>   at 
> org.apache.sling.distribution.journal.impl.subscriber.PackageHandler.apply(PackageHandler.java:53)
>  [org.apache.sling.distribution.journal:0.1.7.T202023011551-c372493]
>   at 
> org.apache.sling.distribution.journal.impl.subscriber.BookKeeper.importPackage(BookKeeper.java:153)
>  [org.apache.sling.distribution.journal:0.1.7.T202023011551-c372493]
>   at 
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber.processQueueItem(DistributionSubscriber.java:408)
>  [org.apache.sling.distribution.journal:0.1.7.T202023011551-c372493]
>   at 
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber.fetchAndProcessQueueItem(DistributionSubscriber.java:369)
>  [org.apache.sling.distribution.journal:0.1.7.T202023011551-c372493]
>   at 
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber.processQueue(DistributionSubscriber.java:353)
>  [org.apache.sling.distribution.journal:0.1.7.T202023011551-c372493]
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: javax.jcr.nodetype.ConstraintViolationException: 
> OakConstraint0025: /etc/packages/my_packages/temptest.zip[[nt:file]]: 
> Mandatory child node jcr:content not found in a new node
> {code}
> Clarification: 
> The expected behavior would be at least having the queue being blocked (which 
> happened at no point) and in the specific case retries are doomed to 
> continously fail as the package is incompatible with the target while. The 
> errormessage does spam the error.log



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10602) DistributionQueueItem's path should be correctly logged in case of success and failure

2021-12-21 Thread Jira


 [ 
https://issues.apache.org/jira/browse/SLING-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothée Maret closed SLING-10602.
--

> DistributionQueueItem's path should be correctly logged in case of success 
> and failure
> --
>
> Key: SLING-10602
> URL: https://issues.apache.org/jira/browse/SLING-10602
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.4.6
>Reporter: Mohit Arora
>Assignee: Christian Schneider
>Priority: Minor
> Fix For: Content Distribution Core 0.4.8
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> The [process method of 
> SimpleDistributionAgentQueueProcessor|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L83-L103]
>  logs debug and error logs to indicate the processing and failure of 
> individual queue items. It basically just prints the queueItem, the [toString 
> method of 
> whose|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/DistributionQueueItem.java#L67]
>  prints the info map of the item as String. But the valuemap also contains 
> some multivalue properties like paths and deepPaths, resulting in logged 
> string to look like below - 
> {noformat}[sling-default-4-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
>  org.apache.sling.distribution.agent.impl.SimpleDistributionAgent 
> [agent][bpdistributionagent0] [queue-bpdistributionagent*0] ITEM-FAIL 
> item=DistributionQueueItem{id='dstrpck-1610659801578-afcff2aa-79b4-437c-a248-8021b743ebb9',*
>  info=org.apache.sling.distribution.queue.DistributionQueueItem@891d3504 : 
> {item.id=dstrpck-1610659801578-afcff2aa-79b4-437c-a248-8021b743ebb9, 
> internal.request.startTime=1610659801558, package.size=705, request.type=ADD, 
> request.deepPaths=[Ljava.lang.String;@116219, internal.request.id=DSTRQ10, 
> request.paths=[Ljava.lang.String;@7eef9f32, 
> internal.request.user=dam-replication-service, 
> package.type=signed-url}}{noformat}
> For debug purposes it would be helpful if we can map a queueItem to an actual 
> resource through the path.
> cc - [~ashishc]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: [VOTE] Release Apache Sling Content Distribution Journal Core 0.1.22 and Content Distribution Core 0.4.8

2021-12-21 Thread Nicolas Peltier
i don't find the 2573 repo anymore

Le mar. 21 déc. 2021 à 10:20,  a écrit :

> +1
>
> David
>
> On Tue, 21 Dec 2021 at 09:19, Timothee Maret  wrote:
>
> > Anybody else keen to cast a binding vote ?
> >
> > Regards,
> >
> > Timothee
> >
> > Le ven. 17 déc. 2021 à 17:12, Timothee Maret  a
> écrit :
> >
> > > Hi,
> > >
> > > This vote includes 2 bundles
> > >
> > > 1. Content Distribution Journal Core 0.1.22
> > >
> > > We solved 3 issues in this release:
> > >
> > >https://issues.apache.org/jira/projects/SLING/versions/12350413
> > >
> > > There are still some outstanding issues:
> > >
> > >https://issues.apache.org/jira/projects/SLING/versions/12351109
> > >
> > > 2. Content Distribution Core 0.4.8
> > >
> > > We solved 3 issues in this release:
> > >
> > >https://issues.apache.org/jira/projects/SLING/versions/12349660
> > >
> > > There are still some outstanding issues:
> > >
> > >https://issues.apache.org/jira/projects/SLING/versions/12351110
> > >
> > > Staging repository:
> > >
> > >
> > https://repository.apache.org/content/repositories/orgapachesling-2573/
> > >
> > > You can use this UNIX script to download the release and verify the
> > > signatures:
> > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> > >
> > > Usage:
> > > sh check_staged_release.sh 2573 /tmp/sling-staging
> > >
> > > Please vote to approve this release:
> > >
> > >   [ ] +1 Approve the release
> > >   [ ]  0 Don't care
> > >   [ ] -1 Don't release, because ...
> > >
> > > This majority vote is open for at least 72 hours.
> > >
> >
>


Re: [VOTE] Release Apache Sling Content Distribution Journal Core 0.1.22 and Content Distribution Core 0.4.8

2021-12-21 Thread davidb
+1

David

On Tue, 21 Dec 2021 at 09:19, Timothee Maret  wrote:

> Anybody else keen to cast a binding vote ?
>
> Regards,
>
> Timothee
>
> Le ven. 17 déc. 2021 à 17:12, Timothee Maret  a écrit :
>
> > Hi,
> >
> > This vote includes 2 bundles
> >
> > 1. Content Distribution Journal Core 0.1.22
> >
> > We solved 3 issues in this release:
> >
> >https://issues.apache.org/jira/projects/SLING/versions/12350413
> >
> > There are still some outstanding issues:
> >
> >https://issues.apache.org/jira/projects/SLING/versions/12351109
> >
> > 2. Content Distribution Core 0.4.8
> >
> > We solved 3 issues in this release:
> >
> >https://issues.apache.org/jira/projects/SLING/versions/12349660
> >
> > There are still some outstanding issues:
> >
> >https://issues.apache.org/jira/projects/SLING/versions/12351110
> >
> > Staging repository:
> >
> >
> https://repository.apache.org/content/repositories/orgapachesling-2573/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2573 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
>


Re: [VOTE] Release Apache Sling Content Distribution Journal Core 0.1.22 and Content Distribution Core 0.4.8

2021-12-21 Thread Timothee Maret
Anybody else keen to cast a binding vote ?

Regards,

Timothee

Le ven. 17 déc. 2021 à 17:12, Timothee Maret  a écrit :

> Hi,
>
> This vote includes 2 bundles
>
> 1. Content Distribution Journal Core 0.1.22
>
> We solved 3 issues in this release:
>
>https://issues.apache.org/jira/projects/SLING/versions/12350413
>
> There are still some outstanding issues:
>
>https://issues.apache.org/jira/projects/SLING/versions/12351109
>
> 2. Content Distribution Core 0.4.8
>
> We solved 3 issues in this release:
>
>https://issues.apache.org/jira/projects/SLING/versions/12349660
>
> There are still some outstanding issues:
>
>https://issues.apache.org/jira/projects/SLING/versions/12351110
>
> Staging repository:
>
>https://repository.apache.org/content/repositories/orgapachesling-2573/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2573 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>


[jira] [Closed] (SLING-10926) Error Handler throws Error checking if response is Open

2021-12-21 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-10926.
--

> Error Handler throws Error checking if response is Open
> ---
>
> Key: SLING-10926
> URL: https://issues.apache.org/jira/browse/SLING-10926
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Resolver 2.8.0
>Reporter: Hakim Sadikali
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Servlets Resolver 2.9.2
>
>
> The Error handler could check to see if its open before the writer is ever 
> created, leading to a null pointer exception:
>  
> 17.11.2021 10:21:15.603 *ERROR* [[0:0:0:0:0:0:0:1] [1637162475519] GET 
> /foobar/foo HTTP/1.1] org.apache.sling.engine.impl.DefaultErrorHandler Error 
> handler failed:java.io.IOException
> java.io.IOException: Error handler failed: java.lang.NullPointerException
>     at 
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.handleError(SlingServletResolver.java:657)
>  [org.apache.sling.servlets.resolver:2.8.2]
>     at 
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.handleError(SlingServletResolver.java:320)
>  [org.apache.sling.servlets.resolver:2.8.2]
>     at 
> org.apache.sling.engine.impl.DefaultErrorHandler.handleError(DefaultErrorHandler.java:97)
>  [org.apache.sling.engine:2.7.10]
>     at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl$1.render(SlingRequestProcessorImpl.java:346)
>  [org.apache.sling.engine:2.7.10]
>     at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:88)
>  [org.apache.sling.engine:2.7.10]
>     at 
> org.apache.sling.rewriter.impl.RewriterFilter.doFilter(RewriterFilter.java:87)
>  [org.apache.sling.rewriter:1.2.2]
>     at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>  [org.apache.sling.engine:2.7.10]
>     at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131) 
> [org.apache.sling.i18n:2.5.14]
>     at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>  [org.apache.sling.engine:2.7.10]
>     at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.handleError(SlingRequestProcessorImpl.java:353)
>  [org.apache.sling.engine:2.7.10]
>     at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:167)
>  [org.apache.sling.engine:2.7.10]
>     at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:250)
>  [org.apache.sling.engine:2.7.10]
>     at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:123)
>  [org.apache.felix.http.jetty:4.1.12]
>     at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>  [org.apache.felix.http.jetty:4.1.12]
>     at 
> com.adobe.granite.metrics.knownerrors.impl.ReportingRequestFilter.doFilter(ReportingRequestFilter.java:87)
>  [com.adobe.granite.metrics.knownerrors:0.0.22]
>     at 
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:142)
>  [org.apache.felix.http.jetty:4.1.12]
>     at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
>  [org.apache.felix.http.jetty:4.1.12]
>     at com.adobe.granite.cors.impl.CORSFilter.doFilter(CORSFilter.java:87) 
> [com.adobe.granite.cors:1.0.20]
>     at 
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:142)
>  [org.apache.felix.http.jetty:4.1.12]
>     at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
>  [org.apache.felix.http.jetty:4.1.12]
>     at 
> com.adobe.granite.license.impl.http.LicenseCheckFilter.doFilter(LicenseCheckFilter.java:301)
>  [com.adobe.granite.license.http:1.0.0]
>     at 
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:142)
>  [org.apache.felix.http.jetty:4.1.12]
>     at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
>  [org.apache.felix.http.jetty:4.1.12]
>     at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131) 
> [org.apache.sling.i18n:2.5.14]
>     at 
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:142)
>  [org.apache.felix.http.jetty:4.1.12]
>     at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
>  [org.apache.felix.http.jetty:4.1.12]
>     at 
> org.apache.sling.featureflags.impl.FeatureManager.doFilter(FeatureManager.java:116)
>  [org.apache.sling.featureflags:1.2.2]
>     at 
> org.apache.

[jira] [Closed] (SLING-11014) Update to Apache Felix Framework 7.0.3

2021-12-21 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-11014.
--

> Update to Apache Felix Framework 7.0.3
> --
>
> Key: SLING-11014
> URL: https://issues.apache.org/jira/browse/SLING-11014
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Affects Versions: Launchpad Base 2.7.4
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Launchpad Base 2.7.6
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Update to Apache Felix Framework 7.0.3



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10323) [container] feature-launcher switch base image to jre

2021-12-21 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-10323.
--

> [container] feature-launcher switch base image to jre
> -
>
> Key: SLING-10323
> URL: https://issues.apache.org/jira/browse/SLING-10323
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Stefan Bischof
>Assignee: Karl Pauls
>Priority: Minor
> Fix For: Feature Model Launcher 1.1.28
>
>
> Switch Base-Image of the feature-launcher-container from
> adoptopenjdk/openjdk11:alpine-slim
>  to
>  adoptopenjdk/openjdk11:alpine-jre
> https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26
> h1.  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10939) Don't register precompiled scripts that are missing

2021-12-21 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-10939.
--

> Don't register precompiled scripts that are missing
> ---
>
> Key: SLING-10939
> URL: https://issues.apache.org/jira/browse/SLING-10939
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting, Servlets
>Affects Versions: Scripting Core 2.4.0, Servlets Resolver 2.9.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Scripting Core 2.4.2, Servlets Resolver 2.9.2
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> When a bundle provides resource type capabilities for scripts that turn out 
> to be missing an executable from the bundle (or can't be loaded) there is a 
> case where if the resource type extends another resource type it is possible 
> that a parent script is found. 
> When the resource type wasn't based on a script in the bundle, then this 
> should cause a registration of the parent script (and it does) - however, 
> when it was based on a script in the bundle, it shouldn't be registered (but 
> it is).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10934) Bundled scripts in the form of .. override the Sling POST Servlet

2021-12-21 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-10934.
--

> Bundled scripts in the form of .. override 
> the Sling POST Servlet
> ---
>
> Key: SLING-10934
> URL: https://issues.apache.org/jira/browse/SLING-10934
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes, Scripting, Servlets
>Affects Versions: Scripting Core 2.4.0, Servlets Resolver 2.9.0, Scripting 
> Bundle Maven Plugin 0.5.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Scripting Core 2.4.2, Scripting Bundle Maven Plugin 0.5.2
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, it is not really possible using bundled scripts to provide a 
> script for a resource label with an HTTP method and at the same time a script 
> for only the HTTP method. Furthermore, when providing the former, there is a 
> small difference in precedence compared to scripts provided via the resource 
> tree.
> In other words, it should be possible to have (for a given resource type, 
> e.g. {{{}foo{}}}) a {{foo/POST.jsp}} and as well as a {{foo/foo.POST.jsp}} 
> and they should have the same matching and priority like scripts provided via 
> the resource tree.
> On the metadata level, this can be achieved by just adding the resource label 
> as a selector to the resulting capability but to make it work at runtime, we 
> need to add a match to the bundle render unit lookup.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10927) NPE in ResolutionCache when the Service is modified

2021-12-21 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-10927.
--

> NPE in ResolutionCache when the Service is modified
> ---
>
> Key: SLING-10927
> URL: https://issues.apache.org/jira/browse/SLING-10927
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Servlets Resolver 2.9.0
>Reporter: Ahmed Musallam
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Servlets Resolver 2.9.2
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In version 2.8.2 of the Servlet Resolver, an NPE is thrown here:
> [https://github.com/apache/sling-org-apache-sling-servlets-resolver/blob/org.apache.sling.servlets.resolver-2.8.2/src/main/java/org/apache/sling/servlets/resolver/internal/resolution/ResolutionCache.java#L98]
> When the component is modified.
> since `cache` member is set to null on deactivate here: 
> [https://github.com/apache/sling-org-apache-sling-servlets-resolver/blob/org.apache.sling.servlets.resolver-2.8.2/src/main/java/org/apache/sling/servlets/resolver/internal/resolution/ResolutionCache.java#L157]
>  
> looking at the code in version 2.9.0 the issue persist there as well./



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10887) Optionally allow osgi dependencies provided by a feature

2021-12-21 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-10887.
--

> Optionally allow osgi dependencies provided by a feature
> 
>
> Key: SLING-10887
> URL: https://issues.apache.org/jira/browse/SLING-10887
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: JSPC Maven Plugin 2.3.2
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> When using the jspc-maven-plugin to compile against osgi bundles the current 
> way of just adding them as dependencies doesn't work very well as bundles can 
> have embedded jar files (which then don't show up on the real class path) and 
> obviously, just because a bundle contains a package doesn't mean it exports 
> it. 
> It would be good if we could give the jspc-maven-plugin a feature and it 
> would, in turn, load the classes from the resolved bundles of the feature. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10826) Update to Felix Framework 7.0.1

2021-12-21 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-10826.
--

> Update to Felix Framework 7.0.1
> ---
>
> Key: SLING-10826
> URL: https://issues.apache.org/jira/browse/SLING-10826
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Launcher 1.1.28
>
>
> We should pick up on the fixes - 
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20FELIX%20AND%20fixVersion%20%3D%20framework-7.0.1
>  , mostly for Java 17 support.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10956) Create assembly for feature launcher

2021-12-21 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-10956.
--

> Create assembly for feature launcher
> 
>
> Key: SLING-10956
> URL: https://issues.apache.org/jira/browse/SLING-10956
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Launcher 1.1.26
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Launcher 1.1.28
>
>
> The launcher can be extended with service loader based class path extenders. 
> That makes it tricky to have it inline its dependencies (especially 
> conditionally) as the extenders might have dependencies as well. 
> I think we should provide the launcher as an assembly so that we can have the 
> launcher jar only contain the launcher classes and provide a zip file with 
> everything included. 
> That way, one can drop in extensions (and their dependencies) into the libs 
> dir and manage the dependencies if required.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10723) Update to Apache Johnzon 1.2.14

2021-12-21 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-10723.
--

> Update to Apache Johnzon 1.2.14
> ---
>
> Key: SLING-10723
> URL: https://issues.apache.org/jira/browse/SLING-10723
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Launcher 1.1.22, slingfeature-maven-plugin 
> 1.5.12, Content-Package to Feature Model Converter 1.1.8, Feature Model API 
> Regions Extension 1.3.10, Feature Model Analyser 1.3.34, Feature Model 
> 1.2.30, Commons Johnzon 1.2.14
>
>
> It seems we have different versions of the johnzon library in various feature 
> model related projects. In order to get bug fixes/improvements included we 
> should update all of them to the latest version 1.2.14



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-10867) The launcher should fail fast when it can't create parent directories for the application feature file

2021-12-21 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-10867.
--

> The launcher should fail fast when it can't create parent directories for the 
> application feature file
> --
>
> Key: SLING-10867
> URL: https://issues.apache.org/jira/browse/SLING-10867
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Launcher 1.1.28
>
>
> When the parent directories can't be created the problem is silently ignored. 
> It will fail immediately later when trying to create the application feature 
> file but the cause will be less clear.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (SLING-11015) Update to Felix Framework 7.0.3

2021-12-21 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-11015.
--

> Update to Felix Framework 7.0.3
> ---
>
> Key: SLING-11015
> URL: https://issues.apache.org/jira/browse/SLING-11015
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Launcher 1.1.28
>
>
> Update to Felix Framework 7.0.3



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: [RESULT| [VOTE] Release Apache Sling Commons Johnzon 1.2.14, Feature Model Launcher 1.1.28, Launchpad Base 2.7.6, Servlets Resolver 2.9.2, Scripting Core 2.4.2, Scripting Bundle Maven Plugin 0.5.2

2021-12-21 Thread Karl Pauls
Time to call the vote on the Apache Sling Commons Johnzon 1.2.14,
Feature Model Launcher 1.1.28, Launchpad Base 2.7.6, Servlets Resolver
2.9.2, Scripting Core 2.4.2, Scripting Bundle Maven Plugin 0.5.2, and
JSPC Maven Plugin 2.3.2 releases.

* +1 votes from Carsten Ziegeler, David Bosschaert, Stefan Seifert,
Radu Cotescu, and Karl Pauls.

* No other votes.

The vote is successful. I will make the artifacts available as soon as possible.


Re: [VOTE] Release Apache Sling Commons Johnzon 1.2.14, Feature Model Launcher 1.1.28, Launchpad Base 2.7.6, Servlets Resolver 2.9.2, Scripting Core 2.4.2, Scripting Bundle Maven Plugin 0.5.2, and JSP

2021-12-21 Thread Karl Pauls
+1

regards,

Karl

On Fri, Dec 17, 2021 at 5:56 PM  wrote:
>
> +1
>
> David
>
> On Fri, 17 Dec 2021 at 15:12, Radu Cotescu  wrote:
>
> > +1
> >
> > > On 16 Dec 2021, at 15:14, Karl Pauls  wrote:
> > >
> > > Please vote to approve these releases:
> > >
> > >   [ ] +1 Approve the release
> > >   [ ]  0 Don't care
> > >   [ ] -1 Don't release, because ...
> >
> >



-- 
Karl Pauls
karlpa...@gmail.com