[jira] [Resolved] (SLING-11080) CMS - Support Java 11 / 17
[ https://issues.apache.org/jira/browse/SLING-11080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-11080. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/27ef20b062cf4c1703ffb274d715737dc38d90e3 > CMS - Support Java 11 / 17 > -- > > Key: SLING-11080 > URL: https://issues.apache.org/jira/browse/SLING-11080 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: App CMS 1.1.2 > > > Sling CMS is currently built with Java 8 and runs on Java 11 but does not > build on Java 11 or 17. > Given that Java 8 has had it's final public release, and there are already > two LTS releases for Java available (11/17), let's deprecate support for Java > 8 in the CMS and target builds for 11 and 17. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #871 is BROKEN
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/871/ for details. No further emails will be sent until the status of the build is changed. Build log follows below: [...truncated 383 lines...] [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.scripting.htl.HtlTest [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.214 s - in org.apache.sling.launchpad.webapp.integrationtest.scripting.htl.HtlTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.installer.ServerSideInstallerTest [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.964 s - in org.apache.sling.launchpad.webapp.integrationtest.installer.ServerSideInstallerTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.MkdirTest [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.198 s - in org.apache.sling.launchpad.webapp.integrationtest.MkdirTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.PrefixTest [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.403 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.PrefixTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletAtCopyTest [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.554 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletAtCopyTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.JsonRenderingTest [INFO] Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.189 s - in org.apache.sling.launchpad.webapp.integrationtest.JsonRenderingTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.ScriptBindingsValuesProviderTest [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.651 s - in org.apache.sling.launchpad.webapp.integrationtest.ScriptBindingsValuesProviderTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.MiscUnsafeTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s - in org.apache.sling.launchpad.webapp.integrationtest.MiscUnsafeTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.WebdavDeleteTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.186 s - in org.apache.sling.launchpad.webapp.integrationtest.WebdavDeleteTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.HtmlDefaultServletTest [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.697 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.HtmlDefaultServletTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletCopyTest [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.548 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletCopyTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.GetWithSuffixTest [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.422 s - in org.apache.sling.launchpad.webapp.integrationtest.GetWithSuffixTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.DavExIntegrationTest [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.959 s - in org.apache.sling.launchpad.webapp.integrationtest.DavExIntegrationTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.035 s - in org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.InitialContentTest [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.04 s - in org.apache.sling.launchpad.webapp.integrationtest.InitialContentTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.PutMethodServletTest [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.29 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.PutMethodServletTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletDeleteParentTest [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.323 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletDeleteParentTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.EventsCounterTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.045 s - in org.apache.sling.launchpad.webapp.integrationtest.EventsCounterTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.VersionInfoServletTest [INFO] Tests run: 3, Fai
[jira] [Created] (SLING-11080) CMS - Support Java 11 / 17
Dan Klco created SLING-11080: Summary: CMS - Support Java 11 / 17 Key: SLING-11080 URL: https://issues.apache.org/jira/browse/SLING-11080 Project: Sling Issue Type: Improvement Components: App CMS Affects Versions: App CMS 1.1.0 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 1.1.2 Sling CMS is currently built with Java 8 and runs on Java 11 but does not build on Java 11 or 17. Given that Java 8 has had it's final public release, and there are already two LTS releases for Java available (11/17), let's deprecate support for Java 8 in the CMS and target builds for 11 and 17. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #55: SLING-11077: improve logging of JCR queries
sonarcloud[bot] commented on pull request #55: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#issuecomment-1017934183 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_coverage&view=list) [72.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #55: SLING-11077: improve logging of JCR queries
sonarcloud[bot] removed a comment on pull request #55: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#issuecomment-1017924835 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_coverage&view=list) [71.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #55: SLING-11077: improve logging of JCR queries
sonarcloud[bot] commented on pull request #55: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#issuecomment-1017924835 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_coverage&view=list) [71.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #55: SLING-11077: improve logging of JCR queries
sonarcloud[bot] removed a comment on pull request #55: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#issuecomment-1017542895 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11078) Repoinit Parser - Describe and Validate Operation.asRepoInitString() Format
[ https://issues.apache.org/jira/browse/SLING-11078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479661#comment-17479661 ] Dan Klco commented on SLING-11078: -- Pull request created: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16 > Repoinit Parser - Describe and Validate Operation.asRepoInitString() Format > --- > > Key: SLING-11078 > URL: https://issues.apache.org/jira/browse/SLING-11078 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.10 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Repoinit Parser 1.6.12 > > Time Spent: 20m > Remaining Estimate: 0h > > There's no JavaDoc for Operation.asRepoInitString(), however all of the other > operations follow the convention of using an OS-agnostic line separator at > the end of the statement and this would seem like a reasonable safety measure > for generating scripts. > We should clarify the intended format in the JavaDoc and add a test to verify > the behavior. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #16: SLING-11078 - Describe and Validate asRepoInitString Line Separator Requirement
sonarcloud[bot] commented on pull request #16: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16#issuecomment-1017878764 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] klcodanr opened a new pull request #16: SLING-11078 - Describe and Validate asRepoInitString Line Separator Requirement
klcodanr opened a new pull request #16: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16 ## Changes - Resolves the regression introduced with SLING-10952 where DeleteGroup.asRepoInitString() no longer has a newline - Adds JavaDoc to describe the intended format for the Operation.asRepoInitString() representation - Add a new method to the ParserTestCase to get a supplier of test cases as the ParserTestCase objects are not reusable for multiple tests within a parameterized test - Adds a test to check the presence of a line separator in the representation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a change in pull request #55: SLING-11077: improve logging of JCR queries
reschke commented on a change in pull request #55: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#discussion_r789062101 ## File path: src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java ## @@ -78,8 +78,6 @@ private static final int VANITY_BLOOM_FILTER_MAX_ENTRIES = 1000; -private final Logger logger = LoggerFactory.getLogger(MapEntries.class); Review comment: I agree in principal. Is there a convention within Sling for this? (I prefer uppercasing to "LOG" in that case). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11079) models-caconfig: Lower log level to debug for message "Injection only supported using @ContextAwareConfiguration annotation"
[ https://issues.apache.org/jira/browse/SLING-11079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-11079. Resolution: Fixed https://github.com/apache/sling-org-apache-sling-models-caconfig/commit/7f3e680ed66c883eace8a42564a6356469f4531e > models-caconfig: Lower log level to debug for message "Injection only > supported using @ContextAwareConfiguration annotation" > > > Key: SLING-11079 > URL: https://issues.apache.org/jira/browse/SLING-11079 > Project: Sling > Issue Type: Improvement > Components: Sling Models >Affects Versions: Models Context-Aware Configuration 1.0.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Minor > Fix For: Models Context-Aware Configuration 1.0.2 > > > the injector is triggered also when no injector is specified with @Inject and > should not log a warning in this case. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11079) models-caconfig: Lower log level to debug for message "Injection only supported using @ContextAwareConfiguration annotation"
Stefan Seifert created SLING-11079: -- Summary: models-caconfig: Lower log level to debug for message "Injection only supported using @ContextAwareConfiguration annotation" Key: SLING-11079 URL: https://issues.apache.org/jira/browse/SLING-11079 Project: Sling Issue Type: Improvement Components: Sling Models Affects Versions: Models Context-Aware Configuration 1.0.0 Reporter: Stefan Seifert Assignee: Stefan Seifert Fix For: Models Context-Aware Configuration 1.0.2 the injector is triggered also when no injector is specified with @Inject and should not log a warning in this case. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11078) Repoinit Parser - Describe and Validate Operation.asRepoInitString() Format
Dan Klco created SLING-11078: Summary: Repoinit Parser - Describe and Validate Operation.asRepoInitString() Format Key: SLING-11078 URL: https://issues.apache.org/jira/browse/SLING-11078 Project: Sling Issue Type: Improvement Components: Repoinit Affects Versions: Repoinit Parser 1.6.10 Reporter: Dan Klco Assignee: Dan Klco Fix For: Repoinit Parser 1.6.12 There's no JavaDoc for Operation.asRepoInitString(), however all of the other operations follow the convention of using an OS-agnostic line separator at the end of the statement and this would seem like a reasonable safety measure for generating scripts. We should clarify the intended format in the JavaDoc and add a test to verify the behavior. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-resourceresolver] cziegeler commented on a change in pull request #55: SLING-11077: improve logging of JCR queries
cziegeler commented on a change in pull request #55: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#discussion_r788831321 ## File path: src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java ## @@ -78,8 +78,6 @@ private static final int VANITY_BLOOM_FILTER_MAX_ENTRIES = 1000; -private final Logger logger = LoggerFactory.getLogger(MapEntries.class); Review comment: I doubt that there is a difference if you have a singleton anyway -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] kwin commented on a change in pull request #55: SLING-11077: improve logging of JCR queries
kwin commented on a change in pull request #55: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#discussion_r788831015 ## File path: src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java ## @@ -78,8 +78,6 @@ private static final int VANITY_BLOOM_FILTER_MAX_ENTRIES = 1000; -private final Logger logger = LoggerFactory.getLogger(MapEntries.class); Review comment: sorry, both loggers are currently non static, I suggest to make this one static -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] kwin commented on a change in pull request #55: SLING-11077: improve logging of JCR queries
kwin commented on a change in pull request #55: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#discussion_r788829989 ## File path: src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java ## @@ -78,8 +78,6 @@ private static final int VANITY_BLOOM_FILTER_MAX_ENTRIES = 1000; -private final Logger logger = LoggerFactory.getLogger(MapEntries.class); Review comment: for performance reasons :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] cziegeler commented on a change in pull request #55: SLING-11077: improve logging of JCR queries
cziegeler commented on a change in pull request #55: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#discussion_r788829278 ## File path: src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java ## @@ -78,8 +78,6 @@ private static final int VANITY_BLOOM_FILTER_MAX_ENTRIES = 1000; -private final Logger logger = LoggerFactory.getLogger(MapEntries.class); Review comment: Why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh commented on a change in pull request #55: SLING-11077: improve logging of JCR queries
joerghoh commented on a change in pull request #55:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#discussion_r788826776
##
File path:
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java
##
@@ -838,20 +836,22 @@ private static String
escapeIllegalXpathSearchChars(String s) {
Map> entryMap = new HashMap<>();
-// sling:vanityPath (lowercase) is the property name
+// sling:vanityPath (lowercase) is the property name
final String queryString = "SELECT sling:vanityPath, sling:redirect,
sling:redirectStatus" +
" FROM nt:base" +
" WHERE NOT isdescendantnode('" + JCR_SYSTEM_PATH + "') and (" +
"sling:vanityPath
='"+escapeIllegalXpathSearchChars(vanityPath).replaceAll("'", "''")+"'" +
" OR sling:vanityPath ="+
"'"+escapeIllegalXpathSearchChars(vanityPath.substring(1)).replaceAll("'",
"''")+"'" +
") ORDER BY sling:vanityOrder DESC";
-ResourceResolver queryResolver = null;
-
-try {
-queryResolver =
factory.getServiceResourceResolver(factory.getServiceUserAuthenticationInfo("mapping"));
+try (ResourceResolver queryResolver =
factory.getServiceResourceResolver(factory.getServiceUserAuthenticationInfo("mapping"));)
{
+long count = 0;
+long valid = 0;
Review comment:
I would suggest to name them ```countTotal``` and ```countValid```.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] kwin commented on a change in pull request #55: SLING-11077: improve logging of JCR queries
kwin commented on a change in pull request #55: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#discussion_r788822037 ## File path: src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java ## @@ -78,8 +78,6 @@ private static final int VANITY_BLOOM_FILTER_MAX_ENTRIES = 1000; -private final Logger logger = LoggerFactory.getLogger(MapEntries.class); Review comment: shouldn't we rather get rid of the non-static logger? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #55: SLING-11077: improve logging of JCR queries
sonarcloud[bot] commented on pull request #55: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#issuecomment-1017542895 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=55&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11077) improve logging of JCR queries
[ https://issues.apache.org/jira/browse/SLING-11077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479391#comment-17479391 ] Julian Reschke commented on SLING-11077: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55 > improve logging of JCR queries > -- > > Key: SLING-11077 > URL: https://issues.apache.org/jira/browse/SLING-11077 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver >Affects Versions: Resource Resolver 1.8.2 >Reporter: Julian Reschke >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-resourceresolver] reschke opened a new pull request #55: SLING-11077: improve logging of JCR queries
reschke opened a new pull request #55: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55 (also get rid of duplicate logger) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11077) improve logging of JCR queries
Julian Reschke created SLING-11077: -- Summary: improve logging of JCR queries Key: SLING-11077 URL: https://issues.apache.org/jira/browse/SLING-11077 Project: Sling Issue Type: Improvement Components: ResourceResolver Affects Versions: Resource Resolver 1.8.2 Reporter: Julian Reschke -- This message was sent by Atlassian Jira (v8.20.1#820001)
Re: Marking issues to attract new contributors
On Thu, Jan 20, 2022 at 10:11 AM Dirk Rudolph wrote: >...Regarding the naming, we may want to adapt the naming > Github uses for that: "good-first-issue".. +1 -Bertrand
Re: Marking issues to attract new contributors
Hi Jörg, I like the idea! Regarding the naming, we may want to adapt the naming Github uses for that: "good-first-issue" https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels#about-default-labels Maybe we will even find a way to make it into services like goodfirstissue.dev . Dirk On Thu, 20 Jan 2022 at 10:03, Jörg Hoh wrote: > > Hi, > > I plan to create a few SLING issues which replicate the changes of > https://issues.apache.org/jira/browse/SLING-11025 to other parts of the > Sling codebase. These changes would be straight forward and not hard to do > (we have a working sample plus the documentation for it already available). > I think that these issues would be a good starter for people getting > involved in Sling (and maybe Apache at all). > > But I think that we have more of such tickets, which are probably neither > hard nor that important for us as a community, but which can act as a > perfect starting point into Sling. > > I suggest that we mark these tickets with a label "slingBeginner" (much > appreciated if you can come up with a better name) and add a new section to > https://sling.apache.org/documentation/getting-started.html which outlines > how you can get involved into the development part of Sling. > > I have some reach on social media into the wider AEM community. I hope to > attract a few contributions from that side, if we can explicitly point out > an easy way to get involved. > > > WDYT? > Jörg > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh
Marking issues to attract new contributors
Hi, I plan to create a few SLING issues which replicate the changes of https://issues.apache.org/jira/browse/SLING-11025 to other parts of the Sling codebase. These changes would be straight forward and not hard to do (we have a working sample plus the documentation for it already available). I think that these issues would be a good starter for people getting involved in Sling (and maybe Apache at all). But I think that we have more of such tickets, which are probably neither hard nor that important for us as a community, but which can act as a perfect starting point into Sling. I suggest that we mark these tickets with a label "slingBeginner" (much appreciated if you can come up with a better name) and add a new section to https://sling.apache.org/documentation/getting-started.html which outlines how you can get involved into the development part of Sling. I have some reach on social media into the wider AEM community. I hope to attract a few contributions from that side, if we can explicitly point out an easy way to get involved. WDYT? Jörg -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[jira] [Assigned] (SLING-10128) Document feature per language version
[ https://issues.apache.org/jira/browse/SLING-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-10128: --- Assignee: (was: Konrad Windszus) > Document feature per language version > - > > Key: SLING-10128 > URL: https://issues.apache.org/jira/browse/SLING-10128 > Project: Sling > Issue Type: Improvement > Components: Documentation, Repoinit >Reporter: Konrad Windszus >Priority: Major > Attachments: RepoInitGrammar.html > > > Although with SLING-9186 the repoinit has been properly versioned (starting > with 8.0) there is currently no overview which language version supports > which feature on > https://sling.apache.org/documentation/bundles/repository-initialization.html. > Also the behaviour of parsing a non-supported feature should be clearly > described. -- This message was sent by Atlassian Jira (v8.20.1#820001)
