[VOTE] Release Apache Sling Security version 1.1.24
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12351306 There are no outstanding issues. Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2601 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2601 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Kind regards Angela
[GitHub] [sling-org-apache-sling-models-impl] kwin commented on pull request #34: SLING-11132 - Exception handling while clearing OSGiServiceReferences
kwin commented on pull request #34: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/34#issuecomment-1039961865 As @cziegeler confirmed that there will be no dangling service references I am fine with the approach taken in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-models-impl] sagarmiglani commented on pull request #34: SLING-11132 - Exception handling while clearing OSGiServiceReferences
sagarmiglani commented on pull request #34: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/34#issuecomment-1039951823 > According to the bug description it seems much better to just add a deactivate method in the injector and do a proper cleanup there. Hi @kwin, Could you please clarify above point. How should I do clean up in the `deactivate` method of injector? These service references are stored by `ModelAdapterFactory` and also being cleaned up (along with the scheduled job) in its `deactivate` method. Also, AFAIU `deactivate` method will be called before the component will be deactivated and I believe these service references are supposed to be cleaned up regularly which is already the case with a scheduled job trigger. I have just added try catch block which will allow the iteration in above code to complete in current job trigger. Can you please have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11140) Update bundles referenced in sling starter to the latest releases
[
https://issues.apache.org/jira/browse/SLING-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman resolved SLING-11140.
-
Resolution: Fixed
Merged PR at:
[{{6a6d220}}|https://github.com/apache/sling-org-apache-sling-starter/commit/6a6d2209db1b67fbbdf56a2ecf7b36a8ec53b80e]
> Update bundles referenced in sling starter to the latest releases
> -
>
> Key: SLING-11140
> URL: https://issues.apache.org/jira/browse/SLING-11140
> Project: Sling
> Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Starter 12
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Update the sling starter to use the latest bundles - according to
> {code:java}
> mvn versions:display-dependency-updates{code}
> the sling starter is a bit out of date with the dependencies
> {noformat}
> [INFO] The following dependencies in Dependencies have newer versions:
> [INFO] com.composum.nodes:composum-nodes-commons . 3.1.0 ->
> 4.0.1
> [INFO] com.composum.nodes:composum-nodes-console . 3.1.0 ->
> 4.0.1
> [INFO] com.composum.nodes:composum-nodes-jslibs .. 3.1.0 ->
> 4.0.1
> [INFO] com.composum.nodes:composum-nodes-pckgmgr . 3.1.0 ->
> 4.0.1
> [INFO] com.composum.nodes:composum-nodes-usermgr . 3.1.0 ->
> 4.0.1
> [INFO] com.fasterxml.jackson.core:jackson-annotations .. 2.13.0 ->
> 2.13.1
> [INFO] com.fasterxml.jackson.core:jackson-core . 2.13.0 ->
> 2.13.1
> [INFO] com.fasterxml.jackson.core:jackson-databind . 2.13.0 ->
> 2.13.1
> ...
> [INFO] org.apache.felix:org.apache.felix.configadmin.plugin.interpolation
> ...
> [INFO] 1.1.2 ->
> 1.2.2
> [INFO] org.apache.felix:org.apache.felix.healthcheck.core ...
> [INFO] 2.0.10 ->
> 2.0.12
> ...
> [INFO] org.apache.felix:org.apache.felix.http.jetty 4.1.12 ->
> 4.1.14
> [INFO] org.apache.httpcomponents:httpcore-osgi . 4.4.14 ->
> 4.4.15
> [INFO] org.apache.pdfbox:fontbox ... 2.0.24 ->
> 2.0.25
> [INFO] org.apache.pdfbox:pdfbox 2.0.24 ->
> 2.0.25
> [INFO] org.apache.servicemix.bundles:org.apache.servicemix.bundles.ognl ...
> [INFO] 3.2.18_1 ->
> 3.3.2_1
> [INFO] org.apache.servicemix.bundles:org.apache.servicemix.bundles.rhino ...
> [INFO] 1.7.13_1 ->
> 1.7.14_1
> [INFO]
> org.apache.servicemix.bundles:org.apache.servicemix.bundles.thymeleaf ...
> [INFO] 3.0.12.RELEASE_1 ->
> 3.0.14.RELEASE_1
> [INFO] org.apache.sling:org.apache.sling.commons.johnzon 1.2.6 ->
> 1.2.14
> [INFO] org.apache.sling:org.apache.sling.commons.log . 5.3.0 ->
> 5.4.0
> [INFO] org.apache.sling:org.apache.sling.commons.metrics 1.2.8 ->
> 1.2.10
> [INFO] org.apache.sling:org.apache.sling.event . 4.2.20 ->
> 4.2.24
> [INFO] org.apache.sling:org.apache.sling.fsresource . 2.1.16 ->
> 2.2.0
> [INFO] org.apache.sling:org.apache.sling.i18n .. 2.5.16 ->
> 2.5.18
> [INFO] org.apache.sling:org.apache.sling.installer.core 3.11.4 ->
> 3.12.0
> [INFO] org.apache.sling:org.apache.sling.installer.factory.configuration ...
> [INFO] 1.3.4 ->
> 1.4.2
> [INFO] org.apache.sling:org.apache.sling.javax.activation 0.2.0 ->
> 0.3.0
> [INFO] org.apache.sling:org.apache.sling.jcr.base ... 3.1.6 ->
> 3.1.10
> [INFO] org.apache.sling:org.apache.sling.models.validation-impl ...
> [INFO] 1.0.0 ->
> 1.1.0
> [INFO] org.apache.sling:org.apache.sling.repoinit.parser ... 1.6.10 ->
> 1.6.12
> [INFO] org.apache.sling:org.apache.sling.resourceresolver 1.8.0 ->
> 1.8.4
> [INFO] org.apache.sling:org.apache.sling.scripting.core .. 2.3.6 ->
> 2.4.2
> [INFO] org.apache.sling:org.apache.sling.scripting.jsp ... 2.5.2 ->
> 2.5.4
> [INFO] org.apache.sling:org.apache.sling.scripting.sightly ...
> [INFO] 1.4.14-1.4.0 ->
> 1.4.16-1.4.0
> [INFO] org.apache.sling:org.apache.sling.servlets.get .. 2.1.40 ->
> 2.1.44
> [INFO] org.apache.sling:org.apache.sling.servlets.resolver ... 2.9.0 ->
> 2.9.2
> [INFO] org.apache.tika:tika-core .. 1.27 ->
> 1.28.1
> [INFO] org.apache.tika:tika-parsers ... 1.27 ->
> 1.28.1
> [INFO] org.javassist:javassist ... 3.27.0-GA ->
> 3.28.0-G
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #917 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/917/ for details. No further emails will be sent until the status of the build is changed.
[jira] [Assigned] (SLING-9640) Document 'official' way of launching the Sling starter
[ https://issues.apache.org/jira/browse/SLING-9640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-9640: -- Assignee: Robert Munteanu > Document 'official' way of launching the Sling starter > -- > > Key: SLING-9640 > URL: https://issues.apache.org/jira/browse/SLING-9640 > Project: Sling > Issue Type: Sub-task > Components: Documentation, Site >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > > Right now we recommend downloading the feature launcher and then using it to > launch the starter aggregate. We should decide what the recommended way to do > that is. Some options: > - download feature launcher + launch local or remote feature file/archive > - kickstart jar > - starter docker image > - feature launcher docker image + local or remote feature file/archive -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-10409) Update to Felix 7 (OSGi Core R8)
[ https://issues.apache.org/jira/browse/SLING-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-10409. - Assignee: Robert Munteanu Resolution: Fixed > Update to Felix 7 (OSGi Core R8) > > > Key: SLING-10409 > URL: https://issues.apache.org/jira/browse/SLING-10409 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Robert Munteanu >Priority: Major > Fix For: Starter 12 > > > We are still relying on Felix 6 which is only compliant with OSGi Core R7. We > should upgrade to Felix 7. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #916 is BROKEN
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/916/ for details. No further emails will be sent until the status of the build is changed. Build log follows below: [...truncated 3580 lines...] ESP template Text A 1644877150745 Forced resource type:ForwardTest/1644877150792. --javax.servlet.include.request_uri- --javax.servlet.include.context_path- --javax.servlet.include.servlet_path- --javax.servlet.include.path_info- -no-javax.servlet.include.query_string- --javax.servlet.include.request_uri- --javax.servlet.include.request_uri- --org.apache.sling.api.include.servlet- --org.apache.sling.api.include.resource- --org.apache.sling.api.include.request_path_info- Test 4 Test 5 Test 6 Test 7 ) [ERROR] ForwardTest.testWithForwardAndExtension:119 Content includes ESP marker [ERROR] ForwardTest.testWithoutForward:104 Content includes ESP marker [ERROR] GetWithSuffixTest.testGETScript:64 Content includes ESP marker [ERROR] NodetypeRenderingTest.testEspHtml:87->RenderingTestBase.assertContains:36 Content does not contain 'ESP template' (content= JSP template This is a test 1644877151176 Test 1 Test 2 Test 3 Test 4 Test 5 Test 6 Test 7 ) [ERROR] NodetypeRenderingTest.testMiniScriptHtml:66 expected:<[There's no code in this script, just this constant string]> but was:<[ JSP template This is a test 1644877151583 Test 1 Test 2 Test 3 Test 4 Test 5 Test 6 Test 7 ]> [ERROR] NodetypeRenderingTest.testPrint:77->RenderingTestBase.assertContains:36 Content does not contain 'print.esp ends' (content= JSP template This is a test 1644877151371 Test 1 Test 2 Test 3 Test 4 Test 5 Test 6 Test 7 ) [ERROR] NodetypeRenderingTest.testWithoutScriptHtml:59->RenderingTestBase.assertContains:36 Content does not contain 'dumped by HtmlRenderer' (content= JSP template This is a test 1644877151250 Test 1 Test 2 Test 3 Test 4 Test 5 Test 6 Test 7 ) [ERROR] FullTextIndexingTest.testUploadedPdfIsIndexed:95 Upload status code expected:<201> but was:<409> [ERROR] Errors: [ERROR] ResourceResolverGeneralTest.testGetDoesNotGoUp » IO Got status code 500 for ht... [ERROR] org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest.testGetRemovesExtensionInResolution(org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest) [ERROR] Run 1: ResourceResolverGeneralTest.setup:123 » Repository This session has been close... [ERROR] Run 2: ResourceResolverGeneralTest.cleanup:177 » Repository This session has been clo... [INFO] [ERROR] ResourceResolverGeneralTest.testGetResource » IO Bundle 'ClientSideTeleporter [ERROR] org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest.testMap(org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest) [ERROR] Run 1: ResourceResolverGeneralTest.setup:132->maybeCreateNode:87 » Repository This se... [ERROR] Run 2: ResourceResolverGeneralTest.cleanup:177 » Repository This session has been clo... [INFO] [ERROR] ResourceResolverGeneralTest.testMapContext » IO Bundle 'ClientSideTeleporter.R... [ERROR] ResourceResolverGeneralTest.testMapE
[GitHub] [sling-org-apache-sling-starter] enapps-enorman merged pull request #50: SLING-11140 Update bundles to the latest releases
enapps-enorman merged pull request #50: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #50: SLING-11140 Update bundles to the latest releases
sonarcloud[bot] commented on pull request #50: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/50#issuecomment-1039504635 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=50) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=50&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=50&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] removed a comment on pull request #50: SLING-11140 Update bundles to the latest releases
sonarcloud[bot] removed a comment on pull request #50: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/50#issuecomment-1037540409 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=50&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=50) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=50&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=50&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Independent features instead of a single project (was: Releasing Sling Starter 12)
> > why is it better to have distinct projects per feature instead of a single > Starter project? In my opinion, it would be better for a variety of reasons, such as; *1)* Modularity. For example, if you need to upgrade to a new version of oak or jetty to address some urgent problem, It would be easier to update, test and release just the oak or jetty feature(s) rather than having to stabilize the whole starter project in order to release the whole thing. *2)* Release Frequency. The starter project is released infrequently so you may not want to wait. *3)* Code Reuse. For example, imagine you are starting a new project by forking the starter project and then customizing it. Now you must forever keep checking the starter project changes for any differences that need to be merged into your copy of the same. If your fork is mostly the same as the starter then there should be less differences to worry about if you only have references to the common features. Just look at how the similar features from the org-apache-sling-app-cms and the starter projects have deviated over time. *4)* Separation of Responsibilities and Encouraging Feature Refinement. When everything is inside the starter project there is less incentive to keep clean separation of responsibilities within the features. For example, in the starter's scripting.json file, all the scripting languages are defined in one feature instead of keeping the freemarker/thymeleaf/jsp/esp/htl support separate from the core scripting support. So if you intend to only use htl scripting in your project you can't just reference the scripting feature from the starter since you have to do extra work to get rid of the freemarker/thymeleaf/esp/jsp bundles you don't need in your distribution. If the features were not inside the starter then these types of things should be more visible. *5)* Better Alignment with the Sling Karaf Features? The sling karaf features and the starter features are defined and grouped differently, so perhaps there something that could be done to keep those in sync? Now you may make the argument that you could accomplish many of the same goals by having your custom projects just use references to the common features that are released with the starter project. Even in that scenario there could be other reasons, such as: *6)* Psychological. The impression is that the starter is a demonstration, so there may be a psychological reluctance to use those "demonstration" features for production ready code. That's all for now. Does that make sense? Regards, -Eric On Mon, Feb 14, 2022 at 7:57 AM Robert Munteanu wrote: > Hi Eric, > > On Sat, 2022-02-12 at 11:27 -0800, Eric Norman wrote: > > Is there any interest in splitting the feature definitions from the > > starter > > project? > > > > IMHO, it would be better if the starter was just referencing small > > features defined elsewhere and then each of those features could be > > released on its own schedule. > > I know the answer may be obvious :-) but I'd still like to ask: why is > it better to have distinct projects per feature instead of a single > Starter project? > > Thanks, > Robert >
[jira] [Resolved] (SLING-11143) Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
[ https://issues.apache.org/jira/browse/SLING-11143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11143. - Resolution: Fixed Fixed with https://github.com/apache/sling-org-apache-sling-starter/pull/51 > Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint > - > > Key: SLING-11143 > URL: https://issues.apache.org/jira/browse/SLING-11143 > Project: Sling > Issue Type: Sub-task > Components: Starter >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Starter 12 > > Time Spent: 10m > Remaining Estimate: 0h > > Until we get SLING-10831 properly fixed we should ensure that the Docker > image does not print the error by default. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #51: SLING-11143 - Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
sonarcloud[bot] commented on pull request #51: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/51#issuecomment-1039345363 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=51&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=51&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=51&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=51) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=51&metric=duplicated_lines_density&view=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-10827) Support Java 17
[ https://issues.apache.org/jira/browse/SLING-10827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-10827. - Resolution: Fixed All done > Support Java 17 > --- > > Key: SLING-10827 > URL: https://issues.apache.org/jira/browse/SLING-10827 > Project: Sling > Issue Type: Improvement >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Labels: Sling-12-ReleaseNotes > Fix For: Starter 12 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #51: SLING-11143 - Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
rombert merged pull request #51: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11143) Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
Robert Munteanu created SLING-11143: --- Summary: Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint Key: SLING-11143 URL: https://issues.apache.org/jira/browse/SLING-11143 Project: Sling Issue Type: Sub-task Components: Starter Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Starter 12 Until we get SLING-10831 properly fixed we should ensure that the Docker image does not print the error by default. -- This message was sent by Atlassian Jira (v8.20.1#820001)
Independent features instead of a single project (was: Releasing Sling Starter 12)
Hi Eric, On Sat, 2022-02-12 at 11:27 -0800, Eric Norman wrote: > Is there any interest in splitting the feature definitions from the > starter > project? > > IMHO, it would be better if the starter was just referencing small > features defined elsewhere and then each of those features could be > released on its own schedule. I know the answer may be obvious :-) but I'd still like to ask: why is it better to have distinct projects per feature instead of a single Starter project? Thanks, Robert
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] stefanseifert commented on pull request #1: SLING-11114 update SLING API to 2.21.0
stefanseifert commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1039240515 yes - but this is a rather bigger step, we do not have a good example for this (already discussed this ab bit with @kwin in the past - it will by a bit fiddly to get this all running). ideally, the ITs should also be moved to the main module (caconfig-impl) to be executed together with the actual code. but this is a bigger project to get it all together smoothly. the same pattern is currently used for the sling models integration tests, and there it's even more important as most of the models code is not covered by unit tests but only by integration tests. also i always prefer running the ITs against a bit older version of sling to make sure it is somewhat backward compatible (e.g. comparable to AEM 6.5) so, it might be easier to bet the few missing deps here first to be able to validate https://github.com/apache/sling-org-apache-sling-caconfig-impl/tree/improvement/SLING-4-use-LazySupplier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] joerghoh commented on pull request #1: SLING-11114 update SLING API to 2.21.0
joerghoh commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1039226066 @stefanseifert thanks for the pointer. From my point of view it does not make sense to continue there. I would rather opt switch the caconfig-integration-tests over to a SLING 12 (-SNAPSHOT) version using the Feature Model. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SLING-11130) Make unpack converter retry downloads
[ https://issues.apache.org/jira/browse/SLING-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-11130. -- > Make unpack converter retry downloads > - > > Key: SLING-11130 > URL: https://issues.apache.org/jira/browse/SLING-11130 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Unpack Extension 0.2.0 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: Feature Model Unpack Extension 0.3.0 > > > The unpack converter [1] should retry downloads in case of failure. > [1] > https://github.com/apache/sling-org-apache-sling-feature-extension-unpack/blob/master/src/main/java/org/apache/sling/feature/extension/unpack/impl/converter/Converter.java -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11118) null returned even if OSGi service is found
[
https://issues.apache.org/jira/browse/SLING-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu closed SLING-8.
> null returned even if OSGi service is found
> ---
>
> Key: SLING-8
> URL: https://issues.apache.org/jira/browse/SLING-8
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Core 2.4.2
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Scripting Core 2.4.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> AbstractBundledRenderUnit.getService(String className) can return {{null}}
> for a service even if the service is found in the service registry.
> This is because the last line of this method always returns {{null}} which
> discards the result from the local {{this.services}} cache if it's found in
> there.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-11122) Improve logging when including Script Bindings
[ https://issues.apache.org/jira/browse/SLING-11122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-11122. > Improve logging when including Script Bindings > -- > > Key: SLING-11122 > URL: https://issues.apache.org/jira/browse/SLING-11122 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting Core 2.4.2 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Scripting Core 2.4.4 > > Time Spent: 20m > Remaining Estimate: 0h > > Right now it is not possible to understand the overhead imposed by the > BindingsValuesProviders. > It should always be logged to the RequestProgressTracker how long it took to > add them all. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11119) Optimise the service retrieval for bundled scripts
[
https://issues.apache.org/jira/browse/SLING-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu closed SLING-9.
> Optimise the service retrieval for bundled scripts
> --
>
> Key: SLING-9
> URL: https://issues.apache.org/jira/browse/SLING-9
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Core 2.4.4
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> The bundled scripts currently have an OSGi service cache per instance,
> however in the
> {{org.apache.sling.scripting.core.impl.bundled.ScriptContextProvider}}
> there's already a service cache per bundle context which could be reused.
> This would save significant memory in systems where there are a lot of
> bundled scripts.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] stefanseifert commented on pull request #1: SLING-11114 update SLING API to 2.21.0
stefanseifert commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1039119809 what i tested was: * "clean and install" locally: https://github.com/apache/sling-org-apache-sling-caconfig-impl/tree/improvement/SLING-4-use-LazySupplier * then "clean and install" on the integration tests - the ITs are failing on startup due to missing dependencies (and will fail after 120sec timeout) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] joerghoh commented on pull request #1: SLING-11114 update SLING API to 2.21.0
joerghoh commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1039114463 @stefanseifert Then I don't understand what you mean wrt to failing IT tests. The tests for this module work perfectly. What I did: * compile master branch of o.a.s.caconfig.impl * compile master branch of o.a.s.caconfig.integration-tests Do we have an automated test which fails? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[RESULT] [VOTE] Release Apache Sling Scripting Core 2.4.4
Hi, The vote has passed with the following result: +1 (binding): Carsten Ziegeler, Dan Klco, Stefan Seifert, Karl Pauls, Nicolas Peltier +1 (non-binding): Jörg Hoh I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Radu Cotescu
Re: [VOTE] Release Apache Sling Rewriter 1.3.2
+1 > On 14 Feb 2022, at 09:44, Carsten Ziegeler wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] stefanseifert commented on pull request #1: SLING-11114 update SLING API to 2.21.0
stefanseifert commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1039037971 this is not enough to actually run the ITs with the updated Sling API (it still fails to startup properly when testing against current impl 1.6.1-SNAPSHOT). it's also required to add this to test/provisioning/sling.txt: ``` # Updated bundles org.apache.sling/org.apache.sling.api ``` but this leads to other dependency problems that are not part of Sling 11, e.g. ``` org.osgi.util.converter,version=[1.0,2) -- Cannot be resolved ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-models-impl] joerghoh commented on pull request #17: SLING-8706 - Injections for java.util.Optional<> should be automatically optional
joerghoh commented on pull request #17: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/17#issuecomment-1038982316 Is there any topic still open? I would then move this topic forward and merge it later this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Rewriter 1.3.2
+1 Carsten Am 14.02.2022 um 09:44 schrieb Carsten Ziegeler: Hi, we solved two issues in this release https://issues.apache.org/jira/projects/SLING/versions/12349607 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2600 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2600 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Rewriter 1.3.2
+1 David On Mon, 14 Feb 2022 at 11:07, Robert Munteanu wrote: > On Mon, 2022-02-14 at 09:44 +0100, Carsten Ziegeler wrote: > > Please vote to approve this release: > > +1 > Robert >
Re: [VOTE] Release Apache Sling Rewriter 1.3.2
On Mon, 2022-02-14 at 09:44 +0100, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Updated] (SLING-11142) Connection Timeout agent is overidding a higher timeout from HttpClientBuilder
[ https://issues.apache.org/jira/browse/SLING-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11142: Fix Version/s: Connection Timeout Agent 1.0.4 > Connection Timeout agent is overidding a higher timeout from > HttpClientBuilder > --- > > Key: SLING-11142 > URL: https://issues.apache.org/jira/browse/SLING-11142 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Connection Timeout Agent 1.0.2 >Reporter: Ankush Malhotra >Assignee: Robert Munteanu >Priority: Major > Fix For: Connection Timeout Agent 1.0.4 > > > Other than using RequestConfig to set socket timeout, it may be set at > default socket config of httpclient builder > [https://github.com/zzphamvanthanhzz/httpclient-4.5.2-java/blob/master/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L353] > the connection tiemout agent ignores the timeout from default socket config > of httpclientbuilder, and this is a problem with default socket timeout in > httpclientbuilder is higer, this override should atleast be documented, if > not fixed. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-11142) Connection Timeout agent is overidding a higher timeout from HttpClientBuilder
[ https://issues.apache.org/jira/browse/SLING-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491939#comment-17491939 ] Robert Munteanu commented on SLING-11142: - Hi [~amalhotr] and thanks for the report. Can you please add a code sample that does not work as expected when instrumented by the connection timeout agent? Ideally this would be a new test case under https://github.com/apache/sling-org-apache-sling-connection-timeout-agent/tree/master/src/test/java/org/apache/sling/cta/impl , but if that proves problematic I'd be happy with a java snippet. Thanks! > Connection Timeout agent is overidding a higher timeout from > HttpClientBuilder > --- > > Key: SLING-11142 > URL: https://issues.apache.org/jira/browse/SLING-11142 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Connection Timeout Agent 1.0.2 >Reporter: Ankush Malhotra >Assignee: Robert Munteanu >Priority: Major > > Other than using RequestConfig to set socket timeout, it may be set at > default socket config of httpclient builder > [https://github.com/zzphamvanthanhzz/httpclient-4.5.2-java/blob/master/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L353] > the connection tiemout agent ignores the timeout from default socket config > of httpclientbuilder, and this is a problem with default socket timeout in > httpclientbuilder is higer, this override should atleast be documented, if > not fixed. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[RESULT][VOTE] Release Apache Sling Feature Model Unpack Extension 0.3.0
Hi all, We received 6 binding +1 votes. This release is successful. I've promoted the artifacts. Kind regards, David On Thu, 10 Feb 2022 at 13:39, wrote: > Hi all, > > I'd like to release org.apache.sling.feature.extension.unpack 0.3.0. > > We solved one issue in this release: > https://issues.apache.org/jira/projects/SLING/versions/12351323 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2599/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2599 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Kind Regards > David >
[VOTE] Release Apache Sling Rewriter 1.3.2
Hi, we solved two issues in this release https://issues.apache.org/jira/projects/SLING/versions/12349607 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2600 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2600 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Updated] (SLING-11142) Connection Timeout agent is overidding a higher timeout from HttpClientBuilder
[ https://issues.apache.org/jira/browse/SLING-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Malhotra updated SLING-11142: Description: Other than using RequestConfig to set socket timeout, it may be set at default socket config of httpclient builder [https://github.com/zzphamvanthanhzz/httpclient-4.5.2-java/blob/master/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L353] the connection tiemout agent ignores the timeout from default socket config of httpclientbuilder, and this is a problem with default socket timeout in httpclientbuilder is higer, this override should atleast be documented, if not fixed. was: Other than using RequestConfig to set socket timeout, socket timeout may be set at default socket config of httpclient builder [https://github.com/zzphamvanthanhzz/httpclient-4.5.2-java/blob/master/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L353] the connection tiemout agent ignores the timeout from default socket config of httpclientbuilder, and this is a problem with default socket timeout in httpclientbuilder is higer, this override should atleast be documented, if not fixed. > Connection Timeout agent is overidding a higher timeout from > HttpClientBuilder > --- > > Key: SLING-11142 > URL: https://issues.apache.org/jira/browse/SLING-11142 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Connection Timeout Agent 1.0.2 >Reporter: Ankush Malhotra >Assignee: Robert Munteanu >Priority: Major > > Other than using RequestConfig to set socket timeout, it may be set at > default socket config of httpclient builder > [https://github.com/zzphamvanthanhzz/httpclient-4.5.2-java/blob/master/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L353] > the connection tiemout agent ignores the timeout from default socket config > of httpclientbuilder, and this is a problem with default socket timeout in > httpclientbuilder is higer, this override should atleast be documented, if > not fixed. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-11142) Connection Timeout agent is overidding a higher timeout from HttpClientBuilder
[ https://issues.apache.org/jira/browse/SLING-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Malhotra updated SLING-11142: Description: Other than using RequestConfig to set socket timeout, socket timeout may be set at default socket config of httpclient builder [https://github.com/zzphamvanthanhzz/httpclient-4.5.2-java/blob/master/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L353] the connection tiemout agent ignores the timeout from default socket config of httpclientbuilder, and this is a problem with default socket timeout in httpclientbuilder is higer, this override should atleast be documented, if not fixed. was: Other than using RequestConfig to set socket timeout, socket timeout may be set at default socket config of httpclient builder https://github.com/zzphamvanthanhzz/httpclient-4.5.2-java/blob/master/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L353 > Connection Timeout agent is overidding a higher timeout from > HttpClientBuilder > --- > > Key: SLING-11142 > URL: https://issues.apache.org/jira/browse/SLING-11142 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Connection Timeout Agent 1.0.2 >Reporter: Ankush Malhotra >Assignee: Robert Munteanu >Priority: Major > > Other than using RequestConfig to set socket timeout, socket timeout may be > set at default socket config of httpclient builder > [https://github.com/zzphamvanthanhzz/httpclient-4.5.2-java/blob/master/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L353] > the connection tiemout agent ignores the timeout from default socket config > of httpclientbuilder, and this is a problem with default socket timeout in > httpclientbuilder is higer, this override should atleast be documented, if > not fixed. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-11142) Connection Timeout agent is overidding a higher timeout from HttpClientBuilder
[ https://issues.apache.org/jira/browse/SLING-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Malhotra updated SLING-11142: Affects Version/s: Connection Timeout Agent 1.0.2 > Connection Timeout agent is overidding a higher timeout from > HttpClientBuilder > --- > > Key: SLING-11142 > URL: https://issues.apache.org/jira/browse/SLING-11142 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Connection Timeout Agent 1.0.2 >Reporter: Ankush Malhotra >Assignee: Robert Munteanu >Priority: Major > > Other than using RequestConfig to set socket timeout, socket timeout may be > set at default socket config of httpclient builder > https://github.com/zzphamvanthanhzz/httpclient-4.5.2-java/blob/master/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L353 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-11142) Connection Timeout agent is overidding a higher timeout from HttpClientBuilder
[
https://issues.apache.org/jira/browse/SLING-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankush Malhotra updated SLING-11142:
Description:
Other than using RequestConfig to set socket timeout, socket timeout may be set
at default socket config of httpclient builder
https://github.com/zzphamvanthanhzz/httpclient-4.5.2-java/blob/master/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L353
was:It seems that sometimes the instrumentation does not work properly. We
should have an extra verbose mode {{vv}} added to the agent so we can trace
every time we are invoked to rewrite a class, even if we decide not to.
> Connection Timeout agent is overidding a higher timeout from
> HttpClientBuilder
> ---
>
> Key: SLING-11142
> URL: https://issues.apache.org/jira/browse/SLING-11142
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Reporter: Ankush Malhotra
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Connection Timeout Agent 1.0.2
>
>
> Other than using RequestConfig to set socket timeout, socket timeout may be
> set at default socket config of httpclient builder
> https://github.com/zzphamvanthanhzz/httpclient-4.5.2-java/blob/master/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L353
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-11142) Connection Timeout agent is overidding a higher timeout from HttpClientBuilder
[ https://issues.apache.org/jira/browse/SLING-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Malhotra updated SLING-11142: Fix Version/s: (was: Connection Timeout Agent 1.0.2) > Connection Timeout agent is overidding a higher timeout from > HttpClientBuilder > --- > > Key: SLING-11142 > URL: https://issues.apache.org/jira/browse/SLING-11142 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Ankush Malhotra >Assignee: Robert Munteanu >Priority: Major > > Other than using RequestConfig to set socket timeout, socket timeout may be > set at default socket config of httpclient builder > https://github.com/zzphamvanthanhzz/httpclient-4.5.2-java/blob/master/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L353 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11142) Connection Timeout agent is overidding a higher timeout from HttpClientBuilder
Ankush Malhotra created SLING-11142:
---
Summary: Connection Timeout agent is overidding a higher timeout
from HttpClientBuilder
Key: SLING-11142
URL: https://issues.apache.org/jira/browse/SLING-11142
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Ankush Malhotra
Assignee: Robert Munteanu
Fix For: Connection Timeout Agent 1.0.2
It seems that sometimes the instrumentation does not work properly. We should
have an extra verbose mode {{vv}} added to the agent so we can trace every time
we are invoked to rewrite a class, even if we decide not to.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
