[GitHub] [sling-org-apache-sling-event] oliverlietz commented on a diff in pull request #22: SLING-11379 do not register the same job over and over
oliverlietz commented on code in PR #22:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/22#discussion_r891608376
##
src/main/java/org/apache/sling/event/impl/jobs/scheduling/JobScheduleBuilderImpl.java:
##
@@ -117,4 +126,31 @@ public ScheduleBuilder suspend() {
this.suspend = true;
return this;
}
+
+/**
+ * In case a scheduleName was not provided we calculate on based on the
available
+ * data so we can detect duplicates.
+ * @return a value which is identical for identical jobs
+ */
+private String deriveScheduleName() {
+StringBuilder sb = new StringBuilder();
+sb.append("topic="+topic)
+.append(",suspend=" + suspend)
+.append(",");
+
+if (properties != null) {
+// sort the properties and flatten them into a string
+List keys = new ArrayList<>(properties.keySet());
+Collections.sort(keys);
+for (String key: keys) {
+
sb.append(key).append("=").append(properties.get(key)).append(",");
+}
+}
+// append all schedules
+sb.append("schedules=").append(schedules);
+
+String hashCode = String.valueOf(sb.toString().hashCode());
+logger.debug("calculated hash [{}] for unspecified scheduleName,
calculated as {}",hashCode, sb.toString());
Review Comment:
don't call `toString()` on `StringBuilder` in log statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event] oliverlietz commented on a diff in pull request #22: SLING-11379 do not register the same job over and over
oliverlietz commented on code in PR #22:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/22#discussion_r891606791
##
src/main/java/org/apache/sling/event/impl/jobs/scheduling/JobScheduleBuilderImpl.java:
##
@@ -117,4 +126,31 @@ public ScheduleBuilder suspend() {
this.suspend = true;
return this;
}
+
+/**
+ * In case a scheduleName was not provided we calculate on based on the
available
+ * data so we can detect duplicates.
+ * @return a value which is identical for identical jobs
+ */
+private String deriveScheduleName() {
+StringBuilder sb = new StringBuilder();
+sb.append("topic="+topic)
+.append(",suspend=" + suspend)
+.append(",");
Review Comment:
```
sb.append("topic=").append(topic).append(",suspend=").append(suspend)
.append(",");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event] oliverlietz commented on a diff in pull request #22: SLING-11379 do not register the same job over and over
oliverlietz commented on code in PR #22:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/22#discussion_r891606000
##
src/main/java/org/apache/sling/event/impl/jobs/JobBuilderImpl.java:
##
@@ -64,7 +64,7 @@ public ScheduleBuilder schedule() {
return new JobScheduleBuilderImpl(
this.topic,
this.properties,
-UUID.randomUUID().toString(),
Review Comment:
leaves an unused import behind, but why not dropping the name from
constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (SLING-11338) Update jacoco to 0.8.8
[ https://issues.apache.org/jira/browse/SLING-11338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-11338. --- > Update jacoco to 0.8.8 > -- > > Key: SLING-11338 > URL: https://issues.apache.org/jira/browse/SLING-11338 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 48 > > > https://www.eclemma.org/jacoco/trunk/doc/changes.html -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-11178) Update to animal-sniffer-m-p 1.21
[ https://issues.apache.org/jira/browse/SLING-11178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-11178. --- > Update to animal-sniffer-m-p 1.21 > - > > Key: SLING-11178 > URL: https://issues.apache.org/jira/browse/SLING-11178 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 48 > > > https://github.com/mojohaus/animal-sniffer/releases/tag/animal-sniffer-parent-1.21 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-11337) Configure Matomo Web Analytics for Maven Sites
[ https://issues.apache.org/jira/browse/SLING-11337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-11337. --- > Configure Matomo Web Analytics for Maven Sites > -- > > Key: SLING-11337 > URL: https://issues.apache.org/jira/browse/SLING-11337 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 48 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The analytics enabled in SLING-11204 should also be used for all Maven > generated sites (used for Sling Maven Plugins). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-11179) Update Jetbrains annotations to version 23
[ https://issues.apache.org/jira/browse/SLING-11179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-11179. --- > Update Jetbrains annotations to version 23 > -- > > Key: SLING-11179 > URL: https://issues.apache.org/jira/browse/SLING-11179 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 48 > > > https://github.com/JetBrains/java-annotations/releases -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-11200) Manage maven-shade-plugin version
[ https://issues.apache.org/jira/browse/SLING-11200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-11200. --- > Manage maven-shade-plugin version > - > > Key: SLING-11200 > URL: https://issues.apache.org/jira/browse/SLING-11200 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 48 > > > We had issues with reproducible builds due to using an outdated version > m-shade-p: > # https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/36 > # https://github.com/apache/sling-org-apache-sling-installer-core/pull/9 > # https://github.com/apache/sling-org-apache-sling-feature/pull/30 > # https://github.com/apache/sling-org-apache-sling-servlets-post/pull/17 > # https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/28 > As we use this plugin quite often in Sling Modules it would be useful to > manage its version in sling-parent. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-11336) Update to ASF Parent 26
[ https://issues.apache.org/jira/browse/SLING-11336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-11336. --- > Update to ASF Parent 26 > --- > > Key: SLING-11336 > URL: https://issues.apache.org/jira/browse/SLING-11336 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 48 > > > https://github.com/apache/maven-apache-parent/releases/tag/apache-26 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-11375) Relocate und update Cargo Maven Plugin
[ https://issues.apache.org/jira/browse/SLING-11375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-11375. --- > Relocate und update Cargo Maven Plugin > -- > > Key: SLING-11375 > URL: https://issues.apache.org/jira/browse/SLING-11375 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 48 > > > https://codehaus-cargo.github.io/cargo/Maven+3+Plugin.html > bq. Please be aware that the Maven 2 / Maven 3 plugin of Codehaus Cargo has > been retired with our version 1.9.0 and has been superseded by a Maven 3 only > plugin. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-11174) Update to ASF Parent 25
[ https://issues.apache.org/jira/browse/SLING-11174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-11174. --- > Update to ASF Parent 25 > --- > > Key: SLING-11174 > URL: https://issues.apache.org/jira/browse/SLING-11174 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 48 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-11175) Update to Bnd 6.3
[ https://issues.apache.org/jira/browse/SLING-11175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-11175. --- > Update to Bnd 6.3 > - > > Key: SLING-11175 > URL: https://issues.apache.org/jira/browse/SLING-11175 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Bundle Parent 48 > > > https://github.com/bndtools/bnd/wiki/Changes-in-6.3.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-11176) Update to newest micro version of OSGi dependencies
[ https://issues.apache.org/jira/browse/SLING-11176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-11176. --- > Update to newest micro version of OSGi dependencies > --- > > Key: SLING-11176 > URL: https://issues.apache.org/jira/browse/SLING-11176 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Bundle Parent 48 > > Time Spent: 20m > Remaining Estimate: 0h > > There were some backwards-compatible fixes applied to several OSGi artifacts > which are compatible with the underlying chapter of the OSGi spec. All those > artifacts should be updated to the newest micro version. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-11344) Backport of SLING-8897 and others from Installer Console 1.1.0 for compatibility with OSGi Installer Core 3.9.0
[ https://issues.apache.org/jira/browse/SLING-11344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-11344. --- > Backport of SLING-8897 and others from Installer Console 1.1.0 for > compatibility with OSGi Installer Core 3.9.0 > --- > > Key: SLING-11344 > URL: https://issues.apache.org/jira/browse/SLING-11344 > Project: Sling > Issue Type: Improvement > Components: Installer >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Installer Console 1.0.4 > > Time Spent: 1h > Remaining Estimate: 0h > > The WebConsole plugin added in SLING-8897 requires OSGi Installer Core 3.10.0 > or newer. As updating the installer core bundle in existing distributions is > often not easy (due to the downstream dependencies to installer providers) it > would be nice to offer this feature in a web console bundle version which is > still compatible with 3.9.0. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[RESULT] [VOTE] Release Apache Sling Installer WebConsole Plugin version 1.0.4
Hi, The vote has passed with the following result : +1 (binding): Robert, Stefan, Carsten I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks for voting, Konrad > On 3. Jun 2022, at 14:39, Konrad Windszus wrote: > > Hi, > > This is mostly a back port of version 1.1.0 to ensure compatibility with OSGi > Installer Core: https://issues.apache.org/jira/browse/SLING-11344 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2643/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2643 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Konrad
[RESULT] [VOTE] Release Apache Sling (Bundle) Parent 48
Hi, The vote has passed with the following result : +1 (binding): Robert, Oli, Stefan I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks for voting, Konrad > On 3. Jun 2022, at 12:01, Konrad Windszus wrote: > > Hi, > > We solved some issues in these releases: > https://issues.apache.org/jira/projects/SLING/versions/12351253 and > https://issues.apache.org/jira/projects/SLING/versions/12351252 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2642/ > > You can use this UNIX script to download the releases and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2642 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Thanks, > Konrad
RE: Please welcome Ashok Pelluru, Sling committer
welcome! stefan On Tue, Jun 7, 2022 at 10:52 AM Robert Munteanu wrote: > > Hi Sling community, > > Based on his ongoing and valuable contributions to the project, the > Sling PMC has elected Ashok Pelluru as a Sling committer, and he > has accepted the invitation. > > Please join me in welcoming Ashok! > > Ashok - if you want to honor the old tradition of new committers > briefly introducing themselves to the list, feel free. > > Welcome! > > Robert
[GitHub] [sling-org-apache-sling-testing-clients] dulvac commented on a diff in pull request #35: SLING-11364 more precise exceptions
dulvac commented on code in PR #35:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/35#discussion_r891133784
##
src/test/java/org/apache/sling/testing/clients/SlingClientExceptions.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.sling.testing.clients;
+
+import java.io.IOException;
+
+import org.apache.sling.testing.clients.exceptions.TestingValidationException;
+import org.junit.ClassRule;
+import org.junit.Test;
+
+public class SlingClientExceptions {
+
+
+ private static final String ERROR_PATH =
"/content/missingResource.json";
Review Comment:
```suggestion
private static final String ERROR_PATH = "/content/missingResource.json";
```
##
src/test/java/org/apache/sling/testing/clients/SlingClientExceptions.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.sling.testing.clients;
+
+import java.io.IOException;
+
+import org.apache.sling.testing.clients.exceptions.TestingValidationException;
+import org.junit.ClassRule;
+import org.junit.Test;
+
+public class SlingClientExceptions {
+
+
Review Comment:
remove extra line break, please
##
src/main/java/org/apache/sling/testing/clients/exceptions/TestingValidationException.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.testing.clients.exceptions;
+
+import org.apache.http.client.methods.HttpUriRequest;
+import org.apache.sling.testing.clients.ClientException;
+import org.apache.sling.testing.clients.SlingHttpResponse;
+
+/**
+ * Use this exception to indicate any mismatch between expectations and the
actual
+ * test result. This exception typically indicates "real" test failures.
+ *
+ */
+public class TestingValidationException extends ClientException {
+
+ public TestingValidationException(String message) {
Review Comment:
```suggestion
public TestingValidationException(String message) {
```
##
src/main/java/org/apache/sling/testing/clients/exceptions/TestingIOException.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless
Re: Please welcome Ashok Pelluru, Sling committer
Welcome Ashok! Regards Julian On Tue, Jun 7, 2022 at 10:52 AM Robert Munteanu wrote: > > Hi Sling community, > > Based on his ongoing and valuable contributions to the project, the > Sling PMC has elected Ashok Pelluru as a Sling committer, and he > has accepted the invitation. > > Please join me in welcoming Ashok! > > Ashok - if you want to honor the old tradition of new committers > briefly introducing themselves to the list, feel free. > > Welcome! > > Robert > > > >
[jira] [Closed] (SLING-11167) Sling jobs inventory printer for json produces invalid json
[
https://issues.apache.org/jira/browse/SLING-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-11167.
-
> Sling jobs inventory printer for json produces invalid json
> ---
>
> Key: SLING-11167
> URL: https://issues.apache.org/jira/browse/SLING-11167
> Project: Sling
> Issue Type: Bug
> Components: Event
>Affects Versions: Event 4.2.24
>Reporter: Natalia Angulo Herrera
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Event 4.3.0
>
>
> Sling jobs inventory printer for json produces invalid json:
> {
> "queues": [
> {
> "configuration" :
> {
> "topics" : "["ref-updater/references", "ref-updater/update",
> "ref-updater/delete"]"
> }
> }
> ]
> }
> where queues.topics is not a valid json format.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (SLING-10727) Fix bundle classpath broken by embedded Event API
[
https://issues.apache.org/jira/browse/SLING-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-10727.
-
> Fix bundle classpath broken by embedded Event API
> -
>
> Key: SLING-10727
> URL: https://issues.apache.org/jira/browse/SLING-10727
> Project: Sling
> Issue Type: Improvement
> Components: Event
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Event 4.3.0
>
>
> {noformat}
> Bundle-ClassPath: .,org.apache.sling.event.api-1.0.0.jar/
> {noformat}
> {noformat}
> [INFO] --- bnd-maven-plugin:5.3.0:bnd-process (bnd-process) @
> org.apache.sling.event ---
> [WARNING] /.../org.apache.sling.event/bnd.bnd [0:0]: Bundle-ClassPath uses a
> directory 'org.apache.sling.event.api-1.0.0.jar' as well as '.'. This means
> bnd does not know if a directory is a package.
> [WARNING] /.../org.apache.sling.event/bnd.bnd [0:0]: Invalid value for
> Bundle-ClassPath, .,org.apache.sling.event.api-1.0.0.jar/ does not match
> /?[^/"
> ]+(/[^/"
> ]+)*
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (SLING-10724) Update to Sling Bundle Parent 44
[ https://issues.apache.org/jira/browse/SLING-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-10724. - > Update to Sling Bundle Parent 44 > > > Key: SLING-10724 > URL: https://issues.apache.org/jira/browse/SLING-10724 > Project: Sling > Issue Type: Task > Components: Event >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Event 4.3.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-10181) fix docu example
[
https://issues.apache.org/jira/browse/SLING-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-10181.
-
> fix docu example
>
>
> Key: SLING-10181
> URL: https://issues.apache.org/jira/browse/SLING-10181
> Project: Sling
> Issue Type: Task
> Components: Event
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
>
> https://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html#jobs-guarantee-of-processing
> mentions
> {noformat}
> ScheduleBuilder scheduleBuilder =
> jobManager.startJob("my/special/jobtopic").schedule();
> {noformat}
> but that seems to be from an oldish API and should rather be something like
> {noformat}
> ScheduleBuilder scheduleBuilder =
> jobManager.createJob("my/special/jobtopic").schedule();
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (SLING-10725) Update Felix Framework to 7.0.1
[
https://issues.apache.org/jira/browse/SLING-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-10725.
-
> Update Felix Framework to 7.0.1
> ---
>
> Key: SLING-10725
> URL: https://issues.apache.org/jira/browse/SLING-10725
> Project: Sling
> Issue Type: Improvement
> Components: Event
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Event 4.3.0
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.sling.event.it.ClassloadingTest
> [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 6.972
> s <<< FAILURE! - in org.apache.sling.event.it.ClassloadingTest
> [ERROR] org.apache.sling.event.it.ClassloadingTest.testFailedClassloading
> Time elapsed: 4.086 s <<< ERROR!
> org.osgi.framework.BundleException: Importing java.* packages not allowed:
> java.io
> at
> org.apache.felix.framework.util.manifestparser.ManifestParser.normalizeImportClauses(ManifestParser.java:349)
> at
> org.apache.felix.framework.util.manifestparser.ManifestParser.(ManifestParser.java:181)
> at
> org.apache.felix.framework.BundleRevisionImpl.(BundleRevisionImpl.java:117)
> at
> org.apache.felix.framework.BundleImpl.createRevision(BundleImpl.java:1282)
> at org.apache.felix.framework.BundleImpl.(BundleImpl.java:113)
> at org.apache.felix.framework.Felix.installBundle(Felix.java:3025)
> at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:167)
> at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:140)
> at
> org.ops4j.pax.swissbox.framework.RemoteFrameworkImpl.installBundle(RemoteFrameworkImpl.java:132)
> at jdk.internal.reflect.GeneratedMethodAccessor1.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:359)
> at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
> at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
> at java.base/java.security.AccessController.doPrivileged(Native Method)
> at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
> at
> java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:562)
> at
> java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:796)
> at
> java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:677)
> at java.base/java.security.AccessController.doPrivileged(Native Method)
> at
> java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:676)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:834)
> at
> java.rmi/sun.rmi.transport.StreamRemoteCall.exceptionReceivedFromServer(StreamRemoteCall.java:303)
> at
> java.rmi/sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:279)
> at java.rmi/sun.rmi.server.UnicastRef.invoke(UnicastRef.java:164)
> at
> java.rmi/java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(RemoteObjectInvocationHandler.java:217)
> at
> java.rmi/java.rmi.server.RemoteObjectInvocationHandler.invoke(RemoteObjectInvocationHandler.java:162)
> at com.sun.proxy.$Proxy13.installBundle(Unknown Source)
> at
> org.ops4j.pax.exam.forked.ForkedTestContainer.installAndStartBundles(ForkedTestContainer.java:285)
> at
> org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:165)
> at
> org.ops4j.pax.exam.spi.reactors.AllConfinedStagedReactor.invoke(AllConfinedStagedReactor.java:79)
> at
> org.ops4j.pax.exam.junit.impl.ProbeRunner$2.evaluate(ProbeRunner.java:267)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at
[jira] [Closed] (SLING-5417) Jobs are only partially persisted
[ https://issues.apache.org/jira/browse/SLING-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-5417. > Jobs are only partially persisted > - > > Key: SLING-5417 > URL: https://issues.apache.org/jira/browse/SLING-5417 > Project: Sling > Issue Type: Bug > Components: Event >Reporter: Carsten Ziegeler >Priority: Critical > > After some experimenting the failing IT tests on our integration servers seem > to indicate that jobs are only partially persisted without any exception. The > error log is full with messages of a read job without a topic. > We already had reports for binary properties, but it doesn't seem to be > limited to this. > This seems to happen with a JR 2 and a Oak based repository > As a first step we could add a call of readJob add JobManager#addJob to > ensure that the job can fully be read again. If that fails, we know for sure > that the above assumption is correct. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-8295) Enable code coverage extraction from integration tests
[ https://issues.apache.org/jira/browse/SLING-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-8295. > Enable code coverage extraction from integration tests > -- > > Key: SLING-8295 > URL: https://issues.apache.org/jira/browse/SLING-8295 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Dominik Süß >Assignee: Oliver Lietz >Priority: Major > Fix For: Event 4.3.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > The current setup doesn't allow to run the jacoco-report profile with IT > extraction as defined in the parent. This is due to the coveragecommand > (prepared agent) not being injected into pax exam vm options. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-11091) Expose the number of scheduled jobs
[ https://issues.apache.org/jira/browse/SLING-11091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-11091. - > Expose the number of scheduled jobs > --- > > Key: SLING-11091 > URL: https://issues.apache.org/jira/browse/SLING-11091 > Project: Sling > Issue Type: Improvement > Components: Event >Affects Versions: Event 4.2.24 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Event 4.3.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Eventing should expose the total number of scheduled jobs as a metric; I have > seen cases where to incorrectly unscheduling the total number of scheduled > jobs was getting huge (> 10k), thus overloading the system. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-10730) Improve configurations of integration tests
[
https://issues.apache.org/jira/browse/SLING-10730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-10730.
-
> Improve configurations of integration tests
> ---
>
> Key: SLING-10730
> URL: https://issues.apache.org/jira/browse/SLING-10730
> Project: Sling
> Issue Type: Improvement
> Components: Event
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Event 4.3.0
>
>
> * use {{factoryConfiguration}} from Pax Exam instead of {{ConfigurationAdmin}}
> * drop useless cleanup, we are using fresh instances for each test (method
> or class)
> * use {{slingEvent()}} option and remove {{org.apache.sling.event}} bundle
> * use injected {{JobManager}}
> * extract base configuration into new {{JobsTestSupport}}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (SLING-11379) Do not create duplicate scheduled jobs
[ https://issues.apache.org/jira/browse/SLING-11379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-11379: -- Fix Version/s: Event 4.3.4 > Do not create duplicate scheduled jobs > -- > > Key: SLING-11379 > URL: https://issues.apache.org/jira/browse/SLING-11379 > Project: Sling > Issue Type: Improvement > Components: Event >Affects Versions: Event 4.3.2 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Event 4.3.4 > > Time Spent: 0.5h > Remaining Estimate: 0h > > I came across situations where periodic jobs were added in the activation of > an OSGI component, which eventually piles up to a huge amount of (identical) > jobs being scheduled, causing major problems on load and stability. > Before adding a new scheduled job, it should be checked if it already exists. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (SLING-8413) JobManagerImpl.findJobs does not escape some values when running queries
[ https://issues.apache.org/jira/browse/SLING-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-8413: - Fix Version/s: Event 4.3.4 > JobManagerImpl.findJobs does not escape some values when running queries > > > Key: SLING-8413 > URL: https://issues.apache.org/jira/browse/SLING-8413 > Project: Sling > Issue Type: Bug > Components: Event >Reporter: Thomas Mueller >Assignee: Joerg Hoh >Priority: Major > Fix For: Event 4.3.4 > > > For SLING-8407 [~stefanegli] found that JobManagerImpl.findJobs doesn't > escape some values when building a JCR query. Values need to be escaped. -- This message was sent by Atlassian Jira (v8.20.7#820007)
Re: [VOTE] Release Apache Sling Installer WebConsole Plugin version 1.0.4
+1 Carsten Am 03.06.2022 um 14:39 schrieb Konrad Windszus: Hi, This is mostly a back port of version 1.1.0 to ensure compatibility with OSGi Installer Core: https://issues.apache.org/jira/browse/SLING-11344 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2643/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2643 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Konrad -- Carsten Ziegeler Adobe cziege...@apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] cziegeler merged pull request #71: SLING-11363: resource resolver: bloom filter incomplete when vanity path size limited
cziegeler merged PR #71: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Installer WebConsole Plugin version 1.0.4
On Fri, 2022-06-03 at 14:39 +0200, Konrad Windszus wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Assigned] (SLING-11380) Update parent bundle (47) to sling-jmx-provider
[ https://issues.apache.org/jira/browse/SLING-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-11380: --- Assignee: Ashok Pelluru > Update parent bundle (47) to sling-jmx-provider > --- > > Key: SLING-11380 > URL: https://issues.apache.org/jira/browse/SLING-11380 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Ashok Pelluru >Priority: Major > Fix For: JMX Resource Provider 1.0.4 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (SLING-11382) Update parent bundle (47) to sling-jms
[ https://issues.apache.org/jira/browse/SLING-11382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11382: Fix Version/s: MoM JMS 1.0.2 > Update parent bundle (47) to sling-jms > -- > > Key: SLING-11382 > URL: https://issues.apache.org/jira/browse/SLING-11382 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Ashok Pelluru >Priority: Minor > Fix For: MoM JMS 1.0.2 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (SLING-11382) Update parent bundle (47) to sling-jms
[ https://issues.apache.org/jira/browse/SLING-11382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-11382: --- Assignee: Ashok Pelluru > Update parent bundle (47) to sling-jms > -- > > Key: SLING-11382 > URL: https://issues.apache.org/jira/browse/SLING-11382 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Ashok Pelluru >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
RE: [VOTE] Release Apache Sling Installer WebConsole Plugin version 1.0.4
+1
[GitHub] [sling-org-apache-sling-jms] rombert commented on a diff in pull request #3: SLING-11382: Sling update to 47
rombert commented on code in PR #3: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/3#discussion_r890976242 ## bnd.bnd: ## @@ -0,0 +1,19 @@ +Embed-Dependency:\ Review Comment: After this PR the bundle no longer embeds the dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
RE: [VOTE] Release Apache Sling (Bundle) Parent 48
+1
[jira] [Assigned] (SLING-11381) Update parent bundle (47) to sling-jcr-api
[ https://issues.apache.org/jira/browse/SLING-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-11381: --- Assignee: Ashok Pelluru > Update parent bundle (47) to sling-jcr-api > -- > > Key: SLING-11381 > URL: https://issues.apache.org/jira/browse/SLING-11381 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Ashok Pelluru >Priority: Minor > Fix For: JCR API 2.4.2 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
Please welcome Ashok Pelluru, Sling committer
Hi Sling community, Based on his ongoing and valuable contributions to the project, the Sling PMC has elected Ashok Pelluru as a Sling committer, and he has accepted the invitation. Please join me in welcoming Ashok! Ashok - if you want to honor the old tradition of new committers briefly introducing themselves to the list, feel free. Welcome! Robert
[jira] [Updated] (SLING-11370) Update parent bundle (47) to sling-resource-inventory
[ https://issues.apache.org/jira/browse/SLING-11370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11370: Fix Version/s: Resource Inventory 1.0.10 > Update parent bundle (47) to sling-resource-inventory > - > > Key: SLING-11370 > URL: https://issues.apache.org/jira/browse/SLING-11370 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Robert Munteanu >Priority: Minor > Fix For: Resource Inventory 1.0.10 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (SLING-11370) Update parent bundle (47) to sling-resource-inventory
[ https://issues.apache.org/jira/browse/SLING-11370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11370. - Assignee: Robert Munteanu Resolution: Fixed PR applied, thanks [~ashokmc...@gmail.com]! > Update parent bundle (47) to sling-resource-inventory > - > > Key: SLING-11370 > URL: https://issues.apache.org/jira/browse/SLING-11370 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Robert Munteanu >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [sling-org-apache-sling-resource-inventory] rombert merged pull request #1: SLING-11370: Sling update to 47
rombert merged PR #1: URL: https://github.com/apache/sling-org-apache-sling-resource-inventory/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jmx-provider] rombert commented on a diff in pull request #1: SLING-11380: Upgrade to sling 47
rombert commented on code in PR #1: URL: https://github.com/apache/sling-org-apache-sling-jmx-provider/pull/1#discussion_r890937215 ## src/test/java/org/apache/sling/jmx/provider/impl/JMXResourceProviderTest.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.sling.jmx.provider.impl; + +import org.apache.sling.testing.mock.osgi.junit.OsgiContext; +import org.junit.Before; +import org.junit.Rule; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.junit.MockitoJUnitRunner; + +import java.util.Dictionary; +import java.util.Hashtable; + +import static org.junit.Assert.assertNotNull; + +@RunWith(MockitoJUnitRunner.class) Review Comment: Why do you need the Mockito runner and the mockito dependency? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #28: SLING-11248 QueryParser.fromRequest(...) calls possible exceptions sh…
sonarcloud[bot] commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/28#issuecomment-1148323140 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core=28) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=28=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=28=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=28=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=28=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=28=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=28=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=28=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9068) Add more context to ParseException
[
https://issues.apache.org/jira/browse/SLING-9068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17550853#comment-17550853
]
Bertrand Delacretaz commented on SLING-9068:
As per
https://stackoverflow.com/questions/1564448/format-parseexception-with-javacc
it looks like we'll need to store a (partial) copy of the input, probably by
wrapping the input Reader, to be able to recreate the context based on the
positional information provided by the {{currentToken}} when an Exception is
thrown.
> Add more context to ParseException
> --
>
> Key: SLING-9068
> URL: https://issues.apache.org/jira/browse/SLING-9068
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit Parser 1.6.2
>Reporter: Angela Schreiber
>Priority: Minor
>
> today the repo init grammar doesn't come with dedicated exception handing and
> thus the parser will fail with messages that can make it hard to spot actual
> problem... specially in a lengthy repo-init as it is present with Adobe AEM.
> Example:
> {code}
> org.apache.sling.repoinit.parser.impl.ParseException: Encountered " "," ", ""
> at line 115, column 46.
> Was expecting:
> ")" ...
>
> at
> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.generateParseException(RepoInitParserImpl.java:3095)
> [org.apache.sling.repoinit.parser:1.3.2]
> {code}
> if i am not mistaken this should be doable be adding explicit exceptions to
> the grammar.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #26: SLING-11293 improve handling of autocreated properties
sonarcloud[bot] commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/26#issuecomment-1148308823 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=26) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=26=new_coverage=list) [89.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=26=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=26=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=26=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #28: SLING-11248 QueryParser.fromRequest(...) calls possible exceptions sh…
sonarcloud[bot] commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/28#issuecomment-1148304514 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core=28) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=28=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=28=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=28=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=28=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=28=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=28=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=28=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=28=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event] cziegeler commented on a diff in pull request #22: SLING-11379 do not register the same job over and over
cziegeler commented on code in PR #22:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/22#discussion_r890855971
##
src/main/java/org/apache/sling/event/impl/jobs/scheduling/JobScheduleBuilderImpl.java:
##
@@ -19,18 +19,23 @@
package org.apache.sling.event.impl.jobs.scheduling;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.Date;
import java.util.List;
import java.util.Map;
import org.apache.sling.event.impl.support.ScheduleInfoImpl;
import org.apache.sling.event.jobs.JobBuilder.ScheduleBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import org.apache.sling.event.jobs.ScheduledJobInfo;
/**
* The builder implementation for scheduled jobs.
*/
public final class JobScheduleBuilderImpl implements ScheduleBuilder {
+
+private static final Logger logger =
LoggerFactory.getLogger(JobScheduleBuilderImpl.class);
Review Comment:
no need for static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event] cziegeler commented on a diff in pull request #22: SLING-11379 do not register the same job over and over
cziegeler commented on code in PR #22:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/22#discussion_r890855478
##
src/main/java/org/apache/sling/event/impl/jobs/scheduling/JobScheduleBuilderImpl.java:
##
@@ -117,4 +126,31 @@ public ScheduleBuilder suspend() {
this.suspend = true;
return this;
}
+
+/**
+ * In case a scheduleName was not provided we calculate on based on the
available
+ * data so we can detect duplicates.
+ * @return a value which is identical for identical jobs
+ */
+private String deriveScheduleName() {
+StringBuilder sb = new StringBuilder();
+sb.append("topic="+topic)
+.append(",suspend=" + suspend)
+.append(",");
+
+if (properties != null) {
+// sort the properties and flatten them into a string
+List keys = new ArrayList<>(properties.keySet());
+Collections.sort(keys);
+for (String key: keys) {
+
sb.append(key).append("=").append(properties.get(key)).append(",");
+}
+}
+// append all schedules
+sb.append("schedules=").append(schedules);
+
+String hashCode = new String("" + sb.toString().hashCode());
Review Comment:
String.valueOf ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] tyge68 opened a new pull request, #28: SLING-11248 QueryParser.fromRequest(...) calls possible exceptions sh…
tyge68 opened a new pull request, #28: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/28 …ould be returned as 400 As described on SLING-11248 it returns 500 errors, while this kind of request should be returned with 400 as it is most likely due to a bad request. Feel free to adjust this PR as you need it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SLING-9068) Add more context to ParseException
[
https://issues.apache.org/jira/browse/SLING-9068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17550837#comment-17550837
]
Bertrand Delacretaz edited comment on SLING-9068 at 6/7/22 7:05 AM:
I guess what's needed is to include a relevant excerpt of the failing script in
the error output, maybe something like
{code}
org.apache.sling.repoinit.parser.impl.ParseException: Encountered " "," ", ""
at line 115, column 46.
Was expecting:
")" ...
Here's the last few lines, where ===> marks the one that causes the error:
create path /content(sling:OrderedFolder)
112 set ACL for anonymous
113 allow jcr:read on /etc/something
114 allow jcr:read on /etc/somethingelse
115 ===> created pathes /allwrong
{code}
As mentioned, I haven't looked yet at how to implement this, just meant to
clarify the requirements.
was (Author: bdelacretaz):
I guess what's needed is to include a relevant excerpt of the failing script in
the error output, maybe something like
{code}
org.apache.sling.repoinit.parser.impl.ParseException: Encountered " "," ", ""
at line 115, column 46.
Was expecting:
")" ...
Here's the last few lines, where ===> marks the one that causes the error:
create path /content(sling:OrderedFolder)
set ACL for anonymous
allow jcr:read on /etc/something
allow jcr:read on /etc/somethingelse
===> created pathes /allwrong
{code}
As mentioned, I haven't looked yet at how to implement this, just meant to
clarify the requirements.
> Add more context to ParseException
> --
>
> Key: SLING-9068
> URL: https://issues.apache.org/jira/browse/SLING-9068
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit Parser 1.6.2
>Reporter: Angela Schreiber
>Priority: Minor
>
> today the repo init grammar doesn't come with dedicated exception handing and
> thus the parser will fail with messages that can make it hard to spot actual
> problem... specially in a lengthy repo-init as it is present with Adobe AEM.
> Example:
> {code}
> org.apache.sling.repoinit.parser.impl.ParseException: Encountered " "," ", ""
> at line 115, column 46.
> Was expecting:
> ")" ...
>
> at
> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.generateParseException(RepoInitParserImpl.java:3095)
> [org.apache.sling.repoinit.parser:1.3.2]
> {code}
> if i am not mistaken this should be doable be adding explicit exceptions to
> the grammar.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SLING-9068) Add more context to ParseException
[
https://issues.apache.org/jira/browse/SLING-9068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17550837#comment-17550837
]
Bertrand Delacretaz commented on SLING-9068:
I guess what's needed is to include a relevant excerpt of the failing script in
the error output, maybe something like
{code}
org.apache.sling.repoinit.parser.impl.ParseException: Encountered " "," ", ""
at line 115, column 46.
Was expecting:
")" ...
Here's the last few lines, where ===> marks the one that causes the error:
create path /content(sling:OrderedFolder)
set ACL for anonymous
allow jcr:read on /etc/something
allow jcr:read on /etc/somethingelse
===> created pathes /allwrong
{code}
As mentioned, I haven't looked yet at how to implement this, just meant to
clarify the requirements.
> Add more context to ParseException
> --
>
> Key: SLING-9068
> URL: https://issues.apache.org/jira/browse/SLING-9068
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit Parser 1.6.2
>Reporter: Angela Schreiber
>Priority: Minor
>
> today the repo init grammar doesn't come with dedicated exception handing and
> thus the parser will fail with messages that can make it hard to spot actual
> problem... specially in a lengthy repo-init as it is present with Adobe AEM.
> Example:
> {code}
> org.apache.sling.repoinit.parser.impl.ParseException: Encountered " "," ", ""
> at line 115, column 46.
> Was expecting:
> ")" ...
>
> at
> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.generateParseException(RepoInitParserImpl.java:3095)
> [org.apache.sling.repoinit.parser:1.3.2]
> {code}
> if i am not mistaken this should be doable be adding explicit exceptions to
> the grammar.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (SLING-11367) Potential NPE as ResolveContext.getProviderState() is nullable
[
https://issues.apache.org/jira/browse/SLING-11367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber resolved SLING-11367.
--
Fix Version/s: JCR Resource 3.2.2
Resolution: Fixed
> Potential NPE as ResolveContext.getProviderState() is nullable
> ---
>
> Key: SLING-11367
> URL: https://issues.apache.org/jira/browse/SLING-11367
> Project: Sling
> Issue Type: Sub-task
> Components: JCR
>Affects Versions: JCR Resource 3.2.0
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: JCR Resource 3.2.2
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> since {{ResolveContext.getProviderState()}} is defined to return a nullable
> provider state code analysis spots this a potential source for NPE. according
> to [~cziegeler] this should never return null as long as the provider is
> active.
> i would suggest to move access to session, resourcefactory and helperdata to
> a utility with comments on why the NPE should not occur.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [sling-org-apache-sling-jcr-resource] anchela merged pull request #26: SLING-11367 : Potential NPE as ResolveContext.getProviderState() is nullable
anchela merged PR #26: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] tyge68 closed pull request #18: SLING-10118 Fully cache GraphQLSchema
tyge68 closed pull request #18: SLING-10118 Fully cache GraphQLSchema URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
