[jira] [Created] (SLING-11487) getNodes method inconsistent with behavior of getNode when using FsNodes to load content resources
Mahidhar Chaluvadi created SLING-11487: -- Summary: getNodes method inconsistent with behavior of getNode when using FsNodes to load content resources Key: SLING-11487 URL: https://issues.apache.org/jira/browse/SLING-11487 Project: Sling Issue Type: Bug Reporter: Mahidhar Chaluvadi Unsure if this is the right place to log this issue, please advise if its not the case. Was using WCM IO & Sling Mocks to load Vault FS content. In the process faced multiple issues like not being able to use Modifiable Map on Assets etc. So thought of doing a workaround of loading Vault FS content then convert to json and reload as there is no issue with json content in the end. In this process found that the FsNode object that gets associated with content file only retrieves jcr content node but not the other children looking for the child entries just from content file. However if you use the getNode method instead of getNodes and pass the name pattern, it does retrieve the other folders or nodes present. This behavior seems to be inconsistent considering the typical behavior of jcr. Appreciate if you can guide us on this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #29: SLING-11458 - fixed a regresssion for the original Ticket SLING-9626
sonarcloud[bot] commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1191832680 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core=29) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=29=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=29=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=29=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=29=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=29=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=29=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=29=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] schaefa commented on pull request #29: SLING-11458 - fixed a regresssion for the original Ticket SLING-9626
schaefa commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1191830068 Updated the code to use a Wrapper to prevent the closure to satisfy the SonarCloud code check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Oak-Based Discovery Service 1.2.38 and Sling Discovery Base 2.0.14
+1 On 2022/07/21 14:46:24 Stefan Egli wrote: > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12351434 > https://issues.apache.org/jira/browse/SLING/fixforversion/12351439 > > There 2 outstanding issues: > https://issues.apache.org/jira/browse/SLING/fixforversion/12352120 > https://issues.apache.org/jira/browse/SLING/fixforversion/12352121 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2657/ > > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2657 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Cheers, > Stefan >
[GitHub] [sling-org-apache-sling-servlet-helpers] sonarcloud[bot] commented on pull request #8: SLING-11486 - Added the support for a Check-for-Closed Test Writer
sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/8#issuecomment-1191779494 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlet-helpers=8) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlet-helpers=8=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlet-helpers=8=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlet-helpers=8=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlet-helpers=8=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlet-helpers=8=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlet-helpers=8=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlet-helpers=8=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlet-helpers=8=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlet-helpers=8=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlet-helpers=8=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlet-helpers=8=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlet-helpers=8=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlet-helpers=8=new_coverage=list) [22.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlet-helpers=8=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlet-helpers=8=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlet-helpers=8=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11486) Allow to use a Writer that check for close as used in Response Context Support
[ https://issues.apache.org/jira/browse/SLING-11486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569618#comment-17569618 ] Andreas Schaefer commented on SLING-11486: -- PR for this ticket can be found here: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/8 > Allow to use a Writer that check for close as used in Response Context Support > -- > > Key: SLING-11486 > URL: https://issues.apache.org/jira/browse/SLING-11486 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Servlet Helpers 1.4.2 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Servlet Helpers 1.4.4 > > Time Spent: 10m > Remaining Estimate: 0h > > A problem with testing GraphQL is that the Unit test does not fail when the > Writer was closed during the invocation. So the Mock Servlet Http Response > should provide a Writer that checks if the writer was already closed to mimic > the actual behavior. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-servlet-helpers] schaefa opened a new pull request, #8: SLING-11486 - Added the support for a Check-for-Closed Test Writer
schaefa opened a new pull request, #8: URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/8 Added a Print Writer that checks for being closed when the Mock Http Servlet Response is marked as such to avoid regressions in the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1191769793 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11486) Allow to use a Writer that check for close as used in Response Context Support
Andreas Schaefer created SLING-11486: Summary: Allow to use a Writer that check for close as used in Response Context Support Key: SLING-11486 URL: https://issues.apache.org/jira/browse/SLING-11486 Project: Sling Issue Type: Improvement Components: Testing Affects Versions: Servlet Helpers 1.4.2 Reporter: Andreas Schaefer Assignee: Andreas Schaefer Fix For: Servlet Helpers 1.4.4 A problem with testing GraphQL is that the Unit test does not fail when the Writer was closed during the invocation. So the Mock Servlet Http Response should provide a Writer that checks if the writer was already closed to mimic the actual behavior. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #34: SLING-11485 - RepoInitValidator to check for content changes contradi…
sonarcloud[bot] commented on PR #34: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/34#issuecomment-1191726200 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=34) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=34=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=34=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=34=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=34=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=34=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=34=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=34=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=34=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=34=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=34=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=34=false=CODE_SMELL) [19 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=34=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=34=new_coverage=list) [45.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=34=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=34=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=34=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-xing-login] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1191722342 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-xing-login=2) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login=2=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-xing-oauth] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1191721818 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-xing-oauth=2) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_duplicated_lines_density=list) [7.3% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] DominikSuess opened a new pull request, #34: SLING-11485 - RepoInitValidator to check for content changes contradi…
DominikSuess opened a new pull request, #34: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/34 …cting repoinit * adjustments to RepositoryInitializer & Factory be able to execute in validation mode * adding validation mbean and repositoryinitializer to execute validation (mbean always in warn mode, service optionally in strict mode) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11483) NodePropertiesVisitor causing session writes on set properties without changed properties
[ https://issues.apache.org/jira/browse/SLING-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Süß updated SLING-11483: Component/s: Repoinit > NodePropertiesVisitor causing session writes on set properties without > changed properties > - > > Key: SLING-11483 > URL: https://issues.apache.org/jira/browse/SLING-11483 > Project: Sling > Issue Type: Bug > Components: Repoinit >Reporter: Dominik Süß >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Executing Repoinit twice without contradicting statements should cause no > writes, so the session returned by the visitors should return false for > session.hasPendingChanges() > The way the NodePropertiesVisitor is implemented the properties are always > written if this is no defaults statement. While this satisfies the contract > that for "default" there should be no writes in case properties are already > present it does even cause a write in case there are no changes what so > ever. The behavior of JCR is that in case the same properties are written > this is equivalent to a touch (and would likely update the last modified > field, although not verified) Adding a comparison for the set scenario to > avoid writting properties if the target state already matches the definition > eliminates the false change indicator. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11483) NodePropertiesVisitor causing session writes on set properties without changed properties
[ https://issues.apache.org/jira/browse/SLING-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Süß updated SLING-11483: Affects Version/s: Repoinit JCR 1.1.40 > NodePropertiesVisitor causing session writes on set properties without > changed properties > - > > Key: SLING-11483 > URL: https://issues.apache.org/jira/browse/SLING-11483 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.40 >Reporter: Dominik Süß >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Executing Repoinit twice without contradicting statements should cause no > writes, so the session returned by the visitors should return false for > session.hasPendingChanges() > The way the NodePropertiesVisitor is implemented the properties are always > written if this is no defaults statement. While this satisfies the contract > that for "default" there should be no writes in case properties are already > present it does even cause a write in case there are no changes what so > ever. The behavior of JCR is that in case the same properties are written > this is equivalent to a touch (and would likely update the last modified > field, although not verified) Adding a comparison for the set scenario to > avoid writting properties if the target state already matches the definition > eliminates the false change indicator. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11485) RepoInitValidator to check for content changes contradicting repoinit
Dominik Süß created SLING-11485: --- Summary: RepoInitValidator to check for content changes contradicting repoinit Key: SLING-11485 URL: https://issues.apache.org/jira/browse/SLING-11485 Project: Sling Issue Type: New Feature Components: Repoinit Reporter: Dominik Süß To be able to detect changes of other logic (e.g. via package-init) that reverts changes performed by repoinit it is necessary to detect if repoinit would cause writes. The proposed feature a) registers a secondary repository initializer running after packageinit to either warn (default) or optionally fail in case applying repoinit would contain effective changes - this is determined by not commiting the session but passing in flag for validation that allows to either fail strict, warn or not run in validation mode (and therefore rather apply) in case changes are present b) for development cases or checks at runtime a jmx mBean is registered that allows to run such a check on demand. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE] Release Apache Sling Oak-Based Discovery Service 1.2.38 and Sling Discovery Base 2.0.14
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12351434 https://issues.apache.org/jira/browse/SLING/fixforversion/12351439 There 2 outstanding issues: https://issues.apache.org/jira/browse/SLING/fixforversion/12352120 https://issues.apache.org/jira/browse/SLING/fixforversion/12352121 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2657/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2657 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Cheers, Stefan
[jira] [Updated] (SLING-9625) DiscoveryServiceImpl#doUpdateProperties may fail due to a LoginException
[
https://issues.apache.org/jira/browse/SLING-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated SLING-9625:
---
Fix Version/s: Discovery Oak 1.2.40
(was: Discovery Oak 1.2.38)
> DiscoveryServiceImpl#doUpdateProperties may fail due to a LoginException
> -
>
> Key: SLING-9625
> URL: https://issues.apache.org/jira/browse/SLING-9625
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Discovery Oak 1.2.30
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Discovery Oak 1.2.40
>
>
> While stopping the OSGi container (Sling Starter 12 SNAPSHOT) I observed the
> following error
> {code}
> 03.08.2020 10:30:06.262 *INFO * [Apache Sling Terminator] Stopping Apache
> Sling
> ERROR: bundle org.apache.sling.discovery.oak:1.2.28
> (139)[org.apache.sling.discovery.oak.OakDiscoveryService(200)] : The
> updatedPropertyProvider method has thrown an exception
> java.lang.RuntimeException: Could not log in to repository
> (org.apache.sling.api.resource.LoginException: Cannot derive user name for
> bundle org.apache.sling.discovery.oak [139] and sub service null)
> at
> org.apache.sling.discovery.oak.OakDiscoveryService.doUpdateProperties(OakDiscoveryService.java:540)
> at
> org.apache.sling.discovery.oak.OakDiscoveryService.bindPropertyProviderInteral(OakDiscoveryService.java:406)
> at
> org.apache.sling.discovery.oak.OakDiscoveryService.updatedPropertyProvider(OakDiscoveryService.java:421)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:242)
> at
> org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
> at
> org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:678)
> at
> org.apache.felix.scr.impl.inject.methods.BaseMethod$NotResolved.invoke(BaseMethod.java:633)
> at
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:524)
> at
> org.apache.felix.scr.impl.inject.methods.BindMethod.invoke(BindMethod.java:42)
> at
> org.apache.felix.scr.impl.manager.DependencyManager.invokeUpdatedMethod(DependencyManager.java:1934)
> at
> org.apache.felix.scr.impl.manager.SingleComponentManager.invokeUpdatedMethod(SingleComponentManager.java:448)
> at
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.modifiedService(DependencyManager.java:366)
> at
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.modifiedService(DependencyManager.java:297)
> at
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerModified(ServiceTracker.java:1229)
> at
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerModified(ServiceTracker.java:1137)
> at
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:883)
> at
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1168)
> at
> org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:125)
> at
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
> at
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
> at
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
> at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
> at org.apache.felix.framework.Felix.access$000(Felix.java:112)
> at org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:434)
> at
> org.apache.felix.framework.ServiceRegistry.servicePropertiesModified(ServiceRegistry.java:601)
> at
> org.apache.felix.framework.ServiceRegistrationImpl.setProperties(ServiceRegistrationImpl.java:132)
> at
> org.apache.sling.event.impl.jobs.JobConsumerManager.unbindService(JobConsumerManager.java:354)
> at
> org.apache.sling.event.impl.jobs.JobConsumerManager.unbindJobExecutor(JobConsumerManager.java:270)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at
[jira] [Updated] (SLING-5598) Exclude slow tests by default with assume(sling.slow.tests.enabled)
[
https://issues.apache.org/jira/browse/SLING-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated SLING-5598:
---
Fix Version/s: Discovery Base 2.0.16
Discovery Oak 1.2.40
(was: Discovery Base 2.0.14)
(was: Discovery Oak 1.2.38)
> Exclude slow tests by default with assume(sling.slow.tests.enabled)
>
>
> Key: SLING-5598
> URL: https://issues.apache.org/jira/browse/SLING-5598
> Project: Sling
> Issue Type: Task
> Components: Extensions
>Affects Versions: Discovery Impl 1.2.6, Discovery Base 1.1.2, Discovery
> Commons 1.0.10, Discovery Oak 1.2.6
>Reporter: Stefan Egli
>Priority: Major
> Fix For: Discovery Impl 1.2.14, Discovery Commons 1.0.28,
> Discovery Base 2.0.16, Discovery Oak 1.2.40
>
> Attachments: SLING-5598-commons-testing.patch,
> SLING-5598-discovery.patch
>
>
> As suggested by [~bdelacretaz] on [the
> list|http://markmail.org/message/yad5awqg53epk3ck] we should improve test
> duration (ideally 1-2min per bundle max, 10-15min overall). While they are
> not yet improved however, slow tests should be excluded by default and run
> only if enabled explicitly. Here's an example {{@Before}} method to achieve
> that:
> {noformat}
> @Before
> public void checkSlowTests() {
> assumeNotNull(System.getProperty("sling.slow.tests.enabled"));
> }
> {noformat}
> and to enable the slow tests you do: {{mvn -Dsling.slow.tests.enabled=true
> clean test}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli commented on pull request #5: SLING-11355: sling discovery bundles: update to sling 48
stefan-egli commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/5#issuecomment-1191537158 would suggest to re-release discovery.oak once this PR is merged together with discovery.commons, which also has a change from SLING-11355 not yet released -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11450) Partially started instance suppression can lead to unwanted leader loss
[ https://issues.apache.org/jira/browse/SLING-11450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved SLING-11450. - Resolution: Fixed > Partially started instance suppression can lead to unwanted leader loss > --- > > Key: SLING-11450 > URL: https://issues.apache.org/jira/browse/SLING-11450 > Project: Sling > Issue Type: Bug > Components: Discovery >Affects Versions: Discovery Base 2.0.12, Discovery Oak 1.2.36 >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Major > Fix For: Discovery Base 2.0.14, Discovery Oak 1.2.38 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > SLING-10489 introduced "partial startup suppression" sometimes also referred > to as "joinerdelay" (even though the latter is actually a subfeature of the > former). > With this suppression enabled (it is disabled by default), upon a topology > change the leader instance can loose its leader status even though it did not > actually leave the topology or crash. This is against the discovery API > contract, which says that the leader stays leader until it crashes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11450) Partially started instance suppression can lead to unwanted leader loss
[ https://issues.apache.org/jira/browse/SLING-11450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569456#comment-17569456 ] Stefan Egli commented on SLING-11450: - * merged both PRs * releasing both bundles next > Partially started instance suppression can lead to unwanted leader loss > --- > > Key: SLING-11450 > URL: https://issues.apache.org/jira/browse/SLING-11450 > Project: Sling > Issue Type: Bug > Components: Discovery >Affects Versions: Discovery Base 2.0.12, Discovery Oak 1.2.36 >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Major > Fix For: Discovery Base 2.0.14, Discovery Oak 1.2.38 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > SLING-10489 introduced "partial startup suppression" sometimes also referred > to as "joinerdelay" (even though the latter is actually a subfeature of the > former). > With this suppression enabled (it is disabled by default), upon a topology > change the leader instance can loose its leader status even though it did not > actually leave the topology or crash. This is against the discovery API > contract, which says that the leader stays leader until it crashes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli merged pull request #7: SLING-11450 : avoid suppressing instances that were seen previously
stefan-egli merged PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11484) Allow richer AbstractInputStreamPipe http requests
Nicolas Peltier created SLING-11484: --- Summary: Allow richer AbstractInputStreamPipe http requests Key: SLING-11484 URL: https://issues.apache.org/jira/browse/SLING-11484 Project: Sling Issue Type: Improvement Components: pipes Affects Versions: pipes 4.4.2 Reporter: Nicolas Peltier AbstractInputStreamPipe should allow: * POST methods (not in dry run), * request headers -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-discovery-oak] ashokmca07 commented on pull request #5: SLING-11355: sling discovery bundles: update to sling 48
ashokmca07 commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/5#issuecomment-1191507235 > @ashokmca07 I was planning to do a discovery.base and discovery.oak release today and was wondering if that's fine for you as it would likely not include this PR yet. But I guess we can do a follow-up release at any future time anyway, so I don't see any issue from that side. sure, it make sense. and this PR doesn’t need to be part of today's release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-oak] sonarcloud[bot] commented on pull request #7: SLING-11450 : avoid suppressing instances that were seen previously
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/7#issuecomment-1191492847 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-discovery-oak=7) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=7=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=7=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=7=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=CODE_SMELL) [34 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=7=new_coverage=list) [91.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=7=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=7=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=7=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-oak] sonarcloud[bot] commented on pull request #5: SLING-11355: sling discovery bundles: update to sling 48
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/5#issuecomment-1191490475 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-discovery-oak=5) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=5=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=5=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=5=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=5=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=5=false=CODE_SMELL) [18 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=5=new_coverage=list) [39.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=5=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=5=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=5=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli commented on pull request #5: SLING-11355: sling discovery bundles: update to sling 48
stefan-egli commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/5#issuecomment-1191438173 @ashokmca07 I was planning to do a discovery.base and discovery.oak release today and was wondering if that's fine for you as it would likely not include this PR yet. But I guess we can do a follow-up release at any future time anyway, so I don't see any issue from that side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] DominikSuess opened a new pull request, #33: SLING-11483 - NodePropertiesVisitor causing session writes on set pro…
DominikSuess opened a new pull request, #33: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/33 …perties without changed properties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11483) NodePropertiesVisitor causing session writes on set properties without changed properties
Dominik Süß created SLING-11483: --- Summary: NodePropertiesVisitor causing session writes on set properties without changed properties Key: SLING-11483 URL: https://issues.apache.org/jira/browse/SLING-11483 Project: Sling Issue Type: Bug Reporter: Dominik Süß Executing Repoinit twice without contradicting statements should cause no writes, so the session returned by the visitors should return false for session.hasPendingChanges() The way the NodePropertiesVisitor is implemented the properties are always written if this is no defaults statement. While this satisfies the contract that for "default" there should be no writes in case properties are already present it does even cause a write in case there are no changes what so ever. The behavior of JCR is that in case the same properties are written this is equivalent to a touch (and would likely update the last modified field, although not verified) Adding a comparison for the set scenario to avoid writting properties if the target state already matches the definition eliminates the false change indicator. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli commented on pull request #7: SLING-11450 : avoid suppressing instances that were seen previously
stefan-egli commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/7#issuecomment-1191366995 jenkins builds fine now. @mreutegg , I sort of read your comment as an official +1? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #351 is BROKEN
ster/.git # timeout=10
> git config remote.origin.url
> https://github.com/apache/sling-org-apache-sling-starter.git # timeout=10
Fetching upstream changes from
https://github.com/apache/sling-org-apache-sling-starter.git
> git --version # timeout=10
> git --version # 'git version 2.17.1'
using GIT_ASKPASS to set credentials Personal access token for Github
repository access. Use with Apache Sling jobs only.
> git fetch --no-tags --progress --
> https://github.com/apache/sling-org-apache-sling-starter.git
> +refs/heads/master:refs/remotes/origin/master # timeout=10
Checking out Revision 0be9a3b84bdcde6ccaa21f1ac9071eff20f818b7 (master)
Commit message: "Update to slingfeature-maven-plugin:1.6.6"
> git config core.sparsecheckout # timeout=10
> git checkout -f 0be9a3b84bdcde6ccaa21f1ac9071eff20f818b7 # timeout=10
GitHub has been notified of this commit’s build result
[Pipeline] withMaven
[withMaven] Options: []
[withMaven] Available options:
[withMaven] using JDK installation jdk_1.8_latest
[withMaven] using Maven installation 'maven_3_latest'
[Pipeline] {
[Pipeline] sh
+ mvn clean compile -Dit.startTimeoutSeconds=120
- withMaven Wrapper script -
Picked up JAVA_TOOL_OPTIONS:
-Dmaven.ext.class.path="/home/jenkins/workspace/_org-apache-sling-starter_master@tmp/withMavenb54cc696/pipeline-maven-spy.jar"
-Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/jenkins/workspace/_org-apache-sling-starter_master@tmp/withMavenb54cc696"
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: /home/jenkins/tools/maven/latest3
Java version: 1.8.0_291, vendor: Oracle Corporation, runtime:
/usr/local/asfpackages/java/oraclejdk-1.8.0-291/jre
Default locale: en_US, platform encoding: ISO-8859-1
OS name: "linux", version: "4.15.0-151-generic", arch: "amd64", family: "unix"
[INFO] [jenkins-event-spy] Generate
/home/jenkins/workspace/_org-apache-sling-starter_master@tmp/withMavenb54cc696/maven-spy-20220721-111723-9226354003238557456071.log.tmp
...
[INFO] Scanning for projects...
[WARNING] The POM for
org.apache.sling:org.apache.sling.feature.analyser:jar:1.6.6 is missing, no
dependency information available
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] Unresolveable build extension: Plugin
org.apache.sling:slingfeature-maven-plugin:1.6.6 or one of its dependencies
could not be resolved:
org.apache.sling:org.apache.sling.feature.analyser:jar:1.6.6 was not found in
https://repo.maven.apache.org/maven2 during a previous attempt. This failure
was cached in the local repository and resolution is not reattempted until the
update interval of central has elapsed or updates are forced @
@
[INFO] [jenkins-event-spy] Generated
/home/jenkins/workspace/_org-apache-sling-starter_master@tmp/withMavenb54cc696/maven-spy-20220721-111723-9226354003238557456071.log
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project org.apache.sling:org.apache.sling.starter:13-SNAPSHOT
(/home/jenkins/workspace/_org-apache-sling-starter_master/pom.xml) has 1 error
[ERROR] Unresolveable build extension: Plugin
org.apache.sling:slingfeature-maven-plugin:1.6.6 or one of its dependencies
could not be resolved:
org.apache.sling:org.apache.sling.feature.analyser:jar:1.6.6 was not found in
https://repo.maven.apache.org/maven2 during a previous attempt. This failure
was cached in the local repository and resolution is not reattempted until the
update interval of central has elapsed or updates are forced -> [Help 2]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2]
http://cwiki.apache.org/confluence/display/MAVEN/PluginManagerException
[Pipeline] }
[withMaven] Publishers:
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] stage
[Pipeline] { (Notifications)
[Pipeline] echo
Status change is BROKEN, notifications will be sent.
[Pipeline] emailext
[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #33: SLING-11482 : Redundant checks for null
sonarcloud[bot] commented on PR #33: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/33#issuecomment-1191283493 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-resource=33) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=33=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=33=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=33=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=33=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=33=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=33=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=33=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=33=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=33=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=33=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=33=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=33=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=33=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=33=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=33=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=33=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] anchela opened a new pull request, #33: SLING-11482 : Redundant checks for null
anchela opened a new pull request, #33: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/33 hi @joerghoh , @cziegeler , please let me know if you have any concerns with the proposed fix. according to nullability annotations all those checks for a param/return value being null are redundant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11482) Redundant checks for null
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11482: - Fix Version/s: JCR Resource 3.2.2 > Redundant checks for null > - > > Key: SLING-11482 > URL: https://issues.apache.org/jira/browse/SLING-11482 > Project: Sling > Issue Type: Bug > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Minor > Fix For: JCR Resource 3.2.2 > > > https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource > reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11482) Redundant checks for null
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11482: - Issue Type: Improvement (was: Bug) > Redundant checks for null > - > > Key: SLING-11482 > URL: https://issues.apache.org/jira/browse/SLING-11482 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Minor > Fix For: JCR Resource 3.2.2 > > > https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource > reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11482) Redundant checks for null
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber reassigned SLING-11482: Assignee: Angela Schreiber > Redundant checks for null > - > > Key: SLING-11482 > URL: https://issues.apache.org/jira/browse/SLING-11482 > Project: Sling > Issue Type: Bug > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Minor > > https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource > reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11482) Redundant checks for null
Angela Schreiber created SLING-11482: Summary: Redundant checks for null Key: SLING-11482 URL: https://issues.apache.org/jira/browse/SLING-11482 Project: Sling Issue Type: Bug Components: JCR Reporter: Angela Schreiber https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11482) Redundant checks for null
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11482: - Priority: Major (was: Minor) > Redundant checks for null > - > > Key: SLING-11482 > URL: https://issues.apache.org/jira/browse/SLING-11482 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: JCR Resource 3.2.2 > > > https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource > reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11311) Improve org-apache-sling-jcr-resource
[ https://issues.apache.org/jira/browse/SLING-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-11311. -- Resolution: Fixed > Improve org-apache-sling-jcr-resource > - > > Key: SLING-11311 > URL: https://issues.apache.org/jira/browse/SLING-11311 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 3.2.0 >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: JCR Resource 3.2.2 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > while working on SLING-10011 i noticed a considerable amount of issues > reported by sonar, which are trivial to fix and would improve overall code > quality. > apart from sonar findings we should fix > - inconsistent formatting > - unused imports > - missing nullable/notnull annotations > - complexity -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-discovery-oak] ashokmca07 commented on pull request #5: SLING-11355: sling discovery bundles: update to sling 48
ashokmca07 commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/5#issuecomment-1191247842 will wait until [PR](https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/7) merge FYI: @stefan-egli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11468) Simplify JcrPropertyMapCacheEntry.convertToType
[ https://issues.apache.org/jira/browse/SLING-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-11468. -- Fix Version/s: JCR Resource 3.2.2 Resolution: Fixed > Simplify JcrPropertyMapCacheEntry.convertToType > --- > > Key: SLING-11468 > URL: https://issues.apache.org/jira/browse/SLING-11468 > Project: Sling > Issue Type: Sub-task > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: JCR Resource 3.2.2 > > Time Spent: 1h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-jcr-resource] anchela merged pull request #31: SLING-11468 : Simplify JcrPropertyMapCacheEntry.convertToType
anchela merged PR #31: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] anchela commented on pull request #31: SLING-11468 : Simplify JcrPropertyMapCacheEntry.convertToType
anchela commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/31#issuecomment-1191145185 @joerghoh , can you take a look at my changes again an (hopefully) approve? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-oak] sonarcloud[bot] commented on pull request #7: SLING-11450 : avoid suppressing instances that were seen previously
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/7#issuecomment-1191127105 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-discovery-oak=7) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=7=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=7=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=7=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=CODE_SMELL) [34 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=7=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=7=new_coverage=list) [91.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=7=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=7=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=7=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
