Re: [VOTE] Release Apache Sling Auth Core version 1.6.0, JUnit Scriptable Tests Provider version 1.0.14

2022-09-26 Thread Carsten Ziegeler

+1

Carsten

Am 26.09.2022 um 21:52 schrieb Eric Norman:

Hi,

We solved 4 issues in the Auth Core release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12352309

We solved 2 issues in the JUnit Scriptable Tests Provider release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12352330


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2682/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2682 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.



--
Carsten Ziegeler
Adobe
cziege...@apache.org


Re: [Engine] Problems with Engine 2.12.0 [was [VOTE] Release Apache Sling Engine 2.12.0]

2022-09-26 Thread Carsten Ziegeler

Thanks Eric!

Am 26.09.2022 um 20:00 schrieb Eric Norman:

Hi Carsten,

Thanks for taking a look and providing the fix.  I can also confirm that
the starter tests work fine after updating the starter with:
org.apache.sling:org.apache.sling.engine:2.12.0 +
org.apache.sling.auth.core:1.5.9-SNAPSHOT +
org.apache.sling.junit.scriptable:1.0.13-SNAPSHOT

I was already doing some unrelated work in auth.core, so I can wrap that up
today and get the releases started.

Regards,
Eric

On Mon, Sep 26, 2022 at 6:37 AM Carsten Ziegeler 
wrote:


+1, I can't help with releases atm, so either someone else can step in
or I can do it end of week

Regards
Carsten

Am 26.09.2022 um 14:54 schrieb Robert Munteanu:

Should we start votes for the two new bundles so that we have stable
Starter ITs?

On Mon, 2022-09-26 at 09:32 +0200, Carsten Ziegeler wrote:

The failing tests are actually caused by

a) https://issues.apache.org/jira/browse/SLING-11598 - a "bug" in
auth
core which lets the authentication support re-register on
configuration
change. This should not happen. With Engine 2.12.0 it causes the
engine
to restart. In general, this is not a bug as after some time of
reconfiguration, everything is up and stable again. However, this can
be
easily avoided by fixing auth core and is actually a regression of
auth
core introduced a while back due to refactorings.
b) https://issues.apache.org/jira/browse/SLING-11597 - a bug in junit
scriptable which is implementing servlet request/response interfaces
by
hand (which really should be avoided). Sling engine is expecting
servlet
api 3.0 to work, junit scriptable is not implementing it properly. I
added a workaround

With both issues fixed, starter tests run totally fine on my machine

Regards
Carsten

Am 26.09.2022 um 07:35 schrieb Carsten Ziegeler:

With Engine 2.12.0 I get consistently these failing tests:

[ERROR] Failures:
[ERROR]
DavExDisabledAnonAccessTest>DavExIntegrationTest.tearDown:90-

configureServerAfterTest:33->HttpTestBase.assertPostStatus:412

Unable to enable anonymous access expected:<200> but was:<404>
[ERROR]
DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:46-

configureServerBeforeTest:40->HttpTestBase.assertPostStatus:412

Unable to disable anonymous access expected:<200> but was:<404>
[ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70
Expected redirect expected:<302> but was:<401>
[ERROR]
PostSendErrorTest.testNotSuccessfulWithHtmlResponseAndSendError:48-

HttpTestBase.getContent:457 Expected status 500 for

http://localhost:38719/PostSendErrorTest/1664170496409 (content=)
expected:<500> but was:<401>
[ERROR]
PostSendErrorTest.testNotSuccessfulWithJsonResponseAndSendError:88-

HttpTestBase.getContent:457 Expected status 500 for

http://localhost:38719/PostSendErrorTest/1664170496409 (content=)
expected:<500> but was:<401>
[ERROR] Errors:
[ERROR]   ServerSideScriptsTest.runScripts:235 » JsonGeneration
write(param) is only val...
[INFO]
[ERROR] Tests run: 572, Failures: 5, Errors: 1, Skipped: 1

Regards
Carsten

Am 26.09.2022 um 06:59 schrieb Carsten Ziegeler:

It seems I cannot even run the starter tests with Engine 2.11.0 -
Sling does not start within a minute

Regards
Carsten

Am 26.09.2022 um 06:47 schrieb Carsten Ziegeler:

I did extensive tests with that engine version and didn't run
into
problems. I don't know much about the tests but maybe they make
assumptions which do not hold true anymore.

We need to dig into this and see what is going on

Regards
Carsten

Am 22.09.2022 um 21:34 schrieb Eric Norman:

-1 for me since I could not successfully run the starter
integration
tests
with this version.  Were you expecting that changes would be
required in
the tests to compensate for the changes?

I get anywhere from 4 to 100+ various test failures during
each
build of
the latest starter project after switching to v2.12.0 of the
engine.

Regards,
-Eric













--
Carsten Ziegeler
Adobe
cziege...@apache.org





--
Carsten Ziegeler
Adobe
cziege...@apache.org


[VOTE] Release Apache Sling Auth Core version 1.6.0, JUnit Scriptable Tests Provider version 1.0.14

2022-09-26 Thread Eric Norman
Hi,

We solved 4 issues in the Auth Core release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12352309

We solved 2 issues in the JUnit Scriptable Tests Provider release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12352330


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2682/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2682 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


[jira] [Resolved] (SLING-11600) Update to Sling Bundle Parent 49

2022-09-26 Thread Eric Norman (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman resolved SLING-11600.
-
Resolution: Fixed

Fixed at: 
[af3426b|https://github.com/apache/sling-org-apache-sling-auth-core/commit/af3426b05c05491688eb868365df75c5a21946e0]

> Update to Sling Bundle Parent 49
> 
>
> Key: SLING-11600
> URL: https://issues.apache.org/jira/browse/SLING-11600
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Auth Core 1.5.10
>
>
> Update to Sling Bundle Parent 49



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (SLING-11600) Update to Sling Bundle Parent 49

2022-09-26 Thread Eric Norman (Jira)
Eric Norman created SLING-11600:
---

 Summary: Update to Sling Bundle Parent 49
 Key: SLING-11600
 URL: https://issues.apache.org/jira/browse/SLING-11600
 Project: Sling
  Issue Type: Improvement
Reporter: Eric Norman
Assignee: Eric Norman
 Fix For: Auth Core 1.5.10


Update to Sling Bundle Parent 49



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (SLING-11446) Move the DefaultLoginsHealthCheck to the auth core bundle

2022-09-26 Thread Eric Norman (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman resolved SLING-11446.
-
Resolution: Fixed

Merged PR at:  
[{{e8d6ba1}}|https://github.com/apache/sling-org-apache-sling-auth-core/commit/e8d6ba1837a52f39f6d83ea77d37ac6193bb0091]

> Move the DefaultLoginsHealthCheck to the auth core bundle
> -
>
> Key: SLING-11446
> URL: https://issues.apache.org/jira/browse/SLING-11446
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Auth Core 1.5.10
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Move the DefaultLoginsHealthCheck to the auth core bundle.
> Ensure that the dependencies to hc apis in the auth core bundle are optional.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [sling-org-apache-sling-auth-core] enapps-enorman merged pull request #13: SLING-11446 Move the DefaultLoginsHealthCheck to the auth core bundle

2022-09-26 Thread GitBox


enapps-enorman merged PR #13:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/13


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Resolved] (SLING-11599) Update to Sling Parent 49

2022-09-26 Thread Eric Norman (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman resolved SLING-11599.
-
Resolution: Fixed

Fixed at: 
[1279528|https://github.com/apache/sling-org-apache-sling-junit-scriptable/commit/1279528badd11bc1f8fe2dadf2f2eea62442e338]

> Update to Sling Parent 49
> -
>
> Key: SLING-11599
> URL: https://issues.apache.org/jira/browse/SLING-11599
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JUnit Scriptable Tests Provider 1.0.14
>
>
> Update to Sling Parent 49



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (SLING-11599) Update to Sling Parent 49

2022-09-26 Thread Eric Norman (Jira)
Eric Norman created SLING-11599:
---

 Summary: Update to Sling Parent 49
 Key: SLING-11599
 URL: https://issues.apache.org/jira/browse/SLING-11599
 Project: Sling
  Issue Type: Improvement
Reporter: Eric Norman
Assignee: Eric Norman
 Fix For: JUnit Scriptable Tests Provider 1.0.14


Update to Sling Parent 49



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [Engine] Problems with Engine 2.12.0 [was [VOTE] Release Apache Sling Engine 2.12.0]

2022-09-26 Thread Eric Norman
Hi Carsten,

Thanks for taking a look and providing the fix.  I can also confirm that
the starter tests work fine after updating the starter with:
org.apache.sling:org.apache.sling.engine:2.12.0 +
org.apache.sling.auth.core:1.5.9-SNAPSHOT +
org.apache.sling.junit.scriptable:1.0.13-SNAPSHOT

I was already doing some unrelated work in auth.core, so I can wrap that up
today and get the releases started.

Regards,
Eric

On Mon, Sep 26, 2022 at 6:37 AM Carsten Ziegeler 
wrote:

> +1, I can't help with releases atm, so either someone else can step in
> or I can do it end of week
>
> Regards
> Carsten
>
> Am 26.09.2022 um 14:54 schrieb Robert Munteanu:
> > Should we start votes for the two new bundles so that we have stable
> > Starter ITs?
> >
> > On Mon, 2022-09-26 at 09:32 +0200, Carsten Ziegeler wrote:
> >> The failing tests are actually caused by
> >>
> >> a) https://issues.apache.org/jira/browse/SLING-11598 - a "bug" in
> >> auth
> >> core which lets the authentication support re-register on
> >> configuration
> >> change. This should not happen. With Engine 2.12.0 it causes the
> >> engine
> >> to restart. In general, this is not a bug as after some time of
> >> reconfiguration, everything is up and stable again. However, this can
> >> be
> >> easily avoided by fixing auth core and is actually a regression of
> >> auth
> >> core introduced a while back due to refactorings.
> >> b) https://issues.apache.org/jira/browse/SLING-11597 - a bug in junit
> >> scriptable which is implementing servlet request/response interfaces
> >> by
> >> hand (which really should be avoided). Sling engine is expecting
> >> servlet
> >> api 3.0 to work, junit scriptable is not implementing it properly. I
> >> added a workaround
> >>
> >> With both issues fixed, starter tests run totally fine on my machine
> >>
> >> Regards
> >> Carsten
> >>
> >> Am 26.09.2022 um 07:35 schrieb Carsten Ziegeler:
> >>> With Engine 2.12.0 I get consistently these failing tests:
> >>>
> >>> [ERROR] Failures:
> >>> [ERROR]
> >>> DavExDisabledAnonAccessTest>DavExIntegrationTest.tearDown:90-
>  configureServerAfterTest:33->HttpTestBase.assertPostStatus:412
> >>> Unable to enable anonymous access expected:<200> but was:<404>
> >>> [ERROR]
> >>> DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:46-
>  configureServerBeforeTest:40->HttpTestBase.assertPostStatus:412
> >>> Unable to disable anonymous access expected:<200> but was:<404>
> >>> [ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70
> >>> Expected redirect expected:<302> but was:<401>
> >>> [ERROR]
> >>> PostSendErrorTest.testNotSuccessfulWithHtmlResponseAndSendError:48-
>  HttpTestBase.getContent:457 Expected status 500 for
> >>> http://localhost:38719/PostSendErrorTest/1664170496409 (content=)
> >>> expected:<500> but was:<401>
> >>> [ERROR]
> >>> PostSendErrorTest.testNotSuccessfulWithJsonResponseAndSendError:88-
>  HttpTestBase.getContent:457 Expected status 500 for
> >>> http://localhost:38719/PostSendErrorTest/1664170496409 (content=)
> >>> expected:<500> but was:<401>
> >>> [ERROR] Errors:
> >>> [ERROR]   ServerSideScriptsTest.runScripts:235 » JsonGeneration
> >>> write(param) is only val...
> >>> [INFO]
> >>> [ERROR] Tests run: 572, Failures: 5, Errors: 1, Skipped: 1
> >>>
> >>> Regards
> >>> Carsten
> >>>
> >>> Am 26.09.2022 um 06:59 schrieb Carsten Ziegeler:
>  It seems I cannot even run the starter tests with Engine 2.11.0 -
>  Sling does not start within a minute
> 
>  Regards
>  Carsten
> 
>  Am 26.09.2022 um 06:47 schrieb Carsten Ziegeler:
> > I did extensive tests with that engine version and didn't run
> > into
> > problems. I don't know much about the tests but maybe they make
> > assumptions which do not hold true anymore.
> >
> > We need to dig into this and see what is going on
> >
> > Regards
> > Carsten
> >
> > Am 22.09.2022 um 21:34 schrieb Eric Norman:
> >> -1 for me since I could not successfully run the starter
> >> integration
> >> tests
> >> with this version.  Were you expecting that changes would be
> >> required in
> >> the tests to compensate for the changes?
> >>
> >> I get anywhere from 4 to 100+ various test failures during
> >> each
> >> build of
> >> the latest starter project after switching to v2.12.0 of the
> >> engine.
> >>
> >> Regards,
> >> -Eric
> >
> 
> >>>
> >>
> >
> >
>
> --
> Carsten Ziegeler
> Adobe
> cziege...@apache.org
>


[GitHub] [sling-org-apache-sling-auth-core] sonarcloud[bot] commented on pull request #13: SLING-11446 Move the DefaultLoginsHealthCheck to the auth core bundle

2022-09-26 Thread GitBox


sonarcloud[bot] commented on PR #13:
URL: 
https://github.com/apache/sling-org-apache-sling-auth-core/pull/13#issuecomment-1258408579

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-core=13)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=13=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=13=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=13=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=13=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=13=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=13=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-core=13=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-core=13=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-core=13=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=13=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=13=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=13=false=CODE_SMELL)
   
   
[![93.5%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png
 
'93.5%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core=13=new_coverage=list)
 [93.5% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core=13=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core=13=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core=13=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [Engine] Problems with Engine 2.12.0 [was [VOTE] Release Apache Sling Engine 2.12.0]

2022-09-26 Thread Carsten Ziegeler
+1, I can't help with releases atm, so either someone else can step in 
or I can do it end of week


Regards
Carsten

Am 26.09.2022 um 14:54 schrieb Robert Munteanu:

Should we start votes for the two new bundles so that we have stable
Starter ITs?

On Mon, 2022-09-26 at 09:32 +0200, Carsten Ziegeler wrote:

The failing tests are actually caused by

a) https://issues.apache.org/jira/browse/SLING-11598 - a "bug" in
auth
core which lets the authentication support re-register on
configuration
change. This should not happen. With Engine 2.12.0 it causes the
engine
to restart. In general, this is not a bug as after some time of
reconfiguration, everything is up and stable again. However, this can
be
easily avoided by fixing auth core and is actually a regression of
auth
core introduced a while back due to refactorings.
b) https://issues.apache.org/jira/browse/SLING-11597 - a bug in junit
scriptable which is implementing servlet request/response interfaces
by
hand (which really should be avoided). Sling engine is expecting
servlet
api 3.0 to work, junit scriptable is not implementing it properly. I
added a workaround

With both issues fixed, starter tests run totally fine on my machine

Regards
Carsten

Am 26.09.2022 um 07:35 schrieb Carsten Ziegeler:

With Engine 2.12.0 I get consistently these failing tests:

[ERROR] Failures:
[ERROR]
DavExDisabledAnonAccessTest>DavExIntegrationTest.tearDown:90-

configureServerAfterTest:33->HttpTestBase.assertPostStatus:412

Unable to enable anonymous access expected:<200> but was:<404>
[ERROR]
DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:46-

configureServerBeforeTest:40->HttpTestBase.assertPostStatus:412

Unable to disable anonymous access expected:<200> but was:<404>
[ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70
Expected redirect expected:<302> but was:<401>
[ERROR]
PostSendErrorTest.testNotSuccessfulWithHtmlResponseAndSendError:48-

HttpTestBase.getContent:457 Expected status 500 for

http://localhost:38719/PostSendErrorTest/1664170496409 (content=)
expected:<500> but was:<401>
[ERROR]
PostSendErrorTest.testNotSuccessfulWithJsonResponseAndSendError:88-

HttpTestBase.getContent:457 Expected status 500 for

http://localhost:38719/PostSendErrorTest/1664170496409 (content=)
expected:<500> but was:<401>
[ERROR] Errors:
[ERROR]   ServerSideScriptsTest.runScripts:235 » JsonGeneration
write(param) is only val...
[INFO]
[ERROR] Tests run: 572, Failures: 5, Errors: 1, Skipped: 1

Regards
Carsten

Am 26.09.2022 um 06:59 schrieb Carsten Ziegeler:

It seems I cannot even run the starter tests with Engine 2.11.0 -
Sling does not start within a minute

Regards
Carsten

Am 26.09.2022 um 06:47 schrieb Carsten Ziegeler:

I did extensive tests with that engine version and didn't run
into
problems. I don't know much about the tests but maybe they make
assumptions which do not hold true anymore.

We need to dig into this and see what is going on

Regards
Carsten

Am 22.09.2022 um 21:34 schrieb Eric Norman:

-1 for me since I could not successfully run the starter
integration
tests
with this version.  Were you expecting that changes would be
required in
the tests to compensate for the changes?

I get anywhere from 4 to 100+ various test failures during
each
build of
the latest starter project after switching to v2.12.0 of the
engine.

Regards,
-Eric













--
Carsten Ziegeler
Adobe
cziege...@apache.org


Re: Intent to release Sling XSS API 2.3.0

2022-09-26 Thread Robert Munteanu
On Fri, 2022-09-23 at 10:54 -0700, Eric Norman wrote:
> Hi Robert,
> 
> Thanks for clarifying that requiring those 3 additional bundles was
> intentional.  I've confirmed that the starter project builds ok and
> all the
> tests are passing after adding those to the distribution.
> 
> I don't know all the history, but I just thought it was a bit odd
> that a
> private copy of some of the dependencies are embedded in the xss
> bundle and
> others are not.
> 
> In other words, is the XSS bundle trying to be a self-contained uber
> bundle, a slim bundle with the dependencies provided externally, or
> somewhere in between to workaround some problems?

The XSS bundle initially inlined many dependencies because we tried
hard to control the XML stack used for parsing. This has been
problematic historically. Some of the history may not be 100% clear
because this was intially developed internally at Adobe and then
contributed to Sling. Note that we were embedding an XML parser and the
XML APIs jar [1], overriding some of the XML discovery classes [2] and
playing tricks with the classloader for IBM JVMs[3].

IMO the XSS bundle should be slim in terms of dependencies since it's
used by many higher-level bundles. At the same time I prefer not
bundling its dependencies unless needed since that makes upgrading
versions harder.

> 
> The 2.2.20 version has 6.831.549 bytes, while
> > the new one has 4.007.522 bytes. And the good part is that these
> > dependencies are now bundles, so they can be updated without
> > needing to
> > cut a new Sling XSS update.
> > 
> 
> A smaller bundle is indeed an improvement.  Though, ~4MB still seems
> a bit
> large for what this is doing.
> 
> This probably wasn't a primary goal for this change, but was there
> consideration of reducing those duplicate private classes in the XSS
> bundle?  Looks like there are private copies of google-guava, batik,
> various commons-* stuff and a few others embedded there.

We embed Guava because the Java HTML Sanitizer needs it and we
can't/don't want to ships this as a bundle in Sling due to be
problematic versioning policy they have.

There are indeed jars inlined that we could take a look at, but that
was not the goal for the change. I think batik is the greatest
"offender", but since we don't deploy it in the Starter we are not
losing anything for now.

Thanks,
Robert

> 

[1]:
https://github.com/apache/sling-org-apache-sling-xss/blob/d2f92e9de35c66a27caf482f2e1567ac274391d3/pom.xml#L117-L124
[2]:
https://github.com/apache/sling-org-apache-sling-xss/tree/org.apache.sling.xss-2.2.20/src/main/java/javax/xml
[3]:
https://github.com/apache/sling-org-apache-sling-xss/blob/d2f92e9de35c66a27caf482f2e1567ac274391d3/src/main/java/org/apache/sling/xss/impl/PolicyHandler.java#L50-L67
> Regards,
> -Eric
> 
> 
> On Fri, Sep 23, 2022 at 9:22 AM Robert Munteanu 
> wrote:
> 
> > Hi Eric,
> > 
> > On Thu, 2022-09-22 at 11:18 -0700, Eric Norman wrote:
> > > Can someone provide any details about what new dependencies this
> > > version of
> > > XSS API is expected to require?
> > 
> > The main change is that we have moved from the AntiSamy library to
> > the
> > OWASP Java HTML Sanitizer. More details and discussion at [1] and
> > [2].
> > 
> > We keep using the same format for the configuration file, which
> > means
> > that we have to parse the XML somehow. The library that was
> > selected
> > was Jackson - it's widely used, has a good community, and
> > permissively
> > licensed.
> > 
> > The woodstox dependency comes from Jackson. Some time ago I had
> > pushed
> > a commit that updated the Sling Starter to have the additional
> > needed
> > dependencies [3].
> > 
> > That may look like a downside, but keep in mind that the "old"
> > Sling
> > XSS bundle embedded many more dependencies, including XML parsers
> > and
> > was very hard to evolve. The 2.2.20 version has 6.831.549 bytes,
> > while
> > the new one has 4.007.522 bytes. And the good part is that these
> > dependencies are now bundles, so they can be updated without
> > needing to
> > cut a new Sling XSS update.
> > 
> > > 
> > > I couldn't plug the SNAPSHOT build into the starter as it would
> > > not
> > > build
> > > due to unresolved dependencies on packages from jackson-
> > > dataformat-
> > > xml
> > > (and woodstox?).
> > > 
> > > Is there any chance that the code could be refactored to not
> > > require
> > > those
> > > additional dependencies?
> > 
> > Jackson is pretty core to the refactoring. I'm not saying it's
> > impossible, but someone would have to do the legwork for that.
> > 
> > Looking at the Jackon pom it seems that we don't _have to_ use
> > Woodstox, but the code does not seem to work without it right now.
> > 
> > Thanks,
> > Robert
> > 
> > 
> > [1]: https://issues.apache.org/jira/browse/SLING-7231
> > [2]: https://github.com/apache/sling-org-apache-sling-xss/pull/28
> > [3]:
> > 
> > 

[jira] [Commented] (SLING-10064) Switch code signing to use the Digicert code signing service

2022-09-26 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-10064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609483#comment-17609483
 ] 

Konrad Windszus commented on SLING-10064:
-

I requested access for [~rombert] and myself in 
https://issues.apache.org/jira/browse/INFRA-23724.

> Switch code signing to use the Digicert code signing service
> 
>
> Key: SLING-10064
> URL: https://issues.apache.org/jira/browse/SLING-10064
> Project: Sling
>  Issue Type: Task
>  Components: Build and Source Control, IDE
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Sling Eclipse IDE 1.2.4
>
>
> See https://infra.apache.org/digicert-access.html. According to infra this 
> should be easily integrated with the maven-jarsigner-plugin.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (SLING-10064) Switch code signing to use the Digicert code signing service

2022-09-26 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-10064:
---

Assignee: Konrad Windszus

> Switch code signing to use the Digicert code signing service
> 
>
> Key: SLING-10064
> URL: https://issues.apache.org/jira/browse/SLING-10064
> Project: Sling
>  Issue Type: Task
>  Components: Build and Source Control, IDE
>Reporter: Robert Munteanu
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Eclipse IDE 1.2.4
>
>
> See https://infra.apache.org/digicert-access.html. According to infra this 
> should be easily integrated with the maven-jarsigner-plugin.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [Engine] Problems with Engine 2.12.0 [was [VOTE] Release Apache Sling Engine 2.12.0]

2022-09-26 Thread Robert Munteanu
Should we start votes for the two new bundles so that we have stable
Starter ITs?

On Mon, 2022-09-26 at 09:32 +0200, Carsten Ziegeler wrote:
> The failing tests are actually caused by
> 
> a) https://issues.apache.org/jira/browse/SLING-11598 - a "bug" in
> auth 
> core which lets the authentication support re-register on
> configuration 
> change. This should not happen. With Engine 2.12.0 it causes the
> engine 
> to restart. In general, this is not a bug as after some time of 
> reconfiguration, everything is up and stable again. However, this can
> be 
> easily avoided by fixing auth core and is actually a regression of
> auth 
> core introduced a while back due to refactorings.
> b) https://issues.apache.org/jira/browse/SLING-11597 - a bug in junit
> scriptable which is implementing servlet request/response interfaces
> by 
> hand (which really should be avoided). Sling engine is expecting
> servlet 
> api 3.0 to work, junit scriptable is not implementing it properly. I 
> added a workaround
> 
> With both issues fixed, starter tests run totally fine on my machine
> 
> Regards
> Carsten
> 
> Am 26.09.2022 um 07:35 schrieb Carsten Ziegeler:
> > With Engine 2.12.0 I get consistently these failing tests:
> > 
> > [ERROR] Failures:
> > [ERROR] 
> > DavExDisabledAnonAccessTest>DavExIntegrationTest.tearDown:90-
> > >configureServerAfterTest:33->HttpTestBase.assertPostStatus:412
> > Unable to enable anonymous access expected:<200> but was:<404>
> > [ERROR] 
> > DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:46-
> > >configureServerBeforeTest:40->HttpTestBase.assertPostStatus:412
> > Unable to disable anonymous access expected:<200> but was:<404>
> > [ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70
> > Expected redirect expected:<302> but was:<401>
> > [ERROR] 
> > PostSendErrorTest.testNotSuccessfulWithHtmlResponseAndSendError:48-
> > >HttpTestBase.getContent:457 Expected status 500 for
> > http://localhost:38719/PostSendErrorTest/1664170496409 (content=)
> > expected:<500> but was:<401>
> > [ERROR] 
> > PostSendErrorTest.testNotSuccessfulWithJsonResponseAndSendError:88-
> > >HttpTestBase.getContent:457 Expected status 500 for
> > http://localhost:38719/PostSendErrorTest/1664170496409 (content=)
> > expected:<500> but was:<401>
> > [ERROR] Errors:
> > [ERROR]   ServerSideScriptsTest.runScripts:235 » JsonGeneration 
> > write(param) is only val...
> > [INFO]
> > [ERROR] Tests run: 572, Failures: 5, Errors: 1, Skipped: 1
> > 
> > Regards
> > Carsten
> > 
> > Am 26.09.2022 um 06:59 schrieb Carsten Ziegeler:
> > > It seems I cannot even run the starter tests with Engine 2.11.0 -
> > > Sling does not start within a minute
> > > 
> > > Regards
> > > Carsten
> > > 
> > > Am 26.09.2022 um 06:47 schrieb Carsten Ziegeler:
> > > > I did extensive tests with that engine version and didn't run
> > > > into 
> > > > problems. I don't know much about the tests but maybe they make
> > > > assumptions which do not hold true anymore.
> > > > 
> > > > We need to dig into this and see what is going on
> > > > 
> > > > Regards
> > > > Carsten
> > > > 
> > > > Am 22.09.2022 um 21:34 schrieb Eric Norman:
> > > > > -1 for me since I could not successfully run the starter
> > > > > integration 
> > > > > tests
> > > > > with this version.  Were you expecting that changes would be 
> > > > > required in
> > > > > the tests to compensate for the changes?
> > > > > 
> > > > > I get anywhere from 4 to 100+ various test failures during
> > > > > each 
> > > > > build of
> > > > > the latest starter project after switching to v2.12.0 of the
> > > > > engine.
> > > > > 
> > > > > Regards,
> > > > > -Eric
> > > > 
> > > 
> > 
> 




[jira] [Commented] (SLING-11588) Certificate used to sign Sling IDE Tooling for Eclipse expired 02/2021

2022-09-26 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609479#comment-17609479
 ] 

Robert Munteanu commented on SLING-11588:
-

[~kwin] - unfortunately that's not possible until we switch to the new code 
signing service - SLING-10064 .

> Certificate used to sign Sling IDE Tooling for Eclipse expired 02/2021
> --
>
> Key: SLING-11588
> URL: https://issues.apache.org/jira/browse/SLING-11588
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.2.2
>Reporter: Konrad Windszus
>Priority: Major
> Attachments: 82840479001475880637676110500335113906-1.der
>
>
> The certificate which has been used to sign the release 1.2.2 from Sling IDE 
> Tooling for Eclipse expired on 27th of February 2021. That leads to invalid 
> certificate warnings when installing it in newer Eclipse versions.
> You find the expired certificate used for signing attached:  
> [^82840479001475880637676110500335113906-1.der] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-11352) Cannot create path-only mapping rule in /etc/map

2022-09-26 Thread Csaba Varga (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609444#comment-17609444
 ] 

Csaba Varga commented on SLING-11352:
-

I have opened a PR with a proposed fix: 
[https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84]

Could someone please take a look at it?

> Cannot create path-only mapping rule in /etc/map
> 
>
> Key: SLING-11352
> URL: https://issues.apache.org/jira/browse/SLING-11352
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.8.4
>Reporter: Csaba Varga
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I am trying to set up a mapping to make some of our site hierarchy appear on 
> a different URL than what would be dictated by the hierarchy. My goal is to 
> map the path /content/mycompany/locales/some_locale/sectionA to the URL 
> /some_locale/sectionB . (I don't want to override the protocol, host and port 
> fields.) Because we support multiple locales, I need to use a regex for 
> setting up the matches. Here is my original attempt:
> {code:java}
> /etc/map/my_mapping
>  +-- sling:internalRedirect = 
> /content/mycompany/locales/([-a-z]+)/sectionA
>  +-- sling:match = /$1/sectionB{code}
> When this node is present, /content/mycompany/locales/en-us/sectionA/foo gets 
> mapped to /en-us://sectionB/foo instead of the intended /en-us/sectionB/foo.
> I can work around the issue by avoiding forward slashes in sling:match, but 
> this is ugly and unclear :
> {code:java}
> /etc/map/my_mapping
>  +-- sling:internalRedirect = 
> /content/mycompany/locales/([-a-z]+)(/)sectionA
>  +-- sling:match = /$1$2sectionB {code}
> Is this kind of mapping supported at all? I would rather avoid adding the 
> hostname to mapping rules because it is environment-specific.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #84: SLING-11352 - Fix parsing of path-only mappings

2022-09-26 Thread GitBox


sonarcloud[bot] commented on PR #84:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-1257874519

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=84)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL)
   
   
[![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png
 
'100.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_coverage=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-resourceresolver] csaboka opened a new pull request, #84: SLING-11352 - Fix parsing of path-only mappings

2022-09-26 Thread GitBox


csaboka opened a new pull request, #84:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84

   It wasn't possible to add a regular path-only mapping to /etc/map because 
the sling:match property was mis-parsed as a URI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [Engine] Problems with Engine 2.12.0 [was [VOTE] Release Apache Sling Engine 2.12.0]

2022-09-26 Thread Carsten Ziegeler

The failing tests are actually caused by

a) https://issues.apache.org/jira/browse/SLING-11598 - a "bug" in auth 
core which lets the authentication support re-register on configuration 
change. This should not happen. With Engine 2.12.0 it causes the engine 
to restart. In general, this is not a bug as after some time of 
reconfiguration, everything is up and stable again. However, this can be 
easily avoided by fixing auth core and is actually a regression of auth 
core introduced a while back due to refactorings.
b) https://issues.apache.org/jira/browse/SLING-11597 - a bug in junit 
scriptable which is implementing servlet request/response interfaces by 
hand (which really should be avoided). Sling engine is expecting servlet 
api 3.0 to work, junit scriptable is not implementing it properly. I 
added a workaround


With both issues fixed, starter tests run totally fine on my machine

Regards
Carsten

Am 26.09.2022 um 07:35 schrieb Carsten Ziegeler:

With Engine 2.12.0 I get consistently these failing tests:

[ERROR] Failures:
[ERROR] 
DavExDisabledAnonAccessTest>DavExIntegrationTest.tearDown:90->configureServerAfterTest:33->HttpTestBase.assertPostStatus:412 Unable to enable anonymous access expected:<200> but was:<404>
[ERROR] 
DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:46->configureServerBeforeTest:40->HttpTestBase.assertPostStatus:412 Unable to disable anonymous access expected:<200> but was:<404>
[ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70 
Expected redirect expected:<302> but was:<401>
[ERROR] 
PostSendErrorTest.testNotSuccessfulWithHtmlResponseAndSendError:48->HttpTestBase.getContent:457 Expected status 500 for http://localhost:38719/PostSendErrorTest/1664170496409 (content=) expected:<500> but was:<401>
[ERROR] 
PostSendErrorTest.testNotSuccessfulWithJsonResponseAndSendError:88->HttpTestBase.getContent:457 Expected status 500 for http://localhost:38719/PostSendErrorTest/1664170496409 (content=) expected:<500> but was:<401>

[ERROR] Errors:
[ERROR]   ServerSideScriptsTest.runScripts:235 » JsonGeneration 
write(param) is only val...

[INFO]
[ERROR] Tests run: 572, Failures: 5, Errors: 1, Skipped: 1

Regards
Carsten

Am 26.09.2022 um 06:59 schrieb Carsten Ziegeler:
It seems I cannot even run the starter tests with Engine 2.11.0 - 
Sling does not start within a minute


Regards
Carsten

Am 26.09.2022 um 06:47 schrieb Carsten Ziegeler:
I did extensive tests with that engine version and didn't run into 
problems. I don't know much about the tests but maybe they make 
assumptions which do not hold true anymore.


We need to dig into this and see what is going on

Regards
Carsten

Am 22.09.2022 um 21:34 schrieb Eric Norman:
-1 for me since I could not successfully run the starter integration 
tests
with this version.  Were you expecting that changes would be 
required in

the tests to compensate for the changes?

I get anywhere from 4 to 100+ various test failures during each 
build of

the latest starter project after switching to v2.12.0 of the engine.

Regards,
-Eric








--
Carsten Ziegeler
Adobe
cziege...@apache.org


[jira] [Resolved] (SLING-11598) Don't reactivate authenticator on configuration change

2022-09-26 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-11598.
--
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-auth-core/commit/fb8d4c91037e041206c42e2f053ecf410f340fee

> Don't reactivate authenticator on configuration change
> --
>
> Key: SLING-11598
> URL: https://issues.apache.org/jira/browse/SLING-11598
> Project: Sling
>  Issue Type: Improvement
>  Components: Authentication
>Affects Versions: Auth Core 1.5.6, Auth Core 1.5.8
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Auth Core 1.5.10
>
>
> Due to some refactorings of auth core, the Sling Authenticator is currently 
> re-registered if its configuration changes. This has unwanted rippling 
> effects on all components depending on the authentication support service.
> Configuration changes should be handled via modified events internally



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (SLING-11597) AbstractMethodError with Sling Engine 2.12.0

2022-09-26 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-11597.
--
  Assignee: Carsten Ziegeler
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-junit-scriptable/commit/1ed87bd55865e2f7de4f9285bb7814593d5fcfcd

> AbstractMethodError with Sling Engine 2.12.0
> 
>
> Key: SLING-11597
> URL: https://issues.apache.org/jira/browse/SLING-11597
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JUnit Scriptable Tests Provider 1.0.12
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Blocker
> Fix For: JUnit Scriptable Tests Provider 1.0.14
>
>
> 26.09.2022 08:14:55.762 *ERROR* [qtp736626945-45] 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught 
> Throwable
> java.lang.AbstractMethodError: Receiver class 
> org.apache.sling.junit.scriptable.HttpRequest does not define or inherit an 
> implementation of the resolved method 'abstract javax.servlet.ServletContext 
> getServletContext()' of interface javax.servlet.ServletRequest.
> at 
> javax.servlet.ServletRequestWrapper.getServletContext(ServletRequestWrapper.java:370)
>  [org.apache.felix.http.servlet-api:1.1.4]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (SLING-11598) Don't reactivate authenticator on configuration change

2022-09-26 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-11598:


 Summary: Don't reactivate authenticator on configuration change
 Key: SLING-11598
 URL: https://issues.apache.org/jira/browse/SLING-11598
 Project: Sling
  Issue Type: Improvement
  Components: Authentication
Affects Versions: Auth Core 1.5.8, Auth Core 1.5.6
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Auth Core 1.5.10


Due to some refactorings of auth core, the Sling Authenticator is currently 
re-registered if its configuration changes. This has unwanted rippling effects 
on all components depending on the authentication support service.
Configuration changes should be handled via modified events internally



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-11597) AbstractMethodError with Sling Engine 2.12.0

2022-09-26 Thread Carsten Ziegeler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609326#comment-17609326
 ] 

Carsten Ziegeler commented on SLING-11597:
--

Starting with Engine 2.12.0 ServletRequest.getServletContext is used in some 
places - this method has been added in servlet 3.0 which is since a long time a 
prerequisite for Sling.
However, Sling's junit scriptable is not implementing these methods. (It also 
does not use request/response wrapper but implements those interfaces by hand, 
which is causing for trouble)

> AbstractMethodError with Sling Engine 2.12.0
> 
>
> Key: SLING-11597
> URL: https://issues.apache.org/jira/browse/SLING-11597
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JUnit Scriptable Tests Provider 1.0.12
>Reporter: Carsten Ziegeler
>Priority: Blocker
> Fix For: JUnit Scriptable Tests Provider 1.0.14
>
>
> 26.09.2022 08:14:55.762 *ERROR* [qtp736626945-45] 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught 
> Throwable
> java.lang.AbstractMethodError: Receiver class 
> org.apache.sling.junit.scriptable.HttpRequest does not define or inherit an 
> implementation of the resolved method 'abstract javax.servlet.ServletContext 
> getServletContext()' of interface javax.servlet.ServletRequest.
> at 
> javax.servlet.ServletRequestWrapper.getServletContext(ServletRequestWrapper.java:370)
>  [org.apache.felix.http.servlet-api:1.1.4]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (SLING-11597) AbstractMethodError with Sling Engine 2.12.0

2022-09-26 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-11597:
-
Fix Version/s: JUnit Scriptable Tests Provider 1.0.14
   (was: JUnit Scriptable Tests Provider 1.0.12)

> AbstractMethodError with Sling Engine 2.12.0
> 
>
> Key: SLING-11597
> URL: https://issues.apache.org/jira/browse/SLING-11597
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JUnit Scriptable Tests Provider 1.0.12
>Reporter: Carsten Ziegeler
>Priority: Blocker
> Fix For: JUnit Scriptable Tests Provider 1.0.14
>
>
> 26.09.2022 08:14:55.762 *ERROR* [qtp736626945-45] 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught 
> Throwable
> java.lang.AbstractMethodError: Receiver class 
> org.apache.sling.junit.scriptable.HttpRequest does not define or inherit an 
> implementation of the resolved method 'abstract javax.servlet.ServletContext 
> getServletContext()' of interface javax.servlet.ServletRequest.
> at 
> javax.servlet.ServletRequestWrapper.getServletContext(ServletRequestWrapper.java:370)
>  [org.apache.felix.http.servlet-api:1.1.4]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (SLING-11597) AbstractMethodError with Sling Engine 2.12.0

2022-09-26 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-11597:
-
Affects Version/s: JUnit Scriptable Tests Provider 1.0.12

> AbstractMethodError with Sling Engine 2.12.0
> 
>
> Key: SLING-11597
> URL: https://issues.apache.org/jira/browse/SLING-11597
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JUnit Scriptable Tests Provider 1.0.12
>Reporter: Carsten Ziegeler
>Priority: Blocker
> Fix For: JUnit Scriptable Tests Provider 1.0.12
>
>
> 26.09.2022 08:14:55.762 *ERROR* [qtp736626945-45] 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught 
> Throwable
> java.lang.AbstractMethodError: Receiver class 
> org.apache.sling.junit.scriptable.HttpRequest does not define or inherit an 
> implementation of the resolved method 'abstract javax.servlet.ServletContext 
> getServletContext()' of interface javax.servlet.ServletRequest.
> at 
> javax.servlet.ServletRequestWrapper.getServletContext(ServletRequestWrapper.java:370)
>  [org.apache.felix.http.servlet-api:1.1.4]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (SLING-11597) AbstractMethodError with Sling Engine 2.12.0

2022-09-26 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-11597:
-
Fix Version/s: JUnit Scriptable Tests Provider 1.0.12

> AbstractMethodError with Sling Engine 2.12.0
> 
>
> Key: SLING-11597
> URL: https://issues.apache.org/jira/browse/SLING-11597
> Project: Sling
>  Issue Type: Bug
>Reporter: Carsten Ziegeler
>Priority: Blocker
> Fix For: JUnit Scriptable Tests Provider 1.0.12
>
>
> 26.09.2022 08:14:55.762 *ERROR* [qtp736626945-45] 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught 
> Throwable
> java.lang.AbstractMethodError: Receiver class 
> org.apache.sling.junit.scriptable.HttpRequest does not define or inherit an 
> implementation of the resolved method 'abstract javax.servlet.ServletContext 
> getServletContext()' of interface javax.servlet.ServletRequest.
> at 
> javax.servlet.ServletRequestWrapper.getServletContext(ServletRequestWrapper.java:370)
>  [org.apache.felix.http.servlet-api:1.1.4]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (SLING-11597) AbstractMethodError with Sling Engine 2.12.0

2022-09-26 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-11597:


 Summary: AbstractMethodError with Sling Engine 2.12.0
 Key: SLING-11597
 URL: https://issues.apache.org/jira/browse/SLING-11597
 Project: Sling
  Issue Type: Bug
Reporter: Carsten Ziegeler


26.09.2022 08:14:55.762 *ERROR* [qtp736626945-45] 
org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught 
Throwable
java.lang.AbstractMethodError: Receiver class 
org.apache.sling.junit.scriptable.HttpRequest does not define or inherit an 
implementation of the resolved method 'abstract javax.servlet.ServletContext 
getServletContext()' of interface javax.servlet.ServletRequest.
at 
javax.servlet.ServletRequestWrapper.getServletContext(ServletRequestWrapper.java:370)
 [org.apache.felix.http.servlet-api:1.1.4]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)