Re: [VOTE] Release Apache Sling Webconsole Securityprovider 1.2.8
+1 Regards, Sagar > On 07-Dec-2022, at 3:40 AM, Karl Pauls wrote: > > +1 > > regards, > > Karl > > On Tue, Dec 6, 2022 at 5:32 PM Daniel Klco wrote: > >> +1 >> >> On Tue, Dec 6, 2022 at 11:23 AM Carsten Ziegeler >> wrote: >> >>> +1 >>> >>> Carsten >>> >>> Am 06.12.2022 um 15:15 schrieb Carsten Ziegeler: Hi, We solved 1 issue in this release https://issues.apache.org/jira/browse/SLING-11620 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2704 You can use this UNIX script to download the release and verify the signatures: >>> >> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2704 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten >>> >>> -- >>> Carsten Ziegeler >>> Adobe >>> cziege...@apache.org >>> >> > > > -- > Karl Pauls > karlpa...@gmail.com
[GitHub] [sling-org-apache-sling-dynamic-include] anban02 commented on pull request #26: SLING-10110: added a functionality for resolving Star-Wildcards in ig…
anban02 commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1340516907 > @anban02 So if I understand this correctly, you want to extend SDI to ignore url parameters not only by exact match (what is already supported today), but you want to add support for globbed URL parameters (for example "utm*"). > > If you internally translate such a glob already to a regex, why not support directly regexes? Yes. that is correct. In the use case i have at my company there are some of these globbed parameters for tracking, as tracking-parameters can be anything they want and just prefix with a certain kind of String like for example "tra-*". How would one go about directly supporting regex here? Can you give me an example for that one as i don't seem to understand what exactly that implies in this scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] royteeuwen commented on pull request #22: SLING-11706: Add basename provider to allow global basename setting i…
royteeuwen commented on PR #22: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/22#issuecomment-1340475131 @enapps-enorman nothing holding you back to do it that way, thats the reason of the provider interface. If you make a RequestAttributeBasenameProvider implementation and then set that attribute in the PostConstruct of the Page object then you have exactly what you want? I’m trying to keep it generic here so that anyway with their own wild idea can get it to work for their situation ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] enapps-enorman commented on pull request #22: SLING-11706: Add basename provider to allow global basename setting i…
enapps-enorman commented on PR #22:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/22#issuecomment-1340162867
Could this be solved with something like a looking for a well known request
attribute name that specifies the default basename to use? Then you could use
something like a servlet filter to set that request attribute for the pages
where you can't or don't want to change the HTL files?
I'm thinking something that a request attribute may be more flexible than a
component interface. For example, I would like to declare the default basename
in the PostContruct init method of my page model so I don't have to keep
repeating the basename on every i18n expression.
I've been using a technique (see example below) to shorten the repetitive
basename on every string by declaring the basename as a variable at the top of
the page and using that variable everywhere, but if I could declare the
basename once in the page model's PostConstruct init method as a request
attribute (or some other declarative way), it would simplify the HTL code as I
could exclude the repetitive basename clauses everywhere.
For example, currently I have to do something like this:
`
${"key1" @ i18n, basename=rb}
${"key2" @ i18n, basename=rb}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [VOTE] Release Apache Sling Webconsole Securityprovider 1.2.8
+1 regards, Karl On Tue, Dec 6, 2022 at 5:32 PM Daniel Klco wrote: > +1 > > On Tue, Dec 6, 2022 at 11:23 AM Carsten Ziegeler > wrote: > > > +1 > > > > Carsten > > > > Am 06.12.2022 um 15:15 schrieb Carsten Ziegeler: > > > Hi, > > > > > > We solved 1 issue in this release > > > https://issues.apache.org/jira/browse/SLING-11620 > > > > > > > > > Staging repository: > > > https://repository.apache.org/content/repositories/orgapachesling-2704 > > > > > > You can use this UNIX script to download the release and verify the > > > signatures: > > > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > Usage: > > > sh check_staged_release.sh 2704 /tmp/sling-staging > > > > > > Please vote to approve this release: > > > > > >[ ] +1 Approve the release > > >[ ] 0 Don't care > > >[ ] -1 Don't release, because ... > > > > > > This majority vote is open for at least 72 hours. > > > > > > Regards > > > Carsten > > > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Feature Launcher 1.2.2 and Feature Extensions Apiregions 1.6.4
+1 David On Tue, 6 Dec 2022 at 16:37, Carsten Ziegeler wrote: > +1 > > Carsten > > Am 06.12.2022 um 06:33 schrieb Carsten Ziegeler: > > Hi, > > > > we solved 11 issues for the launcher > > https://issues.apache.org/jira/projects/SLING/versions/12351353 > > > > and 2 issues for the apiregions extension > > https://issues.apache.org/jira/projects/SLING/versions/12352068 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2703 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2703 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org >
Re: [VOTE] Release Apache Sling Feature Launcher 1.2.2 and Feature Extensions Apiregions 1.6.4
+1 Carsten Am 06.12.2022 um 06:33 schrieb Carsten Ziegeler: Hi, we solved 11 issues for the launcher https://issues.apache.org/jira/projects/SLING/versions/12351353 and 2 issues for the apiregions extension https://issues.apache.org/jira/projects/SLING/versions/12352068 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2703 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2703 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Webconsole Securityprovider 1.2.8
+1 On Tue, Dec 6, 2022 at 11:23 AM Carsten Ziegeler wrote: > +1 > > Carsten > > Am 06.12.2022 um 15:15 schrieb Carsten Ziegeler: > > Hi, > > > > We solved 1 issue in this release > > https://issues.apache.org/jira/browse/SLING-11620 > > > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2704 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2704 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org >
Re: [VOTE] Release Apache Sling Feature Launcher 1.2.2 and Feature Extensions Apiregions 1.6.4
+1 On Tue, Dec 6, 2022 at 3:25 AM Robert Munteanu wrote: > On Tue, 2022-12-06 at 06:33 +0100, Carsten Ziegeler wrote: > > Please vote to approve this release: > > +1 > Robert >
Re: [VOTE] Release Apache Sling Webconsole Securityprovider 1.2.8
+1 Carsten Am 06.12.2022 um 15:15 schrieb Carsten Ziegeler: Hi, We solved 1 issue in this release https://issues.apache.org/jira/browse/SLING-11620 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2704 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2704 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Webconsole Securityprovider 1.2.8
On Tue, 2022-12-06 at 15:15 +0100, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
Re: [VOTE] Release Apache Sling Webconsole Securityprovider 1.2.8
[x] +1 Approve the release kind regards angela From: Carsten Ziegeler Sent: Tuesday, December 6, 2022 15:15 To: dev@sling.apache.org Subject: [VOTE] Release Apache Sling Webconsole Securityprovider 1.2.8 Hi, We solved 1 issue in this release https://issues.apache.org/jira/browse/SLING-11620 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2704 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2704 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[VOTE] Release Apache Sling Webconsole Securityprovider 1.2.8
Hi, We solved 1 issue in this release https://issues.apache.org/jira/browse/SLING-11620 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2704 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2704 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Resolved] (SLING-11620) Synchronization issue in Webconsole Security Provider
[
https://issues.apache.org/jira/browse/SLING-11620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-11620.
--
Resolution: Fixed
> Synchronization issue in Webconsole Security Provider
> -
>
> Key: SLING-11620
> URL: https://issues.apache.org/jira/browse/SLING-11620
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Web Console Security Provider 1.2.6
>Reporter: Sagar Miglani
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Web Console Security Provider 1.2.8
>
> Attachments: BlockedThreads.png, SLING-11620_fix.patch,
> WebconsoleServiceListeners.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> WebconsoleSecurityProvider's
> [ServiceListeners|https://github.com/apache/sling-org-apache-sling-extensions-webconsolesecurityprovider/blob/master/src/main/java/org/apache/sling/extensions/webconsolesecurityprovider/internal/ServicesListener.java]
> class has three fields of Listener (an inner class of {{ServiceListeners}}
> implementing {{{}ServiceListener{}}}) {{{}repositoryListener{}}},
> {{{}authSupportListener{}}}, {{{}authListener{}}}.
> Each of listener uses synchronized methods and on any {{ServiceChanged}}
> event it may call {{notifyChange}} method of {{ServiceListeners}} outer class
> which is also a synchronized method and in this method we are again calling
> all of the listener fields' {{getService}} sychronized methods
> If two service events for these listeneres fields occur simulatenously a
> deadlock situation may arise.
> eg:
> Thread1:
> - repositoryListener -> serviceChanged
> - synchronized retainSerivce - (self lock acquired)
> - synchronized notifyChange - (outer class' lock acquired)
> Thread2:
> - authSupportListener -> serviceChanged
> - synchronized retainService - (self lock aquired)
> - synchronized notifyChange - (wait for thread 1 to release outer class'
> lock)
> Thread1:
> - synchronized (authSupportListener) getService - (wait for thread 2 to
> release the lock)
> Tried to replicate the scenario [^WebconsoleServiceListeners.patch]. The test
> in this patch file fails due to timeout.
> On taking thread snapshot you may see the thread blocked and waiting for each
> other. [^BlockedThreads.png]
> Shouldn't these all listener fields and outer class be using the shared lock
> instead of sychronized methods?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-11620) Synchronization issue in Webconsole Security Provider
[
https://issues.apache.org/jira/browse/SLING-11620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-11620:
Assignee: Carsten Ziegeler
> Synchronization issue in Webconsole Security Provider
> -
>
> Key: SLING-11620
> URL: https://issues.apache.org/jira/browse/SLING-11620
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Web Console Security Provider 1.2.6
>Reporter: Sagar Miglani
>Assignee: Carsten Ziegeler
>Priority: Major
> Attachments: BlockedThreads.png, SLING-11620_fix.patch,
> WebconsoleServiceListeners.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> WebconsoleSecurityProvider's
> [ServiceListeners|https://github.com/apache/sling-org-apache-sling-extensions-webconsolesecurityprovider/blob/master/src/main/java/org/apache/sling/extensions/webconsolesecurityprovider/internal/ServicesListener.java]
> class has three fields of Listener (an inner class of {{ServiceListeners}}
> implementing {{{}ServiceListener{}}}) {{{}repositoryListener{}}},
> {{{}authSupportListener{}}}, {{{}authListener{}}}.
> Each of listener uses synchronized methods and on any {{ServiceChanged}}
> event it may call {{notifyChange}} method of {{ServiceListeners}} outer class
> which is also a synchronized method and in this method we are again calling
> all of the listener fields' {{getService}} sychronized methods
> If two service events for these listeneres fields occur simulatenously a
> deadlock situation may arise.
> eg:
> Thread1:
> - repositoryListener -> serviceChanged
> - synchronized retainSerivce - (self lock acquired)
> - synchronized notifyChange - (outer class' lock acquired)
> Thread2:
> - authSupportListener -> serviceChanged
> - synchronized retainService - (self lock aquired)
> - synchronized notifyChange - (wait for thread 1 to release outer class'
> lock)
> Thread1:
> - synchronized (authSupportListener) getService - (wait for thread 2 to
> release the lock)
> Tried to replicate the scenario [^WebconsoleServiceListeners.patch]. The test
> in this patch file fails due to timeout.
> On taking thread snapshot you may see the thread blocked and waiting for each
> other. [^BlockedThreads.png]
> Shouldn't these all listener fields and outer class be using the shared lock
> instead of sychronized methods?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11620) Synchronization issue in Webconsole Security Provider
[
https://issues.apache.org/jira/browse/SLING-11620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-11620:
-
Fix Version/s: Web Console Security Provider 1.2.8
> Synchronization issue in Webconsole Security Provider
> -
>
> Key: SLING-11620
> URL: https://issues.apache.org/jira/browse/SLING-11620
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Web Console Security Provider 1.2.6
>Reporter: Sagar Miglani
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Web Console Security Provider 1.2.8
>
> Attachments: BlockedThreads.png, SLING-11620_fix.patch,
> WebconsoleServiceListeners.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> WebconsoleSecurityProvider's
> [ServiceListeners|https://github.com/apache/sling-org-apache-sling-extensions-webconsolesecurityprovider/blob/master/src/main/java/org/apache/sling/extensions/webconsolesecurityprovider/internal/ServicesListener.java]
> class has three fields of Listener (an inner class of {{ServiceListeners}}
> implementing {{{}ServiceListener{}}}) {{{}repositoryListener{}}},
> {{{}authSupportListener{}}}, {{{}authListener{}}}.
> Each of listener uses synchronized methods and on any {{ServiceChanged}}
> event it may call {{notifyChange}} method of {{ServiceListeners}} outer class
> which is also a synchronized method and in this method we are again calling
> all of the listener fields' {{getService}} sychronized methods
> If two service events for these listeneres fields occur simulatenously a
> deadlock situation may arise.
> eg:
> Thread1:
> - repositoryListener -> serviceChanged
> - synchronized retainSerivce - (self lock acquired)
> - synchronized notifyChange - (outer class' lock acquired)
> Thread2:
> - authSupportListener -> serviceChanged
> - synchronized retainService - (self lock aquired)
> - synchronized notifyChange - (wait for thread 1 to release outer class'
> lock)
> Thread1:
> - synchronized (authSupportListener) getService - (wait for thread 2 to
> release the lock)
> Tried to replicate the scenario [^WebconsoleServiceListeners.patch]. The test
> in this patch file fails due to timeout.
> On taking thread snapshot you may see the thread blocked and waiting for each
> other. [^BlockedThreads.png]
> Shouldn't these all listener fields and outer class be using the shared lock
> instead of sychronized methods?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-11722) The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API
[
https://issues.apache.org/jira/browse/SLING-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu reassigned SLING-11722:
Assignee: Radu Cotescu
> The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher
> API
>
>
> Key: SLING-11722
> URL: https://issues.apache.org/jira/browse/SLING-11722
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Engine 2.13.2
>
>
> The {{include}} method [0] has the following important sentence in its
> documentation:
> {quote}
> The ServletResponse object has its path elements and parameters remain
> unchanged from the caller's. The included servlet cannot change the response
> status code or set headers; any attempt to make a change is ignored.
> {quote}
> However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
> [0] -
> https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11620) Synchronization issue in Webconsole Security Provider
[
https://issues.apache.org/jira/browse/SLING-11620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643885#comment-17643885
]
Henry Kuijpers commented on SLING-11620:
[~sagarmiglani][~cziegeler] can this new version of Web Console Security
Provider be released, asap? Given the deadlock situation, it is very important
to do this very soon -- We have already had downtime due to this issue (in our
case AEM didn't start up and just hung).
> Synchronization issue in Webconsole Security Provider
> -
>
> Key: SLING-11620
> URL: https://issues.apache.org/jira/browse/SLING-11620
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Web Console Security Provider 1.2.6
>Reporter: Sagar Miglani
>Priority: Major
> Attachments: BlockedThreads.png, SLING-11620_fix.patch,
> WebconsoleServiceListeners.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> WebconsoleSecurityProvider's
> [ServiceListeners|https://github.com/apache/sling-org-apache-sling-extensions-webconsolesecurityprovider/blob/master/src/main/java/org/apache/sling/extensions/webconsolesecurityprovider/internal/ServicesListener.java]
> class has three fields of Listener (an inner class of {{ServiceListeners}}
> implementing {{{}ServiceListener{}}}) {{{}repositoryListener{}}},
> {{{}authSupportListener{}}}, {{{}authListener{}}}.
> Each of listener uses synchronized methods and on any {{ServiceChanged}}
> event it may call {{notifyChange}} method of {{ServiceListeners}} outer class
> which is also a synchronized method and in this method we are again calling
> all of the listener fields' {{getService}} sychronized methods
> If two service events for these listeneres fields occur simulatenously a
> deadlock situation may arise.
> eg:
> Thread1:
> - repositoryListener -> serviceChanged
> - synchronized retainSerivce - (self lock acquired)
> - synchronized notifyChange - (outer class' lock acquired)
> Thread2:
> - authSupportListener -> serviceChanged
> - synchronized retainService - (self lock aquired)
> - synchronized notifyChange - (wait for thread 1 to release outer class'
> lock)
> Thread1:
> - synchronized (authSupportListener) getService - (wait for thread 2 to
> release the lock)
> Tried to replicate the scenario [^WebconsoleServiceListeners.patch]. The test
> in this patch file fails due to timeout.
> On taking thread snapshot you may see the thread blocked and waiting for each
> other. [^BlockedThreads.png]
> Shouldn't these all listener fields and outer class be using the shared lock
> instead of sychronized methods?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-11720) Apache Sling web site update request
[ https://issues.apache.org/jira/browse/SLING-11720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-11720: --- Assignee: Konrad Windszus > Apache Sling web site update request > > > Key: SLING-11720 > URL: https://issues.apache.org/jira/browse/SLING-11720 > Project: Sling > Issue Type: Improvement >Reporter: Yuri Simione >Assignee: Konrad Windszus >Priority: Major > > I wrote two article on Apache Sling on Adobe Experience League Blog site. I > suggest to add these to the Apache Sling, in this section: > [https://sling.apache.org/links.html#articles] > > * [Is Adobe AEM a valid Content Services Platform? [Part one] by Yuri > Simione|[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-one-by-yuri/ba-p/559647] > []|http://example.com]/] > * [Is Adobe AEM a valid Content Services Platform? [Part one] by Yuri > Simione|[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-two-by-yuri/ba-p/559648] > > []|https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-one-by-yuri/ba-p/559647] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-dynamic-include] joerghoh commented on pull request #26: SLING-10110: added a functionality for resolving Star-Wildcards in ig…
joerghoh commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1339283782 @anban02 So if I understand this correctly, you want to extend SDI to ignore url parameters not only by exact match (what is already supported today), but you want to add support for globbed URL parameters (for example "utm*"). If you internally translate such a glob already to a regex, why not support directly regexes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert commented on a diff in pull request #80: Multi-arch support for Docker images
rombert commented on code in PR #80: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/80#discussion_r1040929613 ## RELEASING.md: ## @@ -0,0 +1,12 @@ +# Releasing Review Comment: @tomaszmichalak - the main issue here is that we don't have access to the docker repository credentials, so the `docker login`/`docker push` workflow does not work for us. We set up automated builds on Docker Hub because that's what works for us with a relatively small effort. If we want to switch to GitHub actions, we need to figure out how that would work, and if ASF infra will provide the necessary secrets for us. I've started a conversation on the ASF builds mailing to see how we can best approach this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11720) Apache Sling web site update request
[ https://issues.apache.org/jira/browse/SLING-11720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11720. - Resolution: Fixed Fixed in https://github.com/apache/sling-site/commit/4e71572549c34621daa48eff4250b0c72eb4e889. Should appear in the next few minutes on the website. > Apache Sling web site update request > > > Key: SLING-11720 > URL: https://issues.apache.org/jira/browse/SLING-11720 > Project: Sling > Issue Type: Improvement >Reporter: Yuri Simione >Priority: Major > > I wrote two article on Apache Sling on Adobe Experience League Blog site. I > suggest to add these to the Apache Sling, in this section: > [https://sling.apache.org/links.html#articles] > > * [Is Adobe AEM a valid Content Services Platform? [Part one] by Yuri > Simione|[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-one-by-yuri/ba-p/559647] > []|http://example.com]/] > * [Is Adobe AEM a valid Content Services Platform? [Part one] by Yuri > Simione|[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-two-by-yuri/ba-p/559648] > > []|https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-one-by-yuri/ba-p/559647] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-site] kwin merged pull request #104: Update links.md
kwin merged PR #104: URL: https://github.com/apache/sling-site/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on pull request #26: SLING-10110: added a functionality for resolving Star-Wildcards in ig…
rombert commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1339258433 @anban02 - I am unfortunately quite lost - SDI and the Dispatcher are not at all known to me. @joerghoh - what are your thoughts on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11714) Multi-arch support for Docker images
[ https://issues.apache.org/jira/browse/SLING-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11714: Fix Version/s: Starter 13 > Multi-arch support for Docker images > > > Key: SLING-11714 > URL: https://issues.apache.org/jira/browse/SLING-11714 > Project: Sling > Issue Type: Improvement > Components: Starter >Affects Versions: Starter 12 > Environment: Docker >Reporter: Tomasz Michalak >Priority: Major > Fix For: Starter 13 > > > In the current version (12), docker images are only built for the `amd64` > platform. I am unable to run Sling Starter on e.g. macs with M1. > I have prepared a patch with my proposal: > [https://github.com/apache/sling-org-apache-sling-starter/pull/80.] > Unfortunately, DockerHub Automated Builds still doesn't support it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11720) Apache Sling web site update request
[ https://issues.apache.org/jira/browse/SLING-11720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643741#comment-17643741 ] Yuri Simione commented on SLING-11720: -- Just updated the page with a pending pull request. Thanks [~kwin] ! > Apache Sling web site update request > > > Key: SLING-11720 > URL: https://issues.apache.org/jira/browse/SLING-11720 > Project: Sling > Issue Type: Improvement >Reporter: Yuri Simione >Priority: Major > > I wrote two article on Apache Sling on Adobe Experience League Blog site. I > suggest to add these to the Apache Sling, in this section: > [https://sling.apache.org/links.html#articles] > > * [Is Adobe AEM a valid Content Services Platform? [Part one] by Yuri > Simione|[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-one-by-yuri/ba-p/559647] > []|http://example.com]/] > * [Is Adobe AEM a valid Content Services Platform? [Part one] by Yuri > Simione|[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-two-by-yuri/ba-p/559648] > > []|https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-one-by-yuri/ba-p/559647] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-site] artika4biz opened a new pull request, #104: Update links.md
artika4biz opened a new pull request, #104: URL: https://github.com/apache/sling-site/pull/104 As per https://issues.apache.org/jira/browse/SLING-11720?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11722) The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API
Radu Cotescu created SLING-11722:
Summary: The SlingRequestDispatcher doesn't correctly implement
the RequestDispatcher API
Key: SLING-11722
URL: https://issues.apache.org/jira/browse/SLING-11722
Project: Sling
Issue Type: Bug
Components: Engine
Reporter: Radu Cotescu
Fix For: Engine 2.13.2
The {{include}} method [0] has the following important sentence in its
documentation:
{quote}
The ServletResponse object has its path elements and parameters remain
unchanged from the caller's. The included servlet cannot change the response
status code or set headers; any attempt to make a change is ignored.
{quote}
However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
[0] -
https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [VOTE] Release Apache Sling Feature Launcher 1.2.2 and Feature Extensions Apiregions 1.6.4
On Tue, 2022-12-06 at 06:33 +0100, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Commented] (SLING-11720) Apache Sling web site update request
[ https://issues.apache.org/jira/browse/SLING-11720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643715#comment-17643715 ] Konrad Windszus commented on SLING-11720: - [~artika4biz]Can you come up with a PR? There is even a handy GitHub link at the bottom of the page: https://github.com/apache/sling-site/edit/master/src/main/jbake/content/links.md > Apache Sling web site update request > > > Key: SLING-11720 > URL: https://issues.apache.org/jira/browse/SLING-11720 > Project: Sling > Issue Type: Improvement >Reporter: Yuri Simione >Priority: Major > > I wrote two article on Apache Sling on Adobe Experience League Blog site. I > suggest to add these to the Apache Sling, in this section: > [https://sling.apache.org/links.html#articles] > > * [Is Adobe AEM a valid Content Services Platform? [Part one] by Yuri > Simione|[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-one-by-yuri/ba-p/559647] > []|http://example.com]/] > * [Is Adobe AEM a valid Content Services Platform? [Part one] by Yuri > Simione|[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-two-by-yuri/ba-p/559648] > > []|https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-one-by-yuri/ba-p/559647] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11721) Apache Jackrabbit web site update request
[ https://issues.apache.org/jira/browse/SLING-11721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11721. - Resolution: Duplicate > Apache Jackrabbit web site update request > - > > Key: SLING-11721 > URL: https://issues.apache.org/jira/browse/SLING-11721 > Project: Sling > Issue Type: Improvement >Reporter: Yuri Simione >Priority: Major > > # I wrote two article on Apache Sling on Adobe Experience League Blog site. I > suggest to add these to the Apache Sling, in these sections: > [https://sling.apache.org/links.html#articles|https://jackrabbit.apache.org/oak/docs/articles.html] > # [https://jackrabbit.apache.org/oak/docs/articles.html] > Links to the article can be found here: > * [Is Adobe AEM a valid Content Services Platform? [Part one] by Yuri > Simione|[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-one-by-yuri/ba-p/559647] > []|http://example.com]/] > * [Is Adobe AEM a valid Content Services Platform? [Part one] by Yuri > Simione|[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-two-by-yuri/ba-p/559648] > > []|https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-one-by-yuri/ba-p/559647] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11718) Migrate to Jakarta JSON API
[ https://issues.apache.org/jira/browse/SLING-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643713#comment-17643713 ] Carsten Ziegeler commented on SLING-11718: -- Migrated slingfeature maven plugin in https://github.com/apache/sling-slingfeature-maven-plugin/commit/ef7b719c5df4b06c9d53dcdafdc11442da747f4c > Migrate to Jakarta JSON API > --- > > Key: SLING-11718 > URL: https://issues.apache.org/jira/browse/SLING-11718 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Feature Model Analyser, Maven Plugins and > Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.0, Feature Diff 0.1.0, > Feature Model 2.0.0, Feature Model API Regions Extension 2.0.0, Feature Model > Launcher 1.2.4 > > > Starting with JEE 9 the package names for the enterprise APIs changed from > javax.* to jakarta.* which means that we will benefit from updates to those > APIs only if we make the move. > For the feature model and the related tooling, it should be fairly easy to do > this move as this code is usually only used at tool time but not at > application runtime. > We can simply replace javax.json with jakarta.json and do new releases of > everything involved with a new major version. As we are currently using > javax.json in parts of the API, this will be a breaking change, therefore the > major version update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11718) Migrate to Jakarta JSON API
[ https://issues.apache.org/jira/browse/SLING-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-11718: - Fix Version/s: slingfeature-maven-plugin 1.6.10 > Migrate to Jakarta JSON API > --- > > Key: SLING-11718 > URL: https://issues.apache.org/jira/browse/SLING-11718 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Feature Model Analyser, Maven Plugins and > Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.0, slingfeature-maven-plugin > 1.6.10, Feature Diff 0.1.0, Feature Model 2.0.0, Feature Model API Regions > Extension 2.0.0, Feature Model Launcher 1.2.4 > > > Starting with JEE 9 the package names for the enterprise APIs changed from > javax.* to jakarta.* which means that we will benefit from updates to those > APIs only if we make the move. > For the feature model and the related tooling, it should be fairly easy to do > this move as this code is usually only used at tool time but not at > application runtime. > We can simply replace javax.json with jakarta.json and do new releases of > everything involved with a new major version. As we are currently using > javax.json in parts of the API, this will be a breaking change, therefore the > major version update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11718) Migrate to Jakarta JSON API
[ https://issues.apache.org/jira/browse/SLING-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643712#comment-17643712 ] Carsten Ziegeler commented on SLING-11718: -- Migrated feature diff in https://github.com/apache/sling-org-apache-sling-feature-diff/commit/6854224113ab2930e3a97e0f6b6a480adbf8317a > Migrate to Jakarta JSON API > --- > > Key: SLING-11718 > URL: https://issues.apache.org/jira/browse/SLING-11718 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Feature Model Analyser, Maven Plugins and > Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.0, Feature Diff 0.1.0, > Feature Model 2.0.0, Feature Model API Regions Extension 2.0.0, Feature Model > Launcher 1.2.4 > > > Starting with JEE 9 the package names for the enterprise APIs changed from > javax.* to jakarta.* which means that we will benefit from updates to those > APIs only if we make the move. > For the feature model and the related tooling, it should be fairly easy to do > this move as this code is usually only used at tool time but not at > application runtime. > We can simply replace javax.json with jakarta.json and do new releases of > everything involved with a new major version. As we are currently using > javax.json in parts of the API, this will be a breaking change, therefore the > major version update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11718) Migrate to Jakarta JSON API
[ https://issues.apache.org/jira/browse/SLING-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-11718: - Fix Version/s: Feature Diff 0.0.8 > Migrate to Jakarta JSON API > --- > > Key: SLING-11718 > URL: https://issues.apache.org/jira/browse/SLING-11718 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Feature Model Analyser, Maven Plugins and > Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.0, Feature Diff 0.0.8, > Feature Model 2.0.0, Feature Model API Regions Extension 2.0.0, Feature Model > Launcher 1.2.4 > > > Starting with JEE 9 the package names for the enterprise APIs changed from > javax.* to jakarta.* which means that we will benefit from updates to those > APIs only if we make the move. > For the feature model and the related tooling, it should be fairly easy to do > this move as this code is usually only used at tool time but not at > application runtime. > We can simply replace javax.json with jakarta.json and do new releases of > everything involved with a new major version. As we are currently using > javax.json in parts of the API, this will be a breaking change, therefore the > major version update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Moved] (SLING-11721) Apache Jackrabbit web site update request
[ https://issues.apache.org/jira/browse/SLING-11721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke moved JCR-4876 to SLING-11721: - Key: SLING-11721 (was: JCR-4876) Workflow: no-reopen-closed,doc-test-required (was: no-reopen-closed, patch-avail) Project: Sling (was: Jackrabbit Content Repository) > Apache Jackrabbit web site update request > - > > Key: SLING-11721 > URL: https://issues.apache.org/jira/browse/SLING-11721 > Project: Sling > Issue Type: Improvement >Reporter: Yuri Simione >Priority: Major > > # I wrote two article on Apache Sling on Adobe Experience League Blog site. I > suggest to add these to the Apache Sling, in these sections: > [https://sling.apache.org/links.html#articles|https://jackrabbit.apache.org/oak/docs/articles.html] > # [https://jackrabbit.apache.org/oak/docs/articles.html] > Links to the article can be found here: > * [Is Adobe AEM a valid Content Services Platform? [Part one] by Yuri > Simione|[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-one-by-yuri/ba-p/559647] > []|http://example.com]/] > * [Is Adobe AEM a valid Content Services Platform? [Part one] by Yuri > Simione|[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-two-by-yuri/ba-p/559648] > > []|https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-blogs/is-adobe-aem-a-valid-content-services-platform-part-one-by-yuri/ba-p/559647] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
