[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #152: SLING-11739 Index definition extraction from content packages is miss…
sonarcloud[bot] commented on PR #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#issuecomment-1364448140 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=152) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1364422648 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #152: SLING-11739 Index definition extraction from content packages is miss…
sonarcloud[bot] commented on PR #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#issuecomment-1364165320 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=152) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SLING-11700) Update ASF Parent to v29
[ https://issues.apache.org/jira/browse/SLING-11700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637692#comment-17637692 ] Konrad Windszus edited comment on SLING-11700 at 12/23/22 3:09 PM: --- Updated to 28 in https://github.com/apache/sling-parent/commit/05c99677614633f688fda2a0bd71f05c5331ae14. Updated to 29 in https://github.com/apache/sling-parent/commit/5eb021b8e0c6c46c54c961be029eaf757ceafff1 was (Author: kwin): Fixed in https://github.com/apache/sling-parent/commit/05c99677614633f688fda2a0bd71f05c5331ae14. > Update ASF Parent to v29 > > > Key: SLING-11700 > URL: https://issues.apache.org/jira/browse/SLING-11700 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 50 > > > https://github.com/apache/maven-apache-parent/releases/tag/apache-28 > https://github.com/apache/maven-apache-parent/releases/tag/apache-29 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11700) Update ASF Parent to v29
[ https://issues.apache.org/jira/browse/SLING-11700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11700: Summary: Update ASF Parent to v29 (was: Update ASF Parent to v28) > Update ASF Parent to v29 > > > Key: SLING-11700 > URL: https://issues.apache.org/jira/browse/SLING-11700 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 50 > > > https://github.com/apache/maven-apache-parent/releases/tag/apache-28 > https://github.com/apache/maven-apache-parent/releases/tag/apache-29 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11700) Update ASF Parent to v28
[ https://issues.apache.org/jira/browse/SLING-11700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11700: Description: https://github.com/apache/maven-apache-parent/releases/tag/apache-28 https://github.com/apache/maven-apache-parent/releases/tag/apache-29 was:https://github.com/apache/maven-apache-parent/releases/tag/apache-28 > Update ASF Parent to v28 > > > Key: SLING-11700 > URL: https://issues.apache.org/jira/browse/SLING-11700 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 50 > > > https://github.com/apache/maven-apache-parent/releases/tag/apache-28 > https://github.com/apache/maven-apache-parent/releases/tag/apache-29 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11529) Configure JaCoCo to collect coverage with maven-invoker-plugin
[ https://issues.apache.org/jira/browse/SLING-11529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11529. - Resolution: Fixed Fixed in https://github.com/apache/sling-parent/commit/8aa51bcf23f2a32da269ffabf697f4fe92f5320a. > Configure JaCoCo to collect coverage with maven-invoker-plugin > -- > > Key: SLING-11529 > URL: https://issues.apache.org/jira/browse/SLING-11529 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 50 > > Time Spent: 0.5h > Remaining Estimate: 0h > > We have quite some Maven plugins which leverage maven-invoker-plugin for > executing some ITs. The coverage of those ITs should be taken into > consideration and merged with coverage from ITs from maven-failsafe-plugin > and UTs from maven-surefire-plugin. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-parent] kwin merged pull request #32: SLING-11529 collect coverage for m-invoker-p
kwin merged PR #32: URL: https://github.com/apache/sling-parent/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11729) Add FileVault validator for repoinit files contained in serialized OSGi configs
[ https://issues.apache.org/jira/browse/SLING-11729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651668#comment-17651668 ] Fabrice Bellingard commented on SLING-11729: Done [~kwin]! => https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-repoinit-filevault-validator > Add FileVault validator for repoinit files contained in serialized OSGi > configs > --- > > Key: SLING-11729 > URL: https://issues.apache.org/jira/browse/SLING-11729 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > The SPI from https://jackrabbit.apache.org/filevault/validation.html provides > some means to implement a repoinit validator which can be automatically > executed when building a content package (containing those serialized OSGi > configs). > Internally it should work similar to > https://github.com/apache/sling-whiteboard/blob/master/jbang/RepoinitValidator.java. > All OSGi serialization formats outlined at > https://sling.apache.org/documentation/bundles/configuration-installer-factory.html#configuration-serialization-formats > need to be supported. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11743) Allow serializing of feature model
[ https://issues.apache.org/jira/browse/SLING-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651628#comment-17651628 ] Robert Munteanu commented on SLING-11743: - Interesting, thanks for sharing. > Allow serializing of feature model > -- > > Key: SLING-11743 > URL: https://issues.apache.org/jira/browse/SLING-11743 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 2.0.0 > > > Parts of the feature model already implement Serializable. We should make all > feature model objects serializable to allow serializing/deserializing of a > feature model via object streams -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11743) Allow serializing of feature model
[ https://issues.apache.org/jira/browse/SLING-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651605#comment-17651605 ] Carsten Ziegeler commented on SLING-11743: -- The use case I have is passing objects from a maven lifecycle participant to a maven mojo. Due to different classloaders you can't pass the objects directly and in my cases I don't have a full feature model which I could convert to/from JSON either. Artifacts/Bundles/Configurations were already serializable as these extends ArrayList, but the contained objects were not. This is closing this gap. > Allow serializing of feature model > -- > > Key: SLING-11743 > URL: https://issues.apache.org/jira/browse/SLING-11743 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 2.0.0 > > > Parts of the feature model already implement Serializable. We should make all > feature model objects serializable to allow serializing/deserializing of a > feature model via object streams -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11743) Allow serializing of feature model
[ https://issues.apache.org/jira/browse/SLING-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651601#comment-17651601 ] Robert Munteanu commented on SLING-11743: - Out of curiosity, what are the foreseen use case? > Allow serializing of feature model > -- > > Key: SLING-11743 > URL: https://issues.apache.org/jira/browse/SLING-11743 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 2.0.0 > > > Parts of the feature model already implement Serializable. We should make all > feature model objects serializable to allow serializing/deserializing of a > feature model via object streams -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #152: SLING-11739 Index definition extraction from content packages is miss…
sonarcloud[bot] commented on PR #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#issuecomment-1363800991 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=152) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] abhishekgarg18 commented on a diff in pull request #152: SLING-11739 Index definition extraction from content packages is miss…
abhishekgarg18 commented on code in PR #152:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#discussion_r1056193284
##
src/test/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandlerTest.java:
##
@@ -169,7 +169,64 @@ public void handleIndexDefinitionWithNestedTikaXml()
throws IOException, Convert
assertIsValidXml(tikaConfig);
}
+@Test
+public void handleIndexDefinitionWithStopwordsInAnalyzer() throws
IOException, ConverterException, ParserConfigurationException, SAXException {
+DefaultIndexManager manager = new DefaultIndexManager();
+
+traverseForIndexing(manager, "index_with_stopwards");
+
+IndexDefinitions defs = manager.getIndexes();
+Map> indexes = defs.getIndexes();
+
+assertThat(indexes).as("index definitions")
+.hasSize(1)
+.containsKey("/oak:index");
+
+List rootIndexes = indexes.get("/oak:index");
+assertThat(rootIndexes).as("root indexes")
+.hasSize(1);
+
+assertThat(rootIndexes).as("index definitions")
+.hasSize(1)
+.element(0)
+.has(Conditions.localName("lucene-custom"));
+
+DocViewNode2 luceneCustom = rootIndexes.get(0);
+assertThat(luceneCustom).as("lucene index definition")
+.has(Conditions.childWithLocalName("/oak:index/lucene-custom",
"analyzers", defs));
+
+List luceneCustomChildren =
defs.getChildren("/oak:index/lucene-custom");
+assertThat(luceneCustomChildren).as("lucene index definition children")
+.hasSize(1);
+
+DocViewNode2 analyzersConfigNode = luceneCustomChildren.stream()
+.filter( c -> c.getName().getLocalName().equals("analyzers") )
+.findFirst()
+.get();
+
+assertThat(analyzersConfigNode).as("analyzers config node for stop
words")
+
.has(Conditions.childWithLocalName("/oak:index/lucene-custom/analyzers/default/filters/Stop","stopwords.txt",
defs));
+
+byte[] stopwordsConfig =
defs.getBinary("/oak:index/lucene-custom/analyzers/default/filters/Stop/stopwords.txt").get();
+assertThat(stopwordsConfig).as("stopwordsConfig is ").isNotNull();
+byte[] stopwords_2_Config =
defs.getBinary("/oak:index/lucene-custom/analyzers/default/filters/Stop/stopwords_2.txt").get();
+assertThat(stopwords_2_Config).as("stopwords__2Config is
").isNotNull();
+
+assertThat(analyzersConfigNode).as("analyzers config node for
prowords")
+
.has(Conditions.childWithLocalName("/oak:index/lucene-custom/analyzers/default/filters/KeywordMarker","protwords.txt",
defs));
+
+byte[] keywordMarkerConfig =
defs.getBinary("/oak:index/lucene-custom/analyzers/default/filters/KeywordMarker/protwords.txt").get();
+assertThat(keywordMarkerConfig).as("keywordMarkerConfig is
").isNotNull();
+
+
+assertThat(analyzersConfigNode).as("analyzers config node dor
Synonyms")
+
.has(Conditions.childWithLocalName("/oak:index/lucene-custom/analyzers/default/filters/Synonym","synonyms.txt",
defs));
+
+byte[] synonymConfig =
defs.getBinary("/oak:index/lucene-custom/analyzers/default/filters/Synonym/synonyms.txt").get();
+assertThat(synonymConfig).as("synonymConfig is ").isNotNull();
Review Comment:
added a contains check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] abhishekgarg18 commented on a diff in pull request #152: SLING-11739 Index definition extraction from content packages is miss…
abhishekgarg18 commented on code in PR #152:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#discussion_r1056192807
##
src/test/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandlerTest.java:
##
@@ -169,7 +169,64 @@ public void handleIndexDefinitionWithNestedTikaXml()
throws IOException, Convert
assertIsValidXml(tikaConfig);
}
+@Test
+public void handleIndexDefinitionWithStopwordsInAnalyzer() throws
IOException, ConverterException, ParserConfigurationException, SAXException {
+DefaultIndexManager manager = new DefaultIndexManager();
+
+traverseForIndexing(manager, "index_with_stopwards");
+
+IndexDefinitions defs = manager.getIndexes();
+Map> indexes = defs.getIndexes();
+
+assertThat(indexes).as("index definitions")
+.hasSize(1)
+.containsKey("/oak:index");
+
+List rootIndexes = indexes.get("/oak:index");
+assertThat(rootIndexes).as("root indexes")
+.hasSize(1);
+
+assertThat(rootIndexes).as("index definitions")
+.hasSize(1)
+.element(0)
+.has(Conditions.localName("lucene-custom"));
+
+DocViewNode2 luceneCustom = rootIndexes.get(0);
+assertThat(luceneCustom).as("lucene index definition")
+.has(Conditions.childWithLocalName("/oak:index/lucene-custom",
"analyzers", defs));
+
+List luceneCustomChildren =
defs.getChildren("/oak:index/lucene-custom");
+assertThat(luceneCustomChildren).as("lucene index definition children")
+.hasSize(1);
+
+DocViewNode2 analyzersConfigNode = luceneCustomChildren.stream()
+.filter( c -> c.getName().getLocalName().equals("analyzers") )
+.findFirst()
+.get();
+
+assertThat(analyzersConfigNode).as("analyzers config node for stop
words")
+
.has(Conditions.childWithLocalName("/oak:index/lucene-custom/analyzers/default/filters/Stop","stopwords.txt",
defs));
+
+byte[] stopwordsConfig =
defs.getBinary("/oak:index/lucene-custom/analyzers/default/filters/Stop/stopwords.txt").get();
+assertThat(stopwordsConfig).as("stopwordsConfig is ").isNotNull();
Review Comment:
added a contains check.
##
src/test/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandlerTest.java:
##
@@ -169,7 +169,64 @@ public void handleIndexDefinitionWithNestedTikaXml()
throws IOException, Convert
assertIsValidXml(tikaConfig);
}
+@Test
+public void handleIndexDefinitionWithStopwordsInAnalyzer() throws
IOException, ConverterException, ParserConfigurationException, SAXException {
+DefaultIndexManager manager = new DefaultIndexManager();
+
+traverseForIndexing(manager, "index_with_stopwards");
+
+IndexDefinitions defs = manager.getIndexes();
+Map> indexes = defs.getIndexes();
+
+assertThat(indexes).as("index definitions")
+.hasSize(1)
+.containsKey("/oak:index");
+
+List rootIndexes = indexes.get("/oak:index");
+assertThat(rootIndexes).as("root indexes")
+.hasSize(1);
+
+assertThat(rootIndexes).as("index definitions")
+.hasSize(1)
+.element(0)
+.has(Conditions.localName("lucene-custom"));
+
+DocViewNode2 luceneCustom = rootIndexes.get(0);
+assertThat(luceneCustom).as("lucene index definition")
+.has(Conditions.childWithLocalName("/oak:index/lucene-custom",
"analyzers", defs));
+
+List luceneCustomChildren =
defs.getChildren("/oak:index/lucene-custom");
+assertThat(luceneCustomChildren).as("lucene index definition children")
+.hasSize(1);
+
+DocViewNode2 analyzersConfigNode = luceneCustomChildren.stream()
+.filter( c -> c.getName().getLocalName().equals("analyzers") )
+.findFirst()
+.get();
+
+assertThat(analyzersConfigNode).as("analyzers config node for stop
words")
+
.has(Conditions.childWithLocalName("/oak:index/lucene-custom/analyzers/default/filters/Stop","stopwords.txt",
defs));
+
+byte[] stopwordsConfig =
defs.getBinary("/oak:index/lucene-custom/analyzers/default/filters/Stop/stopwords.txt").get();
+assertThat(stopwordsConfig).as("stopwordsConfig is ").isNotNull();
+byte[] stopwords_2_Config =
defs.getBinary("/oak:index/lucene-custom/analyzers/default/filters/Stop/stopwords_2.txt").get();
+assertThat(stopwords_2_Config).as("stopwords__2Config is
").isNotNull();
+
Review Comment:
added a contains check.
##
src/test/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandlerTest.java:
##
@@ -169,7 +169,64 @@ public void
[GitHub] [sling-org-apache-sling-feature-cpconverter] abhishekgarg18 commented on a diff in pull request #152: SLING-11739 Index definition extraction from content packages is miss…
abhishekgarg18 commented on code in PR #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#discussion_r1056192387 ## src/test/resources/org/apache/sling/feature/cpconverter/handlers/index/index_with_stopwards/jcr_root/_oak_index/lucene-custom/analyzers/default/filters/Stop/stopwords.txt: ## @@ -0,0 +1,353 @@ + +de | from, of Review Comment: left only one word in it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] abhishekgarg18 commented on a diff in pull request #152: SLING-11739 Index definition extraction from content packages is miss…
abhishekgarg18 commented on code in PR #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#discussion_r1056192250 ## src/test/resources/org/apache/sling/feature/cpconverter/handlers/index/index_with_stopwards/jcr_root/_oak_index/lucene-custom/analyzers/default/filters/Stop/stopwords_2.txt: ## @@ -0,0 +1,353 @@ + +de | from, of Review Comment: left only one word in it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #152: SLING-11739 Index definition extraction from content packages is miss…
sonarcloud[bot] commented on PR #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#issuecomment-1363734170 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=152) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11719) Remove deprecated API
[ https://issues.apache.org/jira/browse/SLING-11719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11719. -- Resolution: Fixed > Remove deprecated API > - > > Key: SLING-11719 > URL: https://issues.apache.org/jira/browse/SLING-11719 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Feature Model Analyser, Maven Plugins and > Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.0, Feature Model 2.0.0, > Feature Model API Regions Extension 2.0.0 > > > With the move to the jakarta api (SLING-11718) we will have breaking api > changes, therefore we can at the same time get rid of deprecated api -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11718) Migrate to Jakarta JSON API
[ https://issues.apache.org/jira/browse/SLING-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11718. -- Resolution: Fixed > Migrate to Jakarta JSON API > --- > > Key: SLING-11718 > URL: https://issues.apache.org/jira/browse/SLING-11718 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Feature Model Analyser, Maven Plugins and > Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.0, slingfeature-maven-plugin > 1.6.10, Feature Diff 0.1.0, JCR ContentLoader 2.5.4, Content-Package to > Feature Model Converter 1.1.26, Feature Model 2.0.0, Feature Model API > Regions Extension 2.0.0, Feature Model Launcher 1.2.4 > > > Starting with JEE 9 the package names for the enterprise APIs changed from > javax.* to jakarta.* which means that we will benefit from updates to those > APIs only if we make the move. > For the feature model and the related tooling, it should be fairly easy to do > this move as this code is usually only used at tool time but not at > application runtime. > We can simply replace javax.json with jakarta.json and do new releases of > everything involved with a new major version. As we are currently using > javax.json in parts of the API, this will be a breaking change, therefore the > major version update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11743) Allow serializing of feature model
[ https://issues.apache.org/jira/browse/SLING-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11743. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-feature/commit/bc8c8f3f3397aefcfaeaedcd20d543ef9e8fa46c > Allow serializing of feature model > -- > > Key: SLING-11743 > URL: https://issues.apache.org/jira/browse/SLING-11743 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 2.0.0 > > > Parts of the feature model already implement Serializable. We should make all > feature model objects serializable to allow serializing/deserializing of a > feature model via object streams -- This message was sent by Atlassian Jira (v8.20.10#820010)
