[jira] [Comment Edited] (SLING-11773) ResourceTypeHierarchyBasedResourcePicker not working anymore
[
https://issues.apache.org/jira/browse/SLING-11773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688346#comment-17688346
]
Radu Cotescu edited comment on SLING-11773 at 2/14/23 7:53 AM:
---
There's an additional issue though. With the migration, the components are
registered only based on the configuration properties. The registration
properties are ignored. See SLING-11774. I already have a fix that I'm testing,
haven't committed it yet.
Regarding
bq. That sounds like a bug in the underlying bnd library.
I had thought the same and updated to the latest parent pom, but then I figured
out that the default service registration properties were generated. If you
look at the other picker, its component properties are generated due to the use
of the configuration in the activate method.
was (Author: radu.cotescu):
There's an additional issue though. With the migration, the components are
registered only based on the configuration properties. The registration
properties are ignored. See SLING-11774. I already have a fix that I'm testing,
haven't committed it yet.
> ResourceTypeHierarchyBasedResourcePicker not working anymore
>
>
> Key: SLING-11773
> URL: https://issues.apache.org/jira/browse/SLING-11773
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Resource Merger 1.4.0
>Reporter: Sagar Miglani
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In SLING-10168, SCR annotations were replaced by OSGi and configurations of
> {{ResourceTypeHierarchyBasedResourcePicker}} have been designated to an inner
> Configuration class, which are not getting bind properly without
> {{@Activate}} Method.
> And hence {{ResourceTypeHierarchyBasedResourcePicker}} does not seem to be
> registered by
> {{MergedResourcePickerWhiteboard}} [0].
> Compared generated XMLs:
> *With {{Activate}} Method injection:*
> {code:xml}
>
> http://www.osgi.org/xmlns/scr/v1.3.0;
> name="org.apache.sling.resourcemerger.picker.overriding"
> configuration-policy="require" activate="activate">
>
>
>
>
> interface="org.apache.sling.resourcemerger.spi.MergedResourcePicker2"/>
>
> class="org.apache.sling.resourcemerger.impl.picker.ResourceTypeHierarchyBasedResourcePicker"/>
>
> {code}
> *Without {{@Activate}} method injection:*
> {code:xml}
>
> http://www.osgi.org/xmlns/scr/v1.3.0;
> name="org.apache.sling.resourcemerger.picker.overriding"
> configuration-policy="require">
>
>
> interface="org.apache.sling.resourcemerger.spi.MergedResourcePicker2"/>
>
>class="org.apache.sling.resourcemerger.impl.picker.ResourceTypeHierarchyBasedResourcePicker"/>
>
> {code}
> [0]:
> https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/master/src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java#L87
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11773) ResourceTypeHierarchyBasedResourcePicker not working anymore
[
https://issues.apache.org/jira/browse/SLING-11773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688346#comment-17688346
]
Radu Cotescu commented on SLING-11773:
--
There's an additional issue though. With the migration, the components are
registered only based on the configuration properties. The registration
properties are ignored. See SLING-11774. I already have a fix that I'm testing,
haven't committed it yet.
> ResourceTypeHierarchyBasedResourcePicker not working anymore
>
>
> Key: SLING-11773
> URL: https://issues.apache.org/jira/browse/SLING-11773
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Resource Merger 1.4.0
>Reporter: Sagar Miglani
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In SLING-10168, SCR annotations were replaced by OSGi and configurations of
> {{ResourceTypeHierarchyBasedResourcePicker}} have been designated to an inner
> Configuration class, which are not getting bind properly without
> {{@Activate}} Method.
> And hence {{ResourceTypeHierarchyBasedResourcePicker}} does not seem to be
> registered by
> {{MergedResourcePickerWhiteboard}} [0].
> Compared generated XMLs:
> *With {{Activate}} Method injection:*
> {code:xml}
>
> http://www.osgi.org/xmlns/scr/v1.3.0;
> name="org.apache.sling.resourcemerger.picker.overriding"
> configuration-policy="require" activate="activate">
>
>
>
>
> interface="org.apache.sling.resourcemerger.spi.MergedResourcePicker2"/>
>
> class="org.apache.sling.resourcemerger.impl.picker.ResourceTypeHierarchyBasedResourcePicker"/>
>
> {code}
> *Without {{@Activate}} method injection:*
> {code:xml}
>
> http://www.osgi.org/xmlns/scr/v1.3.0;
> name="org.apache.sling.resourcemerger.picker.overriding"
> configuration-policy="require">
>
>
> interface="org.apache.sling.resourcemerger.spi.MergedResourcePicker2"/>
>
>class="org.apache.sling.resourcemerger.impl.picker.ResourceTypeHierarchyBasedResourcePicker"/>
>
> {code}
> [0]:
> https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/master/src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java#L87
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-11774) Fix the registration of the MergedResourcePicker2 implementations
[ https://issues.apache.org/jira/browse/SLING-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688345#comment-17688345 ] Radu Cotescu edited comment on SLING-11774 at 2/14/23 7:46 AM: --- Ha, yes! It's the same issue. But there's a bit more to it - in addition to that, when the migration was done, only the configuration properties were passed to the pickers. Before we were also passing the registration properties from the ServiceReference. was (Author: radu.cotescu): Ha, yes! It's the same issue. But there's a bit more to it - in addition to that, when the migration was done, only the configuration properties were passed to the pickers. Before we were also passing the registration properties from the ServiceReference. Anyways, let's continue in SLING-11773. > Fix the registration of the MergedResourcePicker2 implementations > - > > Key: SLING-11774 > URL: https://issues.apache.org/jira/browse/SLING-11774 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Resource Merger 1.4.0 >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: Resource Merger 1.4.2 > > > It seems the improvement from SLING-10168 introduced a subtle bug, where the > components are registered only based on configuration properties, completely > ignoring their default configuration (where applicable). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11774) Fix the registration of the MergedResourcePicker2 implementations
[ https://issues.apache.org/jira/browse/SLING-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688345#comment-17688345 ] Radu Cotescu commented on SLING-11774: -- Ha, yes! It's the same issue. But there's a bit more to it - in addition to that, when the migration was done, only the configuration properties were passed to the pickers. Before we were also passing the registration properties from the ServiceReference. Anyways, let's continue in SLING-11773. > Fix the registration of the MergedResourcePicker2 implementations > - > > Key: SLING-11774 > URL: https://issues.apache.org/jira/browse/SLING-11774 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Resource Merger 1.4.0 >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: Resource Merger 1.4.2 > > > It seems the improvement from SLING-10168 introduced a subtle bug, where the > components are registered only based on configuration properties, completely > ignoring their default configuration (where applicable). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11763) Not all 'style' properties are preserved in the HTML output.
[
https://issues.apache.org/jira/browse/SLING-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688322#comment-17688322
]
Konrad Windszus commented on SLING-11763:
-
[~rombert] Sorry for the noise here, in fact my observation is not related as
in the custom code another context has been used.
> Not all 'style' properties are preserved in the HTML output.
> -
>
> Key: SLING-11763
> URL: https://issues.apache.org/jira/browse/SLING-11763
> Project: Sling
> Issue Type: Bug
> Components: XSS Protection API
>Affects Versions: XSS Protection API 2.3.0
>Reporter: Tatyana Vogel
>Assignee: Tatyana Vogel
>Priority: Blocker
> Fix For: XSS Protection API 2.3.4
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When trying to add the ‘style’ property ‘text-align: right’ (or center) the
> text will be displayed as left-aligned.
> T{color:#1d1c1d}his is regression compared to the previous version{color}.
> Expected Behavior: Text should be displayed on the right or center like
> decelerated in the ‘style=“text-align:...“’ property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-11763) Not all 'style' properties are preserved in the HTML output.
[
https://issues.apache.org/jira/browse/SLING-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688322#comment-17688322
]
Konrad Windszus edited comment on SLING-11763 at 2/14/23 6:58 AM:
--
[~rombert] Sorry for the noise here, in fact my observation is not related as
in the custom code another context has been used (html).
was (Author: kwin):
[~rombert] Sorry for the noise here, in fact my observation is not related as
in the custom code another context has been used.
> Not all 'style' properties are preserved in the HTML output.
> -
>
> Key: SLING-11763
> URL: https://issues.apache.org/jira/browse/SLING-11763
> Project: Sling
> Issue Type: Bug
> Components: XSS Protection API
>Affects Versions: XSS Protection API 2.3.0
>Reporter: Tatyana Vogel
>Assignee: Tatyana Vogel
>Priority: Blocker
> Fix For: XSS Protection API 2.3.4
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When trying to add the ‘style’ property ‘text-align: right’ (or center) the
> text will be displayed as left-aligned.
> T{color:#1d1c1d}his is regression compared to the previous version{color}.
> Expected Behavior: Text should be displayed on the right or center like
> decelerated in the ‘style=“text-align:...“’ property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-resourcemerger] sonarcloud[bot] commented on pull request #8: SLING-11773 - ResourceTypeHierarchyBasedResourcePicker not working
sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/8#issuecomment-1429146073 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourcemerger=8) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourcemerger=8=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourcemerger=8=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourcemerger=8=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourcemerger=8=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourcemerger=8=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourcemerger=8=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourcemerger=8=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourcemerger] sagarmiglani commented on a diff in pull request #8: SLING-11773 - ResourceTypeHierarchyBasedResourcePicker not working
sagarmiglani commented on code in PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/8#discussion_r1105310063
##
src/main/java/org/apache/sling/resourcemerger/impl/picker/ResourceTypeHierarchyBasedResourcePicker.java:
##
@@ -99,6 +100,11 @@ public List pickResources(ResourceResolver
resolver, String relativePa
return resources;
}
+@Activate
+protected void activate(final Configuration config) {
+
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-11774) Fix the registration of the MergedResourcePicker2 implementations
[ https://issues.apache.org/jira/browse/SLING-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688272#comment-17688272 ] Sagar Miglani commented on SLING-11774: --- [~radu] Does it look similar to SLING-11773 ? > Fix the registration of the MergedResourcePicker2 implementations > - > > Key: SLING-11774 > URL: https://issues.apache.org/jira/browse/SLING-11774 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Resource Merger 1.4.0 >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: Resource Merger 1.4.2 > > > It seems the improvement from SLING-10168 introduced a subtle bug, where the > components are registered only based on configuration properties, completely > ignoring their default configuration (where applicable). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Upgrade graphgql-java to 17.4
Hi Just an updated on the development of moving to a newer version of grqphql-java: Testing with Sling Graphql Core and AEM I did test graphql-java 17.4 and 20.0 and both versions seems to work just fine even though 20.0 does lead to a PAX testing issue in Sling Graphql Core but I think that’s not a big issue. There are a few issues that I am working out with the graphql-java team: - sun.misc is imported in the bundle (resolved) - MANIFEST.MF is not 1st entry in the JAR file (work in progresss) Cheers - Andy > On Feb 3, 2023, at 10:25 AM, Andreas Schaefer > wrote: > > Right now I am having issues with the SelectionSetWrapper and > SelectedFieldWrapper. The way graphql-java is providing the > DataFetchingFieldSelectionSet is quite different and I am not sure how to > handle it. > > The big difference is that there are no sub fields anymore and also no > InlineFragment vs Field. The Inline Fragment is not part of the Object Type > and a field name with different object types are combined into one. This > means I need to handle Object Types either in the caller to create one > SelectedFieldWrapper for each type or change the entire logic and make the > Sling Graphql Core work similar to graphql-java. > > I will start without changing Sling and then see if it works out. > > - Andy > >> On Feb 3, 2023, at 9:03 AM, Radu Cotescu wrote: >> >> Hi Andy, >> >>> On 3 Feb 2023, at 16:40, Andreas Schaefer wrote: >>> >>> Hi >>> >>> I am tasked with upgrading grqaphql-java for AEM to at least 17.4 because >>> of a vulnerability https://nvd.nist.gov/vuln/detail/CVE-2022-37734 >>> >>> I saw that Radu created a ticket for upgrading to graphql-java 17: >>> https://github.com/graphql-java/graphql-java/releases/tag/v17.0 >>> >>> I assigned that ticket to me and will see what needs to be done to make >>> this work in Sling as well as in AEM. >>> >>> Let me know if you have any objections or already worked on it. >>> >>> Thanks - Andy Schaefer >> >> No objections on my side. I started looking into this [0], but didn’t get to >> commit anything. I remember I had issues with dynamically registering our >> Sling directives [1], but I had to switch to a different task and forgot >> about [0]. >> >> Thanks, >> Radu >> >> [0] - https://issues.apache.org/jira/browse/SLING-10900 >> [1] - >> https://github.com/apache/sling-org-apache-sling-graphql-core/blob/0b1c1dd72ed04324ea84d2227c3223ec65b0b21e/src/main/java/org/apache/sling/graphql/core/directives/Directives.java >> >
[jira] [Assigned] (SLING-11774) Fix the registration of the MergedResourcePicker2 implementations
[ https://issues.apache.org/jira/browse/SLING-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu reassigned SLING-11774: Assignee: Radu Cotescu > Fix the registration of the MergedResourcePicker2 implementations > - > > Key: SLING-11774 > URL: https://issues.apache.org/jira/browse/SLING-11774 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Resource Merger 1.4.0 >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: Resource Merger 1.4.2 > > > It seems the improvement from SLING-10168 introduced a subtle bug, where the > components are registered only based on configuration properties, completely > ignoring their default configuration (where applicable). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11774) Fix the registration of the MergedResourcePicker2 implementations
Radu Cotescu created SLING-11774: Summary: Fix the registration of the MergedResourcePicker2 implementations Key: SLING-11774 URL: https://issues.apache.org/jira/browse/SLING-11774 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Resource Merger 1.4.0 Reporter: Radu Cotescu Fix For: Resource Merger 1.4.2 It seems the improvement from SLING-10168 introduced a subtle bug, where the components are registered only based on configuration properties, completely ignoring their default configuration (where applicable). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling i18n 2.6.0
Carsten,
Perhaps it would be prudent to log a warning message when translations are
found outside of the included_paths or provide a HealthCheck component that
does the same?
Regards,
Eric
On Sun, Feb 12, 2023 at 12:52 AM Carsten Ziegeler
wrote:
> Hi,
>
> yes, the default changes to provide a better out of the box setup.
> I think we can handle this via documentation.
>
> It is a change in behaviour but it is not breaking functionality - I
> know that this is debatable and others might have a different view.
> Most of the apps have their translations in /libs or /apps, there are
> some exceptions. If you have translations outside the default and update
> to the latest version *without* checking the changes, your application
> will still work. It might not show you a translated UI, which is easily
> detectable and then easy to fix.
>
> Regards
> Carsten
>
> Am 11.02.2023 um 23:09 schrieb Eric Norman:
> > Hi Carsten,
> >
> > For SLING-11744, what is the plan for dealing with backward
> compatibility?
> > If I am reading the changes correctly, it looks like the
> > new JcrResourceBundleProvider "included_paths" config now has a default
> > value of {"/libs", "/apps"} so that is what you would get if no
> > configuration was provided for that field. That appears to replace the
> > previous behavior that would search the whole repository, so it doesn't
> > look backward compatible to me.
> >
> > Regards,
> > Eric
> >
> > On Sat, Feb 11, 2023 at 4:17 AM Carsten Ziegeler
> > wrote:
> >
> >> Hi,
> >>
> >> We solved 3 issues in this release
> >>
> >>
> https://issues.apache.org/jira/browse/SLING-11744?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22i18n%202.6.0%22
> >>
> >> Staging repository:
> >> https://repository.apache.org/content/repositories/orgapachesling-2717
> >>
> >> You can use this UNIX script to download the release and verify the
> >> signatures:
> >>
> >>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >>
> >> Usage:
> >> sh check_staged_release.sh 2717 /tmp/sling-staging
> >>
> >> Please vote to approve this release:
> >>
> >> [ ] +1 Approve the release
> >> [ ] 0 Don't care
> >> [ ] -1 Don't release, because ...
> >>
> >> This majority vote is open for at least 72 hours.
> >>
> >> Regards
> >> Carsten
> >> --
> >> Carsten Ziegeler
> >> Adobe
> >> cziege...@apache.org
> >>
> >
>
> --
> Carsten Ziegeler
> Adobe
> cziege...@apache.org
>
Re: [VOTE] Release Apache Sling i18n 2.6.0
+1 On Sat, Feb 11, 2023 at 7:17 AM Carsten Ziegeler wrote: > Hi, > > We solved 3 issues in this release > > https://issues.apache.org/jira/browse/SLING-11744?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22i18n%202.6.0%22 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2717 > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2717 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org >
[GitHub] [sling-org-apache-sling-resourcemerger] kwin commented on a diff in pull request #8: SLING-11773 - ResourceTypeHierarchyBasedResourcePicker not working
kwin commented on code in PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/8#discussion_r1104585446
##
src/main/java/org/apache/sling/resourcemerger/impl/picker/ResourceTypeHierarchyBasedResourcePicker.java:
##
@@ -99,6 +100,11 @@ public List pickResources(ResourceResolver
resolver, String relativePa
return resources;
}
+@Activate
+protected void activate(final Configuration config) {
+
Review Comment:
Maybe add a comment why this is necessary, e.g. reference
https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-ordering.generated.properties
and state that otherwise the component properties are not populated from the
ObjectType defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (SLING-11773) ResourceTypeHierarchyBasedResourcePicker not working anymore
[
https://issues.apache.org/jira/browse/SLING-11773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687971#comment-17687971
]
Konrad Windszus edited comment on SLING-11773 at 2/13/23 2:54 PM:
--
I was assuming the {{@Designate}} annotation clearly connects them metatype
with the DS component
([https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/186043d052c4a25553cde99d3b55e630bc6bc062/src/main/java/org/apache/sling/resourcemerger/impl/picker/ResourceTypeHierarchyBasedResourcePicker.java#L39).]
But you are right, according to
[https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-ordering.generated.properties:]
Only
{quote}Properties defined through component property types used as the type of
an activation object.
{quote}
or
{quote}Properties defined through component property types annotating the
component implementation class.
{quote}
end up as component properties.
was (Author: kwin):
I was assuming the {{@Designate}} annotation clearly connects them metatype
with the DS component
([https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/186043d052c4a25553cde99d3b55e630bc6bc062/src/main/java/org/apache/sling/resourcemerger/impl/picker/ResourceTypeHierarchyBasedResourcePicker.java#L39).]
But you are right, according to
[https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-ordering.generated.properties:]
Only
{quote}Properties defined through component property types used as the type of
an activation object.
{quote}
or
{quote}Properties defined through component property types annotating the
component implementation class.
{quote}
end up as component properties.
I would prefer the latter in this case instead of introducing the empty
activate method.
> ResourceTypeHierarchyBasedResourcePicker not working anymore
>
>
> Key: SLING-11773
> URL: https://issues.apache.org/jira/browse/SLING-11773
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Resource Merger 1.4.0
>Reporter: Sagar Miglani
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In SLING-10168, SCR annotations were replaced by OSGi and configurations of
> {{ResourceTypeHierarchyBasedResourcePicker}} have been designated to an inner
> Configuration class, which are not getting bind properly without
> {{@Activate}} Method.
> And hence {{ResourceTypeHierarchyBasedResourcePicker}} does not seem to be
> registered by
> {{MergedResourcePickerWhiteboard}} [0].
> Compared generated XMLs:
> *With {{Activate}} Method injection:*
> {code:xml}
>
> http://www.osgi.org/xmlns/scr/v1.3.0;
> name="org.apache.sling.resourcemerger.picker.overriding"
> configuration-policy="require" activate="activate">
>
>
>
>
> interface="org.apache.sling.resourcemerger.spi.MergedResourcePicker2"/>
>
> class="org.apache.sling.resourcemerger.impl.picker.ResourceTypeHierarchyBasedResourcePicker"/>
>
> {code}
> *Without {{@Activate}} method injection:*
> {code:xml}
>
> http://www.osgi.org/xmlns/scr/v1.3.0;
> name="org.apache.sling.resourcemerger.picker.overriding"
> configuration-policy="require">
>
>
> interface="org.apache.sling.resourcemerger.spi.MergedResourcePicker2"/>
>
>class="org.apache.sling.resourcemerger.impl.picker.ResourceTypeHierarchyBasedResourcePicker"/>
>
> {code}
> [0]:
> https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/master/src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java#L87
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11773) ResourceTypeHierarchyBasedResourcePicker not working anymore
[
https://issues.apache.org/jira/browse/SLING-11773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687971#comment-17687971
]
Konrad Windszus commented on SLING-11773:
-
I was assuming the {{@Designate}} annotation clearly connects them metatype
with the DS component
([https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/186043d052c4a25553cde99d3b55e630bc6bc062/src/main/java/org/apache/sling/resourcemerger/impl/picker/ResourceTypeHierarchyBasedResourcePicker.java#L39).]
But you are right, according to
[https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-ordering.generated.properties:]
Only
{quote}Properties defined through component property types used as the type of
an activation object.
{quote}
or
{quote}Properties defined through component property types annotating the
component implementation class.
{quote}
end up as component properties.
I would prefer the latter in this case instead of introducing the empty
activate method.
> ResourceTypeHierarchyBasedResourcePicker not working anymore
>
>
> Key: SLING-11773
> URL: https://issues.apache.org/jira/browse/SLING-11773
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Resource Merger 1.4.0
>Reporter: Sagar Miglani
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In SLING-10168, SCR annotations were replaced by OSGi and configurations of
> {{ResourceTypeHierarchyBasedResourcePicker}} have been designated to an inner
> Configuration class, which are not getting bind properly without
> {{@Activate}} Method.
> And hence {{ResourceTypeHierarchyBasedResourcePicker}} does not seem to be
> registered by
> {{MergedResourcePickerWhiteboard}} [0].
> Compared generated XMLs:
> *With {{Activate}} Method injection:*
> {code:xml}
>
> http://www.osgi.org/xmlns/scr/v1.3.0;
> name="org.apache.sling.resourcemerger.picker.overriding"
> configuration-policy="require" activate="activate">
>
>
>
>
> interface="org.apache.sling.resourcemerger.spi.MergedResourcePicker2"/>
>
> class="org.apache.sling.resourcemerger.impl.picker.ResourceTypeHierarchyBasedResourcePicker"/>
>
> {code}
> *Without {{@Activate}} method injection:*
> {code:xml}
>
> http://www.osgi.org/xmlns/scr/v1.3.0;
> name="org.apache.sling.resourcemerger.picker.overriding"
> configuration-policy="require">
>
>
> interface="org.apache.sling.resourcemerger.spi.MergedResourcePicker2"/>
>
>class="org.apache.sling.resourcemerger.impl.picker.ResourceTypeHierarchyBasedResourcePicker"/>
>
> {code}
> [0]:
> https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/master/src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java#L87
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert merged pull request #156: Clarify level of repoinit support
rombert merged PR #156: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11773) ResourceTypeHierarchyBasedResourcePicker not working anymore
[
https://issues.apache.org/jira/browse/SLING-11773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687945#comment-17687945
]
Carsten Ziegeler commented on SLING-11773:
--
[~kwin] I don't think this is a bnd bug. There is no instruction (annotation)
in the class instructing bnd to generate properties. Only the usage in a
lifecycle method does this. The used annotations are purely for metatype.
> ResourceTypeHierarchyBasedResourcePicker not working anymore
>
>
> Key: SLING-11773
> URL: https://issues.apache.org/jira/browse/SLING-11773
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Resource Merger 1.4.0
>Reporter: Sagar Miglani
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In SLING-10168, SCR annotations were replaced by OSGi and configurations of
> {{ResourceTypeHierarchyBasedResourcePicker}} have been designated to an inner
> Configuration class, which are not getting bind properly without
> {{@Activate}} Method.
> And hence {{ResourceTypeHierarchyBasedResourcePicker}} does not seem to be
> registered by
> {{MergedResourcePickerWhiteboard}} [0].
> Compared generated XMLs:
> *With {{Activate}} Method injection:*
> {code:xml}
>
> http://www.osgi.org/xmlns/scr/v1.3.0;
> name="org.apache.sling.resourcemerger.picker.overriding"
> configuration-policy="require" activate="activate">
>
>
>
>
> interface="org.apache.sling.resourcemerger.spi.MergedResourcePicker2"/>
>
> class="org.apache.sling.resourcemerger.impl.picker.ResourceTypeHierarchyBasedResourcePicker"/>
>
> {code}
> *Without {{@Activate}} method injection:*
> {code:xml}
>
> http://www.osgi.org/xmlns/scr/v1.3.0;
> name="org.apache.sling.resourcemerger.picker.overriding"
> configuration-policy="require">
>
>
> interface="org.apache.sling.resourcemerger.spi.MergedResourcePicker2"/>
>
>class="org.apache.sling.resourcemerger.impl.picker.ResourceTypeHierarchyBasedResourcePicker"/>
>
> {code}
> [0]:
> https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/master/src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java#L87
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11773) ResourceTypeHierarchyBasedResourcePicker not working anymore
[
https://issues.apache.org/jira/browse/SLING-11773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687911#comment-17687911
]
Konrad Windszus commented on SLING-11773:
-
That sounds like a bug in the underlying bnd library. [~sagarmiglani] Can you
try upgrading to the latest parent instead to see if this fixes it? Otherwise
would be good to report a bug at https://github.com/bndtools/bnd/issues/.
> ResourceTypeHierarchyBasedResourcePicker not working anymore
>
>
> Key: SLING-11773
> URL: https://issues.apache.org/jira/browse/SLING-11773
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Resource Merger 1.4.0
>Reporter: Sagar Miglani
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In SLING-10168, SCR annotations were replaced by OSGi and configurations of
> {{ResourceTypeHierarchyBasedResourcePicker}} have been designated to an inner
> Configuration class, which are not getting bind properly without
> {{@Activate}} Method.
> And hence {{ResourceTypeHierarchyBasedResourcePicker}} does not seem to be
> registered by
> {{MergedResourcePickerWhiteboard}} [0].
> Compared generated XMLs:
> *With {{Activate}} Method injection:*
> {code:xml}
>
> http://www.osgi.org/xmlns/scr/v1.3.0;
> name="org.apache.sling.resourcemerger.picker.overriding"
> configuration-policy="require" activate="activate">
>
>
>
>
> interface="org.apache.sling.resourcemerger.spi.MergedResourcePicker2"/>
>
> class="org.apache.sling.resourcemerger.impl.picker.ResourceTypeHierarchyBasedResourcePicker"/>
>
> {code}
> *Without {{@Activate}} method injection:*
> {code:xml}
>
> http://www.osgi.org/xmlns/scr/v1.3.0;
> name="org.apache.sling.resourcemerger.picker.overriding"
> configuration-policy="require">
>
>
> interface="org.apache.sling.resourcemerger.spi.MergedResourcePicker2"/>
>
>class="org.apache.sling.resourcemerger.impl.picker.ResourceTypeHierarchyBasedResourcePicker"/>
>
> {code}
> [0]:
> https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/master/src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java#L87
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-resourcemerger] sonarcloud[bot] commented on pull request #8: SLING-11773 - ResourceTypeHierarchyBasedResourcePicker not working
sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/8#issuecomment-1427850487 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourcemerger=8) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourcemerger=8=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourcemerger=8=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourcemerger=8=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourcemerger=8=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourcemerger=8=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourcemerger=8=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourcemerger=8=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourcemerger=8=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11773) ResourceTypeHierarchyBasedResourcePicker not working anymore
Sagar Miglani created SLING-11773:
-
Summary: ResourceTypeHierarchyBasedResourcePicker not working
anymore
Key: SLING-11773
URL: https://issues.apache.org/jira/browse/SLING-11773
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Resource Merger 1.4.0
Reporter: Sagar Miglani
In SLING-10168, SCR annotations were replaced by OSGi and configurations of
{{ResourceTypeHierarchyBasedResourcePicker}} have been designated to an inner
Configuration class, which are not getting bind properly without {{@Activate}}
Method.
And hence {{ResourceTypeHierarchyBasedResourcePicker}} does not seem to be
registered by
{{MergedResourcePickerWhiteboard}} [0].
Compared generated XMLs:
*With {{Activate}} Method injection:*
{code:xml}
http://www.osgi.org/xmlns/scr/v1.3.0;
name="org.apache.sling.resourcemerger.picker.overriding"
configuration-policy="require" activate="activate">
{code}
*Without {{@Activate}} method injection:*
{code:xml}
http://www.osgi.org/xmlns/scr/v1.3.0;
name="org.apache.sling.resourcemerger.picker.overriding"
configuration-policy="require">
{code}
[0]:
https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/master/src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java#L87
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11772) Add EventHandler dependency to the DistributionEventNotifier component
José Correia created SLING-11772: Summary: Add EventHandler dependency to the DistributionEventNotifier component Key: SLING-11772 URL: https://issues.apache.org/jira/browse/SLING-11772 Project: Sling Issue Type: Improvement Components: Content Distribution Affects Versions: Content Distribution Journal Core 0.1.26 Reporter: José Correia Fix For: Content Distribution Journal Core 0.1.28 We should add an _EventHandler_ dependency to the _DistributionEventNotifier_ in order to make sure that the OSGI components responsible for processing the event are activated before the event emitter is up and sending events. This way we avoid loosing created events. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11718) Migrate to Jakarta JSON API
[ https://issues.apache.org/jira/browse/SLING-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-11718. --- > Migrate to Jakarta JSON API > --- > > Key: SLING-11718 > URL: https://issues.apache.org/jira/browse/SLING-11718 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Feature Model Analyser, Maven Plugins and > Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.0, slingfeature-maven-plugin > 1.6.10, Feature Model Diff Tool 0.1.0, JCR ContentLoader 2.6.0, > Content-Package to Feature Model Converter 1.3.0, Feature Model 2.0.0, > Feature Model API Regions Extension 2.0.0, Feature Model Launcher 1.3.0 > > > Starting with JEE 9 the package names for the enterprise APIs changed from > javax.* to jakarta.* which means that we will benefit from updates to those > APIs only if we make the move. > For the feature model and the related tooling, it should be fairly easy to do > this move as this code is usually only used at tool time but not at > application runtime. > We can simply replace javax.json with jakarta.json and do new releases of > everything involved with a new major version. As we are currently using > javax.json in parts of the API, this will be a breaking change, therefore the > major version update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11203) Content Loader: Introduce requireImportProvider directive
[
https://issues.apache.org/jira/browse/SLING-11203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-11203.
---
> Content Loader: Introduce requireImportProvider directive
> -
>
> Key: SLING-11203
> URL: https://issues.apache.org/jira/browse/SLING-11203
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
>Reporter: Stefan Seifert
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR ContentLoader 2.6.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> in context of SLING-11189 [~enorman] proposed the introduction of a
> {{requireImportProvider}} directive which allows bundles to declare on which
> import provider implementations they actually depend. with this, it can be
> ensured a bundle's content is not imported in an inconsistent state when one
> of the required providers is not (yet) available.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11725) Update to Sling Bundle Parent 49
[ https://issues.apache.org/jira/browse/SLING-11725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-11725. --- > Update to Sling Bundle Parent 49 > > > Key: SLING-11725 > URL: https://issues.apache.org/jira/browse/SLING-11725 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: JCR ContentLoader 2.6.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update to Sling Bundle Parent 49 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11713) Change ACL json input structure to be less ambiguous for restrictions
[
https://issues.apache.org/jira/browse/SLING-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-11713.
---
> Change ACL json input structure to be less ambiguous for restrictions
> -
>
> Key: SLING-11713
> URL: https://issues.apache.org/jira/browse/SLING-11713
> Project: Sling
> Issue Type: New Feature
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR ContentLoader 2.6.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The restriction details in the security:acl contentloader json input can be
> ambiguous in some situations.
> This is the ContentLoader equivalent for what was done for SLING-11243 and
> SLING-11233
> Expected:
> The JSON structure of the security:acl entries should be enhanced to make it
> more clear.
> For example, replace the "granted/denied/restrictions" items with a
> "privileges" structure whose items are the granted or denied privileges.
> Each privilege has a "deny" and/or "allow" child whose value is either true
> (no restrictions) or an array of restrictions + values.
> For example:
> {code:java}
> "security:acl": [
> {
> "principal": "sling123_user",
> "privileges":{
> "jcr:read": {
> "allow": true
> },
> "jcr:write":{
> "allow":{
> "rep:glob":"glob1allow"
> },
> "deny":{
> "rep:glob":"glob1deny"
> }
> }
> }
> }
> ] {code}
>
> The previous syntax should be preserved for backward compatibility.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11764) jcr:content node missing for file resources generated in binaries index defintions
[
https://issues.apache.org/jira/browse/SLING-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-11764.
---
> jcr:content node missing for file resources generated in binaries index
> defintions
> --
>
> Key: SLING-11764
> URL: https://issues.apache.org/jira/browse/SLING-11764
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.0
>Reporter: Abhishek Garg
>Assignee: Abhishek Garg
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.0
>
>
> The index definition files generated by the cpcconvertor are missing
> mandatory jcr:content nodes.
> How the resource should look:
> {code:java}
> "tika": {
> "jcr:primaryType": "nam:nt:unstructured",
> "config.xml": {
> "jcr:primaryType": "nam:nt:file",
> "jcr:content": {
> "jcr:mimeType": "text/xml",
> "jcr:data": ":blobId:",
> "jcr:primaryType": "nam:nt:resource"
> }
> }
> }
> {code}
>
> How it looks like now:
> {code:java}
> "tika":{
> "jcr:primaryType":"nam:nt:unstructured",
> "config.xml":{
> "jcr:primaryType":"nam:nt:file",
> "jcr:data":":blobid:"
> }
> }{code}
>
> there is no jcr:content node present
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11719) Remove deprecated API
[ https://issues.apache.org/jira/browse/SLING-11719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-11719. --- > Remove deprecated API > - > > Key: SLING-11719 > URL: https://issues.apache.org/jira/browse/SLING-11719 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Feature Model Analyser, Maven Plugins and > Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.0, Feature Model 2.0.0, > Feature Model API Regions Extension 2.0.0 > > > With the move to the jakarta api (SLING-11718) we will have breaking api > changes, therefore we can at the same time get rid of deprecated api -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11743) Allow serializing of feature model
[ https://issues.apache.org/jira/browse/SLING-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-11743. --- > Allow serializing of feature model > -- > > Key: SLING-11743 > URL: https://issues.apache.org/jira/browse/SLING-11743 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 2.0.0 > > > Parts of the feature model already implement Serializable. We should make all > feature model objects serializable to allow serializing/deserializing of a > feature model via object streams -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11739) Index definition extraction from content packages is missing binary files data
[ https://issues.apache.org/jira/browse/SLING-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-11739. --- > Index definition extraction from content packages is missing binary files data > -- > > Key: SLING-11739 > URL: https://issues.apache.org/jira/browse/SLING-11739 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.24 >Reporter: Abhishek Garg >Assignee: Abhishek Garg >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.0 > > > Currently, binaries are stored in indexDefinitions at [1] and these binaries > should be written in JSONOutput at [2], However each time we are getting it > as empty at [2]. > The reason is that we are storing binaries against its repositoryPath instead > it should be its parent path. > i.e we are storing tika config.xml binaries at repositoryPath > `oak:index/damAssetLucene-8-custom-2/tika/config.xml` > and while writing at [2],we are trying to fetch it from > `oak:index/damAssetLucene-8-custom-2/tika/` > because of this we are getting it as empty as nodeName is till > `oak:index/damAssetLucene-8-custom-2/tika` only. > [1]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java] > [2]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java#L137] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling Feature Model Diff Tool 0.1.0, Apache Sling Content-Package to Feature Model Converter 1.3.0, Apache Sling JCR ContentLoader 2.6.0, Apache Sling Feature Model 2.0.
Hi, The vote has passed with the following result: +1 (binding): Carsten Ziegeler, Angela Schreiber, Robert Munteanu I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Radu Cotescu
Re: [VOTE] Release Apache Sling Feature Model Diff Tool 0.1.0, Apache Sling Content-Package to Feature Model Converter 1.3.0, Apache Sling JCR ContentLoader 2.6.0, Apache Sling Feature Model 2.0.0, Ap
On Wed, 2023-02-08 at 16:07 +0100, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
