[jira] [Commented] (SLING-11809) Disable "overwritePrimaryTypesOfFolders" in the distribution journal
[ https://issues.apache.org/jira/browse/SLING-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705785#comment-17705785 ] Danilo Banjac commented on SLING-11809: --- I've created a new PR (linked in the ticket). Review is appreciated. Thanks. > Disable "overwritePrimaryTypesOfFolders" in the distribution journal > > > Key: SLING-11809 > URL: https://issues.apache.org/jira/browse/SLING-11809 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Roxana-Elena Balasoiu >Assignee: Timothee Maret >Priority: Blocker > > By default, *overwritePrimaryTypesOfFolders* in AEM is set to {*}false{*}, > which conflicts with the value set to *true* in the distribution journal. > This mismatch can lead to inconsistencies, as observed with some customers. > To prevent inconsistencies, ensure that the *overwritePrimaryTypesOfFolders* > value in the distribution journal aligns with the default value of *false* in > AEM. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-app-cms] klcodanr merged pull request #35: SLING-11808 - Cannot run SlingCMS 1.1.2+ on Windows
klcodanr merged PR #35: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-oak] sonarcloud[bot] commented on pull request #12: Bump commons-net from 3.3 to 3.9.0
sonarcloud[bot] commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/12#issuecomment-1485782300 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&resolved=false&types=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&metric=coverage&view=list) No Coverage information [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=12&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE] Release Apache Sling Graphql Core version 0.0.16
Hi, We solved N issues in this release: https://issues.apache.org/jira/browse/SLING-10900 NOTE: this was tested with AEM 6.6 There are still some outstanding issues: none Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2730 https://repository.apache.org/content/repositories/orgapachesling-[YOUR REPOSITORY ID]/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2730 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Commented] (SLING-10900) Update graphl-java to version 17
[ https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705660#comment-17705660 ] Andreas Schaefer commented on SLING-10900: -- After graphql-java released 20.1 with the necessary fixes to make it work in an OSGi environment I updated the code to move to version 20.1 and start the release process. > Update graphl-java to version 17 > > > Key: SLING-10900 > URL: https://issues.apache.org/jira/browse/SLING-10900 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Andreas Schaefer >Priority: Major > Fix For: GraphQL Core 0.0.16 > > > {{graphql-java}} 17 brings a set of performance improvements [0] which could > benefit the GraphQL Core bundle: > * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for > Streams and Iterators > * Dramatic performance improvements in GraphQLSchema building > * Dramatic performance improvements in DataFetchingFieldSelectionSet > * Dramatic performance improvements in large query validation > [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10321) Deprecate service mapping by userID
[ https://issues.apache.org/jira/browse/SLING-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705459#comment-17705459 ] Mahidhar Chaluvadi commented on SLING-10321: [~angela] - Hello I have a question. Reading the documentation I understand the permissions managed via grp membership are not effective for service users when mapping via principal instead of user id. But does this mean the group memberships are gone when trying to perform API calls that depend on group membership? For e.g. We use a custom API that does UserManager operations, and requires that service user is part of user-administrators, else causes AccessDenied regardless of what permissions we grant on respective folders. In future I hope removal of user-id based mapping being gone shouldn't impact this functionality. Please confirm the same. cc: [~sseifert] > Deprecate service mapping by userID > --- > > Key: SLING-10321 > URL: https://issues.apache.org/jira/browse/SLING-10321 > Project: Sling > Issue Type: Improvement > Components: Service User Mapper >Affects Versions: Service User Mapper 1.5.2 >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Service User Mapper 1.5.4 > > Time Spent: 40m > Remaining Estimate: 0h > > [~cziegeler], [~kpauls], for security reasons I would like to deprecate the > old service user mapping by a single userID in favor of the new format that > takes one or multiple principal names. > The new format allows to keep service permissions limited to service-users as > declared in the mapping and doesn't resolve declare or inherited group > permissions. This gives full control over the effective permissions granted > to each service and doesn't risk unrelated permission changes (e.g. to a base > group like 'everyone') impacting service security. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[Vote] Release Apache Sling Oak-Based Discovery Service 1.2.44 AND Apache Sling Event 4.3.8
Hi, This vote is about 2 parts: [part 1] Apache Sling Oak-Based Discovery Service 1.2.44 : We solved 2 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12352471 There are still some outstanding issues: https://issues.apache.org/jira/projects/SLING/versions/12353050 [part 2] Apache Sling Event 4.3.8 : We solved 2 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12351879 There are still some outstanding issues: https://issues.apache.org/jira/projects/SLING/versions/12353051 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2729/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2729 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Cheers, Stefan
[jira] [Updated] (SLING-11422) Stop embedding the event.api package in the event bundle
[ https://issues.apache.org/jira/browse/SLING-11422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-11422: Fix Version/s: Event 4.3.10 (was: Event 4.3.8) > Stop embedding the event.api package in the event bundle > > > Key: SLING-11422 > URL: https://issues.apache.org/jira/browse/SLING-11422 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Robert Munteanu >Priority: Major > Fix For: Event 4.3.10 > > > As discussed in SLING-9664, deploying the Sling Event and Event API bundles > separately would be more in line with how we deploy bundles and also fix the > Javadoc generation. > We should make this a minor version bump for the event bundle, to make it > clear that deployers need to adapt. Probably the baselining mechanism will > complain, but it's something we can ignore for the release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-9664: --- Fix Version/s: Event 4.3.10 (was: Event 4.3.8) > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Joerg Hoh >Priority: Major > Fix For: Event 4.3.10 > > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11805) Don't stop slingId cleanup upon PROPERTIES_CHANGED
[ https://issues.apache.org/jira/browse/SLING-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved SLING-11805. - Resolution: Fixed > Don't stop slingId cleanup upon PROPERTIES_CHANGED > -- > > Key: SLING-11805 > URL: https://issues.apache.org/jira/browse/SLING-11805 > Project: Sling > Issue Type: Improvement > Components: Discovery >Affects Versions: Discovery Oak 1.2.40 >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Minor > Fix For: Discovery Oak 1.2.44 > > Time Spent: 0.5h > Remaining Estimate: 0h > > As a follow-up to SLING-10854 where the SlingIdCleanupTask was introduced. > The current implementation stops cleanup when it received a > PROPERTIES_CHANGED event. This is actually wrong. It should continue. The way > it is currently done has the effect that cleanup is only triggered upon a > TOPOLOGY_INIT or TOPOLOGY_CHANGED without a following PROPERTIES_CHANGED. > This current behaviour reduces the chances of the cleanup running - having > said that, the likelyhood of the cleanup eventually running is still very > high. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-9625) DiscoveryServiceImpl#doUpdateProperties may fail due to a LoginException
[ https://issues.apache.org/jira/browse/SLING-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-9625: --- Fix Version/s: Discovery Oak 1.2.46 (was: Discovery Oak 1.2.44) > DiscoveryServiceImpl#doUpdateProperties may fail due to a LoginException > - > > Key: SLING-9625 > URL: https://issues.apache.org/jira/browse/SLING-9625 > Project: Sling > Issue Type: Improvement >Affects Versions: Discovery Oak 1.2.30 >Reporter: Konrad Windszus >Priority: Major > Fix For: Discovery Oak 1.2.46 > > > While stopping the OSGi container (Sling Starter 12 SNAPSHOT) I observed the > following error > {code} > 03.08.2020 10:30:06.262 *INFO * [Apache Sling Terminator] Stopping Apache > Sling > ERROR: bundle org.apache.sling.discovery.oak:1.2.28 > (139)[org.apache.sling.discovery.oak.OakDiscoveryService(200)] : The > updatedPropertyProvider method has thrown an exception > java.lang.RuntimeException: Could not log in to repository > (org.apache.sling.api.resource.LoginException: Cannot derive user name for > bundle org.apache.sling.discovery.oak [139] and sub service null) > at > org.apache.sling.discovery.oak.OakDiscoveryService.doUpdateProperties(OakDiscoveryService.java:540) > at > org.apache.sling.discovery.oak.OakDiscoveryService.bindPropertyProviderInteral(OakDiscoveryService.java:406) > at > org.apache.sling.discovery.oak.OakDiscoveryService.updatedPropertyProvider(OakDiscoveryService.java:421) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:242) > at > org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41) > at > org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:678) > at > org.apache.felix.scr.impl.inject.methods.BaseMethod$NotResolved.invoke(BaseMethod.java:633) > at > org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:524) > at > org.apache.felix.scr.impl.inject.methods.BindMethod.invoke(BindMethod.java:42) > at > org.apache.felix.scr.impl.manager.DependencyManager.invokeUpdatedMethod(DependencyManager.java:1934) > at > org.apache.felix.scr.impl.manager.SingleComponentManager.invokeUpdatedMethod(SingleComponentManager.java:448) > at > org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.modifiedService(DependencyManager.java:366) > at > org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.modifiedService(DependencyManager.java:297) > at > org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerModified(ServiceTracker.java:1229) > at > org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerModified(ServiceTracker.java:1137) > at > org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:883) > at > org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1168) > at > org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:125) > at > org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990) > at > org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838) > at > org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545) > at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833) > at org.apache.felix.framework.Felix.access$000(Felix.java:112) > at org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:434) > at > org.apache.felix.framework.ServiceRegistry.servicePropertiesModified(ServiceRegistry.java:601) > at > org.apache.felix.framework.ServiceRegistrationImpl.setProperties(ServiceRegistrationImpl.java:132) > at > org.apache.sling.event.impl.jobs.JobConsumerManager.unbindService(JobConsumerManager.java:354) > at > org.apache.sling.event.impl.jobs.JobConsumerManager.unbindJobExecutor(JobConsumerManager.java:270) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Me
[jira] [Updated] (SLING-10813) Improve ViewStateManagerImpl.waitForAsyncEvents, also speeds up tests
[ https://issues.apache.org/jira/browse/SLING-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-10813: Fix Version/s: Discovery Oak 1.2.46 (was: Discovery Oak 1.2.44) > Improve ViewStateManagerImpl.waitForAsyncEvents, also speeds up tests > - > > Key: SLING-10813 > URL: https://issues.apache.org/jira/browse/SLING-10813 > Project: Sling > Issue Type: Improvement > Components: Discovery >Reporter: Stefan Egli >Priority: Minor > Fix For: Discovery Oak 1.2.46 > > > As discussed [in this > PR|https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4#discussion_r708292265] > the ViewStateManagerImpl.waitForAsyncEvents returning currently requires a > {{Thread.sleep()}} to ensure anything that was "just triggered" has finished > executing asynchronously. > This should be improved in this waitForAsyncEvent method, by being more > precise about when it returns (ie include any call to > {{asyncEvent.trigger()}} having terminated) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-5598) Exclude slow tests by default with assume(sling.slow.tests.enabled)
[ https://issues.apache.org/jira/browse/SLING-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-5598: --- Fix Version/s: Discovery Oak 1.2.46 (was: Discovery Oak 1.2.44) > Exclude slow tests by default with assume(sling.slow.tests.enabled) > > > Key: SLING-5598 > URL: https://issues.apache.org/jira/browse/SLING-5598 > Project: Sling > Issue Type: Task > Components: Extensions >Affects Versions: Discovery Impl 1.2.6, Discovery Base 1.1.2, Discovery > Commons 1.0.10, Discovery Oak 1.2.6 >Reporter: Stefan Egli >Priority: Major > Fix For: Discovery Impl 1.2.14, Discovery Base 2.0.16, Discovery > Commons 1.0.30, Discovery Oak 1.2.46 > > Attachments: SLING-5598-commons-testing.patch, > SLING-5598-discovery.patch > > > As suggested by [~bdelacretaz] on [the > list|http://markmail.org/message/yad5awqg53epk3ck] we should improve test > duration (ideally 1-2min per bundle max, 10-15min overall). While they are > not yet improved however, slow tests should be excluded by default and run > only if enabled explicitly. Here's an example {{@Before}} method to achieve > that: > {noformat} > @Before > public void checkSlowTests() { > assumeNotNull(System.getProperty("sling.slow.tests.enabled")); > } > {noformat} > and to enable the slow tests you do: {{mvn -Dsling.slow.tests.enabled=true > clean test}} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-10008) Add null annotations to package org.apache.sling.discovery (Discovery API)
[ https://issues.apache.org/jira/browse/SLING-10008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-10008: Fix Version/s: Discovery Oak 1.2.46 (was: Discovery Oak 1.2.44) > Add null annotations to package org.apache.sling.discovery (Discovery API) > -- > > Key: SLING-10008 > URL: https://issues.apache.org/jira/browse/SLING-10008 > Project: Sling > Issue Type: Improvement > Components: Discovery >Reporter: Konrad Windszus >Priority: Major > Fix For: Discovery Oak 1.2.46 > > > In https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2492 > and https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2498 > there were potential NPEs uncovered. To prevent consumers from running into > those the Null annotations > (https://sling.apache.org/documentation/development/null-analysis.html) > should be added to the relevant classes there as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11619) Restore safeguard mechanism for discovery config's int and long properties
[ https://issues.apache.org/jira/browse/SLING-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli closed SLING-11619. --- > Restore safeguard mechanism for discovery config's int and long properties > -- > > Key: SLING-11619 > URL: https://issues.apache.org/jira/browse/SLING-11619 > Project: Sling > Issue Type: Task > Components: Discovery >Affects Versions: Discovery Oak 1.2.40 >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Minor > Fix For: Discovery Oak 1.2.42 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > With the [update to parent > 47|https://github.com/apache/sling-org-apache-sling-discovery-oak/commit/c306408f36e7636c72b71805d2bb0e3e6f0f0e73#diff-73d443e41e9bfaa5e9c77b6db0e318079f1885f5a7ed9685aae9730209adc579] > the discovery.oak's Config "lost" the ability to gracefully deal with wrong > values, such as empty strings. It used to silently swallow these, but now > fails loudly with > {noformat} > org.osgi.service.component.ComponentException: > java.lang.NumberFormatException: For input string: "" > at > org.apache.felix.scr.impl.inject.internal.Annotations$Handler.invoke(Annotations.java:379) > [org.apache.felix.scr:2.2.0] > at com.sun.proxy.$Proxy368.backoffStandbyFactor(Unknown Source) > at org.apache.sling.discovery.oak.Config.configure(Config.java:238) > [org.apache.sling.discovery.oak:1.2.40] > at org.apache.sling.discovery.oak.Config.activate(Config.java:159) > [org.apache.sling.discovery.oak:1.2.40] > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: SLING-11709 - Set up Jira autolinks to all Sling Github projects
On Thu, 2023-03-23 at 19:42 +0100, Konrad Windszus wrote: > I think one week passed :-) Are you still planning to work on this? > This is a very useful feature. Yes, but obviously delayed :-) I started working on a script, see https://github.com/apache/sling-aggregator/pull/8 . But it needs some improvements to handle existing files and gracefully merge them without overwriting. Definitely happy to incorporate changes if someone wants to contribute. Robert > > Thanks, > Konrad > > > On 15. Dec 2022, at 13:11, Konrad Windszus wrote: > > > > Sounds good to me. Could we at the same reestablish auto-linking of > > GitHub PRs with > > https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Jiranotificationoptions > > > > I would suggest just adding "jira_optionsL link", as the other > > options probably cause too much noise. WDYT? > > > > Konrad > > > > On 2022/12/01 15:54:12 Robert Munteanu wrote: > > > Hi, > > > > > > We can now set autolinks [1] for our GitHub modules using > > > .asf.yaml > > > [2]. > > > > > > For now, we can only explicitly reference Jira projects from the > > > ASF > > > Jira instance. > > > > > > Since this is going to be one of those "push a commit to each > > > module" > > > operations, I think we should make sure we have all the Jira > > > projects > > > that we need included from the start. > > > > > > I proposed an initial set of values at [3], feel free to add > > > more. > > > > > > I plan to make the change in a week or so. > > > > > > Thanks, > > > Robert > > > > > > > > > [1]: > > > https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-autolinks-to-reference-external-resources > > > [2]: > > > https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-AutolinksforJira > > > [3]: https://issues.apache.org/jira/browse/SLING-11709 > > > >
[GitHub] [sling-aggregator] rombert opened a new pull request, #8: SLING-11709 - Set up Jira autolinks to all Sling Github projects
rombert opened a new pull request, #8: URL: https://github.com/apache/sling-aggregator/pull/8 Start working on a script to automate .asf.yaml maintenance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11811) caconfig Mock Plugin: Register Sling Models injector in beforeSetUp
[ https://issues.apache.org/jira/browse/SLING-11811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-11811. Assignee: Stefan Seifert Resolution: Fixed https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/commit/5eb36b1ac6674360acbf74cc7aa6b12e7eb0dd84 > caconfig Mock Plugin: Register Sling Models injector in beforeSetUp > --- > > Key: SLING-11811 > URL: https://issues.apache.org/jira/browse/SLING-11811 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Context-Aware Configuration Mock Plugin 1.4.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Context-Aware Configuration Mock Plugin 1.4.2 > > Time Spent: 0.5h > Remaining Estimate: 0h > > in line with > [https://github.com/wcm-io/io.wcm.testing.wcm-io-mock.sling/pull/4] and > following the discussion in > [https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/5] sling models > injectrs in sling mocks plugin should be registered in *beforeSetUp* instead > of afterSetUp, to ensure they are present before the auto-registration of > sling models found in classpath is executed. > otherwise all sling models are re-registered (it seems even multiple times) > if the injector is added later. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-testing-caconfig-mock-plugin] stefanseifert merged pull request #2: SLING-11811 caconfig Mock Plugin: Register Sling Models injector in beforeSetUp
stefanseifert merged PR #2: URL: https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-caconfig-mock-plugin] sonarcloud[bot] commented on pull request #2: SLING-11811 caconfig Mock Plugin: Register Sling Models injector in beforeSetUp
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/pull/2#issuecomment-1484725534 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&resolved=false&types=CODE_SMELL) [![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png '100.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&metric=new_coverage&view=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin&pullRequest=2&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-caconfig-mock-plugin] stefanseifert opened a new pull request, #2: SLING-11811 caconfig Mock Plugin: Register Sling Models injector in beforeSetUp
stefanseifert opened a new pull request, #2: URL: https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/pull/2 https://issues.apache.org/jira/browse/SLING-11811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11811) caconfig Mock Plugin: Register Sling Models injector in beforeSetUp
Stefan Seifert created SLING-11811: -- Summary: caconfig Mock Plugin: Register Sling Models injector in beforeSetUp Key: SLING-11811 URL: https://issues.apache.org/jira/browse/SLING-11811 Project: Sling Issue Type: Improvement Components: Testing Affects Versions: Context-Aware Configuration Mock Plugin 1.4.0 Reporter: Stefan Seifert Fix For: Context-Aware Configuration Mock Plugin 1.4.2 in line with [https://github.com/wcm-io/io.wcm.testing.wcm-io-mock.sling/pull/4] and following the discussion in [https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/5] sling models injectrs in sling mocks plugin should be registered in *beforeSetUp* instead of afterSetUp, to ensure they are present before the auto-registration of sling models found in classpath is executed. otherwise all sling models are re-registered (it seems even multiple times) if the injector is added later. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11792) osgi-mock, sling-mock: Allow mixture of plugins/callbacks
[ https://issues.apache.org/jira/browse/SLING-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-11792. -- > osgi-mock, sling-mock: Allow mixture of plugins/callbacks > - > > Key: SLING-11792 > URL: https://issues.apache.org/jira/browse/SLING-11792 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing Sling Mock 3.4.4, Testing OSGi Mock 3.3.6 > > Time Spent: 50m > Remaining Estimate: 0h > > the OsgiContextBuilder and SlingContextBuilder provides methods to add an > array of plugins or callbacks to customize the test execution. the current > generic annotations allows only a list of plugins using the same subtype of > the context: > {code} > public final SlingContextBuilder plugin(@NotNull > ContextPlugin @NotNull ... plugin) > {code} > it would be more flexible, to allow mixing plugins with any subtype in a > single row: > {code} > public final SlingContextBuilder plugin(@NotNull ContextPlugin OsgiContextImpl> @NotNull ... plugin) > {code} > this applies to various methods of the \*ContextBuilder and Plugins > implementations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling Testing OSGi Mock 3.3.6, Sling Mock 3.4.4
Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Daniel Klco, Eric Norman I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. stefan