[jira] [Commented] (SLING-11967) Onboard JCR Presence to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-11967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743426#comment-17743426 ] Oliver Lietz commented on SLING-11967: -- [~bellingard], Please onboard {{sling-org-apache-sling-jcr-presence}} to SonarCloud. > Onboard JCR Presence to SonarCloud > -- > > Key: SLING-11967 > URL: https://issues.apache.org/jira/browse/SLING-11967 > Project: Sling > Issue Type: Task > Components: JCR >Reporter: Oliver Lietz >Assignee: Fabrice Bellingard >Priority: Major > Fix For: JCR Presence 1.0.0 > > > {{sling-org-apache-sling-jcr-presence}} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11967) Onboard JCR Presence to SonarCloud
Oliver Lietz created SLING-11967: Summary: Onboard JCR Presence to SonarCloud Key: SLING-11967 URL: https://issues.apache.org/jira/browse/SLING-11967 Project: Sling Issue Type: Task Components: JCR Reporter: Oliver Lietz Assignee: Fabrice Bellingard Fix For: JCR Presence 1.0.0 {{sling-org-apache-sling-jcr-presence}} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #40: SLING-11067 extend URIProvider by method returning Optional
sonarcloud[bot] commented on PR #40: URL: https://github.com/apache/sling-org-apache-sling-api/pull/40#issuecomment-1636749540 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-api&pullRequest=40) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=40&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=40&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=40&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=40&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=40&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=40&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=40&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=40&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=40&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=40&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=40&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=40&resolved=false&types=CODE_SMELL) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=40&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=40&metric=new_coverage&view=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=40&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=40&metric=new_duplicated_lines_density&view=list) ![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png 'idea') Catch issues before they fail your Quality Gate with our IDE extension ![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png 'sonarlint') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #920 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/920/ for details. No further emails will be sent until the status of the build is changed.
Re: Rewriter: resource structure forcing a dependency on OSGI services
Hey, What is the reasoning around making this a JCR node in the first place? Why not make it an OSGi configuration instead? I often had the same issue where the specific parser was not live yet as OSGi service, but the configuration already exists in the repo so I get the message that you stated Greets, Roy > On 14 Jul 2023, at 09:51, Jörg Hoh wrote: > > Hi, > > I want to bring up a topic, which has caused me headaches for quite some > time. > > We have a rewriter configuration, which is stored within in the Sling > Repository, and which is picked up any request. But we often see messages > like this in the logs: > > org.apache.sling.engine.impl.SlingRequestProcessorImpl service: > Uncaught SlingException > java.io.IOException: Unable to get component of class 'interface > org.apache.sling.rewriter.Transformer' with type 'externallinks'. > > This is normally caused by the requested rewriter not being present and > should vanish as soon as that service is present. But I also have seen > cases, that the instance was not getting up because of this; *at least > that's my impression, I have not closely analyzed it. (I hoped that this > problem of instances not starting up properly was fixed with SSLING-11317, > but I spotted this behavior afterwards as well.) > > The problem is the dependency of a repository structure to an OSGI service, > which we cannot model with the means of OSGI (at least I am not aware of > that); it will be always a polling mechanism to see if the service is > present, and fail with an exception if not. > > Are you aware of a way to change this dependency and make it more > OSGI-aware, and not starting the relevant parts of the sling engine if the > requested rewriter is not present? > > Jörg > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh
[jira] [Resolved] (SLING-11907) Update depends-maven-plugin to 1.5.0 (reproducible builds)
[ https://issues.apache.org/jira/browse/SLING-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11907. - Resolution: Fixed Fixed in https://github.com/apache/sling-parent/commit/7f6d30d81093bbbead3fe2dbb172dbf46dd10e70 > Update depends-maven-plugin to 1.5.0 (reproducible builds) > -- > > Key: SLING-11907 > URL: https://issues.apache.org/jira/browse/SLING-11907 > Project: Sling > Issue Type: Task >Affects Versions: Parent 49 >Reporter: Joerg Hoh >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 52 > > > We should update the maven-depends-plugin to 1.5.0, as it will fix an issue > with reproducible builds. > See SM-5021. > Then we don't need workarounds on a bundle level anymore (like > https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/36) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11907) Update depends-maven-plugin to 1.5.0 (reproducible builds)
[ https://issues.apache.org/jira/browse/SLING-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-11907: --- Assignee: Konrad Windszus (was: Joerg Hoh) > Update depends-maven-plugin to 1.5.0 (reproducible builds) > -- > > Key: SLING-11907 > URL: https://issues.apache.org/jira/browse/SLING-11907 > Project: Sling > Issue Type: Task >Affects Versions: Parent 49 >Reporter: Joerg Hoh >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 52 > > > We should update the maven-depends-plugin to 1.5.0, as it will fix an issue > with reproducible builds. > See SM-5021. > Then we don't need workarounds on a bundle level anymore (like > https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/36) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11907) Update depends-maven-plugin to 1.5.0 (reproducible builds)
[ https://issues.apache.org/jira/browse/SLING-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11907: Fix Version/s: Parent 52 > Update depends-maven-plugin to 1.5.0 (reproducible builds) > -- > > Key: SLING-11907 > URL: https://issues.apache.org/jira/browse/SLING-11907 > Project: Sling > Issue Type: Task >Affects Versions: Parent 49 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Parent 52 > > > We should update the maven-depends-plugin to 1.5.0, as it will fix an issue > with reproducible builds. > See SM-5021. > Then we don't need workarounds on a bundle level anymore (like > https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/36) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11966) Broken site descriptor
[ https://issues.apache.org/jira/browse/SLING-11966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11966. - Resolution: Fixed Fixed in https://github.com/apache/sling-parent/commit/2c4cf8a3c14b8fbb14c37da37664b6d0274bdd91. > Broken site descriptor > -- > > Key: SLING-11966 > URL: https://issues.apache.org/jira/browse/SLING-11966 > Project: Sling > Issue Type: Bug >Affects Versions: Parent 50 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 52 > > > The XML in {{site.xml}} became non-well-formed after commit > https://github.com/apache/sling-parent/commit/17d84016a7f28821b452eb927906c1e660e6e130. > This leads to errors like this when building sites based on this descriptor > {code} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on > project slingfeature-maven-plugin: SiteToolException: Error parsing site > descriptor: start tag unexpected character < (position: START_DOCUMENT seen > ...TION/1.8.0 http://maven.apache.org/xsd/decoration-1.8.0.xsd"\n<... > @23:6) -> [Help 1] > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11966) Broken site descriptor
[ https://issues.apache.org/jira/browse/SLING-11966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11966: Component/s: General > Broken site descriptor > -- > > Key: SLING-11966 > URL: https://issues.apache.org/jira/browse/SLING-11966 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Parent 50 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 52 > > > The XML in {{site.xml}} became non-well-formed after commit > https://github.com/apache/sling-parent/commit/17d84016a7f28821b452eb927906c1e660e6e130. > This leads to errors like this when building sites based on this descriptor > {code} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on > project slingfeature-maven-plugin: SiteToolException: Error parsing site > descriptor: start tag unexpected character < (position: START_DOCUMENT seen > ...TION/1.8.0 http://maven.apache.org/xsd/decoration-1.8.0.xsd"\n<... > @23:6) -> [Help 1] > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11966) Broken site descriptor
Konrad Windszus created SLING-11966: --- Summary: Broken site descriptor Key: SLING-11966 URL: https://issues.apache.org/jira/browse/SLING-11966 Project: Sling Issue Type: Bug Affects Versions: Parent 50 Reporter: Konrad Windszus Assignee: Konrad Windszus Fix For: Parent 52 The XML in {{site.xml}} became non-well-formed after commit https://github.com/apache/sling-parent/commit/17d84016a7f28821b452eb927906c1e660e6e130. This leads to errors like this when building sites based on this descriptor {code} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on project slingfeature-maven-plugin: SiteToolException: Error parsing site descriptor: start tag unexpected character < (position: START_DOCUMENT seen ...TION/1.8.0 http://maven.apache.org/xsd/decoration-1.8.0.xsd"\n<... @23:6) -> [Help 1] {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)