[jira] [Commented] (SLING-11975) org.apache.sling.launchpad.base.jar fails to load on jdk 11.0.20 because it has malformed Zip64 extra fields

2023-07-24 Thread Mark Adamcin (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746581#comment-17746581
 ] 

Mark Adamcin commented on SLING-11975:
--

For future reference, I narrowed down the affected artifact versions to just 
the three listed. Using zipinfo, it looks like the malformed entries are the 
ones embedded from org.apache.felix.framework. If the upstream zip entries 
defined a zip64 extra field like a last modified timestamp, the resulting 
embedded entry had a malformed zip64 extra field.
 * 7.0.1-2.7.2
 * 7.0.1-2.7.4
 * 7.0.3-2.7.6

> org.apache.sling.launchpad.base.jar fails to load on jdk 11.0.20 because it 
> has malformed Zip64 extra fields
> 
>
> Key: SLING-11975
> URL: https://issues.apache.org/jira/browse/SLING-11975
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Affects Versions: Launchpad Base 2.7.2, Launchpad Base 2.7.4, Launchpad 
> Base 2.7.6
>Reporter: Mark Adamcin
>Assignee: Mark Adamcin
>Priority: Critical
>  Labels: has-pr
> Fix For: Launchpad Base 2.7.8
>
>
> I ran into an error when trying to run AEM quickstart locally after upgrading 
> my jdk to 11.0.20 ([release 
> notes|https://www.oracle.com/java/technologies/javase/11-0-20-relnotes.html]):
> {quote}core-libs/java.util.jar
> *[➜|https://www.oracle.com/java/technologies/javase/11-0-20-relnotes.html#JDK-8302483]*
>  *Improved ZIP64 Extra Field Validation* (JDK-8302483 (not 
> public)){{{}java.util.zip.ZipFile{}}} has been updated to provide additional 
> validation of ZIP64 extra fields when opening a ZIP file. This validation may 
> be disabled by setting the system property 
> {{jdk.util.zip.disableZip64ExtraFieldValidation}} to {{{}true{}}}.{quote}
> it manifested for me as an exception in {{logs/stderr.log}} :
> {code:java}
> 20.07.2023 07:59:22.568 *ERROR* [main] Cannot launch: Cannot install 
> jar:file:/opt/code/aem/quickstart/target/author-54594/crx-quickstart/app/cq-quickstart-6.6.0-SNAPSHOT-standalone-quickstart.jar!/resources/org.apache.sling.launchpad.base.jar
>  for use
> 20.07.2023 07:59:22.568 *ERROR* [main] java.util.zip.ZipException: Invalid 
> CEN header (invalid zip64 extra data field size)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.zerror(ZipFile.java:1736)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.checkExtraFields(ZipFile.java:1254)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.initCEN(ZipFile.java:1701)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.(ZipFile.java:1430)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1393)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$CleanableResource.(ZipFile.java:742)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$CleanableResource.get(ZipFile.java:859)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile.(ZipFile.java:257)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile.(ZipFile.java:186)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.jar.JarFile.(JarFile.java:348)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.jar.JarFile.(JarFile.java:319)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.jar.JarFile.(JarFile.java:285)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> org.apache.sling.commons.osgi.bundleversion.FileBundleVersionInfo.(FileBundleVersionInfo.java:40)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> org.apache.sling.launchpad.base.shared.Loader.installLauncherJar(Loader.java:172)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> org.apache.sling.launchpad.app.Main.doStart(Main.java:382)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> org.apache.sling.launchpad.app.Main.doStart(Main.java:347)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.lang.reflect.Method.invoke(Method.java:566)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> com.adobe.granite.quickstart.base.impl.exec.Bootstrap.run(Bootstrap.java:107)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
>

[jira] [Updated] (SLING-11975) org.apache.sling.launchpad.base.jar fails to load on jdk 11.0.20 because it has malformed Zip64 extra fields

2023-07-24 Thread Mark Adamcin (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Adamcin updated SLING-11975:
-
Affects Version/s: Launchpad Base 2.7.4
   Launchpad Base 2.7.2

> org.apache.sling.launchpad.base.jar fails to load on jdk 11.0.20 because it 
> has malformed Zip64 extra fields
> 
>
> Key: SLING-11975
> URL: https://issues.apache.org/jira/browse/SLING-11975
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Affects Versions: Launchpad Base 2.7.2, Launchpad Base 2.7.4, Launchpad 
> Base 2.7.6
>Reporter: Mark Adamcin
>Assignee: Mark Adamcin
>Priority: Critical
>  Labels: has-pr
> Fix For: Launchpad Base 2.7.8
>
>
> I ran into an error when trying to run AEM quickstart locally after upgrading 
> my jdk to 11.0.20 ([release 
> notes|https://www.oracle.com/java/technologies/javase/11-0-20-relnotes.html]):
> {quote}core-libs/java.util.jar
> *[➜|https://www.oracle.com/java/technologies/javase/11-0-20-relnotes.html#JDK-8302483]*
>  *Improved ZIP64 Extra Field Validation* (JDK-8302483 (not 
> public)){{{}java.util.zip.ZipFile{}}} has been updated to provide additional 
> validation of ZIP64 extra fields when opening a ZIP file. This validation may 
> be disabled by setting the system property 
> {{jdk.util.zip.disableZip64ExtraFieldValidation}} to {{{}true{}}}.{quote}
> it manifested for me as an exception in {{logs/stderr.log}} :
> {code:java}
> 20.07.2023 07:59:22.568 *ERROR* [main] Cannot launch: Cannot install 
> jar:file:/opt/code/aem/quickstart/target/author-54594/crx-quickstart/app/cq-quickstart-6.6.0-SNAPSHOT-standalone-quickstart.jar!/resources/org.apache.sling.launchpad.base.jar
>  for use
> 20.07.2023 07:59:22.568 *ERROR* [main] java.util.zip.ZipException: Invalid 
> CEN header (invalid zip64 extra data field size)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.zerror(ZipFile.java:1736)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.checkExtraFields(ZipFile.java:1254)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.initCEN(ZipFile.java:1701)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.(ZipFile.java:1430)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1393)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$CleanableResource.(ZipFile.java:742)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$CleanableResource.get(ZipFile.java:859)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile.(ZipFile.java:257)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile.(ZipFile.java:186)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.jar.JarFile.(JarFile.java:348)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.jar.JarFile.(JarFile.java:319)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.jar.JarFile.(JarFile.java:285)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> org.apache.sling.commons.osgi.bundleversion.FileBundleVersionInfo.(FileBundleVersionInfo.java:40)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> org.apache.sling.launchpad.base.shared.Loader.installLauncherJar(Loader.java:172)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> org.apache.sling.launchpad.app.Main.doStart(Main.java:382)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> org.apache.sling.launchpad.app.Main.doStart(Main.java:347)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.lang.reflect.Method.invoke(Method.java:566)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> com.adobe.granite.quickstart.base.impl.exec.Bootstrap.run(Bootstrap.java:107)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> com.adobe.granite.quickstart.base.impl.Quickstart.run(Quickstart.java:272)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> com.adobe.granite.quickstart.base.impl.Main.(Main.java:918)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> com.adobe.granite.quickstart.base.impl.Main.main(Main.java:980)
> MAIN process: shutdown hook
> MAIN process: exiting {code}
> This appears to be an issue with

[jira] [Closed] (SLING-11977) Update to Apache Felix Framework 7.0.5

2023-07-24 Thread Carsten Ziegeler (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-11977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-11977.


> Update to Apache Felix Framework 7.0.5
> --
>
> Key: SLING-11977
> URL: https://issues.apache.org/jira/browse/SLING-11977
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Launchpad Base 2.7.8
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-11975) org.apache.sling.launchpad.base.jar fails to load on jdk 11.0.20 because it has malformed Zip64 extra fields

2023-07-24 Thread Carsten Ziegeler (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-11975.


> org.apache.sling.launchpad.base.jar fails to load on jdk 11.0.20 because it 
> has malformed Zip64 extra fields
> 
>
> Key: SLING-11975
> URL: https://issues.apache.org/jira/browse/SLING-11975
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Affects Versions: Launchpad Base 2.7.6
>Reporter: Mark Adamcin
>Assignee: Mark Adamcin
>Priority: Critical
>  Labels: has-pr
> Fix For: Launchpad Base 2.7.8
>
>
> I ran into an error when trying to run AEM quickstart locally after upgrading 
> my jdk to 11.0.20 ([release 
> notes|https://www.oracle.com/java/technologies/javase/11-0-20-relnotes.html]):
> {quote}core-libs/java.util.jar
> *[➜|https://www.oracle.com/java/technologies/javase/11-0-20-relnotes.html#JDK-8302483]*
>  *Improved ZIP64 Extra Field Validation* (JDK-8302483 (not 
> public)){{{}java.util.zip.ZipFile{}}} has been updated to provide additional 
> validation of ZIP64 extra fields when opening a ZIP file. This validation may 
> be disabled by setting the system property 
> {{jdk.util.zip.disableZip64ExtraFieldValidation}} to {{{}true{}}}.{quote}
> it manifested for me as an exception in {{logs/stderr.log}} :
> {code:java}
> 20.07.2023 07:59:22.568 *ERROR* [main] Cannot launch: Cannot install 
> jar:file:/opt/code/aem/quickstart/target/author-54594/crx-quickstart/app/cq-quickstart-6.6.0-SNAPSHOT-standalone-quickstart.jar!/resources/org.apache.sling.launchpad.base.jar
>  for use
> 20.07.2023 07:59:22.568 *ERROR* [main] java.util.zip.ZipException: Invalid 
> CEN header (invalid zip64 extra data field size)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.zerror(ZipFile.java:1736)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.checkExtraFields(ZipFile.java:1254)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.initCEN(ZipFile.java:1701)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.(ZipFile.java:1430)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1393)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$CleanableResource.(ZipFile.java:742)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile$CleanableResource.get(ZipFile.java:859)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile.(ZipFile.java:257)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.zip.ZipFile.(ZipFile.java:186)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.jar.JarFile.(JarFile.java:348)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.jar.JarFile.(JarFile.java:319)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.util.jar.JarFile.(JarFile.java:285)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> org.apache.sling.commons.osgi.bundleversion.FileBundleVersionInfo.(FileBundleVersionInfo.java:40)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> org.apache.sling.launchpad.base.shared.Loader.installLauncherJar(Loader.java:172)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> org.apache.sling.launchpad.app.Main.doStart(Main.java:382)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> org.apache.sling.launchpad.app.Main.doStart(Main.java:347)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> java.base/java.lang.reflect.Method.invoke(Method.java:566)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> com.adobe.granite.quickstart.base.impl.exec.Bootstrap.run(Bootstrap.java:107)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> com.adobe.granite.quickstart.base.impl.Quickstart.run(Quickstart.java:272)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> com.adobe.granite.quickstart.base.impl.Main.(Main.java:918)
> 20.07.2023 07:59:22.568 *ERROR* [main]  at 
> com.adobe.granite.quickstart.base.impl.Main.main(Main.java:980)
> MAIN process: shutdown hook
> MAIN process: exiting {code}
> This appears to be an issue with the org.apache.sling.launchpad.base 
> 7.0.3-2.7.6 jar specifically:
> {code:java}
> $ jar -tf 
>

[jira] [Closed] (SLING-11976) Update to parent 51 and make build work with Java 11

2023-07-24 Thread Carsten Ziegeler (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-11976.


> Update to parent 51 and make build work with Java 11
> 
>
> Key: SLING-11976
> URL: https://issues.apache.org/jira/browse/SLING-11976
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Launchpad Base 2.7.8
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[VOTE RESULT] Apache Sling Launchpad Base 7.0.5-2.7.8

2023-07-24 Thread Carsten Ziegeler 

The vote passed with three binding +1 votes

Thanks
Carsten

--
Carsten Ziegeler
Adobe
cziege...@apache.org

Re: [VOTE] Release Apache Sling Resource Merger 1.4.4

2023-07-24 Thread Carsten Ziegeler 

+1

Carsten

On 24.07.2023 13:30, Carsten Ziegeler wrote:

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING-11978

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2774

You can use this UNIX script to download the release and verify the
signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2774 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten


--
Carsten Ziegeler
Adobe
cziege...@apache.org

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #40: Sling 11982 avoid repo access

2023-07-24 Thread via GitHub 


sonarcloud[bot] commented on PR #40:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/40#issuecomment-1647991970

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver=40)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=40=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=40=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=40=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=40=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=40=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=40=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=40=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=40=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=40=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=40=false=CODE_SMELL)
 
[![B](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B-16px.png
 
'B')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=40=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=40=false=CODE_SMELL)
   
   
[![90.5%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png
 
'90.5%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=40=new_coverage=list)
 [90.5% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=40=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=40=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=40=new_duplicated_lines_density=list)
   
   
   
   
![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png
 'idea') Catch issues before they fail your Quality Gate with our IDE extension 
![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png
 'sonarlint') 
[SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[VOTE] Release Apache Sling Resource Merger 1.4.4

2023-07-24 Thread Carsten Ziegeler 

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING-11978

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2774

You can use this UNIX script to download the release and verify the
signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2774 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe
cziege...@apache.org

[jira] [Created] (SLING-11984) Sling Resource Merger takes current node structure into consideration (not only parent) when determining inclusion/exclusions of nodes with sling:hideChildren

2023-07-24 Thread Henry Kuijpers (Jira) 
Henry Kuijpers created SLING-11984:
--

 Summary: Sling Resource Merger takes current node structure into 
consideration (not only parent) when determining inclusion/exclusions of nodes 
with sling:hideChildren
 Key: SLING-11984
 URL: https://issues.apache.org/jira/browse/SLING-11984
 Project: Sling
  Issue Type: Bug
Affects Versions: Resource Merger 1.4.0
Reporter: Henry Kuijpers


It seems that the following node structure:

/apps/test
+ a
+ b
+ c

/apps/test2 (sling:resourceSuperType=/apps/test)
(sling:hideChildren=!a,!b,*)
+ a (with modifications)
+ d (newly defined)

results in:
a,b
instead of
a,b,d

The d node was added additionally (i.e. a tab in a dialog). It does not make 
sense to me that we would need to add it in the whitelist of children that we 
do not want to hide. To me, it seems that sling:hideChildren should only act on 
what is defined in the parent, not on what is defined in the current structure.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling GraphQL Core 0.0.22

2023-07-24 Thread Andreas Schaefer 
I am sorry to be a little pushy here but this is an important release to 
upgrade to the latest GraphQL-java because of security vulnerabilities in v15.0.

The previous release failed to address an issue with Inlined Fragments which 
are dropped by graphql-java but it can be resolved with the Object Type Names 
which are not exposed in this release 0.0.22.

Thanks - Andy

> On Jul 20, 2023, at 9:49 AM, Radu Cotescu  wrote:
> 
> Hi,
> 
> We solved 1 issue in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12353082
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2772/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2772 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards,
> Radu Cotescu