date:20230917

[jira] [Comment Edited] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled

2023-09-17 Thread Julian Reschke (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766203#comment-17766203
 ] 

Julian Reschke edited comment on SLING-12025 at 9/18/23 6:57 AM:
-

I agree that the behaviour needs to be the same.

I disagree that special-casing jcr:content is useful, but it's unlikely that we 
can remove that as "feature".

Note, this might be an oversight, or it might be because the non-cached lookup 
would be even more expensive with that "feature".


was (Author: reschke):
I agree that the behaviour needs to be the same.

I disagree that special-casing jcr:content is usefuly, but it's unlikely that 
we can remove that as "feature".

> ResourceResolver: different mapping when optimizedAliasResolution enabled
> -
>
> Key: SLING-12025
> URL: https://issues.apache.org/jira/browse/SLING-12025
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Priority: Major
>
> I found that the there is a different behavior in case the "optimized alias 
> resolution is enabled.
> Setup:
> {noformat}
> * /content/jcr:content
>   + sling:alias=foobar
> {noformat}
> In my opinion the expected behavior is that the {{content}} resource is 
> aliased and can be resolved via both {{/content}} and {{/foobar}}. You cannot 
> alias the {{jcr:content}} node. Unfortunately there are no unit tests for 
> that, and I just came across that behavior when I tried to write one.
> This works with the "optimized alias resolution" feature turned on, but if 
> it's turned off, it does not work anymore, and you can resolve that resource 
> only via its name. (In that case I assume that the jcr:content resource is 
> aliased.)
> I created 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to 
> demonstrate this problem.
> Is my assumption about the behavior correct?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled

2023-09-17 Thread Julian Reschke (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766203#comment-17766203
 ] 

Julian Reschke commented on SLING-12025:


I agree that the behaviour needs to be the same.

I disagree that special-casing jcr:content is usefuly, but it's unlikely that 
we can remove that as "feature".

> ResourceResolver: different mapping when optimizedAliasResolution enabled
> -
>
> Key: SLING-12025
> URL: https://issues.apache.org/jira/browse/SLING-12025
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Priority: Major
>
> I found that the there is a different behavior in case the "optimized alias 
> resolution is enabled.
> Setup:
> {noformat}
> * /content/jcr:content
>   + sling:alias=foobar
> {noformat}
> In my opinion the expected behavior is that the {{content}} resource is 
> aliased and can be resolved via both {{/content}} and {{/foobar}}. You cannot 
> alias the {{jcr:content}} node. Unfortunately there are no unit tests for 
> that, and I just came across that behavior when I tried to write one.
> This works with the "optimized alias resolution" feature turned on, but if 
> it's turned off, it does not work anymore, and you can resolve that resource 
> only via its name. (In that case I assume that the jcr:content resource is 
> aliased.)
> I created 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to 
> demonstrate this problem.
> Is my assumption about the behavior correct?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled

2023-09-17 Thread Joerg Hoh (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joerg Hoh updated SLING-12025:
--
Description: 
I found that the there is a different behavior in case the "optimized alias 
resolution is enabled.

Setup:
{noformat}
* /content/jcr:content
  + sling:alias=foobar
{noformat}

In my opinion the expected behavior is that the {{content}} resource is aliased 
and can be resolved via both {{/content}} and {{/foobar}}. You cannot alias the 
{{jcr:content}} node. Unfortunately there are no unit tests for that, and I 
just came across that behavior when I tried to write one.

This works with the "optimized alias resolution" feature turned on, but if it's 
turned off, it does not work anymore, and you can resolve that resource only 
via its name. (In that case I assume that the jcr:content resource is aliased.)

I created 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to 
demonstrate this problem.

Is my assumption about the behavior correct?






  was:
I found that the there is a different behavior in case the "optimized alias 
resolution is enabled.

Setup:
{noformat}
* /content/jcr:content
  + sling:alias=foobar
{noformat}

In my opinion the expected behavior is that the {{content}} resource is aliased 
and can be resolved via both {{/content}} and {{/foobar}}. You cannot alias the 
{{jcr:content}} node. Unfortunately there are no unit tests for that, and I 
just came across that behavior when I tried to write one.

This works with the "optimized alias resolution" feature turned on, but if it's 
turned off, it does not work anymore, and you can resolve that resource only 
via its name. (In that case I assume that the jcr:content node is aliased.)

I created 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to 
demonstrate this problem.

Is my assumption about the behavior correct?







> ResourceResolver: different mapping when optimizedAliasResolution enabled
> -
>
> Key: SLING-12025
> URL: https://issues.apache.org/jira/browse/SLING-12025
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Priority: Major
>
> I found that the there is a different behavior in case the "optimized alias 
> resolution is enabled.
> Setup:
> {noformat}
> * /content/jcr:content
>   + sling:alias=foobar
> {noformat}
> In my opinion the expected behavior is that the {{content}} resource is 
> aliased and can be resolved via both {{/content}} and {{/foobar}}. You cannot 
> alias the {{jcr:content}} node. Unfortunately there are no unit tests for 
> that, and I just came across that behavior when I tried to write one.
> This works with the "optimized alias resolution" feature turned on, but if 
> it's turned off, it does not work anymore, and you can resolve that resource 
> only via its name. (In that case I assume that the jcr:content resource is 
> aliased.)
> I created 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to 
> demonstrate this problem.
> Is my assumption about the behavior correct?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled

2023-09-17 Thread Joerg Hoh (Jira)

Joerg Hoh created SLING-12025:
-

 Summary: ResourceResolver: different mapping when 
optimizedAliasResolution enabled
 Key: SLING-12025
 URL: https://issues.apache.org/jira/browse/SLING-12025
 Project: Sling
  Issue Type: Task
  Components: ResourceResolver
Affects Versions: Resource Resolver 1.10.0
Reporter: Joerg Hoh


I found that the there is a different behavior in case the "optimized alias 
resolution is enabled.

Setup:
{noformat}
+ /content/jcr:content
  + sling:alias=foobar
{noformat}

In my opinion the expected behavior is that the {{content}} resource is aliased 
and can be resolved via both {{/content}} and {{/foobar}}. You cannot alias the 
{{jcr:content}} node. Unfortunately there are no unit tests for that, and I 
just came across that behavior when I tried to write one.

This works with the "optimized alias resolution" feature turned on, but if it's 
turned off, it does not work anymore, and you can resolve that resource only 
via its name. (In that case I assume that the jcr:content node is aliased.)

I created 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to 
demonstrate this problem.

Is my assumption about the behavior correct?








--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled

2023-09-17 Thread Joerg Hoh (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joerg Hoh updated SLING-12025:
--
Description: 
I found that the there is a different behavior in case the "optimized alias 
resolution is enabled.

Setup:
{noformat}
* /content/jcr:content
  + sling:alias=foobar
{noformat}

In my opinion the expected behavior is that the {{content}} resource is aliased 
and can be resolved via both {{/content}} and {{/foobar}}. You cannot alias the 
{{jcr:content}} node. Unfortunately there are no unit tests for that, and I 
just came across that behavior when I tried to write one.

This works with the "optimized alias resolution" feature turned on, but if it's 
turned off, it does not work anymore, and you can resolve that resource only 
via its name. (In that case I assume that the jcr:content node is aliased.)

I created 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to 
demonstrate this problem.

Is my assumption about the behavior correct?






  was:
I found that the there is a different behavior in case the "optimized alias 
resolution is enabled.

Setup:
{noformat}
+ /content/jcr:content
  + sling:alias=foobar
{noformat}

In my opinion the expected behavior is that the {{content}} resource is aliased 
and can be resolved via both {{/content}} and {{/foobar}}. You cannot alias the 
{{jcr:content}} node. Unfortunately there are no unit tests for that, and I 
just came across that behavior when I tried to write one.

This works with the "optimized alias resolution" feature turned on, but if it's 
turned off, it does not work anymore, and you can resolve that resource only 
via its name. (In that case I assume that the jcr:content node is aliased.)

I created 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to 
demonstrate this problem.

Is my assumption about the behavior correct?







> ResourceResolver: different mapping when optimizedAliasResolution enabled
> -
>
> Key: SLING-12025
> URL: https://issues.apache.org/jira/browse/SLING-12025
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Priority: Major
>
> I found that the there is a different behavior in case the "optimized alias 
> resolution is enabled.
> Setup:
> {noformat}
> * /content/jcr:content
>   + sling:alias=foobar
> {noformat}
> In my opinion the expected behavior is that the {{content}} resource is 
> aliased and can be resolved via both {{/content}} and {{/foobar}}. You cannot 
> alias the {{jcr:content}} node. Unfortunately there are no unit tests for 
> that, and I just came across that behavior when I tried to write one.
> This works with the "optimized alias resolution" feature turned on, but if 
> it's turned off, it does not work anymore, and you can resolve that resource 
> only via its name. (In that case I assume that the jcr:content node is 
> aliased.)
> I created 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to 
> demonstrate this problem.
> Is my assumption about the behavior correct?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #101: SLING-11715 in the optimized code path avoid resource resolution

2023-09-17 Thread via GitHub



sonarcloud[bot] commented on PR #101:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/101#issuecomment-1722490442

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=CODE_SMELL)
 [4 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=CODE_SMELL)
   
   
[![93.3%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png
 
'93.3%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&metric=new_coverage&view=list)
 [93.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #101: SLING-11715 in the optimized code path avoid resource resolution

2023-09-17 Thread via GitHub



sonarcloud[bot] commented on PR #101:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/101#issuecomment-1722479762

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=CODE_SMELL)
 [4 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&resolved=false&types=CODE_SMELL)
   
   
[![95.3%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png
 
'95.3%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&metric=new_coverage&view=list)
 [95.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=101&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Comment Edited] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled

[jira] [Commented] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled

[jira] [Updated] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled

[jira] [Created] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled

[jira] [Updated] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #101: SLING-11715 in the optimized code path avoid resource resolution

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #101: SLING-11715 in the optimized code path avoid resource resolution

7 matches

Site Navigation

Mail list logo

Footer information