[jira] [Updated] (SLING-12186) Automatic code formatting with spotless-maven-plugin

2023-12-08 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-12186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-12186:

Description: 
As discussed in 
https://lists.apache.org/thread/t32o425mttoftfr622wkvp4s5br4wzt1 we should 
introduce 
[spotless-maven-plugin|https://github.com/diffplug/spotless/tree/main/plugin-maven]
 to enforce a common code formatting similar to what was done for Maven in 
https://issues.apache.org/jira/browse/MPOM-349.

With each reformatting a {{.git-blame-ignore-revs}} should be added/enriched 
which is considered by git blame in GitHub 
(https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view)
 and optionally with Git CLI 
(https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt).
 

I propose to reuse the following configuration files from Apache Maven Shared 
Resources
* 
https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/maven-eclipse-importorder.txt
* 
https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/maven-header-plain.txt

  was:
As discussed in 
https://lists.apache.org/thread/t32o425mttoftfr622wkvp4s5br4wzt1 we should 
introduce 
[spotless-maven-plugin|https://github.com/diffplug/spotless/tree/main/plugin-maven]
 to enforce a common code formatting similar to what was done for Maven in 
https://issues.apache.org/jira/browse/MPOM-349.

With each reformatting a {{.git-blame-ignore-revs}} should be added/enriched 
which is considered by git blame in GitHub 
(https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view)
 and optionally with Git CLI 
(https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt).
 


> Automatic code formatting with spotless-maven-plugin
> 
>
> Key: SLING-12186
> URL: https://issues.apache.org/jira/browse/SLING-12186
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> As discussed in 
> https://lists.apache.org/thread/t32o425mttoftfr622wkvp4s5br4wzt1 we should 
> introduce 
> [spotless-maven-plugin|https://github.com/diffplug/spotless/tree/main/plugin-maven]
>  to enforce a common code formatting similar to what was done for Maven in 
> https://issues.apache.org/jira/browse/MPOM-349.
> With each reformatting a {{.git-blame-ignore-revs}} should be added/enriched 
> which is considered by git blame in GitHub 
> (https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view)
>  and optionally with Git CLI 
> (https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt).
>  
> I propose to reuse the following configuration files from Apache Maven Shared 
> Resources
> * 
> https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/maven-eclipse-importorder.txt
> * 
> https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/maven-header-plain.txt



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Introduce spotless-maven-plugin

2023-12-08 Thread Konrad Windszus 
I created https://issues.apache.org/jira/browse/SLING-12186 to track this and 
linked two feature branches where this has been tried out.
Please have a look there.

@Julian: checking happens in phase “process-sources” 
(https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#Lifecycle_Reference)
 which is pretty early.

Konrad

> On 7. Dec 2023, at 12:40, Stefan Seifert  
> wrote:
> 
> 
>> Sure, any candidate(s) you have in mind? Then I can prepare a PR with the
>> proposed changes.
>> Konrad
> 
> e.g. models-api and models-impl
> 
> we have to keep in mind that once we apply one-time reformatting of the code 
> base, all open PRs might be in conflict and will only be mergeable with 
> manual work.
> 
> stefan
>

[jira] [Assigned] (SLING-12186) Automatic code formatting with spotless-maven-plugin

2023-12-08 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-12186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-12186:
---

Assignee: Konrad Windszus

> Automatic code formatting with spotless-maven-plugin
> 
>
> Key: SLING-12186
> URL: https://issues.apache.org/jira/browse/SLING-12186
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> As discussed in 
> https://lists.apache.org/thread/t32o425mttoftfr622wkvp4s5br4wzt1 we should 
> introduce 
> [spotless-maven-plugin|https://github.com/diffplug/spotless/tree/main/plugin-maven]
>  to enforce a common code formatting similar to what was done for Maven in 
> https://issues.apache.org/jira/browse/MPOM-349.
> With each reformatting a {{.git-blame-ignore-revs}} should be added/enriched 
> which is considered by git blame in GitHub 
> (https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view)
>  and optionally with Git CLI 
> (https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt).
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12186) Automatic code formatting with spotless-maven-plugin

2023-12-08 Thread Konrad Windszus (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-12186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794776#comment-17794776
 ] 

Konrad Windszus commented on SLING-12186:
-

There are two PoC branches where proposed formatting rules have been applied:

# https://github.com/apache/sling-org-apache-sling-models-api/pull/11
# https://github.com/apache/sling-org-apache-sling-models-impl/pull/48

> Automatic code formatting with spotless-maven-plugin
> 
>
> Key: SLING-12186
> URL: https://issues.apache.org/jira/browse/SLING-12186
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Konrad Windszus
>Priority: Major
>
> As discussed in 
> https://lists.apache.org/thread/t32o425mttoftfr622wkvp4s5br4wzt1 we should 
> introduce 
> [spotless-maven-plugin|https://github.com/diffplug/spotless/tree/main/plugin-maven]
>  to enforce a common code formatting similar to what was done for Maven in 
> https://issues.apache.org/jira/browse/MPOM-349.
> With each reformatting a {{.git-blame-ignore-revs}} should be added/enriched 
> which is considered by git blame in GitHub 
> (https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view)
>  and optionally with Git CLI 
> (https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt).
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] SLING-12186 PoC for spotless-maven-plugin [sling-org-apache-sling-models-impl]

2023-12-08 Thread via GitHub 


kwin commented on PR #48:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/48#issuecomment-1847393666

   @stefanseifert The license headers were already mostly correct here (i.e. 
were not touched by spotless)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] SLING-12186 PoC for spotless-maven-plugin [sling-org-apache-sling-models-impl]

2023-12-08 Thread via GitHub 


kwin opened a new pull request, #48:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/48

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Enable spotless-maven-plugin with palantir and pom plugin [sling-org-apache-sling-models-api]

2023-12-08 Thread via GitHub 


kwin commented on PR #11:
URL: 
https://github.com/apache/sling-org-apache-sling-models-api/pull/11#issuecomment-1847373644

   The license header is automatically inserted/adjusted according to the 
configuration of 
https://github.com/diffplug/spotless/blob/main/plugin-maven/src/main/java/com/diffplug/spotless/maven/generic/LicenseHeader.java.
 In this case it is coming from a Maven Jar. I don't think that is an issue (we 
should really make sure the license header is exactly(!) the same). Ours has 
actually some typo in it `The ASF licenses this file to You` vs `The ASF 
licenses this file to you` but we can obviously come up with our own resource 
providing the Sling ASF license header but according to 
https://www.apache.org/legal/src-headers.html#headers it needs to be as 
corrected by spotless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling Provider Type Checker Bnd Plugin 1.0.0

2023-12-08 Thread Konrad Windszus 
I need at least one more binding vote. Anyone?
Thanks,
Konrad

> On 6. Dec 2023, at 11:55, Stefan Seifert  
> wrote:
> 
> +1
> 
> stefan

[jira] [Commented] (SLING-12194) Cycle between scripting services

2023-12-08 Thread Carsten Ziegeler (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794770#comment-17794770
 ] 

Carsten Ziegeler commented on SLING-12194:
--

Fix configuration handling 
https://github.com/apache/sling-org-apache-sling-scripting-core/commit/6be8493b45aad7c771ce3f00e5606239e76af948

> Cycle between scripting services
> 
>
> Key: SLING-12194
> URL: https://issues.apache.org/jira/browse/SLING-12194
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.4.8
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Scripting Core 2.4.10
>
>
> There can be an activation cycle between the SlingScriptEngineManager , the 
> ScriptEngines and the ScriptCache if a ScriptEngine (e.g. Sightly) requires 
> the ScriptCache. The ScriptCache also requires the SlingScriptEngineManager  
> which then completes the cycle



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12194) Cycle between scripting services

2023-12-08 Thread Carsten Ziegeler (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-12194.
--
  Assignee: Carsten Ziegeler
Resolution: Fixed

I broke the cycle by moving the event based invalidation to a separate 
component and bending slightly the contract of the removeScript method of the 
cache (now able to take a prefix path)
https://github.com/apache/sling-org-apache-sling-scripting-core/commit/3249d3989bd0ca7f7dc5552d4ce6f4853c577425


> Cycle between scripting services
> 
>
> Key: SLING-12194
> URL: https://issues.apache.org/jira/browse/SLING-12194
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.4.8
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Scripting Core 2.4.10
>
>
> There can be an activation cycle between the SlingScriptEngineManager , the 
> ScriptEngines and the ScriptCache if a ScriptEngine (e.g. Sightly) requires 
> the ScriptCache. The ScriptCache also requires the SlingScriptEngineManager  
> which then completes the cycle



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12194) Cycle between scripting services

2023-12-08 Thread Carsten Ziegeler (Jira) 
Carsten Ziegeler created SLING-12194:


 Summary: Cycle between scripting services
 Key: SLING-12194
 URL: https://issues.apache.org/jira/browse/SLING-12194
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting Core 2.4.8
Reporter: Carsten Ziegeler
 Fix For: Scripting Core 2.4.10


There can be an activation cycle between the SlingScriptEngineManager , the 
ScriptEngines and the ScriptCache if a ScriptEngine (e.g. Sightly) requires the 
ScriptCache. The ScriptCache also requires the SlingScriptEngineManager  which 
then completes the cycle



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12193) Potential concurrency issue in ScriptCacheImpl

2023-12-08 Thread Carsten Ziegeler (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-12193.
--
Resolution: Fixed

Fixed in 
https://github.com/apache/sling-org-apache-sling-scripting-core/commit/d38ba1d5ae99d5182a88bb89d5afec4b91944bb2
In addition, the ResourceChangeListener service registration is only updated, 
if something changes

> Potential concurrency issue in ScriptCacheImpl
> --
>
> Key: SLING-12193
> URL: https://issues.apache.org/jira/browse/SLING-12193
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.4.8
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Scripting Core 2.4.10
>
>
> The field extensions is read in a write lock but might be modified in 
> handleEvent() without any synchronization



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] Enable spotless-maven-plugin with palantir and pom plugin [sling-org-apache-sling-models-api]

2023-12-08 Thread via GitHub 


stefanseifert commented on PR #11:
URL: 
https://github.com/apache/sling-org-apache-sling-models-api/pull/11#issuecomment-1847189563

   i had a look on the actual code formatting changes - it looks quite good in 
general.
   
   one remark: all apache license headers are reformatted - i assume due to 
comment line length. can we reconfigure so they are not reformatted? they are 
usually copied/automatically inserted anway in the previous form.
   
   looking forward to see the result on some real code (models impl)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (SLING-12193) Potential concurrency issue in ScriptCacheImpl

2023-12-08 Thread Carsten Ziegeler (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-12193:


Assignee: Carsten Ziegeler

> Potential concurrency issue in ScriptCacheImpl
> --
>
> Key: SLING-12193
> URL: https://issues.apache.org/jira/browse/SLING-12193
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.4.8
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Scripting Core 2.4.10
>
>
> The field extensions is read in a write lock but might be modified in 
> handleEvent() without any synchronization



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12193) Potential concurrency issue in ScriptCacheImpl

2023-12-08 Thread Carsten Ziegeler (Jira) 
Carsten Ziegeler created SLING-12193:


 Summary: Potential concurrency issue in ScriptCacheImpl
 Key: SLING-12193
 URL: https://issues.apache.org/jira/browse/SLING-12193
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting Core 2.4.8
Reporter: Carsten Ziegeler
 Fix For: Scripting Core 2.4.10


The field extensions is read in a write lock but might be modified in 
handleEvent() without any synchronization



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12192) caconfig-mock-plugin: Fix nested config path building when writing config with custom persistence strategies

2023-12-08 Thread Stefan Seifert (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-12192.

Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/commit/ee86a7f1c858af337b06b086473462ea9b283b7d

> caconfig-mock-plugin: Fix nested config path building when writing config 
> with custom persistence strategies
> 
>
> Key: SLING-12192
> URL: https://issues.apache.org/jira/browse/SLING-12192
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: Context-Aware Configuration Mock Plugin 1.5.2
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Context-Aware Configuration Mock Plugin 1.5.4
>
>
> as reported in https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/25 
> there is currently an issue when custom persistence strategies are in place: 
> nested configurations may be written in invalid paths, resulting in not found 
> when reading the configuration again.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] SLING-12192 Fix nested config path building when writing config with custom persistence strategies [sling-org-apache-sling-testing-caconfig-mock-plugin]

2023-12-08 Thread via GitHub 


stefanseifert merged PR #5:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/pull/5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12192 Fix nested config path building when writing config with custom persistence strategies [sling-org-apache-sling-testing-caconfig-mock-plugin]

2023-12-08 Thread via GitHub 


sonarcloud[bot] commented on PR #5:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/pull/5#issuecomment-1847154966

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=false=CODE_SMELL)
   
   
[![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png
 
'100.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=new_coverage=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-caconfig-mock-plugin=5=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] SLING-12192 Fix nested config path building when writing config with custom persistence strategies [sling-org-apache-sling-testing-caconfig-mock-plugin]

2023-12-08 Thread via GitHub 


stefanseifert opened a new pull request, #5:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/pull/5

   https://issues.apache.org/jira/browse/SLING-12192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-12192) caconfig-mock-plugin: Fix nested config path building when writing config with custom persistence strategies

2023-12-08 Thread Stefan Seifert (Jira) 
Stefan Seifert created SLING-12192:
--

 Summary: caconfig-mock-plugin: Fix nested config path building 
when writing config with custom persistence strategies
 Key: SLING-12192
 URL: https://issues.apache.org/jira/browse/SLING-12192
 Project: Sling
  Issue Type: Bug
  Components: Testing
Affects Versions: Context-Aware Configuration Mock Plugin 1.5.2
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Context-Aware Configuration Mock Plugin 1.5.4


as reported in https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/25 
there is currently an issue when custom persistence strategies are in place: 
nested configurations may be written in invalid paths, resulting in not found 
when reading the configuration again.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1169 is FIXED

2023-12-08 Thread Apache Jenkins Server 
Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1169/
 for details.

No further emails will be sent until the status of the build is changed.

[jira] [Resolved] (SLING-12191) caconfig-mock-plugin: Update to Parent 52

2023-12-08 Thread Stefan Seifert (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-12191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-12191.

Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/commit/5d9af75ba47cb35c9e201ebcf1575df9e3de8116

> caconfig-mock-plugin: Update to Parent 52
> -
>
> Key: SLING-12191
> URL: https://issues.apache.org/jira/browse/SLING-12191
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Context-Aware Configuration Mock Plugin 1.5.2
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
> Fix For: Context-Aware Configuration Mock Plugin 1.5.4
>
>
> update to latest parent



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12191) caconfig-mock-plugin: Update to Parent 52

2023-12-08 Thread Stefan Seifert (Jira) 
Stefan Seifert created SLING-12191:
--

 Summary: caconfig-mock-plugin: Update to Parent 52
 Key: SLING-12191
 URL: https://issues.apache.org/jira/browse/SLING-12191
 Project: Sling
  Issue Type: Improvement
  Components: Testing
Affects Versions: Context-Aware Configuration Mock Plugin 1.5.2
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Context-Aware Configuration Mock Plugin 1.5.4


update to latest parent



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12186) Automatic code formatting with spotless-maven-plugin

2023-12-08 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-12186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-12186:

Description: 
As discussed in 
https://lists.apache.org/thread/t32o425mttoftfr622wkvp4s5br4wzt1 we should 
introduce 
[spotless-maven-plugin|https://github.com/diffplug/spotless/tree/main/plugin-maven]
 to enforce a common code formatting similar to what was done for Maven in 
https://issues.apache.org/jira/browse/MPOM-349.

With each reformatting a {{.git-blame-ignore-revs}} should be added/enriched 
which is considered by git blame in GitHub 
(https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view)
 and optionally with Git CLI 
(https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt).
 

  was:
As discussed in 
https://lists.apache.org/thread/t32o425mttoftfr622wkvp4s5br4wzt1 we should 
introduce 
[spotless-maven-plugin|https://github.com/diffplug/spotless/tree/main/plugin-maven]
 to enforce a common code formatting similar to what was done for Maven in 
https://issues.apache.org/jira/browse/MPOM-349.

With each reformatting a {{.git-blame-ignore-revs}} should be added/enriched 
which is considered by git blame in GitHub 
(https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#bypassing-git-blame-ignore-revs-in-the-blame-view)
 and optionally with Git CLI 
(https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt).
 


> Automatic code formatting with spotless-maven-plugin
> 
>
> Key: SLING-12186
> URL: https://issues.apache.org/jira/browse/SLING-12186
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Konrad Windszus
>Priority: Major
>
> As discussed in 
> https://lists.apache.org/thread/t32o425mttoftfr622wkvp4s5br4wzt1 we should 
> introduce 
> [spotless-maven-plugin|https://github.com/diffplug/spotless/tree/main/plugin-maven]
>  to enforce a common code formatting similar to what was done for Maven in 
> https://issues.apache.org/jira/browse/MPOM-349.
> With each reformatting a {{.git-blame-ignore-revs}} should be added/enriched 
> which is considered by git blame in GitHub 
> (https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view)
>  and optionally with Git CLI 
> (https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt).
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)