Re: [PR] [SECURITY] Fix Temporary File Information Disclosure Vulnerability [sling-org-apache-sling-feature-analyser]
cziegeler commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/41#issuecomment-1867297489 The code is in a junit test, no disclosure required -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SECURITY] Fix Temporary File Information Disclosure Vulnerability [sling-org-apache-sling-feature-analyser]
cziegeler merged PR #41: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-12210) Remove unused startLevel from BundleDescriptorImpl
[ https://issues.apache.org/jira/browse/SLING-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12210. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-feature-analyser/commit/04cc3ce2407ed73b8be9d3f5cc0af1ffcf80d4c0 > Remove unused startLevel from BundleDescriptorImpl > -- > > Key: SLING-12210 > URL: https://issues.apache.org/jira/browse/SLING-12210 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12210) Remove unused startLevel from BundleDescriptorImpl
Carsten Ziegeler created SLING-12210: Summary: Remove unused startLevel from BundleDescriptorImpl Key: SLING-12210 URL: https://issues.apache.org/jira/browse/SLING-12210 Project: Sling Issue Type: Improvement Components: Feature Model Analyser Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Feature Model Analyser 2.0.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]
enapps-enorman commented on code in PR #109:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#discussion_r1434736024
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1154,7 +1152,7 @@ private Map>>
loadAliases(final ResourceR
log.debug("start alias query: {}", queryString);
long queryStart = System.nanoTime();
-final Iterator i = resolver.findResources(queryString,
"sql");
+final Iterator i = resolver.findResources(queryString,
"JCR-SQL2");
Review Comment:
> The java compiler will inline string references in the resulting class
file anyway.
Yes, this is true. I prefer using the Query.JCR_SQL2 constant just in case
that language gets deprecated someday (like what happened for the "xpath" and
"sql" languages) so that your IDE will warn you about usage of deprecated code
in that scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Various improvements for the webconsole plugin [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #78: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/78#issuecomment-1866841628 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78) **Quality Gate failed** Failed conditions [2.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11352 - Fix parsing of path-only mappings [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #84: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-1866841184 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&resolved=false&inNewCodePeriod=true) [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&metric=new_coverage&view=list) [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SECURITY] Fix Temporary File Information Disclosure Vulnerability [sling-org-apache-sling-feature-analyser]
sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/41#issuecomment-1866830807 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser&pullRequest=41) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser&pullRequest=41&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-analyser&pullRequest=41&resolved=false&inNewCodePeriod=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser&pullRequest=41&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser&pullRequest=41) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12200: sling-org-apache-sling-graphql-core unnecessarily uses the shaded guava from graphql-java [sling-org-apache-sling-graphql-core]
sonarcloud[bot] commented on PR #40: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/40#issuecomment-1866574901 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core&pullRequest=40) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=40&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=40&resolved=false&inNewCodePeriod=true) [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=40&metric=new_coverage&view=list) [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=40&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core&pullRequest=40) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12200) sling-org-apache-sling-graphql-core unnecessarily uses the shaded guava from graphql-java
[ https://issues.apache.org/jira/browse/SLING-12200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated SLING-12200: --- Affects Version/s: GraphQL Core 0.0.26 > sling-org-apache-sling-graphql-core unnecessarily uses the shaded guava from > graphql-java > - > > Key: SLING-12200 > URL: https://issues.apache.org/jira/browse/SLING-12200 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Affects Versions: GraphQL Core 0.0.26 >Reporter: Manfred Baedke >Assignee: Julian Reschke >Priority: Trivial > > AFAIK shaded Guava is no longer part part of recent releases of graphql-java. > The only usage is > https://github.com/apache/sling-org-apache-sling-graphql-core/blob/30babad3caab0da0dc85bc0d645f76ca6784ef67/src/main/java/org/apache/sling/graphql/core/engine/SelectedFieldWrapper.java#L181, > which is trivial to replace with JavaSE. > cc [~reschke] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12200) sling-org-apache-sling-graphql-core unnecessarily uses the shaded guava from graphql-java
[ https://issues.apache.org/jira/browse/SLING-12200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke reassigned SLING-12200: -- Assignee: Julian Reschke > sling-org-apache-sling-graphql-core unnecessarily uses the shaded guava from > graphql-java > - > > Key: SLING-12200 > URL: https://issues.apache.org/jira/browse/SLING-12200 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Manfred Baedke >Assignee: Julian Reschke >Priority: Trivial > > AFAIK shaded Guava is no longer part part of recent releases of graphql-java. > The only usage is > https://github.com/apache/sling-org-apache-sling-graphql-core/blob/30babad3caab0da0dc85bc0d645f76ca6784ef67/src/main/java/org/apache/sling/graphql/core/engine/SelectedFieldWrapper.java#L181, > which is trivial to replace with JavaSE. > cc [~reschke] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] SLING-12200: sling-org-apache-sling-graphql-core unnecessarily uses the shaded guava from graphql-java [sling-org-apache-sling-graphql-core]
reschke opened a new pull request, #40: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/40 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling JCR Jackrabbit User Manager version 2.2.30
On Mon, 2023-12-18 at 18:58 -0800, Eric Norman wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
Re: [VOTE] Release Apache Sling Testing JCR Mock version 1.6.12
On Mon, 2023-12-18 at 11:50 -0800, Eric Norman wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
Re: [VOTE] Release Apache Sling Testing JCR Mock version 1.6.12
signature.asc Description: This is a digitally signed message part
[jira] [Created] (SLING-12209) Improve logging output
Carsten Ziegeler created SLING-12209: Summary: Improve logging output Key: SLING-12209 URL: https://issues.apache.org/jira/browse/SLING-12209 Project: Sling Issue Type: New Feature Components: Feature Model Analyser Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Feature Model Analyser 2.0.4 The logging output of the analyser could be improved, e.g. by adding the full time it took to analyse as well as providing an option to surpress task info output. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]
rombert commented on code in PR #109:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#discussion_r1434028256
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1154,7 +1152,7 @@ private Map>>
loadAliases(final ResourceR
log.debug("start alias query: {}", queryString);
long queryStart = System.nanoTime();
-final Iterator i = resolver.findResources(queryString,
"sql");
+final Iterator i = resolver.findResources(queryString,
"JCR-SQL2");
Review Comment:
We already optionally import `javax.jcr`, so I don't see what the issue
would be with referencing the constant value.
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/c7bdc4d6a5e360623b0ad3c117f1728e26c12e8e/bnd.bnd#L2
The java compiler will inline string references in the resulting class file
anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-11799: ResourceResolver - use keyset pagination for sling:alias query [sling-org-apache-sling-resourceresolver]
rombert commented on code in PR #111:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#discussion_r1434026128
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1148,19 +1148,26 @@ private boolean addEntry(final Map> entryMap, final Strin
*/
private Map>> loadAliases(final
ResourceResolver resolver) {
final Map>> map = new
ConcurrentHashMap<>();
-final String queryString = generateAliasQuery();
+final String baseQueryString = generateAliasQuery();
-log.debug("start alias query: {}", queryString);
-long queryStart = System.nanoTime();
-final Iterator i = resolver.findResources(queryString,
"JCR-SQL2");
-long queryElapsed = System.nanoTime() - queryStart;
-log.debug("end alias query; elapsed {}ms",
TimeUnit.NANOSECONDS.toMillis(queryElapsed));
+Iterator it;
+try {
+final String queryStringWithSort = baseQueryString + " AND
FIRST([sling:alias]) > '%s' ORDER BY FIRST([sling:alias])";
+it = new PagedQueryIterator("alias", "sling:alias", resolver,
queryStringWithSort,
+Integer.getInteger("sling.alias.pageSize", 2000));
Review Comment:
When we should remove this, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-11799: ResourceResolver - use keyset pagination for sling:alias query [sling-org-apache-sling-resourceresolver]
reschke commented on code in PR #111:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#discussion_r1434015830
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1148,19 +1148,26 @@ private boolean addEntry(final Map> entryMap, final Strin
*/
private Map>> loadAliases(final
ResourceResolver resolver) {
final Map>> map = new
ConcurrentHashMap<>();
-final String queryString = generateAliasQuery();
+final String baseQueryString = generateAliasQuery();
-log.debug("start alias query: {}", queryString);
-long queryStart = System.nanoTime();
-final Iterator i = resolver.findResources(queryString,
"JCR-SQL2");
-long queryElapsed = System.nanoTime() - queryStart;
-log.debug("end alias query; elapsed {}ms",
TimeUnit.NANOSECONDS.toMillis(queryElapsed));
+Iterator it;
+try {
+final String queryStringWithSort = baseQueryString + " AND
FIRST([sling:alias]) > '%s' ORDER BY FIRST([sling:alias])";
+it = new PagedQueryIterator("alias", "sling:alias", resolver,
queryStringWithSort,
+Integer.getInteger("sling.alias.pageSize", 2000));
Review Comment:
The system property was added to ease debugging and performance testing, not
to be set in practice.
I seriously doubt that adding more OSGi toggles would be helpful, but if we
did this, we should do it consistently (and maybe dissuss whether alias and
vanity path need different ones).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-11799: ResourceResolver - use keyset pagination for sling:alias query [sling-org-apache-sling-resourceresolver]
rombert commented on code in PR #111:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#discussion_r1434012781
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1148,19 +1148,26 @@ private boolean addEntry(final Map> entryMap, final Strin
*/
private Map>> loadAliases(final
ResourceResolver resolver) {
final Map>> map = new
ConcurrentHashMap<>();
-final String queryString = generateAliasQuery();
+final String baseQueryString = generateAliasQuery();
-log.debug("start alias query: {}", queryString);
-long queryStart = System.nanoTime();
-final Iterator i = resolver.findResources(queryString,
"JCR-SQL2");
-long queryElapsed = System.nanoTime() - queryStart;
-log.debug("end alias query; elapsed {}ms",
TimeUnit.NANOSECONDS.toMillis(queryElapsed));
+Iterator it;
+try {
+final String queryStringWithSort = baseQueryString + " AND
FIRST([sling:alias]) > '%s' ORDER BY FIRST([sling:alias])";
+it = new PagedQueryIterator("alias", "sling:alias", resolver,
queryStringWithSort,
+Integer.getInteger("sling.alias.pageSize", 2000));
Review Comment:
This should come as an OSGi config, not as a system property. OSGi
configuration properties can then be picked up from environment variables if
desired, see
https://github.com/apache/felix-dev/blob/master/configadmin-plugins/interpolation/README.md#interpolating-environment-variables
.
The OSGi config should have that default of 2000 set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-11799: ResourceResolver - use keyset pagination for sling:alias query [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #111: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#issuecomment-1866158129 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=111) **Quality Gate failed** Failed conditions [78.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=111&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=111) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-11799: ResourceResolver - use keyset pagination for sling:alias query [sling-org-apache-sling-resourceresolver]
reschke opened a new pull request, #111: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111 Changes query strategy for sling:alias to the same as sling:vanityPath. Fallbacks allow deploying on older store versions or on stores that require an index on "first(sling:alias)". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11799: ResourceResolver - use keyset pagination for sling:alias query [sling-org-apache-sling-resourceresolver]
reschke closed pull request #110: SLING-11799: ResourceResolver - use keyset pagination for sling:alias query URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-11799: ResourceResolver - use keyset pagination for sling:alias query [sling-org-apache-sling-resourceresolver]
reschke opened a new pull request, #110: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/110 Changes query strategy for sling:alias to the same as sling:vanityPath. Fallbacks allow deploying on older store versions or on stores that require an index on "first(sling:alias)". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-12208) sling/jcr/osgi/resourceresolver-mock: Update Dependencies to 2023
[ https://issues.apache.org/jira/browse/SLING-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-12208. Resolution: Fixed * [https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/commit/c9cf4bc35580394dcd2327cc25a3baf479647de3] * [https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/commit/2ff8736b466ef13c449adb0bb3df125cd9430e63] * [https://github.com/apache/sling-org-apache-sling-testing-resourceresolver-mock/commit/34db5a5a8ad48adb7e041a135af6cc239cd65fe6] * [https://github.com/apache/sling-org-apache-sling-testing-sling-mock/commit/39a864df8893025de7db92cc55528d0fd0fda160] * [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/83747eff96ad0804e5b772257edeb010317a8841] > sling/jcr/osgi/resourceresolver-mock: Update Dependencies to 2023 > - > > Key: SLING-12208 > URL: https://issues.apache.org/jira/browse/SLING-12208 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing Sling Mock Oak 3.1.12-1.44.0, Testing > ResourceResolver Mock 1.4.6, Testing OSGi Mock 3.4.2, Testing Sling Mock > 3.4.18, Testing JCR Mock 1.6.14 > > > every 1-2 years we update the dependencies of sling-mock and related mock > modules to a new "baseline" of dependencies. as sling-mock is used in a lot > of user projects with very different context (applications, deployment > target) we try to be as backwards-compatible as possible but dropping out > older versions from time to time. > the baseline we target for this ticket is: > [https://repo1.maven.org/maven2/io/wcm/maven/io.wcm.maven.aem-dependencies/6.5.17.0001/io.wcm.maven.aem-dependencies-6.5.17.0001.pom] > several dependencies from this POM esp. from Sling and Oak are not the latest > version from mid 2023, but it's a consistent baseline that is still used in a > lot of projects. > the goal is to stick to this baseline for the next 1-2 years and only deviate > from it with a good reason. such a reason might be security warnings in > artifact scanners - but only if it deviates not too much or in a potential > risky way from this baseline. > the goal is that all mock code that is written sticks to this baseline. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-sling-mock-oak]
stefanseifert merged PR #10: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-sling-mock-oak]
sonarcloud[bot] commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/10#issuecomment-1866110709 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock-oak&pullRequest=10) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak&pullRequest=10&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak&pullRequest=10&resolved=false&inNewCodePeriod=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak&pullRequest=10&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock-oak&pullRequest=10) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-sling-mock-oak]
sonarcloud[bot] commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/10#issuecomment-1866102182 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock-oak&pullRequest=10) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak&pullRequest=10&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak&pullRequest=10&resolved=false&inNewCodePeriod=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak&pullRequest=10&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock-oak&pullRequest=10) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-sling-mock-oak]
stefanseifert opened a new pull request, #10: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/10 see https://issues.apache.org/jira/browse/SLING-12208 for details -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-sling-mock]
stefanseifert merged PR #36: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-sling-mock]
sonarcloud[bot] commented on PR #36: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/36#issuecomment-1866089635 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock&pullRequest=36) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock&pullRequest=36&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock&pullRequest=36&resolved=false&inNewCodePeriod=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock&pullRequest=36&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock&pullRequest=36) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-sling-mock]
stefanseifert opened a new pull request, #36: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/36 see https://issues.apache.org/jira/browse/SLING-12208 for details -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-osgi-mock]
stefanseifert merged PR #39: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-osgi-mock]
sonarcloud[bot] commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/39#issuecomment-1866065388 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=39) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=39&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=39&resolved=false&inNewCodePeriod=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=39&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=39) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-resourceresolver-mock]
stefanseifert merged PR #14: URL: https://github.com/apache/sling-org-apache-sling-testing-resourceresolver-mock/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-jcr-mock]
stefanseifert merged PR #34: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-resourceresolver-mock]
sonarcloud[bot] commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-testing-resourceresolver-mock/pull/14#issuecomment-1866058961 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-resourceresolver-mock&pullRequest=14) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-resourceresolver-mock&pullRequest=14&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-resourceresolver-mock&pullRequest=14&resolved=false&inNewCodePeriod=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-resourceresolver-mock&pullRequest=14&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-resourceresolver-mock&pullRequest=14) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-resourceresolver-mock]
stefanseifert opened a new pull request, #14: URL: https://github.com/apache/sling-org-apache-sling-testing-resourceresolver-mock/pull/14 see https://issues.apache.org/jira/browse/SLING-12208 for details -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-jcr-mock]
sonarcloud[bot] commented on PR #34: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/34#issuecomment-1866050634 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=34) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=34&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=34&resolved=false&inNewCodePeriod=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=34&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=34) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-osgi-mock]
stefanseifert opened a new pull request, #39: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/39 see https://issues.apache.org/jira/browse/SLING-12208 for details -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12208 Update Dependencies to 2023 [sling-org-apache-sling-testing-jcr-mock]
stefanseifert opened a new pull request, #34: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/34 see https://issues.apache.org/jira/browse/SLING-12208 for details -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12208) sling/jcr/osgi/resourceresolver-mock: Update Dependencies to 2023
Stefan Seifert created SLING-12208: -- Summary: sling/jcr/osgi/resourceresolver-mock: Update Dependencies to 2023 Key: SLING-12208 URL: https://issues.apache.org/jira/browse/SLING-12208 Project: Sling Issue Type: Improvement Components: Testing Reporter: Stefan Seifert Assignee: Stefan Seifert Fix For: Testing Sling Mock Oak 3.1.12-1.44.0, Testing ResourceResolver Mock 1.4.6, Testing OSGi Mock 3.4.2, Testing Sling Mock 3.4.18, Testing JCR Mock 1.6.14 every 1-2 years we update the dependencies of sling-mock and related mock modules to a new "baseline" of dependencies. as sling-mock is used in a lot of user projects with very different context (applications, deployment target) we try to be as backwards-compatible as possible but dropping out older versions from time to time. the baseline we target for this ticket is: [https://repo1.maven.org/maven2/io/wcm/maven/io.wcm.maven.aem-dependencies/6.5.17.0001/io.wcm.maven.aem-dependencies-6.5.17.0001.pom] several dependencies from this POM esp. from Sling and Oak are not the latest version from mid 2023, but it's a consistent baseline that is still used in a lot of projects. the goal is to stick to this baseline for the next 1-2 years and only deviate from it with a good reason. such a reason might be security warnings in artifact scanners - but only if it deviates not too much or in a potential risky way from this baseline. the goal is that all mock code that is written sticks to this baseline. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12207) Use adjusted inheritance rules for URLs
[
https://issues.apache.org/jira/browse/SLING-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12207:
Fix Version/s: Parent 60 (Java 11)
> Use adjusted inheritance rules for URLs
> ---
>
> Key: SLING-12207
> URL: https://issues.apache.org/jira/browse/SLING-12207
> Project: Sling
> Issue Type: Bug
> Components: General
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Parent 60 (Java 11)
>
>
> For Sling projects the default inheritance rules for URLs are not applicable:
> https://maven.apache.org/ref/3.8.4/maven-model-builder/index.html#Inheritance_Assembly.
> Therefore the dedicated attribute {{@child.project.url.inherit.append.path}}
> should be set to {{false}} (requires Maven 3.6.1 or newer,
> https://issues.apache.org/jira/browse/MNG-6059).
> Also the SCM element and children should be moved to the profile only active
> when the parent pom is built (as they are never applicable as is to derived
> modules).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12207) Use adjusted inheritance rules for URLs
Konrad Windszus created SLING-12207:
---
Summary: Use adjusted inheritance rules for URLs
Key: SLING-12207
URL: https://issues.apache.org/jira/browse/SLING-12207
Project: Sling
Issue Type: Bug
Components: General
Reporter: Konrad Windszus
For Sling projects the default inheritance rules for URLs are not applicable:
https://maven.apache.org/ref/3.8.4/maven-model-builder/index.html#Inheritance_Assembly.
Therefore the dedicated attribute {{@child.project.url.inherit.append.path}}
should be set to {{false}} (requires Maven 3.6.1 or newer,
https://issues.apache.org/jira/browse/MNG-6059).
Also the SCM element and children should be moved to the profile only active
when the parent pom is built (as they are never applicable as is to derived
modules).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12206) Support WAR deployment within servlet 5 container
Carsten Ziegeler created SLING-12206: Summary: Support WAR deployment within servlet 5 container Key: SLING-12206 URL: https://issues.apache.org/jira/browse/SLING-12206 Project: Sling Issue Type: New Feature Components: Launchpad Reporter: Carsten Ziegeler The WAR file created by the launchpad only supports Servlet 3 (javax.servlet). We should update the support to be able to run within Servlet 5 (jakarta.servlet) application servers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]
enapps-enorman commented on code in PR #109:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#discussion_r1433717742
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1154,7 +1152,7 @@ private Map>>
loadAliases(final ResourceR
log.debug("start alias query: {}", queryString);
long queryStart = System.nanoTime();
-final Iterator i = resolver.findResources(queryString,
"sql");
+final Iterator i = resolver.findResources(queryString,
"JCR-SQL2");
Review Comment:
Pretty weak that you just merging immediately without giving me a chance to
respond. You are already using a JCR specific language there so pretending
that a different backend would support that language somehow seems unlikely to
me. Using a string doesn't magically make it more portable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (SLING-12205) ResourceResolver: switch sling:alias query to JCR-SQL2
[ https://issues.apache.org/jira/browse/SLING-12205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved SLING-12205. Fix Version/s: Resource Resolver 1.11.6 Resolution: Fixed > ResourceResolver: switch sling:alias query to JCR-SQL2 > -- > > Key: SLING-12205 > URL: https://issues.apache.org/jira/browse/SLING-12205 > Project: Sling > Issue Type: Task > Components: ResourceResolver >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Fix For: Resource Resolver 1.11.6 > > > (needed to be able tp use paging later on) -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]
reschke commented on code in PR #109:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#discussion_r1433692557
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1154,7 +1152,7 @@ private Map>>
loadAliases(final ResourceR
log.debug("start alias query: {}", queryString);
long queryStart = System.nanoTime();
-final Iterator i = resolver.findResources(queryString,
"sql");
+final Iterator i = resolver.findResources(queryString,
"JCR-SQL2");
Review Comment:
Not convinced. We currently do not use javax.jcr imports; likely because
Sling in theory supports other backends.
I personally do not buy this argument, but if we go down that road, there's
a lot more we could / should change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]
reschke merged PR #109: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
