[jira] [Resolved] (SLING-12219) ResourceUtil.normalize does not handle segments with multiple dots correctly
[ https://issues.apache.org/jira/browse/SLING-12219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12219. -- Resolution: Fixed Rewrote the method in https://github.com/apache/sling-org-apache-sling-api/commit/13ef4835f031a4fe5115433a42fa967f8fe560b3 for better readability. Adjusted test cases with more than two dots and added additional ones (which fail with the old implementation) > ResourceUtil.normalize does not handle segments with multiple dots correctly > > > Key: SLING-12219 > URL: https://issues.apache.org/jira/browse/SLING-12219 > Project: Sling > Issue Type: Bug > Components: API >Affects Versions: API 2.27.2 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: API 2.27.4 > > > If a path segment contains more than two dots but anything else, then > ResourceUtil.normalize does not handle these correctly. It should just return > null. Instead in some cases it is leaving the segment untouched or shortens > it for example from four dots to two dots. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12219) ResourceUtil.normalize does not handle segments with multiple dots correctly
Carsten Ziegeler created SLING-12219: Summary: ResourceUtil.normalize does not handle segments with multiple dots correctly Key: SLING-12219 URL: https://issues.apache.org/jira/browse/SLING-12219 Project: Sling Issue Type: Bug Components: API Affects Versions: API 2.27.2 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: API 2.27.4 If a path segment contains more than two dots but anything else, then ResourceUtil.normalize does not handle these correctly. It should just return null. Instead in some cases it is leaving the segment untouched or shortens it for example from four dots to two dots. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-11458 - fixed a regresssion for the original Ticket SLING-9626 [sling-org-apache-sling-graphql-core]
sonarcloud[bot] commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1875798753 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core=29) **Quality Gate passed** The SonarCloud Quality Gate passed, but some issues were introduced. [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=29=false=true) [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=29=new_coverage=list) [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=29=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core=29) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.sling.engine from 2.7.10 to 2.14.0 [sling-org-apache-sling-graphql-core]
sonarcloud[bot] commented on PR #35: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/35#issuecomment-1875793740 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core=35) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=35=false=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=35=false=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=35=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core=35) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling GraphQL Core 0.0.28
+1 Carsten On 03.01.2024 17:30, Radu Cotescu wrote: Hi, We solved 2 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354026=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2826 You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2826 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Radu Cotescu -- Carsten Ziegeler Adobe cziege...@apache.org
[VOTE] Release Apache Sling GraphQL Core 0.0.28
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354026=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2826 You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2826 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Radu Cotescu
Re: [PR] SLING-12198 - Extending sling.graphql.engine to allow passing custom graphql ParserOptions. [sling-org-apache-sling-graphql-core]
raducotescu commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/39#issuecomment-1875554789 The change looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12218) Limit queue size
Christian Schneider created SLING-12218: --- Summary: Limit queue size Key: SLING-12218 URL: https://issues.apache.org/jira/browse/SLING-12218 Project: Sling Issue Type: Improvement Components: Content Distribution Reporter: Christian Schneider Assignee: Christian Schneider Fix For: Content Distribution Journal Core 0.3.0 Currently users can add an indefinite number of replications to the queue. This is problematic as the end to end latency increases with the queue size. So it makes sense to have a limit on the queue size. If the limit is reached we should: - Block for a certain time to wait for the queue size to become smaller - Fail after the timeout with an exception ( in case of http call we could fail with 429 or 503) Metric for queue size limit reached. As the changed behaviour might break user code we should make the limiting behaviour opt in via a PublisherConfiguration. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12177) Status poller is created once per agent but should only be created once
[ https://issues.apache.org/jira/browse/SLING-12177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved SLING-12177. - Resolution: Fixed > Status poller is created once per agent but should only be created once > --- > > Key: SLING-12177 > URL: https://issues.apache.org/jira/browse/SLING-12177 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.3.0 > > > We are creating the status poller once per distribution agent: > [https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/0e38eb8dc91008f70c5ea64b4e1906afdc7dfda5/src/main/java/org/apache/sling/distribution/journal/impl/publisher/DistributionPublisher.java#L170] > This causes a lot of stress on the system as we also read the topic from > earliest. > So if we have 4 agents we read all status messages 4 times which can be > considerable data. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12213 update dependencies [sling-org-apache-sling-models-jacksonexporter]
kwin commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/11#discussion_r1440357188 ## pom.xml: ## @@ -112,19 +112,19 @@ com.fasterxml.jackson.core jackson-databind -2.3.2 +2.16.1 Review Comment: Why this version? Which CVEs are the older versions suffering from? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1207 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1207/ for details. No further emails will be sent until the status of the build is changed.
