Re: [PR] [SLING-11742] Provide alternative equitable terminology for properties [sling-org-apache-sling-resourceresolver]
cziegeler commented on PR #89: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89#issuecomment-1884294090 This has been implemented a while ago by #97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SLING-11742] Provide alternative equitable terminology for properties [sling-org-apache-sling-resourceresolver]
cziegeler closed pull request #89: [SLING-11742] Provide alternative equitable terminology for properties URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Various improvements for the webconsole plugin [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #78: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/78#issuecomment-1883680585 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78) **Quality Gate failed** Failed conditions [2.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11352 - Fix parsing of path-only mappings [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #84: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-1883678322 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&resolved=false&inNewCodePeriod=true) [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&metric=new_coverage&view=list) [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12207 Adjust url inheritance [sling-parent]
sonarcloud[bot] commented on PR #42: URL: https://github.com/apache/sling-parent/pull/42#issuecomment-1883655265 ## [](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=42) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=42&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent&pullRequest=42&resolved=false&inNewCodePeriod=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=42&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=42) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12222: INFO-level log not only query time but also # of resourcs (and rate) for sling:alias and sling:vanityPath [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #112: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/112#issuecomment-1883416066 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=112) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=112&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=112&resolved=false&inNewCodePeriod=true) [81.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=112&metric=new_coverage&view=list) [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=112&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=112) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12222: INFO-level log not only query time but also # of resourcs (and rate) for sling:alias and sling:vanityPath [sling-org-apache-sling-resourceresolver]
reschke opened a new pull request, #112: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/112 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.felix:org.apache.felix.webconsole to v5 [sling-org-apache-sling-starter]
rombert merged PR #293: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.felix:org.apache.felix.webconsole to v5 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #293: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/293 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.felix:org.apache.felix.webconsole](https://felix.apache.org/) ([source](https://gitbox.apache.org/repos/asf?p=felix-dev.git)) | `4.9.6` -> `5.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SLING-12225) resource resolver: revise documentation and naming of system properties for query paging
[ https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804679#comment-17804679 ] Carsten Ziegeler edited comment on SLING-12225 at 1/9/24 10:39 AM: --- Given that this is a helper for implementation, I think there are three options: * no configurability at all * make it configurable in a special branch via whatever mechanism is appropriate * make it configurable in the main branch, but ensure to remove it before a release I would prefer one of the first two. And I agree we should use the same approach for both. was (Author: cziegeler): Given that this is a helper for implementation, I think there are three options: * no configurability at all * make it configurable in a special branch via whatever mechanism is appropriate * make it configurable in the main branch, but ensure to remove it before a release I would prefer one of the first two. And I agree we should use the same approach for both. > resource resolver: revise documentation and naming of system properties for > query paging > > > Key: SLING-12225 > URL: https://issues.apache.org/jira/browse/SLING-12225 > Project: Sling > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > > See > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12225) resource resolver: revise documentation and naming of system properties for query paging
[ https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804679#comment-17804679 ] Carsten Ziegeler commented on SLING-12225: -- Given that this is a helper for implementation, I think there are three options: * no configurability at all * make it configurable in a special branch via whatever mechanism is appropriate * make it configurable in the main branch, but ensure to remove it before a release I would prefer one of the first two. And I agree we should use the same approach for both. > resource resolver: revise documentation and naming of system properties for > query paging > > > Key: SLING-12225 > URL: https://issues.apache.org/jira/browse/SLING-12225 > Project: Sling > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > > See > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12225) resource resolver: revise documentation and naming of system properties for query paging
[ https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804677#comment-17804677 ] Julian Reschke commented on SLING-12225: It was suggested by Thomas Müller while trying different page size values. I really do not care that much, but it's certainly easier to try different values without having to use a special build. In any case, the answer should be the same & consistent for both vanity paths and aliases. > resource resolver: revise documentation and naming of system properties for > query paging > > > Key: SLING-12225 > URL: https://issues.apache.org/jira/browse/SLING-12225 > Project: Sling > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > > See > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12225) resource resolver: revise documentation and naming of system properties for query paging
[ https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated SLING-12225: --- Summary: resource resolver: revise documentation and naming of system properties for query paging (was: resource resolver: revise document and naming of system properties for paging) > resource resolver: revise documentation and naming of system properties for > query paging > > > Key: SLING-12225 > URL: https://issues.apache.org/jira/browse/SLING-12225 > Project: Sling > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > > See > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11799) use keyset pagination for sling:alias query
[ https://issues.apache.org/jira/browse/SLING-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved SLING-11799. Fix Version/s: Resource Resolver 1.11.6 Resolution: Fixed > use keyset pagination for sling:alias query > --- > > Key: SLING-11799 > URL: https://issues.apache.org/jira/browse/SLING-11799 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Fix For: Resource Resolver 1.11.6 > > > Similar to what was done for vanity paths (SLING-11581), we should use keyset > pagination for queries for sling:alias. > This would work the same in principle, however we should keep in mind that - > due to the different type of data - we may have way more duplicates, so in > edge cases the pages might be bigger than expected. However, every size > reduction of "results of a single query" should help. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-11799: ResourceResolver - use keyset pagination for sling:alias query [sling-org-apache-sling-resourceresolver]
reschke merged PR #111: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12225) resource resolver: revise document and naming of system properties for paging
[ https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804642#comment-17804642 ] Carsten Ziegeler commented on SLING-12225: -- Reading that thread, I'm wondering why this is configurable to begin with? It seems that there is no intention to make this configurable for users. The only reason seems to be for "debugging" - but then who is debugging this? Apparently not users. Making this configurable for the implementor to find the right value doesn't sound right to me, at least not in the main branch. > resource resolver: revise document and naming of system properties for paging > - > > Key: SLING-12225 > URL: https://issues.apache.org/jira/browse/SLING-12225 > Project: Sling > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > > See > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12225) resource resolver: revise document and naming of system properties for paging
[ https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated SLING-12225: --- Description: See https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 > resource resolver: revise document and naming of system properties for paging > - > > Key: SLING-12225 > URL: https://issues.apache.org/jira/browse/SLING-12225 > Project: Sling > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > > See > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-11799: ResourceResolver - use keyset pagination for sling:alias query [sling-org-apache-sling-resourceresolver]
reschke commented on code in PR #111:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#discussion_r1445794252
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1148,19 +1148,26 @@ private boolean addEntry(final Map> entryMap, final Strin
*/
private Map>> loadAliases(final
ResourceResolver resolver) {
final Map>> map = new
ConcurrentHashMap<>();
-final String queryString = generateAliasQuery();
+final String baseQueryString = generateAliasQuery();
-log.debug("start alias query: {}", queryString);
-long queryStart = System.nanoTime();
-final Iterator i = resolver.findResources(queryString,
"JCR-SQL2");
-long queryElapsed = System.nanoTime() - queryStart;
-log.debug("end alias query; elapsed {}ms",
TimeUnit.NANOSECONDS.toMillis(queryElapsed));
+Iterator it;
+try {
+final String queryStringWithSort = baseQueryString + " AND
FIRST([sling:alias]) > '%s' ORDER BY FIRST([sling:alias])";
+it = new PagedQueryIterator("alias", "sling:alias", resolver,
queryStringWithSort,
+Integer.getInteger("sling.alias.pageSize", 2000));
Review Comment:
-> https://issues.apache.org/jira/browse/SLING-12225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (SLING-12225) resource resolver: revise document and naming of system properties for paging
Julian Reschke created SLING-12225: -- Summary: resource resolver: revise document and naming of system properties for paging Key: SLING-12225 URL: https://issues.apache.org/jira/browse/SLING-12225 Project: Sling Issue Type: Task Reporter: Julian Reschke Assignee: Julian Reschke -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12223) Incorrect values for OSGI properties (VaultDistributionPackageBuilderFactory)
[
https://issues.apache.org/jira/browse/SLING-12223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider resolved SLING-12223.
-
Resolution: Fixed
> Incorrect values for OSGI properties (VaultDistributionPackageBuilderFactory)
> -
>
> Key: SLING-12223
> URL: https://issues.apache.org/jira/browse/SLING-12223
> Project: Sling
> Issue Type: Task
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.5.0
>Reporter: Joerg Hoh
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Core 0.5.2
>
>
> When changing a OSGI value for an service instance of
> VaultDistributionPackageBuilderFactory via the OSGI webconsole, I came across
> this error:
> {noformat}
> 08.01.2024 14:57:00.773 *ERROR* [FelixLogListener]
> org.apache.sling.distribution.serialization.impl.vlt.VaultDistributionPackageBuilderFactory
> bundle org.apache.sling.distribution.core:0.5.0 (334)[or
> g.apache.sling.distribution.serialization.impl.vlt.VaultDistributionPackageBuilderFactory(1167)]
> : The activate method has thrown an exception
> (java.lang.IllegalArgumentException: No enum constant org.apache.sling.distrib
> ution.util.impl.FileBackedMemoryOutputStream.MemoryUnit.Bytes)
> java.lang.IllegalArgumentException: No enum constant
> org.apache.sling.distribution.util.impl.FileBackedMemoryOutputStream.MemoryUnit.Bytes
> at java.base/java.lang.Enum.valueOf(Enum.java:240)
> at
> org.apache.sling.distribution.util.impl.FileBackedMemoryOutputStream$MemoryUnit.valueOf(FileBackedMemoryOutputStream.java:41)
> [org.apache.sling.distribution.core:0.5.0]
> at
> org.apache.sling.distribution.serialization.impl.vlt.VaultDistributionPackageBuilderFactory.activate(VaultDistributionPackageBuilderFactory.java:267)
> [org.apache.sling.distribution.core:0.5.0]
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:245)
> [org.apache.felix.scr:2.2.4]
> {noformat}
> And indeed the property definition for the property "MEGA_BYTES" looks like
> this:
> {noformat}
> @Property(
> label = "The memory unit for the file threshold",
> description = "The memory unit for the file threshold, Megabytes
> by default",
> value = DEFAULT_MEMORY_UNIT,
> options = {
> @PropertyOption(name = "BYTES", value = "Bytes"),
> @PropertyOption(name = "KILO_BYTES", value = "Kilobytes"),
> @PropertyOption(name = "MEGA_BYTES", value = "Megabytes"),
> @PropertyOption(name = "GIGA_BYTES", value = "Gigabytes")
> }
> )
> private static final String MEMORY_UNIT = "MEGA_BYTES";
> {noformat}
> while the definition for the enum FileBackedMemoryOutputStream.MemoryUnit
> looks like this:
> {noformat}
> public enum MemoryUnit {
> BYTES(1),
> KILO_BYTES(1000),
> MEGA_BYTES((int) pow(10, 6)),
> GIGA_BYTES((int) pow(10, 9));
> private final int memoryFactor;
> MemoryUnit(int memoryFactor) {
> this.memoryFactor = memoryFactor;
> }
> }
> {noformat}
> Meaning that the values in the property definition need adjustment to
> "BYTES", "KILO_BYTES" etc to match the enum definition.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-12223) Incorrect values for OSGI properties (VaultDistributionPackageBuilderFactory)
[
https://issues.apache.org/jira/browse/SLING-12223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider reassigned SLING-12223:
---
Assignee: Christian Schneider
> Incorrect values for OSGI properties (VaultDistributionPackageBuilderFactory)
> -
>
> Key: SLING-12223
> URL: https://issues.apache.org/jira/browse/SLING-12223
> Project: Sling
> Issue Type: Task
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.5.0
>Reporter: Joerg Hoh
>Assignee: Christian Schneider
>Priority: Major
>
> When changing a OSGI value for an service instance of
> VaultDistributionPackageBuilderFactory via the OSGI webconsole, I came across
> this error:
> {noformat}
> 08.01.2024 14:57:00.773 *ERROR* [FelixLogListener]
> org.apache.sling.distribution.serialization.impl.vlt.VaultDistributionPackageBuilderFactory
> bundle org.apache.sling.distribution.core:0.5.0 (334)[or
> g.apache.sling.distribution.serialization.impl.vlt.VaultDistributionPackageBuilderFactory(1167)]
> : The activate method has thrown an exception
> (java.lang.IllegalArgumentException: No enum constant org.apache.sling.distrib
> ution.util.impl.FileBackedMemoryOutputStream.MemoryUnit.Bytes)
> java.lang.IllegalArgumentException: No enum constant
> org.apache.sling.distribution.util.impl.FileBackedMemoryOutputStream.MemoryUnit.Bytes
> at java.base/java.lang.Enum.valueOf(Enum.java:240)
> at
> org.apache.sling.distribution.util.impl.FileBackedMemoryOutputStream$MemoryUnit.valueOf(FileBackedMemoryOutputStream.java:41)
> [org.apache.sling.distribution.core:0.5.0]
> at
> org.apache.sling.distribution.serialization.impl.vlt.VaultDistributionPackageBuilderFactory.activate(VaultDistributionPackageBuilderFactory.java:267)
> [org.apache.sling.distribution.core:0.5.0]
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:245)
> [org.apache.felix.scr:2.2.4]
> {noformat}
> And indeed the property definition for the property "MEGA_BYTES" looks like
> this:
> {noformat}
> @Property(
> label = "The memory unit for the file threshold",
> description = "The memory unit for the file threshold, Megabytes
> by default",
> value = DEFAULT_MEMORY_UNIT,
> options = {
> @PropertyOption(name = "BYTES", value = "Bytes"),
> @PropertyOption(name = "KILO_BYTES", value = "Kilobytes"),
> @PropertyOption(name = "MEGA_BYTES", value = "Megabytes"),
> @PropertyOption(name = "GIGA_BYTES", value = "Gigabytes")
> }
> )
> private static final String MEMORY_UNIT = "MEGA_BYTES";
> {noformat}
> while the definition for the enum FileBackedMemoryOutputStream.MemoryUnit
> looks like this:
> {noformat}
> public enum MemoryUnit {
> BYTES(1),
> KILO_BYTES(1000),
> MEGA_BYTES((int) pow(10, 6)),
> GIGA_BYTES((int) pow(10, 9));
> private final int memoryFactor;
> MemoryUnit(int memoryFactor) {
> this.memoryFactor = memoryFactor;
> }
> }
> {noformat}
> Meaning that the values in the property definition need adjustment to
> "BYTES", "KILO_BYTES" etc to match the enum definition.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12223) Incorrect values for OSGI properties (VaultDistributionPackageBuilderFactory)
[
https://issues.apache.org/jira/browse/SLING-12223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider updated SLING-12223:
Fix Version/s: Content Distribution Core 0.5.2
> Incorrect values for OSGI properties (VaultDistributionPackageBuilderFactory)
> -
>
> Key: SLING-12223
> URL: https://issues.apache.org/jira/browse/SLING-12223
> Project: Sling
> Issue Type: Task
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.5.0
>Reporter: Joerg Hoh
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Core 0.5.2
>
>
> When changing a OSGI value for an service instance of
> VaultDistributionPackageBuilderFactory via the OSGI webconsole, I came across
> this error:
> {noformat}
> 08.01.2024 14:57:00.773 *ERROR* [FelixLogListener]
> org.apache.sling.distribution.serialization.impl.vlt.VaultDistributionPackageBuilderFactory
> bundle org.apache.sling.distribution.core:0.5.0 (334)[or
> g.apache.sling.distribution.serialization.impl.vlt.VaultDistributionPackageBuilderFactory(1167)]
> : The activate method has thrown an exception
> (java.lang.IllegalArgumentException: No enum constant org.apache.sling.distrib
> ution.util.impl.FileBackedMemoryOutputStream.MemoryUnit.Bytes)
> java.lang.IllegalArgumentException: No enum constant
> org.apache.sling.distribution.util.impl.FileBackedMemoryOutputStream.MemoryUnit.Bytes
> at java.base/java.lang.Enum.valueOf(Enum.java:240)
> at
> org.apache.sling.distribution.util.impl.FileBackedMemoryOutputStream$MemoryUnit.valueOf(FileBackedMemoryOutputStream.java:41)
> [org.apache.sling.distribution.core:0.5.0]
> at
> org.apache.sling.distribution.serialization.impl.vlt.VaultDistributionPackageBuilderFactory.activate(VaultDistributionPackageBuilderFactory.java:267)
> [org.apache.sling.distribution.core:0.5.0]
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:245)
> [org.apache.felix.scr:2.2.4]
> {noformat}
> And indeed the property definition for the property "MEGA_BYTES" looks like
> this:
> {noformat}
> @Property(
> label = "The memory unit for the file threshold",
> description = "The memory unit for the file threshold, Megabytes
> by default",
> value = DEFAULT_MEMORY_UNIT,
> options = {
> @PropertyOption(name = "BYTES", value = "Bytes"),
> @PropertyOption(name = "KILO_BYTES", value = "Kilobytes"),
> @PropertyOption(name = "MEGA_BYTES", value = "Megabytes"),
> @PropertyOption(name = "GIGA_BYTES", value = "Gigabytes")
> }
> )
> private static final String MEMORY_UNIT = "MEGA_BYTES";
> {noformat}
> while the definition for the enum FileBackedMemoryOutputStream.MemoryUnit
> looks like this:
> {noformat}
> public enum MemoryUnit {
> BYTES(1),
> KILO_BYTES(1000),
> MEGA_BYTES((int) pow(10, 6)),
> GIGA_BYTES((int) pow(10, 9));
> private final int memoryFactor;
> MemoryUnit(int memoryFactor) {
> this.memoryFactor = memoryFactor;
> }
> }
> {noformat}
> Meaning that the values in the property definition need adjustment to
> "BYTES", "KILO_BYTES" etc to match the enum definition.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12223) Incorrect values for OSGI properties (VaultDistributionPackageBuilderFactory)
[
https://issues.apache.org/jira/browse/SLING-12223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804624#comment-17804624
]
Christian Schneider commented on SLING-12223:
-
Looks like the name and value in the definition have to be swapped.
> Incorrect values for OSGI properties (VaultDistributionPackageBuilderFactory)
> -
>
> Key: SLING-12223
> URL: https://issues.apache.org/jira/browse/SLING-12223
> Project: Sling
> Issue Type: Task
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.5.0
>Reporter: Joerg Hoh
>Priority: Major
>
> When changing a OSGI value for an service instance of
> VaultDistributionPackageBuilderFactory via the OSGI webconsole, I came across
> this error:
> {noformat}
> 08.01.2024 14:57:00.773 *ERROR* [FelixLogListener]
> org.apache.sling.distribution.serialization.impl.vlt.VaultDistributionPackageBuilderFactory
> bundle org.apache.sling.distribution.core:0.5.0 (334)[or
> g.apache.sling.distribution.serialization.impl.vlt.VaultDistributionPackageBuilderFactory(1167)]
> : The activate method has thrown an exception
> (java.lang.IllegalArgumentException: No enum constant org.apache.sling.distrib
> ution.util.impl.FileBackedMemoryOutputStream.MemoryUnit.Bytes)
> java.lang.IllegalArgumentException: No enum constant
> org.apache.sling.distribution.util.impl.FileBackedMemoryOutputStream.MemoryUnit.Bytes
> at java.base/java.lang.Enum.valueOf(Enum.java:240)
> at
> org.apache.sling.distribution.util.impl.FileBackedMemoryOutputStream$MemoryUnit.valueOf(FileBackedMemoryOutputStream.java:41)
> [org.apache.sling.distribution.core:0.5.0]
> at
> org.apache.sling.distribution.serialization.impl.vlt.VaultDistributionPackageBuilderFactory.activate(VaultDistributionPackageBuilderFactory.java:267)
> [org.apache.sling.distribution.core:0.5.0]
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:245)
> [org.apache.felix.scr:2.2.4]
> {noformat}
> And indeed the property definition for the property "MEGA_BYTES" looks like
> this:
> {noformat}
> @Property(
> label = "The memory unit for the file threshold",
> description = "The memory unit for the file threshold, Megabytes
> by default",
> value = DEFAULT_MEMORY_UNIT,
> options = {
> @PropertyOption(name = "BYTES", value = "Bytes"),
> @PropertyOption(name = "KILO_BYTES", value = "Kilobytes"),
> @PropertyOption(name = "MEGA_BYTES", value = "Megabytes"),
> @PropertyOption(name = "GIGA_BYTES", value = "Gigabytes")
> }
> )
> private static final String MEMORY_UNIT = "MEGA_BYTES";
> {noformat}
> while the definition for the enum FileBackedMemoryOutputStream.MemoryUnit
> looks like this:
> {noformat}
> public enum MemoryUnit {
> BYTES(1),
> KILO_BYTES(1000),
> MEGA_BYTES((int) pow(10, 6)),
> GIGA_BYTES((int) pow(10, 9));
> private final int memoryFactor;
> MemoryUnit(int memoryFactor) {
> this.memoryFactor = memoryFactor;
> }
> }
> {noformat}
> Meaning that the values in the property definition need adjustment to
> "BYTES", "KILO_BYTES" etc to match the enum definition.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
