Re: [PR] SLING-12213 update dependencies [sling-org-apache-sling-models-jacksonexporter]
sonarcloud[bot] commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/11#issuecomment-1936573303 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-jacksonexporter=11) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=11=false=true) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-jacksonexporter=11=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=11=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-jacksonexporter=11) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12249) Clarify "ADDED" resource changes for ancestor nodes of path
[ https://issues.apache.org/jira/browse/SLING-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816076#comment-17816076 ] Carsten Ziegeler commented on SLING-12249: -- sounds ok to me > Clarify "ADDED" resource changes for ancestor nodes of path > --- > > Key: SLING-12249 > URL: https://issues.apache.org/jira/browse/SLING-12249 > Project: Sling > Issue Type: Improvement > Components: API >Affects Versions: API 2.15.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Similar to what was clarified in SLING-6066, events for ancestors of the > registered path may not only be received for "REMOVED" resource changes but > also for "ADDED" resource changes. > This happens e.g. for moving resources with the JCR Resource Provider which > uses internally the semantics from > https://issues.apache.org/jira/browse/OAK-1459?focusedCommentId=13911484=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13911484 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] log something in case the vanity path initializer fails [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #116: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/116#issuecomment-1935782061 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=116) **Quality Gate failed** Failed conditions  [C Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=116) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=116) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11605) Async VanityPathInitializer thread should log any exception
[ https://issues.apache.org/jira/browse/SLING-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816029#comment-17816029 ] Joerg Hoh commented on SLING-11605: --- [~reschke] The Sling threadpool implementation is logging if a thread fails with an exception. But this implementation here uses the raw Java Thread, and there is no logging in case the thread fails with an exception. > Async VanityPathInitializer thread should log any exception > --- > > Key: SLING-11605 > URL: https://issues.apache.org/jira/browse/SLING-11605 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver >Affects Versions: Resource Resolver 1.10.0 >Reporter: Joerg Hoh >Priority: Major > > In case the vanity paths are loaded asynchronously, the thread can be > terminated by an unchecked exception without leaving any trace in the logs. > The code should be changed that in case an unchecked exception thrown at > least the exception is logged. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11605) Async VanityPathInitializer thread should log any exception
[ https://issues.apache.org/jira/browse/SLING-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816027#comment-17816027 ] Joerg Hoh commented on SLING-11605: --- PR: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/116 > Async VanityPathInitializer thread should log any exception > --- > > Key: SLING-11605 > URL: https://issues.apache.org/jira/browse/SLING-11605 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver >Affects Versions: Resource Resolver 1.10.0 >Reporter: Joerg Hoh >Priority: Major > > In case the vanity paths are loaded asynchronously, the thread can be > terminated by an unchecked exception without leaving any trace in the logs. > The code should be changed that in case an unchecked exception thrown at > least the exception is logged. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11969) Improve the ConfigurableSerializationModuleProvider
[ https://issues.apache.org/jira/browse/SLING-11969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-11969. --- Resolution: Fixed > Improve the ConfigurableSerializationModuleProvider > --- > > Key: SLING-11969 > URL: https://issues.apache.org/jira/browse/SLING-11969 > Project: Sling > Issue Type: Task > Components: Sling Models >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Models Jackson Exporter 1.1.6 > > > (Feedback taken over from SLING-11924) > * > https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/7/files > contains several commented out lines of code and TODO tags, would be good to > get rid of all those in the final code base > * the comments in the OSGi config definition should explicitly state that > currently only org.apache.sling.api.resource.ResourceResolver is supported. > unlike the OSGi config definition itself we can change the comments at any > time if we want to support more classes. > * and if a different class name is given for any of those parameters, a > warning should be logged that it has no effect. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-11969 a few minor improvements to make the limits more explicit [sling-org-apache-sling-models-jacksonexporter]
joerghoh merged PR #10: URL: https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11969 a few minor improvements to make the limits more explicit [sling-org-apache-sling-models-jacksonexporter]
sonarcloud[bot] commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/10#issuecomment-1935749106 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-jacksonexporter=10) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=10=false=true) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-jacksonexporter=10=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=10=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=10=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-jacksonexporter=10) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12213 update dependencies [sling-org-apache-sling-models-jacksonexporter]
sonarcloud[bot] commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/11#issuecomment-1935725642 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-jacksonexporter=11) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=11=false=true) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-jacksonexporter=11=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=11=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-jacksonexporter=11) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11928) Improve wording in log message
[
https://issues.apache.org/jira/browse/SLING-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-11928:
--
Fix Version/s: Content Distribution Journal Core 0.4.0
(was: Content Distribution Journal ITs 0.1.4)
> Improve wording in log message
> --
>
> Key: SLING-11928
> URL: https://issues.apache.org/jira/browse/SLING-11928
> Project: Sling
> Issue Type: Task
> Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.26
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Content Distribution Journal Core 0.4.0
>
>
> The log message
> {noformat}
> Timeout waiting for distribution package at offset=x on status topic
> {noformat}
> should be clearer; it indicates that the precondition to import a package has
> not been met and for that reason it cannot import the package. Right now the
> message could also be interpreted that there is a network timeout or
> something like that.
> I suggest the following log message:
> {noformat}
> The precondition to import the distribution package at offset= on status
> topic is not met, thus waiting.
> {noformat}
> It's clear, that this situation is expected and that the actual instance
> cannot do much about this situation, until the precondition is met.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11928) Improve wording in log message
[
https://issues.apache.org/jira/browse/SLING-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-11928:
--
Fix Version/s: Content Distribution Journal ITs 0.1.4
> Improve wording in log message
> --
>
> Key: SLING-11928
> URL: https://issues.apache.org/jira/browse/SLING-11928
> Project: Sling
> Issue Type: Task
> Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.26
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Content Distribution Journal ITs 0.1.4
>
>
> The log message
> {noformat}
> Timeout waiting for distribution package at offset=x on status topic
> {noformat}
> should be clearer; it indicates that the precondition to import a package has
> not been met and for that reason it cannot import the package. Right now the
> message could also be interpreted that there is a network timeout or
> something like that.
> I suggest the following log message:
> {noformat}
> The precondition to import the distribution package at offset= on status
> topic is not met, thus waiting.
> {noformat}
> It's clear, that this situation is expected and that the actual instance
> cannot do much about this situation, until the precondition is met.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11928) Improve wording in log message
[
https://issues.apache.org/jira/browse/SLING-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh resolved SLING-11928.
---
Resolution: Fixed
PR merged
> Improve wording in log message
> --
>
> Key: SLING-11928
> URL: https://issues.apache.org/jira/browse/SLING-11928
> Project: Sling
> Issue Type: Task
> Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.26
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
>
> The log message
> {noformat}
> Timeout waiting for distribution package at offset=x on status topic
> {noformat}
> should be clearer; it indicates that the precondition to import a package has
> not been met and for that reason it cannot import the package. Right now the
> message could also be interpreted that there is a network timeout or
> something like that.
> I suggest the following log message:
> {noformat}
> The precondition to import the distribution package at offset= on status
> topic is not met, thus waiting.
> {noformat}
> It's clear, that this situation is expected and that the actual instance
> cannot do much about this situation, until the precondition is met.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12249) Clarify "ADDED" resource changes for ancestor nodes of path
[ https://issues.apache.org/jira/browse/SLING-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815995#comment-17815995 ] Konrad Windszus commented on SLING-12249: - [~cziegeler] I would appreciate a review on the linked PR. > Clarify "ADDED" resource changes for ancestor nodes of path > --- > > Key: SLING-12249 > URL: https://issues.apache.org/jira/browse/SLING-12249 > Project: Sling > Issue Type: Improvement > Components: API >Affects Versions: API 2.15.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Similar to what was clarified in SLING-6066, events for ancestors of the > registered path may not only be received for "REMOVED" resource changes but > also for "ADDED" resource changes. > This happens e.g. for moving resources with the JCR Resource Provider which > uses internally the semantics from > https://issues.apache.org/jira/browse/OAK-1459?focusedCommentId=13911484=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13911484 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling GraphQL Core 0.0.30
On Thu, 2024-02-08 at 15:21 +, Radu Cotescu wrote: > Please vote to approve this release: +1 Robert
