Re: [PR] SLING-12252 Remove maven-plugin-annotations from dependencyManagement [sling-parent]
sonarcloud[bot] commented on PR #43: URL: https://github.com/apache/sling-parent/pull/43#issuecomment-1942870072 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=43) **Quality Gate passed** Issues ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=43&resolved=false&inNewCodePeriod=true) Measures ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent&pullRequest=43&resolved=false&inNewCodePeriod=true) ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Coverage ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=43) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12252 Remove maven-plugin-annotations from dependencyManagement [sling-parent]
slawekjaranowski opened a new pull request, #43: URL: https://github.com/apache/sling-parent/pull/43 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12252) Remove maven-plugin-annotations from dependencyManagement
Slawomir Jaranowski created SLING-12252: --- Summary: Remove maven-plugin-annotations from dependencyManagement Key: SLING-12252 URL: https://issues.apache.org/jira/browse/SLING-12252 Project: Sling Issue Type: Task Reporter: Slawomir Jaranowski Fix For: Parent 61 dependencyManagement for maven-plugin-annotations is defined in ASF parent from version 25 - MPOM-288 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12251) Null Props Cause Incorrect Query Estimation
[ https://issues.apache.org/jira/browse/SLING-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrique Legault resolved SLING-12251. -- Resolution: Invalid > Null Props Cause Incorrect Query Estimation > > > Key: SLING-12251 > URL: https://issues.apache.org/jira/browse/SLING-12251 > Project: Sling > Issue Type: Bug > Components: Oak >Reporter: Patrique Legault >Priority: Major > Attachments: Non Union Query Plan.json, Non Union With Null > Check.json, Screenshot 2024-02-13 at 10.17.31 AM.png, Union Query Plan.json, > cqTagLucene.json > > > Using null props in a query can cause the query engine to incorrectly > estimate the cost of query plan which can lead to a traversal and slow > queries to execute. > > If you look at the query plan below the number of null props documents is > quiet high yet the cost for the query is only 19. When we execute the UNION > query the cost is 38 which is why it is not selected when in reality the > original cost should be much higher. > > After removing the null check the cost estimation is drastically different > and correctly reflects the number of documents in the index. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12251) Null Props Cause Incorrect Query Estimation
Patrique Legault created SLING-12251: Summary: Null Props Cause Incorrect Query Estimation Key: SLING-12251 URL: https://issues.apache.org/jira/browse/SLING-12251 Project: Sling Issue Type: Bug Components: Oak Reporter: Patrique Legault Attachments: Non Union Query Plan.json, Non Union With Null Check.json, Screenshot 2024-02-13 at 10.17.31 AM.png, Union Query Plan.json, cqTagLucene.json Using null props in a query can cause the query engine to incorrectly estimate the cost of query plan which can lead to a traversal and slow queries to execute. If you look at the query plan below the number of null props documents is quiet high yet the cost for the query is only 19. When we execute the UNION query the cost is 38 which is why it is not selected when in reality the original cost should be much higher. After removing the null check the cost estimation is drastically different and correctly reflects the number of documents in the index. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12250) Adding Resource with sling:vanityPath set causes mismatch when resolving vanity URL (timing issue)
[ https://issues.apache.org/jira/browse/SLING-12250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817039#comment-17817039 ] Julian Reschke commented on SLING-12250: While the vanity path cache is populated, the resource resolver will query the repo for the path (and cache that result). Once the cache is ready, timing will depend on event delivery. > Adding Resource with sling:vanityPath set causes mismatch when resolving > vanity URL (timing issue) > -- > > Key: SLING-12250 > URL: https://issues.apache.org/jira/browse/SLING-12250 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Henry Kuijpers >Priority: Major > > It could happen that a Resource containing sling:vanityPath is added and then > resolved, but the Resource did not end up yet in the vanity logic. > Observed with JCR_OAK mock context. > Adding Thread.sleep(1000) fixes the issue, but it's of course not a very good > solution. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12250) Adding Resource with sling:vanityPath set causes mismatch when resolving vanity URL (timing issue)
[ https://issues.apache.org/jira/browse/SLING-12250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817036#comment-17817036 ] Henry Kuijpers commented on SLING-12250: That is indeed an option, it's indeed done asynchronous I think. I believe I saw that a resource change listener was used, though not triggered (yet). > Adding Resource with sling:vanityPath set causes mismatch when resolving > vanity URL (timing issue) > -- > > Key: SLING-12250 > URL: https://issues.apache.org/jira/browse/SLING-12250 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Henry Kuijpers >Priority: Major > > It could happen that a Resource containing sling:vanityPath is added and then > resolved, but the Resource did not end up yet in the vanity logic. > Observed with JCR_OAK mock context. > Adding Thread.sleep(1000) fixes the issue, but it's of course not a very good > solution. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12250) Adding Resource with sling:vanityPath set causes mismatch when resolving vanity URL (timing issue)
[ https://issues.apache.org/jira/browse/SLING-12250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817033#comment-17817033 ] Stefan Seifert commented on SLING-12250: the initializing that part of sling resource resolver which also interprets the vanity paths changed a couple of times of the last years for performance and stability improvements, and is done mostly async in the latest release. as using vanity paths in unit test is more an edge case, it makes no sense to automatically wait for it's completion for all tests. if you have a test that really needs vanity paths, probably use libraries like [https://github.com/awaitility/awaitility] to wait until it's available and then proceed with the tests. > Adding Resource with sling:vanityPath set causes mismatch when resolving > vanity URL (timing issue) > -- > > Key: SLING-12250 > URL: https://issues.apache.org/jira/browse/SLING-12250 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Henry Kuijpers >Priority: Major > > It could happen that a Resource containing sling:vanityPath is added and then > resolved, but the Resource did not end up yet in the vanity logic. > Observed with JCR_OAK mock context. > Adding Thread.sleep(1000) fixes the issue, but it's of course not a very good > solution. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12250) Adding Resource with sling:vanityPath set causes mismatch when resolving vanity URL (timing issue)
Henry Kuijpers created SLING-12250: -- Summary: Adding Resource with sling:vanityPath set causes mismatch when resolving vanity URL (timing issue) Key: SLING-12250 URL: https://issues.apache.org/jira/browse/SLING-12250 Project: Sling Issue Type: Bug Components: Testing Affects Versions: Testing Sling Mock 3.4.18 Reporter: Henry Kuijpers It could happen that a Resource containing sling:vanityPath is added and then resolved, but the Resource did not end up yet in the vanity logic. Observed with JCR_OAK mock context. Adding Thread.sleep(1000) fixes the issue, but it's of course not a very good solution. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1261 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1261/ for details. No further emails will be sent until the status of the build is changed.