Re: [PR] Add tests for multiple applicable configs [sling-org-apache-sling-event]

2024-03-21 Thread via GitHub


kwin merged PR #35:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/35


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Clarify queue ranking [sling-site]

2024-03-21 Thread via GitHub


kwin merged PR #156:
URL: https://github.com/apache/sling-site/pull/156


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] SLING-12263 Separate non-bundles from bundles [sling-site]

2024-03-21 Thread via GitHub


kwin merged PR #158:
URL: https://github.com/apache/sling-site/pull/158


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] SLING-12263 Separate non-bundles from bundles [sling-site]

2024-03-21 Thread via GitHub


kwin commented on PR #158:
URL: https://github.com/apache/sling-site/pull/158#issuecomment-2013687859

   Let us start with the current proposal, we can move later on between 
sections.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] chore(deps): update dependency com.composum.nodes:composum-nodes-commons to v4.3.1 [sling-org-apache-sling-starter]

2024-03-21 Thread via GitHub


rombert merged PR #306:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/306


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (SLING-12274) Adding Support for Additional Distribution Paths

2024-03-21 Thread Danilo Banjac (Jira)
Danilo Banjac created SLING-12274:
-

 Summary: Adding Support for Additional Distribution Paths
 Key: SLING-12274
 URL: https://issues.apache.org/jira/browse/SLING-12274
 Project: Sling
  Issue Type: New Feature
  Components: Content Distribution
Reporter: Danilo Banjac


At present, enriching distribution paths forwarded to the import post processor 
and the invalidation post processor is not feasible. To address this 
limitation, we propose introducing a hook (interface) designed to supply 
additional paths to these processors.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] SLING-12273 Update to sling-bndle-parent 60 [sling-org-apache-sling-models-api]

2024-03-21 Thread via GitHub


sonarcloud[bot] commented on PR #13:
URL: 
https://github.com/apache/sling-org-apache-sling-models-api/pull/13#issuecomment-2012319067

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-api&pullRequest=13)
 **Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-api&pullRequest=13&metric=new_coverage&view=list)
 (required ≥ 80%)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-api&pullRequest=13)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (SLING-12273) Build breaks on Java 21

2024-03-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-12273:

Fix Version/s: Models API 1.5.2

> Build breaks on Java 21
> ---
>
> Key: SLING-12273
> URL: https://issues.apache.org/jira/browse/SLING-12273
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Affects Versions: Models API 1.5.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Models API 1.5.2
>
>
> The following error is emitted in during building with Maven 
> (https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-models-api/detail/master/212/pipeline/)
> {code}
> [INFO] --- invoker:3.3.0:run (integration-test) @ org.apache.sling.models.api 
> ---
> [INFO] Building: validating-annotation-processor/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO]   BUG! exception in phase 'semantic analysis' in source unit 
> 'Script1.groovy' Unsupported class file major version 65
> [INFO]   validating-annotation-processor/pom.xml .. FAILED 
> (15.5 s)
> [INFO] -
> [INFO] Build Summary:
> [INFO]   Passed: 0, Failed: 1, Errors: 0, Skipped: 0
> [INFO] -
> [ERROR] The following builds failed:
> [ERROR] *  validating-annotation-processor/pom.xml
> [INFO] -
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  51.891 s
> [INFO] Finished at: 2024-03-15T23:26:49Z
> [INFO] 
> 
> [INFO] [jenkins-event-spy] Generated 
> /home/jenkins/workspace/g-apache-sling-models-api_master/jdk_21_latest@tmp/withMaven74374c80/maven-spy-20240315-232556-91012999432982760308630.log
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run (integration-test) on 
> project org.apache.sling.models.api: 1 build failed. See console output above 
> for details. -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run 
> (integration-test) on project org.apache.sling.models.api: 1 build failed. 
> See console output above for details.
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run 
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute 
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:159)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:105)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.DirectMethodHandleAccessor.invoke 
> (DirectMethodHandleAccessor.java:103)
> at java.lang.reflect.Method.invoke (Method.java:580)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:348)
> Caused by: org.apache.maven.plugin.MojoFailureException: 1 build failed. See 
> console output above for details.

[PR] SLING-12273 Update to sling-bndle-parent 60 [sling-org-apache-sling-models-api]

2024-03-21 Thread via GitHub


kwin opened a new pull request, #13:
URL: https://github.com/apache/sling-org-apache-sling-models-api/pull/13

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (SLING-12273) Build breaks on Java 21

2024-03-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-12273:
---

Assignee: Konrad Windszus

> Build breaks on Java 21
> ---
>
> Key: SLING-12273
> URL: https://issues.apache.org/jira/browse/SLING-12273
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Affects Versions: Models API 1.5.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> The following error is emitted in during building with Maven 
> (https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-models-api/detail/master/212/pipeline/)
> {code}
> [INFO] --- invoker:3.3.0:run (integration-test) @ org.apache.sling.models.api 
> ---
> [INFO] Building: validating-annotation-processor/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO]   BUG! exception in phase 'semantic analysis' in source unit 
> 'Script1.groovy' Unsupported class file major version 65
> [INFO]   validating-annotation-processor/pom.xml .. FAILED 
> (15.5 s)
> [INFO] -
> [INFO] Build Summary:
> [INFO]   Passed: 0, Failed: 1, Errors: 0, Skipped: 0
> [INFO] -
> [ERROR] The following builds failed:
> [ERROR] *  validating-annotation-processor/pom.xml
> [INFO] -
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  51.891 s
> [INFO] Finished at: 2024-03-15T23:26:49Z
> [INFO] 
> 
> [INFO] [jenkins-event-spy] Generated 
> /home/jenkins/workspace/g-apache-sling-models-api_master/jdk_21_latest@tmp/withMaven74374c80/maven-spy-20240315-232556-91012999432982760308630.log
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run (integration-test) on 
> project org.apache.sling.models.api: 1 build failed. See console output above 
> for details. -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run 
> (integration-test) on project org.apache.sling.models.api: 1 build failed. 
> See console output above for details.
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run 
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute 
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:159)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:105)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.DirectMethodHandleAccessor.invoke 
> (DirectMethodHandleAccessor.java:103)
> at java.lang.reflect.Method.invoke (Method.java:580)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:348)
> Caused by: org.apache.maven.plugin.MojoFailureException: 1 build failed. See 
> console output above for details.
> at org.apache.maven.plugins.invoke

[jira] [Created] (SLING-12273) Build breaks on Java 21

2024-03-21 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-12273:
---

 Summary: Build breaks on Java 21
 Key: SLING-12273
 URL: https://issues.apache.org/jira/browse/SLING-12273
 Project: Sling
  Issue Type: Improvement
  Components: Sling Models
Affects Versions: Models API 1.5.0
Reporter: Konrad Windszus


The following error is emitted in during building with Maven 
(https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-models-api/detail/master/212/pipeline/)

{code}
[INFO] --- invoker:3.3.0:run (integration-test) @ org.apache.sling.models.api 
---
[INFO] Building: validating-annotation-processor/pom.xml
[INFO] run post-build script verify.groovy
[INFO]   BUG! exception in phase 'semantic analysis' in source unit 
'Script1.groovy' Unsupported class file major version 65
[INFO]   validating-annotation-processor/pom.xml .. FAILED 
(15.5 s)
[INFO] -
[INFO] Build Summary:
[INFO]   Passed: 0, Failed: 1, Errors: 0, Skipped: 0
[INFO] -
[ERROR] The following builds failed:
[ERROR] *  validating-annotation-processor/pom.xml
[INFO] -
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  51.891 s
[INFO] Finished at: 2024-03-15T23:26:49Z
[INFO] 
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/workspace/g-apache-sling-models-api_master/jdk_21_latest@tmp/withMaven74374c80/maven-spy-20240315-232556-91012999432982760308630.log
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run (integration-test) on 
project org.apache.sling.models.api: 1 build failed. See console output above 
for details. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run (integration-test) on 
project org.apache.sling.models.api: 1 build failed. See console output above 
for details.
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 
(MojoExecutor.java:333)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
(MojoExecutor.java:316)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:174)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 
(MojoExecutor.java:75)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run 
(MojoExecutor.java:162)
at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute 
(DefaultMojosExecutionStrategy.java:39)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:159)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:105)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:73)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:53)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:118)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
at jdk.internal.reflect.DirectMethodHandleAccessor.invoke 
(DirectMethodHandleAccessor.java:103)
at java.lang.reflect.Method.invoke (Method.java:580)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:283)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:226)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:407)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:348)
Caused by: org.apache.maven.plugin.MojoFailureException: 1 build failed. See 
console output above for details.
at org.apache.maven.plugins.invoker.InvokerSession.handleFailures 
(InvokerSession.java:285)
at org.apache.maven.plugins.invoker.InvokerMojo.processResults 
(InvokerMojo.java:81)
at org.apache.maven.plugins.invoker.AbstractInvokerMojo.execute 
(AbstractInvokerMojo.java:876)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:126)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecu

[jira] [Resolved] (SLING-10137) SlingModelAdapterFactory.createModel() returns null

2024-03-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-10137.
-
Resolution: Duplicate

> SlingModelAdapterFactory.createModel() returns null
> ---
>
> Key: SLING-10137
> URL: https://issues.apache.org/jira/browse/SLING-10137
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Affects Versions: Models Implementation 1.4.16
>Reporter: René Grob
>Priority: Major
>
> According to the documentation 
> ([https://sling.apache.org/documentation/bundles/models.html#modelfactory-since-120])
>  null checks are not necessary. However if a {{@PostConstruct}} method 
> returns false, 
> {{org.apache.sling.models.impl.ModelAdapterFactory.invokePostConstruct()}} 
> will return {{null}}. This will cause 
> {{org.apache.sling.models.impl.ModelAdapterFactory.createModel()}} to fail 
> because {{result.getThrowable()}} returns {{null}} which will result in 
> {{throw null}}.
> In order to fix this {{internalCreateModel()}} needs to return a valid 
> throwable to indicate that the {{@PostConstruct}} method returned {{false}} 
> and therefore no model was created.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (SLING-12271) Supported source version 'RELEASE_8' from annotation processor 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less than -source '11'

2024-03-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-12271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-12271:

Description: 
The annotation processor introduced with SLING-11507 only supports Java 8 
source code version according to the annotation 
https://github.com/apache/sling-org-apache-sling-models-api/blob/3a2bfd7882ef0ef453261aff4f58adeee171c4c7/src/main/java/org/apache/sling/models/annotations/apt/ValidatingAnnotationProcessor.java#L41.

This leads to the following warning during compilation when using javac's 
{{source}} or {{release}} option with any other value than 1.8/8.

{code}
[WARNING] Supported source version 'RELEASE_8' from annotation processor 
'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less 
than -source '11'
{code}

  was:
The annotation processor introduced with SLING-11507 only supports Java 8 
bytecode according to the annotation 
https://github.com/apache/sling-org-apache-sling-models-api/blob/3a2bfd7882ef0ef453261aff4f58adeee171c4c7/src/main/java/org/apache/sling/models/annotations/apt/ValidatingAnnotationProcessor.java#L41.

This leads to the following warning during compilation when targetting e.g. 
Java 11 bytecode

{code}
[WARNING] Supported source version 'RELEASE_8' from annotation processor 
'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less 
than -source '11'
{code}


> Supported source version 'RELEASE_8' from annotation processor 
> 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less 
> than -source '11'
> -
>
> Key: SLING-12271
> URL: https://issues.apache.org/jira/browse/SLING-12271
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Affects Versions: Models API 1.5.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> The annotation processor introduced with SLING-11507 only supports Java 8 
> source code version according to the annotation 
> https://github.com/apache/sling-org-apache-sling-models-api/blob/3a2bfd7882ef0ef453261aff4f58adeee171c4c7/src/main/java/org/apache/sling/models/annotations/apt/ValidatingAnnotationProcessor.java#L41.
> This leads to the following warning during compilation when using javac's 
> {{source}} or {{release}} option with any other value than 1.8/8.
> {code}
> [WARNING] Supported source version 'RELEASE_8' from annotation processor 
> 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less 
> than -source '11'
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-12272) Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor

2024-03-21 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829523#comment-17829523
 ] 

Konrad Windszus commented on SLING-12272:
-

[~rombert] or [~diru] Can any of you take this up?

> Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor
> --
>
> Key: SLING-12272
> URL: https://issues.apache.org/jira/browse/SLING-12272
> Project: Sling
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Priority: Major
>
> With JDK 22 annotation processors will no longer be automatically executed by 
> javac (https://bugs.openjdk.org/browse/JDK-8306819). Instead they need to be 
> explicitly enabled with
> {code}
> -processor 
> {code}
> (https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#option-processor)
> That and a minimum description of what it does should be added to 
> https://sling.apache.org/documentation/bundles/models.html.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (SLING-12272) Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor

2024-03-21 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-12272:
---

 Summary: Document 
org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor
 Key: SLING-12272
 URL: https://issues.apache.org/jira/browse/SLING-12272
 Project: Sling
  Issue Type: Improvement
Reporter: Konrad Windszus


With JDK 22 annotation processors will no longer be automatically executed by 
javac (https://bugs.openjdk.org/browse/JDK-8306819). Instead they need to be 
explicitly enabled with
{code}
-processor 
{code}

(https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#option-processor)
That and a minimum description of what it does should be added to 
https://sling.apache.org/documentation/bundles/models.html.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (SLING-12271) Supported source version 'RELEASE_8' from annotation processor 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less than -source '11'

2024-03-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-12271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-12271:
---

Assignee: Konrad Windszus

> Supported source version 'RELEASE_8' from annotation processor 
> 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less 
> than -source '11'
> -
>
> Key: SLING-12271
> URL: https://issues.apache.org/jira/browse/SLING-12271
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Affects Versions: Models API 1.5.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> The annotation processor introduced with SLING-11507 only supports Java 8 
> bytecode according to the annotation 
> https://github.com/apache/sling-org-apache-sling-models-api/blob/3a2bfd7882ef0ef453261aff4f58adeee171c4c7/src/main/java/org/apache/sling/models/annotations/apt/ValidatingAnnotationProcessor.java#L41.
> This leads to the following warning during compilation when targetting e.g. 
> Java 11 bytecode
> {code}
> [WARNING] Supported source version 'RELEASE_8' from annotation processor 
> 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less 
> than -source '11'
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] SLING-12271 Remove Java <= 8 bytecode restriction [sling-org-apache-sling-models-api]

2024-03-21 Thread via GitHub


kwin opened a new pull request, #12:
URL: https://github.com/apache/sling-org-apache-sling-models-api/pull/12

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (SLING-12271) Supported source version 'RELEASE_8' from annotation processor 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less than -source '11'

2024-03-21 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-12271:
---

 Summary: Supported source version 'RELEASE_8' from annotation 
processor 
'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less 
than -source '11'
 Key: SLING-12271
 URL: https://issues.apache.org/jira/browse/SLING-12271
 Project: Sling
  Issue Type: Improvement
  Components: Sling Models
Affects Versions: Models API 1.5.0
Reporter: Konrad Windszus


The annotation processor introduced with SLING-11507 only supports Java 8 
bytecode according to the annotation 
https://github.com/apache/sling-org-apache-sling-models-api/blob/3a2bfd7882ef0ef453261aff4f58adeee171c4c7/src/main/java/org/apache/sling/models/annotations/apt/ValidatingAnnotationProcessor.java#L41.

This leads to the following warning during compilation when targetting e.g. 
Java 11 bytecode

{code}
[WARNING] Supported source version 'RELEASE_8' from annotation processor 
'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less 
than -source '11'
{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (SLING-12270) Fix null paths in PackageMessage

2024-03-21 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-12270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved SLING-12270.
-
Resolution: Fixed

> Fix null paths in PackageMessage
> 
>
> Key: SLING-12270
> URL: https://issues.apache.org/jira/browse/SLING-12270
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Messages 0.5.6
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Journal Messages 0.5.10
>
>
> The custom builder caused an issue where a packagemessage created with 
> defaults would have null in the paths property. This can cause NPE in other 
> code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)