Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062945983 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) **Quality Gate passed** Issues  [16 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log=18=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-log=18=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-log=18=false=true)  [88.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-log=18=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-log=18=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062939330 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) **Quality Gate failed** Failed conditions  [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-log=18=false=true) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062929582 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) **Quality Gate failed** Failed conditions  [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-log=18=false=true) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062856322 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) **Quality Gate failed** Failed conditions  [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-log=18=false=true)  [67.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-log=18=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062848693 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) **Quality Gate failed** Failed conditions  [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-log=18=false=true)  [67.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-log=18=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062813806 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) **Quality Gate failed** Failed conditions  [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-log=18=false=true)  [67.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-log=18=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062017247 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) **Quality Gate failed** Failed conditions  [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-log=18=false=true)  [67.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-log=18=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log=18) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12298) Repoinit Script Not Respecting the Order of ACLs in set ACL
Sean Curtis created SLING-12298:
---
Summary: Repoinit Script Not Respecting the Order of ACLs in set
ACL
Key: SLING-12298
URL: https://issues.apache.org/jira/browse/SLING-12298
Project: Sling
Issue Type: Bug
Components: Repoinit
Affects Versions: Repoinit JCR 1.1.38, Repoinit Parser 1.6.14
Reporter: Sean Curtis
In short, the Repoinit parser doesn't appear to respect the order of deny-allow
in the set ACL commands.
I had a script like so:
{code:java}
// code placeholder
{
"scripts": [
"create group test-fragments-editors with path /home/groups/forms",
"set ACL on /content/dam/formsanddocuments/\n remove * for
forms-users\n deny jcr:all for forms-users
restriction(rep:glob,/)\nallow jcr:read,crx:replicate for
forms-users restriction(rep:glob,/)\nallow jcr:all for
test-fragments-editors restriction(rep:glob,/)\nend",
"set ACL on /content/forms/af/\n remove * for forms-users\n
deny jcr:all for forms-users restriction(rep:glob,/)\nallow
jcr:read,crx:replicate for forms-users
restriction(rep:glob,/)\nallow jcr:all
restriction(rep:glob,/)for test-fragments-editors\nend""
]
} {code}
I would expect the resulting nodes would match the order defined in the script,
like so:
{code:java}
// expected node output under /content/dam|forms/formsanddocuments|af/
-rep:policy
- deny (forms-useers)
- allow1 (forms-users)
- allow2 (test-fragments-editors) {code}
But instead it was:
{code:java}
// example node output under /content/dam|forms/formsanddocuments|af/
-rep:policy
- allow (test-fragments-editors)
- deny1 (forms-users)
- allow2 (forms-users){code}
Which resulted in a user who is a member of both groups being assigned the more
restrictive permissions. For it to work, I had to put each deny-allow in a
separate set ACL line like so:
{code:java}
// code placeholder
{
"scripts": [
"create group test-fragments-editors with path /home/groups/forms",
"set ACL on /content/dam/formsanddocuments/\n remove * for
forms-users\nend",
"set ACL on /content/dam/formsanddocuments/\n deny jcr:all
for forms-users restriction(rep:glob,/)\nend",
"set ACL on /content/dam/formsanddocuments/\nallow
jcr:read,crx:replicate for forms-users
restriction(rep:glob,/)\nend",
"set ACL on /content/dam/formsanddocuments/\n allow jcr:all
for test-fragments-editors restriction(rep:glob,/)\nend",
...
]
} {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
RE: [VOTE] Release Apache Sling Testing Sling Mock 3.5.0, Sling Mock Oak 4.0.0-1.62.0
+1 stefan
RE: [VOTE] Release Apache Sling Testing Sling Mock Oak 3.2.0-1.22.15
+1 stefan
[VOTE] Release Apache Sling Testing Sling Mock 3.5.0, Sling Mock Oak 4.0.0-1.62.0
Hi, Testing Sling Mock 3.5.0 (3 issues) https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12354169=Text=12310710 Testing Sling Mock Oak 4.0.0-1.62.0 (7 issues) https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12354581=Text=12310710 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2848/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2848 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan
[VOTE] Release Apache Sling Testing Sling Mock Oak 3.2.0-1.22.15
Hi, We solved 6 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353253=Text=12310710 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2849/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2849 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan
[PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]
enapps-enorman opened a new pull request, #18:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18
Increasingly more libraries have been migrating to slf4j 2.x (for example
logback 1.3+, tika 2.5+ and jetty 10+)
To be compatible with those, the sling commons log bundle should migrate to
slf4j v2.x and logback v1.5.x
The changes proposed here is an attempt to do the refactoring to migrate to
the newer versions.
Here are some differences in the proposal:
-
1. Per: https://www.slf4j.org/faq.html#changesInVersion200
SLF4J 2.x has switched to use the java.util.ServiceLoader to locate the
logging implementation so we now require a service loader mediator
implementation in order for the slf4j-api to find the logback implementation.
2. I have tried to avoid embedding the slf4j and logback classes inside of
the org.apache.sling.commons.log bundle and instead just use the bundles that
were already provided by those other organizations. That approach mostly
worked, but I did encounter one classloading (visiblity) problem from our
MaskingMessageUtil customizations where the class names were being passed to
logback and loaded via reflection. I was also able to create a temporary
workaround by forking and updating the logback PatternLayout (and related)
classes to additionally pass a Supplier instead of a classname for that.
I proposed a change to logback that would make my forked workaround
unnecessary which is tracked at: https://github.com/qos-ch/logback/issues/803
3. There still exists a problem with some of the OAK bundles importing the
org.slf4j.event with an old version that is not exported in the SLF4j 2.x
implementation. I was able to workaround this by creating a fragment bundle
that is attached to slf4j-api and exports the 1.7.36 version of the
org.slf4j.event bundle. Hopefully OAK can be modified to remove the dependency
on org.slf4j.event?
I believe this is tracked as:
https://issues.apache.org/jira/browse/OAK-10339
The result of this problem is errors reported by the feature analyzer
like this:
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-lucene:1.60.0:
Bundle is importing package org.slf4j.event;version=[1.7,2) with start order 15
but no bundle is exporting these for that start order in the required version
range.
[ERROR] [bundle-packages]
org.apache.jackrabbit:oak-store-document:1.60.0: Bundle is importing package
org.slf4j.event;version=[1.7,2) with start order 15 but no bundle is exporting
these for that start order in the required version range.
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-commons:1.60.0:
Bundle is importing package org.slf4j.event;version=[1.7,2) with start order 15
but no bundle is exporting these for that start order in the required version
range.
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-core:1.60.0: Bundle
is importing package org.slf4j.event;version=[1.7,2) with start order 15 but no
bundle is exporting these for that start order in the required version range.
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-query-spi:1.60.0:
Bundle is importing package org.slf4j.event;version=[1.7,2) with start order 15
but no bundle is exporting these for that start order in the required version
range.
4. Integrating this into the starter (or other sling based application)
requires this set of bundles in the boot.json feature descriptor:
{
"id":"org.ow2.asm:asm-analysis:${asm.version}",
"start-order":"1"
},
{
"id":"org.ow2.asm:asm-commons:${asm.version}",
"start-order":"1"
},
{
"id":"org.ow2.asm:asm-tree:${asm.version}",
"start-order":"1"
},
{
"id":"org.ow2.asm:asm-util:${asm.version}",
"start-order":"1"
},
{
"id":"org.ow2.asm:asm:${asm.version}",
"start-order":"1"
},
{
"id":"org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle:1.3.7",
"start-order":"1"
},
{
"id":"org.apache.sling:org.apache.sling.commons.log:6.0.0-SNAPSHOT",
"start-order":"1"
},
{
"id":"ch.qos.logback:logback-core:${logback.version}",
"start-order":"1"
},
{
"id":"ch.qos.logback:logback-classic:${logback.version}",
"start-order":"1"
},
{
"id":"org.slf4j:jul-to-slf4j:${slf4j.version}",
"start-order":"1"
},
{
"id":"org.slf4j:jcl-over-slf4j:${slf4j.version}",
"start-order":"1"
},
{
[jira] [Resolved] (SLING-12296) sling-mock-oak: Update to Oak 1.62.0
[ https://issues.apache.org/jira/browse/SLING-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-12296. Resolution: Fixed https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/68e22b7f3087f1caafbc457ddb2b20df7e8c1beb > sling-mock-oak: Update to Oak 1.62.0 > > > Key: SLING-12296 > URL: https://issues.apache.org/jira/browse/SLING-12296 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Minor > Fix For: Testing Sling Mock Oak 4.0.0-1.62.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12296 Update to Oak 1.62.0 [sling-org-apache-sling-testing-sling-mock-oak]
stefanseifert merged PR #15: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12296 Update to Oak 1.62.0 [sling-org-apache-sling-testing-sling-mock-oak]
sonarcloud[bot] commented on PR #15: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/15#issuecomment-2061927885 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock-oak=15) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=15=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=15=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak=15=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=15=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock-oak=15) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-12297) Logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-12297. --- Resolution: Fixed > Logging in case no servlet can be resolved > -- > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.12 > > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12297 log a warning in case no servlet was found [sling-org-apache-sling-engine]
paul-bjorkstrand commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/41#discussion_r1569266916
##
src/main/java/org/apache/sling/engine/impl/request/RequestData.java:
##
@@ -517,6 +518,11 @@ public static void service(SlingHttpServletRequest request,
Servlet servlet = requestData.getContentData().getServlet();
if (servlet == null) {
+log.warn("Did not find a servlet to handle the request
(path=%s,selectors=%,extension=%s,suffix=%s)",
Review Comment:
A couple things:
1. Shouldn't these just be positional parameters (`{}`) in logs, not
`String.format`-style parameters?
2. Not sure if needed here, but if you use a logger method that ends up
var-args (more than 2 format arguments/exception), it is often good to wrap
with `if (Logger.isXxxEnabled()) { ... }` to avoid the varargs array creation.
For (2) it really depends on how frequently it is expected to occur. This
one might be ok, but I figured better to mention it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (SLING-12297) Logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-12297: - Assignee: Joerg Hoh > Logging in case no servlet can be resolved > -- > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.12 > > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12297 log a warning in case no servlet was found [sling-org-apache-sling-engine]
joerghoh merged PR #41: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12297) Logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12297: -- Fix Version/s: Engine 2.15.12 > Logging in case no servlet can be resolved > -- > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.12 > > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] SLING-12297 log a warning in case no servlet was found [sling-org-apache-sling-engine]
joerghoh opened a new pull request, #41: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/41 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12297) Adding logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12297: -- Description: Right now the SlingEngine just returns a 404, if the no servlet was found to render the resource. It should also log a WARN message indicating that this happened. (was: Right now the ServletsResolver just returns a 404, if the no servlet was found to render the resource. It should also log a WARN message indicating that this happened.) > Adding logging in case no servlet can be resolved > - > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Priority: Major > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12297) Logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12297: -- Summary: Logging in case no servlet can be resolved (was: Add logging in case no servlet can be resolved) > Logging in case no servlet can be resolved > -- > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Priority: Major > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12297) Add logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12297: -- Summary: Add logging in case no servlet can be resolved (was: Adding logging in case no servlet can be resolved) > Add logging in case no servlet can be resolved > -- > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Priority: Major > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12297) Adding logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12297: -- Affects Version/s: Engine 2.15.10 (was: Servlets Resolver 2.11.2) > Adding logging in case no servlet can be resolved > - > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Priority: Major > > Right now the ServletsResolver just returns a 404, if the no servlet was > found to render the resource. It should also log a WARN message indicating > that this happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12297) Adding logging in case no servlet can be resolved
Joerg Hoh created SLING-12297: - Summary: Adding logging in case no servlet can be resolved Key: SLING-12297 URL: https://issues.apache.org/jira/browse/SLING-12297 Project: Sling Issue Type: Task Affects Versions: Servlets Resolver 2.11.2 Reporter: Joerg Hoh Right now the ServletsResolver just returns a 404, if the no servlet was found to render the resource. It should also log a WARN message indicating that this happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] SLING-12296 Update to Oak 1.62.0 [sling-org-apache-sling-testing-sling-mock-oak]
stefanseifert opened a new pull request, #15: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/15 https://issues.apache.org/jira/browse/SLING-12296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12296) sling-mock-oak: Update to Oak 1.62.0
Stefan Seifert created SLING-12296: -- Summary: sling-mock-oak: Update to Oak 1.62.0 Key: SLING-12296 URL: https://issues.apache.org/jira/browse/SLING-12296 Project: Sling Issue Type: Improvement Components: Testing Reporter: Stefan Seifert Assignee: Stefan Seifert Fix For: Testing Sling Mock Oak 4.0.0-1.62.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling Tenant 1.1.8
We need one more binding vote. Thanks, Robert
Re: [VOTE] Release Apache Sling Tenant 1.1.8
On Thu, 2024-04-11 at 13:33 +, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Closed] (SLING-12291) Broken backwards compatibility for duplicated keys
[ https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-12291. --- > Broken backwards compatibility for duplicated keys > -- > > Key: SLING-12291 > URL: https://issues.apache.org/jira/browse/SLING-12291 > Project: Sling > Issue Type: Bug >Affects Versions: Commons JSON 2.0.24 >Reporter: Remo Liechti >Assignee: Remo Liechti >Priority: Major > Fix For: Commons JSON 2.0.26 > > > The fix of CVE-2022-47937 introduced an invalid backwards compatibility for > duplicated keys in a json. > New behaviour: throws an exception on duplicated keys > Old behaviour: ignores the fact and is able to process json with duplicated > keys. > To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling Commons JSON 2.0.26
Hi, The vote has passed with the following result: +1 (binding): Stefan Seifert, Carsten Ziegeler, Robert Munteanu +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
Re: [VOTE] Release Apache Sling Commons JSON 2.0.26
On Fri, 2024-04-12 at 07:49 +, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Resolved] (SLING-12287) sling-mock-oak: Update to Oak 1.60 and provide separate 1.22 release
[ https://issues.apache.org/jira/browse/SLING-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-12287. Resolution: Fixed * 4.x: (master): [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/d4f0388ac9cf592a218230ee01cf14a6c3a93463] * 3.2.x: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/edf70e21c3e06b9e4960d99332669050727c7251 > sling-mock-oak: Update to Oak 1.60 and provide separate 1.22 release > > > Key: SLING-12287 > URL: https://issues.apache.org/jira/browse/SLING-12287 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing Sling Mock Oak 3.2.0-1.22.15, Testing Sling Mock > Oak 4.0.0-1.60.0 > > > following the discussion with [~reschke] in SLING-12266 we should move away > from oak 1.44 which is quite outdated. however, we need to ensure to keep > compatibility with the old 1.22.x version range to support all sorts of > projects using the mocks. > a solution might be to switch to a recent version of oak in the POM, and > create dedicated ITs to test against this and older 1.22.x versions to ensure > compatibility. > the benefit is, that all projects that are "just using" sling-mock-oak > without thinking about the dependency management (e.g. not using something > like [https://wcm.io/tooling/maven/aem-dependencies.html)] will get the > latest version which is better supported. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12287 Switch to Oak 1.60 [sling-org-apache-sling-testing-sling-mock-oak]
stefanseifert merged PR #14: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SLING-12287) sling-mock-oak: Update to Oak 1.60 and provide separate 1.22 release
[ https://issues.apache.org/jira/browse/SLING-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836439#comment-17836439 ] Stefan Seifert edited comment on SLING-12287 at 4/17/24 2:00 PM: - looking deeper into this, i think it's not easy possible to have a single JAR/POM supporting both oak 1.22 and latest oak version at the same time. there is too much change between them, regarding supported jdks and the change guava is embedded. i currently plan to do a branching of sling-mock-oak - one maintenance branch for 1.22.x and one for latest versions - this is in-line how oak itself it is doing. i started two draft PRs and will continue test the produced JARs in different project environments if this is working. maybe we can eliminate more of the shading/embedding in the latest sling-mock-oak version which would be a good thing. * sling-mock-oak 4.x with Oak 1.60: [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/14] * sling-mock-oak 3.2.x with Oak 1.22: [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/13] was (Author: sseif...@pro-vision.de): looking deeper into this, i think it's not easy possible to have a single JAR/POM supporting both oak 1.22 and latest oak version at the same time. there is too much change between them, regarding supported jdks and the change guava is embedded. i currently plan to do a branching of sling-mock-oak - one maintenance branch for 1.22.x and one for latest versions - this is in-line how oak itself it is doing. i started two draft PRs and will continue test the produced JARs in different project environments if this is working. maybe we can eliminate more of the shading/embedding in the latest sling-mock-oak version which would be a good thing. * sling-mock-oak 4.x with Oak 1.60: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/13 * sling-mock-oak 3.2.x with Oak 1.22: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/14 > sling-mock-oak: Update to Oak 1.60 and provide separate 1.22 release > > > Key: SLING-12287 > URL: https://issues.apache.org/jira/browse/SLING-12287 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing Sling Mock Oak 3.2.0-1.22.15, Testing Sling Mock > Oak 4.0.0-1.60.0 > > > following the discussion with [~reschke] in SLING-12266 we should move away > from oak 1.44 which is quite outdated. however, we need to ensure to keep > compatibility with the old 1.22.x version range to support all sorts of > projects using the mocks. > a solution might be to switch to a recent version of oak in the POM, and > create dedicated ITs to test against this and older 1.22.x versions to ensure > compatibility. > the benefit is, that all projects that are "just using" sling-mock-oak > without thinking about the dependency management (e.g. not using something > like [https://wcm.io/tooling/maven/aem-dependencies.html)] will get the > latest version which is better supported. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12287 Switch to Oak 1.22 [sling-org-apache-sling-testing-sling-mock-oak]
stefanseifert merged PR #13: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12287) sling-mock-oak: Update to Oak 1.60 and provide separate 1.22 release
[ https://issues.apache.org/jira/browse/SLING-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-12287: --- Fix Version/s: Testing Sling Mock Oak 4.0.0-1.60.0 > sling-mock-oak: Update to Oak 1.60 and provide separate 1.22 release > > > Key: SLING-12287 > URL: https://issues.apache.org/jira/browse/SLING-12287 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing Sling Mock Oak 3.2.0-1.22.15, Testing Sling Mock > Oak 4.0.0-1.60.0 > > > following the discussion with [~reschke] in SLING-12266 we should move away > from oak 1.44 which is quite outdated. however, we need to ensure to keep > compatibility with the old 1.22.x version range to support all sorts of > projects using the mocks. > a solution might be to switch to a recent version of oak in the POM, and > create dedicated ITs to test against this and older 1.22.x versions to ensure > compatibility. > the benefit is, that all projects that are "just using" sling-mock-oak > without thinking about the dependency management (e.g. not using something > like [https://wcm.io/tooling/maven/aem-dependencies.html)] will get the > latest version which is better supported. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12287) sling-mock-oak: Update to Oak 1.60 and provide separate 1.22 release
[ https://issues.apache.org/jira/browse/SLING-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-12287: --- Summary: sling-mock-oak: Update to Oak 1.60 and provide separate 1.22 release (was: sling-mock-oak: Use latest Oak Version and add ITs to ensure compatiblity with 1.22.x) > sling-mock-oak: Update to Oak 1.60 and provide separate 1.22 release > > > Key: SLING-12287 > URL: https://issues.apache.org/jira/browse/SLING-12287 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing Sling Mock Oak 3.2.0-1.44.0 > > > following the discussion with [~reschke] in SLING-12266 we should move away > from oak 1.44 which is quite outdated. however, we need to ensure to keep > compatibility with the old 1.22.x version range to support all sorts of > projects using the mocks. > a solution might be to switch to a recent version of oak in the POM, and > create dedicated ITs to test against this and older 1.22.x versions to ensure > compatibility. > the benefit is, that all projects that are "just using" sling-mock-oak > without thinking about the dependency management (e.g. not using something > like [https://wcm.io/tooling/maven/aem-dependencies.html)] will get the > latest version which is better supported. -- This message was sent by Atlassian Jira (v8.20.10#820010)
RE: [VOTE] Release Apache Sling JUnit Tests Teleporter 1.0.26
+1 stefan
Re: [VOTE] Release Apache Sling JUnit Tests Teleporter 1.0.26
Please disregard this thread, I accidentally sent the email twice. Thanks, Robert On Wed, 2024-04-17 at 11:52 +0200, Robert Munteanu wrote: > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12348597=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2847/ > > You can use this UNIX script to download the release and verify the > signatures: > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2847 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu signature.asc Description: This is a digitally signed message part
[VOTE] Release Apache Sling JUnit Tests Teleporter 1.0.26
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12348597=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2847/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2847 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Assigned] (SLING-11633) ClientSideTeleporter throwing illegal argument when target byte code is > 1.8
[ https://issues.apache.org/jira/browse/SLING-11633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-11633: --- Assignee: Scott Yuan > ClientSideTeleporter throwing illegal argument when target byte code is > 1.8 > - > > Key: SLING-11633 > URL: https://issues.apache.org/jira/browse/SLING-11633 > Project: Sling > Issue Type: Improvement > Components: Testing > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Maven home: C:\aem-tools\utils\apache-maven-3.8.5 > Java version: 11.0.15.1, vendor: Oracle Corporation, runtime: > C:\aem-tools\utils\jdk-11.0.15.1 > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >Reporter: Scott Yuan >Assignee: Scott Yuan >Priority: Trivial > Fix For: JUnit Tests Teleporter 1.0.26 > > Attachments: mylab.zip > > Original Estimate: 2h > Time Spent: 0.5h > Remaining Estimate: 1.5h > > When attempted to use the latest 1.0.22 to build test cases using > TeleporterRule with Java 11+ code, illegal arguments error occurred. > It can be reproduce with the attached Maven project by change following > properites to 11. > * maven.compiler.source > * maven.compiler.target -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060868380 Thanks for your patience @sufyanharoon, I started a release vote: https://lists.apache.org/thread/lfkj8cjfswcp3nnqx3s1mxrmd99rs1wl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE] Release Apache Sling JUnit Tests Teleporter 1.0.26
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12348597=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2847/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2847 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert merged PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060740880 @rombert LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060672290 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=8) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-teleporter=8=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=8=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-junit-teleporter=8=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=8=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060615568 Thanks for the revierw @sufyanharoon . I made the additional change now, let me know if that solves the issue completely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-12295) Add queue size metric
[ https://issues.apache.org/jira/browse/SLING-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved SLING-12295. - Resolution: Fixed > Add queue size metric > - > > Key: SLING-12295 > URL: https://issues.apache.org/jira/browse/SLING-12295 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
