Re: [PR] SLING-12322 Stream Reader should Return SC_OK if content length is le… [sling-org-apache-sling-servlets-get]

2024-05-22 Thread via GitHub 


abhishekgarg18 closed pull request #14: SLING-12322 Stream Reader should Return 
SC_OK if content length is le…
URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-12322) Stream Reader should Return SC_OK if content length is less than specified range

2024-05-22 Thread Abhishek Garg (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Garg resolved SLING-12322.
---
Resolution: Not A Problem

> Stream Reader should Return SC_OK if content length is less than specified 
> range
> 
>
> Key: SLING-12322
> URL: https://issues.apache.org/jira/browse/SLING-12322
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.2.0
>Reporter: Abhishek Garg
>Priority: Major
>
> if the Request contains following header :
> {code:java}
> Range: bytes=0-8388607 {code}
> and file length is less than this, then we should return SC_OK(200) instead 
> of 
> SC_PARTIAL_CONTENT(206).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12322) Stream Reader should Return SC_OK if content length is less than specified range

2024-05-22 Thread Abhishek Garg (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848822#comment-17848822
 ] 

Abhishek Garg commented on SLING-12322:
---

This PR was handling the case when the request with the RANGE header and 
response size was less than the RANGE HEADER.

Apparently, this is against HTTP RFC 
[https://greenbytes.de/tech/webdav/rfc9110.html#field.range]
marking this as closed.

thanks [~kwin] 

> Stream Reader should Return SC_OK if content length is less than specified 
> range
> 
>
> Key: SLING-12322
> URL: https://issues.apache.org/jira/browse/SLING-12322
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.2.0
>Reporter: Abhishek Garg
>Priority: Major
>
> if the Request contains following header :
> {code:java}
> Range: bytes=0-8388607 {code}
> and file length is less than this, then we should return SC_OK(200) instead 
> of 
> SC_PARTIAL_CONTENT(206).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12322) Stream Reader should Return SC_OK if content length is less than specified range

2024-05-22 Thread Konrad Windszus (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848818#comment-17848818
 ] 

Konrad Windszus commented on SLING-12322:
-

I don’t think this is compliant with 
https://datatracker.ietf.org/doc/html/rfc7233#section-4.1. What actual issue 
are you trying to solve?

> Stream Reader should Return SC_OK if content length is less than specified 
> range
> 
>
> Key: SLING-12322
> URL: https://issues.apache.org/jira/browse/SLING-12322
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.2.0
>Reporter: Abhishek Garg
>Priority: Major
>
> if the Request contains following header :
> {code:java}
> Range: bytes=0-8388607 {code}
> and file length is less than this, then we should return SC_OK(200) instead 
> of 
> SC_PARTIAL_CONTENT(206).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12322) Stream Reader should Return SC_OK if content length is less than specified range

2024-05-22 Thread Abhishek Garg (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848813#comment-17848813
 ] 

Abhishek Garg commented on SLING-12322:
---

create a draft PR 
[https://github.com/apache/sling-org-apache-sling-servlets-get/pull/14]

> Stream Reader should Return SC_OK if content length is less than specified 
> range
> 
>
> Key: SLING-12322
> URL: https://issues.apache.org/jira/browse/SLING-12322
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.2.0
>Reporter: Abhishek Garg
>Priority: Major
>
> if the Request contains following header :
> {code:java}
> Range: bytes=0-8388607 {code}
> and file length is less than this, then we should return SC_OK(200) instead 
> of 
> SC_PARTIAL_CONTENT(206).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] SLING-12322 Stream Reader should Return SC_OK if content length is le… [sling-org-apache-sling-servlets-get]

2024-05-22 Thread via GitHub 


abhishekgarg18 opened a new pull request, #14:
URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/14

   …ss than specified range


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-12322) Stream Reader should Return SC_OK if content length is less than specified range

2024-05-22 Thread Abhishek Garg (Jira) 
Abhishek Garg created SLING-12322:
-

 Summary: Stream Reader should Return SC_OK if content length is 
less than specified range
 Key: SLING-12322
 URL: https://issues.apache.org/jira/browse/SLING-12322
 Project: Sling
  Issue Type: Bug
  Components: Servlets
Affects Versions: Servlets Get 2.2.0
Reporter: Abhishek Garg


if the Request contains following header :
{code:java}
Range: bytes=0-8388607 {code}
and file length is less than this, then we should return SC_OK(200) instead of 
SC_PARTIAL_CONTENT(206).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1384 is FIXED

2024-05-22 Thread Apache Jenkins Server 
Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1384/
 for details.

No further emails will be sent until the status of the build is changed.

[jira] [Resolved] (SLING-12317) Make Sling Engine build with Java 21

2024-05-22 Thread Robert Munteanu (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-12317.
-
Resolution: Fixed

> Make Sling Engine build with Java 21
> 
>
> Key: SLING-12317
> URL: https://issues.apache.org/jira/browse/SLING-12317
> Project: Sling
>  Issue Type: Task
>  Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Engine 2.15.16
>
>
> {noformat}[ERROR] 
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant
>   Time elapsed: 0 s  <<< ERROR!
> java.lang.IllegalStateException: No code generation strategy available
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.proxyClass(ByteBuddyClassImposteriser.java:167)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.access$000(ByteBuddyClassImposteriser.java:41)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:100)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:96)
>   at 
> java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.proxy(ByteBuddyClassImposteriser.java:95)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.imposterise(ByteBuddyClassImposteriser.java:66)
>   at org.jmock.Mockery.mock(Mockery.java:167)
>   at org.jmock.Mockery.mock(Mockery.java:143)
>   at 
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant(SlingHttpServletRequestImplTest.java:176)
>   at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:580)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
>   at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
>   at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] SLING-12317 - Make Sling Engine build with Java 21 [sling-org-apache-sling-engine]

2024-05-22 Thread via GitHub 


rombert commented on PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-engine/pull/45#issuecomment-2124809600

   @joerghoh  - all done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12317 - Make Sling Engine build with Java 21 [sling-org-apache-sling-engine]

2024-05-22 Thread via GitHub 


rombert merged PR #45:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/45


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12318 apply spotless formatting [sling-org-apache-sling-engine]

2024-05-22 Thread via GitHub 


rombert merged PR #44:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/44


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-12321) Update parent pom to latest

2024-05-22 Thread Joerg Hoh (Jira) 
Joerg Hoh created SLING-12321:
-

 Summary: Update parent pom to latest
 Key: SLING-12321
 URL: https://issues.apache.org/jira/browse/SLING-12321
 Project: Sling
  Issue Type: Task
  Components: Engine
Reporter: Joerg Hoh
 Fix For: Engine 2.15.16






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] SLING-12317 - Make Sling Engine build with Java 21 [sling-org-apache-sling-engine]

2024-05-22 Thread via GitHub 


joerghoh commented on PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-engine/pull/45#issuecomment-2124762983

   @rombert would appreciate that. I plan to upgrade parent pom afterwards 
(SLING-12321)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12283 : write config in correct format incase of factoryPid is … [sling-org-apache-sling-installer-provider-jcr]

2024-05-22 Thread via GitHub 


jsedding commented on code in PR #9:
URL: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9#discussion_r1609457830


##
src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrUtil.java:
##
@@ -73,4 +75,21 @@ public static Node createPath(final Session session,
 }
 return parentNode.getNode(relativePath);
 }
+
+/**
+ * Get the PID for a configuration event by using the R7 format before 
saving it.
+ *
+ * @param factoryPid factory PID of the configuration
+ * @param pid PID of the configuration
+ * @return The PID in R7 format
+ */
+public static String getPid(final String factoryPid, final String pid) {
+// if factory pid is separated from pid by a period (.), we need 
replace it with a ~ so that this can be installed
+// and grouped as a factory configuration
+if (pid.startsWith(factoryPid + '.')) {
+String id = pid.substring(factoryPid.length() + 1);
+return factoryPid + "~" + id;
+}
+return pid;

Review Comment:
   I was thinking to keep this slightly more generic (note: untested code 
below!):
   
   ```suggestion
   final String name;
   if (pid.matches("^" + factoryPid + "[^a-zA-Z0-9\\s]")) {
   name = pid.substring(factoryPid.length() + 1);
   } else {
   name = pid;
   }
   return factoryPid + "~" + name;
   ```
   
   WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

RE: [VOTE] Release Apache Sling JCR Resource 3.3.2

2024-05-22 Thread Stefan Seifert 
+1

stefan

Re: [PR] SLING-12317 - Make Sling Engine build with Java 21 [sling-org-apache-sling-engine]

2024-05-22 Thread via GitHub 


rombert commented on PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-engine/pull/45#issuecomment-2124069446

   @joerghoh - do you want to merge #44 first? I can then rebase, if needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org