Re: [PR] SLING-12283 : write config in correct format incase of factoryPid is … [sling-org-apache-sling-installer-provider-jcr]
rishabhdaim commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9#issuecomment-2129190028 > @rishabhdaim I think once you remove the original.pid part of the code, we could merge this PR. Done in https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9/commits/69597f866d6a5646ba334cbefb3aade499a97e1d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12325) The HTL parser can get confused when HTML markup is present in string literals
Csaba Varga created SLING-12325:
---
Summary: The HTL parser can get confused when HTML markup is
present in string literals
Key: SLING-12325
URL: https://issues.apache.org/jira/browse/SLING-12325
Project: Sling
Issue Type: Bug
Components: HTL
Reporter: Csaba Varga
In some cases, HTL that's perfectly valid based on the spec will cause a
compilation error. For example, this will be rejected when used outside of an
attribute:
{code:java}
${'Click here.' @ format='/', context='html'} {code}
The HTML parsing phase will consider the first closing brace to be the end of
the expression, and the part as a tag outside of an expression. The next
phase will see this expression:
{code:java}
${'Click here {code}
and reject it as syntactically invalid.
The HTML parsing phase needs to be more careful about expression syntax. I
think it will need to look out for quotes and backslashes to safely tell
whether a closing brace is an expression terminator or just a regular character
inside a string literal.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
