from:"Carsten Ziegeler"



[ 
https://issues.apache.org/jira/browse/SLING-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814809#comment-17814809
 ] 

Carsten Ziegeler commented on SLING-12247:
--

Looks ok to me

> Provide component property type for (External)ResourceChangeListener
> 
>
> Key: SLING-12247
> URL: https://issues.apache.org/jira/browse/SLING-12247
> Project: Sling
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In order to ease registration of Sling ResourceChangeListeners a [component 
> property type 
> |https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types]
>  should be provided with elements for all supported properties.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener



[ 
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814722#comment-17814722
 ] 

Carsten Ziegeler commented on SLING-12246:
--

Sure. In theory there should be no need to handle a move event. But if there 
are cases where no added/removed combo is sent, then this should probably be 
fixed (best in Oak).

> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED 
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
>  is not supported in {{JcrResourceListener}} 
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited 
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the 
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for 
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
>  must be the same as for remove events (i.e. changed parent paths will also 
> trigger it)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener



[ 
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814717#comment-17814717
 ] 

Carsten Ziegeler commented on SLING-12246:
--

I read there "NODE_MOVED event, NODE_ADDED event for the root of the sub-tree 
only, NODE_REMOVED event for the root of the sub-tree only"

> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED 
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
>  is not supported in {{JcrResourceListener}} 
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited 
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the 
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for 
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
>  must be the same as for remove events (i.e. changed parent paths will also 
> trigger it)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener



[ 
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814714#comment-17814714
 ] 

Carsten Ziegeler commented on SLING-12246:
--

If I remember correctly, we skipped implementing explicit support for the 
"moved" event as a add/remove events were sent in addition anyway. 

> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED 
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
>  is not supported in {{JcrResourceListener}} 
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited 
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the 
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for 
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
>  must be the same as for remove events (i.e. changed parent paths will also 
> trigger it)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

CVE-2024-23673: Apache Sling Servlets Resolver: Malicious code execution via path traversal

2024-02-06 Thread Carsten Ziegeler

Affected versions:

- Apache Sling Servlets Resolver before 2.11.0

Description:

Malicious code execution via path traversal in Apache Software Foundation 
Apache Sling Servlets Resolver.This issue affects all version of Apache Sling 
Servlets Resolver before 2.11.0. However, whether a system is vulnerable to 
this attack depends on the exact configuration of the system.
If the system is vulnerable, a user with write access to the repository might 
be able to trick the Sling Servlet Resolver to load a previously uploaded 
script. 

Users are recommended to upgrade to version 2.11.0, which fixes this issue. It 
is recommended to upgrade, regardless of whether your system configuration 
currently allows this attack or not.

This issue is being tracked as SLING-12233 

References:

https://sling.apache.org/
https://www.cve.org/CVERecord?id=CVE-2024-23673
https://issues.apache.org/jira/browse/SLING-12233

Re: Sling Model Caching & GC problems

2024-01-30 Thread Carsten Ziegeler

Sure, no problem with using a WeakHashMap.

Regards
Carsten

On 30.01.2024 10:28, Jörg Hoh wrote:

Paul,

thanks for your mail. I agree to your observation what's going on. I also
think that cache at the ResourceResolver level makes more sense, and it's
easier to control and remove cached models, which cannot be used any more.

@Carsten: Regarding the size, we can still use a WeakHashMap as a container
for these Sling Models (and store the WeakHashMap in the PropertyMap of the
ResourceResolver), and that should prevent the worst, even in case of a
long-running ResourceResolver or many adaptions.

Jörg

Am Di., 30. Jan. 2024 um 07:16 Uhr schrieb Carsten Ziegeler <
cziege...@apache.org>:

I don't know much about sling models caching, but it seems storing the
cache into the resource resolver and therefore binding it to that
lifecycle sounds very reasonable to me. And due to the mentioned support
for Closeable, the cache gets discarded automatically with the resolver
being closed. No extra handling required, no soft references etc. needed.

Obviously, that sounds problematic with long or forever running resource
resolvers as the cache would never be released. However, I guess thats
not worse than what we have today. And long running resource resolvers
are an anti-pattern anyway.

Regards
Carsten

On 23.01.2024 17:23, Paul Bjorkstrand wrote:

Hi Jörg,

My guess is that you are running up against the problem where the Model

referencing its adaptable, directly or indirectly. In that situation, the
model would not be collectable because it is referenced more strongly

than

by weak reference. The reference path of these might look like this:

Model Cache Holder (the Model Adapter Factory
(strong reference)
Model Cache
(soft reference)
Model
(strong reference)
Resource Resolver
(strong reference, maybe indirectly)
Resource [the adaptable]

The resource is strongly or softly referenced, possibly indirectly,

making

it ineligible for collection on normal GC cycles. The resource &

resolver,

will not be collected until after the model is collected. Since the model
is not collected until there is memory pressure, that would explain why

you

are seeing this (expensive) GC behavior.

When memory pressure occurs, first the models (soft references) are
collected prior to the OOM, which releases both resolver (no longer
referenced via field in the model) and resource.

The quickest fix is to release the resource resolver at the end of the
model’s constructor or @PostConstruct [2]. Alternatively, you can

eliminate

the cache=true, provided it does not negatively impact your application
performance.
Another option, though more involved, is that the entire caching impl

could

be changed to better handle these kinds of reference loops, by putting

the

cache in the adaptable itself (Resolver, Resource, Request, etc).

Possible

good candidates of these are [4] or request attributes. [4] seems to be

the

overall best candidate, especially since you can hook into it using
Closeable ([5]) improving the cache eviction even more.

As long as the object holding the cache is not referenced strongly

outside

that reference loop (cache holder > cache > model > ... > cache holder),
then the loop's objects would be eligible for GC as soon as the cache
holder is eligible.

[1]:

https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/ref/SoftReference.html

[2]:

https://sling.apache.org/documentation/bundles/models.html#a-note-about-cache-true-and-using-the-self-injector

[3]:

https://github.com/apache/sling-org-apache-sling-models-impl/pull/18

[4]:

https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L888

[5]:

https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L610

// Paul

On Tue, Jan 23, 2024 at 6:48 AM Jörg Hoh
.invalid>

wrote:

Hi Sling community,

I want to share a recent experience I had with Sling Models, Sling Model
caching and Garbage Collection problems.

I had a case, where an AEM instance had massive garbage collection
problems, but no memory problems. We saw the regular sawtooth pattern in
the heap consumption, but heavy GC activity (in a stop-the-world manner)
almost constantly. But no OutOfMemory situation, there it's not a memory
leak.

I manually captured a heapdump and found a lot of Sling models being
referenced by the Sling ModelAdapterFactory cache, and rechecking these
model classes in detail I found them to specify "cache=true" in their
@Model annotation.When these statements were removed, the situation

looks

completely different, and the garbage collection was normal again.

I don't have a full explanation for this behavior yet. The Sling Models

had

a reference to a ResourceResolver (which was properly closed), but I

assume

that this reference somehow "disabled&q

Re: Sling Model Caching & GC problems

2024-01-29 Thread Carsten Ziegeler

Regards
Carsten

On 23.01.2024 17:23, Paul Bjorkstrand wrote:

Hi Jörg,

My guess is that you are running up against the problem where the Model is
referencing its adaptable, directly or indirectly. In that situation, the
model would not be collectable because it is referenced more strongly than
by weak reference. The reference path of these might look like this:

Model Cache Holder (the Model Adapter Factory
(strong reference)
Model Cache
(soft reference)
Model
(strong reference)
Resource Resolver
(strong reference, maybe indirectly)
Resource [the adaptable]

The resource is strongly or softly referenced, possibly indirectly, making
it ineligible for collection on normal GC cycles. The resource & resolver,
will not be collected until after the model is collected. Since the model
is not collected until there is memory pressure, that would explain why you
are seeing this (expensive) GC behavior.

When memory pressure occurs, first the models (soft references) are
collected prior to the OOM, which releases both resolver (no longer
referenced via field in the model) and resource.

The quickest fix is to release the resource resolver at the end of the
model’s constructor or @PostConstruct [2]. Alternatively, you can eliminate
the cache=true, provided it does not negatively impact your application
performance.
Another option, though more involved, is that the entire caching impl could
be changed to better handle these kinds of reference loops, by putting the
cache in the adaptable itself (Resolver, Resource, Request, etc). Possible
good candidates of these are [4] or request attributes. [4] seems to be the
overall best candidate, especially since you can hook into it using
Closeable ([5]) improving the cache eviction even more.

As long as the object holding the cache is not referenced strongly outside
that reference loop (cache holder > cache > model > ... > cache holder),
then the loop's objects would be eligible for GC as soon as the cache
holder is eligible.

[1]:
https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/ref/SoftReference.html
[2]:
https://sling.apache.org/documentation/bundles/models.html#a-note-about-cache-true-and-using-the-self-injector
[3]: https://github.com/apache/sling-org-apache-sling-models-impl/pull/18
[4]:
https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L888
[5]:
https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L610

// Paul

On Tue, Jan 23, 2024 at 6:48 AM Jörg Hoh
wrote:

Hi Sling community,

I want to share a recent experience I had with Sling Models, Sling Model
caching and Garbage Collection problems.

I don't have a full explanation for this behavior yet. The Sling Models had
a reference to a ResourceResolver (which was properly closed), but I assume
that this reference somehow "disabled" the cleaning of the cache on major
GCs (as its a WeakHashMap), but tied the collection of these models to the
collection of the ResourceResolver objects, which have finalizers
registered. And finalizers are only executed under memory pressure. Having
this connetion might have led to the situation that the SlingModel objects
were not disposed eagerly, but only alongside the finalizers in situation
of high memory pressure in a "stop-the-world" situation.

I try to get some more examples for that behavior; but I am not sure of the
caching of Sling Models as-is is something we should continue to use. This
case was quite hard to crack, and I don't know if/how we can avoid such a
situation by design.

Jörg

--
https://cqdump.joe

Re: [VOTE] Release Apache Sling Commons Log 5.5.0

2024-01-29 Thread Carsten Ziegeler


+1

Carsten

On 29.01.2024 13:37, Robert Munteanu wrote:

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354154=Text

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2835/

You can use this UNIX script to download the release and verify the signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2835 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu


--
Carsten Ziegeler
Adobe
cziege...@apache.org

[jira] [Closed] (SLING-12238) Prevent NullPointerException if global transformer returns null

2024-01-27 Thread Carsten Ziegeler (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-12238.


> Prevent NullPointerException if global transformer returns null
> ---
>
> Key: SLING-12238
> URL: https://issues.apache.org/jira/browse/SLING-12238
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Rewriter 1.3.8
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Rewriter 1.3.10
>
>
> A TransformerFactory for a global transformer might return null for the 
> Transformer, similar the factory might already be gone. Both result in a null 
> value inserted into the array of global transformers.
> Later on, when that array is processed, there is no null check anymore. 
> Potentially resulting in a NullPointerException
> This should be guarded with a null check, as this might happen in a dynamic 
> system



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12239) Create string representation of processing component configuration only once

2024-01-27 Thread Carsten Ziegeler (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-12239.


> Create string representation of processing component configuration only once
> 
>
> Key: SLING-12239
> URL: https://issues.apache.org/jira/browse/SLING-12239
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Rewriter 1.3.8
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Rewriter 1.3.10
>
>
> With SLING-12227 the "caching" of the processing component configuration got 
> accidentally removed. As this one is printed out with each and every html 
> request, we should only create it once.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12233) Ignore resource type with invalid paths

2024-01-27 Thread Carsten Ziegeler (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-12233.


> Ignore resource type with invalid paths
> ---
>
> Key: SLING-12233
> URL: https://issues.apache.org/jira/browse/SLING-12233
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Resolver 2.10.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: servlets resolver 2.11.0
>
>
> Most invalid resource types are already ignored as it relies on 
> ResourceUtil.normalize. However, path segments with more than two consecutive 
> dots are currently not ignored, leading to unexpected results.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[VOTE RESULT] Release Apache Sling Rewriter 1.3.10

2024-01-27 Thread Carsten Ziegeler


The vote passed with four binding +1 votes

Thanks
Carsten

--
Carsten Ziegeler
Adobe
cziege...@apache.org

[VOTE RESULT] Release Apache Sling Servlets Resolver 2.11.0

2024-01-27 Thread Carsten Ziegeler


The vote passed with four binding +1 votes

Thanks
Carsten

--
Carsten Ziegeler
Adobe
cziege...@apache.org

Re: [VOTE] Release Apache Sling Servlets Resolver 2.11.0

2024-01-27 Thread Carsten Ziegeler


+1

Carsten

On 24.01.2024 14:56, Carsten Ziegeler wrote:

Hi,

We solved 1 issues in this release
https://issues.apache.org/jira/browse/SLING-12233


Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2834/


You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2834 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten


--
Carsten Ziegeler
Adobe
cziege...@apache.org

Re: [VOTE] Release Apache Sling Rewriter 1.3.10

2024-01-27 Thread Carsten Ziegeler


+1

Carsten

On 24.01.2024 07:07, Carsten Ziegeler wrote:

Hi,

We solved 2 issues in this release
https://issues.apache.org/jira/projects/SLING/versions/12354138


Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2833/


You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2833 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten


--
Carsten Ziegeler
Adobe
cziege...@apache.org

[VOTE] Release Apache Sling Servlets Resolver 2.11.0

2024-01-24 Thread Carsten Ziegeler


Hi,

We solved 1 issues in this release
https://issues.apache.org/jira/browse/SLING-12233


Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2834/


You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2834 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe
cziege...@apache.org

[VOTE] Release Apache Sling Rewriter 1.3.10

2024-01-23 Thread Carsten Ziegeler


Hi,

We solved 2 issues in this release
https://issues.apache.org/jira/projects/SLING/versions/12354138


Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2833/


You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2833 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe
cziege...@apache.org

[jira] [Resolved] (SLING-12239) Create string representation of processing component configuration only once



 [ 
https://issues.apache.org/jira/browse/SLING-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-12239.
--
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-rewriter/commit/7bbf8a52db191f2d59bc6c00fc86bf0a8235bf20

> Create string representation of processing component configuration only once
> 
>
> Key: SLING-12239
> URL: https://issues.apache.org/jira/browse/SLING-12239
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Rewriter 1.3.8
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Rewriter 1.3.10
>
>
> With SLING-12227 the "caching" of the processing component configuration got 
> accidentally removed. As this one is printed out with each and every html 
> request, we should only create it once.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12239) Create string representation of processing component configuration only once

Carsten Ziegeler created SLING-12239:


 Summary: Create string representation of processing component 
configuration only once
 Key: SLING-12239
 URL: https://issues.apache.org/jira/browse/SLING-12239
 Project: Sling
  Issue Type: Improvement
  Components: General
Affects Versions: Rewriter 1.3.8
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Rewriter 1.3.10


With SLING-12227 the "caching" of the processing component configuration got 
accidentally removed. As this one is printed out with each and every html 
request, we should only create it once.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12211) Update Parent to 52 and make build compatible with Java 17 and above



 [ 
https://issues.apache.org/jira/browse/SLING-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-12211:
-
Fix Version/s: Rewriter 1.3.12
   (was: Rewriter 1.3.10)

> Update Parent to 52 and make build compatible with Java 17 and above
> 
>
> Key: SLING-12211
> URL: https://issues.apache.org/jira/browse/SLING-12211
> Project: Sling
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Rewriter 1.3.12
>
>
> Updating to Parent 52 allows reproducible builds 
> (https://issues.apache.org/jira/browse/SLING-11907).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12238) Prevent NullPointerException if global transformer returns null



 [ 
https://issues.apache.org/jira/browse/SLING-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-12238.
--
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-rewriter/commit/bd45e2145a438899c487184ce388a579270495f0

> Prevent NullPointerException if global transformer returns null
> ---
>
> Key: SLING-12238
> URL: https://issues.apache.org/jira/browse/SLING-12238
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Rewriter 1.3.8
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Rewriter 1.3.10
>
>
> A TransformerFactory for a global transformer might return null for the 
> Transformer, similar the factory might already be gone. Both result in a null 
> value inserted into the array of global transformers.
> Later on, when that array is processed, there is no null check anymore. 
> Potentially resulting in a NullPointerException
> This should be guarded with a null check, as this might happen in a dynamic 
> system



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12238) Prevent NullPointerException if global transformer returns null

Carsten Ziegeler created SLING-12238:


 Summary: Prevent NullPointerException if global transformer 
returns null
 Key: SLING-12238
 URL: https://issues.apache.org/jira/browse/SLING-12238
 Project: Sling
  Issue Type: Improvement
  Components: General
Affects Versions: Rewriter 1.3.8
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Rewriter 1.3.10


A TransformerFactory for a global transformer might return null for the 
Transformer, similar the factory might already be gone. Both result in a null 
value inserted into the array of global transformers.
Later on, when that array is processed, there is no null check anymore. 
Potentially resulting in a NullPointerException
This should be guarded with a null check, as this might happen in a dynamic 
system



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12232) Remove usage of httpclient 5



 [ 
https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-12232.


> Remove usage of httpclient 5
> 
>
> Key: SLING-12232
> URL: https://issues.apache.org/jira/browse/SLING-12232
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Installer
>Affects Versions: Feature Model Unpack Extension 0.3.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Unpack Extension 0.4.0
>
>
> Version 0.3.0 introduced a dependency on httpclient5 which is not available 
> as an OSGi bundle. Therefore we should remove this dependency.
> It seems, httpclient is only used in order to implement a retry loop, this 
> can be done without using that dependency.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12232) Remove usage of httpclient 5



[ 
https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809472#comment-17809472
 ] 

Carsten Ziegeler commented on SLING-12232:
--

Applied PR which removes dependency to httpclient completely

> Remove usage of httpclient 5
> 
>
> Key: SLING-12232
> URL: https://issues.apache.org/jira/browse/SLING-12232
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Installer
>Affects Versions: Feature Model Unpack Extension 0.3.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Unpack Extension 0.4.0
>
>
> Version 0.3.0 introduced a dependency on httpclient5 which is not available 
> as an OSGi bundle. Therefore we should remove this dependency.
> It seems, httpclient is only used in order to implement a retry loop, this 
> can be done without using that dependency.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12232) Remove usage of httpclient 5



 [ 
https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-12232.
--
Resolution: Fixed

> Remove usage of httpclient 5
> 
>
> Key: SLING-12232
> URL: https://issues.apache.org/jira/browse/SLING-12232
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Installer
>Affects Versions: Feature Model Unpack Extension 0.3.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Unpack Extension 0.4.0
>
>
> Version 0.3.0 introduced a dependency on httpclient5 which is not available 
> as an OSGi bundle. Therefore we should remove this dependency.
> It seems, httpclient is only used in order to implement a retry loop, this 
> can be done without using that dependency.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12231) Replace javax.json with jakarta.json



 [ 
https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-12231.


> Replace javax.json with jakarta.json
> 
>
> Key: SLING-12231
> URL: https://issues.apache.org/jira/browse/SLING-12231
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Core 3.12.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.14.0
>
>
> We should replace the usage of javax.json with jakarta.json



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12097) Installer Core build fails with Java 17



 [ 
https://issues.apache.org/jira/browse/SLING-12097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-12097.


> Installer Core build fails with Java 17
> ---
>
> Key: SLING-12097
> URL: https://issues.apache.org/jira/browse/SLING-12097
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Installer Core 3.14.0
>
>
> [ERROR] Failed to execute goal 
> biz.aQute.bnd:bnd-maven-plugin:5.0.0:bnd-process (bnd-process) on project 
> org.apache.sling.installer.core: bnd error: null: 
> ConcurrentModificationException -> [Help 1]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[VOTE RESULT] Release Apache Sling Installer Core 3.14.0, Installer Factory Feature 0.8.0, Feature Extension Unpack 0.4.0

2024-01-22 Thread Carsten Ziegeler


The vote passed with three binding +1 votes

Thanks
Carsten

--
Carsten Ziegeler
Adobe
cziege...@apache.org

Re: [VOTE] Release Apache Sling Installer Core 3.14.0, Installer Factory Feature 0.8.0, Feature Extension Unpack 0.4.0

2024-01-21 Thread Carsten Ziegeler


+1

Carsten

On 19.01.2024 16:08, Carsten Ziegeler wrote:

Hi,

We solved 2 issues in installer core 3.14.0
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353713

We solved 1 issue for installer factory feature 0.8.0
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353494

We solved 2 issues for feature extension unpack 0.4.0
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12351328

Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2831/


You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2831 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten


--
Carsten Ziegeler
Adobe
cziege...@apache.org

[VOTE] Release Apache Sling Installer Core 3.14.0, Installer Factory Feature 0.8.0, Feature Extension Unpack 0.4.0

2024-01-19 Thread Carsten Ziegeler


Hi,

We solved 2 issues in installer core 3.14.0
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353713

We solved 1 issue for installer factory feature 0.8.0
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353494

We solved 2 issues for feature extension unpack 0.4.0
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12351328

Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2831/


You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2831 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe
cziege...@apache.org

[jira] [Closed] (SLING-11393) Escape characters in log entries



 [ 
https://issues.apache.org/jira/browse/SLING-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-11393.


> Escape characters in log entries
> 
>
> Key: SLING-11393
> URL: https://issues.apache.org/jira/browse/SLING-11393
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: Commons Log 5.4.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Commons Log 5.4.2
>
>
> We should escape some characters in log messages and exception messages for a 
> better output.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12232) Remove usage of httpclient 5



 [ 
https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-12232:
-
Description: 
Version 0.3.0 introduced a dependency on httpclient5 which is not available as 
an OSGi bundle. Therefore we should remove this dependency.
It seems, httpclient is only used in order to implement a retry loop, this can 
be done without using that dependency.

  was:Version 0.3.0 introduced a dependency on httpclient5 which is not 
available as an OSGi bundle. Therefore we should switch to httpclient4.


> Remove usage of httpclient 5
> 
>
> Key: SLING-12232
> URL: https://issues.apache.org/jira/browse/SLING-12232
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Installer
>Affects Versions: Feature Model Unpack Extension 0.3.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Unpack Extension 0.4.0
>
>
> Version 0.3.0 introduced a dependency on httpclient5 which is not available 
> as an OSGi bundle. Therefore we should remove this dependency.
> It seems, httpclient is only used in order to implement a retry loop, this 
> can be done without using that dependency.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12232) Remove usage of httpclient 5



 [ 
https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-12232:
-
Summary: Remove usage of httpclient 5  (was: Switch to Apache HttpClient 4)

> Remove usage of httpclient 5
> 
>
> Key: SLING-12232
> URL: https://issues.apache.org/jira/browse/SLING-12232
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Installer
>Affects Versions: Feature Model Unpack Extension 0.3.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Unpack Extension 0.4.0
>
>
> Version 0.3.0 introduced a dependency on httpclient5 which is not available 
> as an OSGi bundle. Therefore we should switch to httpclient4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12233) Ignore resource type with invalid paths



 [ 
https://issues.apache.org/jira/browse/SLING-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-12233.
--
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/b54d4e6693e0bcd63a97a0328f4f065b8a81b75e

> Ignore resource type with invalid paths
> ---
>
> Key: SLING-12233
> URL: https://issues.apache.org/jira/browse/SLING-12233
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Resolver 2.10.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: servlets resolver 2.11.0
>
>
> Most invalid resource types are already ignored as it relies on 
> ResourceUtil.normalize. However, path segments with more than two consecutive 
> dots are currently not ignored, leading to unexpected results.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12233) Ignore resource type with invalid paths

Carsten Ziegeler created SLING-12233:


 Summary: Ignore resource type with invalid paths
 Key: SLING-12233
 URL: https://issues.apache.org/jira/browse/SLING-12233
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
Affects Versions: Servlets Resolver 2.10.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: servlets resolver 2.11.0


Most invalid resource types are already ignored as it relies on 
ResourceUtil.normalize. However, path segments with more than two consecutive 
dots are currently not ignored, leading to unexpected results.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12232) Switch to Apache HttpClient 4

Carsten Ziegeler created SLING-12232:


 Summary: Switch to Apache HttpClient 4
 Key: SLING-12232
 URL: https://issues.apache.org/jira/browse/SLING-12232
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model, Installer
Affects Versions: Feature Model Unpack Extension 0.3.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Feature Model Unpack Extension 0.3.2


Version 0.3.0 introduced a dependency on httpclient5 which is not available as 
an OSGi bundle. Therefore we should switch to httpclient4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json



 [ 
https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-12231:
-
Affects Version/s: (was: Installer Factory Feature Model 0.7.0)

> Replace javax.json with jakarta.json
> 
>
> Key: SLING-12231
> URL: https://issues.apache.org/jira/browse/SLING-12231
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Core 3.12.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Factory Feature Model 0.8.0, Installer Core 
> 3.14.0
>
>
> We should replace the usage of javax.json with jakarta.json



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12231) Replace javax.json with jakarta.json



 [ 
https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-12231.
--
Resolution: Fixed

> Replace javax.json with jakarta.json
> 
>
> Key: SLING-12231
> URL: https://issues.apache.org/jira/browse/SLING-12231
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Core 3.12.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.14.0
>
>
> We should replace the usage of javax.json with jakarta.json



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json



 [ 
https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-12231:
-
Fix Version/s: (was: Installer Factory Feature Model 0.8.0)

> Replace javax.json with jakarta.json
> 
>
> Key: SLING-12231
> URL: https://issues.apache.org/jira/browse/SLING-12231
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Core 3.12.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.14.0
>
>
> We should replace the usage of javax.json with jakarta.json



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json



 [ 
https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-12231:
-
Fix Version/s: Installer Factory Feature Model 0.8.0

> Replace javax.json with jakarta.json
> 
>
> Key: SLING-12231
> URL: https://issues.apache.org/jira/browse/SLING-12231
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Core 3.12.0, Installer Factory Feature Model 
> 0.7.0
>    Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Factory Feature Model 0.8.0, Installer Core 
> 3.14.0
>
>
> We should replace the usage of javax.json with jakarta.json



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json



 [ 
https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-12231:
-
Affects Version/s: Installer Factory Feature Model 0.7.0

> Replace javax.json with jakarta.json
> 
>
> Key: SLING-12231
> URL: https://issues.apache.org/jira/browse/SLING-12231
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Core 3.12.0, Installer Factory Feature Model 
> 0.7.0
>    Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.14.0
>
>
> We should replace the usage of javax.json with jakarta.json



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12231) Replace javax.json with jakarta.json



[ 
https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808283#comment-17808283
 ] 

Carsten Ziegeler commented on SLING-12231:
--

Installer Core: 
https://github.com/apache/sling-org-apache-sling-installer-core/commit/ab56c53b4d0a5e9cb0fb5cfb6a1af465f5d80fef

> Replace javax.json with jakarta.json
> 
>
> Key: SLING-12231
> URL: https://issues.apache.org/jira/browse/SLING-12231
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Core 3.12.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.12.2
>
>
> We should replace the usage of javax.json with jakarta.json



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12231) Replace javax.json with jakarta.json

Carsten Ziegeler created SLING-12231:


 Summary: Replace javax.json with jakarta.json
 Key: SLING-12231
 URL: https://issues.apache.org/jira/browse/SLING-12231
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: Installer Core 3.12.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Installer Core 3.12.2






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json



 [ 
https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-12231:
-
Description: We should replace the usage of javax.json with jakarta.json

> Replace javax.json with jakarta.json
> 
>
> Key: SLING-12231
> URL: https://issues.apache.org/jira/browse/SLING-12231
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Core 3.12.0
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.12.2
>
>
> We should replace the usage of javax.json with jakarta.json



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12228) Status printer does not display global transformers



 [ 
https://issues.apache.org/jira/browse/SLING-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-12228.


> Status printer does not display global transformers
> ---
>
> Key: SLING-12228
> URL: https://issues.apache.org/jira/browse/SLING-12228
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Rewriter 1.3.6
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Rewriter 1.3.8
>
>
> Global transformers are currently not displayed at all on the status report



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12227) Status printer does not properly display array values



 [ 
https://issues.apache.org/jira/browse/SLING-12227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-12227.


> Status printer does not properly display array values
> -
>
> Key: SLING-12227
> URL: https://issues.apache.org/jira/browse/SLING-12227
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Rewriter 1.3.6
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Rewriter 1.3.8
>
>
> The status printer for the pipeline components does not properly display 
> array values, for example the current output looks like this:
> {noformat}
> Pipeline : 
> Generator : 
> htmlparser : {includeTags=[Ljava.lang.String;@19a2db46}
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12230) Replace usage of Sling Commons OSGi with OSGi converter



 [ 
https://issues.apache.org/jira/browse/SLING-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-12230.


> Replace usage of Sling Commons OSGi with OSGi converter
> ---
>
> Key: SLING-12230
> URL: https://issues.apache.org/jira/browse/SLING-12230
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>    Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Rewriter 1.3.8
>
>
> We should replace the usage of Sling Commons OSGi with the OSGi converter to 
> remove all usage of commons osgi.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling Rewriter 1.3.8

2024-01-18 Thread Carsten Ziegeler


+1

Carsten

On 15.01.2024 10:58, Carsten Ziegeler wrote:

Hi,

We solved 3 issues in this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354083

Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2828/


You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2828 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten


--
Carsten Ziegeler
Adobe
cziege...@apache.org

[VOTE RESULT] Release Apache Sling Rewriter 1.3.8

2024-01-18 Thread Carsten Ziegeler




The vote passed with four binding +1 votes

Thanks
Carsten

--
Carsten Ziegeler
Adobe
cziege...@apache.org

Re: Order of steps in https://sling.apache.org/documentation/development/release-management.html

2024-01-17 Thread Carsten Ziegeler

I think there is no perfect solution. We are operating this way for many 
years :) which of course doesn't mean there is no room for improvement.


I think the scenario you describe happened at least once. but it was 
detected when the version was released, the jira issue corrected and all 
was good. This requires a little care of the release manager. but it 
really is more a theoretical issue. We have all the notifications flying 
around and usually if you are working on something you know that there 
is a vote for it going on.


The Oak way shows a version as released although it is not, and might 
never be - which at least in theory can create confusion to users.


So I prefer potentially confused release managers over potentially 
confused users :)


Regards
Carsten

On 17.01.2024 11:02, Julian Reschke wrote:

Hi there,

the "Release Management" document suggests adding a new (next) release
should happen after the release vote, and that the release being voted
on remains "unreleased" in the meantime.

Doesn't that leave us with a time windos of 72h+ hours in which issue
tracking in Jira will be extremely ... awkward? What happens if somebody
resolves an issue and enters the release currently under vote as
"fixVersion"?

(In Oak land, we do it the other way around; we create the "next"
release first, and make the release being voted on as "released" when
the vote starts).

Best regards, Julian


--
Carsten Ziegeler
Adobe
cziege...@apache.org

Re: [VOTE] Release Apache Sling Testing Clients 3.0.22

2024-01-15 Thread Carsten Ziegeler


+1

Carsten

On 15.01.2024 11:08, Andrei Dulvac wrote:

Hi,

We solved 5 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12353709

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2829/

You can use this UNIX script to download the release and verify the
signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2829 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

- Andrei



--
Carsten Ziegeler
Adobe
cziege...@apache.org

[VOTE] Release Apache Sling Rewriter 1.3.8

2024-01-15 Thread Carsten Ziegeler


Hi,

We solved 3 issues in this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354083

Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2828/


You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2828 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe
cziege...@apache.org

[jira] [Updated] (SLING-12211) Update Parent to 52 and make build compatible with Java 17 and above



 [ 
https://issues.apache.org/jira/browse/SLING-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-12211:
-
Fix Version/s: Rewriter 1.3.10
   (was: Rewriter 1.3.8)

> Update Parent to 52 and make build compatible with Java 17 and above
> 
>
> Key: SLING-12211
> URL: https://issues.apache.org/jira/browse/SLING-12211
> Project: Sling
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Rewriter 1.3.10
>
>
> Updating to Parent 52 allows reproducible builds 
> (https://issues.apache.org/jira/browse/SLING-11907).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12230) Replace usage of Sling Commons OSGi with OSGi converter



 [ 
https://issues.apache.org/jira/browse/SLING-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-12230.
--
Resolution: Fixed

Changed in 
https://github.com/apache/sling-org-apache-sling-rewriter/commit/2960e0b480f53308a7184dc63dc45b958b46e6e6

> Replace usage of Sling Commons OSGi with OSGi converter
> ---
>
> Key: SLING-12230
> URL: https://issues.apache.org/jira/browse/SLING-12230
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>    Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Rewriter 1.3.8
>
>
> We should replace the usage of Sling Commons OSGi with the OSGi converter to 
> remove all usage of commons osgi.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12230) Replace usage of Sling Commons OSGi with OSGi converter

Carsten Ziegeler created SLING-12230:


 Summary: Replace usage of Sling Commons OSGi with OSGi converter
 Key: SLING-12230
 URL: https://issues.apache.org/jira/browse/SLING-12230
 Project: Sling
  Issue Type: Improvement
  Components: General
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Rewriter 1.3.8


We should replace the usage of Sling Commons OSGi with the OSGi converter to 
remove all usage of commons osgi.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12228) Status printer does not display global transformers



 [ 
https://issues.apache.org/jira/browse/SLING-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-12228.
--
  Assignee: Carsten Ziegeler
Resolution: Fixed

Fixed in 
https://github.com/apache/sling-org-apache-sling-rewriter/commit/5ef0f8e0fe857fe03a5e1770838359fb654ecb1f

> Status printer does not display global transformers
> ---
>
> Key: SLING-12228
> URL: https://issues.apache.org/jira/browse/SLING-12228
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Rewriter 1.3.6
>Reporter: Carsten Ziegeler
>    Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Rewriter 1.3.8
>
>
> Global transformers are currently not displayed at all on the status report



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12227) Status printer does not properly display array values