[jira] [Commented] (SLING-6126) Ability to specify TTL for separate health check

2016-10-13 Thread Evgeniy Fitsner (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573362#comment-15573362
 ] 

Evgeniy Fitsner commented on SLING-6126:


Dear [~gehen],

Thanks for support but another reason why I've asked for this option in that 
I'm working with Adobe AEM and here all health checks are displaying on the 
board with status color, so user can simply check that all is green and that's 
it (simple and fast). Sure, we can every time check in console with 
"/system/console/healthcheck?tags=project_tag=5" but 
more simply to allow specify directly in class metadata special TTL value.

I've updated code in [PR|https://github.com/apache/sling/pull/180], so please 
let me know if smth else should be updated.

> Ability to specify TTL for separate health check
> 
>
> Key: SLING-6126
> URL: https://issues.apache.org/jira/browse/SLING-6126
> Project: Sling
>  Issue Type: Improvement
>  Components: Health Check
>Reporter: Evgeniy Fitsner
>
> Currently there is no ability to specify TTL for separate health check.
> Ex.: in my case "hc" validating against repository about 3-5 minutes 
> therefore I couldn't specify TTL globally to not impact on other "hc" 
> results. This "hc" I couldn't execute by scheduler to prevent CPU from high 
> loading, also results for this check remains relevant for an 1-3 hours.
> Therefore if it make sense not only for me I've added "[pull 
> request|https://github.com/apache/sling/pull/180]; for this functionality:
> * If property "hc.ttl" specified within HC - it will be used as TTL for 
> result, otherwise cache will use default TTL value



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6126) Ability to specify TTL for separate health check

2016-10-11 Thread Evgeniy Fitsner (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564657#comment-15564657
 ] 

Evgeniy Fitsner commented on SLING-6126:


Dear [~henzlerg],

Suddenly but this is not an option in my case, because we have a deployment 
every 3 weeks. After deployment DevOps should check that instance is working 
w/o errors therefore they will check "hc" 1,2,3,...,n times to validate that 
instance is working (I'm not sure how often this heavy "hc" will be executed 
but I know that  "hc" enough expensive to CPU/Memory resources, approximately 
"hc" execution time (3 min) and period in which "hc" result will be 
relevant(approximately 30min)). In case of "hc" fail between deployments we 
need to execute it once again immediately after environment repair rather than 
wait next scheduled execution.

So for case above it's OK if user try to execute "hc", then wait a little (for 
example 5 minutes to complete all "hc") and execute "hc" again - in this case 
user will see cached relevant results immediately.

In my pull request I've only added global TTL override if service contains 
HealthCheck.TTL property.

> Ability to specify TTL for separate health check
> 
>
> Key: SLING-6126
> URL: https://issues.apache.org/jira/browse/SLING-6126
> Project: Sling
>  Issue Type: Improvement
>  Components: Health Check
>Reporter: Evgeniy Fitsner
>
> Currently there is no ability to specify TTL for separate health check.
> Ex.: in my case "hc" validating against repository about 3-5 minutes 
> therefore I couldn't specify TTL globally to not impact on other "hc" 
> results. This "hc" I couldn't execute by scheduler to prevent CPU from high 
> loading, also results for this check remains relevant for an 1-3 hours.
> Therefore if it make sense not only for me I've added "[pull 
> request|https://github.com/apache/sling/pull/180]; for this functionality:
> * If property "hc.ttl" specified within HC - it will be used as TTL for 
> result, otherwise cache will use default TTL value



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-6126) Ability to specify TTL for separate health check

2016-10-10 Thread Evgeniy Fitsner (JIRA)
Evgeniy Fitsner created SLING-6126:
--

 Summary: Ability to specify TTL for separate health check
 Key: SLING-6126
 URL: https://issues.apache.org/jira/browse/SLING-6126
 Project: Sling
  Issue Type: Improvement
  Components: Health Check
Reporter: Evgeniy Fitsner


Currently there is no ability to specify TTL for separate health check.

Ex.: in my case "hc" validating against repository about 3-5 minutes therefore 
I couldn't specify TTL globally to not impact on other "hc" results. This "hc" 
I couldn't execute by scheduler to prevent CPU from high loading, also results 
for this check remains relevant for an 1-3 hours.

Therefore if it make sense not only for me I've added "[pull 
request|https://github.com/apache/sling/pull/180]; for this functionality:
* If property "hc.ttl" specified within HC - it will be used as TTL for result, 
otherwise cache will use default TTL value




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)