[jira] [Updated] (SLING-12402) ResourceResolver: add additional log entry when there are many conflicting or invalid aliases (also add metrics)

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12402:
---
Fix Version/s: Resource Resolver 1.12.4

> ResourceResolver: add additional log entry when there are many conflicting or 
> invalid aliases (also add metrics)
> 
>
> Key: SLING-12402
> URL: https://issues.apache.org/jira/browse/SLING-12402
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>    Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Minor
> Fix For: Resource Resolver 1.12.4
>
>
> ...and also add metrics for invalid/conflicting aliases.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[VOTE] Release Apache Sling Resource Resolver version 1.12.2

[Julian Reschke]

Hi,

We solved 4 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12355007

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2888

You can use this UNIX script to download the release and verify the
signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2888 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Best regards, Julian

[jira] [Created] (SLING-12439) repoinit allows invalid namespace names (URIs)

[Julian Reschke (Jira)]

Julian Reschke created SLING-12439:
--

 Summary: repoinit allows invalid namespace names (URIs)
 Key: SLING-12439
 URL: https://issues.apache.org/jira/browse/SLING-12439
 Project: Sling
  Issue Type: Bug
  Components: Repoinit
Reporter: Julian Reschke


In JCR, a namespace name is defined to be an absolute URI (see 
<https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/3_Repository_Model.html#3.2%20Names>)

Repoinit, however, seems to allow "simple" names such as "foo".

These names break in the JCR API, because it will assume that "{foo}bar" will 
parse as "local" name, not an expanded name (in the namespace "foo").

Optimally, these would be rejected, but I assume that'll break compatibilty.

Maybe the documentation could be improved and/or a warning be generated?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12402) ResourceResolver: add additional log entry when there are many conflicting or invalid aliases (also add metrics)

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12402:
---
Summary: ResourceResolver: add additional log entry when there are many 
conflicting or invalid aliases (also add metrics)  (was: ResourceResolver: add 
additional log entry when there are many duplicate or invalid aliases)

> ResourceResolver: add additional log entry when there are many conflicting or 
> invalid aliases (also add metrics)
> 
>
> Key: SLING-12402
> URL: https://issues.apache.org/jira/browse/SLING-12402
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>    Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Minor
>
> ...and also add metrics for invalid/conflicting aliases.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-12402) ResourceResolver: add additional log entry when there are many duplicate or invalid aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke reassigned SLING-12402:
--

Assignee: Julian Reschke

> ResourceResolver: add additional log entry when there are many duplicate or 
> invalid aliases
> ---
>
> Key: SLING-12402
> URL: https://issues.apache.org/jira/browse/SLING-12402
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>    Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12402) ResourceResolver: add additional log entry when there are many duplicate or invalid aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12402:
---
Description: ...and also add metrics for invalid/conflicting aliases.

> ResourceResolver: add additional log entry when there are many duplicate or 
> invalid aliases
> ---
>
> Key: SLING-12402
> URL: https://issues.apache.org/jira/browse/SLING-12402
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>    Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Minor
>
> ...and also add metrics for invalid/conflicting aliases.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-12400) ResourceResolver: add test coverage for aliases on jcr:content nodes

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke reassigned SLING-12400:
--

Assignee: Julian Reschke

> ResourceResolver: add test coverage for aliases on jcr:content nodes
> 
>
> Key: SLING-12400
> URL: https://issues.apache.org/jira/browse/SLING-12400
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Major
>
> These are special in that the alias is apparently added to the parent node 
> (which needs to be documented and tested).
> Also, we do have quite some code duplication between {{loadAlias}} and 
> {{doUpdateAliase}}. This should be reduced. FWIW, there maybe non-optimal 
> overlaps in the handling of {{jcr:content}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12399) ResourceResolver: revise handling of empty aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved SLING-12399.

Fix Version/s: Resource Resolver 1.12.2
   Resolution: Fixed

> ResourceResolver: revise handling of empty aliases
> --
>
> Key: SLING-12399
> URL: https://issues.apache.org/jira/browse/SLING-12399
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Major
> Fix For: Resource Resolver 1.12.2
>
>
> ...and either document what they mean (see 
> https://github.com/apache/sling-site/edit/master/src/main/jbake/content/documentation/the-sling-engine/mappings-for-resource-resolution.md),
>  or disallow them in 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/428f8a7d5b8f3621c525e3c8782eb1e2586d1f5a/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1300



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12399) ResourceResolver: revise handling of empty aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12399:
---
Description: ...and either document what they mean (see 
https://github.com/apache/sling-site/edit/master/src/main/jbake/content/documentation/the-sling-engine/mappings-for-resource-resolution.md),
 or disallow them in 
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/428f8a7d5b8f3621c525e3c8782eb1e2586d1f5a/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1300
  (was: ...and either document what they mean, or disallow them in 
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/428f8a7d5b8f3621c525e3c8782eb1e2586d1f5a/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1300)

> ResourceResolver: revise handling of empty aliases
> --
>
> Key: SLING-12399
> URL: https://issues.apache.org/jira/browse/SLING-12399
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Major
>
> ...and either document what they mean (see 
> https://github.com/apache/sling-site/edit/master/src/main/jbake/content/documentation/the-sling-engine/mappings-for-resource-resolution.md),
>  or disallow them in 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/428f8a7d5b8f3621c525e3c8782eb1e2586d1f5a/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1300



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12412) ResourceResolver: add test coverage for empty aliases, blank aliases, and invalid aliases

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875867#comment-17875867
 ] 

Julian Reschke commented on SLING-12412:


(note: documention page at 
[https://sling.apache.org/documentation/the-sling-engine/mappings-for-resource-resolution.html#alias-configurations-1]
 needs separate PR)

> ResourceResolver: add test coverage for empty aliases, blank aliases, and 
> invalid aliases
> -
>
> Key: SLING-12412
> URL: https://issues.apache.org/jira/browse/SLING-12412
> Project: Sling
>  Issue Type: Sub-task
>  Components: ResourceResolver
>    Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: Resource Resolver 1.12.2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12412) ResourceResolver: add test coverage for empty aliases, blank aliases, and invalid aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved SLING-12412.

Fix Version/s: Resource Resolver 1.12.2
   Resolution: Fixed

> ResourceResolver: add test coverage for empty aliases, blank aliases, and 
> invalid aliases
> -
>
> Key: SLING-12412
> URL: https://issues.apache.org/jira/browse/SLING-12412
> Project: Sling
>  Issue Type: Sub-task
>  Components: ResourceResolver
>    Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Minor
> Fix For: Resource Resolver 1.12.2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875852#comment-17875852
 ] 

Julian Reschke commented on SLING-12025:


...in the meantime I understood that, other than for vanity paths, there is no 
size limit for the alias cache.

 

> ResourceResolver: different mapping when optimizedAliasResolution enabled
> -
>
> Key: SLING-12025
> URL: https://issues.apache.org/jira/browse/SLING-12025
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Resource Resolver 1.11.2
>
>
> I found that the there is a different behavior in case the "optimized alias 
> resolution is enabled.
> Setup:
> {noformat}
> * /content/jcr:content
>   + sling:alias=foobar
> {noformat}
> In my opinion the expected behavior is that the {{content}} resource is 
> aliased and can be resolved via both {{/content}} and {{/foobar}}. You cannot 
> alias the {{jcr:content}} node. Unfortunately there are no unit tests for 
> that, and I just came across that behavior when I tried to write one.
> This works with the "optimized alias resolution" feature turned on, but if 
> it's turned off, it does not work anymore, and you can resolve that resource 
> only via its name. (In that case I assume that the jcr:content resource is 
> aliased.)
> I created 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to 
> demonstrate this problem.
> Is my assumption about the behavior correct?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875771#comment-17875771
 ] 

Julian Reschke commented on SLING-12025:


Maybe I'm missing something, but the "non-optimized" lookup is still required 
when the number of aliases exceeds the cache size, no?

> ResourceResolver: different mapping when optimizedAliasResolution enabled
> -
>
> Key: SLING-12025
> URL: https://issues.apache.org/jira/browse/SLING-12025
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Resource Resolver 1.11.2
>
>
> I found that the there is a different behavior in case the "optimized alias 
> resolution is enabled.
> Setup:
> {noformat}
> * /content/jcr:content
>   + sling:alias=foobar
> {noformat}
> In my opinion the expected behavior is that the {{content}} resource is 
> aliased and can be resolved via both {{/content}} and {{/foobar}}. You cannot 
> alias the {{jcr:content}} node. Unfortunately there are no unit tests for 
> that, and I just came across that behavior when I tried to write one.
> This works with the "optimized alias resolution" feature turned on, but if 
> it's turned off, it does not work anymore, and you can resolve that resource 
> only via its name. (In that case I assume that the jcr:content resource is 
> aliased.)
> I created 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to 
> demonstrate this problem.
> Is my assumption about the behavior correct?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875466#comment-17875466
 ] 

Julian Reschke commented on SLING-12025:


Don't we need the non-optimized lookup once the cache overflows?

> ResourceResolver: different mapping when optimizedAliasResolution enabled
> -
>
> Key: SLING-12025
> URL: https://issues.apache.org/jira/browse/SLING-12025
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Resource Resolver 1.11.2
>
>
> I found that the there is a different behavior in case the "optimized alias 
> resolution is enabled.
> Setup:
> {noformat}
> * /content/jcr:content
>   + sling:alias=foobar
> {noformat}
> In my opinion the expected behavior is that the {{content}} resource is 
> aliased and can be resolved via both {{/content}} and {{/foobar}}. You cannot 
> alias the {{jcr:content}} node. Unfortunately there are no unit tests for 
> that, and I just came across that behavior when I tried to write one.
> This works with the "optimized alias resolution" feature turned on, but if 
> it's turned off, it does not work anymore, and you can resolve that resource 
> only via its name. (In that case I assume that the jcr:content resource is 
> aliased.)
> I created 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to 
> demonstrate this problem.
> Is my assumption about the behavior correct?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-12412) ResourceResolver: add test coverage for empty aliases, blank aliases, and invalid aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke reassigned SLING-12412:
--

Assignee: Julian Reschke

> ResourceResolver: add test coverage for empty aliases, blank aliases, and 
> invalid aliases
> -
>
> Key: SLING-12412
> URL: https://issues.apache.org/jira/browse/SLING-12412
> Project: Sling
>  Issue Type: Sub-task
>  Components: ResourceResolver
>    Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12412) ResourceResolver: add test coverage for empty aliases, blank aliases, and invalid aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12412:
---
Summary: ResourceResolver: add test coverage for empty aliases, blank 
aliases, and invalid aliases  (was: ResourceResolver: add test coverage for 
empty aliases)

> ResourceResolver: add test coverage for empty aliases, blank aliases, and 
> invalid aliases
> -
>
> Key: SLING-12412
> URL: https://issues.apache.org/jira/browse/SLING-12412
> Project: Sling
>  Issue Type: Sub-task
>  Components: ResourceResolver
>    Reporter: Julian Reschke
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12412) ResourceResolver: add test coverage for empty aliases

[Julian Reschke (Jira)]

Julian Reschke created SLING-12412:
--

 Summary: ResourceResolver: add test coverage for empty aliases
 Key: SLING-12412
 URL: https://issues.apache.org/jira/browse/SLING-12412
 Project: Sling
  Issue Type: Sub-task
  Components: ResourceResolver
Reporter: Julian Reschke






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12399) ResourceResolver: revise handling of empty aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12399:
---
Summary: ResourceResolver: revise handling of empty aliases  (was: 
ResourceResolver: add test coverage for empty aliases)

> ResourceResolver: revise handling of empty aliases
> --
>
> Key: SLING-12399
> URL: https://issues.apache.org/jira/browse/SLING-12399
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Major
>
> ...and either document what they mean, or disallow them in 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/428f8a7d5b8f3621c525e3c8782eb1e2586d1f5a/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1300



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-12399) ResourceResolver: add test coverage for empty aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke reassigned SLING-12399:
--

Assignee: Julian Reschke

> ResourceResolver: add test coverage for empty aliases
> -
>
> Key: SLING-12399
> URL: https://issues.apache.org/jira/browse/SLING-12399
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Major
>
> ...and either document what they mean, or disallow them in 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/428f8a7d5b8f3621c525e3c8782eb1e2586d1f5a/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1300



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11800) resource resolver: optionally run initial alias query asynchronously

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874009#comment-17874009
 ] 

Julian Reschke commented on SLING-11800:


We dismissed the idea of caching aliases in a persisted resource for vanity 
paths, due to complexity (such as service user being needed to write it, and 
lack of compleness when new nodes are added while the node restarts).

The proposed solution is to replicate what we did for vanity paths: running the 
cache init async. The problem with that - other than for vanity paths - is that 
the fallback query we would need to use during cache init is much slower.

> resource resolver: optionally run initial alias query asynchronously
> 
>
> Key: SLING-11800
> URL: https://issues.apache.org/jira/browse/SLING-11800
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.8.6
>    Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>
> ...to avoid slow startup in presence of many alias resources.
> (add OSGi switch and keep the old behavior as default for now)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (SLING-11800) resource resolver: optionally run initial alias query asynchronously

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874009#comment-17874009
 ] 

Julian Reschke edited comment on SLING-11800 at 8/15/24 4:50 PM:
-

The proposed solution is to replicate what we did for vanity paths: running the 
cache init async. The problem with that - other than for vanity paths - is that 
the fallback query we would need to use during cache init is much slower.


was (Author: reschke):
We dismissed the idea of caching aliases in a persisted resource for vanity 
paths, due to complexity (such as service user being needed to write it, and 
lack of compleness when new nodes are added while the node restarts).

The proposed solution is to replicate what we did for vanity paths: running the 
cache init async. The problem with that - other than for vanity paths - is that 
the fallback query we would need to use during cache init is much slower.

> resource resolver: optionally run initial alias query asynchronously
> 
>
> Key: SLING-11800
> URL: https://issues.apache.org/jira/browse/SLING-11800
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.8.6
>    Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>
> ...to avoid slow startup in presence of many alias resources.
> (add OSGi switch and keep the old behavior as default for now)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12400) ResourceResolver: add test coverage for aliases on jcr:content nodes

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12400:
---
Summary: ResourceResolver: add test coverage for aliases on jcr:content 
nodes  (was: ResourceResolver: add test coverage aliases on jcr:content nodes)

> ResourceResolver: add test coverage for aliases on jcr:content nodes
> 
>
> Key: SLING-12400
> URL: https://issues.apache.org/jira/browse/SLING-12400
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>        Reporter: Julian Reschke
>Priority: Major
>
> These are special in that the alias is apparently added to the parent node 
> (which needs to be documented and tested).
> Also, we do have quite some code duplication between {{loadAlias}} and 
> {{doUpdateAliase}}. This should be reduced. FWIW, there maybe non-optimal 
> overlaps in the handling of {{jcr:content}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12401) ResourceResolver: MapEntries.isAliasValid() misnamed

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved SLING-12401.

Fix Version/s: Resource Resolver 1.12.2
   Resolution: Fixed

> ResourceResolver: MapEntries.isAliasValid() misnamed
> 
>
> Key: SLING-12401
> URL: https://issues.apache.org/jira/browse/SLING-12401
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Trivial
> Fix For: Resource Resolver 1.12.2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12382) Potential concurrency issues with resource provider registration/unregistration

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed SLING-12382.
--

> Potential concurrency issues with resource provider 
> registration/unregistration
> ---
>
> Key: SLING-12382
> URL: https://issues.apache.org/jira/browse/SLING-12382
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.11.6
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Resource Resolver 1.12.0
>
>
> With SLING-6943 (and follow up issues) we removed larger synchronized blocks 
> in favour if smaller ones to not call to the service registry from within a 
> synchronized blocks.
> However, this split up synchronization might lead to concurrency issues - the 
> code that got split up into smaller sync blocks still expects that no one 
> interferes while all the blocks are executed.
> As that might happen, this results in the code making wrong expectations.
> We probably need to get back to large sync'ed blocks and call the service 
> registry from within.
> Update: the code is actually written with the exceptional case in mind (two 
> providers for the same path) - only for that case the lazy getting of 
> services makes sense. As the normal use case requires the service anyway, we 
> can avoid calling to the service registry from within the sync blocks - 
> punishing the exceptional case with potentially unnecessary fetched providers



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12129) Fix javadoc warnings

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed SLING-12129.
--

> Fix javadoc warnings
> 
>
> Key: SLING-12129
> URL: https://issues.apache.org/jira/browse/SLING-12129
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.11.2
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Minor
> Fix For: Resource Resolver 1.12.0
>
>
> ``mvn javadoc:javadoc`` logs a lot of warnings, which pollutes the maven 
> output during the release process.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12387) ResourceResolver: improve test coverage for PagedQueryIterator

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed SLING-12387.
--

> ResourceResolver: improve test coverage for PagedQueryIterator
> --
>
> Key: SLING-12387
> URL: https://issues.apache.org/jira/browse/SLING-12387
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Major
> Fix For: Resource Resolver 1.12.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12389) All resource resolver operations should check for a closed

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed SLING-12389.
--

> All resource resolver operations should check for a closed
> --
>
> Key: SLING-12389
> URL: https://issues.apache.org/jira/browse/SLING-12389
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.11.6
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Resource Resolver 1.12.0
>
>
> Although the API javadoc mentions for all operations that the resource 
> resolver throws an exception if a method is called and it is already closed, 
> not all operations actually perform this check.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12383) ResourceResolver: potential NPE while processing aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed SLING-12383.
--

> ResourceResolver: potential NPE while processing aliases
> 
>
> Key: SLING-12383
> URL: https://issues.apache.org/jira/browse/SLING-12383
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.11.6
>    Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Major
> Fix For: Resource Resolver 1.12.0
>
>
> Seen in production:
>  
> {noformat}
> ERROR [ResourceResolverFactory registration]
>  org.apache.sling.resourceresolver.impl.mapping.MapEntries Unexpected 
> problem during initialization of optimize alias resolution. Therefore 
> disabling optimize alias resolution. Please fix the problem.
> java.lang.NullPointerException: null
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadAlias(MapEntries.java:1226)
>  [org.apache.sling.resourceresolver:1.11.6]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadAliases(MapEntries.java:1173)
>  [org.apache.sling.resourceresolver:1.11.6]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.doInit(MapEntries.java:241)
>  [org.apache.sling.resourceresolver:1.11.6] {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12381) Always clear provider context on deactivate

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed SLING-12381.
--

> Always clear provider context on deactivate
> ---
>
> Key: SLING-12381
> URL: https://issues.apache.org/jira/browse/SLING-12381
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.11.6
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Resource Resolver 1.12.0
>
>
> The provider context is only cleared in deactivate if a provider has been set 
> before. However, we should always clear this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12371) Always update the metric for unclosed ResourceResolvers

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed SLING-12371.
--

> Always update the metric for unclosed ResourceResolvers
> ---
>
> Key: SLING-12371
> URL: https://issues.apache.org/jira/browse/SLING-12371
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Resource Resolver 1.12.0
>
>
> Right now the metric 
> "sling:org.apache.sling.resourceresolver.unclosedResourceResolvers" is only 
> updated when the configuration "logUnclosedResolvers" is enabled, which is 
> not always the case.
> But the metric should be updated even if this setting is not enabled.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12384) ResourceResolver: paged query for sling:alias will miss entries

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed SLING-12384.
--

> ResourceResolver: paged query for sling:alias will miss entries
> ---
>
> Key: SLING-12384
> URL: https://issues.apache.org/jira/browse/SLING-12384
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Resource Resolver 1.11.6
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Major
> Fix For: Resource Resolver 1.12.0
>
>
> Initially I thought that the issue just applies to empty alias values, 
> because the paged query will always skip them, due to the first query being 
> "{{{}first(sling:alias) > ''{}}}".
> Closer inspection showed that the pageing logic was flawed:
>  * read values until pageSize is exceeded *and* a new key value _x_ is reached
>  * start a new query with condition {{> x}}
> This worked mostly ok with vanity paths, where the search key 
> "first(sling:vanityPath)" almost always changes (having the same value for 
> many resources will only lead to one working vanity path, because the same 
> path cannot map to multiple resources).
> For aliases the situations is different, because their value is locally 
> scoped to the collection the aliased resource appears in. So we could have 
> 1 resources with the _same_ set of aliases (think translations or 
> shortcuts), and in cases like these, the page size (right now 2000) would be 
> exceeded.
> The proposed change is:
>  * always use ">=" so the initial page contains the empty-valued properties 
> as well
>  * when page size is exceeded and a new key _y_ is found, do not include the 
> last result, but execute a new query right away (with the proper condition so 
> that all resources with "{{first(sling:alias) >= y}}" are returned)
>  * also add more diagnostics, which may help to diagnose pacge size / query 
> limit issues early
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[RESULT] [VOTE] Apache Sling ResourceResolver 1.12.0

[Julian Reschke]

On 05.08.2024 17:42, Julian Reschke wrote:

...


Hi,

Hi,

The vote has passed with the following result :

+1 (binding): Carsten Ziegeler, Jörg Hoh, Julian Reschke

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Best regards, Julian

[jira] [Comment Edited] (SLING-12401) ResourceResolver: MapEntries.isAliasValid() misnamed

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871579#comment-17871579
 ] 

Julian Reschke edited comment on SLING-12401 at 8/7/24 8:56 AM:


The method actually returns {{true}} when the alias is invalid (the callers 
deal with it, but this causes major confusion when reading the code).


was (Author: reschke):
The method actually checks returns {{true}} when the alias is invalid (the 
callers deal with it, but this causes major confusion when reading the code).

> ResourceResolver: MapEntries.isAliasValid() misnamed
> 
>
> Key: SLING-12401
> URL: https://issues.apache.org/jira/browse/SLING-12401
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>    Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Trivial
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12402) ResourceResolver: add additional log entry when there are many duplicate or invalid aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12402:
---
Summary: ResourceResolver: add additional log entry when there are many 
duplicate or invalid aliases  (was: Res)

> ResourceResolver: add additional log entry when there are many duplicate or 
> invalid aliases
> ---
>
> Key: SLING-12402
> URL: https://issues.apache.org/jira/browse/SLING-12402
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>    Reporter: Julian Reschke
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12402) Res

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12402:
---
Component/s: ResourceResolver

> Res
> ---
>
> Key: SLING-12402
> URL: https://issues.apache.org/jira/browse/SLING-12402
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>        Reporter: Julian Reschke
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12401) ResourceResolver: MapEntries.isAliasValid() misnamed

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12401:
---
Summary: ResourceResolver: MapEntries.isAliasValid() misnamed  (was: 
ResourceResolver: MapEntries.isAliasValid misnamed)

> ResourceResolver: MapEntries.isAliasValid() misnamed
> 
>
> Key: SLING-12401
> URL: https://issues.apache.org/jira/browse/SLING-12401
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Trivial
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12401) ResourceResolver: MapEntries.isAliasValid misnamed

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12401:
---
Component/s: ResourceResolver

> ResourceResolver: MapEntries.isAliasValid misnamed
> --
>
> Key: SLING-12401
> URL: https://issues.apache.org/jira/browse/SLING-12401
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Trivial
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12402) ResourceResolver: add additional log entry when there are many duplicate or invalid aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12402:
---
Priority: Minor  (was: Major)

> ResourceResolver: add additional log entry when there are many duplicate or 
> invalid aliases
> ---
>
> Key: SLING-12402
> URL: https://issues.apache.org/jira/browse/SLING-12402
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>    Reporter: Julian Reschke
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12402) Res

[Julian Reschke (Jira)]

Julian Reschke created SLING-12402:
--

 Summary: Res
 Key: SLING-12402
 URL: https://issues.apache.org/jira/browse/SLING-12402
 Project: Sling
  Issue Type: Improvement
Reporter: Julian Reschke






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12401) ResourceResolver: MapEntries.isAliasValid misnamed

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12401:
---
Summary: ResourceResolver: MapEntries.isAliasValid misnamed  (was: Res)

> ResourceResolver: MapEntries.isAliasValid misnamed
> --
>
> Key: SLING-12401
> URL: https://issues.apache.org/jira/browse/SLING-12401
> Project: Sling
>  Issue Type: Bug
>    Reporter: Julian Reschke
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-12401) ResourceResolver: MapEntries.isAliasValid misnamed

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke reassigned SLING-12401:
--

Assignee: Julian Reschke

> ResourceResolver: MapEntries.isAliasValid misnamed
> --
>
> Key: SLING-12401
> URL: https://issues.apache.org/jira/browse/SLING-12401
> Project: Sling
>  Issue Type: Bug
>    Reporter: Julian Reschke
>        Assignee: Julian Reschke
>Priority: Trivial
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12401) Res

[Julian Reschke (Jira)]

Julian Reschke created SLING-12401:
--

 Summary: Res
 Key: SLING-12401
 URL: https://issues.apache.org/jira/browse/SLING-12401
 Project: Sling
  Issue Type: Bug
Reporter: Julian Reschke






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12400) ResourceResolver: add test coverage aliases on jcr:content nodes

[Julian Reschke (Jira)]

Julian Reschke created SLING-12400:
--

 Summary: ResourceResolver: add test coverage aliases on 
jcr:content nodes
 Key: SLING-12400
 URL: https://issues.apache.org/jira/browse/SLING-12400
 Project: Sling
  Issue Type: Task
  Components: ResourceResolver
Reporter: Julian Reschke


These are special in that the alias is apparently added to the parent node 
(which needs to be documented and tested).

Also, we do have quite some code duplication between {{loadAlias}} and 
{{doUpdateAliase}}. This should be reduced. FWIW, there maybe non-optimal 
overlaps in the handling of {{jcr:content}}.





--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12401) ResourceResolver: MapEntries.isAliasValid misnamed

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12401:
---
Priority: Trivial  (was: Major)

> ResourceResolver: MapEntries.isAliasValid misnamed
> --
>
> Key: SLING-12401
> URL: https://issues.apache.org/jira/browse/SLING-12401
> Project: Sling
>  Issue Type: Bug
>    Reporter: Julian Reschke
>Priority: Trivial
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12399) ResourceResolver: add test coverage for empty aliases

[Julian Reschke (Jira)]

Julian Reschke created SLING-12399:
--

 Summary: ResourceResolver: add test coverage for empty aliases
 Key: SLING-12399
 URL: https://issues.apache.org/jira/browse/SLING-12399
 Project: Sling
  Issue Type: Task
  Components: ResourceResolver
Reporter: Julian Reschke


...and either document what they mean, or disallow them in 
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/428f8a7d5b8f3621c525e3c8782eb1e2586d1f5a/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1300



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling Scripting HTL Testing Content 1.0.34-1.4.0, Apache Sling Scripting HTL Testing 1.0.36-1.4.0, Apache Sling Scripting HTL JS Use Provider 1.2.10

[Julian Reschke]

On 17.07.2024 15:32, Radu Cotescu wrote:

...


[X] +1 Approve the release

> ...

Best regards, Julian

Re: [VOTE] Apache Sling ResourceResolver 1.12.0

[Julian Reschke]

Am 05.08.2024 um 17:42 schrieb Julian Reschke:

Hi,

We solved N issues in this release:
...


Where N == 5.

Best regards, Julian

Re: [VOTE] Apache Sling ResourceResolver 1.12.0

[Julian Reschke]

Am 05.08.2024 um 17:42 schrieb Julian Reschke:

...


[X] +1 Approve the release

Best regards, Julian

[VOTE] Apache Sling ResourceResolver 1.12.0

[Julian Reschke]

Hi,

We solved N issues in this release:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710&version=12354143&styleName=Text

Staging repository:

https://repository.apache.org/content/repositories/orgapachesling-2877

You can use this UNIX script to download the release and verify the
signatures:

https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2877 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Best regards, Julian

[jira] [Resolved] (SLING-12384) ResourceResolver: paged query for sling:alias will miss entries

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved SLING-12384.

Resolution: Fixed

> ResourceResolver: paged query for sling:alias will miss entries
> ---
>
> Key: SLING-12384
> URL: https://issues.apache.org/jira/browse/SLING-12384
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Resource Resolver 1.11.6
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Major
> Fix For: Resource Resolver 1.12.0
>
>
> Initially I thought that the issue just applies to empty alias values, 
> because the paged query will always skip them, due to the first query being 
> "{{{}first(sling:alias) > ''{}}}".
> Closer inspection showed that the pageing logic was flawed:
>  * read values until pageSize is exceeded *and* a new key value _x_ is reached
>  * start a new query with condition {{> x}}
> This worked mostly ok with vanity paths, where the search key 
> "first(sling:vanityPath)" almost always changes (having the same value for 
> many resources will only lead to one working vanity path, because the same 
> path cannot map to multiple resources).
> For aliases the situations is different, because their value is locally 
> scoped to the collection the aliased resource appears in. So we could have 
> 1 resources with the _same_ set of aliases (think translations or 
> shortcuts), and in cases like these, the page size (right now 2000) would be 
> exceeded.
> The proposed change is:
>  * always use ">=" so the initial page contains the empty-valued properties 
> as well
>  * when page size is exceeded and a new key _y_ is found, do not include the 
> last result, but execute a new query right away (with the proper condition so 
> that all resources with "{{first(sling:alias) >= y}}" are returned)
>  * also add more diagnostics, which may help to diagnose pacge size / query 
> limit issues early
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12387) ResourceResolver: improve test coverage for PagedQueryIterator

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved SLING-12387.

Fix Version/s: Resource Resolver 1.12.0
   Resolution: Fixed

> ResourceResolver: improve test coverage for PagedQueryIterator
> --
>
> Key: SLING-12387
> URL: https://issues.apache.org/jira/browse/SLING-12387
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Major
> Fix For: Resource Resolver 1.12.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12387) ResourceResolver: improve test coverage for PagedQueryIterator

[Julian Reschke (Jira)]

Julian Reschke created SLING-12387:
--

 Summary: ResourceResolver: improve test coverage for 
PagedQueryIterator
 Key: SLING-12387
 URL: https://issues.apache.org/jira/browse/SLING-12387
 Project: Sling
  Issue Type: Task
  Components: ResourceResolver
Reporter: Julian Reschke
Assignee: Julian Reschke






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12386) ResourceResolver: is an empty string a valid sling:alias value

[Julian Reschke (Jira)]

Julian Reschke created SLING-12386:
--

 Summary: ResourceResolver: is an empty string a valid sling:alias 
value
 Key: SLING-12386
 URL: https://issues.apache.org/jira/browse/SLING-12386
 Project: Sling
  Issue Type: Task
  Components: ResourceResolver
Reporter: Julian Reschke


If it is, let's document what it means.

Otherwise, we'll need to filter them out, and likely warn about them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12384) ResourceResolver: paged query for sling:alias will miss entries

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12384:
---
Description: 
Initially I thought that the issue just applies to empty alias values, because 
the paged query will always skip them, due to the first query being 
"{{{}first(sling:alias) > ''{}}}".

Closer inspection showed that the pageing logic was flawed:
 * read values until pageSize is exceeded *and* a new key value _x_ is reached
 * start a new query with condition {{> x}}

This worked mostly ok with vanity paths, where the search key 
"first(sling:vanityPath)" almost always changes (having the same value for many 
resources will only lead to one working vanity path, because the same path 
cannot map to multiple resources).

For aliases the situations is different, because their value is locally scoped 
to the collection the aliased resource appears in. So we could have 1 
resources with the _same_ set of aliases (think translations or shortcuts), and 
in cases like these, the page size (right now 2000) would be exceeded.

The proposed change is:
 * always use ">=" so the initial page contains the empty-valued properties as 
well
 * when page size is exceeded and a new key _y_ is found, do not include the 
last result, but execute a new query right away (with the proper condition so 
that all resources with "{{first(sling:alias) >= y}}" are returned)
 * also add more diagnostics, which may help to diagnose pacge size / query 
limit issues early

 

 

 

  was:
Initially I thought that the issue just applies to empty alias values, because 
the paged query will always skip them, due to the first query being "starts 
with '{{{}> ''"{}}}.

Closer inspection showed that the pageing logic was flawed:
 * read values until pageSize is exceeded *and* a new key value _x_ is reached
 * start a new query with condition {{>= x}}

This worked mostly ok with vanity paths, where the search key 
("first(sling:vanityPath)" almost always changes (having the same value for 
many resources will only lead to one working vanity path, because the same path 
cannot map to multiple resources).

For aliases the situations is different, because their value is locally scoped 
to the collection the aliased resource appears in. So we could have 1 
resources with the _same_ set of aliases (think translations or shortcuts), and 
in cases like these, the page size (right now 2000) would be exceeded.

The proposed change is:
 * always use ">=" so the initial page contains the empty-valued properties
 * when page size is exceeded and a new key _y_ is found, do not include the 
last result, but execute a new query right away (with the proper condition so 
that all resources with key _y_ are returned)
 * also add more diagnostics, which may help to diagnose pacge size / query 
limit issues early

 

 

 


> ResourceResolver: paged query for sling:alias will miss entries
> ---
>
> Key: SLING-12384
> URL: https://issues.apache.org/jira/browse/SLING-12384
>     Project: Sling
>  Issue Type: Bug
>Affects Versions: Resource Resolver 1.11.6
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>
> Initially I thought that the issue just applies to empty alias values, 
> because the paged query will always skip them, due to the first query being 
> "{{{}first(sling:alias) > ''{}}}".
> Closer inspection showed that the pageing logic was flawed:
>  * read values until pageSize is exceeded *and* a new key value _x_ is reached
>  * start a new query with condition {{> x}}
> This worked mostly ok with vanity paths, where the search key 
> "first(sling:vanityPath)" almost always changes (having the same value for 
> many resources will only lead to one working vanity path, because the same 
> path cannot map to multiple resources).
> For aliases the situations is different, because their value is locally 
> scoped to the collection the aliased resource appears in. So we could have 
> 1 resources with the _same_ set of aliases (think translations or 
> shortcuts), and in cases like these, the page size (right now 2000) would be 
> exceeded.
> The proposed change is:
>  * always use ">=" so the initial page contains the empty-valued properties 
> as well
>  * when page size is exceeded and a new key _y_ is found, do not include the 
> last result, but execute a new query right away (with the proper condition so 
> that all resources with "{{first(sling:alias) >= y}}" are returned)
>  * also add more diagnostics, which may help to diagnose pacge size / query 
> limit issues early
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12384) ResourceResolver: paged query for sling:alias will miss entries

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12384:
---
Description: 
Initially I thought that the issue just applies to empty alias values, because 
the paged query will always skip them, due to the first query being "starts 
with '{{{}> ''"{}}}.

Closer inspection showed that the pageing logic was flawed:
 * read values until pageSize is exceeded *and* a new key value _x_ is reached
 * start a new query with condition {{>= x}}

This worked mostly ok with vanity paths, where the search key 
("first(sling:vanityPath)" almost always changes (having the same value for 
many resources will only lead to one working vanity path, because the same path 
cannot map to multiple resources).

For aliases the situations is different, because their value is locally scoped 
to the collection the aliased resource appears in. So we could have 1 
resources with the _same_ set of aliases (think translations or shortcuts), and 
in cases like these, the page size (right now 2000) would be exceeded.

The proposed change is:
 * always use ">=" so the initial page contains the empty-valued properties
 * when page size is exceeded and a new key _y_ is found, do not include the 
last result, but execute a new query right away (with the proper condition so 
that all resources with key _y_ are returned)
 * also add more diagnostics, which may help to diagnose pacge size / query 
limit issues early

 

 

 

  was:...as the query starts with '{{> ''}}'.


> ResourceResolver: paged query for sling:alias will miss entries
> ---
>
> Key: SLING-12384
> URL: https://issues.apache.org/jira/browse/SLING-12384
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Resource Resolver 1.11.6
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>
> Initially I thought that the issue just applies to empty alias values, 
> because the paged query will always skip them, due to the first query being 
> "starts with '{{{}> ''"{}}}.
> Closer inspection showed that the pageing logic was flawed:
>  * read values until pageSize is exceeded *and* a new key value _x_ is reached
>  * start a new query with condition {{>= x}}
> This worked mostly ok with vanity paths, where the search key 
> ("first(sling:vanityPath)" almost always changes (having the same value for 
> many resources will only lead to one working vanity path, because the same 
> path cannot map to multiple resources).
> For aliases the situations is different, because their value is locally 
> scoped to the collection the aliased resource appears in. So we could have 
> 1 resources with the _same_ set of aliases (think translations or 
> shortcuts), and in cases like these, the page size (right now 2000) would be 
> exceeded.
> The proposed change is:
>  * always use ">=" so the initial page contains the empty-valued properties
>  * when page size is exceeded and a new key _y_ is found, do not include the 
> last result, but execute a new query right away (with the proper condition so 
> that all resources with key _y_ are returned)
>  * also add more diagnostics, which may help to diagnose pacge size / query 
> limit issues early
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12384) ResourceResolver: paged query for sling:alias will miss entriesere 'first(sling:alias)' is empty

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12384:
---
Summary: ResourceResolver: paged query for sling:alias will miss entriesere 
'first(sling:alias)' is empty  (was: ResourceResolver: paged query for 
sling:alias will miss entries where 'first(sling:alias)' is empty)

> ResourceResolver: paged query for sling:alias will miss entriesere 
> 'first(sling:alias)' is empty
> 
>
> Key: SLING-12384
> URL: https://issues.apache.org/jira/browse/SLING-12384
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Resource Resolver 1.11.6
>    Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>
> ...as the query starts with '{{> ''}}'.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12384) ResourceResolver: paged query for sling:alias will miss entries

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12384:
---
Summary: ResourceResolver: paged query for sling:alias will miss entries  
(was: ResourceResolver: paged query for sling:alias will miss entriesere 
'first(sling:alias)' is empty)

> ResourceResolver: paged query for sling:alias will miss entries
> ---
>
> Key: SLING-12384
> URL: https://issues.apache.org/jira/browse/SLING-12384
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Resource Resolver 1.11.6
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>
> ...as the query starts with '{{> ''}}'.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12383) ResourceResolver: potential NPE while processing aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved SLING-12383.

Fix Version/s: Resource Resolver 1.12.0
   Resolution: Fixed

see 
https://github.com/apache/sling-org-apache-sling-resourceresolver/commit/1e8850451be2dce0a9614ce06e42a002b17814d7

> ResourceResolver: potential NPE while processing aliases
> 
>
> Key: SLING-12383
> URL: https://issues.apache.org/jira/browse/SLING-12383
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.11.6
>    Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Major
> Fix For: Resource Resolver 1.12.0
>
>
> Seen in production:
>  
> {noformat}
> ERROR [ResourceResolverFactory registration]
>  org.apache.sling.resourceresolver.impl.mapping.MapEntries Unexpected 
> problem during initialization of optimize alias resolution. Therefore 
> disabling optimize alias resolution. Please fix the problem.
> java.lang.NullPointerException: null
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadAlias(MapEntries.java:1226)
>  [org.apache.sling.resourceresolver:1.11.6]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadAliases(MapEntries.java:1173)
>  [org.apache.sling.resourceresolver:1.11.6]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.doInit(MapEntries.java:241)
>  [org.apache.sling.resourceresolver:1.11.6] {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12384) ResourceResolver: paged query for sling:alias will miss entries where 'first(sling:alias)' is empty

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12384:
---
Summary: ResourceResolver: paged query for sling:alias will miss entries 
where 'first(sling:alias)' is empty  (was: ResourceResolver: paged query for 
sling:alias will miss entries where 'first(sing:alias)' is empty)

> ResourceResolver: paged query for sling:alias will miss entries where 
> 'first(sling:alias)' is empty
> ---
>
> Key: SLING-12384
> URL: https://issues.apache.org/jira/browse/SLING-12384
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Resource Resolver 1.11.6
>    Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>
> ...as the query starts with '{{> ''}}'.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12384) ResourceResolver: paged query for sling:alias will miss entries where 'first(sing:alias)' is empty

[Julian Reschke (Jira)]

Julian Reschke created SLING-12384:
--

 Summary: ResourceResolver: paged query for sling:alias will miss 
entries where 'first(sing:alias)' is empty
 Key: SLING-12384
 URL: https://issues.apache.org/jira/browse/SLING-12384
 Project: Sling
  Issue Type: Bug
Affects Versions: Resource Resolver 1.11.6
Reporter: Julian Reschke
Assignee: Julian Reschke


...as the query starts with '{{> ''}}'.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-12383) ResourceResolver: potential NPE while processing aliases

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke reassigned SLING-12383:
--

Assignee: Julian Reschke

> ResourceResolver: potential NPE while processing aliases
> 
>
> Key: SLING-12383
> URL: https://issues.apache.org/jira/browse/SLING-12383
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.11.6
>    Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Major
>
> Seen in production:
>  
> {noformat}
> ERROR [ResourceResolverFactory registration]
>  org.apache.sling.resourceresolver.impl.mapping.MapEntries Unexpected 
> problem during initialization of optimize alias resolution. Therefore 
> disabling optimize alias resolution. Please fix the problem.
> java.lang.NullPointerException: null
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadAlias(MapEntries.java:1226)
>  [org.apache.sling.resourceresolver:1.11.6]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadAliases(MapEntries.java:1173)
>  [org.apache.sling.resourceresolver:1.11.6]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.doInit(MapEntries.java:241)
>  [org.apache.sling.resourceresolver:1.11.6] {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12383) ResourceResolver: potential NPE while processing aliases

[Julian Reschke (Jira)]

Julian Reschke created SLING-12383:
--

 Summary: ResourceResolver: potential NPE while processing aliases
 Key: SLING-12383
 URL: https://issues.apache.org/jira/browse/SLING-12383
 Project: Sling
  Issue Type: Bug
  Components: ResourceResolver
Affects Versions: Resource Resolver 1.11.6
Reporter: Julian Reschke


Seen in production:

 
{noformat}
ERROR [ResourceResolverFactory registration]
 org.apache.sling.resourceresolver.impl.mapping.MapEntries Unexpected 
problem during initialization of optimize alias resolution. Therefore 
disabling optimize alias resolution. Please fix the problem.

java.lang.NullPointerException: null

at 
org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadAlias(MapEntries.java:1226)
 [org.apache.sling.resourceresolver:1.11.6]

at 
org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadAliases(MapEntries.java:1173)
 [org.apache.sling.resourceresolver:1.11.6]

at 
org.apache.sling.resourceresolver.impl.mapping.MapEntries.doInit(MapEntries.java:241)
 [org.apache.sling.resourceresolver:1.11.6] {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (SLING-11906) Migrate to slf4j 2.x

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866418#comment-17866418
 ] 

Julian Reschke edited comment on SLING-11906 at 7/16/24 2:36 PM:
-

FYI, from <[https://www.slf4j.org/faq.html#changesInVersion200]>:
{quote}since 2.0.9 You can specify the provider class explicitly via the 
"slf4j.provider" system property. This bypasses the service loader mechanism 
for finding providers and may shorten SLF4J initialization.
{quote}
Maybe that makes things easier?


was (Author: reschke):
FYI, from <https://www.slf4j.org/faq.html#changesInVersion200>:

bq. since 2.0.9 You can specify the provider class explicitly via the 
"slf4j.provider" system property. This bypasses the service loader mechanism 
for finding providers and may shorten SLF4J initialization.

Maybe that makes things easiert?

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866418#comment-17866418
 ] 

Julian Reschke commented on SLING-11906:


FYI, from <https://www.slf4j.org/faq.html#changesInVersion200>:

bq. since 2.0.9 You can specify the provider class explicitly via the 
"slf4j.provider" system property. This bypasses the service loader mechanism 
for finding providers and may shorten SLF4J initialization.

Maybe that makes things easiert?

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12342) commons-log test ITPackagingData fails on Windows

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851063#comment-17851063
 ] 

Julian Reschke commented on SLING-12342:


I suspect that it has to do with using "/" as path sep (instead of 
File.separatorChar), but fixing these does not seem to be sufficient.

> commons-log test ITPackagingData fails on Windows
> -
>
> Key: SLING-12342
> URL: https://issues.apache.org/jira/browse/SLING-12342
> Project: Sling
>  Issue Type: Task
>  Components: Commons
>Reporter: Julian Reschke
>Priority: Major
>
> {noformat}
> [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 17.346 s <<< FAILURE! - in 
> org.apache.sling.commons.log.logback.integration.ITPackagingData
> [ERROR] 
> org.apache.sling.commons.log.logback.integration.ITPackagingData.packageDataWorking
>   Time elapsed: 6.075 s  <<< ERROR!
> java.io.IOException: Zugriff verweigert
> at 
> org.apache.sling.commons.log.logback.integration.ITPackagingData.packageDataWorking(ITPackagingData.java:148)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12342) commons-log test ITPackagingData fails on Windows

[Julian Reschke (Jira)]

Julian Reschke created SLING-12342:
--

 Summary: commons-log test ITPackagingData fails on Windows
 Key: SLING-12342
 URL: https://issues.apache.org/jira/browse/SLING-12342
 Project: Sling
  Issue Type: Task
  Components: Commons
Reporter: Julian Reschke


{noformat}
[ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 17.346 
s <<< FAILURE! - in 
org.apache.sling.commons.log.logback.integration.ITPackagingData
[ERROR] 
org.apache.sling.commons.log.logback.integration.ITPackagingData.packageDataWorking
  Time elapsed: 6.075 s  <<< ERROR!
java.io.IOException: Zugriff verweigert
at 
org.apache.sling.commons.log.logback.integration.ITPackagingData.packageDataWorking(ITPackagingData.java:148)
{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851052#comment-17851052
 ] 

Julian Reschke commented on SLING-11906:


FYI; removal of slf4j.event in Oak is in progress (see OAK-10339) and will be 
done in ca. 10 weeks (two public releases). I still see 
org.apache.sling:org.apache.sling.commons.log:5.5.0 using slf4j.spi and 
slf4j.event in public APIs; do we have a ticket for that? 

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12313) bump oak.version to 1.62.0 for compatibility

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846598#comment-17846598
 ] 

Julian Reschke commented on SLING-12313:


Oak and Jackrabbit dependencies should be in sync. Like that:

{noformat}
diff --git a/pom.xml b/pom.xml
index 24fb059..2e43fa7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -43,8 +43,8 @@

   
 
-2.16.3
-1.56.0
+2.20.15
+1.62.0
 4.13.3
 
2023-10-09T22:21:44Z
   
@@ -98,8 +98,8 @@
 
 
   org.apache.jackrabbit
-  jackrabbit-api
-  ${jackrabbit.version}
+  oak-jackrabbit-api
+  ${oak.version}
   provided
 
 

{noformat}

> bump oak.version to 1.62.0 for compatibility
> 
>
> Key: SLING-12313
> URL: https://issues.apache.org/jira/browse/SLING-12313
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Oak Server 1.4.2
>
>
> Oak 1.62.0 has bumped the version of the shaded guava packages to a new major 
> version (from 32 to 33) which results in a failure to resolve the 
> o.a.sling.jcr.oak.server bundle with that version of the Oak bundles.
> {code:java}
> org.osgi.framework.BundleException: Unable to resolve 
> org.apache.sling.jcr.oak.server [144](R 144.0): missing requirement 
> [org.apache.sling.jcr.oak.server [144](R 144.0)] osgi.wiring.package; 
> (&(osgi.wiring.package=org.apache.jackrabbit.guava.common.base)(version>=32.1.0)(!(version>=33.0.0)))
>  Unresolved requirements: [[org.apache.sling.jcr.oak.server [144](R 144.0)] 
> osgi.wiring.package; 
> (&(osgi.wiring.package=org.apache.jackrabbit.guava.common.base)(version>=32.1.0)(!(version>=33.0.0)))]
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836072#comment-17836072
 ] 

Julian Reschke commented on SLING-12266:


bq. there was some need form other sling modules to have a slightly newer 
version from oak in sling-mock-oak than 1.22

Would be interesting to dig out why; might be a confusion about how versioning 
is handled over in Oak.

> Cache initial repository state to improve JCR_OAK performance
> -
>
> Key: SLING-12266
> URL: https://issues.apache.org/jira/browse/SLING-12266
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing Sling Mock 3.4.18
>Reporter: Csaba Varga
>Assignee: Stefan Seifert
>Priority: Minor
>
> A lot of effort goes into preparing an Oak Mock repository from scratch: node 
> types need to be registered, indexes need to be created, and all this happens 
> over several commits. None of this work depends on the test case itself, so 
> it will always result in the exact same repository state. We could take the 
> root NodeState from the first repository we build, then build subsequent 
> repositories on top of it, avoiding most of the redundant work. Commits can 
> be relatively expensive even in memory, so each one we avoid can save a lot 
> of time in the long term.
>  
> This would require extending the contract between Testing Sling Mock and the 
> ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo 
> from snapshot" operations. For adapters that don't support them, we would 
> keep rebuilding things from scratch.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836061#comment-17836061
 ] 

Julian Reschke commented on SLING-12266:


Yep - that's an unsupported version. Either use a recent version from the 
maintenance branch (1.22.x), or the "latest & greatest".

> Cache initial repository state to improve JCR_OAK performance
> -
>
> Key: SLING-12266
> URL: https://issues.apache.org/jira/browse/SLING-12266
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing Sling Mock 3.4.18
>Reporter: Csaba Varga
>Assignee: Stefan Seifert
>Priority: Minor
>
> A lot of effort goes into preparing an Oak Mock repository from scratch: node 
> types need to be registered, indexes need to be created, and all this happens 
> over several commits. None of this work depends on the test case itself, so 
> it will always result in the exact same repository state. We could take the 
> root NodeState from the first repository we build, then build subsequent 
> repositories on top of it, avoiding most of the redundant work. Commits can 
> be relatively expensive even in memory, so each one we avoid can save a lot 
> of time in the long term.
>  
> This would require extending the contract between Testing Sling Mock and the 
> ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo 
> from snapshot" operations. For adapters that don't support them, we would 
> keep rebuilding things from scratch.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836055#comment-17836055
 ] 

Julian Reschke commented on SLING-12266:


AEM 6.5 should be on Oak 1.22.18 with the latest SP. If you really need to 
support older SPs, there are matching Oak versions for each.

AEM pre 6.5 is EOL and does not receive any fixes anymore.

> Cache initial repository state to improve JCR_OAK performance
> -
>
> Key: SLING-12266
> URL: https://issues.apache.org/jira/browse/SLING-12266
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing Sling Mock 3.4.18
>Reporter: Csaba Varga
>Assignee: Stefan Seifert
>Priority: Minor
>
> A lot of effort goes into preparing an Oak Mock repository from scratch: node 
> types need to be registered, indexes need to be created, and all this happens 
> over several commits. None of this work depends on the test case itself, so 
> it will always result in the exact same repository state. We could take the 
> root NodeState from the first repository we build, then build subsequent 
> repositories on top of it, avoiding most of the redundant work. Commits can 
> be relatively expensive even in memory, so each one we avoid can save a lot 
> of time in the long term.
>  
> This would require extending the contract between Testing Sling Mock and the 
> ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo 
> from snapshot" operations. For adapters that don't support them, we would 
> keep rebuilding things from scratch.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835795#comment-17835795
 ] 

Julian Reschke commented on SLING-12266:


I'm not an expert on mocking and Oak APIs, so I really can't provide feedback 
here. If it works...

That said: please make sure to update Jackrabbit/Oak references to non-EOLd 
releases...

> Cache initial repository state to improve JCR_OAK performance
> -
>
> Key: SLING-12266
> URL: https://issues.apache.org/jira/browse/SLING-12266
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing Sling Mock 3.4.18
>Reporter: Csaba Varga
>Assignee: Stefan Seifert
>Priority: Minor
>
> A lot of effort goes into preparing an Oak Mock repository from scratch: node 
> types need to be registered, indexes need to be created, and all this happens 
> over several commits. None of this work depends on the test case itself, so 
> it will always result in the exact same repository state. We could take the 
> root NodeState from the first repository we build, then build subsequent 
> repositories on top of it, avoiding most of the redundant work. Commits can 
> be relatively expensive even in memory, so each one we avoid can save a lot 
> of time in the long term.
>  
> This would require extending the contract between Testing Sling Mock and the 
> ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo 
> from snapshot" operations. For adapters that don't support them, we would 
> keep rebuilding things from scratch.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (SLING-12250) Adding Resource with sling:vanityPath set causes mismatch when resolving vanity URL (timing issue)

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820743#comment-17820743
 ] 

Julian Reschke edited comment on SLING-12250 at 2/26/24 3:21 PM:
-

Well, it should resolve to what is persisted in the repo. If the test *changes* 
the repo and the resolves it, it might make time until bg init has finished and 
events are processed.

You may want to inspect DEBUG logs...


was (Author: reschke):
Well, it should resolve.

If you have a repro test case, I can have a look.

> Adding Resource with sling:vanityPath set causes mismatch when resolving 
> vanity URL (timing issue)
> --
>
> Key: SLING-12250
> URL: https://issues.apache.org/jira/browse/SLING-12250
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: Testing Sling Mock 3.4.18
>Reporter: Henry Kuijpers
>Priority: Major
>
> It could happen that a Resource containing sling:vanityPath is added and then 
> resolved, but the Resource did not end up yet in the vanity logic.
> Observed with JCR_OAK mock context.
> Adding Thread.sleep(1000) fixes the issue, but it's of course not a very good 
> solution.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12250) Adding Resource with sling:vanityPath set causes mismatch when resolving vanity URL (timing issue)

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820743#comment-17820743
 ] 

Julian Reschke commented on SLING-12250:


Well, it should resolve.

If you have a repro test case, I can have a look.

> Adding Resource with sling:vanityPath set causes mismatch when resolving 
> vanity URL (timing issue)
> --
>
> Key: SLING-12250
> URL: https://issues.apache.org/jira/browse/SLING-12250
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: Testing Sling Mock 3.4.18
>Reporter: Henry Kuijpers
>Priority: Major
>
> It could happen that a Resource containing sling:vanityPath is added and then 
> resolved, but the Resource did not end up yet in the vanity logic.
> Observed with JCR_OAK mock context.
> Adding Thread.sleep(1000) fixes the issue, but it's of course not a very good 
> solution.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12250) Adding Resource with sling:vanityPath set causes mismatch when resolving vanity URL (timing issue)

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820732#comment-17820732
 ] 

Julian Reschke commented on SLING-12250:


AFAIU, the path should *always* resolve. If it does not, it might be because we 
have a bug, or because the test is doing something silly :-).

> Adding Resource with sling:vanityPath set causes mismatch when resolving 
> vanity URL (timing issue)
> --
>
> Key: SLING-12250
> URL: https://issues.apache.org/jira/browse/SLING-12250
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: Testing Sling Mock 3.4.18
>Reporter: Henry Kuijpers
>Priority: Major
>
> It could happen that a Resource containing sling:vanityPath is added and then 
> resolved, but the Resource did not end up yet in the vanity logic.
> Observed with JCR_OAK mock context.
> Adding Thread.sleep(1000) fixes the issue, but it's of course not a very good 
> solution.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12250) Adding Resource with sling:vanityPath set causes mismatch when resolving vanity URL (timing issue)

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817039#comment-17817039
 ] 

Julian Reschke commented on SLING-12250:


While the vanity path cache is populated, the resource resolver will query the 
repo for the path (and cache that result).

Once the cache is ready, timing will depend on event delivery.

> Adding Resource with sling:vanityPath set causes mismatch when resolving 
> vanity URL (timing issue)
> --
>
> Key: SLING-12250
> URL: https://issues.apache.org/jira/browse/SLING-12250
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: Testing Sling Mock 3.4.18
>Reporter: Henry Kuijpers
>Priority: Major
>
> It could happen that a Resource containing sling:vanityPath is added and then 
> resolved, but the Resource did not end up yet in the vanity logic.
> Observed with JCR_OAK mock context.
> Adding Thread.sleep(1000) fixes the issue, but it's of course not a very good 
> solution.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810479#comment-17810479
 ] 

Julian Reschke commented on SLING-11906:


Awesome. Thanks.

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810475#comment-17810475
 ] 

Julian Reschke commented on SLING-11906:


[~kwin] - IIUC, Oak has similar problems wrt using SLF packages it should not? 
Could you open an issue over there once we fully understand what needs to be 
done?

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [RESULT] [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 23.01.2024 13:05, Konrad Windszus wrote:

Done, please update the site accordingly.
Thanks,
Konrad


Thanks Konrad,

-> 

Best regards, Julian

Re: [RESULT] [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 22.01.2024 17:25, Julian Reschke wrote:

On 22.01.2024 10:20, Julian Reschke wrote:

On 17.01.2024 07:51, Julian Reschke wrote:

...


Hi,

The vote has passed with the following result :

+1 (binding): Bertrand Delacretaz , Julian
Reschke , Konrad Windszus ,
Robert Munteanu 

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Best regards, Julian


OK, I will need help with promoting the release (I'm committer but not
PMC member, thus have no write access to the SVN repo).

Best regards, Julian


Hi,

FYI: Konrad has volunteered to do the release promotion; thanks for that.

Best regards, Julian

Re: [RESULT] [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 22.01.2024 10:20, Julian Reschke wrote:

On 17.01.2024 07:51, Julian Reschke wrote:

...


Hi,

The vote has passed with the following result :

+1 (binding): Bertrand Delacretaz , Julian
Reschke , Konrad Windszus ,
Robert Munteanu 

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Best regards, Julian


OK, I will need help with promoting the release (I'm committer but not
PMC member, thus have no write access to the SVN repo).

Best regards, Julian

[RESULT] [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 17.01.2024 07:51, Julian Reschke wrote:

...


Hi,

The vote has passed with the following result :

+1 (binding): Bertrand Delacretaz , Julian 
Reschke , Konrad Windszus , 
Robert Munteanu 


I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Best regards, Julian

Re: [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 20.01.2024 02:09, Eric Norman wrote:

+0 for me.

Though, I am still a little annoyed that you just ignored my review
comments from
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#pullrequestreview-1791514750


Eric,

FWIW: disagreeing is not the same thing as "ignoring". This change was
urgent because it addresses a customer-visible defect (aliases broken
when more than >100K). What you raised is a stylistic issue which is not
specific to this PR, so it really ought to be addressed/discussed as
separate issue.

Best regards, Julian

Re: [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 17.01.2024 13:44, Bertrand Delacretaz wrote:

[X ] +1 Approve the release

Julian's signature 44F4797A52C336FA666CD9271DE461528F1F1B2A was
missing from https://downloads.apache.org/sling/KEYS , I have added it
[1] from [0], it should appear in a few minutes.
:::


Ups. Thanks.

Best regards, Julian

Re: Order of steps in https://sling.apache.org/documentation/development/release-management.html

[Julian Reschke]

On 17.01.2024 11:14, Carsten Ziegeler wrote:

I think there is no perfect solution. We are operating this way for many
years :) which of course doesn't mean there is no room for improvement.

I think the scenario you describe happened at least once. but it was
detected when the version was released, the jira issue corrected and all
was good. This requires a little care of the release manager. but it
really is more a theoretical issue. We have all the notifications flying
around and usually if you are working on something you know that there
is a vote for it going on.

The Oak way shows a version as released although it is not, and might
never be - which at least in theory can create confusion to users.

So I prefer potentially confused release managers over potentially
confused users :)

Regards
Carsten



In that case how about adding some precise instructions to check
fixVersion consistency after the release?

Best regards, Julian

Order of steps in https://sling.apache.org/documentation/development/release-management.html

[Julian Reschke]

Hi there,

the "Release Management" document suggests adding a new (next) release
should happen after the release vote, and that the release being voted
on remains "unreleased" in the meantime.

Doesn't that leave us with a time windos of 72h+ hours in which issue
tracking in Jira will be extremely ... awkward? What happens if somebody
resolves an issue and enters the release currently under vote as
"fixVersion"?

(In Oak land, we do it the other way around; we create the "next"
release first, and make the release being voted on as "released" when
the vote starts).

Best regards, Julian

Re: [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 17.01.2024 07:51, Julian Reschke wrote:

...


[X] +1 Approve the release


Best regards, Julian

[VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

Hi,

We solved 6 issues in this release:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710&version=12353856&styleName=Text

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2830

You can use this UNIX script to download the release and verify the
signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2830 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Best regards, Julian

[jira] [Updated] (SLING-11511) Allow checking the map/resolve result for an empty path

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-11511:
---
Fix Version/s: (was: Resource Resolver 1.11.6)

> Allow checking the map/resolve result for an empty path
> ---
>
> Key: SLING-11511
> URL: https://issues.apache.org/jira/browse/SLING-11511
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>
> The resource resolver API supports mapping/resolving empty paths, although 
> this is an invalid path.
> The web console plug-in should support this as well, to better support 
> debugging for scenarios like SLING-10844 .



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11513) Allow impersonating an user when checking the result of a map/resolve call

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-11513:
---
Fix Version/s: (was: Resource Resolver 1.11.6)

> Allow impersonating an user when checking the result of a map/resolve call
> --
>
> Key: SLING-11513
> URL: https://issues.apache.org/jira/browse/SLING-11513
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: screenshot-1.png
>
>
> When debugging various resolve/map issues ( e.g. SLING-10844 ) it is useful 
> to be able to impersonate a user that does not have access to the web console.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12222) MapEntries: Display the total number of loaded vanity urls / alias when loading is completed

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved SLING-1.

Fix Version/s: Resource Resolver 1.11.6
   Resolution: Fixed

> MapEntries: Display the total number of loaded vanity urls / alias when 
> loading is completed
> 
>
> Key: SLING-1
> URL: https://issues.apache.org/jira/browse/SLING-1
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.11.4
>Reporter: Joerg Hoh
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: Resource Resolver 1.11.6
>
>
> Right now the completion of the loading process of vanity urls is logged like 
> this:
> {noformat}
> org.apache.sling.resourceresolver.impl.mapping.MapEntries vanity path 
> initialization - end, elapsed 459889ms
> {noformat}
> It would be nice, if the total number of vanity urls loaded during this 
> process is loaded as well; then it's possible to calculate the performance 
> ("vanity urls per second") and compare it via multiple instances.
> Would be good to have the same data for the aliases as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12222) MapEntries: Display the total number of loaded vanity urls / alias when loading is completed

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807154#comment-17807154
 ] 

Julian Reschke commented on SLING-1:


https://github.com/apache/sling-org-apache-sling-resourceresolver/commit/9eb03e021669a2520f96598968c00832ff6c0f47

> MapEntries: Display the total number of loaded vanity urls / alias when 
> loading is completed
> 
>
> Key: SLING-1
> URL: https://issues.apache.org/jira/browse/SLING-1
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.11.4
>Reporter: Joerg Hoh
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: Resource Resolver 1.11.6
>
>
> Right now the completion of the loading process of vanity urls is logged like 
> this:
> {noformat}
> org.apache.sling.resourceresolver.impl.mapping.MapEntries vanity path 
> initialization - end, elapsed 459889ms
> {noformat}
> It would be nice, if the total number of vanity urls loaded during this 
> process is loaded as well; then it's possible to calculate the performance 
> ("vanity urls per second") and compare it via multiple instances.
> Would be good to have the same data for the aliases as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Resource Resolver release

[Julian Reschke]

Hi,

I'd like to cut 1.11.6
(https://issues.apache.org/jira/projects/SLING/versions/12353856) tomorrow.

Robert: there are currently two in-progress issues assigned to you: can
we move them to the next release?

Note that I haven't done a SLING release before - I'm looking at
https://sling.apache.org/documentation/development/release-management.html
- I assume that's the right place?

Best regards, Julian

[jira] [Resolved] (SLING-12225) resource resolver: revise documentation and naming of system properties for query paging

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved SLING-12225.

Fix Version/s: Resource Resolver 1.11.6
   Resolution: Fixed

System properties removed.

https://github.com/apache/sling-org-apache-sling-resourceresolver/commit/56507f067ce057240ba9abdd2e8663b9206ef456

> resource resolver: revise documentation and naming of system properties for 
> query paging
> 
>
> Key: SLING-12225
> URL: https://issues.apache.org/jira/browse/SLING-12225
> Project: Sling
>  Issue Type: Task
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Minor
> Fix For: Resource Resolver 1.11.6
>
>
> See 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12222) MapEntries: Display the total number of loaded vanity urls / alias when loading is completed

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805106#comment-17805106
 ] 

Julian Reschke commented on SLING-1:


sample output from PR'd resolver:

{noformat}
09.01.2024 17:47:51.581 *INFO* [ResourceResolverFactory registration] 
org.apache.sling.resourceresolver.impl.mapping.MapEntries alias initialization 
- end, processed 134066 resources with sling:alias properties in 34040ms (~3938 
resource/s)
09.01.2024 17:47:51.654 *INFO* [VanityPathInitializer] 
org.apache.sling.resourceresolver.impl.mapping.MapEntries vanity path 
initialization - end, processed 47 resources with sling:vanityPath properties 
in 43ms (~1083 resource/s)
{noformat}

> MapEntries: Display the total number of loaded vanity urls / alias when 
> loading is completed
> 
>
> Key: SLING-1
> URL: https://issues.apache.org/jira/browse/SLING-1
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.11.4
>Reporter: Joerg Hoh
>Assignee: Julian Reschke
>Priority: Minor
>
> Right now the completion of the loading process of vanity urls is logged like 
> this:
> {noformat}
> org.apache.sling.resourceresolver.impl.mapping.MapEntries vanity path 
> initialization - end, elapsed 459889ms
> {noformat}
> It would be nice, if the total number of vanity urls loaded during this 
> process is loaded as well; then it's possible to calculate the performance 
> ("vanity urls per second") and compare it via multiple instances.
> Would be good to have the same data for the aliases as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12225) resource resolver: revise documentation and naming of system properties for query paging

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804677#comment-17804677
 ] 

Julian Reschke commented on SLING-12225:


It was suggested by Thomas Müller while trying different page size values.

I really do not care that much, but it's certainly easier to try different 
values without having to use a special build.

In any case, the answer should be the same & consistent for both vanity paths 
and aliases.


> resource resolver: revise documentation and naming of system properties for 
> query paging
> 
>
> Key: SLING-12225
> URL: https://issues.apache.org/jira/browse/SLING-12225
> Project: Sling
>  Issue Type: Task
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>
> See 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12225) resource resolver: revise documentation and naming of system properties for query paging

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12225:
---
Summary: resource resolver: revise documentation and naming of system 
properties for query paging  (was: resource resolver: revise document and 
naming of system properties for paging)

> resource resolver: revise documentation and naming of system properties for 
> query paging
> 
>
> Key: SLING-12225
> URL: https://issues.apache.org/jira/browse/SLING-12225
> Project: Sling
>  Issue Type: Task
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Minor
>
> See 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-11799) use keyset pagination for sling:alias query

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved SLING-11799.

Fix Version/s: Resource Resolver 1.11.6
   Resolution: Fixed

> use keyset pagination for sling:alias query
> ---
>
> Key: SLING-11799
> URL: https://issues.apache.org/jira/browse/SLING-11799
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>        Reporter: Julian Reschke
>    Assignee: Julian Reschke
>Priority: Major
> Fix For: Resource Resolver 1.11.6
>
>
> Similar to what was done for vanity paths (SLING-11581), we should use keyset 
> pagination for queries for sling:alias.
> This would work the same in principle, however we should keep in mind that - 
> due to the different type of data - we may have way more duplicates, so in 
> edge cases the pages might be bigger than expected. However, every size 
> reduction of "results of a single query" should help.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12225) resource resolver: revise document and naming of system properties for paging

[Julian Reschke (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-12225:
---
Description: See 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455

> resource resolver: revise document and naming of system properties for paging
> -
>
> Key: SLING-12225
> URL: https://issues.apache.org/jira/browse/SLING-12225
> Project: Sling
>  Issue Type: Task
>    Reporter: Julian Reschke
>        Assignee: Julian Reschke
>Priority: Minor
>
> See 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12225) resource resolver: revise document and naming of system properties for paging

[Julian Reschke (Jira)]

Julian Reschke created SLING-12225:
--

 Summary: resource resolver: revise document and naming of system 
properties for paging
 Key: SLING-12225
 URL: https://issues.apache.org/jira/browse/SLING-12225
 Project: Sling
  Issue Type: Task
Reporter: Julian Reschke
Assignee: Julian Reschke






--
This message was sent by Atlassian Jira
(v8.20.10#820010)