[jira] [Resolved] (SLING-11731) make package pipe assembly optional
[ https://issues.apache.org/jira/browse/SLING-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-11731. - Resolution: Not A Problem "assemble" flag defaulting to true is already there > make package pipe assembly optional > --- > > Key: SLING-11731 > URL: https://issues.apache.org/jira/browse/SLING-11731 > Project: Sling > Issue Type: Improvement > Components: Sling Pipes >Affects Versions: pipes 4.5.0 >Reporter: Nicolas Peltier >Priority: Major > > For big packages it's preferable to delegate the build to a dedicated action, > improvement would be to add a flag "noAssembly" that when set not do any > assembly :) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11731) make package pipe assembly optional
Nicolas Peltier created SLING-11731: --- Summary: make package pipe assembly optional Key: SLING-11731 URL: https://issues.apache.org/jira/browse/SLING-11731 Project: Sling Issue Type: Improvement Components: Sling Pipes Affects Versions: pipes 4.5.0 Reporter: Nicolas Peltier For big packages it's preferable to delegate the build to a dedicated action, improvement would be to add a flag "noAssembly" that when set not do any assembly :) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11559) writing relative properties may override resource type of the root
Nicolas Peltier created SLING-11559:
---
Summary: writing relative properties may override resource type of
the root
Key: SLING-11559
URL: https://issues.apache.org/jira/browse/SLING-11559
Project: Sling
Issue Type: Bug
Components: pipes
Affects Versions: pipes 4.5.0
Reporter: Nicolas Peltier
{write foo=blah foo/bar=blah} might override current resource resourceType with
sling:Folder
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11551) switch to parent 49
[ https://issues.apache.org/jira/browse/SLING-11551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-11551. - Assignee: Nicolas Peltier Resolution: Fixed > switch to parent 49 > --- > > Key: SLING-11551 > URL: https://issues.apache.org/jira/browse/SLING-11551 > Project: Sling > Issue Type: Task > Components: pipes >Affects Versions: pipes 4.5.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 4.5.2 > > > task to update to latest parent -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11551) switch to parent 49
[ https://issues.apache.org/jira/browse/SLING-11551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-11551: Fix Version/s: pipes 4.5.2 > switch to parent 49 > --- > > Key: SLING-11551 > URL: https://issues.apache.org/jira/browse/SLING-11551 > Project: Sling > Issue Type: Task > Components: pipes >Affects Versions: pipes 4.5.0 >Reporter: Nicolas Peltier >Priority: Major > Fix For: pipes 4.5.2 > > > task to update to latest parent -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11551) switch to parent 49
Nicolas Peltier created SLING-11551: --- Summary: switch to parent 49 Key: SLING-11551 URL: https://issues.apache.org/jira/browse/SLING-11551 Project: Sling Issue Type: Task Components: pipes Affects Versions: pipes 4.5.0 Reporter: Nicolas Peltier task to update to latest parent -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11495) allow escaped equal signs in command lines for values
[
https://issues.apache.org/jira/browse/SLING-11495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-11495:
Description: right now there is no good way throug command pipes to have
equals signs in values (due to parsing constraints). Introduction of a
{Code}_EQ_{Code} string that is the escaped version of it (was: right now
there is no good way throug command pipes to have equals signs in values (due
to parsing constraints). Introduction of a {{_EQ_}} string that is the escaped
version of it)
> allow escaped equal signs in command lines for values
> -
>
> Key: SLING-11495
> URL: https://issues.apache.org/jira/browse/SLING-11495
> Project: Sling
> Issue Type: Improvement
> Components: pipes
>Affects Versions: pipes 4.4.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: pipes 4.5.0
>
>
> right now there is no good way throug command pipes to have equals signs in
> values (due to parsing constraints). Introduction of a {Code}_EQ_{Code}
> string that is the escaped version of it
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11495) allow escaped equal signs in command lines for values
[
https://issues.apache.org/jira/browse/SLING-11495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-11495:
Description: right now there is no good way throug command pipes to have
equals signs in values (due to parsing constraints). Introduction of a {{_EQ_}}
string that is the escaped version of it (was: right now there is no good way
throug command pipes to have equals signs in values (due to parsing
constraints). Introduction of a "_{_}EQ_{_}" string that is the escaped version
of it)
> allow escaped equal signs in command lines for values
> -
>
> Key: SLING-11495
> URL: https://issues.apache.org/jira/browse/SLING-11495
> Project: Sling
> Issue Type: Improvement
> Components: pipes
>Affects Versions: pipes 4.4.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: pipes 4.5.0
>
>
> right now there is no good way throug command pipes to have equals signs in
> values (due to parsing constraints). Introduction of a {{_EQ_}} string that
> is the escaped version of it
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11495) allow escaped equal signs in command lines for values
[ https://issues.apache.org/jira/browse/SLING-11495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-11495. - Fix Version/s: pipes 4.5.0 Resolution: Fixed > allow escaped equal signs in command lines for values > - > > Key: SLING-11495 > URL: https://issues.apache.org/jira/browse/SLING-11495 > Project: Sling > Issue Type: Improvement > Components: pipes >Affects Versions: pipes 4.4.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Minor > Fix For: pipes 4.5.0 > > > right now there is no good way throug command pipes to have equals signs in > values (due to parsing constraints). Introduction of a "_EQ_" string that is > the escaped version of it -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11495) allow escaped equal signs in command lines for values
[
https://issues.apache.org/jira/browse/SLING-11495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-11495:
Description: right now there is no good way throug command pipes to have
equals signs in values (due to parsing constraints). Introduction of a
"_{_}EQ_{_}" string that is the escaped version of it (was: right now there is
no good way throug command pipes to have equals signs in values (due to parsing
constraints). Introduction of a "_EQ_" string that is the escaped version of it)
> allow escaped equal signs in command lines for values
> -
>
> Key: SLING-11495
> URL: https://issues.apache.org/jira/browse/SLING-11495
> Project: Sling
> Issue Type: Improvement
> Components: pipes
>Affects Versions: pipes 4.4.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: pipes 4.5.0
>
>
> right now there is no good way throug command pipes to have equals signs in
> values (due to parsing constraints). Introduction of a "_{_}EQ_{_}" string
> that is the escaped version of it
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-11495) allow escaped equal signs in command lines for values
[ https://issues.apache.org/jira/browse/SLING-11495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-11495: --- Assignee: Nicolas Peltier > allow escaped equal signs in command lines for values > - > > Key: SLING-11495 > URL: https://issues.apache.org/jira/browse/SLING-11495 > Project: Sling > Issue Type: Improvement > Components: pipes >Affects Versions: pipes 4.4.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Minor > > right now there is no good way throug command pipes to have equals signs in > values (due to parsing constraints). Introduction of a "_EQ_" string that is > the escaped version of it -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11495) allow escaped equal signs in command lines for values
Nicolas Peltier created SLING-11495: --- Summary: allow escaped equal signs in command lines for values Key: SLING-11495 URL: https://issues.apache.org/jira/browse/SLING-11495 Project: Sling Issue Type: Improvement Components: pipes Affects Versions: pipes 4.4.2 Reporter: Nicolas Peltier right now there is no good way throug command pipes to have equals signs in values (due to parsing constraints). Introduction of a "_EQ_" string that is the escaped version of it -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11494) Write pipe should ignore rep:policy
[ https://issues.apache.org/jira/browse/SLING-11494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-11494. - Fix Version/s: pipes 4.5.0 Assignee: Nicolas Peltier Resolution: Fixed https://github.com/apache/sling-org-apache-sling-pipes/commit/b275559c736513bb26c59f849a0cc83f7483b64d > Write pipe should ignore rep:policy > --- > > Key: SLING-11494 > URL: https://issues.apache.org/jira/browse/SLING-11494 > Project: Sling > Issue Type: Bug > Components: pipes >Affects Versions: pipes 4.4.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 4.5.0 > > > rep:policy should not be dubbed by write pipe. If ACLs need to be set in a > pipe execution, ACL Pipe can be used -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11494) Write pipe should ignore rep:policy
Nicolas Peltier created SLING-11494: --- Summary: Write pipe should ignore rep:policy Key: SLING-11494 URL: https://issues.apache.org/jira/browse/SLING-11494 Project: Sling Issue Type: Bug Components: pipes Affects Versions: pipes 4.4.2 Reporter: Nicolas Peltier rep:policy should not be dubbed by write pipe. If ACLs need to be set in a pipe execution, ACL Pipe can be used -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11493) Write pipe should ignore lock properties
[
https://issues.apache.org/jira/browse/SLING-11493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-11493.
-
Fix Version/s: pipes 4.5.0
Assignee: Nicolas Peltier
Resolution: Fixed
https://github.com/apache/sling-org-apache-sling-pipes/commit/6c160c16ad220dbe6168027625bc3dd7191e4b51
> Write pipe should ignore lock properties
>
>
> Key: SLING-11493
> URL: https://issues.apache.org/jira/browse/SLING-11493
> Project: Sling
> Issue Type: Bug
> Components: pipes
>Affects Versions: pipes 4.4.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 4.5.0
>
>
> {color:#172b4d}"jcr:lockIsDeep" and "jcr:lockOwner" should be ignored from
> dubbing
> {color}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11493) Write pipe should ignore lock properties
Nicolas Peltier created SLING-11493:
---
Summary: Write pipe should ignore lock properties
Key: SLING-11493
URL: https://issues.apache.org/jira/browse/SLING-11493
Project: Sling
Issue Type: Bug
Components: pipes
Affects Versions: pipes 4.4.2
Reporter: Nicolas Peltier
{color:#172b4d}"jcr:lockIsDeep" and "jcr:lockOwner" should be ignored from
dubbing
{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11492) write pipe should not try to mark nodes that can't be written with jcr:lastModified
[ https://issues.apache.org/jira/browse/SLING-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-11492. - Fix Version/s: pipes 4.5.0 Resolution: Fixed fixed in https://github.com/apache/sling-org-apache-sling-pipes/commit/a95cf1172c9f578a5a5ca9394528640641916033 > write pipe should not try to mark nodes that can't be written with > jcr:lastModified > --- > > Key: SLING-11492 > URL: https://issues.apache.org/jira/browse/SLING-11492 > Project: Sling > Issue Type: Bug > Components: pipes >Affects Versions: pipes 4.4.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 4.5.0 > > > there are JCR nodes that can't be marked with jcr:lastModified, those should > not be touched at all. > jcr:lastModified can't be put into node: > java.util.GregorianCalendar[time=1658502310596,areFieldsSet=true,areAllFieldsSet=true,lenient=true,zone=sun.util > at > org.apache.sling.jcr.resource.internal.JcrModifiableValueMap.put(JcrModifiableValueMap.java:47) > [org.apache.sling.jcr.resource:3.0.18] > .calendar.ZoneInfo[id="Europe/Paris",offset=360,dstSavings=360,useDaylight=true,transitions=184,lastRule=java.util.SimpleTimeZone[id=Europe/Paris,offset=360,dstSavings=360,useDaylight=tr> > at > org.apache.sling.pipes.internal.PlumberImpl.markWithJcrLastModified(PlumberImpl.java:300) > [org.apache.sling.pipes:4.5.0.SNAPSHOT] > e,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=360,startTimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTime=360,endTimeMode=2]],firstDayOfWeek=2,minim> > at org.apache.sling.pipes.internal.PathPipe.computeOutput(PathPipe.java:93) > [org.apache.sling.pipes:4.5.0.SNAPSHOT] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11492) write pipe should not try to mark nodes that can't be written with jcr:lastModified
[ https://issues.apache.org/jira/browse/SLING-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-11492: --- Assignee: Nicolas Peltier > write pipe should not try to mark nodes that can't be written with > jcr:lastModified > --- > > Key: SLING-11492 > URL: https://issues.apache.org/jira/browse/SLING-11492 > Project: Sling > Issue Type: Bug > Components: pipes >Affects Versions: pipes 4.4.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > > there are JCR nodes that can't be marked with jcr:lastModified, those should > not be touched at all. > jcr:lastModified can't be put into node: > java.util.GregorianCalendar[time=1658502310596,areFieldsSet=true,areAllFieldsSet=true,lenient=true,zone=sun.util > at > org.apache.sling.jcr.resource.internal.JcrModifiableValueMap.put(JcrModifiableValueMap.java:47) > [org.apache.sling.jcr.resource:3.0.18] > .calendar.ZoneInfo[id="Europe/Paris",offset=360,dstSavings=360,useDaylight=true,transitions=184,lastRule=java.util.SimpleTimeZone[id=Europe/Paris,offset=360,dstSavings=360,useDaylight=tr> > at > org.apache.sling.pipes.internal.PlumberImpl.markWithJcrLastModified(PlumberImpl.java:300) > [org.apache.sling.pipes:4.5.0.SNAPSHOT] > e,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=360,startTimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTime=360,endTimeMode=2]],firstDayOfWeek=2,minim> > at org.apache.sling.pipes.internal.PathPipe.computeOutput(PathPipe.java:93) > [org.apache.sling.pipes:4.5.0.SNAPSHOT] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11492) write pipe should not try to mark nodes that can't be written with jcr:lastModified
Nicolas Peltier created SLING-11492: --- Summary: write pipe should not try to mark nodes that can't be written with jcr:lastModified Key: SLING-11492 URL: https://issues.apache.org/jira/browse/SLING-11492 Project: Sling Issue Type: Bug Components: pipes Affects Versions: pipes 4.4.2 Reporter: Nicolas Peltier there are JCR nodes that can't be marked with jcr:lastModified, those should not be touched at all. jcr:lastModified can't be put into node: java.util.GregorianCalendar[time=1658502310596,areFieldsSet=true,areAllFieldsSet=true,lenient=true,zone=sun.util at org.apache.sling.jcr.resource.internal.JcrModifiableValueMap.put(JcrModifiableValueMap.java:47) [org.apache.sling.jcr.resource:3.0.18] .calendar.ZoneInfo[id="Europe/Paris",offset=360,dstSavings=360,useDaylight=true,transitions=184,lastRule=java.util.SimpleTimeZone[id=Europe/Paris,offset=360,dstSavings=360,useDaylight=tr> at org.apache.sling.pipes.internal.PlumberImpl.markWithJcrLastModified(PlumberImpl.java:300) [org.apache.sling.pipes:4.5.0.SNAPSHOT] e,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=360,startTimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTime=360,endTimeMode=2]],firstDayOfWeek=2,minim> at org.apache.sling.pipes.internal.PathPipe.computeOutput(PathPipe.java:93) [org.apache.sling.pipes:4.5.0.SNAPSHOT] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11484) Allow richer AbstractInputStreamPipe http requests
[ https://issues.apache.org/jira/browse/SLING-11484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-11484: --- Assignee: Nicolas Peltier > Allow richer AbstractInputStreamPipe http requests > -- > > Key: SLING-11484 > URL: https://issues.apache.org/jira/browse/SLING-11484 > Project: Sling > Issue Type: Improvement > Components: pipes >Affects Versions: pipes 4.4.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 4.5.0 > > > AbstractInputStreamPipe should allow: > * POST methods (not in dry run), > * request headers -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11484) Allow richer AbstractInputStreamPipe http requests
[ https://issues.apache.org/jira/browse/SLING-11484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-11484. - Resolution: Fixed https://github.com/apache/sling-org-apache-sling-pipes/commit/f75979ef43b483762bb3962b1dfe1ad1ff0c6765 > Allow richer AbstractInputStreamPipe http requests > -- > > Key: SLING-11484 > URL: https://issues.apache.org/jira/browse/SLING-11484 > Project: Sling > Issue Type: Improvement > Components: pipes >Affects Versions: pipes 4.4.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: pipes 4.5.0 > > > AbstractInputStreamPipe should allow: > * POST methods (not in dry run), > * request headers -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11484) Allow richer AbstractInputStreamPipe http requests
[ https://issues.apache.org/jira/browse/SLING-11484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-11484: Fix Version/s: pipes 4.5.0 > Allow richer AbstractInputStreamPipe http requests > -- > > Key: SLING-11484 > URL: https://issues.apache.org/jira/browse/SLING-11484 > Project: Sling > Issue Type: Improvement > Components: pipes >Affects Versions: pipes 4.4.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: pipes 4.5.0 > > > AbstractInputStreamPipe should allow: > * POST methods (not in dry run), > * request headers -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11484) Allow richer AbstractInputStreamPipe http requests
Nicolas Peltier created SLING-11484: --- Summary: Allow richer AbstractInputStreamPipe http requests Key: SLING-11484 URL: https://issues.apache.org/jira/browse/SLING-11484 Project: Sling Issue Type: Improvement Components: pipes Affects Versions: pipes 4.4.2 Reporter: Nicolas Peltier AbstractInputStreamPipe should allow: * POST methods (not in dry run), * request headers -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11278) sling-pipes: Switch to Commons Collections 4
[ https://issues.apache.org/jira/browse/SLING-11278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-11278. - Resolution: Fixed > sling-pipes: Switch to Commons Collections 4 > > > Key: SLING-11278 > URL: https://issues.apache.org/jira/browse/SLING-11278 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: pipes 4.5.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > switch to Commons Collections 4 > this also implies an update of caconfig api 1.2.0/impl 1.5.0 dependencies -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SLING-11278) sling-pipes: Switch to Commons Collections 4
[ https://issues.apache.org/jira/browse/SLING-11278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17532901#comment-17532901 ] Nicolas Peltier commented on SLING-11278: - [~sseifert] no i have not, will check > sling-pipes: Switch to Commons Collections 4 > > > Key: SLING-11278 > URL: https://issues.apache.org/jira/browse/SLING-11278 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: pipes 4.5.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > switch to Commons Collections 4 > this also implies an update of caconfig api 1.2.0/impl 1.5.0 dependencies -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (SLING-11284) sling-pipes: Switch to Bundle Parent 47
[ https://issues.apache.org/jira/browse/SLING-11284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-11284. - Resolution: Fixed > sling-pipes: Switch to Bundle Parent 47 > --- > > Key: SLING-11284 > URL: https://issues.apache.org/jira/browse/SLING-11284 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Stefan Seifert >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 4.5.0 > > Time Spent: 20m > Remaining Estimate: 0h > > switch to latest bundle parent 47. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (SLING-11284) sling-pipes: Switch to Bundle Parent 47
[
https://issues.apache.org/jira/browse/SLING-11284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531638#comment-17531638
]
Nicolas Peltier edited comment on SLING-11284 at 5/5/22 12:04 PM:
--
yeah, more than 4 references here,
{Code}
src/main/java/org/apache/sling/pipes/BasePipe.java:import
org.apache.sling.pipes.internal.bindings.BindingProvider;
src/main/java/org/apache/sling/pipes/OutputWriter.java:import static
org.apache.sling.pipes.internal.CommandUtil.stringToMap;
src/main/java/org/apache/sling/pipes/PipeBindings.java:import
org.apache.sling.pipes.internal.bindings.JxltEngine;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ACLPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.AuthorizablePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.FilterPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.MovePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.MultiPropertyPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.NotPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.PackagePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.PathPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ReferencePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.RemovePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ShallowReferencePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.TraversePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.WritePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.XPathPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.inputstream.CsvPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.inputstream.JsonPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.inputstream.RegexpPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.ChildrenPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.ClosestPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.FindPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.ParentPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.ParentsPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.SiblingsPipe;
{Code}
-so there must be some of those that are accepted- looks like all of them are
a problem, just 4 unique package names
was (Author: npeltier):
yeah, more than 4 references here,
{Code}
src/main/java/org/apache/sling/pipes/BasePipe.java:import
org.apache.sling.pipes.internal.bindings.BindingProvider;
src/main/java/org/apache/sling/pipes/OutputWriter.java:import static
org.apache.sling.pipes.internal.CommandUtil.stringToMap;
src/main/java/org/apache/sling/pipes/PipeBindings.java:import
org.apache.sling.pipes.internal.bindings.JxltEngine;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ACLPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.AuthorizablePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.FilterPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.MovePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.MultiPropertyPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.NotPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.PackagePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.PathPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ReferencePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.RemovePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ShallowReferencePipe;
[jira] [Comment Edited] (SLING-11284) sling-pipes: Switch to Bundle Parent 47
[
https://issues.apache.org/jira/browse/SLING-11284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531638#comment-17531638
]
Nicolas Peltier edited comment on SLING-11284 at 5/5/22 12:03 PM:
--
yeah, more than 4 references here,
{Code}
src/main/java/org/apache/sling/pipes/BasePipe.java:import
org.apache.sling.pipes.internal.bindings.BindingProvider;
src/main/java/org/apache/sling/pipes/OutputWriter.java:import static
org.apache.sling.pipes.internal.CommandUtil.stringToMap;
src/main/java/org/apache/sling/pipes/PipeBindings.java:import
org.apache.sling.pipes.internal.bindings.JxltEngine;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ACLPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.AuthorizablePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.FilterPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.MovePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.MultiPropertyPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.NotPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.PackagePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.PathPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ReferencePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.RemovePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ShallowReferencePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.TraversePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.WritePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.XPathPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.inputstream.CsvPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.inputstream.JsonPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.inputstream.RegexpPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.ChildrenPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.ClosestPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.FindPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.ParentPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.ParentsPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.SiblingsPipe;
{Code}
- so there must be some of those that are accepted - looks like all of them are
a problem, just 4 unique package names
was (Author: npeltier):
yeah, more than 4 references here,
{Code}
src/main/java/org/apache/sling/pipes/BasePipe.java:import
org.apache.sling.pipes.internal.bindings.BindingProvider;
src/main/java/org/apache/sling/pipes/OutputWriter.java:import static
org.apache.sling.pipes.internal.CommandUtil.stringToMap;
src/main/java/org/apache/sling/pipes/PipeBindings.java:import
org.apache.sling.pipes.internal.bindings.JxltEngine;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ACLPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.AuthorizablePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.FilterPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.MovePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.MultiPropertyPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.NotPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.PackagePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.PathPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ReferencePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.RemovePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ShallowReferencePipe;
[jira] [Commented] (SLING-11284) sling-pipes: Switch to Bundle Parent 47
[
https://issues.apache.org/jira/browse/SLING-11284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531638#comment-17531638
]
Nicolas Peltier commented on SLING-11284:
-
yeah, more than 4 references here,
{Code}
src/main/java/org/apache/sling/pipes/BasePipe.java:import
org.apache.sling.pipes.internal.bindings.BindingProvider;
src/main/java/org/apache/sling/pipes/OutputWriter.java:import static
org.apache.sling.pipes.internal.CommandUtil.stringToMap;
src/main/java/org/apache/sling/pipes/PipeBindings.java:import
org.apache.sling.pipes.internal.bindings.JxltEngine;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ACLPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.AuthorizablePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.FilterPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.MovePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.MultiPropertyPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.NotPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.PackagePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.PathPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ReferencePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.RemovePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.ShallowReferencePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.TraversePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.WritePipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.XPathPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.inputstream.CsvPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.inputstream.JsonPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.inputstream.RegexpPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.ChildrenPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.ClosestPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.FindPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.ParentPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.ParentsPipe;
src/main/java/org/apache/sling/pipes/PipeBuilder.java:import
org.apache.sling.pipes.internal.slingquery.SiblingsPipe;
{Code}
so there must be some of those that are accepted
> sling-pipes: Switch to Bundle Parent 47
> ---
>
> Key: SLING-11284
> URL: https://issues.apache.org/jira/browse/SLING-11284
> Project: Sling
> Issue Type: Improvement
> Components: pipes
>Reporter: Stefan Seifert
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 4.4.4
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> switch to latest bundle parent 47.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SLING-11284) sling-pipes: Switch to Bundle Parent 47
[ https://issues.apache.org/jira/browse/SLING-11284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531632#comment-17531632 ] Nicolas Peltier commented on SLING-11284: - sure [~sseifert] i merged your PR(s), i'll fix this > sling-pipes: Switch to Bundle Parent 47 > --- > > Key: SLING-11284 > URL: https://issues.apache.org/jira/browse/SLING-11284 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Stefan Seifert >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 4.4.4 > > Time Spent: 20m > Remaining Estimate: 0h > > switch to latest bundle parent 47. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SLING-11267) Whitespaces in property value recognized as subtoken - Sling Pipes
[
https://issues.apache.org/jira/browse/SLING-11267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier closed SLING-11267.
---
> Whitespaces in property value recognized as subtoken - Sling Pipes
> --
>
> Key: SLING-11267
> URL: https://issues.apache.org/jira/browse/SLING-11267
> Project: Sling
> Issue Type: Bug
> Components: pipes
>Reporter: Marvin Flock
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 4.4.2
>
>
> Actual Behavior:
> Using Sling Pipes Command Executor with whitespaces in a property value will
> recognize everything after the whitespace as another subtoken.
> Expected Behavior:
> Whitespace will be recognized as part of the property value
> Alternatively a way to escape whitespaces would be nice
> Example:
> {code:java}
> curl http://localhost:4502/ \
> -F 'pipe_cmd="echo /content/dam/jcr:content | write test=System
> Default"'{code}
> Code:
> [https://github.com/apache/sling-org-apache-sling-pipes/blob/faa622ef56b90e9edfa793de440fdbf80e74276c/src/main/java/org/apache/sling/pipes/internal/CommandExecutorImpl.java#L489]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (SLING-11267) Whitespaces in property value recognized as subtoken - Sling Pipes
[
https://issues.apache.org/jira/browse/SLING-11267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-11267.
-
Fix Version/s: pipes 4.4.2
Resolution: Fixed
> Whitespaces in property value recognized as subtoken - Sling Pipes
> --
>
> Key: SLING-11267
> URL: https://issues.apache.org/jira/browse/SLING-11267
> Project: Sling
> Issue Type: Bug
> Components: pipes
>Reporter: Marvin Flock
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 4.4.2
>
>
> Actual Behavior:
> Using Sling Pipes Command Executor with whitespaces in a property value will
> recognize everything after the whitespace as another subtoken.
> Expected Behavior:
> Whitespace will be recognized as part of the property value
> Alternatively a way to escape whitespaces would be nice
> Example:
> {code:java}
> curl http://localhost:4502/ \
> -F 'pipe_cmd="echo /content/dam/jcr:content | write test=System
> Default"'{code}
> Code:
> [https://github.com/apache/sling-org-apache-sling-pipes/blob/faa622ef56b90e9edfa793de440fdbf80e74276c/src/main/java/org/apache/sling/pipes/internal/CommandExecutorImpl.java#L489]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (SLING-11267) Whitespaces in property value recognized as subtoken - Sling Pipes
[
https://issues.apache.org/jira/browse/SLING-11267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier reassigned SLING-11267:
---
Assignee: Nicolas Peltier
thanks! looking into it
> Whitespaces in property value recognized as subtoken - Sling Pipes
> --
>
> Key: SLING-11267
> URL: https://issues.apache.org/jira/browse/SLING-11267
> Project: Sling
> Issue Type: Bug
> Components: pipes
>Reporter: Marvin Flock
>Assignee: Nicolas Peltier
>Priority: Major
>
> Actual Behavior:
> Using Sling Pipes Command Executor with whitespaces in a property value will
> recognize everything after the whitespace as another subtoken.
> Expected Behavior:
> Whitespace will be recognized as part of the property value
> Alternatively a way to escape whitespaces would be nice
> Example:
> {code:java}
> curl http://localhost:4502/ \
> -F 'pipe_cmd="echo /content/dam/jcr:content | write test=System
> Default"'{code}
> Code:
> [https://github.com/apache/sling-org-apache-sling-pipes/blob/faa622ef56b90e9edfa793de440fdbf80e74276c/src/main/java/org/apache/sling/pipes/internal/CommandExecutorImpl.java#L489]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (SLING-11041) CsvPipe: InputStream closed before Iterator is finished
[
https://issues.apache.org/jira/browse/SLING-11041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier closed SLING-11041.
---
> CsvPipe: InputStream closed before Iterator is finished
> ---
>
> Key: SLING-11041
> URL: https://issues.apache.org/jira/browse/SLING-11041
> Project: Sling
> Issue Type: Bug
> Components: pipes
>Affects Versions: Pipes 4.3.0
>Reporter: Lukas Kummer
>Priority: Major
> Fix For: Pipes 4.4.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When using the
> [CsvPipe|https://sling.apache.org/documentation/bundles/sling-pipes/readers.html#csv-pipe-csv-expr-1]
> and using a remote source for the expr such as:
> {code:java}
> csv
> https://raw.githubusercontent.com/apache/sling-org-apache-sling-pipes/5660af99a75f36915bbd5b226c459952cb972f30/src/test/resources/standardTest.csv
> | echo ${item.apple}
> {code}
> an Exception will be thrown, that `next()` cannot be called because the
> stream is closed. The reason is, that the AbstractInputStreamPipe is [closing
> the InputStream
> quietly|https://github.com/apache/sling-org-apache-sling-pipes/blob/5660af99a75f36915bbd5b226c459952cb972f30/src/main/java/org/apache/sling/pipes/AbstractInputStreamPipe.java#L118]
> before the CsvIterator has finished it's task.
> One solution could be to delegate the task of closing the InputStream to the
> inherited classes of the Abstract Class (CsvPipe, JsonPipe, RegexPipe).
> Another solution could be to create an AbstractIterator. This iterator could
> also read in the InputStream to a defined size (to limit the used memory)
> into a String. This String can then be used again to create a stream.
> This problem mainly affects CsvPipe and RegexPipe for remote connections. It
> does not affect the JsonPipe because the JsonPipe is reading in the full
> String from the InputStream.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-11165) Make pipes additional script feature toggleable
[ https://issues.apache.org/jira/browse/SLING-11165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-11165. --- > Make pipes additional script feature toggleable > --- > > Key: SLING-11165 > URL: https://issues.apache.org/jira/browse/SLING-11165 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.4.0 > > > some might feel unconfortable with the ability for a given script to depend > on another (remote) script. > To help those :) we could add a toggle that make additional script feature a > toggleable feature -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11041) CsvPipe: InputStream closed before Iterator is finished
[
https://issues.apache.org/jira/browse/SLING-11041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-11041.
-
Resolution: Fixed
> CsvPipe: InputStream closed before Iterator is finished
> ---
>
> Key: SLING-11041
> URL: https://issues.apache.org/jira/browse/SLING-11041
> Project: Sling
> Issue Type: Bug
> Components: pipes
>Affects Versions: Pipes 4.3.0
>Reporter: Lukas Kummer
>Priority: Major
> Fix For: Pipes 4.4.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When using the
> [CsvPipe|https://sling.apache.org/documentation/bundles/sling-pipes/readers.html#csv-pipe-csv-expr-1]
> and using a remote source for the expr such as:
> {code:java}
> csv
> https://raw.githubusercontent.com/apache/sling-org-apache-sling-pipes/5660af99a75f36915bbd5b226c459952cb972f30/src/test/resources/standardTest.csv
> | echo ${item.apple}
> {code}
> an Exception will be thrown, that `next()` cannot be called because the
> stream is closed. The reason is, that the AbstractInputStreamPipe is [closing
> the InputStream
> quietly|https://github.com/apache/sling-org-apache-sling-pipes/blob/5660af99a75f36915bbd5b226c459952cb972f30/src/main/java/org/apache/sling/pipes/AbstractInputStreamPipe.java#L118]
> before the CsvIterator has finished it's task.
> One solution could be to delegate the task of closing the InputStream to the
> inherited classes of the Abstract Class (CsvPipe, JsonPipe, RegexPipe).
> Another solution could be to create an AbstractIterator. This iterator could
> also read in the InputStream to a defined size (to limit the used memory)
> into a String. This String can then be used again to create a stream.
> This problem mainly affects CsvPipe and RegexPipe for remote connections. It
> does not affect the JsonPipe because the JsonPipe is reading in the full
> String from the InputStream.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (SLING-11165) Make pipes additional script feature toggleable
[ https://issues.apache.org/jira/browse/SLING-11165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-11165. - Resolution: Fixed https://github.com/apache/sling-org-apache-sling-pipes/commit/57733a0d9fc02a7071f10faac99836fb266aa128 > Make pipes additional script feature toggleable > --- > > Key: SLING-11165 > URL: https://issues.apache.org/jira/browse/SLING-11165 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.4.0 > > > some might feel unconfortable with the ability for a given script to depend > on another (remote) script. > To help those :) we could add a toggle that make additional script feature a > toggleable feature -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-11165) Make pipes additional script feature toggleable
[ https://issues.apache.org/jira/browse/SLING-11165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498973#comment-17498973 ] Nicolas Peltier commented on SLING-11165: - cc [~pa.hupe] > Make pipes additional script feature toggleable > --- > > Key: SLING-11165 > URL: https://issues.apache.org/jira/browse/SLING-11165 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > > some might feel unconfortable with the ability for a given script to depend > on another (remote) script. > To help those :) we could add a toggle that make additional script feature a > toggleable feature -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-11165) Make pipes additional script feature toggleable
[ https://issues.apache.org/jira/browse/SLING-11165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-11165: Summary: Make pipes additional script feature toggleable (was: Make additional script feature toggleable) > Make pipes additional script feature toggleable > --- > > Key: SLING-11165 > URL: https://issues.apache.org/jira/browse/SLING-11165 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Nicolas Peltier >Priority: Major > > some might feel unconfortable with the ability for a given script to depend > on another (remote) script. > To help those :) we could add a toggle that make additional script feature a > toggleable feature -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (SLING-11165) Make pipes additional script feature toggleable
[ https://issues.apache.org/jira/browse/SLING-11165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-11165: --- Assignee: Nicolas Peltier > Make pipes additional script feature toggleable > --- > > Key: SLING-11165 > URL: https://issues.apache.org/jira/browse/SLING-11165 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > > some might feel unconfortable with the ability for a given script to depend > on another (remote) script. > To help those :) we could add a toggle that make additional script feature a > toggleable feature -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-11165) Make pipes additional script feature toggleable
[ https://issues.apache.org/jira/browse/SLING-11165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-11165: Fix Version/s: Pipes 4.4.0 > Make pipes additional script feature toggleable > --- > > Key: SLING-11165 > URL: https://issues.apache.org/jira/browse/SLING-11165 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.4.0 > > > some might feel unconfortable with the ability for a given script to depend > on another (remote) script. > To help those :) we could add a toggle that make additional script feature a > toggleable feature -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11165) Make additional script feature toggleable
Nicolas Peltier created SLING-11165: --- Summary: Make additional script feature toggleable Key: SLING-11165 URL: https://issues.apache.org/jira/browse/SLING-11165 Project: Sling Issue Type: Improvement Components: pipes Reporter: Nicolas Peltier some might feel unconfortable with the ability for a given script to depend on another (remote) script. To help those :) we could add a toggle that make additional script feature a toggleable feature -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-11041) CsvPipe: InputStream closed before Iterator is finished
[
https://issues.apache.org/jira/browse/SLING-11041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-11041:
Fix Version/s: Pipes 4.4.0
> CsvPipe: InputStream closed before Iterator is finished
> ---
>
> Key: SLING-11041
> URL: https://issues.apache.org/jira/browse/SLING-11041
> Project: Sling
> Issue Type: Bug
> Components: pipes
>Affects Versions: Pipes 4.3.0
>Reporter: Lukas Kummer
>Priority: Major
> Fix For: Pipes 4.4.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When using the
> [CsvPipe|https://sling.apache.org/documentation/bundles/sling-pipes/readers.html#csv-pipe-csv-expr-1]
> and using a remote source for the expr such as:
> {code:java}
> csv
> https://raw.githubusercontent.com/apache/sling-org-apache-sling-pipes/5660af99a75f36915bbd5b226c459952cb972f30/src/test/resources/standardTest.csv
> | echo ${item.apple}
> {code}
> an Exception will be thrown, that `next()` cannot be called because the
> stream is closed. The reason is, that the AbstractInputStreamPipe is [closing
> the InputStream
> quietly|https://github.com/apache/sling-org-apache-sling-pipes/blob/5660af99a75f36915bbd5b226c459952cb972f30/src/main/java/org/apache/sling/pipes/AbstractInputStreamPipe.java#L118]
> before the CsvIterator has finished it's task.
> One solution could be to delegate the task of closing the InputStream to the
> inherited classes of the Abstract Class (CsvPipe, JsonPipe, RegexPipe).
> Another solution could be to create an AbstractIterator. This iterator could
> also read in the InputStream to a defined size (to limit the used memory)
> into a String. This String can then be used again to create a stream.
> This problem mainly affects CsvPipe and RegexPipe for remote connections. It
> does not affect the JsonPipe because the JsonPipe is reading in the full
> String from the InputStream.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11041) CsvPipe: InputStream closed before Iterator is finished
[
https://issues.apache.org/jira/browse/SLING-11041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469227#comment-17469227
]
Nicolas Peltier commented on SLING-11041:
-
[~luckyluke80] we could also move the IS closing to the "after" hook.
> CsvPipe: InputStream closed before Iterator is finished
> ---
>
> Key: SLING-11041
> URL: https://issues.apache.org/jira/browse/SLING-11041
> Project: Sling
> Issue Type: Bug
> Components: pipes
>Affects Versions: Pipes 4.3.0
>Reporter: Lukas Kummer
>Priority: Major
>
> When using the
> [CsvPipe|https://sling.apache.org/documentation/bundles/sling-pipes/readers.html#csv-pipe-csv-expr-1]
> and using a remote source for the expr such as:
> {code:java}
> csv
> https://raw.githubusercontent.com/apache/sling-org-apache-sling-pipes/5660af99a75f36915bbd5b226c459952cb972f30/src/test/resources/standardTest.csv
> | echo ${item.apple}
> {code}
> an Exception will be thrown, that `next()` cannot be called because the
> stream is closed. The reason is, that the AbstractInputStreamPipe is [closing
> the InputStream
> quietly|https://github.com/apache/sling-org-apache-sling-pipes/blob/5660af99a75f36915bbd5b226c459952cb972f30/src/main/java/org/apache/sling/pipes/AbstractInputStreamPipe.java#L118]
> before the CsvIterator has finished it's task.
> One solution could be to delegate the task of closing the InputStream to the
> inherited classes of the Abstract Class (CsvPipe, JsonPipe, RegexPipe).
> Another solution could be to create an AbstractIterator. This iterator could
> also read in the InputStream to a defined size (to limit the used memory)
> into a String. This String can then be used again to create a stream.
> This problem mainly affects CsvPipe and RegexPipe for remote connections. It
> does not affect the JsonPipe because the JsonPipe is reading in the full
> String from the InputStream.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-8651) JsonPipe: Add index option
[
https://issues.apache.org/jira/browse/SLING-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier closed SLING-8651.
--
> JsonPipe: Add index option
> --
>
> Key: SLING-8651
> URL: https://issues.apache.org/jira/browse/SLING-8651
> Project: Sling
> Issue Type: New Feature
> Components: pipes
>Affects Versions: Pipes 3.1.0
>Reporter: Ilyas Türkben
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.3.2
>
>
> Given the following pipe:
> {code:java}
> .json('').with('valuePath','$')
> .name('item')
> .mkdir('${basePath}/jcr:content/config/item${item.index}'){code}
> where json pipe receives a JSON file containing an array of objects and I
> would like to use
> the index of objects in the array when I create nodes using mkdir.
> Currently, my JSON file has those indexes hard coded.
> Considering {{item.index}} might be a custom property in my json file, I
> propose to use {{$index}} for that purpose.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-10916) allow disablement of plumber http access (while leaving plumber up)
[ https://issues.apache.org/jira/browse/SLING-10916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-10916. --- > allow disablement of plumber http access (while leaving plumber up) > --- > > Key: SLING-10916 > URL: https://issues.apache.org/jira/browse/SLING-10916 > Project: Sling > Issue Type: Improvement >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.2 > > > it might be wanted to disable plumber servlet (http triggering of pipes), > while still authorizing execution of pipes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10856) Update to sling parent 41
[ https://issues.apache.org/jira/browse/SLING-10856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10856: Fix Version/s: Pipes 4.3.0 (was: Pipes 4.3.2) > Update to sling parent 41 > - > > Key: SLING-10856 > URL: https://issues.apache.org/jira/browse/SLING-10856 > Project: Sling > Issue Type: Task > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-7772) add other scripting options for pipe expressions
[ https://issues.apache.org/jira/browse/SLING-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-7772. -- > add other scripting options for pipe expressions > > > Key: SLING-7772 > URL: https://issues.apache.org/jira/browse/SLING-7772 > Project: Sling > Issue Type: Improvement > Components: Extensions, pipes >Affects Versions: Pipes 2.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.0.0 > > > nashorn is being deprecated (http://openjdk.java.net/jeps/335). There might > be another option soon, that will be another dependency. > Thinking about it, we should provide an option for script in pipe expression > (which should be fairly easy to do). And may be thinking of changing the > default script engine not to be JS anymore but something that does not need > dependency installed, popular and performant -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-7994) add skipExecution flag to reference pipes
[ https://issues.apache.org/jira/browse/SLING-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-7994. -- > add skipExecution flag to reference pipes > - > > Key: SLING-7994 > URL: https://issues.apache.org/jira/browse/SLING-7994 > Project: Sling > Issue Type: Improvement > Components: Extensions, pipes >Affects Versions: Pipes 3.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.0.0 > > > add a skipExecution flag to pipe, and the superpipe's behaviour to ignore > execution of a subpipe with that flag set -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-9155) Update Testing PaxExam to 3.1.0
[ https://issues.apache.org/jira/browse/SLING-9155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-9155. -- > Update Testing PaxExam to 3.1.0 > --- > > Key: SLING-9155 > URL: https://issues.apache.org/jira/browse/SLING-9155 > Project: Sling > Issue Type: Task > Components: pipes >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Trivial > Fix For: Pipes 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10440) org.apache.sling.pipes.it.PipeModelIT.testListComponent fails from time to time
[ https://issues.apache.org/jira/browse/SLING-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-10440. --- > org.apache.sling.pipes.it.PipeModelIT.testListComponent fails from time to > time > --- > > Key: SLING-10440 > URL: https://issues.apache.org/jira/browse/SLING-10440 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.0 > > > see > https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-pipes/job/master/74/console > for example -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10848) URLs in RegexPipe: Add option to process as String
[ https://issues.apache.org/jira/browse/SLING-10848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-10848. --- > URLs in RegexPipe: Add option to process as String > -- > > Key: SLING-10848 > URL: https://issues.apache.org/jira/browse/SLING-10848 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > If the input(expression) for a RegexPipe is a url (starts with "http"), an > HTTP request to that URL is executed and the response from the HTTP is used > as the input for the RegexPipe. > We have a scenario where we would like to apply a regex to the URL as-is (as > a String). > I would likle to have an option to enable processing URLs as a string on > RegexPipes -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10869) ability to declare (multiline) bindings in pipe scripts
[ https://issues.apache.org/jira/browse/SLING-10869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-10869. --- > ability to declare (multiline) bindings in pipe scripts > --- > > Key: SLING-10869 > URL: https://issues.apache.org/jira/browse/SLING-10869 > Project: Sling > Issue Type: Improvement > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.0 > > > we should be able for sake of ease of use to add multiline bindings (csv or > json mostly) to the text scripts we can reuse in a pipe declared in the same > script -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10849) Sling Pipes IT Test Fail
[ https://issues.apache.org/jira/browse/SLING-10849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-10849. --- > Sling Pipes IT Test Fail > > > Key: SLING-10849 > URL: https://issues.apache.org/jira/browse/SLING-10849 > Project: Sling > Issue Type: Bug >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.0 > > > Steps to Reproduce: > # check out the Sling Pipes source code, master branch > # execute "mvn clean install" > Build fails because of IT Tests: > [ERROR] Errors: > [ERROR] PipeBuilderIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exa... > [ERROR] PipeModelIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exam > [ERROR] PlumberServletIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax > [ERROR] PlumberTestIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exa... > Note: "mvn clean test" command passes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-9517) allow simpler way to add pipes bindings
[
https://issues.apache.org/jira/browse/SLING-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier closed SLING-9517.
--
> allow simpler way to add pipes bindings
> ---
>
> Key: SLING-9517
> URL: https://issues.apache.org/jira/browse/SLING-9517
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Pipes 3.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.3.0
>
>
> execution bindings tend to be more & more used, and having to add bindings
> all the time is cumbersome, this ticket is for having possibility in case
> e.g. we have a root binding to be able to add root=/content as a parameter,
> not binding=\{'root':'/content'}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-10856) Update to sling parent 41
[ https://issues.apache.org/jira/browse/SLING-10856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-10856. --- > Update to sling parent 41 > - > > Key: SLING-10856 > URL: https://issues.apache.org/jira/browse/SLING-10856 > Project: Sling > Issue Type: Task > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10846) Sling Pipes to write metadata on modified resources
[
https://issues.apache.org/jira/browse/SLING-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier closed SLING-10846.
---
> Sling Pipes to write metadata on modified resources
> ---
>
> Key: SLING-10846
> URL: https://issues.apache.org/jira/browse/SLING-10846
> Project: Sling
> Issue Type: Improvement
> Components: pipes
>Reporter: Mariia Lukianets
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: Pipes 4.3.0
>
>
> h4. Background
> Sling Pipes modify content without leaving a trace in the repository.
> Developers should have the ability to mark resources modified by the Sling
> Pipe. While modifying the resource, the 'Write' Sling pipe could also set
> metadata info indicating the time of modification and the author of the
> change.
> *Example*: pipe 'enable-foo' sets the property foo=true on nodeA.
> without metadata:
> nodeA
> foo=true
> with metadata:
> nodeA
> foo = true
> jcr:lastModified = 2021-08-09T11:06:56.753+02:00
> jcr:lastModifiedBy = sling-pipe-enable-foo
> h4.
> h4. Suggestion
> To add a 'metadata' flag to content modification pipes. When set to true, the
> pipe will set 2 properties on each modified resource:
> * 'jcr:lastModified' - current server's DateTime.
> * 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name}'
> By default, the metadata flag is set to false and will do nothing.
> Q1. should we make 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name} on behalf
> of ${user}'?
> Q2. what other pipes to adapt
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-10847) RegexPipe: Allow Patterns from Bindings
[ https://issues.apache.org/jira/browse/SLING-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-10847. --- > RegexPipe: Allow Patterns from Bindings > --- > > Key: SLING-10847 > URL: https://issues.apache.org/jira/browse/SLING-10847 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > > The RegexPipe has a property "pattern". Currently this can only be passed > into the pipe as a fixed string. > I would be helpful to allow the pattern to be read from existing bindings in > the execution scope, so the pattern can be passed from a previous pipe into > the RegexPipe. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10848) URLs in RegexPipe: Add option to process as String
[ https://issues.apache.org/jira/browse/SLING-10848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10848: Fix Version/s: Pipes 4.3.0 (was: Pipes 4.3.2) > URLs in RegexPipe: Add option to process as String > -- > > Key: SLING-10848 > URL: https://issues.apache.org/jira/browse/SLING-10848 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > If the input(expression) for a RegexPipe is a url (starts with "http"), an > HTTP request to that URL is executed and the response from the HTTP is used > as the input for the RegexPipe. > We have a scenario where we would like to apply a regex to the URL as-is (as > a String). > I would likle to have an option to enable processing URLs as a string on > RegexPipes -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10846) Sling Pipes to write metadata on modified resources
[
https://issues.apache.org/jira/browse/SLING-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10846:
Fix Version/s: Pipes 4.3.0
(was: Pipes 4.3.2)
> Sling Pipes to write metadata on modified resources
> ---
>
> Key: SLING-10846
> URL: https://issues.apache.org/jira/browse/SLING-10846
> Project: Sling
> Issue Type: Improvement
> Components: pipes
>Reporter: Mariia Lukianets
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: Pipes 4.3.0
>
>
> h4. Background
> Sling Pipes modify content without leaving a trace in the repository.
> Developers should have the ability to mark resources modified by the Sling
> Pipe. While modifying the resource, the 'Write' Sling pipe could also set
> metadata info indicating the time of modification and the author of the
> change.
> *Example*: pipe 'enable-foo' sets the property foo=true on nodeA.
> without metadata:
> nodeA
> foo=true
> with metadata:
> nodeA
> foo = true
> jcr:lastModified = 2021-08-09T11:06:56.753+02:00
> jcr:lastModifiedBy = sling-pipe-enable-foo
> h4.
> h4. Suggestion
> To add a 'metadata' flag to content modification pipes. When set to true, the
> pipe will set 2 properties on each modified resource:
> * 'jcr:lastModified' - current server's DateTime.
> * 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name}'
> By default, the metadata flag is set to false and will do nothing.
> Q1. should we make 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name} on behalf
> of ${user}'?
> Q2. what other pipes to adapt
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-10847) RegexPipe: Allow Patterns from Bindings
[ https://issues.apache.org/jira/browse/SLING-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10847: Fix Version/s: Pipes 4.3.0 (was: Pipes 4.3.2) > RegexPipe: Allow Patterns from Bindings > --- > > Key: SLING-10847 > URL: https://issues.apache.org/jira/browse/SLING-10847 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > > The RegexPipe has a property "pattern". Currently this can only be passed > into the pipe as a fixed string. > I would be helpful to allow the pattern to be read from existing bindings in > the execution scope, so the pattern can be passed from a previous pipe into > the RegexPipe. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10869) ability to declare (multiline) bindings in pipe scripts
[ https://issues.apache.org/jira/browse/SLING-10869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10869: Fix Version/s: Pipes 4.3.0 (was: Pipes 4.3.2) > ability to declare (multiline) bindings in pipe scripts > --- > > Key: SLING-10869 > URL: https://issues.apache.org/jira/browse/SLING-10869 > Project: Sling > Issue Type: Improvement > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.0 > > > we should be able for sake of ease of use to add multiline bindings (csv or > json mostly) to the text scripts we can reuse in a pipe declared in the same > script -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10849) Sling Pipes IT Test Fail
[ https://issues.apache.org/jira/browse/SLING-10849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10849: Fix Version/s: Pipes 4.3.0 (was: Pipes 4.3.2) > Sling Pipes IT Test Fail > > > Key: SLING-10849 > URL: https://issues.apache.org/jira/browse/SLING-10849 > Project: Sling > Issue Type: Bug >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.0 > > > Steps to Reproduce: > # check out the Sling Pipes source code, master branch > # execute "mvn clean install" > Build fails because of IT Tests: > [ERROR] Errors: > [ERROR] PipeBuilderIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exa... > [ERROR] PipeModelIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exam > [ERROR] PlumberServletIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax > [ERROR] PlumberTestIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exa... > Note: "mvn clean test" command passes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10440) org.apache.sling.pipes.it.PipeModelIT.testListComponent fails from time to time
[ https://issues.apache.org/jira/browse/SLING-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10440: Fix Version/s: Pipes 4.3.0 (was: Pipes 4.3.2) > org.apache.sling.pipes.it.PipeModelIT.testListComponent fails from time to > time > --- > > Key: SLING-10440 > URL: https://issues.apache.org/jira/browse/SLING-10440 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.0 > > > see > https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-pipes/job/master/74/console > for example -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-9517) allow simpler way to add pipes bindings
[
https://issues.apache.org/jira/browse/SLING-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-9517:
---
Fix Version/s: Pipes 4.3.0
(was: Pipes 4.3.2)
> allow simpler way to add pipes bindings
> ---
>
> Key: SLING-9517
> URL: https://issues.apache.org/jira/browse/SLING-9517
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Pipes 3.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.3.0
>
>
> execution bindings tend to be more & more used, and having to add bindings
> all the time is cumbersome, this ticket is for having possibility in case
> e.g. we have a root binding to be able to add root=/content as a parameter,
> not binding=\{'root':'/content'}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (SLING-8651) JsonPipe: Add index option
[
https://issues.apache.org/jira/browse/SLING-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-8651.
Fix Version/s: Pipes 4.3.2
Assignee: Nicolas Peltier
Resolution: Fixed
> JsonPipe: Add index option
> --
>
> Key: SLING-8651
> URL: https://issues.apache.org/jira/browse/SLING-8651
> Project: Sling
> Issue Type: New Feature
> Components: pipes
>Affects Versions: Pipes 3.1.0
>Reporter: Ilyas Türkben
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.3.2
>
>
> Given the following pipe:
> {code:java}
> .json('').with('valuePath','$')
> .name('item')
> .mkdir('${basePath}/jcr:content/config/item${item.index}'){code}
> where json pipe receives a JSON file containing an array of objects and I
> would like to use
> the index of objects in the array when I create nodes using mkdir.
> Currently, my JSON file has those indexes hard coded.
> Considering {{item.index}} might be a custom property in my json file, I
> propose to use {{$index}} for that purpose.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-7425) Add service user and base integration tests on this in sling pipes
[ https://issues.apache.org/jira/browse/SLING-7425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7425: --- Component/s: pipes > Add service user and base integration tests on this in sling pipes > -- > > Key: SLING-7425 > URL: https://issues.apache.org/jira/browse/SLING-7425 > Project: Sling > Issue Type: Improvement > Components: Extensions, pipes >Affects Versions: Pipes 2.0.2 >Reporter: Nicolas Peltier >Priority: Major > > would be better to have a service user in IT so we can test: > - asynchronous registration & execution, > - pipes executed with non admin resolver -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-7729) add basic auth to AbstractInputStreamPipe
[ https://issues.apache.org/jira/browse/SLING-7729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7729: --- Component/s: pipes > add basic auth to AbstractInputStreamPipe > - > > Key: SLING-7729 > URL: https://issues.apache.org/jira/browse/SLING-7729 > Project: Sling > Issue Type: Improvement > Components: Extensions, pipes >Affects Versions: Pipes 2.0.2 >Reporter: Nicolas Peltier >Priority: Major > > being able to point to an URL with AbstractInputStreamPipe is cool, would be > even better if we could set credentials -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-10916) allow disablement of plumber http access (while leaving plumber up)
[ https://issues.apache.org/jira/browse/SLING-10916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10916. - Fix Version/s: Pipes 4.3.2 Resolution: Fixed > allow disablement of plumber http access (while leaving plumber up) > --- > > Key: SLING-10916 > URL: https://issues.apache.org/jira/browse/SLING-10916 > Project: Sling > Issue Type: Improvement >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.2 > > > it might be wanted to disable plumber servlet (http triggering of pipes), > while still authorizing execution of pipes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (SLING-10916) allow disablement of plumber http access (while leaving plumber up)
[ https://issues.apache.org/jira/browse/SLING-10916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-10916: --- Assignee: Nicolas Peltier > allow disablement of plumber http access (while leaving plumber up) > --- > > Key: SLING-10916 > URL: https://issues.apache.org/jira/browse/SLING-10916 > Project: Sling > Issue Type: Improvement >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > > it might be wanted to disable plumber servlet (http triggering of pipes), > while still authorizing execution of pipes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10916) allow disablement of plumber http access (while leaving plumber up)
[ https://issues.apache.org/jira/browse/SLING-10916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10916: Summary: allow disablement of plumber http access (while leaving plumber up) (was: allow disablement of plumber servlet (while leaving plumber up)) > allow disablement of plumber http access (while leaving plumber up) > --- > > Key: SLING-10916 > URL: https://issues.apache.org/jira/browse/SLING-10916 > Project: Sling > Issue Type: Improvement >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Priority: Major > > it might be wanted to disable plumber servlet (http triggering of pipes), > while still authorizing execution of pipes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-10916) allow disablement of plumber servlet (while leaving plumber up)
Nicolas Peltier created SLING-10916: --- Summary: allow disablement of plumber servlet (while leaving plumber up) Key: SLING-10916 URL: https://issues.apache.org/jira/browse/SLING-10916 Project: Sling Issue Type: Improvement Affects Versions: Pipes 4.2.0 Reporter: Nicolas Peltier it might be wanted to disable plumber servlet (http triggering of pipes), while still authorizing execution of pipes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-9517) allow simpler way to add pipes bindings
[
https://issues.apache.org/jira/browse/SLING-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-9517.
Fix Version/s: Pipes 4.3.0
Assignee: Nicolas Peltier
Resolution: Won't Fix
> allow simpler way to add pipes bindings
> ---
>
> Key: SLING-9517
> URL: https://issues.apache.org/jira/browse/SLING-9517
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Pipes 3.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.3.0
>
>
> execution bindings tend to be more & more used, and having to add bindings
> all the time is cumbersome, this ticket is for having possibility in case
> e.g. we have a root binding to be able to add root=/content as a parameter,
> not binding=\{'root':'/content'}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10440) org.apache.sling.pipes.it.PipeModelIT.testListComponent fails from time to time
[ https://issues.apache.org/jira/browse/SLING-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10440. - Fix Version/s: Pipes 4.3.0 Resolution: Duplicate > org.apache.sling.pipes.it.PipeModelIT.testListComponent fails from time to > time > --- > > Key: SLING-10440 > URL: https://issues.apache.org/jira/browse/SLING-10440 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.0 > > > see > https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-pipes/job/master/74/console > for example -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9712) Move pipe should support relative path as expression
[
https://issues.apache.org/jira/browse/SLING-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-9712:
---
Affects Version/s: pipes
> Move pipe should support relative path as expression
>
>
> Key: SLING-9712
> URL: https://issues.apache.org/jira/browse/SLING-9712
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Pipes 3.1.0, pipes
>Reporter: Honwai Wong
>Priority: Major
>
> The Move pipe should support relative paths as argument from the expression.
> Currently, an absolute path needs to be provided which potentially requires
> constructing the full path using ${path}/foo for example.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9523) package pipe should not pass bad init
[ https://issues.apache.org/jira/browse/SLING-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-9523: --- Component/s: pipes > package pipe should not pass bad init > - > > Key: SLING-9523 > URL: https://issues.apache.org/jira/browse/SLING-9523 > Project: Sling > Issue Type: Bug > Components: Extensions, pipes >Affects Versions: Pipes 3.1.0 >Reporter: Nicolas Peltier >Priority: Major > > When something is badly configured with package pipe: > * no path provided, > * already existing package in another folder provided > this results in NPE at the end of referrer call execution, while we do have > the error clearly stated that would be much clearer to output -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-7250) allow non persisted configurations for pipe
[ https://issues.apache.org/jira/browse/SLING-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7250: --- Component/s: pipes > allow non persisted configurations for pipe > --- > > Key: SLING-7250 > URL: https://issues.apache.org/jira/browse/SLING-7250 > Project: Sling > Issue Type: Improvement > Components: Extensions, pipes >Affects Versions: Pipes 1.1.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > > for some usage of the pipe builder, it might be useful not to persist pipes > before executing them -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10849) Sling Pipes IT Test Fail
[ https://issues.apache.org/jira/browse/SLING-10849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10849. - Assignee: Nicolas Peltier Resolution: Fixed added a dependency on plumber servlet that should guarantee readiness of the servlet before the request is done (was observing responses that were default sling servlet's) > Sling Pipes IT Test Fail > > > Key: SLING-10849 > URL: https://issues.apache.org/jira/browse/SLING-10849 > Project: Sling > Issue Type: Bug >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.0 > > > Steps to Reproduce: > # check out the Sling Pipes source code, master branch > # execute "mvn clean install" > Build fails because of IT Tests: > [ERROR] Errors: > [ERROR] PipeBuilderIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exa... > [ERROR] PipeModelIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exam > [ERROR] PlumberServletIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax > [ERROR] PlumberTestIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exa... > Note: "mvn clean test" command passes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10869) ability to declare (multiline) bindings in pipe scripts
[ https://issues.apache.org/jira/browse/SLING-10869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10869. - Fix Version/s: Pipes 4.3.0 Assignee: Nicolas Peltier Resolution: Fixed > ability to declare (multiline) bindings in pipe scripts > --- > > Key: SLING-10869 > URL: https://issues.apache.org/jira/browse/SLING-10869 > Project: Sling > Issue Type: Improvement > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.0 > > > we should be able for sake of ease of use to add multiline bindings (csv or > json mostly) to the text scripts we can reuse in a pipe declared in the same > script -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10869) ability to declare (multiline) bindings in pipe scripts
[ https://issues.apache.org/jira/browse/SLING-10869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10869: Issue Type: Improvement (was: Task) > ability to declare (multiline) bindings in pipe scripts > --- > > Key: SLING-10869 > URL: https://issues.apache.org/jira/browse/SLING-10869 > Project: Sling > Issue Type: Improvement > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Priority: Major > > we should be able for sake of ease of use to add multiline bindings (csv or > json mostly) to the text scripts we can reuse in a pipe declared in the same > script -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10869) ability to declare (multiline) bindings in pipe scripts
Nicolas Peltier created SLING-10869: --- Summary: ability to declare (multiline) bindings in pipe scripts Key: SLING-10869 URL: https://issues.apache.org/jira/browse/SLING-10869 Project: Sling Issue Type: Task Components: pipes Affects Versions: Pipes 4.2.0 Reporter: Nicolas Peltier we should be able for sake of ease of use to add multiline bindings (csv or json mostly) to the text scripts we can reuse in a pipe declared in the same script -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10856) Update to sling parent 41
[ https://issues.apache.org/jira/browse/SLING-10856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10856. - Resolution: Fixed > Update to sling parent 41 > - > > Key: SLING-10856 > URL: https://issues.apache.org/jira/browse/SLING-10856 > Project: Sling > Issue Type: Task > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10856) Update to sling parent 41
[ https://issues.apache.org/jira/browse/SLING-10856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10856: Fix Version/s: Pipes 4.3.0 > Update to sling parent 41 > - > > Key: SLING-10856 > URL: https://issues.apache.org/jira/browse/SLING-10856 > Project: Sling > Issue Type: Task > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10856) Update to sling parent 41
[ https://issues.apache.org/jira/browse/SLING-10856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-10856: --- Assignee: Nicolas Peltier > Update to sling parent 41 > - > > Key: SLING-10856 > URL: https://issues.apache.org/jira/browse/SLING-10856 > Project: Sling > Issue Type: Task > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10856) Update to sling parent 41
Nicolas Peltier created SLING-10856: --- Summary: Update to sling parent 41 Key: SLING-10856 URL: https://issues.apache.org/jira/browse/SLING-10856 Project: Sling Issue Type: Task Components: pipes Affects Versions: Pipes 4.2.0 Reporter: Nicolas Peltier -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10846) Sling Pipes to write metadata on modified resources
[
https://issues.apache.org/jira/browse/SLING-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-10846.
-
Assignee: Nicolas Peltier
Resolution: Fixed
Hey [~lukianet], pls have a look at
https://github.com/apache/sling-org-apache-sling-pipes/commit/de3179f618476c40de8b832b1165b31364384759
and check if it's ok with you
> Sling Pipes to write metadata on modified resources
> ---
>
> Key: SLING-10846
> URL: https://issues.apache.org/jira/browse/SLING-10846
> Project: Sling
> Issue Type: Improvement
> Components: pipes
>Reporter: Mariia Lukianets
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: Pipes 4.3.0
>
>
> h4. Background
> Sling Pipes modify content without leaving a trace in the repository.
> Developers should have the ability to mark resources modified by the Sling
> Pipe. While modifying the resource, the 'Write' Sling pipe could also set
> metadata info indicating the time of modification and the author of the
> change.
> *Example*: pipe 'enable-foo' sets the property foo=true on nodeA.
> without metadata:
> nodeA
> foo=true
> with metadata:
> nodeA
> foo = true
> jcr:lastModified = 2021-08-09T11:06:56.753+02:00
> jcr:lastModifiedBy = sling-pipe-enable-foo
> h4.
> h4. Suggestion
> To add a 'metadata' flag to content modification pipes. When set to true, the
> pipe will set 2 properties on each modified resource:
> * 'jcr:lastModified' - current server's DateTime.
> * 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name}'
> By default, the metadata flag is set to false and will do nothing.
> Q1. should we make 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name} on behalf
> of ${user}'?
> Q2. what other pipes to adapt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10849) Sling Pipes IT Test Fail
[
https://issues.apache.org/jira/browse/SLING-10849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424524#comment-17424524
]
Nicolas Peltier commented on SLING-10849:
-
reproduced it once, looks like an intermittent paxexam osgi context issue.
This time
{Code}
---
Test set: org.apache.sling.pipes.it.PlumberServletIT
---
Tests run: 2, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 20.672 s <<<
FAILURE! - in org.apache.sling.pipes.it.PlumberServletIT
org.apache.sling.pipes.it.PlumberServletIT.testListComponentJson Time elapsed:
2.139 s <<< FAILURE!
java.lang.AssertionError: there should be 2 elements expected:<2> but was:<0>
at
org.apache.sling.pipes.it.PlumberServletIT.testListComponentJson(PlumberServletIT.java:59)
{Code}
> Sling Pipes IT Test Fail
>
>
> Key: SLING-10849
> URL: https://issues.apache.org/jira/browse/SLING-10849
> Project: Sling
> Issue Type: Bug
>Reporter: Ben Zahler
>Priority: Major
> Fix For: Pipes 4.3.0
>
>
> Steps to Reproduce:
> # check out the Sling Pipes source code, master branch
> # execute "mvn clean install"
> Build fails because of IT Tests:
> [ERROR] Errors:
> [ERROR] PipeBuilderIT » TestContainer
> [link:classpath:META-INF/links/org.ops4j.pax.exa...
> [ERROR] PipeModelIT » TestContainer
> [link:classpath:META-INF/links/org.ops4j.pax.exam
> [ERROR] PlumberServletIT » TestContainer
> [link:classpath:META-INF/links/org.ops4j.pax
> [ERROR] PlumberTestIT » TestContainer
> [link:classpath:META-INF/links/org.ops4j.pax.exa...
> Note: "mvn clean test" command passes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10847) RegexPipe: Allow Patterns from Bindings
[ https://issues.apache.org/jira/browse/SLING-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10847. - Resolution: Fixed thanks [~benzahler] and Sonja! > RegexPipe: Allow Patterns from Bindings > --- > > Key: SLING-10847 > URL: https://issues.apache.org/jira/browse/SLING-10847 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > > The RegexPipe has a property "pattern". Currently this can only be passed > into the pipe as a fixed string. > I would be helpful to allow the pattern to be read from existing bindings in > the execution scope, so the pattern can be passed from a previous pipe into > the RegexPipe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10847) RegexPipe: Allow Patterns from Bindings
[ https://issues.apache.org/jira/browse/SLING-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-10847: --- Assignee: Nicolas Peltier > RegexPipe: Allow Patterns from Bindings > --- > > Key: SLING-10847 > URL: https://issues.apache.org/jira/browse/SLING-10847 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > > The RegexPipe has a property "pattern". Currently this can only be passed > into the pipe as a fixed string. > I would be helpful to allow the pattern to be read from existing bindings in > the execution scope, so the pattern can be passed from a previous pipe into > the RegexPipe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10848) URLs in RegexPipe: Add option to process as String
[ https://issues.apache.org/jira/browse/SLING-10848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-10848: --- Assignee: Nicolas Peltier > URLs in RegexPipe: Add option to process as String > -- > > Key: SLING-10848 > URL: https://issues.apache.org/jira/browse/SLING-10848 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > Time Spent: 1h > Remaining Estimate: 0h > > If the input(expression) for a RegexPipe is a url (starts with "http"), an > HTTP request to that URL is executed and the response from the HTTP is used > as the input for the RegexPipe. > We have a scenario where we would like to apply a regex to the URL as-is (as > a String). > I would likle to have an option to enable processing URLs as a string on > RegexPipes -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10848) URLs in RegexPipe: Add option to process as String
[ https://issues.apache.org/jira/browse/SLING-10848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10848. - Resolution: Fixed thanks [~benzahler] and Sonja! > URLs in RegexPipe: Add option to process as String > -- > > Key: SLING-10848 > URL: https://issues.apache.org/jira/browse/SLING-10848 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > Time Spent: 1h > Remaining Estimate: 0h > > If the input(expression) for a RegexPipe is a url (starts with "http"), an > HTTP request to that URL is executed and the response from the HTTP is used > as the input for the RegexPipe. > We have a scenario where we would like to apply a regex to the URL as-is (as > a String). > I would likle to have an option to enable processing URLs as a string on > RegexPipes -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10849) Sling Pipes IT Test Fail
[ https://issues.apache.org/jira/browse/SLING-10849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10849: Fix Version/s: Pipes 4.3.0 > Sling Pipes IT Test Fail > > > Key: SLING-10849 > URL: https://issues.apache.org/jira/browse/SLING-10849 > Project: Sling > Issue Type: Bug >Reporter: Ben Zahler >Priority: Major > Fix For: Pipes 4.3.0 > > > Steps to Reproduce: > # check out the Sling Pipes source code, master branch > # execute "mvn clean install" > Build fails because of IT Tests: > [ERROR] Errors: > [ERROR] PipeBuilderIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exa... > [ERROR] PipeModelIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exam > [ERROR] PlumberServletIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax > [ERROR] PlumberTestIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exa... > Note: "mvn clean test" command passes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10846) Sling Pipes to write metadata on modified resources
[
https://issues.apache.org/jira/browse/SLING-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10846:
Component/s: Extensions
> Sling Pipes to write metadata on modified resources
> ---
>
> Key: SLING-10846
> URL: https://issues.apache.org/jira/browse/SLING-10846
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Reporter: Mariia Lukianets
>Priority: Minor
> Fix For: Pipes 4.3.0
>
>
> h4. Background
> Sling Pipes modify content without leaving a trace in the repository.
> Developers should have the ability to mark resources modified by the Sling
> Pipe. While modifying the resource, the 'Write' Sling pipe could also set
> metadata info indicating the time of modification and the author of the
> change.
> *Example*: pipe 'enable-foo' sets the property foo=true on nodeA.
> without metadata:
> nodeA
> foo=true
> with metadata:
> nodeA
> foo = true
> jcr:lastModified = 2021-08-09T11:06:56.753+02:00
> jcr:lastModifiedBy = sling-pipe-enable-foo
> h4.
> h4. Suggestion
> To add a 'metadata' flag to content modification pipes. When set to true, the
> pipe will set 2 properties on each modified resource:
> * 'jcr:lastModified' - current server's DateTime.
> * 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name}'
> By default, the metadata flag is set to false and will do nothing.
> Q1. should we make 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name} on behalf
> of ${user}'?
> Q2. what other pipes to adapt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10846) Sling Pipes to write metadata on modified resources
[
https://issues.apache.org/jira/browse/SLING-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10846:
Component/s: (was: Extensions)
pipes
> Sling Pipes to write metadata on modified resources
> ---
>
> Key: SLING-10846
> URL: https://issues.apache.org/jira/browse/SLING-10846
> Project: Sling
> Issue Type: Improvement
> Components: pipes
>Reporter: Mariia Lukianets
>Priority: Minor
> Fix For: Pipes 4.3.0
>
>
> h4. Background
> Sling Pipes modify content without leaving a trace in the repository.
> Developers should have the ability to mark resources modified by the Sling
> Pipe. While modifying the resource, the 'Write' Sling pipe could also set
> metadata info indicating the time of modification and the author of the
> change.
> *Example*: pipe 'enable-foo' sets the property foo=true on nodeA.
> without metadata:
> nodeA
> foo=true
> with metadata:
> nodeA
> foo = true
> jcr:lastModified = 2021-08-09T11:06:56.753+02:00
> jcr:lastModifiedBy = sling-pipe-enable-foo
> h4.
> h4. Suggestion
> To add a 'metadata' flag to content modification pipes. When set to true, the
> pipe will set 2 properties on each modified resource:
> * 'jcr:lastModified' - current server's DateTime.
> * 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name}'
> By default, the metadata flag is set to false and will do nothing.
> Q1. should we make 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name} on behalf
> of ${user}'?
> Q2. what other pipes to adapt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10846) Sling Pipes to write metadata on modified resources
[
https://issues.apache.org/jira/browse/SLING-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423184#comment-17423184
]
Nicolas Peltier commented on SLING-10846:
-
i think we should keep jcr:lastModifiedBy to be user name, i like though the
tracking of pipe used for that modification. May be in another property.
I wonder also if we should not need an opt out for that last property
> Sling Pipes to write metadata on modified resources
> ---
>
> Key: SLING-10846
> URL: https://issues.apache.org/jira/browse/SLING-10846
> Project: Sling
> Issue Type: Improvement
>Reporter: Mariia Lukianets
>Priority: Minor
> Fix For: Pipes 4.3.0
>
>
> h4. Background
> Sling Pipes modify content without leaving a trace in the repository.
> Developers should have the ability to mark resources modified by the Sling
> Pipe. While modifying the resource, the 'Write' Sling pipe could also set
> metadata info indicating the time of modification and the author of the
> change.
> *Example*: pipe 'enable-foo' sets the property foo=true on nodeA.
> without metadata:
> nodeA
> foo=true
> with metadata:
> nodeA
> foo = true
> jcr:lastModified = 2021-08-09T11:06:56.753+02:00
> jcr:lastModifiedBy = sling-pipe-enable-foo
> h4.
> h4. Suggestion
> To add a 'metadata' flag to content modification pipes. When set to true, the
> pipe will set 2 properties on each modified resource:
> * 'jcr:lastModified' - current server's DateTime.
> * 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name}'
> By default, the metadata flag is set to false and will do nothing.
> Q1. should we make 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name} on behalf
> of ${user}'?
> Q2. what other pipes to adapt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10846) Sling Pipes to write metadata on modified resources
[
https://issues.apache.org/jira/browse/SLING-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10846:
Fix Version/s: Pipes 4.3.0
> Sling Pipes to write metadata on modified resources
> ---
>
> Key: SLING-10846
> URL: https://issues.apache.org/jira/browse/SLING-10846
> Project: Sling
> Issue Type: Improvement
>Reporter: Mariia Lukianets
>Priority: Minor
> Fix For: Pipes 4.3.0
>
>
> h4. Background
> Sling Pipes modify content without leaving a trace in the repository.
> Developers should have the ability to mark resources modified by the Sling
> Pipe. While modifying the resource, the 'Write' Sling pipe could also set
> metadata info indicating the time of modification and the author of the
> change.
> *Example*: pipe 'enable-foo' sets the property foo=true on nodeA.
> without metadata:
> nodeA
> foo=true
> with metadata:
> nodeA
> foo = true
> jcr:lastModified = 2021-08-09T11:06:56.753+02:00
> jcr:lastModifiedBy = sling-pipe-enable-foo
> h4.
> h4. Suggestion
> To add a 'metadata' flag to content modification pipes. When set to true, the
> pipe will set 2 properties on each modified resource:
> * 'jcr:lastModified' - current server's DateTime.
> * 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name}'
> By default, the metadata flag is set to false and will do nothing.
> Q1. should we make 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name} on behalf
> of ${user}'?
> Q2. what other pipes to adapt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10848) URLs in RegexPipe: Add option to process as String
[ https://issues.apache.org/jira/browse/SLING-10848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10848: Fix Version/s: Pipes 4.3.0 > URLs in RegexPipe: Add option to process as String > -- > > Key: SLING-10848 > URL: https://issues.apache.org/jira/browse/SLING-10848 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Priority: Minor > Fix For: Pipes 4.3.0 > > > If the input(expression) for a RegexPipe is a url (starts with "http"), an > HTTP request to that URL is executed and the response from the HTTP is used > as the input for the RegexPipe. > We have a scenario where we would like to apply a regex to the URL as-is (as > a String). > I would likle to have an option to enable processing URLs as a string on > RegexPipes -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10847) RegexPipe: Allow Patterns from Bindings
[ https://issues.apache.org/jira/browse/SLING-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10847: Fix Version/s: PIpes 4.3.0 > RegexPipe: Allow Patterns from Bindings > --- > > Key: SLING-10847 > URL: https://issues.apache.org/jira/browse/SLING-10847 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Priority: Minor > Fix For: PIpes 4.3.0 > > > The RegexPipe has a property "pattern". Currently this can only be passed > into the pipe as a fixed string. > I would be helpful to allow the pattern to be read from existing bindings in > the execution scope, so the pattern can be passed from a previous pipe into > the RegexPipe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10816) left tokens of pipe commands should parse expression too
[
https://issues.apache.org/jira/browse/SLING-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10816:
Fix Version/s: Pipes 4.2.0
> left tokens of pipe commands should parse expression too
>
>
> Key: SLING-10816
> URL: https://issues.apache.org/jira/browse/SLING-10816
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.1.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.2.0
>
>
> write ${some.expr}=foo is not possible from commands while the pipe itself
> supports it
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10816) left tokens of pipe commands should parse expression too
[
https://issues.apache.org/jira/browse/SLING-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-10816.
-
Resolution: Fixed
> left tokens of pipe commands should parse expression too
>
>
> Key: SLING-10816
> URL: https://issues.apache.org/jira/browse/SLING-10816
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.1.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.2.0
>
>
> write ${some.expr}=foo is not possible from commands while the pipe itself
> supports it
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
