[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on issue #12: SLING-8982 - dynamic-include: upgrade to parent pom 35

2020-01-10 Thread GitBox
rombert commented on issue #12: SLING-8982 - dynamic-include: upgrade to parent 
pom 35
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/12#issuecomment-573054240
 
 
   Based on the discussion from 
[SLING-8987](https://issues.apache.org/jira/browse/SLING-8987) I've removed 
**all** package exports. My assumption is that none are actually used, but I'll 
wait for more feedback before proceeding.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on issue #12: SLING-8982 - dynamic-include: upgrade to parent pom 35

2020-01-10 Thread GitBox
rombert commented on issue #12: SLING-8982 - dynamic-include: upgrade to parent 
pom 35
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/12#issuecomment-573017316
 
 
   @ericvangeem, @scotty6435 , @briankasingli , @toniedzwiedz  - from recent 
activity you are using SDI in your projects. I have migrated the SDI project to 
the bnd annotations, it would be great if you could test if things still work 
with the changes from this PR.
   
   Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services