[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #32: SLING-11923 : fixed IT failures for JDK 17
stefan-egli commented on PR #32: URL: https://github.com/apache/sling-org-apache-sling-event/pull/32#issuecomment-1640246129 @rishabhdaim , looks like it might not be a flaky test so much anymore - but maybe it's just a very slow piece of hardware used - could you please increase the `sleep(5000)` [here in your fork](https://github.com/rishabhdaim/sling-org-apache-sling-event/blob/SLING-11923/src/test/java/org/apache/sling/event/impl/discovery/InitDelayingTopologyEventListenerTest.java#L307) to eg `sleep(1)` - just to check? thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #32: SLING-11923 : fixed IT failures for JDK 17
stefan-egli commented on PR #32: URL: https://github.com/apache/sling-org-apache-sling-event/pull/32#issuecomment-1639963865 @rishabhdaim * good point about updating the wiki. Something along the lines of "paxexam 4.0 is required for Java 17" ? * `.java-version` : noticed you added this file, do we need this? ``` SLING-11923 : removed jacoco while using pax exam 4 ``` I'll ignore the test failures prior to [run 6](https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-event/job/PR-32/6/) then. Run 6 itself had a test fialure with `InitDelayingTopologyEventListenerTest.testProperties`, so perhaps that's an actual flaky test. I'd like to do some more test rounds to get a better understanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #32: SLING-11923 : fixed IT failures for JDK 17
stefan-egli commented on PR #32: URL: https://github.com/apache/sling-org-apache-sling-event/pull/32#issuecomment-1634433620 (reran the tests to see if it was a flaky failure) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
