Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060868380 Thanks for your patience @sufyanharoon, I started a release vote: https://lists.apache.org/thread/lfkj8cjfswcp3nnqx3s1mxrmd99rs1wl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert merged PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060740880 @rombert LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060672290 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=8) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-teleporter=8=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=8=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-junit-teleporter=8=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=8=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060615568 Thanks for the revierw @sufyanharoon . I made the additional change now, let me know if that solves the issue completely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060088293 Thanks @rombert. Later on, I had changed the scope to runtime as these are not needed for compile but needed at runtime for tests to run. Similar to Line#98 in the pom. If you could change it, it would be good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2059914892 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=8) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-teleporter=8=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=8=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-junit-teleporter=8=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=8=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2059430499 @sufyanharoon - I added a small comment on top of your changes from #7 , hope this is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert opened a new pull request, #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2059409129 Hm, why did this get closed? I don't remember deleting this branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert closed pull request #7: SLING-11633 - Compile with Java 11 URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2058609691 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=7) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-teleporter=7=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=7=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-junit-teleporter=7=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=7=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=7) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2055066934 @rombert, yes adding the two additional jars to the class path should fix this issue but before we upgraded to Java 11, it used to work seamlessly. This is a side effect of update of Java 11 where we have updated certain dependencies. As I stated earlier, anyone using latest teleporter will have to add these dependencies in their test class path. For that, the same should be documented on teleporter's [page](https://sling.apache.org/documentation/bundles/org-apache-sling-junit-bundles.html) under upgrade to Java 11 runtime otherwise everyone will struggle with the same issue that faced. Do you see any issues in adding these additional jars as dependencies? These will make update to Java 11 and general usage of teleporter seamless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2049712912 @sufyanharoon - I agree that it can be used as a plain jar, but if you build it you will see that it's an OSGi bundle - https://github.com/apache/sling-org-apache-sling-junit-teleporter/blob/3de6bd052bcb1c7b59bcf6c7a660bc2be5ead532/pom.xml#L24 ``` $ cat target/classes/META-INF/MANIFEST.MF | grep 'Bundle-SymbolicName' Bundle-SymbolicName: org.apache.sling.junit.teleporter ``` Won't your scenario be fixed if you add the two extra jars to the classpath? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2045119495 @rombert, teleporter is not a bundle and is not supposed to be deployed in OSGI container. It is a jar which provides a test framework and is supposed to be used for writing tests in a module and used as a test dependency. When tests are executed, this module creates a bundle on runtime, installs it on OSGI server and executes the test and uninstalls the bundles. The dependencies I have added are required during test execution on client side. Hence, should be added here to be available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2044726714 @sufyanharoon - I'm not an expert of the module here, but I see it's packaged as a bundle as well, so we should not explicitly declare dependencies and rather let OSGi runtime point out what is needed. But perhaps you are using it differently? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2044717676 >What problem does this solve? When using the latest build of teleporter in tests, these dependencies were not coming transitively. When added in tests, it worked. Ideally, these should come transitively as teleporter code only is using them. cc: @rombert -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2044556812 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=7) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-teleporter=7=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=7=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-junit-teleporter=7=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=7=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=7) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2044550283 @rombert Please review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon opened a new pull request, #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert merged PR #5: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/5#issuecomment-2042660900 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=5) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-teleporter=5=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=5=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-junit-teleporter=5=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=5=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/5#issuecomment-2042649905 @sufyanharoon - FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-2042614227 @sufyanharoon - I'll start a release vote today, thanks for the reminder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-2042306162 Thanks @rombert. Can you please help in release this component as well? Or whom should I reach out to for release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert merged PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1985394188 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=4) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=4=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=4) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1985389084 @rombert I have refreshed the PR. Please review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1985362787 @rombert yes, I meant the spotless-maven-plugin only. First I tried to update to parent version 60 and then this plugin enforced the formatting changes. I had to downgrade to parent 50 due to some issues with Java dependency but I didn't revert changes due to spotless plugin. I will revert those changes and update the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1983151463 > @sufyanharoon - can you please disable that plug-in and ensure that there are no formatting changes? Did you mean the spotless-maven-plugin? IIRC that is only active for parent version 60 or newer, see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=284790344 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1983018716 @sufyanharoon - can you please disable that plug-in and ensure that there are no formatting changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1982439294 @rombert I didn't add the white spaces intentionally. There is a plugin (I am forgetting the name) configured when aligning with latest parent-pom which is not letting the build pass till it formats the files as per configured specification. Can you please review it? cc: @bdelacretaz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1961317550 @sufyanharoon - thanks for the PR. You asked me about > Detected JDK version 11.0.16-1 (JAVA_HOME=/usr/local/asfpackages/java/adoptium-jdk-11.0.16.1+1) is not in the allowed range [17,). But this does not seem to be a problem anymore. It would be great if you could remove the whitespace changes, there seem to be a lots of those and it's making the change hard to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1940410525 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=4) **Quality Gate failed** Failed conditions  [18.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=4=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=4) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1938536348 @rombert , I am trying to run this PR and it is failing in Jenkins with the following issue `Detected JDK version 11.0.16-1 (JAVA_HOME=/usr/local/asfpackages/java/adoptium-jdk-11.0.16.1+1) is not in the allowed range [17,).` The sling parent pom enforces v60 enforces Java 17 as min build requirement but the worker node on Jenkins doesn't have Java 17 installed. Can you please help here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1938411088 @bdelacretaz, can you please review it? This is needed for running tests with Java 11 using teleporter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon opened a new pull request, #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4 When teleported 1.0.22 is used with Java 11.0.22 then the plugin fails -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
