Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-11 Thread via GitHub


stefanseifert merged PR #12:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-11 Thread via GitHub


sonarcloud[bot] commented on PR #12:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#issuecomment-2049560447

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12=new_accepted_issues=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [100.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12=new_coverage=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-11 Thread via GitHub


stefanseifert commented on code in PR #12:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#discussion_r1560922574


##
pom.xml:
##
@@ -45,7 +45,7 @@
 
 1.44.0

Review Comment:
   i've created 
[SLING-12287](https://issues.apache.org/jira/browse/SLING-12287) for the oak 
version discussion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-11 Thread via GitHub


csaboka commented on code in PR #12:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#discussion_r1560500748


##
pom.xml:
##
@@ -45,7 +45,7 @@
 
 1.44.0

Review Comment:
   I think this change would be better done in a separate PR, with a related 
Jira ticket since it's unrelated to the goal of this ticket and PR. I would 
rather someone else did it, someone who understands the implications.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-10 Thread via GitHub


reschke commented on code in PR #12:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#discussion_r1560466861


##
pom.xml:
##
@@ -45,7 +45,7 @@
 
 1.44.0

Review Comment:
   These versions of Oak and Jackrabbit are EOLd.
   
   Please use the latest maintenance branch versions (Jackrabbit 2.20.15 and 
Oak 1.22.19).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-10 Thread via GitHub


csaboka commented on PR #12:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#issuecomment-2047124607

   This change depends on 
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/39 . 
It won't build properly until that PR is merged. This is expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-10 Thread via GitHub


csaboka opened a new pull request, #12:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org