Re: [PR] SLING-12312 add jakarta.servlet support in RequestLocaleResolve [sling-org-apache-sling-i18n]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/13#issuecomment-2297379520 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n&pullRequest=13&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n&pullRequest=13&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-i18n&pullRequest=13&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12312 add jakarta.servlet support in RequestLocaleResolve [sling-org-apache-sling-i18n]
rombert commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/13#issuecomment-2107431441 > Why can't the EE8 loyalists just stay on the old version of org.apache.sling.i18n? I don't think "loyalists" is the right term here. And we don't typically get to chose how our users manage their deployments. I'll start a dev@sling thread on this, I think it's important to have a clear policy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12312 add jakarta.servlet support in RequestLocaleResolve [sling-org-apache-sling-i18n]
enapps-enorman commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/13#issuecomment-2099146151 > This way the package has a dependency on both javax.servlet and jakarta.servlet and will not work for older environments. Was that the intention? I would prefer to get rid of the javax.servlet (EE8) but that is not possible yet so both have to be there for now. Community support for all the versions of jetty that don't support EE9 or later have been [eol](https://endoflife.date/eclipse-jetty) for a while now. I guess I don't expect that people who don't upgrade anything and keep using eol software should get to decide what can be changed. Progress requires moving forward. org.apache.felix.http.jetty 5.x and org.apache.felix.http.jetty12 1.x both support servlets using either javax.servlet or jakarta.servlet Why can't the EE8 loyalists just stay on the old version of org.apache.sling.i18n? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12312 add jakarta.servlet support in RequestLocaleResolve [sling-org-apache-sling-i18n]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/13#issuecomment-2095051714 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n&pullRequest=13&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-i18n&pullRequest=13&resolved=false&inNewCodePeriod=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12312 add jakarta.servlet support in RequestLocaleResolve [sling-org-apache-sling-i18n]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/13#issuecomment-2094361258 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n&pullRequest=13&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-i18n&pullRequest=13&resolved=false&inNewCodePeriod=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12312 add jakarta.servlet support in RequestLocaleResolve [sling-org-apache-sling-i18n]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/13#issuecomment-2093942922 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n&pullRequest=13&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-i18n&pullRequest=13&resolved=false&inNewCodePeriod=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12312 add jakarta.servlet support in RequestLocaleResolve [sling-org-apache-sling-i18n]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/13#issuecomment-2093900760 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n&pullRequest=13&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-i18n&pullRequest=13&resolved=false&inNewCodePeriod=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12312 add jakarta.servlet support in RequestLocaleResolve [sling-org-apache-sling-i18n]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/13#issuecomment-2093895850 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n&pullRequest=13&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-i18n&pullRequest=13&resolved=false&inNewCodePeriod=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12312 add jakarta.servlet support in RequestLocaleResolve [sling-org-apache-sling-i18n]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/13#issuecomment-2093887440 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n&pullRequest=13&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-i18n&pullRequest=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12312 add jakarta.servlet support in RequestLocaleResolve [sling-org-apache-sling-i18n]
enapps-enorman opened a new pull request, #13: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/13 provide a variant of the RequestLocaleResolver#resolveLocale call that accepts a jakarta.servlet.http.HttpServletRequest for use cases that have migrated to EE9 or later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
