Re: [PR] SLING-12318 apply spotless formatting [sling-org-apache-sling-engine]

[via GitHub]

rombert merged PR #44:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/44


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12318 apply spotless formatting [sling-org-apache-sling-engine]

[via GitHub]

sonarcloud[bot] commented on PR #44:
URL: 
https://github.com/apache/sling-org-apache-sling-engine/pull/44#issuecomment-2113699160

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=44)
 **Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [34.5% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=44&metric=new_coverage&view=list)
 (required ≥ 80%)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=44)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12318 apply spotless formatting [sling-org-apache-sling-engine]

[via GitHub]

joerghoh commented on PR #44:
URL: 
https://github.com/apache/sling-org-apache-sling-engine/pull/44#issuecomment-2113422171

   @rombert When I tried to make the update of the parent pom and the test 
dependencies, the spotless plugin failed the build for me; and for that reason 
I wanted to have the formatting change before I do the update of the pom.
   
   In other words: we need #44 **and** #45 merged (preferably in this order).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12318 apply spotless formatting [sling-org-apache-sling-engine]

[via GitHub]

rombert commented on PR #44:
URL: 
https://github.com/apache/sling-org-apache-sling-engine/pull/44#issuecomment-2112750535

   @joerghoh - I think I already fixed the Java 21 build ... #45 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12318 apply spotless formatting [sling-org-apache-sling-engine]

[via GitHub]

joerghoh commented on PR #44:
URL: 
https://github.com/apache/sling-org-apache-sling-engine/pull/44#issuecomment-2112724636

   (failed for not building on Java 21, which I plan to fix asap)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org