[RESULT] [VOTE] Release Apache Sling Servlet Helpers 1.4.4

2023-03-11 Thread Robert Munteanu 
Hi,

The vote has passed with the following result:

+1 (binding): Stefan Seifert, Oliver Lietz, Robert Munteanu
+1 (non-binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Robert Munteanu

Re: [VOTE] Release Apache Sling Servlet Helpers 1.4.4

2023-03-11 Thread Robert Munteanu 
On Tue, 2023-03-07 at 10:48 +, Robert Munteanu wrote:
> Please vote to approve this release:

+1
Robert

Hamcrest vs. AssertJ ( was: [VOTE] Release Apache Sling Servlet Helpers 1.4.4)

2023-03-09 Thread Robert Munteanu 
On Thu, 2023-03-09 at 13:00 +0100, Oliver Lietz wrote:
> Was there any reason to not use Hamcrest (what we usually use,
> instead of 
> AssertJ)?

I simply find AssertJ nicer and I started using it everywhere.

On top of that, JUnit 5 does not half-bundle any assertion library
anymore [1], so one of my main reasons to go with Hamcrest is gone.

Thanks,
Robert

[1]: https://github.com/junit-team/junit5/issues/147

Re: [VOTE] Release Apache Sling Servlet Helpers 1.4.4

2023-03-09 Thread Oliver Lietz 
On Tuesday, 7 March 2023 11:48:19 CET Robert Munteanu wrote:
> Hi,
> 
> We solved 1 issue in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12348413
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2722/
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=ch
> eck_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2722 /tmp/sling-staging

+1

Was there any reason to not use Hamcrest (what we usually use, instead of 
AssertJ)?

O.

RE: [VOTE] Release Apache Sling Servlet Helpers 1.4.4

2023-03-07 Thread Stefan Seifert 
+1

stefan

[VOTE] Release Apache Sling Servlet Helpers 1.4.4

2023-03-07 Thread Robert Munteanu 
Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12348413

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2722/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2722 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu