[
https://issues.apache.org/jira/browse/SLING-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021869#comment-16021869
]
Stefan Seifert edited comment on SLING-6871 at 5/23/17 9:10 PM:
in my pov the implementation of the ticks conversion is incomplete. it's not
possible to put ' or " in strings quoted in ticks.
in context of SLING-6872 i've refactored your code and added additional unit
tests to cover this as well:
https://github.com/apache/sling/blob/trunk/bundles/jcr/contentparser/src/main/java/org/apache/sling/jcr/contentparser/impl/JsonTicksConverter.java
(in SLING-6634 it was planned to migrate JCR content loader to use JCR content
parser as well, but this is a non-trivial task - even for JSON - and would
required a good deal of refactoring in JCR content loader; so we cannot just do
it here to reuse the logic directly)
was (Author: sseif...@pro-vision.de):
in my pov the implementation of the ticks conversion is incomplete. it's not
possible to put ' or " in strings quoted in ticks.
in context of SLING-6872 i've refactored your code and added additional unit
tests to cover this as well.
(in SLING-6634 it was planned to migrate JCR content loader to use JCR content
parser as well, but this is a non-trivial task - even for JSON - and would
required a good deal of refactoring in JCR content loader; so we cannot just do
it here to reuse the logic directly)
> JsonReader should allow tick as well as double quotes on import.
>
>
> Key: SLING-6871
> URL: https://issues.apache.org/jira/browse/SLING-6871
> Project: Sling
> Issue Type: Bug
> Components: JCR
>Affects Versions: JCR ContentLoader 2.2.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
> Fix For: JCR ContentLoader 2.2.2
>
>
> I think we have to relax the json parsing at least for the contentloader
> import case. It's just to likely that people will use ticks instead of double
> quotes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
