[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1741#comment-1741 ] Stefan Seifert commented on SLING-10840: +1 the servlet-helpers bundle still fulfills it's initial purpose to back Sling Mocks & Co - but this it not object to any validation as it's only used in unit tests > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422194#comment-17422194 ] Carsten Ziegeler commented on SLING-10840: -- So my suggest is that we implement SLING-8742 and move the two builder classes to either API or Engine. Whatever classes those builders need in addition will be private > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422186#comment-17422186 ] Bertrand Delacretaz commented on SLING-10840: - FWIW you can see an example of the GraphQL core making an internal request to get a schema for the current request using an internal request [in the DefaultSchemaProvider class|https://github.com/apache/sling-org-apache-sling-graphql-core/blob/1ea954e36e626d0c89ddc93655d71b9300f26e88/src/main/java/org/apache/sling/graphql/core/schema/DefaultSchemaProvider.java#L55]. > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422151#comment-17422151 ] Roy Teeuwen commented on SLING-10840: - I indeed have the same requirement as [~empire29], having requests to internal things and I don't want to use the main Request for this and polute it. Maybe since the changes that [~bdelacretaz] did for the GraphQL, this can be done more easily now, in the past we had to do this based on creating "mock requests" and "mock responses" to then add that to the actual request / response after processing has been done for those request / responses > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422138#comment-17422138 ] Carsten Ziegeler commented on SLING-10840: -- Yes, an update of the api probably also needs an update of the implementation, so that needs to be provided by the product you are using. I guess we can debate a long time about what makes a clean solution in that area :) > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422116#comment-17422116 ] David Gonzalez commented on SLING-10840: [~cziegeler] If the bundle shouldn't be used at runtime then it makes sense to document as such (maybe highlight the change in guidance). SLING-8742 looks like it would suffice for my use-cases (double checked, my 2nd use-case also comes down to having to override RequestPathInfo since I cannot specify (in this case, nullify) the extension attribute. I assume I would need to let the CMS's I'm deploying include (ex. Service Pack, etc.) the new sling bundle containing SLING-8742, rather than "bringing it with me" to support the back compatibility of my application with the earlier product versions? FWIW - The Internal request and responses can certainly be nice for orchestrating multiple calls to Sling resources and then doing merging, transforming, etc. the results. This if often the cleanest way especially when you are making calls to resources/end-points provided by a product, and you otherwise have no real way of invoking/accessing. Obviously, developers always need to be careful about getting too much data (ex. binary) in memory, but (IMO) its cleaner, and simpler code to be able to invoke isolated internal request/responses rather than trying to piggyback on "real" request/response w/ wrappers and hope you don't accidentally mess something up (like something issuing a re-direct that gets flushed before you've finished doing your work). If we (you :)) could figure out a safe way to do this, i think it would be helpful to Sling dev community. (or if you have other established patterns that are as clean/simple that works too) > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in >
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422003#comment-17422003 ] Carsten Ziegeler commented on SLING-10840: -- Yes, there are different use cases - many use cases I've seen so far could be solved by using the wrapper classes around an existing request/response. However, there seem to be some use cases like the one from David where even that does not help. But that could be solved in the dispatcher implementation. I think remaining are use cases, where you don't have a request/response and need to create an artifical one - this is where this bundle might come into play. We could think about adding a factory (or builder) api to the engine bundle as the engine bundle contains the processor service and locally these belong together. > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[
https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421977#comment-17421977
]
Bertrand Delacretaz commented on SLING-10840:
-
As stated in the docs at
[https://sling.apache.org/documentation/bundles/servlet-helpers.html] I think
one good reason to use the servlet helpers bundle in production is the
{{SlingInternalRequest}} and {{ServletInternalRequest}} helpers, which make
internal requests simple and clean.
I think these services correctly hide their implementation details, returning a
{{SlingHttpServletResponse}} for example, so changing the underlying
request/response objects should be possible if needed.
Maybe these services should have been implemented in a different bundle which
only exports the package that allows using them. The servlets helpers bundle
also exports the {{org.apache.sling.servlethelpers}} package, which IIUC
contains the problematic classes discussed here.
> Sling Servlet Helpers implements @ProviderType interfaces
> -
>
> Key: SLING-10840
> URL: https://issues.apache.org/jira/browse/SLING-10840
> Project: Sling
> Issue Type: Bug
> Components: General
>Affects Versions: Servlet Helpers 1.4.2
>Reporter: David Gonzalez
>Priority: Major
>
> When using the Sling Servlet Helpers bundle/API, code quality scans detect
> that implentations in the Sling Servlet Helpers bundle implement
> @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here
> are some fo the examples (though probably not exhaustive) I found when
> attempting to use ths Servlet Helpers library.
>
> |The product interface org.apache.sling.api.request.RequestParameter
> annotated with @ProviderType should not be implemented by custom code.
> Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in
> /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.|
> |The product interface org.apache.sling.api.request.RequestParameterMap
> annotated with @ProviderType should not be implemented by custom code.
> Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained
> in
> /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.|
> |The product interface org.apache.sling.api.request.RequestPathInfo annotated
> with @ProviderType should not be implemented by custom code. Detected in
> org.apache.sling.servlethelpers.MockRequestPathInfo contained in
> /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.|
> |The product interface org.apache.sling.api.request.RequestProgressTracker
> annotated with @ProviderType should not be implemented by custom code.
> Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker
> contained in
> /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.|
> |The product interface org.apache.sling.api.SlingHttpServletRequest annotated
> with @ProviderType should not be implemented by custom code. Detected in
> org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in
> /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.|
> |The product interface org.apache.sling.api.SlingHttpServletResponse
> annotated with @ProviderType should not be implemented by custom code.
> Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse
> contained in
> /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.|
> |The product interface org.apache.sling.api.resource.Resource annotated with
> @ProviderType should not be implemented by custom code. Detected in
> org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource
> contained in
> /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.|
> Perhaps there needs to be Wrappers for all these classes that are
> @ConsumerTypes?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421976#comment-17421976 ] Carsten Ziegeler commented on SLING-10840: -- [~empire29] If any application (large CMS?) is using the bundle, that is fine as that application provides the implementation anyway. However, I would still suggest against doing this, but that's more a question of style then. For users of an application, this is different. As soon as you use this bundle, you are subject to breakage. I'm fine with changing the documentation around the bundle and if SLING-8742 solves the use case, we have a much better solution anyway > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421974#comment-17421974 ] Robert Munteanu commented on SLING-10840: - I guess what you actually want then is SLING-8742 :-) > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421821#comment-17421821 ] David Gonzalez commented on SLING-10840: I'm trying to conditionally invoke an internal sling endpoint from an incoming request, and I need to change the extension - which RequestDispatcherOptions doesn't let you do AFAIK. I believe you need to overload the RequestPathInfo for the sling forward/includes to resolve properly. Unless someone changes the Sling docs this bundle is positioned to be used at runtime as well - which is why i tried :) (... and which certain large CMS's happen to do too) > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421163#comment-17421163 ] Carsten Ziegeler commented on SLING-10840: -- [~royteeuwen] As [~justinedelson] points out, for every use case where you already have a request and response object you can use SlingHttpServletRequestWrapper and SlingHttpServletResponseWrapper. In fact, it is more than recommended to use those instead of these mock objects as otherwise you might break further processing. [~empire29] What is exactly the use case of using this bundle in production? > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420975#comment-17420975 ] Justin Edelson commented on SLING-10840: bq. But still it is a very common use-case in real world applications. For example when rewriting response in a java Filter. Isn't this a use case where you would use a wrapper per [~cziegeler]'s comment? > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420967#comment-17420967 ] Roy Teeuwen commented on SLING-10840: - But still it is a very common use-case in real world applications. For example when rewriting response in a java Filter. Not having this possibility would block us from upgrading to a situation where you would have these validators ;) > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420823#comment-17420823 ] Carsten Ziegeler commented on SLING-10840: -- Most of the issues can be fixed by selecting the right base class, for example the response / request wrappers or AbstractResource > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420808#comment-17420808 ] Stefan Seifert commented on SLING-10840: this is a special case, and of course the whole servlet helpers bundle is about mock-implementing interfaces which are not intended to be implemented again. but this it not done by accident, but with a special purpose. maybe it is possible to allow-list this specific implementations / exclude it from the validator? > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420804#comment-17420804 ] David Gonzalez commented on SLING-10840: /cc [~cziegeler], [~sseifert], [~kwin] > Sling Servlet Helpers implements @ProviderType interfaces > - > > Key: SLING-10840 > URL: https://issues.apache.org/jira/browse/SLING-10840 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Servlet Helpers 1.4.2 >Reporter: David Gonzalez >Priority: Major > > When using the Sling Servlet Helpers bundle/API, code quality scans detect > that implentations in the Sling Servlet Helpers bundle implement > @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here > are some fo the examples (though probably not exhaustive) I found when > attempting to use ths Servlet Helpers library. > > |The product interface org.apache.sling.api.request.RequestParameter > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestParameterMap > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained > in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestPathInfo annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockRequestPathInfo contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.request.RequestProgressTracker > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletRequest annotated > with @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.SlingHttpServletResponse > annotated with @ProviderType should not be implemented by custom code. > Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > |The product interface org.apache.sling.api.resource.Resource annotated with > @ProviderType should not be implemented by custom code. Detected in > org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource > contained in > /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.| > Perhaps there needs to be Wrappers for all these classes that are > @ConsumerTypes? -- This message was sent by Atlassian Jira (v8.3.4#803005)
