[jira] [Commented] (SLING-11797) Log Jobs Added with No Assigned Topology Capability at Info

2023-03-11 Thread Dan Klco (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17699270#comment-17699270
 ] 

Dan Klco commented on SLING-11797:
--

PR opened: https://github.com/apache/sling-org-apache-sling-event/pull/25

> Log Jobs Added with No Assigned Topology Capability at Info
> ---
>
> Key: SLING-11797
> URL: https://issues.apache.org/jira/browse/SLING-11797
> Project: Sling
>  Issue Type: Bug
>  Components: Event
>Affects Versions: Event 4.3.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: Event 4.3.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When creating a job where the topology does not provide a capability for the 
> topic, the JobManagerImpl logs the following message at the DEBUG level:
> {quote}Persisting job {} into queue {}{quote}
>  
> This makes it challenging to identify/diagnose issues with jobs not being 
> assigned as: * It requires enabling debug logging on the JobManagerImpl which 
> can be quite verbose, especially under load
>  * Since most production instances do not run with DEBUG, these situations 
> will not be available in logs
>  * The log message does not indicate that this job will not be immediately 
> assigned to be processed
> Instead, the JobManagerImpl should log a message at least at INFO level which 
> indicates that the Job being persisted does not have an assigned target.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-11797) Log Jobs Added with No Assigned Topology Capability at Info

2023-03-11 Thread Dan Klco (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17699241#comment-17699241
 ] 

Dan Klco commented on SLING-11797:
--

Acknowledged. The intent isn't to use this for log monitoring, but to aid in 
debugging issues in a running environment. Starting a job without an execution 
target available isn't _necessarily_ a problem but it's an event you may want 
to be aware happened in a running environment, thus INFO seems more appropriate 
than DEBUG.

> Log Jobs Added with No Assigned Topology Capability at Info
> ---
>
> Key: SLING-11797
> URL: https://issues.apache.org/jira/browse/SLING-11797
> Project: Sling
>  Issue Type: Bug
>  Components: Event
>Affects Versions: Event 4.3.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: Event 4.3.8
>
>
> When creating a job where the topology does not provide a capability for the 
> topic, the JobManagerImpl logs the following message at the DEBUG level:
> {quote}Persisting job {} into queue {}{quote}
>  
> This makes it challenging to identify/diagnose issues with jobs not being 
> assigned as: * It requires enabling debug logging on the JobManagerImpl which 
> can be quite verbose, especially under load
>  * Since most production instances do not run with DEBUG, these situations 
> will not be available in logs
>  * The log message does not indicate that this job will not be immediately 
> assigned to be processed
> Instead, the JobManagerImpl should log a message at least at INFO level which 
> indicates that the Job being persisted does not have an assigned target.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-11797) Log Jobs Added with No Assigned Topology Capability at Info

2023-03-07 Thread Carsten Ziegeler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697505#comment-17697505
 ] 

Carsten Ziegeler commented on SLING-11797:
--

I'm not against changing the log level, but keep in mind that this can be 
misleading. I wouldn't use the log for monitoring, but rather look for 
unassigned jobs through the API

> Log Jobs Added with No Assigned Topology Capability at Info
> ---
>
> Key: SLING-11797
> URL: https://issues.apache.org/jira/browse/SLING-11797
> Project: Sling
>  Issue Type: Bug
>  Components: Event
>Affects Versions: Event 4.3.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: Event 4.3.8
>
>
> When creating a job where the topology does not provide a capability for the 
> topic, the JobManagerImpl logs the following message at the DEBUG level:
> {quote}Persisting job {} into queue {}{quote}
>  
> This makes it challenging to identify/diagnose issues with jobs not being 
> assigned as: * It requires enabling debug logging on the JobManagerImpl which 
> can be quite verbose, especially under load
>  * Since most production instances do not run with DEBUG, these situations 
> will not be available in logs
>  * The log message does not indicate that this job will not be immediately 
> assigned to be processed
> Instead, the JobManagerImpl should log a message at least at INFO level which 
> indicates that the Job being persisted does not have an assigned target.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)