[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2024-07-16 Thread Eric Norman (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866458#comment-17866458
 ] 

Eric Norman commented on SLING-11906:
-

[~reschke] Probably not easier since the provider class name provided by that 
slf4j.provider system property also has to be visible to the slf4j.api bundle 
classloader.  The classloading workaround is one of the problems that the 
serviceloader mediator is solving.
 

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2024-07-16 Thread Julian Reschke (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866418#comment-17866418
 ] 

Julian Reschke commented on SLING-11906:


FYI, from :

bq. since 2.0.9 You can specify the provider class explicitly via the 
"slf4j.provider" system property. This bypasses the service loader mechanism 
for finding providers and may shorten SLF4J initialization.

Maybe that makes things easiert?

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2024-06-05 Thread Robert Munteanu (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852420#comment-17852420
 ] 

Robert Munteanu commented on SLING-11906:
-

[~reschke] - we don't have any other ticket besides this one.

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2024-05-31 Thread Julian Reschke (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851052#comment-17851052
 ] 

Julian Reschke commented on SLING-11906:


FYI; removal of slf4j.event in Oak is in progress (see OAK-10339) and will be 
done in ca. 10 weeks (two public releases). I still see 
org.apache.sling:org.apache.sling.commons.log:5.5.0 using slf4j.spi and 
slf4j.event in public APIs; do we have a ticket for that? 

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2024-01-24 Thread Robert Munteanu (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810482#comment-17810482
 ] 

Robert Munteanu commented on SLING-11906:
-

[~kwin] - perhaps upgrading logback to 1.3.x. or 1.4.x in Commons Log will 
remove the need to import the old package; did not have the time to investigate.

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2024-01-24 Thread Julian Reschke (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810479#comment-17810479
 ] 

Julian Reschke commented on SLING-11906:


Awesome. Thanks.

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2024-01-24 Thread Julian Reschke (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810475#comment-17810475
 ] 

Julian Reschke commented on SLING-11906:


[~kwin] - IIUC, Oak has similar problems wrt using SLF packages it should not? 
Could you open an issue over there once we fully understand what needs to be 
done?

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2024-01-24 Thread Konrad Windszus (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810474#comment-17810474
 ] 

Konrad Windszus commented on SLING-11906:
-

The fix in SLF4J 2.0.11 only exports {{org.slf4j.helpers}} in a backwards 
compatible way. I think we should get rid of imports towards {{org.sl4j.event}} 
as that was IMHO never devised as stable API (but only supposed to be used 
internally).

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2024-01-24 Thread Robert Munteanu (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810441#comment-17810441
 ] 

Robert Munteanu commented on SLING-11906:
-

For the record, when trying to upgrade to slf4j 2.0.11 the following errors 
come up

- Oak bundles importing org.slf4j.event with narrow range
- Sling commons.log importing org.slf4j.event with narrow range
- missing serviceloader mediator capability

{noformat}
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-lucene:1.60.0: Bundle is 
importing package org.slf4j.event;version=[1.7,2) with start order 15 but no 
bundle is exporting these for that start order in the required version range.
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-store-document:1.60.0: 
Bundle is importing package org.slf4j.event;version=[1.7,2) with start order 15 
but no bundle is exporting these for that start order in the required version 
range.
[ERROR] [bundle-packages] org.apache.sling:org.apache.sling.commons.log:5.4.2: 
Bundle is importing packages [Package org.slf4j.event;version=[1.7,2), Package 
org.slf4j.spi;version=[1.7,2)] with start order 1 but no bundle is exporting 
these for that start order in the required version range.
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-commons:1.60.0: Bundle is 
importing package org.slf4j.event;version=[1.7,2) with start order 15 but no 
bundle is exporting these for that start order in the required version range.
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-core:1.60.0: Bundle is 
importing package org.slf4j.event;version=[1.7,2) with start order 15 but no 
bundle is exporting these for that start order in the required version range.
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-query-spi:1.60.0: Bundle is 
importing package org.slf4j.event;version=[1.7,2) with start order 15 but no 
bundle is exporting these for that start order in the required version range.
[ERROR] [requirements-capabilities] org.slf4j:slf4j-api:2.0.11: Artifact 
org.slf4j:slf4j-api:2.0.11 requires [slf4j.api/2.0.11] osgi.serviceloader; 
osgi.serviceloader=org.slf4j.spi.SLF4JServiceProvider; 
filter:="(osgi.serviceloader=org.slf4j.spi.SLF4JServiceProvider)" in start 
level 1 but no artifact is providing a matching capability in this start level.
{noformat}

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2023-10-04 Thread Konrad Windszus (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771950#comment-17771950
 ] 

Konrad Windszus commented on SLING-11906:
-

I tried to prepare an upstream fix, but ran into 
https://github.com/bndtools/bnd/issues/5789.

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2023-07-05 Thread Konrad Windszus (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740424#comment-17740424
 ] 

Konrad Windszus commented on SLING-11906:
-

There are some hints in 
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/issues/588
 on how Eclipse managed to update.

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.0.7 (and logback v1.4.7)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2023-07-05 Thread Konrad Windszus (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740111#comment-17740111
 ] 

Konrad Windszus commented on SLING-11906:
-

Seems that was a deliberate decision from SLF4J, compare with 
https://jira.qos.ch/browse/SLF4J-579?focusedId=21673&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-21673:
Maybe if we have a convincing use case for using the other packages outside of 
logging backends we can adjust that.

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.0.7 (and logback v1.4.7)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2023-06-14 Thread Eric Norman (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732661#comment-17732661
 ] 

Eric Norman commented on SLING-11906:
-

[~rombert] Thanks for those additional data points.  I guess we will need some 
additional experimentation to see if it would be safe for the slf4j-api 2.0.x 
bundle to export those additional org.slf4j.helpers and org.slf4j.event 
packages as well.

 

The required serviceloader capabilities would be provided by the new 1.3+ 
logback library so I was already aware of that one.  SLF4j-api 2.x now uses the 
ServiceLoader mechanism to find the logging implementation instead of their old 
1.x style "static binding" technique.  So this also means a serviceloader 
mediator must exist in the OSGi runtime for it to work.

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.0.7 (and logback v1.4.7)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2023-06-14 Thread Robert Munteanu (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732425#comment-17732425
 ] 

Robert Munteanu commented on SLING-11906:
-

As a data point, we have a renovate PR that updates the slf4j-api version in 
the starter ( https://github.com/apache/sling-org-apache-sling-starter/pull/180 
):

{noformat}
diff --git a/pom.xml b/pom.xml
index 0955dd00..6c37dae4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -48,7 +48,7 @@
 
 1.52.0
 
-1.7.36
+2.0.7
 
 4.2.1
 
{noformat}

It looks like there is at least some fallout, wih many bundles failing to 
resolve

{noformat}[ERROR] [bundle-packages] 
org.apache.jackrabbit:oak-store-document:1.52.0: Bundle is importing packages 
[Package org.slf4j.helpers;version=[1.7,2), Package 
org.slf4j.event;version=[1.7,2)] with start order 15 but no bundle is exporting 
these for that start order in the required version range.
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-commons:1.52.0: Bundle is 
importing package org.slf4j.event;version=[1.7,2) with start order 15 but no 
bundle is exporting these for that start order in the required version range.
[ERROR] [bundle-packages] 
org.apache.felix:org.apache.felix.healthcheck.api:2.0.4: Bundle is importing 
package org.slf4j.helpers;version=[1.7,2) with start order 5 but no bundle is 
exporting these for that start order in the required version range.
[ERROR] [bundle-packages] org.apache.sling:org.apache.sling.hc.api:1.0.4: 
Bundle is importing package org.slf4j.helpers;version=[1.7,2) with start order 
20 but no bundle is exporting these for that start order in the required 
version range.
[ERROR] [bundle-packages] org.apache.sling:org.apache.sling.commons.log:5.4.2: 
Bundle is importing packages [Package org.slf4j.event;version=[1.7,2), Package 
org.slf4j.helpers;version=[1.7,2), Package org.slf4j.spi;version=[1.7,2)] with 
start order 1 but no bundle is exporting these for that start order in the 
required version range.
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-query-spi:1.52.0: Bundle is 
importing package org.slf4j.event;version=[1.7,2) with start order 15 but no 
bundle is exporting these for that start order in the required version range.
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-core:1.52.0: Bundle is 
importing package org.slf4j.event;version=[1.7,2) with start order 15 but no 
bundle is exporting these for that start order in the required version range.
[ERROR] [bundle-packages] org.apache.sling:org.apache.sling.xss:2.2.20: Bundle 
is importing package org.slf4j.helpers;version=[1.7,2) with start order 20 but 
no bundle is exporting these for that start order in the required version range.
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-lucene:1.52.0: Bundle is 
importing package org.slf4j.event;version=[1.7,2) with start order 15 but no 
bundle is exporting these for that start order in the required version range.
{noformat}

and an error that probably needs to be addressed in the commons.log bundle

{noformat}
[ERROR] [requirements-capabilities] org.slf4j:slf4j-api:2.0.7: Artifact 
org.slf4j:slf4j-api:2.0.7 requires [slf4j.api/2.0.7] osgi.serviceloader; 
osgi.serviceloader=org.slf4j.spi.SLF4JServiceProvider; 
filter:="(osgi.serviceloader=org.slf4j.spi.SLF4JServiceProvider)" in start 
level 1 but no artifact is providing a matching capability in this start level.
{noformat}

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.0.7 (and logback v1.4.7)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2023-06-13 Thread Eric Norman (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732228#comment-17732228
 ] 

Eric Norman commented on SLING-11906:
-

[~rombert] yes, the logback packages are exported, but migration to the 1.4.7 
version doesn't appear to involve a change to the major version of the exported 
packages.  So I would expect that consumer bundles that are using the typical 
version range should still resolve.  I'm not sure about full binary 
compatibility since it doesn't look like logback is utilizing the semantic 
versioning best practices.

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.0.7 (and logback v1.4.7)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2023-06-13 Thread Robert Munteanu (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732009#comment-17732009
 ] 

Robert Munteanu commented on SLING-11906:
-

[~enorman] - ah, I scanned the description but missed the part where sl4j 2.0 
exports both versions. I see that the o.a.s.commons.log bundle exports Logback 
as well ( 
https://github.com/apache/sling-org-apache-sling-commons-log/blob/d88701405509a294c99aaf7211c7f4158feba860/bnd.bnd#L27-L28C38
 ) but I expect fewer consumers to be bound to it.

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.0.7 (and logback v1.4.7)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2023-06-12 Thread Eric Norman (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731684#comment-17731684
 ] 

Eric Norman commented on SLING-11906:
-

[~rombert] Yes, that is what I was implying in the last sentence of the 
description.  Specifically slf4j-api 2.0.7 has the changes from 
[https://github.com/qos-ch/slf4j/commit/b363bb31ed08d3ad9761ccdca5e51bb2327c3287]
 that should make that possible for slf4j-api 1.x consumers to still satisfy 
their requirements.

 

Unfortunately, after some quick experimenting, it looks like swapping out the 
slf4j-api with the 2.0.7 version is like the easy part.  Updating to the latest 
version of the embedded logback library appears to have incompatible changes 
(logback.version 1.2.10 vs 1.4.7) that impact what was done in the 
o.a.sling.commons.log bundle.  I'm not familiar with the code in the 
o.a.sling.commons.log bundle so unless someone else wants to volunteer to do 
the refactoring then I would need to try to find some time to understand, 
unwind and fix what that code is doing.  After my first attempt at refactoring 
I can get it to compile, but there are many integration tests that fail.

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.0.7 (and logback v1.4.7)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

2023-06-12 Thread Robert Munteanu (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731620#comment-17731620
 ] 

Robert Munteanu commented on SLING-11906:
-

I think we should have a way of supporting slf4j 1.x and 2.x at the same time. 
We probably have lots of consumers bound to the old version of the slf4j api.

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.0.7 (and logback v1.4.7)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)