[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822513#comment-17822513
]
Konrad Windszus commented on SLING-12246:
-
I added some more tests in
https://github.com/apache/sling-org-apache-sling-jcr-resource/commit/7660582019bc8b4b0fdda73bdddbde77262159e6
(without modifying the behaviour) to verify which events are currently sent
for the different move operations (including the edge case outlined at
SLING-12245). Since there is no functional change needed in the context of this
ticket closing this as "invalid".
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815320#comment-17815320
]
Konrad Windszus commented on SLING-12246:
-
Indeed {{Session.move()}} always emits "NODE_DELETE" and "NODE_ADDED" for the
root paths in Oak. There is no event currently emitted for
{{Node.orderBefore(...)}} (only a "NODE_MOVED") is sent for that operation).
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814722#comment-17814722
]
Carsten Ziegeler commented on SLING-12246:
--
Sure. In theory there should be no need to handle a move event. But if there
are cases where no added/removed combo is sent, then this should probably be
fixed (best in Oak).
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814718#comment-17814718
]
Konrad Windszus commented on SLING-12246:
-
Let me verify with an IT, but I think at least rename operations (i.e. moves
not changing the level nor parent node) do not emit NODE_ADDED and NODE_REMOVED.
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814717#comment-17814717
]
Carsten Ziegeler commented on SLING-12246:
--
I read there "NODE_MOVED event, NODE_ADDED event for the root of the sub-tree
only, NODE_REMOVED event for the root of the sub-tree only"
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814716#comment-17814716
]
Konrad Windszus commented on SLING-12246:
-
bq. event as a add/remove events were sent in addition anyway.
That contradicts the description in
https://jackrabbit.apache.org/oak/docs/differences.html#observation and also I
have at least one use case which was not working correctly: SLING-12245.
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814714#comment-17814714
]
Carsten Ziegeler commented on SLING-12246:
--
If I remember correctly, we skipped implementing explicit support for the
"moved" event as a add/remove events were sent in addition anyway.
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
