[jira] [Commented] (SLING-2110) Test classes should be packaged and deployed as a "-tests.jar" artifact to enable reuse of *TestsBase classes in other projects
[ https://issues.apache.org/jira/browse/SLING-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061405#comment-13061405 ] Mark Adamcin commented on SLING-2110: - I think that would be sufficient. > Test classes should be packaged and deployed as a "-tests.jar" artifact to > enable reuse of *TestsBase classes in other projects > --- > > Key: SLING-2110 > URL: https://issues.apache.org/jira/browse/SLING-2110 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Sample Integration Tests 1.0.6 >Reporter: Mark Adamcin >Priority: Minor > Fix For: Sample Integration Tests 1.0.8 > > Attachments: integrationtests-jar_test_jar.patch > > > The Sample Integration Tests module > (org.apache.sling.testing.samples.integrationtests) contains a couple > convenient base test classes (ServerSideTestsBase and > SlingServerSideTestsBase) that would be useful to extend when writing > integration tests for other projects. However, they are not deployed in the > primary artifact and so their original source files must be copied into new > projects when they are set up. > It would be more convenient if a "jar:tests-jar" goal were added to the > package phase so that a tests jar will be deployed to the public repository > during releases. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2110) Test classes should be packaged and deployed as a "-tests.jar" artifact to enable reuse of *TestsBase classes in other projects
[ https://issues.apache.org/jira/browse/SLING-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061277#comment-13061277 ] Bertrand Delacretaz commented on SLING-2110: My idea when creating those samples is that the base test classes are sufficiently simple to be copied and pasted in people's own projects. The actual logic that they provide comes (or should come) from the org.apache.sling.testing.tools module. IMO the only classes that might be reusable are: org.apache.sling.testing.samples.integrationtests.serverside.ServerSideTestsBase org.apache.sling.testing.samples.integrationtests.serverside.sling.SlingServerSideTestsBase which don't contain much in terms of logic, so copy/paste is fine IMO. Mark, do you agree with the this? If yes I'll just document this recommendation to copy/paste at http://sling.apache.org/site/sling-testing-tools.html > Test classes should be packaged and deployed as a "-tests.jar" artifact to > enable reuse of *TestsBase classes in other projects > --- > > Key: SLING-2110 > URL: https://issues.apache.org/jira/browse/SLING-2110 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Sample Integration Tests 1.0.6 >Reporter: Mark Adamcin >Priority: Minor > Fix For: Sample Integration Tests 1.0.8 > > Attachments: integrationtests-jar_test_jar.patch > > > The Sample Integration Tests module > (org.apache.sling.testing.samples.integrationtests) contains a couple > convenient base test classes (ServerSideTestsBase and > SlingServerSideTestsBase) that would be useful to extend when writing > integration tests for other projects. However, they are not deployed in the > primary artifact and so their original source files must be copied into new > projects when they are set up. > It would be more convenient if a "jar:tests-jar" goal were added to the > package phase so that a tests jar will be deployed to the public repository > during releases. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2110) Test classes should be packaged and deployed as a "-tests.jar" artifact to enable reuse of *TestsBase classes in other projects
[ https://issues.apache.org/jira/browse/SLING-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058801#comment-13058801 ] Mark Adamcin commented on SLING-2110: - I see what you mean. I got confused by the empty main jar artifact that didn't contain the base classes and decided to solve the problem by wrapping up the test classes into their own artifact. Do you think it be more ideal to create a test-sources artifact instead of the tests artifact? That would seem to more closely follow how the other sample junit modules are being deployed. > Test classes should be packaged and deployed as a "-tests.jar" artifact to > enable reuse of *TestsBase classes in other projects > --- > > Key: SLING-2110 > URL: https://issues.apache.org/jira/browse/SLING-2110 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Sample Integration Tests 1.0.6 >Reporter: Mark Adamcin >Priority: Minor > Fix For: Sample Integration Tests 1.0.8 > > Attachments: integrationtests-jar_test_jar.patch > > > The Sample Integration Tests module > (org.apache.sling.testing.samples.integrationtests) contains a couple > convenient base test classes (ServerSideTestsBase and > SlingServerSideTestsBase) that would be useful to extend when writing > integration tests for other projects. However, they are not deployed in the > primary artifact and so their original source files must be copied into new > projects when they are set up. > It would be more convenient if a "jar:tests-jar" goal were added to the > package phase so that a tests jar will be deployed to the public repository > during releases. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2110) Test classes should be packaged and deployed as a "-tests.jar" artifact to enable reuse of *TestsBase classes in other projects
[ https://issues.apache.org/jira/browse/SLING-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057570#comment-13057570 ] Justin Edelson commented on SLING-2110: --- Just my 2cents, but if these test base classes are going to be consumed outside of the samples module, they should be in a module which isn't named "samples". > Test classes should be packaged and deployed as a "-tests.jar" artifact to > enable reuse of *TestsBase classes in other projects > --- > > Key: SLING-2110 > URL: https://issues.apache.org/jira/browse/SLING-2110 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Sample Integration Tests 1.0.6 >Reporter: Mark Adamcin >Priority: Minor > Fix For: Sample Integration Tests 1.0.8 > > Attachments: integrationtests-jar_test_jar.patch > > > The Sample Integration Tests module > (org.apache.sling.testing.samples.integrationtests) contains a couple > convenient base test classes (ServerSideTestsBase and > SlingServerSideTestsBase) that would be useful to extend when writing > integration tests for other projects. However, they are not deployed in the > primary artifact and so their original source files must be copied into new > projects when they are set up. > It would be more convenient if a "jar:tests-jar" goal were added to the > package phase so that a tests jar will be deployed to the public repository > during releases. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
